SRL Archive - RS3 Combat/Fighting

99s reported:
[INDENT]I gave up tracking them! Here were the realy ones:
@nutta124 @Mantasx27 @uhit @everve @Note @jarofhearts @Cyanempire @ayzee5793
[/INDENT]

Features:

[INDENT]

• Autodetects and autocolors NPCs
• Motion detection mode
• Left or right click support to initiate fight.
• Food support. Will log out before letting you die.
• Autoupdater
• Antiban
• Basic break system so you can set time periods for regular breaks.
• On-screen and debug window progress reports.
• Pre-targets next npc while fighting

[/INDENT]

Requirements:

[INDENT]You need a functional setup with current software (Simba 1.x, SMART 8.X, SRL-6)

You need to use the player manager to add your character to a players file. The player manager is on the simba menu under srl->player manager.
[/INDENT]

Installing:

[INDENT]Download the installer at the bottom of this post.

Run this installer script and it will download the most current package. The installer will delete itself when done. You will end up with bonsaiFighter.simba in your SIMBADIR/scripts folder. It will also install library files in SIMBADIR/includes/bonsai[/INDENT]

EOC Abilities:

[INDENT]The player form has a field manualAbilities. My current recommendation is to set this to False and use the Runescape combat mode "revolution". This will automatically use your abilities without the script needing to do anything.

If you set manualAbilities to True the script will use abilities on your visible ability bar. It uses the first 9 slots from RIGHT to LEFT. If you place basic skills on the left, threshold in the middle, and ultimate on the right, it will use the ultimate and threshold when they are ready.[/INDENT]

In-game setup:

[INDENT]Make sure your interface settings have Always show target information checked.

Locate your character in the room you will be fighting in with a weapon in hand. You should be zoomed all the way out (smallest view of yourself).

If you want food support, have the food in your inventory. Set the food to one of the open taskbar slots. When you run the script, make sure the food key is set to the key to activate this slot.[/indent]

Example setup:

[INDENT]
Note:

• A: If you grab the key you can move this up here out of the way. It helps keep the screen clear.
• B: Put your XP thing here. I don't use it yet but many scripts do and I will at some point
• C: Get this button out of the way
• D: Notice the food is on the '=' key

[/indent]

You can use the fighter as an include so you can make your own custom fighter/looter!

[INDENT]Here is a sample that fights a few crawling corpses. You need a color file from the fighter that matches the name on the npc in the code.

program corpseTorso;
{$DEFINE SMART}
{$include_once srl-6/srl.simba}
{$include_once bonsai/blCombat.simba}

var
   ccTorso: Tnpc;
   i: integer;
   
begin
   SetupSRL();
   ccTorso.init('crawling-corpse-torso', true);

   for i := 0 to 5 do
   begin
      combatMgr.attack(ccTorso, true {wait until dead},
         nil {use default foodhandler}, MOUSE_RIGHT);
      sleep(5000);
   end;
end.

[/INDENT]

Known bugs / issues:

[INDENT]

• Be patient with the coloring. It takes time to decide :)
• You can't fight NPCs that are over your level
• If it can't find enough colors to start fighting, try zooming in a little to get more detail. Remove the (bad) color file from your early attempts.

[/INDENT]

Improvements to be made:

[INDENT]

• CTS2 color mode
• Form. Needs tabs. Human style breaking needs to be put in.
• Many others…

[/INDENT]

IMPORTANT NOTE:

[indent]Since the script will autoupdate your changes can get overwritten. The updater will save previous versions to FILENAME.simba.bak

If you don't migrate your changes before two updates you will lose them!! It's a good idea to save your entries somewhere.
[/INDENT]

Progress reported:

[INDENT]

////////////////////////////////////////////////////////////////////////////////////////////////////
////////////////////////////////////////       Bonsai       ////////////////////////////////////////
////////////////////////////////////////       Fighter      ////////////////////////////////////////
////////////////////////////////////////       _______      ////////////////////////////////////////
//////////                                                                                //////////
//////////  Script runtime:                                                               //////////
//////////       15 hr 52 min 54 sec(Total) 15 hr 52 min 54 sec(Active) 0 sec(Break)      //////////
//////////                                                                                //////////
////////////////////////////////////////        Kills       ////////////////////////////////////////
//////////                             Total        Per Hour    /Hour Active              //////////
//////////               NOTE          7,920          498.69          498.69              //////////
//////////                XP       2,727,648      171,747.59      171,747.59              //////////
//////////          Const XP         899,712       56,650.77       56,650.77              //////////
//////////                                                                                //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

[/INDENT]

Credits:

[INDENT] @Camel - StarPaint debug
@Cyanempire - Testing, User assistance, color files
@Clarity - Jsons, web lookup for XP[/indent]

Color files:
[INDENT]If google doesn't overload[/INDENT]

Installer:
[INDENT][ATTACH]27058[/ATTACH][/INDENT]

Fight Detectors

99% of the problems with the sctipt are that it is hard to detect some of the fight indicators. The script might be run anywhere with any background mess. Various game doodads covers things briefly. Other people might be running around, popups, etc. It's pretty difficult to find things that work in every case.

This script uses a variety of detectors and decides on fight status depending on the results. Here's what those icons mean when you are fighting:

• A - The gold lock on the enemy target popup
• B - The health bar over your head
• C - The adrenaline bar over your head
• D - The text area of the popup
• E - The yellow circle of someone attacking you (THIS ONE IS WORKING POORLY)
• F - The red circle around your target NPC
• G - Detects enemy death from the '0' in the popup. This never turns yellow since the program flashes them all red when this happens!!
• H - If this is green, the program thinks it is in a fight.

Here's another view if it helps. You can't see the gold lock, but you know what it is:


Every time an enemy dies you should see the icons flash red. If this is not happening the DTM needs to be worked on. The program works a lot worse if this one is not working correctly.

Congrats on the (re)release! :)

Nice work on this. Tested it out on giant rats… The color choice was less than ideal but once i corrected it with ACA everything ran smoothly. Once i got the colors correct left click worked reasonably well.

I'm having difficulty at flesh crawlers. It finds the first one just fine, and initiates combat but after that the screen just rotates and nothing else happens.

From: sharkbaits
I'm having difficulty at flesh crawlers. It finds the first one just fine, and initiates combat but after that the screen just rotates and nothing else happens.

I just retried them and it was finding them ok here. BTW, there's a bunch of people that bot those rooms. I noticed that when I was testing and just had a hard time finding somewhere quiet to try. I ran a 6 hour test in the northeast room a couple of weeks ago

Maybe the color isn't working well for you. You can use ACA to pick a new one and edit the entry in SIMBADIR/includes/bonsai/libnpc.simba (use CTS 2).

You can uncomment the {$DEFINE DEBUG_ON} line at the top of bonsaiFighter.simba and it will generate lots of info about what it's doing.

If it's spinning around that pretty much tells me that it's not finding anything to fight.

Did you set it to left click? If so, try it with right click.

Alright, I'll try the things you said. I originally was using right click but after that did the same thing I just started going through things I could change. Thank you for your input and I'll try it, it's very helpful.

I've been having some trouble getting the script to run for long periods of time…

I've turned on debug and the few lines i see after the program has stopped is
***** Health check returning 55 percent
***** Identified 1 potential targets, trying to initiate fight
***** Fight initiated
***** Logging player in

not sure what to make of that

edit:
oh and another crash but this one i found the cause

sometimes you will do something like hover over the buttons to switch the action bar. This covers up the health meter, so the script thinks you have a health% in the single digits.

From: freeplay
I've been having some trouble getting the script to run for long periods of time…

I've turned on debug and the few lines i see after the program has stopped is
***** Health check returning 55 percent
***** Identified 1 potential targets, trying to initiate fight
***** Fight initiated
***** Logging player in

not sure what to make of that

edit:
oh and another crash but this one i found the cause

sometimes you will do something like hover over the buttons to switch the action bar. This covers up the health meter, so the script thinks you have a health% in the single digits.

update posted. probably not perfect yet but should help with these issues.

hmmmm….

now the script ends as soon as my client loads, without trying to log in
not sure, maybe something is wrong with my setup

I probably borked it. I know I used the copy I posted the other day after I figured out why it was saying not logged in so much. But I may have used it only when already logged in.

Can't test today. I think I got banned, login not working. :fiery:

:( sorry about the ban.

Take your time with the fix.

Edit:
hey look at that it works, your code is fine.
I'm just an idiot who botched it by accident.

[Error] C:\Simba\Scripts\bonsaiFighterInstall.simba(35:11): Duplicate identifier 'TUPDATER' at line 35
Compiling failed.
Keeps giving me this error, I've tried scanning through and also commenting out different sections.Still keeps giving me this error. Not very sure what to do?

From: almost1monkey
[Error] C:\Simba\Scripts\bonsaiFighterInstall.simba(35:11): Duplicate identifier 'TUPDATER' at line 35
Compiling failed.
Keeps giving me this error, I've tried scanning through and also commenting out different sections.Still keeps giving me this error. Not very sure what to do?

I think you have your interpreter set to pascalscript. Use script->interpreter->lape

This is a script for SRL6/RS3 so it uses lape.

I'm planning on working on this some more this week. Made a couple of tweaks, added a secondary method of finding the in-fight popup. I need to level a new character so I'll try to get some hours on it before I post it. the other script I was working on got me spanked so I gotta chill out on that anyway :)

Yeah you're right, almost as soon as I posted it I thought "You're running this in pascal dummy" Thank you haha :) and that sounds awesome. I haven't done any scripting in years but I just recently started back up into RS and there aren't very many out there so I might as well.

It's actually getting hung up after logging my player in, it chooses the correct world and then just sits there still waiting for the login even though it's already done. Any suggestion? I've made sure to edit everything I needed to as well.

Not a proper answer but you could try logging in first then running the script.

If you uncomment the {$DEFINE DEBUG_ON} line at the top of bonsaiFighter.simba it will generate lots of output so it would be easier to see where it's bugging up. Sounds like the player.login() isn't returning from the symptoms.

If you search for disableSRLDebug you can change the 'true' to 'false' (or just uncomment it). Then you'll get SRL debug printing in the same window with the script debug.

From: bonsai
Not a proper answer but you could try logging in first then running the script.

If you uncomment the {$DEFINE DEBUG_ON} line at the top of bonsaiFighter.simba it will generate lots of output so it would be easier to see where it's bugging up. Sounds like the player.login() isn't returning from the symptoms.

If you search for disableSRLDebug you can change the 'true' to 'false' (or just uncomment it). Then you'll get SRL debug printing in the same window with the script debug.

Alright so I checked the debug and this is what it's giving me.
—- WARNING: Unknown color count: 777
—- HINT: Please report this issue in the SRL bugs section of the forum
—— Saving screenshot: unknown_login_count.png
—- Login response: One minute as passed…
—— All players inactive…
– TPlayer.login(): False
I'm not exactly sure what to do about that :duh:
I figured out what the issue was. It could not detect my player when I was down in the level with catablepons. I moved to flesh crawlers and its working now.

hey I need some help! When I run the script it stops by itself after opening SMART and I'm left with this:

Exception in Script: Runtime error: "Access violation" at line 394, column 33
The following bitmaps were not freed: [SMART Debug Image]
File[C:\Users\Sony\Desktop\Simba\Includes\SRL-6/logs/SRL log (20-11-13 at 12.11.10 AM).txt] has not been freed in the script, freeing it now.

I believe that line is setupSRL() so you're not even getting launched. You should have debug output in SIMBADIR/include/srl-6/logs

Are you able to run a simple shell?

program new;
{$DEFINE SMART}
{$i srl-6/srl.simba}

begin
  clearDebug();
  setupSRL();
end.

Why doesn't the script start? It just keep saying this?

—- Waiting up to 5 minutes for RS to load…
—- 1 minute(s) have passed, client is not ready yet
—- 2 minute(s) have passed, client is not ready yet
—- 3 minute(s) have passed, client is not ready yet

I already tried logging in so it doesn't have to log my account in. It seems it doesn't recognize SMART. But it already said this in Debug Box so..

——– Found 1 free client(s), attempting to pair to one…
———- smartSetAsTarget(): Succesfully set SMART[6272] as Simba's target
——– Succesfully paired to a existing client, SMART[6272]
—— smartPairToExistingClient(): result = true
—— Succesfully initialized via pairing to a previously spawned client
—- initSmart()
—— smartSetupDrawing(): Succesfully setup SMART drawing

http://i.imgur.com/KxnCrsV.png
I think the fact that the internal color data capture is disabled makes the S.M.A.R.T client non interactive? How do I enable it? Thanks!

From: gorouchan
Why doesn't the script start? It just keep saying this?

—- Waiting up to 5 minutes for RS to load…
—- 1 minute(s) have passed, client is not ready yet

I think the fact that the internal color data capture is disabled makes the S.M.A.R.T client non interactive?

SRL isn't recognizing that RS loaded in the smart window.

I would use the test script in the post above yours until it works ok.

Make sure you followed everything in the setup guide, expecially setting up your graphic settings like brightness, opengl, etc.

The internal color thing is normal. Here's what mine looks like on a good launch.

[ATTACH=CONFIG]22396[/ATTACH]

Do you have any idea why I keep re updating SRL and SPS?

I mean,
Update> Finished Updating> Close Simba> Reopen Simba> The SRL and SPS menus are gone from the tool bar. And this happened more than 5 times already. I kept updating and updating whenever I reopen Simba, the SRL and SPS menus are gone then when I try to enable them, there will be an update available. It's truly annoying. I believe the reason why the script doesn't work is because of this.

Your script seems to disable the SRL and SPS. O.o
http://i.imgur.com/DVdmQO0.png

The script isn't doing that to you. I'm not sure what would cause that but it's an issue with simba/extensions. I remember some posts about people losing extensions a couple of weeks ago. I don't remember seeing a solution on why it happened.

I did a new simba install on a clean machine yesterday and everything went ok. I did have to force a simba update the first time I ran it and say yes to the question about "you already have the current version, you sure you want to update".

My first 6+ hour run with this script :)


¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ ( )\ ) ) )
¸.·´¯`·.¸ ( )\ ) ( (()/( ( ( ( ( /( ( /( ( (
¸.·´¯`·.¸ )((_) ( ( ( ( /( )\ /(_)) )\ )\))( )\()) )\()) ))\ )(
¸.·´¯`·.¸ ((_)_ )\ )\ ) )\ )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\
¸.·´¯`·.¸ | _ ) ((_) _(_/( ((_)((_)_ (_) | |_ (_) (()(_)| |(_)| |_ (_)) ((_)
¸.·´¯`·.¸ | _ \/ _ \| ' \))(_-</ _` | | | | __| | |/ _` | | ' \ | _|/ -_) | '_|
¸.·´¯`·.¸ |___/\___/|_||_| /__/\__,_| |_| |_| |_|\__, | |_||_| \__|\___| |_|
¸.·´¯`·.¸ |___/
¸.·´¯`·.¸
¸.·´¯`·.¸ Script runtime:
¸.·´¯`·.¸ 6 hr 54 min 29 sec(Total) 6 hr 21 min 15 sec(Active) 33 min 13 sec(Break)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸ KILLS ¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸

It's been working wonderfully, I just tried to add a NPC and am unsure if I did it right
I added turoth to it
['Turoth', 63, 14.5, 9606336, 18.918, 19.525, 11.786,['ttack', 'uroth'], 45, 45, 170, _standardDTM, 120, -1, [5]]
like so. Picked the color with aca and used the rgb tol and xyz values. I was unsure which slot in that was meant for which so I guessed.

However I am now getting this error in the bonsaifighter script
Exception in Script: Expression is not a valid range at line 80, column 7 in file "C:\Simba\Includes\bonsai\libnpc.simba"
and
Exception in Script: Constant expression expected at line 80, column 7
in the libnc script
Any idea why?

From: almost1monkey
['Turoth', 63, 14.5, 9606336, 18.918, 19.525, 11.786,['ttack', 'uroth'], 45, 45, 170, _standardDTM, 120, -1, [5]]

In ACA, you need to change it to CTS 2. After choosing a bunch of the colors and making sure 'mark best color' highlights the npc good, you enter the best color data into the program. It's also a good idea to do this on a few different screenshots taken from different logins/worlds. They love to change these a little here and there so sometimes you think you pick a great color then it doesn't work :)

In your example you have the tolerance value (an integer) set to 18.918 (an extended).

From: freeplay
My first 6+ hour run with this script :)

Sweet! I've fallen behind on getting an update posted. I have a slightly newer version that I only ran for about 2 hours and I'm not sure it has enough value added to bother people with the update (have to recustomize, etc).

From: sharkbaits
I'm having difficulty at flesh crawlers. It finds the first one just fine, and initiates combat but after that the screen just rotates and nothing else happens.

I had this same problem with a fresh setup and it was because I had the XP counter display thing on.

That was blcoking the compass so the SRL function to rotate was not able to see it.

From: bonsai
Sweet! I've fallen behind on getting an update posted. I have a slightly newer version that I only ran for about 2 hours and I'm not sure it has enough value added to bother people with the update (have to recustomize, etc).

Yeah, i had to make some changes to the code once I found the cause of the logout bug. What's happening is that if the logout button is covered you're script using the srl script thinks that you are logged out. So you try to log in. log in uses the same method to check that you are logged out. it is also fooled because the log out button is still covered. Eventually the log in times out.

This becomes worse if you are eating food because, if the food bar is covered you send the mouse to a random point in the minimap(covering it covers the log out). The run energy icon is in the minimap. This increases the odds of a crash.

I just added extra if statements so that if its going to try to log in or quit it moves the mouse to a safe location first and rechecks.



yay! just finished my second run with these changes >>>>>>>>>>>>>>>>>6 hr 11 min 3 sec(Total)
I think i got all the bugs out :)

Exception in Script: Unknown declaration "smartClientWidth" at line 425, column 51 in file "C:\Simba\Includes\bonsai\libnpc.simba"

I'm also having the SPS and SRL problems when i open a script rather than opening simba itself. Reinstalling Simba doesn't fix it :(

I have no idea whats going on here or if its related to the above error…

I'm working on some code changes including storing user customization and NPCs in XML files so you won't lose your settings when there is a program update. It's a lot of code so I'll need to run it through some testing. Hope to post it up in the next few days.

In the mean time, the script works with the new fixed screen SRL. The only thing you need to do is bump down the pixel counts in SIMBADIR/includes/bonsai/libnpc.simba

The smaller screen results in fewer pixels matched. Cut the _pointMatch on your NPC to a half or third of the current value.

From: freeplay
Exception in Script: Unknown declaration "smartClientWidth" at line 425, column 51 in file "C:\Simba\Includes\bonsai\libnpc.simba"

I'm also having the SPS and SRL problems when i open a script rather than opening simba itself. Reinstalling Simba doesn't fix it :(

I have no idea whats going on here or if its related to the above error…

This doesn't sound good. I don't think its related to the script. Did you get working since this post?

From: bonsai
This doesn't sound good. I don't think its related to the script. Did you get working since this post?

Ahh… I changed the smart client dimensions to constants since they can no longer be changed.

From: Olly
Ahh… I changed the smart client dimensions to constants since they can no longer be changed.

I just used them; no changes. If he was getting unknown declaration it sounds like his SRL include was wonky. Or maybe a script without the {$DEFINE SMART}?

Actually i think he's trying to run the whole file, one of your includes.

I can get the fighting script to run if define
smartClientWidth=800;
smartClientHeight = 600;
In the libnpc include.

These are the just the values from smart.simba


On another note the size of the client is now different, so the interfaces don't fit nicely anymore. Do I just change the dimensions of the client using those variables in smart.simba? or is there a better way?

From: freeplay
I can get the fighting script to run if define
smartClientWidth=800;
smartClientHeight = 600;
In the libnpc include.

These are the just the values from smart.simba


On another note the size of the client is now different, so the interfaces don't fit nicely anymore. Do I just change the dimensions of the client using those variables in smart.simba? or is there a better way?

Did you see this announcement about the screen changes?

You need to set graphics to fixed mode and choose the "old school" interface preset.

And I don't know why you would have to set smartClientXXX manually, the script includes srl.simba which includes smart.simba. Which leaves me thinking you removed / commented {$DEFINE SMART} at the top of bonsaiFighter.simba

Program updates posted, the autoupdater should pick them up or just redownload/run the installer.

Your old changes will be saved in <filename>.bak so make sure you save(d) them.

See the OP for more information. I will try to work up a good post on adding new NPCs.

* Added xml files to store user preferences and user defined NPCs. This should help with future updates so your customizations don't get overwritten.
* Changed definitions / code to support the new fixed size screen.
* Modified logic on mouse moving / avoiding covering the health bar, etc. So far so good on my tests.
* Changed to use my object finding library, added support for multiple colors on NPC (not really tested yet). Multiple colors are inclusive (meaning both colors must be found within a certain distance or they will not be considered matches).
* Changed use of toATPA(width, height) to use of split(dist).
* ???

Let me know if you bump into any issues.

I'm getting this error now
—– getJavaPath()
——– Using parameters [http://world27.runescape.com/, f6972040531000897125]
——– Using plugins "OpenGL32.dll"
——– FATAL ERROR: Failed to spawn a SMART client
——– Freeing the minimap mask
****** bonsaiFighter: Script shutting down
I've made all necessary changes

From: almost1monkey
I'm getting this error now
—– getJavaPath()
——– Using parameters [http://world27.runescape.com/, f6972040531000897125]
——– Using plugins "OpenGL32.dll"
——– FATAL ERROR: Failed to spawn a SMART client
——– Freeing the minimap mask
****** bonsaiFighter: Script shutting down
I've made all necessary changes

Can you validate your software with something simple like this:

program new;
{$DEFINE SMART}
{$i srl-6/srl.simba}

begin
  ClearDebug();
  SetupSRL();
  players.setup(['TTnick'], 'characters');
  currentPlayer := 0;
  players[0].world := 33;
  players[currentPlayer].login();
//  wait(10000);
//  players[currentPlayer].logout();

end.

If that's ok, maybe post more of the log? I left debug on so there should probably be a bunch of stuff before that.

Here's mine from same section of debug

***** loadSettings: ..... mouseStyle           =right
***** loadSettings: ..... npc                  =autodetect
***** Next break time calculated, break in 132.418033333333 minutes
-- setupSRL()
---- Setting up SRL...
---- initSmart():
------ Attempting to pair to a previously spawned client
------ smartPairToExistingClient():
-------- Found no free clients to pair to
------ smartPairToExistingClient(): result = false
------ Attempting to spawn a new client..
------ smartCreateClient():
---------- smartGetParameters(): Succesfully grabbed paramters
-------- getJavaPath():
---------- Attempting to search for your Java path
---------- Found your java path @ C:\Program Files\Java\jre7\bin\java.exe
-------- getJavaPath()
-------- Using parameters [http://world27.runescape.com/, f47593253025683428]
-------- Using plugins "OpenGL32.dll"
-------- Succesfully spawned a client, attempting to target
---------- smartSetAsTarget(): Succesfully set SMART[5024] as Simba's target
------ smartCreateClient(): result = true
------ Succesfully initialized via spawning a new client
---- initSmart()
------ smartSetupDrawing(): Succesfully setup SMART drawing
---- Waiting up to 5 minutes for RS to load...
------ __setInputBoxes(): Set username and password boxes
---- Client is ready.
---- Setup SRL in 16630ms.
-- setupSRL(): True
***** Logging player in

I need help! For some reason my bot just sits and spins around then stops, spins around then stops over and over till it logs me off and wont fight anything! HELP MEH!

From: Gongarth
I need help! For some reason my bot just sits and spins around then stops, spins around then stops over and over till it logs me off and wont fight anything! HELP MEH!

Sorry about that! It's probably due to a bad color for that NPC. I had some problems myself this morning with a couple of them.

I'll have to spend some time gathering snapshots and recoloring.

You can try replacing the one you're working with. Run the ACA tool against a fresh screenshot (using CTS 2) and enter the "best color" data into the XML file entry for that NPC. The XML file is SIMBADIR/includes/bonsai/libnpcStandard.xml

On the positive side of things, I got EOC abilities working and started testing it.

I just got Simba and I have no idea what the ACA or CTS 2 is! Can you give a detailed quote I can read that shows me where these tools are and everything I have to set up to change the colors for the Skeleton and Warped bat npc's?(ACA CTS 2)

Start here: http://lmgtfy.com/?q=How+to+use+ACA+with+Simba

[PHP]¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ ( )\ ) ) )
¸.·´¯`·.¸ ( )\ ) ( (()/( ( ( ( ( /( ( /( ( (
¸.·´¯`·.¸ )((_) ( ( ( ( /( )\ /(_)) )\ )\))( )\()) )\()) ))\ )(
¸.·´¯`·.¸ ((_)_ )\ )\ ) )\ )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\
¸.·´¯`·.¸ | _ ) ((_) _(_/( ((_)((_)_ (_) | |_ (_) (()(_)| |(_)| |_ (_)) ((_)
¸.·´¯`·.¸ | _ \/ _ \| ' \))(_-</ _` | | | | __| | |/ _` | | ' \ | _|/ -_) | '_|
¸.·´¯`·.¸ |___/\___/|_||_| /__/\__,_| |_| |_| |_|\__, | |_||_| \__|\___| |_|
¸.·´¯`·.¸ |___/
¸.·´¯`·.¸
¸.·´¯`·.¸ Script runtime:
¸.·´¯`·.¸ 1 hr 39 min 13 sec(Total) 1 hr 39 min 13 sec(Active) 0 sec(Break)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸ KILLS ¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ Giant Spider
¸.·´¯`·.¸ 213(Killed) 129(per hour run) 129(per hour active)
¸.·´¯`·.¸ 18105(xp) 10948(xp per hour run) 10948(xp per hour active)
¸.·´¯`·.¸ 5964(const xp) 3606(const xp per hour run) 3606(const xp per hour active)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸[/PHP]
:)

From: Gongarth
I just got Simba and I have no idea what the ACA or CTS 2 is! Can you give a detailed quote I can read that shows me where these tools are and everything I have to set up to change the colors for the Skeleton and Warped bat npc's?(ACA CTS 2)

Start here: http://lmgtfy.com/?q=How+to+use+ACA+with+Simba

Just some suggestions:

Can you add Varrock Sewers: Deadly Red Spider? Because that's the main mob to kill from around lvl 70-99 :)
Giant spiders are OK but aren't great, and Deadly Red Spiders are really great for leveling.
Also: If you can add like a path to the bank to restock on food, that also would be awesome :)

Great script man!! ^_^

Hey I would really appreciate if anyone can get the colors! I've tried almost every mob and yet I have not been able to detect even one of them! Can someone somehow give the color inputs they are using for each mob? I would really appreciate it!!

From: Gongarth
Hey I would really appreciate if anyone can get the colors! I've tried almost every mob and yet I have not been able to detect even one of them! Can someone somehow give the color inputs they are using for each mob? I would really appreciate it!!

I'm working on recoloring today. I have to gather a lot of screenshots from multiple logins/computers so it's time consuming. I hope to post an update later today.

If you're having trouble with all npcs, I wonder if your graphic settings are very different than mine?

Can you check against this?
[ATTACH=CONFIG]22448[/ATTACH]

Does your screen look like this?
[ATTACH=CONFIG]22449[/ATTACH]

From: sparkyownage
Just some suggestions:

Can you add Varrock Sewers: Deadly Red Spider? Because that's the main mob to kill from around lvl 70-99 :)
Giant spiders are OK but aren't great, and Deadly Red Spiders are really great for leveling.
Also: If you can add like a path to the bank to restock on food, that also would be awesome :)

Great script man!! ^_^

I'll try to get them in the update expected today/tomorrow. I actually started gathering some NPCs from that area yesterday. There aren't too many places loaded with things to fight, I was wondering if it might end up with a lot of idle time.

I wouldn't expect a bank run capability (probably ever :) ). That's a lot, especially considering the number of places it would have to know how to walk back to.

It seems like you get the most XP fighting things that you can kill with one/two whacks, so if you're needing a lot of food I think there may be more effective things to fight.

[PHP]¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ ( )\ ) ) )
¸.·´¯`·.¸ ( )\ ) ( (()/( ( ( ( ( /( ( /( ( (
¸.·´¯`·.¸ )((_) ( ( ( ( /( )\ /(_)) )\ )\))( )\()) )\()) ))\ )(
¸.·´¯`·.¸ ((_)_ )\ )\ ) )\ )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\
¸.·´¯`·.¸ | _ ) ((_) _(_/( ((_)((_)_ (_) | |_ (_) (()(_)| |(_)| |_ (_)) ((_)
¸.·´¯`·.¸ | _ \/ _ \| ' \))(_-</ _` | | | | __| | |/ _` | | ' \ | _|/ -_) | '_|
¸.·´¯`·.¸ |___/\___/|_||_| /__/\__,_| |_| |_| |_|\__, | |_||_| \__|\___| |_|
¸.·´¯`·.¸ |___/
¸.·´¯`·.¸
¸.·´¯`·.¸ Script runtime:
¸.·´¯`·.¸ 1 hr 23 min 3 sec(Total) 1 hr 23 min 3 sec(Active) 0 sec(Break)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸ KILLS ¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ Giant Spider
¸.·´¯`·.¸ 185(Killed) 122(per hour run) 122(per hour active)
¸.·´¯`·.¸ 15725(xp) 10379(xp per hour run) 10379(xp per hour active)
¸.·´¯`·.¸ 5180(const xp) 3419(const xp per hour run) 3419(const xp per hour active)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸[/PHP]

First ever run!
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ ( )\ ) ) )
¸.·´¯`·.¸ ( )\ ) ( (()/( ( ( ( ( /( ( /( ( (
¸.·´¯`·.¸ )((_) ( ( ( ( /( )\ /(_)) )\ )\))( )\()) )\()) ))\ )(
¸.·´¯`·.¸ ((_)_ )\ )\ ) )\ )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\
¸.·´¯`·.¸ | _ ) ((_) _(_/( ((_)((_)_ (_) | |_ (_) (()(_)| |(_)| |_ (_)) ((_)
¸.·´¯`·.¸ | _ \/ _ \| ' \))(_-</ _` | | | | __| | |/ _` | | ' \ | _|/ -_) | '_|
¸.·´¯`·.¸ |___/\___/|_||_| /__/\__,_| |_| |_| |_|\__, | |_||_| \__|\___| |_|
¸.·´¯`·.¸ |___/
¸.·´¯`·.¸
¸.·´¯`·.¸ Script runtime:
¸.·´¯`·.¸ 42 min 25 sec(Total) 42 min 25 sec(Active) 0 sec(Break)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸ KILLS ¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ Giant Spider
¸.·´¯`·.¸ 75(Killed) 106(per hour run) 106(per hour active)
¸.·´¯`·.¸ 6375(xp) 9018(xp per hour run) 9018(xp per hour active)
¸.·´¯`·.¸ 2100(const xp) 2971(const xp per hour run) 2971(const xp per hour active)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸

i cant run this scrip for some reson here is what i get:
——————————————————-
– Checking libupdater.simba for updates.
– Version is current, no update needed.
——————————————————-
– Checking libobjfind.simba for updates.
– Version is current, no update needed.
——————————————————-
– Checking libnpc.simba for updates.
– Version is current, no update needed.
***** _loadNpc: Loaded NPC record, name=Warped Cockroach color1=3624328 xp=24.9
***** _loadNpc: Loaded NPC record, name=Corpse Spider color1=4681085 xp=25
***** _loadNpc: Loaded NPC record, name=Warped Fly color1=2372952 xp=27.6
***** _loadNpc: Loaded NPC record, name=Crawling corpse torso color1=4020577 xp=40
***** _loadNpc: Loaded NPC record, name=Warped rat color1=4610917 xp=41
***** _loadNpc: Loaded NPC record, name=Skeleton color1=10017521 xp=33.9
***** _loadNpc: Loaded NPC record, name=Warped bat color1=4868944 xp=48
***** _loadNpc: Loaded NPC record, name=Corpse archer color1=7496753 xp=50
***** _loadNpc: Loaded NPC record, name=Skoblin color1=5273221 xp=36.5
***** _loadNpc: Loaded NPC record, name=Corpse mage color1=5524794 xp=52
***** _loadNpc: Loaded NPC record, name=Troll brute color1=6188401 xp=30
***** _loadNpc: Loaded NPC record, name=Goblin color1=4218426 xp=34
***** _loadNpc: Loaded NPC record, name=Minotaur color1=8230551 xp=34
***** _loadNpc: Loaded NPC record, name=Wolf color1=10077376 xp=0
***** _loadNpc: Loaded NPC record, name=Zombie color1=4212039 xp=31
***** _loadNpc: Loaded NPC record, name=Flesh Crawler color1=1062466 xp=64.5
***** _loadNpc: Loaded NPC record, name=Giant Rat color1=2370095 xp=30
***** _loadNpc: Loaded NPC record, name=Giant Spider color1=463646 xp=85
***** _loadNpc: Loaded NPC record, name=Catablepon color1=4155702 xp=132
***** _loadNpc: Loaded NPC record, name=Scorpion color1=2835556 xp=44
***** _loadNpc: Loaded NPC record, name=Spider color1=3359297 xp=36
***** _loadNpc: Requested file does not exist [C:\Simba\Includes\bonsai\libnpcUser.xml]
——————————————————-
– Checking libitem.simba for updates.
– Version is current, no update needed.
——————————————————-
– Checking libtask.simba for updates.
– Version is current, no update needed.
——————————————————-
– Checking libtracker.simba for updates.
– Version is current, no update needed.
——————————————————-
– Checking libbreak.simba for updates.
– Version is current, no update needed.
——————————————————-
– Checking bonsaiFighter.simba for updates.
– Version is current, no update needed.
***** loadSettings: Loaded settings from [C:\Simba\Scripts\bonsaiFighterSettings.xml]
***** loadSettings: ….. playerName =SnakeDecay
***** loadSettings: ….. playerFile =SnakeDecay
***** loadSettings: ….. desiredWorld =0
***** loadSettings: ….. healthPercentToEatAt =50
***** loadSettings: ….. healthPercentToQuit =25
***** loadSettings: ….. cantFindNpcLoops =150
***** loadSettings: ….. averageSessionMin =120
***** loadSettings: ….. sessionVarianceMin =20
***** loadSettings: ….. averageBreakMin =17
***** loadSettings: ….. breakVarianceMin =5
***** loadSettings: ….. logoutWhenExiting =False
***** loadSettings: ….. mouseStyle =left
***** loadSettings: ….. npc =Warped Cockroach
***** Next break time calculated, break in 122.33485 minutes
– setupSRL()
—- Setting up SRL…
—- initSmart():
—— Attempting to pair to a previously spawned client
—— smartPairToExistingClient():
——– Found no free clients to pair to
—— smartPairToExistingClient(): result = false
—— Attempting to spawn a new client..
—— smartCreateClient():
———- smartGetParameters(): Succesfully grabbed paramters
——– getJavaPath():
———- Attempting to search for your Java path
———- Found your java path @ C:\Program Files (x86)\Java\jre7\bin\java.exe
——– getJavaPath()
——– Using parameters [http://world36.runescape.com/, f3083590200738444005]
——– Using plugins "OpenGL32.dll"
——– Succesfully spawned a client, attempting to target
———- smartSetAsTarget(): Succesfully set SMART[1316] as Simba's target
—— smartCreateClient(): result = true
—— Succesfully initialized via spawning a new client
—- initSmart()
—— smartSetupDrawing(): Succesfully setup SMART drawing
—- Waiting up to 5 minutes for RS to load…
—- 1 minute(s) have passed, client is not ready yet
—- 2 minute(s) have passed, client is not ready yet
—- 3 minute(s) have passed, client is not ready yet
—- 4 minute(s) have passed, client is not ready yet
—- Client is taking too long to load, terminating…
– setupSRL(): False
– Freeing the minimap mask
****** bonsaiFighter: Script shutting down
—- Saving screenshot: bonsaiFighter.png
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ ( )\ ) ) )
¸.·´¯`·.¸ ( )\ ) ( (()/( ( ( ( ( /( ( /( ( (
¸.·´¯`·.¸ )((_) ( ( ( ( /( )\ /(_)) )\ )\))( )\()) )\()) ))\ )(
¸.·´¯`·.¸ ((_)_ )\ )\ ) )\ )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\
¸.·´¯`·.¸ | _ ) ((_) _(_/( ((_)((_)_ (_) | |_ (_) (()(_)| |(_)| |_ (_)) ((_)
¸.·´¯`·.¸ | _ \/ _ \| ' \))(_-</ _` | | | | __| | |/ _` | | ' \ | _|/ -_) | '_|
¸.·´¯`·.¸ |___/\___/|_||_| /__/\__,_| |_| |_| |_|\__, | |_||_| \__|\___| |_|
¸.·´¯`·.¸ |___/
¸.·´¯`·.¸
¸.·´¯`·.¸ Script runtime:
¸.·´¯`·.¸ 5 min 7 sec(Total) 5 min 7 sec(Active) 0 sec(Break)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
– Succesfully freed SMART[1316]
Successfully executed.

i think it may have somthing to do with this:
—- Waiting up to 5 minutes for RS to load…
—- 1 minute(s) have passed, client is not ready yet
—- 2 minute(s) have passed, client is not ready yet
—- 3 minute(s) have passed, client is not ready yet
—- 4 minute(s) have passed, client is not ready yet
—- Client is taking too long to load, terminating…

Dont worry i have figered out what when wrong it was just a mistype in the players folder

From: bonsai


I wouldn't expect a bank run capability (probably ever :) ). That's a lot, especially considering the number of places it would have to know how to walk back to.

It seems like you get the most XP fighting things that you can kill with one/two whacks, so if you're needing a lot of food I think there may be more effective things to fight.

Not really alot of banks, one for stronghold of security, maybe edgeville bank or varrock west bank, and for lumbridge dungeon, lumbridge bank I think..? so a maximum of around 4 banks you would have to put paths for, though I don't know if that would be difficult to put in your script or not XD

From: sparkyownage
Not really alot of banks, one for stronghold of security, maybe edgeville bank or varrock west bank, and for lumbridge dungeon, lumbridge bank I think..? so a maximum of around 4 banks you would have to put paths for, though I don't know if that would be difficult to put in your script or not XD

One could put in a script to teleport to a city and then walk to bank…? I don't think that would be too hard. Let us know when you are finished coding it! :D

¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ ( )\ ) ) )
¸.·´¯`·.¸ ( )\ ) ( (()/( ( ( ( ( /( ( /( ( (
¸.·´¯`·.¸ )((_) ( ( ( ( /( )\ /(_)) )\ )\))( )\()) )\()) ))\ )(
¸.·´¯`·.¸ ((_)_ )\ )\ ) )\ )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\
¸.·´¯`·.¸ | _ ) ((_) _(_/( ((_)((_)_ (_) | |_ (_) (()(_)| |(_)| |_ (_)) ((_)
¸.·´¯`·.¸ | _ \/ _ \| ' \))(_-</ _` | | | | __| | |/ _` | | ' \ | _|/ -_) | '_|
¸.·´¯`·.¸ |___/\___/|_||_| /__/\__,_| |_| |_| |_|\__, | |_||_| \__|\___| |_|
¸.·´¯`·.¸ |___/
¸.·´¯`·.¸
¸.·´¯`·.¸ Script runtime:
¸.·´¯`·.¸ 29 min 46 sec(Total) 29 min 46 sec(Active) 0 sec(Break)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸ KILLS ¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ Warped Cockroach
¸.·´¯`·.¸ 135(Killed) 272(per hour run) 272(per hour active)
¸.·´¯`·.¸ 3362(xp) 6775(xp per hour run) 6775(xp per hour active)
¸.·´¯`·.¸ 1107(const xp) 2231(const xp per hour run) 2231(const xp per hour active)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸

First run! :)

¸.·´¯`·.¸ Script runtime:
¸.·´¯`·.¸ 2 hr 18 min 6 sec(Total) 2 hr 18 min 6 sec(Active) 0 sec(Break)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸ KILLS ¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ Crawling corpse torso
¸.·´¯`·.¸ 276(Killed) 120(per hour run) 120(per hour active)
¸.·´¯`·.¸ 11040(xp) 4797(xp per hour run) 4797(xp per hour active)
¸.·´¯`·.¸ 3643(const xp) 1583(const xp per hour run) 1583(const xp per hour active)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
First Long run! :)

I posted an updated color file in the first post. The forum wouldn't allow .xml extension, so I had to make it .xml.txt

Copy this file to SIMBADIR/includes/bonsai/libnpcStandard.xml to get the new definitions.

I have to write some code to get the XML files working with versions/autoupdate.

I also updated the script to use the EOC abilities.

Added a few NPCs. Deadly red spider by request, moss giant, shade/ghost/ankou from bottom floor of the stronghold. Couldn't test the varrock ones due to low level. The stronghold ones don't work too great due to colors being the same as backgrounds and they move fast.

Er, I'm getting this error, it finds the monster but it takes like 10 seconds because it cant find it and then it finds it via color match, anyone can help me?

****** Having problems finding NPC, sleeping
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 24
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 25
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 26
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 27
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 28
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 29
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 30
****** Having problems finding NPC, rotating cam.
***** Altering angle to 205
***** Health check returning 102 percent
***** Health check returning 102 percent
TObjFind.choose: found 1 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
****** Didnt find a Catablepon to fight. timesFailed = 31
****** Having problems finding NPC, moving to closest yellow dot
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 32
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 33
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 34
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 35
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 36
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 37
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 38
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 39
TObjFind.choose: found 0 possible objects
****** Didnt find a Catablepon to fight. timesFailed = 40
****** Having problems finding NPC, rotating cam.
***** Altering angle to 59
TObjFind.choose: found 3 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
TObjFind.choose: chooseOption called on object, result=True
***** Fight initiated
***** Tnpc.isInFight: did not find standard DTM, trying color match
***** Tnpc.isInFight: did not find standard DTM, trying color match
***** Tnpc.isInFight: did not find standard DTM, trying color match

and then it found it.

and also, it says returning health: 102%??? and its eating all my food when im not even below 50%

The health part is weird, but not really a problem as long as you're not dying and your food is not being wasted. With the monster finding, either edit the colour codes and tolerances yourself or fight a monster that has a more contrasting colour to its environment, this will help the script to find the monster a lot easier. Lastly, Bonsai uploaded a new xml file with updated info in it, if you haven't downloaded that and added as per the instructions here, you should do that too. Let us know how you go.

[PHP]¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ ( )\ ) ) )
¸.·´¯`·.¸ ( )\ ) ( (()/( ( ( ( ( /( ( /( ( (
¸.·´¯`·.¸ )((_) ( ( ( ( /( )\ /(_)) )\ )\))( )\()) )\()) ))\ )(
¸.·´¯`·.¸ ((_)_ )\ )\ ) )\ )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\
¸.·´¯`·.¸ | _ ) ((_) _(_/( ((_)((_)_ (_) | |_ (_) (()(_)| |(_)| |_ (_)) ((_)
¸.·´¯`·.¸ | _ \/ _ \| ' \))(_-</ _` | | | | __| | |/ _` | | ' \ | _|/ -_) | '_|
¸.·´¯`·.¸ |___/\___/|_||_| /__/\__,_| |_| |_| |_|\__, | |_||_| \__|\___| |_|
¸.·´¯`·.¸ |___/
¸.·´¯`·.¸
¸.·´¯`·.¸ Script runtime:
¸.·´¯`·.¸ 3 hr 14 min 20 sec(Total) 2 hr 55 min 16 sec(Active) 19 min 4 sec(Break)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸ KILLS ¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸
¸.·´¯`·.¸ Giant Spider
¸.·´¯`·.¸ 448(Killed) 138(per hour run) 153(per hour active)
¸.·´¯`·.¸ 38080(xp) 11757(xp per hour run) 13036(xp per hour active)
¸.·´¯`·.¸ 12544(const xp) 3873(const xp per hour run) 4294(const xp per hour active)
¸.·´¯`·.¸
¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸¸.·´¯`·.¸[/PHP]

From: sparkyownage
Er, I'm getting this error, it finds the monster but it takes like 10 seconds because it cant find it and then it finds it via color match, anyone can help me?

TObjFind.choose: found 0 possible objects

This is indicating a color issue (if there are NPCs in view). For fix, I would check grahpic settings against the screenshot I posted a few posts back. Or recolor the entry to your own setup.

***** Tnpc.isInFight: did not find standard DTM, trying color match
***** Tnpc.isInFight: did not find standard DTM, trying color match
***** Tnpc.isInFight: did not find standard DTM, trying color match

This is normal, it spams that message in the time between clicking the NPC and the fight starting. On a couple of NPCs the DTM doesn't match and it spams that the whole fight.

 and also, it says returning health: 102%??? 

That's normal too, they changed something that gives me back a few more pixels on the color check I do. I just need to record the newer count and use that for the percent. It's pretty harmless though.

and its eating all my food when im not even below 50%

This one's not harmless. It shouldn't eat the food unless it detects health lower than the percent you set in your settings. There were some earlier bugs with that but I haven't noticed anything on this version. I'll poke around and see if I see any likely cause. The old issues were when the health bar got covered up and it couldn't read it.

BTW, if the debugs are annoying anyone, they turn off by commenting out line 7. They're helpful if having problems but way too much when things are running ok :)

{$DEFINE DEBUG_ON}

Change to:

//  {$DEFINE DEBUG_ON}

@Anyone that wants to fight deadly red spiders, I find these colors to be almost perfect:

       <name>DRS</name>
        <xp>399</xp>
        <constXp>131.6</constXp>
        <color1>3164087</color1>
        <tolerance1>13</tolerance1>
        <hue1>0.15</hue1>
        <sat1>1.26</sat1>

not working here

– Checking bonsaiFighter.simba for updates.
– Version is current, no update needed.
***** Next break time calculated, break in 178.49415 minutes
– setupSRL()
—- Setting up SRL…
—- initSmart():
—— Attempting to pair to a previously spawned client
—— smartPairToExistingClient():
——– Found 1 free client(s), attempting to pair to one…
——– Failed to pair to SMART[11832]
—— smartPairToExistingClient(): result = false
—— Attempting to spawn a new client..
—— smartCreateClient():
———- smartGetParameters(): Succesfully grabbed paramters
——– getJavaPath():
———- Attempting to search for your Java path
———- Found your java path @ C:\Program Files (x86)\Java\jre7\bin\java.exe
——– getJavaPath()
——– Using parameters [(unable to post links, f5335362921684422725]
——– Using plugins "OpenGL32.dll"
——– Succesfully spawned a client, attempting to target
———- smartSetAsTarget(): Succesfully set SMART[11216] as Simba's target
—— smartCreateClient(): result = true
—— Succesfully initialized via spawning a new client
—- initSmart()
—— smartSetupDrawing(): Succesfully setup SMART drawing
—- Waiting up to 5 minutes for RS to load…
—— __setInputBoxes(): Set username and password boxes
—- Client is ready.
—- Setup SRL in 13828ms.
– setupSRL(): True
***** Logging player in
***** Health check returning 67 percent
***** Health check returning 67 percent
****** Starting auto detect process
***** autoDetect checking for Warped Cockroach
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Corpse Spider
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Warped Fly
TObjFind.choose: found 2 possible objects
TObjFind.choose: mouse moved to object 0
Font tmpMouseoverChars already loaded as: tmpMouseoverChars
TObjFind.choose: examining mouseText=Attack Giant spider (level.. SZ)
TObjFind.choose: Attack Giant spider (level.. SZ) matched; will click object
****** Auto detected NPC:
****** Could not set up NPC [autodetect]. Verify name is in XML file.
***** Loop ended, terminating
****** bonsaiFighter: Script shutting down

From: Nehalem
not working here

Font tmpMouseoverChars already loaded as: tmpMouseoverChars
TObjFind.choose: examining mouseText=Attack Giant spider (level.. SZ)
TObjFind.choose: Attack Giant spider (level.. SZ) matched; will click object
****** Auto detected NPC:
****** Could not set up NPC [autodetect]. Verify name is in XML file.
***** Loop ended, terminating
****** bonsaiFighter: Script shutting down

Looks like I bugged up the autodetect. Set your npc name to

'Giant spider' at the top of the script and it should run fine.

I'll poke at the code later and post an update.

Can you make it so that the script is using keys instead of clicking skills? It's unhumane, and makes it so that there is a greater chance of getting caught.

From: KeepBotting
@Anyone that wants to fight deadly red spiders, I find these colors to be almost perfect:

       <name>DRS</name>
        <xp>399</xp>
        <constXp>131.6</constXp>
        <color1>3164087</color1>
        <tolerance1>13</tolerance1>
        <hue1>0.15</hue1>
        <sat1>1.26</sat1>

Thank you :D

From: sparkyownage
Can you make it so that the script is using keys instead of clicking skills? It's unhumane, and makes it so that there is a greater chance of getting caught.

Update posted, you should get it the next time you run the script.

Changes:

* When loading NPCs it will lowercase the names for comparisons. This will fix the autodetect problem posted today as well as any other case issues. Giant Rat == Giant rat == GIANT RAT
* Abilities are activated by keystroke instead of mouse clicks
* User NPCs are loaded before the pre-installed ones. That way if you override one of the the provided ones, your entry will take precendence.

"Exception in Script: Unknown declaration "TObjFilterSpec" at line 268, column 38 in file "C:\Simba\Includes\bonsai\libnpc.simba"

This is the error I'm getting when I try and run this script. Any ideas?

From: stickyninja
"Exception in Script: Unknown declaration "TObjFilterSpec" at line 268, column 38 in file "C:\Simba\Includes\bonsai\libnpc.simba"

This is the error I'm getting when I try and run this script. Any ideas?

That's wierd. Was this on a new install or existing?

I just downloaded the installer to one of my machines and did a full install and it compiled ok.

TObjFilterSpec is in file SIMBADIR/includes/bonsai/libobjfind.simba

Somehow you don't have that or it is corrupt?

I would grab the installer from the first post and run that to fix things up.

That fixed the first problem. now this is the error I'm getting.
Am I missing something here?

"Exception in Script: Runtime error: "Access violation" at line 421, column 33
The following DTMs were not freed: [0]
The following bitmaps were not freed: [Minimap Mask, SMART Debug Image]
File[C:\Simba\Includes\SRL-6/logs/SRL log (07-12-13 at 08.42.43 PM).txt] has not been freed in the script, freeing it now."

From: stickyninja
That fixed the first problem. now this is the error I'm getting.
Am I missing something here?

"Exception in Script: Runtime error: "Access violation" at line 421, column 33
The following DTMs were not freed: [0]
The following bitmaps were not freed: [Minimap Mask, SMART Debug Image]
File[C:\Simba\Includes\SRL-6/logs/SRL log (07-12-13 at 08.42.43 PM).txt] has not been freed in the script, freeing it now."

You need to edit bonsaiFighterSettings.xml and add your player nickname and filename

I guess I should have a check on that and a clear error message.

From: bonsai
You need to edit bonsaiFighterSettings.xml and add your player nickname and filename

I guess I should have a check on that and a clear error message.

Okay, I'll give it a try. I was trying to use the player manager for login.

From: stickyninja
Okay, I'll give it a try. I was trying to use the player manager for login.

It does use the player manager but you still need to tell each script which nickname(s) to run for. You can put a bunch of characters into one player manager file.

Scripts also need the name of your player manager file. Player manager uses "default.xml" by default but you can change it to any name you want.

From: bonsai
It does use the player manager but you still need to tell each script which nickname(s) to run for. You can put a bunch of characters into one player manager file.

Scripts also need the name of your player manager file. Player manager uses "default.xml" by default but you can change it to any name you want.

I finally got it to log in but it isn't attacking anything. I'm going to do a clean install of everything and see if that helps.

Hey, I have tried running your script at minotaurs and goblins at the stronghold of security and it logs me in,
stands there for a little bit and terminates the script. In the de-bug it says:

***** Logging player in
*************************************************
***** ERROR GETTING PLAYER LOGGED IN, EXITING!!!
*************************************************
****** bonsaiFighter: Script shutting down

I have ran the sample script you provided to someone else earlier in this thread and that works fine :)

From: catsrback321
Hey, I have tried running your script at minotaurs and goblins at the stronghold of security and it logs me in,
stands there for a little bit and terminates the script. In the de-bug it says:

***** Logging player in
*************************************************
***** ERROR GETTING PLAYER LOGGED IN, EXITING!!!
*************************************************
****** bonsaiFighter: Script shutting down

I have ran the sample script you provided to someone else earlier in this thread and that works fine :)

It prints that message if "players[currentPlayer].login()" fails, so the SRL library is claiming you're not logged in.

I suspect RS is changing colors again and messing up the libraries. One of my test characters started doing stuff like this yesterday while another one worked fine.

From: stickyninja
I finally got it to log in but it isn't attacking anything. I'm going to do a clean install of everything and see if that helps.

That seems drastic if you have a workable setup that launches smart and logs in.

I would double check the graphics settings. I posted a screenshot previously in the thread.

Otherwise you might be having the same issue as catsrback321. What's the debug output looking like?

this is a bigger caption of the debug,
—- Client is ready.
—- Setup SRL in 219ms.
– setupSRL(): True
***** Logging player in
*************************************************
***** ERROR GETTING PLAYER LOGGED IN, EXITING!!!
*************************************************
****** bonsaiFighter: Script shutting down

I've tried it in a few places wearing different things :/

From: catsrback321
this is a bigger caption of the debug,
—- Client is ready.
—- Setup SRL in 219ms.
– setupSRL(): True
***** Logging player in
*************************************************
***** ERROR GETTING PLAYER LOGGED IN, EXITING!!!
*************************************************
****** bonsaiFighter: Script shutting down

I've tried it in a few places wearing different things :/

Are you sure your graphic settings are all correct?

•Open the settings interface and select the preset layout Old School.
•Click Interface Settings and make sure that the "Slim Headers" is checked.
•Make sure the "Hide title bars when locked" is not checked.

graphics settings

If so, you're hitting an SRL bug regarding the login checking.

the code that you're passing through is calling two SRL functions, isLoggedIn() and login() and these are failing.

   if (not isLoggedIn()) then
   begin
      writeln('***** Logging player in');
      takeScreenshot(scriptName + '.png');
      if (not players[currentPlayer].login()) then 
      begin
         writeln('*************************************************');
         writeln('***** ERROR GETTING PLAYER LOGGED IN, EXITING!!!');
         writeln('*************************************************');
         terminateScript();
      end
      else
      begin
         mainscreen.setangle(MS_ANGLE_HIGH);
         exitSquealOfFortune();
      end;
   end; 

Script is running great :)
Every night I run it before I sleep and wake up to it still running strong.

Any chance you could add a 6-hour-fix. The length of my runs is limited by the frequency of the breaks i use and I would rather not forgo breaks to run all day. I know that it RS doesn't boot you out immediately after 6 hours anymore, but having a session run significantly more than 6 hours seems like it would be a red flag.

From: freeplay
Script is running great :)
Every night I run it before I sleep and wake up to it still running strong.

Any chance you could add a 6-hour-fix. The length of my runs is limited by the frequency of the breaks i use and I would rather not forgo breaks to run all day. I know that it RS doesn't boot you out immediately after 6 hours anymore, but having a session run significantly more than 6 hours seems like it would be a red flag.

It was my understanding from reading the code that player.login() would end up calling sixhourfix for me with no intervention. I thought it worked ok because I had a few runs more than six hours. Not much more, so maybe I just got lucky.

What sort of error do you see? Do you get a decent screenshot in the SIMBADIR/includes/srl-6/logs folder?

From: bonsai
It was my understanding from reading the code that player.login() would end up calling sixhourfix for me with no intervention. I thought it worked ok because I had a few runs more than six hours. Not much more, so maybe I just got lucky.

What sort of error do you see? Do you get a decent screenshot in the SIMBADIR/includes/srl-6/logs folder?

Ah, i've got it. The problem solves itself, but not in the way I expected. I would just recommend that people use frequent but short breaks as opposed to fewer long breaks (like I had). It never results in an error, but if you have long periods in between breaks you could have your client open for 8~9 hours (on a variable that jagex clearly watches).

From: freeplay
Ah, i've got it. The problem solves itself, but not in the way I expected. I would just recommend that people use frequent but short breaks as opposed to fewer long breaks (like I had). It never results in an error, but if you have long periods in between breaks you could have your client open for 8~9 hours (on a variable that jagex clearly watches).

At some point around 6 hours open they'll force you out. When it logs back in it should detect the six hour issue and spawn a new client, then log you in. At least, that's my understanding of it.

So you should be able to get 9-10 hour runs, but the last few hours would be on a second client session.

And during break you get idled out like if you walked away and left the browser open. That probably happens a lot so I don't think it's something too trackable. The length of actual login/activity per day; now that's something I would think they run reports on.

Hi there, I got this error while attempting to run the script:
***** Logging player in
Exception in Script: Runtime error: "Font [NumberCharsSmooth] not found." at line 813, column 19 in file "C:\Simba\Includes\srl-6\lib\utilities\wrappers.simba"
The following DTMs were not freed: [0]
The following bitmaps were not freed: [Minimap Mask, SMART Debug Image]
File[C:\Simba\Includes\SRL-6/logs/SRL log (12-12-13 at 05.53.59 PM).txt] has not been freed in the script, freeing it now.

Your install isn't good. Perhaps force a simba update? Pick tools->update and if it says you are up to date, force it anyway.

Restart simba afterwards, do the same on the SRL menu, srl->update. If it updates, restart simba again.

Hopefully that will clear up any issues.

Ok, now I have an interesting error message that I get occasionally at the end of a long run.

Program exception!
Stacktrace:

Exception class: EThread
Message: Thread creation error: Not enough storage is available to process this command.

$004592BC
$006241F6
$0060E3D4
$004349D4
$0042C90A
$005835A5
$0058350F
$00508911
$768B7694
$768B870E
$768B85A5
$768B9C40
$00509475
$0042638C
$004267AF
$004494A3
$00426765
Simba Version: 1003

I don't think its an issue with my simba install, since other scripts i run for long times don't do this. I'll have the actual debug when I reproduce it.

Interesting. Best guess is that something my libraries/objects are doing cause a memory leak.

Did you catch any debug from the script before it happened? That might help me hone in on a culprit.

Or even the SRL output from SIMBADIR/includes/srl-6/logs may tell me.

Lape is a little quirky sometimes and I may need to avoid something I'm doing or find a different way to do it.

From: bonsai
Interesting. Best guess is that something my libraries/objects are doing cause a memory leak.

Did you catch any debug from the script before it happened? That might help me hone in on a culprit.

Or even the SRL output from SIMBADIR/includes/srl-6/logs may tell me.

Lape is a little quirky sometimes and I may need to avoid something I'm doing or find a different way to do it.

I had debug off when i got it this time, but i'm working on getting it again. I won't have a good internet connection for several hours so I'll probably post the actual debug tomorrow. The output i posted was from SIMBADIR/includes/srl-6/logs.

It crashes simba after 6-8 hours of running your script and i think that might be cumulative.
(a 2 hour run and a 6 hour run without restarting was the case for this crash)

From: bonsai
Are you sure your graphic settings are all correct?

•Open the settings interface and select the preset layout Old School.
•Click Interface Settings and make sure that the "Slim Headers" is checked.
•Make sure the "Hide title bars when locked" is not checked.

That is my issue… I forgot to setup the graphics settings right. Got it up and running now. Thanks for the help!

TObjFind.choose: chooseOption called on object, result=True
***** Fight initiated
***** Tnpc.isInFight: did not find standard DTM, trying color match
***** Tnpc.isInFight: did not find standard DTM, trying color match
***** Tnpc.isInFight: did not find standard DTM, trying color match
***** Tnpc._doAbilities: ability[12] returned cooldown 40
***** Tnpc._doAbilities: ability[11] returned cooldown 1
***** Tnpc._doAbilities: activated ability[11]
***** Health check returning 98 percent
***** Health check returning 98 percent
***** Tnpc._doAbilities: ability[12] returned cooldown 50
***** Tnpc._doAbilities: ability[11] returned cooldown 1
***** Tnpc._doAbilities: activated ability[11]
***** Tnpc._doAbilities: ability[12] returned cooldown 62
***** Tnpc._doAbilities: ability[11] returned cooldown 88
***** Tnpc._doAbilities: ability[10] returned cooldown 63
***** Tnpc._doAbilities: ability[9] returned cooldown 90
***** Tnpc._doAbilities: ability[8] returned cooldown 1
***** Tnpc._doAbilities: activated ability[8]
***** Health check returning 98 percent
***** Health check returning 98 percent
***** Tnpc._doAbilities: ability[12] returned cooldown 73
***** Tnpc._doAbilities: ability[11] returned cooldown 1
***** Tnpc._doAbilities: activated ability[11]
***** Tnpc.isInFight: did not find standard DTM, trying color match
***** End of fight detected
***** Killed a Flesh Crawler

This is the simba output. The actual debug file was never created. I don't think this will be much help…

Do I need to change something to make my guy eat? it got down to 20% with a full inventory of food and didn't eat.
Other than that working great! Here is my first run progress report.

////////////////////////////////////////////////////////////////////////////////////////////////////
////////// ( )\ ) ) ) //////////
////////// ( )\ ) ( (()/( ( ( ( ( /( ( /( ( ( //////////
////////// )((_) ( ( ( ( /( )\ /(_)) )\ )\))( )\()) )\()) ))\ )( //////////
////////// ((_)_ )\ )\ ) )\ )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\ //////////
////////// | _ ) ((_) _(_/( ((_)((_)_ (_) | |_ (_) (()(_)| |(_)| |_ (_)) ((_) //////////
////////// | _ \/ _ \| ' \))(_-</ _` | | | | __| | |/ _` | | ' \ | _|/ -_) | '_| //////////
////////// |___/\___/|_||_| /__/\__,_| |_| |_| |_|\__, | |_||_| \__|\___| |_| //////////
////////// |___/ //////////
////////// //////////
////////// Script runtime: //////////
////////// 2 hr 40 min 25 sec(Total) 2 hr 21 min 57 sec(Active) 18 min 28 sec(Break)//////////
////////// //////////
//////////////////////////////////////// KILLS ////////////////////////////////////////
////////// Corpse mage //////////
////////// 566(Killed) 212(per hour run) 239(per hour active) //////////
////////// 29432(xp) 11007(per hour run) 12440(per hour active) //////////
////////// 9679(const xp) 3620(per hour run) 4091(per hour active) //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

From: stickyninja
Do I need to change something to make my guy eat? it got down to 20% with a full inventory of food and didn't eat.
Other than that working great! Here is my first run progress report.

Sweet. Glad you got it going ok.

For the food, you need to assign the food to quick inventory A and make sure that slot has 'z' for the hotkey.

It just presses z when it wants to eat.

From: bonsai
Sweet. Glad you got it going ok.

For the food, you need to assign the food to quick inventory A and make sure that slot has 'z' for the hotkey.

It just presses z when it wants to eat.

Okay I got it. Just one more setting I didn't check first. Thanks for the help.

Bank support would be lovely :) <3

Script runtime:
7 hr 5 min 14 sec(Total) 6 hr 11 min 15 sec(Active) 53 min 59 sec(Break)
KILLS
Corpse mage
1586(Killed) 224(per hour run) 256(per hour active)
82472(xp) 11637(per hour run) 13329(per hour active)
27121(const xp) 3827(per hour run) 4383(per hour active)

Longest run yet! :)

I have a question about the color detection.

If you set two colors in the xml file, is it:
monster with color 1 and color 2
monster with color 1 or color 2
or something else?

From: freeplay
I have a question about the color detection.

If you set two colors in the xml file, is it:
monster with color 1 and color 2
monster with color 1 or color 2
or something else?

It will find both colors on the mainscreen. It filters these by clusting all pixels within a certain distance (<dist> in the XML file). So if you have a great color match you can use small dist like 2-3. If your color match gets holes, you could use higher numbers.

Then it fiters again keeping the areas where BOTH colors esist within a certain distance. That distance is in the XML file named <inclDist>. So if you use 35 it will only keep items where both of those colors are with 35 of each other.

The filtering also drops out small or large objects to minimize finding the wrong thing. Those are <minPixels> and <maxPixels>).

I changed the second post in this thread to have the information on how to add your own NPC entry. Please let me know if it is unclear.

Wow, that's a nice guide!

Thanks for the information :)

Word of warning…

Got a clean account permabanned at a time when I was only running this script (for short periods with plenty of breaks).

Too many bad mouseovers? Not sure.

It said macro goldfarm which makes no sense. The account has no money and super minimal trading history.

From: bonsai
Word of warning…

Got a clean account permabanned at a time when I was only running this script (for short periods with plenty of breaks).

Too many bad mouseovers? Not sure.

It said macro goldfarm which makes no sense. The account has no money and super minimal trading history.

What monsters where you fighting? I think they do macro goldfarm bans for things like cows/chickens because they're popular for training combat goldfarming bots, as well as monsters that are commonly botted for money.

////////////////////////////////////////////////////////////////////////////////////////////////////
//////////       (                              )\ )                )     )               //////////
//////////     ( )\                     )  (   (()/(  (   (  (   ( /(  ( /(   (   (       //////////
//////////     )((_)  (    (     (   ( /(  )\   /(_)) )\  )\))(  )\()) )\()) ))\  )(      //////////
//////////    ((_)_   )\   )\ )  )\  )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\     //////////
//////////     | _ ) ((_) _(_/( ((_)((_)_  (_) | |_   (_) (()(_)| |(_)| |_ (_))   ((_)    //////////
//////////     | _ \/ _ \| ' \))(_-</ _` | | | | __|  | |/ _` | | ' \ |  _|/ -_) | '_|    //////////
//////////     |___/\___/|_||_| /__/\__,_| |_| |_|    |_|\__, | |_||_| \__|\___| |_|      //////////
//////////                                               |___/                            //////////
//////////                                                                                //////////
//////////  Script runtime:                                                               //////////
//////////       10 hr 36 min 22 sec(Total) 9 hr 13 min 40 sec(Active) 1 hr 22 min 42 sec(Break)//////////
//////////                                                                                //////////
////////////////////////////////////////        KILLS       ////////////////////////////////////////
////////// Catablepon                                                                     //////////
//////////       1717(Killed) 162(per hour run) 186(per hour active)                      //////////
//////////       226644(xp) 21369(per hour run) 24561(per hour active)                    //////////
//////////       74690(const xp) 7042(per hour run) 8094(per hour active)                 //////////
//////////                                                                                //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

Got me from 66 to 69 attack.

Nice script, been getting a few levels on one of my accounts. Couple of things I noticed/suggestions

-When using the left click only option, it still clicks on monsters that have already been attacked (*). I think you have it excluded for the right click option, but I had to change a couple things to exclude the mouseovertext *. (This was with giant spiders) - I also changed the left click to a multi click, but that's just personal pref
-Why not add detection for when the monster has 0 hp and then immediately go to next one instead of waiting for the overhead dealio to go away? (Went ahead and added this in me local version)
-I was having trouble getting it to eat, so I ended up just putting the food in slot 1 of the action bar, and removing that bar from the ability checker since I don't use all of the ability slots.
-Another suggestion would be to add reguvinate or however you spell capability to help limit food usage
-Also you may want to put in OP that you need to have the target popup dealio turned on for it to work (You may have mentioned and I missed it - I had it turned off at LRC b/c it takes up a lot of room

Hope I didn't come across as raggin on your script, it is definitely really good!

////////////////////////////////////////////////////////////////////////////////////////////////////
//////////       (                              )\ )                )     )               //////////
//////////     ( )\                     )  (   (()/(  (   (  (   ( /(  ( /(   (   (       //////////
//////////     )((_)  (    (     (   ( /(  )\   /(_)) )\  )\))(  )\()) )\()) ))\  )(      //////////
//////////    ((_)_   )\   )\ )  )\  )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\     //////////
//////////     | _ ) ((_) _(_/( ((_)((_)_  (_) | |_   (_) (()(_)| |(_)| |_ (_))   ((_)    //////////
//////////     | _ \/ _ \| ' \))(_-</ _` | | | | __|  | |/ _` | | ' \ |  _|/ -_) | '_|    //////////
//////////     |___/\___/|_||_| /__/\__,_| |_| |_|    |_|\__, | |_||_| \__|\___| |_|      //////////
//////////                                               |___/                            //////////
//////////                                                                                //////////
//////////  Script runtime:                                                               //////////
//////////       1 hr 22 min 30 sec(Total) 1 hr 22 min 30 sec(Active) 0 sec(Break)        //////////
//////////                                                                                //////////
////////////////////////////////////////        KILLS       ////////////////////////////////////////
////////// Giant Spider                                                                   //////////
//////////       570(Killed) 415(per hour run) 415(per hour active)                       //////////
//////////       48450(xp) 35235(per hour run) 35235(per hour active)                     //////////
//////////       15960(const xp) 11607(per hour run) 11607(per hour active)               //////////
//////////                                                                                //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

Amazing script! Im learning a little bit from your scripts man! Keep doing this good work i really appreciate it and im sure more do :)

Script runtime: 5 hr 38 min 1 sec(Total) 5 hr 1 min 39 sec(Active) 36 min 22 sec(Break)
KILLS
Minotaur
1595(Killed) 283(per hour run) 317(per hour active)
54230(xp) 9626(per hour run) 10787(per hour active)
17864(const xp) 3171(per hour run) 3553(per hour active)

Best one yet! ;)

hmm was trying at warped cockroach, it does a lot of mouse hovering :(

I get 1 kill per minute roflol

edit: fixed, had to add a little wait before TObjFind.choose :)

edit2: superb script mate, this performs great!

Edit: Nope, disregard this again, I'm still an idiot! xD

hey i got a lil prob when i run the script it asks for something called an army password for decryption when runscape login screen comes up i dont know what to type and if i just click enter it says sucessfully executedor if i cancel it it says


Exception in Script: Runtime error: "Access violation" at line 421, column 33
The following DTMs were not freed: [0]
The following bitmaps were not freed: [Minimap Mask, SMART Debug Image]
File[C:\Simba\Includes\SRL-6/logs/SRL log (08-01-14 at 03.45.25 PM).txt] has not been freed in the script, freeing it now.

That would imply you set encryption and a password on your player file when you set it up.

I never tried that so I'm not sure off the top of my head what may need to be done in the script (if anything).

If you want to get going immediately, set up another player file without the encryption and use that.

Hi Bonsai - thanks for the great script. I'm new to the community and whilst I have used the search button I can't find a solution to my problem… I am sure it's simple.

I am getting the 'socket disconnected; unpairing' error.

Could you please help me?

From: badezy
Hi Bonsai - thanks for the great script. I'm new to the community and whilst I have used the search button I can't find a solution to my problem… I am sure it's simple.

I am getting the 'socket disconnected; unpairing' error.

Could you please help me?

That message always comes up when a script exits. The question is, why is the script exiting.

The info to solve your problem is most likely in the simba log. check SIMBADIR/includes/srl-6/logs

To get more logging in the simba window itself, make sure around line 7 that "{$DEFINE DEBUG_ON}" is not commented out. Also change around line 418 "disableSRLDebug := true" to "disableSRLDebug := false".

I did a test login this morning and had a problem with the login being recognized. It logged me in fine but the login() function didn't return it just sat waiting. Not sure if a recent update has messed up the SRL library a little.

Thanks so much for replying.

This is the log….

– TPlayer.login(): False
*************************************************
***** ERROR GETTING PLAYER LOGGED IN, EXITING!!!
*************************************************
– Freeing the minimap mask
****** bonsaiFighter: Script shutting down
—- Saving screenshot: bonsaiFighter.png




But I don't understand because it appears to log in just fine. Then once it logs in it just waits then eventually brings up the menu and then stops.

From: badezy
Thanks so much for replying.

This is the log….

– TPlayer.login(): False
*************************************************
***** ERROR GETTING PLAYER LOGGED IN, EXITING!!!
*************************************************
– Freeing the minimap mask
****** bonsaiFighter: Script shutting down
—- Saving screenshot: bonsaiFighter.png




But I don't understand because it appears to log in just fine. Then once it logs in it just waits then eventually brings up the menu and then stops.

Yeah, assuming you have your graphics all set correctly, it looks like an SRL issue with the new RS update. It did it to me on a system that definitely worked well in the past.

It doesn't look like anyone has reported a bug yet. I'm at work so I can't test and gather info to write up a bug report.

It might work if you stop/start the script after you get logged in. Depends on whether the isloggedin() function is also wonky.

From: bonsai
Yeah, assuming you have your graphics all set correctly, it looks like an SRL issue with the new RS update. It did it to me on a system that definitely worked well in the past.

It doesn't look like anyone has reported a bug yet. I'm at work so I can't test and gather info to write up a bug report.

It might work if you stop/start the script after you get logged in. Depends on whether the isloggedin() function is also wonky.

Understand, thanks very much.

Could I delete the 'isloggedin()' and then perhaps it will work?

From: badezy
Understand, thanks very much.

Could I delete the 'isloggedin()' and then perhaps it will work?

Yes, that would probably work around it temporarily.

Didn't work I am afraid :(

From: badezy
Didn't work I am afraid :(

go to lin 418-420: fill your rafiki data there:

   players.setup(['bot'], 'much');
   currentPlayer := 0;
   players[currentPlayer].world := 120;     

works for me

Hey, I tried that - same thing, can I maybe add you to Skype to show you what I am doing on my screen?

From: badezy
Hey, I tried that - same thing, can I maybe add you to Skype to show you what I am doing on my screen?

euh sure, gimme your skype

Hey I just wanna thank you both for your help - I've resolved the issue. It was me fucking up the setup. I apologise for jerking you both around.

Hi Bonsai, I've been using your script alot - with no issues. But all of a sudden I am getting this quite alot:

TObjFind.choose: found 1 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
****** Didnt find a Flesh Crawler to fight.  timesFailed = 29

Any fixes?

From: badezy
Hi Bonsai, I've been using your script alot - with no issues. But all of a sudden I am getting this quite alot:

TObjFind.choose: found 1 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
****** Didnt find a Flesh Crawler to fight.  timesFailed = 29

Any fixes?

It's not catching any mouseovertext. Maybe if you put a small wait in between the mouse move and text check it will get it?

File SIMBADIR/includes/bonsai/libobjfind.simba, function TObjFind.choose (around line 1243).

mouse(objPoints[i].rand(pointVariance), MOUSE_MOVE);
         
{$IFDEF DEBUG_ON} writeln('TObjFind.choose: mouse moved to object ', i); {$ENDIF}
        
moText := getMouseOverText();

Try changing to:

mouse(objPoints[i].rand(pointVariance), MOUSE_MOVE);
         
{$IFDEF DEBUG_ON} writeln('TObjFind.choose: mouse moved to object ', i); {$ENDIF}
wait(250);  
moText := getMouseOverText();

You can play with the 250 to see what works well.

If it helps let me know and I can put out for general release.

////////////////////////////////////////////////////////////////////////////////////////////////////
////////// ( )\ ) ) ) //////////
////////// ( )\ ) ( (()/( ( ( ( ( /( ( /( ( ( //////////
////////// )((_) ( ( ( ( /( )\ /(_)) )\ )\))( )\()) )\()) ))\ )( //////////
////////// ((_)_ )\ )\ ) )\ )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\ //////////
////////// | _ ) ((_) _(_/( ((_)((_)_ (_) | |_ (_) (()(_)| |(_)| |_ (_)) ((_) //////////
////////// | _ \/ _ \| ' \))(_-</ _` | | | | __| | |/ _` | | ' \ | _|/ -_) | '_| //////////
////////// |___/\___/|_||_| /__/\__,_| |_| |_| |_|\__, | |_||_| \__|\___| |_| //////////
////////// |___/ //////////
////////// //////////
////////// Script runtime: //////////
////////// 13 hr 9 min 21 sec(Total) 11 hr 38 min 35 sec(Active) 1 hr 30 min 45 sec(Break)//////////
////////// //////////
//////////////////////////////////////// KILLS ////////////////////////////////////////
////////// Catablepon //////////
////////// 2356(Killed) 179(per hour run) 202(per hour active) //////////
////////// 224762(xp) 17085(per hour run) 19304(per hour active) //////////
////////// 73743(const xp) 5605(per hour run) 6334(per hour active) //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

Longest one I've gotten yet! ;)

From: stickyninja
////////////////////////////////////////////////////////////////////////////////////////////////////
////////// ( )\ ) ) ) //////////
////////// ( )\ ) ( (()/( ( ( ( ( /( ( /( ( ( //////////
////////// )((_) ( ( ( ( /( )\ /(_)) )\ )\))( )\()) )\()) ))\ )( //////////
////////// ((_)_ )\ )\ ) )\ )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\ //////////
////////// | _ ) ((_) _(_/( ((_)((_)_ (_) | |_ (_) (()(_)| |(_)| |_ (_)) ((_) //////////
////////// | _ \/ _ \| ' \))(_-</ _` | | | | __| | |/ _` | | ' \ | _|/ -_) | '_| //////////
////////// |___/\___/|_||_| /__/\__,_| |_| |_| |_|\__, | |_||_| \__|\___| |_| //////////
////////// |___/ //////////
////////// //////////
////////// Script runtime: //////////
////////// 13 hr 9 min 21 sec(Total) 11 hr 38 min 35 sec(Active) 1 hr 30 min 45 sec(Break)//////////
////////// //////////
//////////////////////////////////////// KILLS ////////////////////////////////////////
////////// Catablepon //////////
////////// 2356(Killed) 179(per hour run) 202(per hour active) //////////
////////// 224762(xp) 17085(per hour run) 19304(per hour active) //////////
////////// 73743(const xp) 5605(per hour run) 6334(per hour active) //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

Longest one I've gotten yet! ;)

Grrr, you guys suck! I usually bot for an hour or two at a time and I keep getting bans!!! :fiery:

I'm about ready to bot my main since f2p chars get whack-a-moled.

I need to find some time to work on another script. Ashaman keeps releasing 10 scripts a week; it's making me feel lazy.

From: bonsai
Grrr, you guys suck! I usually bot for an hour or two at a time and I keep getting bans!!! :fiery:

I'm about ready to bot my main since f2p chars get whack-a-moled.

I need to find some time to work on another script. Ashaman keeps releasing 10 scripts a week; it's making me feel lazy.

Do u make your accounts in a short time span?

From: bonsai
It's not catching any mouseovertext. Maybe if you put a small wait in between the mouse move and text check it will get it?

File SIMBADIR/includes/bonsai/libobjfind.simba, function TObjFind.choose (around line 1243).

mouse(objPoints[i].rand(pointVariance), MOUSE_MOVE);
         
{$IFDEF DEBUG_ON} writeln('TObjFind.choose: mouse moved to object ', i); {$ENDIF}
        
moText := getMouseOverText();

Try changing to:

mouse(objPoints[i].rand(pointVariance), MOUSE_MOVE);
         
{$IFDEF DEBUG_ON} writeln('TObjFind.choose: mouse moved to object ', i); {$ENDIF}
wait(250);  
moText := getMouseOverText();

You can play with the 250 to see what works well.

If it helps let me know and I can put out for general release.

Thanks for replying - I'll give it a shot and let you know!

From: bonsai
Grrr, you guys suck! I usually bot for an hour or two at a time and I keep getting bans!!! :fiery:

I'm about ready to bot my main since f2p chars get whack-a-moled.

I need to find some time to work on another script. Ashaman keeps releasing 10 scripts a week; it's making me feel lazy.

Sorry to hear about your bans!

Am just loving your script mate - I'll post a proggy soon.

Have you had any luck with the collecting at all? Even it was charms it'd be helpful.

mm i cant find ''libnpcUser.xml'' in my bonsai folder
i only have ''libnpcStandard''

There is none by default, you need to make one if you are adding your own NPCs.

You can copy the libnpcStandard.xml and cut out all the entries (except one). Then overwrite that one with your NPC info.

I actually found a little time to mess around this morning and was working on a few small changes to this script. I braved running it on my main and can see some things on the local system that aren't obvious when you're on a slow teamviewer connection.

The fighting DTM wasn't matching well so I'm doing a new one, using the new HP function, etc. Anyone else been seeing any quirks I should look for?

did i do something wrong? it telling me to verify the name

[ATTACH=CONFIG]22840[/ATTACH]
its my first time doing this kind of stuff soo im not even sure what am i doing half of the time

<npc>
<name>Deadly Red Spider</name>
<xp>399</xp>
<constXp>131.6</constXp>
<color1>3412084</color1>
<tolerance1>6</tolerance1>
<hue1>0.28</hue1>
<sat1>1.19</sat1>
<color2>-1</color2>
<tolerance2>0</tolerance2>
<hue2>0.0</hue2>
<sat2>0.0</sat2>
<dist>5</dist>
<inclDist>0</inclDist>
<minPixels>50</minPixels>
<maxPixels>200</maxPixels>
<maxFightSeconds>60</maxFightSeconds>
<uptext>pider</uptext>
</npc>

Did you have all that wrapped by <npclist> and ended with </npclist> ?

Did you leave npcToFight (line 30 in bonsaiFighter.simba) set to 'autodetect' or did you change it to 'Deadly Red Spider' (recommended)?

You might want to meld in the rest of those pink colors or set <dist> larger than 5 to cover the gaps.

I'm pretty sure someone posted a good color for DRS if you browse the thread.

From: bonsai
That would imply you set encryption and a password on your player file when you set it up.

I never tried that so I'm not sure off the top of my head what may need to be done in the script (if anything).

If you want to get going immediately, set up another player file without the encryption and use that.

Hey bonsai I am also getting that same message, but it does not say anything about the password, it simply starts to check all updates and set up the client and comes up with this…

—- Client is ready.
—- Setup SRL in 234ms.
– setupSRL(): True
Exception in Script: Runtime error: "Access violation" at line 421, column 33
The following DTMs were not freed: [0]
The following bitmaps were not freed: [Minimap Mask, SMART Debug Image]
File[C:\Simba\Includes\SRL-6/logs/SRL log (08-02-14 at 11.07.51 AM).txt] has not been freed in the script, freeing it now.

<<<< The first 3 lines of the debug that I posted before, to a newbie like me sounds like everything is going fine, but something little is affecting why the script is failing to start up.
Any information on why this could be happening is greatly appreciated, great script by the way, I can't wait to finally test it and get u a proggy =D


I appreciate the time taken for you reading this =D

//////////
////////// Script runtime: //////////
////////// 1 hr 45 min 52 sec(Total) 1 hr 45 min 52 sec(Active) 0 sec(Break) //////////
////////// //////////
//////////////////////////////////////// KILLS ////////////////////////////////////////
////////// Goblin //////////
////////// 525(Killed) 298(per hour run) 298(per hour active) //////////
////////// 17850(xp) 10117(per hour run) 10117(per hour active) //////////
////////// 525(const xp) 298(per hour run) 298(per hour active) //////////
//////////

my guy starts attacking another npc halfway through the fight, anyway to stop that?

I don't know too much but I'm thinking you hafta find extend the max time waited per battle. Whereever that would be in the script, im not sure.

I don't know too much but I'm thinking you hafta find extend the max time waited per battle. Whereever that would be in the script, im not sure.

A good idea, but I have it set to the default 60 seconds and it still does it - there's no way it takes 60 seconds to 2/3 hit a DRS.

I can get this script to run steadily for hours in Chaos Tunnels at DRS with a SGS as I don't have to use food then (doesn't seem to want to eat for me).

The only issue is it doesn't wait until the monster is killed before trying to attack another and it shows the "can't find something to attack" error too much (even if it does) causing it to stop the script prematurely unless I set the error count before shut down until like 4000. Other than that it's a great script, not the most efficient, but hey, considering I didn't have to make the script or train manually, it's a win win. Cheers bonsai!

Exception in Script: Runtime error: "Access violation" at line 421, column 33
The following DTMs were not freed: [0]
The following bitmaps were not freed: [Minimap Mask, SMART Debug Image]

help?

Works well but stopped moving after an Hour and a half and I was just in the lobby

I will try this soon so I can get 99 slayer because I have always hated combat it bores me.

I want to punch something.

I'm trying to add Dagon'hai Monks, but the surrounding area is basically the same color as their robes. What the hell! This is so annoying. The mouse goes haywire because it thinks Dagon'hai Monks are everywhere!

Furthermore, I tried to render each NPC in Photoshop individually… but then for some reason, the script couldn't recognize them in-game at all.

E: I'm personally deeming this impossible. If anyone has a working script extension for Dagon'hai Monks, I'd love you forever…

From: Ophanim
I want to punch something.

I'm trying to add Dagon'hai Monks, but the surrounding area is basically the same color as their robes. What the hell! This is so annoying. The mouse goes haywire because it thinks Dagon'hai Monks are everywhere!

Furthermore, I tried to render each NPC in Photoshop individually… but then for some reason, the script couldn't recognize them in-game at all.

E: I'm personally deeming this impossible. If anyone has a working script extension for Dagon'hai Monks, I'd love you forever…

Yeah, the other monks were a problem too. You can probably get it working by using more than one color. If you provide two colors the script identifies the area where both colors are present within the specified distance. Also, the min/max settings can help with stuff like this. If the background matches are returning 800 pixels and the NPC is returning more like 200, you can set the max around 300 and the background gets filtered out.

See post two for info on playing with the settings and how to test it. You can post a screenshot if you're having problems getting it going.

Not sure what you mean regarding photoshop. If you're talking about grabbing screen shots to test with, maybe your method of copy/paste is changing colors?

I usually use the snipping tool and paste it into MS paint.

I have an updated copy of the script that I haven't had a chance to test thoroughly. I added support for the user form and made a couple of small tweaks. I also added a directX flag but haven't tried anything with it yet.

From: bonsai
Yeah, the other monks were a problem too. You can probably get it working by using more than one color. If you provide two colors the script identifies the area where both colors are present within the specified distance. Also, the min/max settings can help with stuff like this. If the background matches are returning 800 pixels and the NPC is returning more like 200, you can set the max around 300 and the background gets filtered out.

See post two for info on playing with the settings and how to test it. You can post a screenshot if you're having problems getting it going.

Not sure what you mean regarding photoshop. If you're talking about grabbing screen shots to test with, maybe your method of copy/paste is changing colors?

I usually use the snipping tool and paste it into MS paint.

I have an updated copy of the script that I haven't had a chance to test thoroughly. I added support for the user form and made a couple of small tweaks. I also added a directX flag but haven't tried anything with it yet.

Yeah, I tried using more than one color. Unfortunately, literally the only ones that don't seem to meld with the background is the golden belt-thing and the skin. Those colors make the cursor go haywire as well. I'll try to continue tinkering with it, but I think I might just train on them manually (*cry*).

Also, what I meant by rendering them in Photoshop was basically individually cropping each NPC on a white background and then continuing the color process with ACA. I can't show pictures, sorry.

Odds are that I'm doing this wrong. It's my first time. It took me like an hour to even get Simba set up (LOL).

Superb script, I've used it for deadly red spiders, too bad that it can't bank haha.

I personally use a charm impling and it becomes a fighter/charm collector ;)

Thanks for this amazing script!

Great script! It's working great without stopping at Catablepons and Flesh Crawlers for hours. Will try to get some nice proggies in.

From: NineteenNinetyNine
Great script! It's working great without stopping at Catablepons and Flesh Crawlers for hours. Will try to get some nice proggies in.

Any luck with those reports? I can never get it to run longer than an hour.

From: Desirousphere
Any luck with those reports? I can never get it to run longer than an hour.

Do you know why it's failing? It will create a screenshot when it exits. That is usually helpful to see where it was at. They are in the SIMBADIR/includes/srl-6/logs folder.

The only problems I had with it running for hours was if it chased an NPC out of the room and couldn't find them any more. Or if color matches were poor but in that case it generally fails right when started.

You can turn more debugging on by making sure "{$DEFINE DEBUG_ON}" is not commented out near the top. Also search for disableSRLDebug and make sure it's set to false. It will generate an offensive amount of debugging info :D

From: Desirousphere
Any luck with those reports? I can never get it to run longer than an hour.

I already reached my goal of 99 ranged thanks to this script, but the script would always run for atleast 4 hours straight.

I finally posted an updated version. Please let me know if you see any regression.

Changes:
* Added support for player form. You don't need to edit bonsaiFighterSettings.xml any more!
* Added DirectX support (I did not test this, please give feedback if you do).
* Added support for revolution combat mode. I recommend using this for abilities. Recent updates seem to have bugged up the SRL ability functions. In the player form, set manualAbilities to False. In runescape set your combat mode to revolution.
* Removed a useless sleep, added a small sleep between mouse move and uptext checking.

It looks like there are some new problems detecting the in-fight popup. I didn't try to make a new DTM for it at this time. The secondary check is working so it has minimal impact.

I'm having trouble adding waterfiends to the script properly, should I try to use the second colour function in order to ease the detection of waterfiends?

This is what I have

<npc>
<name>Waterfiend</name>
<xp>934</xp>
<constXp>308</constXp>
<color1>7561002</color1>
<tolerance1>6</tolerance1>
<hue1>0.36</hue1>
<sat1>2.35</sat1>
<color2>-1</color2>
<tolerance2>0</tolerance2>
<hue2>0.0</hue2>
<sat2>0.0</sat2>
<dist>4</dist>
<inclDist>0</inclDist>
<minPixels>10</minPixels>
<maxPixels>275</maxPixels>
<maxFightSeconds>100</maxFightSeconds>
<uptext>aterfiend</uptext>
</npc>

From: Yoboi
I'm having trouble adding waterfiends to the script properly, should I try to use the second colour function in order to ease the detection of waterfiends?

Can you post one or two screenshots so I can take a look without getting myself there?

Is the script saying that it can't find them and quitting after a couple of minutes of thrashing?

Will have a play with it within the next day or two and let you know my results bonsai. Appreciate the effort. :)

From: Yoboi
Superb script, I've used it for deadly red spiders, too bad that it can't bank haha.

I personally use a charm impling and it becomes a fighter/charm collector ;)

Thanks for this amazing script!

Hey, can u please provide me with you deadly red spider npc colours and other? I cant get to work this script on DRS, everything else runs just like a charm, already 99 att achieved with this. Too bad it doesnt collect charms and banks

Hey bonsai, got it to run longer than I have been able to before since you updated it. Any way for me to make it slow down on how often it will attempt to attack a new spider?

From: Desirousphere
Hey bonsai, got it to run longer than I have been able to before since you updated it. Any way for me to make it slow down on how often it will attempt to attack a new spider?

Sure, you can add a wait in the main loop after it kills one. Around line 359. Note the wait added below (1-2 second delay).

I really have to wonder if you guys would get better XP fighting something else that you can kill in 1-2 whacks where there are plenty of them in a single place. For lower levels I found junk NPCs like troll brutes got better XP than fighting something closer to your own level.

      if npc.attack(WAIT_FOR_END_OF_FIGHT, checkHealthAndEat, mouseStyle, manualAbilities) then
      begin
         {$IFDEF DEBUG_ON} writeln('***** Killed a ' + npc.name()); {$ENDIF}
         timesFailed := 0;
         antiBan(); 
         tracker.recordKill(npc.name());
         tracker.killHud();
         if ((tracker.numKilled(npc) mod 15) = 0) then
            tracker.progressReport();
         wait(randomRange(1000,2000);
      end

Also, could you post your XML entry for the person above you asking for a DRS entry? Thanks!

Here's what I used to train to 90 atk/def/str at deadly red spiders, hope it works for you.

<npc>
<name>Deadly Red Spider</name>
<xp>399</xp>
<constXp>131.6</constXp>
<color1>5988626</color1>
<tolerance1>11</tolerance1>
<hue1>4.36</hue1>
<sat1>1.51</sat1>
<color2>-1</color2>
<tolerance2>0</tolerance2>
<hue2>0.0</hue2>
<sat2>0.0</sat2>
<dist>5</dist>
<inclDist>0</inclDist>
<minPixels>50</minPixels>
<maxPixels>200</maxPixels>
<maxFightSeconds>120</maxFightSeconds>
<uptext>pider</uptext>
</npc>

Love the script, on my way to 99 slayer and working on reading 1000 wpm ;)

From: Yoboi
Here's what I used to train to 90 atk/def/str at deadly red spiders, hope it works for you.

<npc>
<name>Deadly Red Spider</name>
<xp>399</xp>
<constXp>131.6</constXp>
<color1>5988626</color1>
<tolerance1>11</tolerance1>
<hue1>4.36</hue1>
<sat1>1.51</sat1>
<color2>-1</color2>
<tolerance2>0</tolerance2>
<hue2>0.0</hue2>
<sat2>0.0</sat2>
<dist>5</dist>
<inclDist>0</inclDist>
<minPixels>50</minPixels>
<maxPixels>200</maxPixels>
<maxFightSeconds>120</maxFightSeconds>
<uptext>pider</uptext>
</npc>

OMG, Thank you Yoboi! Finally DRS works like a charm! Thank you really much! :)

EDIT: Hey, btw, bonsai, are you planning in future to add charm picking to your autofighter? That would be flawless :)

From: terrmiits
OMG, Thank you Yoboi! Finally DRS works like a charm! Thank you really much! :)

EDIT: Hey, btw, bonsai, are you planning in future to add charm picking to your autofighter? That would be flawless :)

I'd recommend on leeching 100k tokens and getting a charming imp. By the way, ALWAYS use a ring of life if you have a charming imp.

From: terrmiits
OMG, Thank you Yoboi! Finally DRS works like a charm! Thank you really much! :)

EDIT: Hey, btw, bonsai, are you planning in future to add charm picking to your autofighter? That would be flawless :)

From: Yoboi
I'd recommend on leeching 100k tokens and getting a charming imp. By the way, ALWAYS use a ring of life if you have a charming imp.

Just as I was really getting into writing some scripts life threw me a couple of curveballs and I haven't had any time to spend on it. ATM I'm working 10-11 hours a day and taking care of a 16 month old on my own. Not much time and energy left for runescape lol.

Currently the script is very basic and just focused on XP.

I think the next step would be to use it as a base and produce some NPC specific scripts that could handle more of the drops/banking that people ask for. DRS is obviously a popular one.

I agree with Yobio on the imp. That's a simple way of getting the charms drops. Picking up drops is pretty hard to do in an intelligent manner. I can already see the complaints about how few NPCs it kills, inefficient, etc. Heck, people have already complained about efficiency and if you read the script all it does is find an npc, attack it, and find the next one :)


The easiest additions would probably be potion/prayer support. I don't think anyone has asked for them but they would help boost xp and save food.

I will probably add a foodKey option so we can stop using the (buggy) quick inventory and use the ability bar slots. That a simple coding effort.

From: bonsai



The easiest additions would probably be potion/prayer support. I don't think anyone has asked for them but they would help boost xp and save food.

I will probably add a foodKey option so we can stop using the (buggy) quick inventory and use the ability bar slots. That a simple coding effort.

What I did to bypass the "buggy" quick inventory bar issue is to set a key without the ability bar to whatever hotkey I set the food to.

For example, I switched the = ability bar key to z for food and it never fails to eat at my desired health %.

Fcuking brilliant, banned on 7 year acc :(

From: xJennYx
Fcuking brilliant, banned on 7 year acc :(

How not to post 101.

From: Yoboi
I'd recommend on leeching 100k tokens and getting a charming imp. By the way, ALWAYS use a ring of life if you have a charming imp.

Damn,but it would take a lot of time to get 100k tokens, atm lvl 14 dungeoneering, played for hour or so and got 270+ tokens, i realised that it would take a lot of time to get charming imp. Any recommendations?

EDIT:

" ATM I'm working 10-11 hours a day and taking care of a 16 month old on my own. Not much time and energy left for runescape lol."

I fully understand u, working 12hour shifts on CNC and also father of 2months old son :) Luckily for me, not alone. Cheers!

From: bonsai
Sure, you can add a wait in the main loop after it kills one. Around line 359. Note the wait added below (1-2 second delay).

I really have to wonder if you guys would get better XP fighting something else that you can kill in 1-2 whacks where there are plenty of them in a single place. For lower levels I found junk NPCs like troll brutes got better XP than fighting something closer to your own level.

I've got high enough stats that I two hit spiders, plus I use a Saradomin Godsword to negate prayer and HP drain.

I'll give that code a try soon and let you know.

From: bonsai
Also, could you post your XML entry for the person above you asking for a DRS entry? Thanks!

Sorry guys, been a way for a few days, going to try Yoboi's settings and see if they are better than mine. Will let you all know tonight.



*************************************************************************
***** ERROR: You did not provide a valid playername/nickname/player file
*************************************************************************
****** bonsaiFighter: Script shutting down
—- Saving screenshot: bonsaiFighter.png


Anyone know what's up with this? Filled out the details fine. Didn't have this issue when I tried to use it last.

Im at warped rats and i keep getting this error.
***** Logging player in
***** Health check returning 84 percent
****** Starting auto detect process
***** autoDetect checking for Warped Cockroach
TObjFind.choose: found 6 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=Attack Warped rat
TObjFind.choose: Attack Warped rat matched; will click object
****** Auto detected NPC:
****** Could not set up NPC [autodetect]. Verify name is in XML file.
***** Loop ended, terminating
****** bonsaiFighter: Script shutting down

plus i think i messed something up with the game setting cuz my games looks like this.
[ATTACH=CONFIG]23188[/ATTACH]

From: Rogue Sniper
Im at warped rats and i keep getting this error.
***** Logging player in
***** Health check returning 84 percent
****** Starting auto detect process
***** autoDetect checking for Warped Cockroach
TObjFind.choose: found 6 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=Attack Warped rat
TObjFind.choose: Attack Warped rat matched; will click object
****** Auto detected NPC:
****** Could not set up NPC [autodetect]. Verify name is in XML file.
***** Loop ended, terminating
****** bonsaiFighter: Script shutting down

plus i think i messed something up with the game setting cuz my games looks like this.
[ATTACH=CONFIG]23188[/ATTACH]

That looks like a bug in the autodetect to me. I'll look into it. In the mean time choose warped rat from the drop down list in the form.

I think your screen looks ok.

Thanks bonsai … i got it to work by not using auto detect and i fixed the screen too by resetting the graphics to normal and then back to SMART

Hey very nice script man, able to run it fine however it seems like the script has trouble locating the mobs. For example, the script searches for long amounts of time before finding a mob(I am using Deadly Red Spiders in Varrock Sewers). So it will move around skimming over some of the spiders but it does not pick them up and continues to follow a loop until finally it finds one and restarts the process. Is it maybe a problem with my computer because nobody else seems to have the problem. Anyways thanks again for the awsome script much appreciated.

From: Yoboi
Here's what I used to train to 90 atk/def/str at deadly red spiders, hope it works for you.

<npc>
<name>Deadly Red Spider</name>
<xp>399</xp>
<constXp>131.6</constXp>
<color1>5988626</color1>
<tolerance1>11</tolerance1>
<hue1>4.36</hue1>
<sat1>1.51</sat1>
<color2>-1</color2>
<tolerance2>0</tolerance2>
<hue2>0.0</hue2>
<sat2>0.0</sat2>
<dist>5</dist>
<inclDist>0</inclDist>
<minPixels>50</minPixels>
<maxPixels>200</maxPixels>
<maxFightSeconds>120</maxFightSeconds>
<uptext>pider</uptext>
</npc>

Sorry bit a of a noob, I cannot find where to put this into the script, where did u put it?

From: Moneymake
Sorry bit a of a noob, I cannot find where to put this into the script, where did u put it?

See the second post in the thread for more info on adding new entries.

"Add your entry into the user XML file (SIMBADIR/includes/bonsai/libnpcUser.xml). If this is your first time making one you can use this template for the formatting:"

The file needs to start with <npclist> then the text you quoted then </npclist>

From: bonsai
See the second post in the thread for more info on adding new entries.

"Add your entry into the user XML file (SIMBADIR/includes/bonsai/libnpcUser.xml). If this is your first time making one you can use this template for the formatting:"

The file needs to start with <npclist> then the text you quoted then </npclist>

ok thanks a lot, btw I posted sumthin above this, I should have just incorporated the two dunno why I made separate ones, but do u have any idea about that?

From: Moneymake
ok thanks a lot, btw I posted sumthin above this, I should have just incorporated the two dunno why I made separate ones, but do u have any idea about that?

That problem sounds like a bad color match, and hopefully the new entry will take care of it.

For some reason my Rejuvinate ability will not activate while everything else does. Any thoughts? I didn't have an issue with past versions, but it's been about a month since I've used it.

From: killercrashy
For some reason my Rejuvinate ability will not activate while everything else does. Any thoughts? I didn't have an issue with past versions, but it's been about a month since I've used it.

Did you try it with manualAbilities set to false and runescape set to combat mode "revolution"? Then the script doesn't even need to press abilities.

You can turn on the debugging and see what's printing when it checks the abilities. If the script doesn't think it's ready that would be something in the SRL6 library. The ability checking function is a bit rough.

From: bonsai
Did you try it with manualAbilities set to false and runescape set to combat mode "revolution"? Then the script doesn't even need to press abilities.

You can turn on the debugging and see what's printing when it checks the abilities. If the script doesn't think it's ready that would be something in the SRL6 library. The ability checking function is a bit rough.

I tried using revolution - problem is that it doesn't automatically activate threshold or ultimate abilities (rejuvenate being ultimate).
Looking in the debug the script is able to use my other abilities, but simply isn't showing anything with the slot containing rejuvinate.

Niiice bot! but it would be perfect if it could go back to town and fill up with food and go back to stronghold of security and find the Flesh Crawlers and repeat :)
+5 stars

Thanks bonsai for helping me achieve 99 attack :)

hi ive been using this script very often lately. a problem i noticed is that the tnpc.isinfight function would detect an enemy health bar when the mouse was hovering over it, and i was not necessarily fighting it. this caused the script to stop with the "is in fight too long" case. so i added a case function so that every once in a while it does a smallmousemovement function. these functions are in include/bonsai, for those who do not know.

If anyone is able to help me out

I see that on the npc list theres deadly red spiders and I'm in the Varrock Dungeon and it seems to not log in or not attack the spider any help with this situation… sorry for sounding like a scrub

From: TimeRiders
If anyone is able to help me out

I see that on the npc list theres deadly red spiders and I'm in the Varrock Dungeon and it seems to not log in or not attack the spider any help with this situation… sorry for sounding like a scrub

Would have to see the debug output from the simba screen to tell if it's a setup issue or just a player manager / player name type issue.

Double check your settings vs. the setup guide. OpenGL/DirectX, screen size, display settings…

When you run the script, make sure you're selecting the same (opengl/directx) as you used in setting up. Make sure the player file and name are correct (and it is case sensitive).

Yoboi posted this entry for spiders, it may work better. You can edit SIMBADIR/includes/bonsai/libnpcStandard.xml

From: Yoboi
Here's what I used to train to 90 atk/def/str at deadly red spiders, hope it works for you.

<npc>
<name>Deadly Red Spider</name>
<xp>399</xp>
<constXp>131.6</constXp>
<color1>5988626</color1>
<tolerance1>11</tolerance1>
<hue1>4.36</hue1>
<sat1>1.51</sat1>
<color2>-1</color2>
<tolerance2>0</tolerance2>
<hue2>0.0</hue2>
<sat2>0.0</sat2>
<dist>5</dist>
<inclDist>0</inclDist>
<minPixels>50</minPixels>
<maxPixels>200</maxPixels>
<maxFightSeconds>120</maxFightSeconds>
<uptext>pider</uptext>
</npc>

I tried to run this the other day to validate I added directX properly to my machine.

The colors in the lumby dungeon are changed. It used to be kind of grey on grey now it's much brighter. Cockroaches used to be pinkish, now they're red.

I didn't check the stronghold and should probably double check my runescape settings.

Others seeing the same? Not sure I have the mental energy to go recolor all the entries :)

From: bonsai
I tried to run this the other day to validate I added directX properly to my machine.

The colors in the lumby dungeon are changed. It used to be kind of grey on grey now it's much brighter. Cockroaches used to be pinkish, now they're red.

I didn't check the stronghold and should probably double check my runescape settings.

Others seeing the same? Not sure I have the mental energy to go recolor all the entries :)

I'm having the same experience in Stronghold. Had to redo the colors myself. There's a bit of a learning curve, but one you get the hang of it, you're good.

this script is pretty good, the only issue I'm having is that it just doesnt recognize the guthix blessing spell (it skips over it even if i put it to the right of death's swiftness). Do you know why?

I am running it at waterfiends and black demons without any other issues.

I think I managed to hard code the guthix blessing in by tying it to death's swiftness but idk if there is a better solution

Script wont eat at all

From: TimeRiders
Script wont eat at all

To make it eat you need to drag food to the action bar and customise key bind it to the 'z' key.

It wouldn't let me run the script. I got this ;

-------------------------------------------------------
-- Installing bonsaiFighter
-------------------------------------------------------
-- Checking for bonsai include folder:
--     include folder already exists, no change made
-------------------------------------------------------
-- Installing latest libupdater.simba
--     file C:\Simba\Includes\bonsai\libupdater.simba already exists, renaming to .bak
--     removing file C:\Simba\Includes\bonsai\libupdater.simba.bak
--     Script C:\Simba\Includes\bonsai\libupdater.simba has been updated
-------------------------------------------------------
-- Installing latest libtracker.simba
--     file C:\Simba\Includes\bonsai\libtracker.simba already exists, renaming to .bak
--     removing file C:\Simba\Includes\bonsai\libtracker.simba.bak
--     Script C:\Simba\Includes\bonsai\libtracker.simba has been updated
-------------------------------------------------------
-- Installing latest libtask.simba
--     file C:\Simba\Includes\bonsai\libtask.simba already exists, renaming to .bak
--     removing file C:\Simba\Includes\bonsai\libtask.simba.bak
--     Script C:\Simba\Includes\bonsai\libtask.simba has been updated
-------------------------------------------------------
-- Installing latest libnpc.simba
--     file C:\Simba\Includes\bonsai\libnpc.simba already exists, renaming to .bak
--     removing file C:\Simba\Includes\bonsai\libnpc.simba.bak
--     Script C:\Simba\Includes\bonsai\libnpc.simba has been updated
-------------------------------------------------------
-- Installing latest libitem.simba
--     file C:\Simba\Includes\bonsai\libitem.simba already exists, renaming to .bak
--     removing file C:\Simba\Includes\bonsai\libitem.simba.bak
--     Script C:\Simba\Includes\bonsai\libitem.simba has been updated
-------------------------------------------------------
-- Installing latest libbreak.simba
--     file C:\Simba\Includes\bonsai\libbreak.simba already exists, renaming to .bak
--     removing file C:\Simba\Includes\bonsai\libbreak.simba.bak
--     Script C:\Simba\Includes\bonsai\libbreak.simba has been updated
-------------------------------------------------------
-- Installing latest libobjfind.simba
--     file C:\Simba\Includes\bonsai\libobjfind.simba already exists, renaming to .bak
--     removing file C:\Simba\Includes\bonsai\libobjfind.simba.bak
--     Script C:\Simba\Includes\bonsai\libobjfind.simba has been updated
-------------------------------------------------------
-- Installing latest libnpcStandard.xml
--     file C:\Simba\Includes\bonsai\libnpcStandard.xml already exists, renaming to .bak
--     removing file C:\Simba\Includes\bonsai\libnpcStandard.xml.bak
--     Script C:\Simba\Includes\bonsai\libnpcStandard.xml has been updated
-------------------------------------------------------
-- Installing latest bonsaiFighter.simba
--     file C:\Simba\Scripts\bonsaiFighter.simba already exists, renaming to .bak
--     removing file C:\Simba\Scripts\bonsaiFighter.simba.bak
--     Script C:\Simba\Scripts\bonsaiFighter.simba has been updated
-------------------------------------------------------
-- Installing latest bonsaiFighterSettings.xml
--     file C:\Simba\Scripts\bonsaiFighterSettings.xml already exists, renaming to .bak
--     removing file C:\Simba\Scripts\bonsaiFighterSettings.xml.bak
--     Script C:\Simba\Scripts\bonsaiFighterSettings.xml has been updated
-------------------------------------------------------
-- Install Completed
-------------------------------------------------------
Successfully executed.

>

That's fine, Beefman. It installed the scripts. Now open up bonsaifighter.simba and it should pull up a form.

As we were discussing the colors have changed for most everything so you'll probably have to read post 2 and color what you want. Or ask in the thread if someone has a current entry for what you want.

From: bonsai
That's fine, Beefman. It installed the scripts. Now open up bonsaifighter.simba and it should pull up a form.

As we were discussing the colors have changed for most everything so you'll probably have to read post 2 and color what you want. Or ask in the thread if someone has a current entry for what you want.

Ah my bad, sorry for being a newbie. :P thanks for the help ha. Working now!

Still can't get the script working. I run the scripts, logs in and looks for monsters (I'm at Stronghold of Security; Goblin, Minotaur, Wolf) However, it cannot find anything. It looks and shortly executes after.
I've checked my settings and i have my interface settings as Always show target information checked and it is completely zoomed out and i've check all my other settings. Any idea?

The colors have changed, it probably can't locate the NPCs. You'll have to capture the new colors (see post 2 in this thread).

If anyone has recolored these already, please post updated colors. I can work them into the xlm file.

Not sure when I will get time to redo them. Life is becoming more free but I think I have one more busy month coming before I really get a break.

I'll try and learn it tomorrow and fix Troll brutes, if I get the time.

when u guys re-take the colors please use 0% transparency so that we will all get similar results and not have problems with the colors :) I myself will see if I can capture some images and compile them.

I got it to attack and kill the Minotaurs, but after it attacks the first one it just logs off. It just didnt detect that it killed the minotaur. Is there any way to fix this? here is what it said in the debug:
***** Logging player in
***** Health check returning 100 percent
TObjFind.choose: found 2 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
TObjFind.choose: chooseOption called on object, result=True
***** Fight initiated
***** Health check returning 100 percent
****** Something wrong… in fight too long
****** bonsaiFighter: Script shutting down
////////////////////////////////////////////////////////////////////////////////////////////////////
////////// ( )\ ) ) ) //////////
////////// ( )\ ) ( (()/( ( ( ( ( /( ( /( ( ( //////////
////////// )((_) ( ( ( ( /( )\ /(_)) )\ )\))( )\()) )\()) ))\ )( //////////
////////// ((_)_ )\ )\ ) )\ )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\ //////////
////////// | _ ) ((_) _(_/( ((_)((_)_ (_) | |_ (_) (()(_)| |(_)| |_ (_)) ((_) //////////
////////// | _ \/ _ \| ' \))(_-</ _` | | | | __| | |/ _` | | ' \ | _|/ -_) | '_| //////////
////////// |___/\___/|_||_| /__/\__,_| |_| |_| |_|\__, | |_||_| \__|\___| |_| //////////
////////// |___/ //////////
////////// //////////
////////// Script runtime: //////////
////////// 32 sec(Total) 32 sec(Active) 0 sec(Break) //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////
Successfully executed.

////////// Script runtime: //////////
////////// 1 hr 26 min 15 sec(Total) 1 hr 26 min 15 sec(Active) 0 sec(Break) //////////
////////// //////////
//////////////////////////////////////// KILLS ////////////////////////////////////////
////////// Giant Spider //////////
////////// 706(Killed) 491(per hour run) 491(per hour active) //////////
////////// 60010(xp) 41742(per hour run) 41742(per hour active) //////////
////////// 19768(const xp) 13750(per hour run) 13750(per hour active) //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////


Having some issues with it attacking 5-6 spiders at a time, i end up surviving but it uses 7-8 lobsters due to continuously engaging more instead of finishing off the ones that are attacking it.

<npc>
<name>Minotaur</name>
<xp>34</xp>
<constXp>11.2</constXp>
<color1>2391215</color1>
<tolerance1>28</tolerance1>
<hue1>0.17</hue1>
<sat1>0.92</sat1>
<color2>-1</color2>
<tolerance2>0</tolerance2>
<hue2>0.0</hue2>
<sat2>0.0</sat2>
<dist>8</dist>
<inclDist>0</inclDist>
<minPixels>20</minPixels>
<maxPixels>63</maxPixels>
<maxFightSeconds>120</maxFightSeconds>
<uptext>Minotaur</uptext>
</npc>
Here are updated colors for the minotaurs and it magically started to detect when it killed them so now it doesn't just attack one and log… Great bot :)
And about the colors.. every once in a while it will attack a rat.. idk why.. maybe its just antiban or maybe its the colors, but its not really a problem. I just wanted to mention that it does this.

From: Reliquin95726

Having some issues with it attacking 5-6 spiders at a time, i end up surviving but it uses 7-8 lobsters due to continuously engaging more instead of finishing off the ones that are attacking it.

Haha, I love when that happens!!

Do you have the pop ups enabled? The script isn't detecting that you got into a fight so it's attacking another NPC.

More of the debug output would be helpful to see the problem.

From: shazs

And about the colors.. every once in a while it will attack a rat.. idk why.. maybe its just antiban or maybe its the colors, but its not really a problem. I just wanted to mention that it does this.

The rat should be due to a color match in common with the minotaur. Harmless enough imo although it will be a little bit off on XP tracking.

Thanks for sharing the entry back! Anyone else who can please do the same. 20-63 looks pretty tight on the size match.

I'm planning on working on the script in a few weeks when I'm settled down. I have some new logic for the fight detection so maybe fix some of those false alarms.

20-63 is the original size match that you had listed :p I'll see if I can help you out and get some more colors for you. Is there any potential for banking being added to the bot?

From: shazs
20-63 is the original size match that you had listed :p I'll see if I can help you out and get some more colors for you. Is there any potential for banking being added to the bot?

Oh, that's because I was matching on the tiny white horns. Run the test program in post 2 against your screenshot and it should show you how big your current matches are returning. If they're larger than 63 you'll be missing them with that entry.

Adding banking would mean making a branch script just for a specific NPC. I've thought about doing it for DRS since so many people like them. It's not a huge chore, the main script logic is simple. It just needs SPS maps and a little logic to use them.

From: bonsai
Haha, I love when that happens!!

Do you have the pop ups enabled? The script isn't detecting that you got into a fight so it's attacking another NPC.

More of the debug output would be helpful to see the problem.

next time i run it ill run the debug with it. also ill check out to see if i had that running, im pretty sure i do but you never know :-P ill give ya an update tomorrow probably.

I have a suggestion;

It would be awesome if the script could use regenerate (which only works out of combat) when below a certain HP threshold, that way the script could run indefinitely, and I could use a 2H weapon! =]

But the script runs pretty good on Giant Spiders and Ankous for me on OpenGL, thanks a bunch for your work!

for some reason it doesn't attack anything. having problem finding npc

What npc are you attempting to attack? The colors may not have been updated for the specific npc yet.

From: rewopelet
for some reason it doesn't attack anything. having problem finding npc

Like Rewopelet said what npc's are you trying to attack ?

I encountered this problem when i first started using the script , you should check and make sure you set up your interface and graphics correctly, are you running in OpenGL or Direct-x ?

I'm actually testing the script, been running it for a good 10 hours on two accounts. Works fairly decent, love how you can adjust things so easily.

did DRS got a colour change?

only one way to find out :p

From: xevo1
I'm actually testing the script, been running it for a good 10 hours on two accounts. Works fairly decent, love how you can adjust things so easily.

Would you mind sharing your settings/monsters?

Well, I'm using the default NPC's that came with it - I haven't tried adding my own!

But which npc's are you attacking? Some of the colors haven't changed such as catablepons, but others such as corpse mages need to be updated. It would just help to know which ones dont need to be updated.

there should be a page where players post their monster's colour number and such ~.~ thought it was a great idea.

From: nutta124
there should be a page where players post their monster's colour number and such ~.~ thought it was a great idea.

Try to make it a forum that's a great idea in my opinion :)

i looked at the libnpcStandard.xml.txt

and just informing you that the deadly red spider information on their is false

Just letting you know , i don't know why but the script will be running fine then it will attack a npc not fully kill and hop to another and continue like its not being attacked other times it will attack the ones it didn't finish but ive died numerous times now and it's just getting so frustrating cause i will think to my self that i can go do something else other than babysitting and come back dead ( the script is great don't get me wrong dude, just it's something to look into i'm not sure if this is happening/happened to other individuals running this script)

where do i add my own npc? in the script it siad in ''libnpcUser.xml'' but theres only libpcStandard.xml?!?

From: nutta124
where do i add my own npc? in the script it siad in ''libnpcUser.xml'' but theres only libpcStandard.xml?!?

Someone correct me if im wrong but you download the second file it should say "libnpcStandard.xml.txt" then you just add the npc like the rest

From: TimeRiders
Someone correct me if im wrong but you download the second file it should say "libnpcStandard.xml.txt" then you just add the npc like the rest

libnpcStandard.xml is the file automatically installed by the script. You make libnpcUser.xml yourself, just follow the same structure as the other one.

If the script updates it will only change libnpcStandard.xml and you won't lose your manual entries in libnpcUser.xml.

You can also add entries to libnpcStandard.xml. You just carry the risk that the script will overwrite them.

From: TimeRiders
Just letting you know , i don't know why but the script will be running fine then it will attack a npc not fully kill and hop to another and continue like its not being attacked other times it will attack the ones it didn't finish but ive died numerous times now and it's just getting so frustrating cause i will think to my self that i can go do something else other than babysitting and come back dead ( the script is great don't get me wrong dude, just it's something to look into i'm not sure if this is happening/happened to other individuals running this script)

If it moves on to another NPC that means it thought the fight was over (did not detect the in-fight popup).

I need to rework some of that logic. I'm thinking to use the red targeting circle as a primary indicator and the popup as a secondary.

It's disappointing it didn't recognize your low health and let it die.

The script ran for 4 hours but it self shutdown

Exception in Script: Runtime error: "Out of memory" at line 145, column 23 in file "C:\Simba\Includes\srl-6\lib\utilities\wrappers.simba"
The following DTMs were not freed: [0]
The following bitmaps were not freed: [Minimap Mask, SMART Debug Image, Gametab Bitmap[13], Gametab Bitmap[12], Gametab Bitmap[11], Gametab Bitmap[10], Gametab Bitmap[9], Gametab Bitmap[8], Gametab Bitmap[7], Gametab Bitmap[6], Gametab Bitmap[5], Gametab Bitmap[4], Gametab Bitmap[3], Gametab Bitmap[2], Gametab Bitmap[0], Gametab Bitmap[1]]
File[C:\Simba\Includes\SRL-6/logs/SRL log (10-07-14 at 10.31.50 PM).txt] has not been freed in the script, freeing it now.

From: nutta124
The script ran for 4 hours but it self shutdown

Yuck I don't like the looks of that one at all. No clue how to debug a memory leak in a script lol.

It's probably some slop in libobjfind.simba.

You doing anything unusual like a two color npc?

No, i was using the script's giant spider.

can someone add waterfiends?

I've been working on automatic detection. It's about half baked.

It finds NPCs based on screen movement, grabs colors around the mouse area, and tests them to find usable ones.

It's pretty sweet. No more coloring!! I have it working, just refining some ideas like balancing accuracy / speed.

Whoa, but what if theres 2 different monsters in an area? O.o

From: nutta124
Whoa, but what if theres 2 different monsters in an area? O.o

Yes, that can be a problem. I can keep an NPC name in the form and reject incorrect matches on the motion detection.

Can't do much about a color matching both unless you want to right click, decide it's the wrong one, and move one. Might as well just kill the dang thing ehehe

It runs the mouse around like a madman for a couple of minutes right now. Looking to smooth that out so it learns over time but still gets killing asap.

Hitting background colors is a problem, the findcolors hangs for a long time collecting them.

cool +1

From: bonsai
Yes, that can be a problem. I can keep an NPC name in the form and reject incorrect matches on the motion detection.

Can't do much about a color matching both unless you want to right click, decide it's the wrong one, and move one. Might as well just kill the dang thing ehehe

It runs the mouse around like a madman for a couple of minutes right now. Looking to smooth that out so it learns over time but still gets killing asap.

Hitting background colors is a problem, the findcolors hangs for a long time collecting them.

Hey mate, whenever I try to run your script and the fight menu pops up and when i have everything checked
And click Run It just opens a new client? i really need help, thanks.

I'm not sure I understand. When you hit run on the form a SMART window should come up and start loading runescape.

Are you saying you get more than one of these?

What shows up in the simba console at the bottom of the window?

From: bonsai
I'm not sure I understand. When you hit run on the form a SMART window should come up and start loading runescape.

Are you saying you get more than one of these?

What shows up in the simba console at the bottom of the window?

I already have one but I get another one?

it doesnt use my weapon's special -.- i have the special icon in the action bar but it never been activate

HELPPP!@ D:

Why does it only attack 1 monster then it just stays there??

From: alee1
Why does it only attack 1 monster then it just stays there??

its probably couldnt find the colour. what monster were you fighting?

From: nutta124
its probably couldnt find the colour? what monster are you fighting?

Giant spiders, can you help me with team viewer

From: alee1
Giant spiders, can you help me with team viewer

the giant spider's colors are pretty old(i think O.o). you should try using the ACA tool to get a better color
if you want i can give you my Fire Giant(Chaos tunnel)'s color if you're interested, its not prefect but i could run it for 2/3 hours before running out of food supply

From: nutta124
the giant spider's colors are pretty old(i think O.o). you should try using the ACA tool to get a better color
if you want i can give you my Fire Giant(Chaos tunnel)'s color if you're interested, its not prefect but i could run it for 2/3 hours before running out of food supply

Yea sure that would be better.

From: alee1
Yea sure that would be better.

you're welcome~

<npc>
<name>Fire giant</name>
<xp>424</xp>
<constXp>140</constXp>
<color1>2900866</color1>
<tolerance1>26</tolerance1>
<hue1>0.14</hue1>
<sat1>1.10</sat1>
<color2>-1</color2>
<tolerance2>0</tolerance2>
<hue2>0.0</hue2>
<sat2>0.0</sat2>
<dist>4</dist>
<inclDist>0</inclDist>
<minPixels>450</minPixels>
<maxPixels>1500</maxPixels>
<maxFightSeconds>180</maxFightSeconds>
<uptext>iant</uptext>
</npc>

From: nutta124
you're welcome~

Hey man thanks for the code, but just one question, I add it to the notepad where all
The codes for the other monsters? Just that?

yeah, add it to ''libnpcStandard.xml''
Then, in the start up menu there should be ''Fire Giant'' in the monster list

bonsai!!~~ the manualAbilities wouldnt click on the ''Special Attack'' icon -.- its a threshold ability so Revolution would not activate it. FIX?! T-T
i really need it for my saradomin gs's healing ability~~ thank you :3

From: alee1
I already have one but I get another one?

I don't know what could cause that. I assume it happens with any script?

Did you try something simple like:

program new;
{$DEFINE SMART}
{$i srl-6/srl.simba}

begin
  clearDebug();
  setupSRL();
end.

If it still happens, post in one of the general help areas, it's not a script issue.

From: alee1
Why does it only attack 1 monster then it just stays there??

The debug window should tell you what it's thinking. If you didn't enable it:

Around line 7 there is a line of code: "{$DEFINE DEBUG_ON}". Comment this out to reduce the printed output to a minimum. Uncomment it to get detailed logging for reporting problems and troubleshooting.

To enable SRL level debugging, search for disableSRLDebug and make sure it is set to 'False'.

From: nutta124
it doesnt use my weapon's special -.- i have the special icon in the action bar but it never been activate

HELPPP!@ D:

Are you using the manual abilities? If so, the srl function to check if the ability is ready might not be giving back a proper answer.

I use the automatic (revolution?), I don't know what it would do there.

Yeah, im using manual abilities. revolution cant active threshold ability nor ultimate ability :/

From: nutta124
bonsai!!~~ the manualAbilities wouldnt click on the ''Special Attack'' icon -.- its a threshold ability so Revolution would not activate it. FIX?! T-T
i really need it for my saradomin gs's healing ability~~ thank you :3

Check out includes/bonsai/libnpc.simba

Uncomment the writeln near the top of Tnpc._doAbilities

Then run it and you will see what actionbar.getBilityCooldown() is telling us.

If that's a consistent number when ready, let's say '99', add 99 to the if statement there

"if (pct = 1) or (pct = 99) then"

I'm hoping to publish a revamped version in a week or two. The color detect stuff is close to complete.

I think the colors changed on the popup box. That can lead to you starting new fights before done and swarming yourself.

People might want to try this DTM at the top of includes/bonsai/libnpc.simba:

_npcInfightDTM = 'mlwAAAHicY2eAAEYgZgViTiTMBpWTgGIxIOaDqgMBbkERnJgLKM+CAzPiwVAAAKx0AgE=';

wait im a little confused o.o so i open libnpc in simba then Uncomment the writeln near the top of Tnpc._doAbilities? what does uncomment meant in this context?

yo man i am using also sgds on fire giants and i picked that special ability on Z instead of food and its working try it

after update it stop working cant find npcs

From: mathozz
after update it stop working cant find npcs

Argh. Can't get this autocolor version finished fast enough!

I'll try to figure out how to fit the sword special into things while I'm at it.

so script dont working now right>

is it just the color of the fire giants isn't matching?

its working fine for me

Script runtime: //////////
////////// 3 hr 55 min 59 sec(Total) 3 hr 38 min 45 sec(Active) 17 min 13 sec(Break)//////////
////////// //////////
//////////////////////////////////////// KILLS ////////////////////////////////////////
////////// Fire giant //////////
////////// 945(Killed) 240(per hour run) 259(per hour active) //////////
////////// 400680(xp) 101871(per hour run) 109894(per hour active) //////////
////////// 132300(const xp) 33637(per hour run) 36286(per hour active) //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

have to stop because i was running out of food

weird i used same colors as nutta posted and it wasnt working :X btw nutta if you using that sara godsword use special on z as food you can stay here forever with that heals

ok its working now iam on greater demons and its ok:D

Yeah, it would work if i only use the basic ability (revaluation) and dont use any threshold/ultimate (manual)

Any way you can fix the "***** Tnpc.isInFight() found more than one popup box open on screen" error? It keeps going to the next NPC before the first is dead. Otherwise great script and custom NPCs are working great.

From: therossity
Any way you can fix the "***** Tnpc.isInFight() found more than one popup box open on screen" error? It keeps going to the next NPC before the first is dead. Otherwise great script and custom NPCs are working great.

Did you try the new DTM I posted a few posts back?

I'm working on a script update, it's probably a couple of weeks out.

the script doesn't click on the world i desire ~.~

From: bonsai
Did you try the new DTM I posted a few posts back?

I'm working on a script update, it's probably a couple of weeks out.

Yes, just tried it and while the error itself does not appear anymore in Simba, the script still attacks before killing the one it started with.

//////////////////////////////////////// KILLS ////////////////////////////////////////
////////// Fire giant //////////
////////// 295(Killed) 393(per hour run) 393(per hour active) //////////
////////// 125080(xp) 166755(per hour run) 166755(per hour active) //////////
////////// 41300(const xp) 55061(per hour run) 55061(per hour active) //////////
////////// //////////
//////////////////////////////////////////////////////////////////////////////////////////////////// gr8 xp

Another bug is that it's counting each kill as 2. The counter increeases by 1 when engaging a monster and then again after it dies. This is doubled when the above bug I posted happens.

WHAT?! 160k exp per hour!? what weapon were you using?

From: therossity
Another bug is that it's counting each kill as 2. The counter increeases by 1 when engaging a monster and then again after it dies. This is doubled when the above bug I posted happens.

Would have to see the debug output to tell what it's thinking.

From: bonsai
Would have to see the debug output to tell what it's thinking.

***** Killed a Werewolf
TObjFind.choose: found 4 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 2
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 3
TObjFind.choose: examining mouseText=
****** Didnt find a Werewolf to fight. timesFailed = 1
TObjFind.choose: found 5 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 2
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** Fight initiated
***** Health check returning 86 percent
***** Tnpc.isInFight: did not find standard DTM, trying color match
***** End of fight detected
***** Killed a Werewolf
***** Health check returning 83 percent

Why does it take Agees to kill it says'finding ankou 100 times.
Getting pissed

From: alee1
Why does it take Agees to kill it says'finding ankou 100 times.
Getting pissed

Calm down man, this script doesn't owe you anything.

it started to use special attack now <3

but sometime it uses the special attack when it not ready(not enough adrenaline)

different sword require different amout of adrenaline to use their special (25%, 30% 50% 60% ect)

i been getting this problem lately: upon logging on it would type both my ID and Password in the ''username'' box

////////// Script runtime: //////////
////////// 9 hr 4 min 3 sec(Total) 8 hr 47 min 15 sec(Active) 16 min 48 sec(Break) //////////
////////// //////////
//////////////////////////////////////// KILLS ////////////////////////////////////////
////////// Fire giant //////////
////////// 2804(Killed) 309(per hour run) 319(per hour active) //////////
////////// 1188896(xp) 131114(per hour run) 135292(per hour active) //////////
////////// 392560(const xp) 43292(per hour run) 44672(per hour active) //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

longerprog:D

auto detected NPC: Could not set up NPC [autodetect]. Verify name is in XML file.
script shutting down.

—- Client is ready.
—- Setup SRL in 17296ms.
– setupSRL(): True
***** Logging player in
***** Health check returning 86 percent
****** Starting auto detect process
***** autoDetect checking for Warped Cockroach
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Corpse Spider
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Warped Fly
TObjFind.choose: found 3 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** autoDetect checking for Crawling corpse torso
TObjFind.choose: found 4 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** autoDetect checking for Warped rat
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Skeleton
TObjFind.choose: found 5 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 2
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** autoDetect checking for Warped bat
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Corpse archer
TObjFind.choose: found 1 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
***** autoDetect checking for Skoblin
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Corpse mage
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Troll brute
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Goblin
TObjFind.choose: found 9 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** autoDetect checking for Minotaur
TObjFind.choose: found 3 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 2
TObjFind.choose: examining mouseText=
***** autoDetect checking for Wolf
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Zombie
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Flesh Crawler
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Giant Rat
TObjFind.choose: found 1 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
***** autoDetect checking for Giant Spider
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Catablepon
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Scorpion
TObjFind.choose: found 1 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
***** autoDetect checking for Spider
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Deadly Red Spider
TObjFind.choose: found 1 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=Open Gate of War
***** autoDetect checking for Ankou
TObjFind.choose: found 17 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** autoDetect checking for Ghost
TObjFind.choose: found 9 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** autoDetect checking for Moss Giant
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Shade
TObjFind.choose: found 0 possible objects
****** Auto detected NPC:
****** Could not set up NPC [autodetect]. Verify name is in XML file.
***** Loop ended, terminating
****** bonsaiFighter: Script shutting down
—
It logged into rs, started moving the mouse around the screen (looking for goblins), and didn't click/recognize them, but I installed the file, and it has the Always show target information checked.
Goblin is in the xml file..

goblin text:

<npc>
<name>Goblin</name>
<xp>34</xp>
<constXp>1</constXp>
<color1>3433072</color1>
<tolerance1>26</tolerance1>
<hue1>0.27</hue1>
<sat1>0.25</sat1>
<color2>-1</color2>
<tolerance2>0</tolerance2>
<hue2>0.0</hue2>
<sat2>0.0</sat2>
<dist>3</dist>
<inclDist>0</inclDist>
<minPixels>100</minPixels>
<maxPixels>450</maxPixels>
<maxFightSeconds>120</maxFightSeconds>
<uptext>oblin</uptext>
</npc>


Any suggestions?

From: theorange
auto detected NPC: Could not set up NPC [autodetect]. Verify name is in XML file.
script shutting down.

Any suggestions?

Don't use autodetect, fill in goblin. If it still won't find them the color is outdated.

From: bonsai
Don't use autodetect, fill in goblin. If it still won't find them the color is outdated.

That fixed it! They aren't eating their food in the inventory though… It does pause/logout/quit if the health gets to the set percentage, but food does not become eaten… What to do for that?

It also keeps trying to use memberskills on f2p servers, how to disable that?

Sometimes it fails to associate with a RS window, getting stuck in the "waiting for RS to load" phase, even though the screen is on directX/etc/with all the proper settings/transperency levels and all, how to fix that? Even when I close and reload the rs window occasionally it won't recognize the window it creates itself. – Only 2 builds are running properly right now, any time I try another instance, fresh install, proper graphic settings, it will load RS, log the player in, then it wont' interact with the screen at all, but it has the exact same settings as the two running ones

Also:

****** Something wrong… in fight too long
****** bonsaiFighter: Script shutting down

Also:
If they are in the stronghold of security, and missclick to step through a door, they get stuck, and it doesn't recognize it is stuck. Similarly if it tries to click on a monster in another room it gets stuck.


Also:
[11:40:21 PM] a: "failed to spawn smart client"
Nice script btw.

From: theorange
auto detected NPC: Could not set up NPC [autodetect]. Verify name is in XML file.
script shutting down.

—- Client is ready.
—- Setup SRL in 17296ms.
– setupSRL(): True
***** Logging player in
***** Health check returning 86 percent
****** Starting auto detect process
***** autoDetect checking for Warped Cockroach
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Corpse Spider
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Warped Fly
TObjFind.choose: found 3 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** autoDetect checking for Crawling corpse torso
TObjFind.choose: found 4 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** autoDetect checking for Warped rat
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Skeleton
TObjFind.choose: found 5 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 2
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** autoDetect checking for Warped bat
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Corpse archer
TObjFind.choose: found 1 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
***** autoDetect checking for Skoblin
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Corpse mage
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Troll brute
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Goblin
TObjFind.choose: found 9 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** autoDetect checking for Minotaur
TObjFind.choose: found 3 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 2
TObjFind.choose: examining mouseText=
***** autoDetect checking for Wolf
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Zombie
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Flesh Crawler
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Giant Rat
TObjFind.choose: found 1 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
***** autoDetect checking for Giant Spider
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Catablepon
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Scorpion
TObjFind.choose: found 1 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
***** autoDetect checking for Spider
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Deadly Red Spider
TObjFind.choose: found 1 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=Open Gate of War
***** autoDetect checking for Ankou
TObjFind.choose: found 17 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** autoDetect checking for Ghost
TObjFind.choose: found 9 possible objects
TObjFind.choose: mouse moved to object 0
TObjFind.choose: examining mouseText=
TObjFind.choose: mouse moved to object 1
TObjFind.choose: examining mouseText=Attack
TObjFind.choose: Attack matched; will click object
***** autoDetect checking for Moss Giant
TObjFind.choose: found 0 possible objects
***** autoDetect checking for Shade
TObjFind.choose: found 0 possible objects
****** Auto detected NPC:
****** Could not set up NPC [autodetect]. Verify name is in XML file.
***** Loop ended, terminating
****** bonsaiFighter: Script shutting down
—
It logged into rs, started moving the mouse around the screen (looking for goblins), and didn't click/recognize them, but I installed the file, and it has the Always show target information checked.
Goblin is in the xml file..

goblin text:

<npc>
<name>Goblin</name>
<xp>34</xp>
<constXp>1</constXp>
<color1>3433072</color1>
<tolerance1>26</tolerance1>
<hue1>0.27</hue1>
<sat1>0.25</sat1>
<color2>-1</color2>
<tolerance2>0</tolerance2>
<hue2>0.0</hue2>
<sat2>0.0</sat2>
<dist>3</dist>
<inclDist>0</inclDist>
<minPixels>100</minPixels>
<maxPixels>450</maxPixels>
<maxFightSeconds>120</maxFightSeconds>
<uptext>oblin</uptext>
</npc>


Any suggestions?

Happens to me to

From: mathozz
////////// Script runtime: //////////
////////// 9 hr 4 min 3 sec(Total) 8 hr 47 min 15 sec(Active) 16 min 48 sec(Break) //////////
////////// //////////
//////////////////////////////////////// KILLS ////////////////////////////////////////
////////// Fire giant //////////
////////// 2804(Killed) 309(per hour run) 319(per hour active) //////////
////////// 1188896(xp) 131114(per hour run) 135292(per hour active) //////////
////////// 392560(const xp) 43292(per hour run) 44672(per hour active) //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

longerprog:D

Hey m8, where do I put the fire giant code at?
Thanks :)

From: alee1
Hey m8, where do I put the fire giant code at?
Thanks :)

put it in libnpcStandard.xml in Simba\Includes\bonsai

Idk what's wrong is it me or is the script slow ? It rarly kills anything..

From: alee1
Idk what's wrong is it me or is the script slow ? It rarly kills anything..

I'm aware it has deteriorated from game updates. When it's working properly it moves right on from one to the next.

I'm working on a new version. I need about 2 days of coding and a day of testing. Maybe by this weekend if life is quiet.

From: bonsai
I'm aware it has deteriorated from game updates. When it's working properly it moves right on from one to the next.

I'm working on a new version. I need about 2 days of coding and a day of testing. Maybe by this weekend if life is quiet.

Any chance of a loot function? :D

If anyone wants to beta test the autocoloring version, I think it's stable enough to let you try.

It's a long way from done so keep an eye on it. I killed myself yesterday.

When the form comes up, type "autodetect" into the NPC name.

The first time you fight something takes a while to get some colors but once it gets cranking it gets better and better. If you return to an NPC you already colored it gets right down to business.

Replace your SIMBADIR/scripts/bonsaiFighter.simba and SIMBADIR/includes/bonsai/libnpc.simba with the below.

SIMBADIR/includes/bonsai/libcolorizer.simba is a new file, put it in place.

Let me know how you do!!

SIMBADIR/scripts/bonsaiFighter.simba:

// -----------------------------------------------------------------------------
// --    bonsaiFighter.simba
// --    Written by: bonsai
// -----------------------------------------------------------------------------
program bonsaiFighter;
{$DEFINE SMART}
{$DEFINE DEBUG_ON}
{$include_once srl-6/srl.simba}
{$include_once srl-6/lib/misc/srlplayerform.simba}
{$include_once bonsai/libnpc.simba}
{$include_once bonsai/libitem.simba}
{$include_once bonsai/libtracker.simba}
{$include_once bonsai/libbreak.simba}
{$f-}

// -----------------------------------------------------------------------------
// --                           CUSTOMIZING
// --
// --    Script is customized by using the form that pops up when you run it
// --
// --    To add NPCs, you edit SIMBADIR/includes/bonsai/libnpcUser.xml.
// --    See the script thread for more information.
// -----------------------------------------------------------------------------

const 
   scriptName = 'bonsaiFighter';  
   bonsaiFighterVersion = '2.0';
   bonsaiFighterVerUrl = 'http://pastebin.com/raw.php?i=pTW8JsUM';
   bonsaiFighterCodeUrl = 'http://pastebin.com/raw.php?i=94U0sEny';
   bonsaiFighterXmlVerUrl = 'http://pastebin.com/raw.php?i=asBUvqnX';
   bonsaiFighterXmlCodeUrl = 'http://pastebin.com/raw.php?i=KDTDguyH';
   
var
   healthPercentToEatAt: integer = 50;    
   healthPercentToQuit: integer = 25;
   healthTimer: TTimeMarker;
   logoutWhenExiting: boolean = false;
   playerName: string = 'noname'; 
   playerFile: string = 'nofile';      
   desiredWorld: integer = 0;            
   mouseStyle: integer = MOUSE_RIGHT;        
   cantFindNpcLoops: integer = 150;      
   manualAbilities: boolean = false;
   averageSessionMin: integer = 120;    
   sessionVarianceMin: integer = 20;  
   averageBreakMin: integer = 17;      
   breakVarianceMin: integer = 5; 
   graphicsMode: string = 'OpenGL';
   npcToFight: string = 'autodetect';      

// -----------------------------------------------------------------------------
// doPlayerLogin()
//
// Checks if the player is logged in and attempts to log it in if not.
// Also sets screen settings to our default (overhead view).
// Takes a screenshot to help debug why the user would need to get
// logged in.
// -----------------------------------------------------------------------------
procedure doPlayerLogin();
begin
   if (not isLoggedIn()) then
   begin
      writeln('***** Logging player in');
      takeScreenshot(scriptName + '.png');
      if (not players[currentPlayer].login()) then 
      begin
         writeln('*************************************************');
         writeln('***** ERROR GETTING PLAYER LOGGED IN, EXITING!!!');
         writeln('*************************************************');
         terminateScript();
      end
      else
      begin
         mainscreen.setangle(MS_ANGLE_HIGH);
         exitSquealOfFortune();
      end;
   end; 
end;

// -----------------------------------------------------------------------------
// checkHealthAndEat()
//
// Checks the health percentage and eats if needed.  If health is too low
// it initiates shutdown so we don't die.  Uses a timer so it doesn't check
// it too frequently.
// -----------------------------------------------------------------------------
procedure checkHealthAndEat();

var
   hp: integer;
   
begin
   if (healthTimer.getTime() < 8000) then
      exit;
      
   hp := actionbar.getHPPercent();
   {$IFDEF DEBUG_ON} 
      writeln('***** Health check returning ', hp, ' percent'); 
   {$ENDIF}   
   
   if (hp < healthPercentToEatAt) then
      sendKeys('z', 250, 40);

   if (hp < healthPercentToQuit) then
   begin
      writeln('***** Terminating script due to low health');
      terminateScript();
   end;
      
   healthTimer.start();
end;

// -----------------------------------------------------------------------------
// antiBan()
//
// This gets called often to provide some random actions.
// -----------------------------------------------------------------------------
procedure antiBan();
begin
   case (random(275)) of
      1, 19, 35, 60:
         begin
            {$IFDEF DEBUG_ON} writeln('****** antiBan [move off client and sleep]'); {$ENDIF}
            mouseOffClient(OFF_CLIENT_RANDOM);  
            wait(randomRange(5000,10000));
         end;
      5,8,15,25,28,35,38,45,48:
         begin
            {$IFDEF DEBUG_ON} writeln('****** antiBan [sleep and move mouse] + [secondary]'); {$ENDIF}
            sleepAndMoveMouse(randomRange(2000,3000));
            case (random(12)) of               
               1:       randomRclickItem();
               2:       sleepAndMoveMouse(randomRange(1000,2000));
               3:       pickUpMouse();
               4,5,11:  begin mouseOffClient(OFF_CLIENT_RANDOM);  wait(randomRange(5000,10000)); end;
               6:       smallRandomMouse();
               7:       randomCompass(50, 150, true);
               8:       mouseMovingObject();
               9,10:     begin
                           tabStats.open(); 
                           mouseBox(tabStats.getSkillBox(random(25)), MOUSE_MOVE);
                           wait(randomRange(2750,4750));                     
                           tabBackpack.open();
                        end;
            end; // case (random(12))
         end;
   end;
end;

// -----------------------------------------------------------------------------
// scriptShutdown()
//
// This function is put into the termination chain to be called whenever
// the script stops.  
// -----------------------------------------------------------------------------
procedure scriptShutdown();
begin
   {$IFDEF DEBUG_ON} writeln('****** ' + scriptName + ': Script shutting down'); {$ENDIF}
   takeScreenshot(scriptName + '.png');
   tracker.progressReport();
   if (logoutWhenExiting and isLoggedIn()) then
      players[currentPlayer].logout();
end;

// -----------------------------------------------------------------------------
// onBreakStart()
//
// This gets called whenever we start a break.  Tells the time tracker we
// are paused.
// -----------------------------------------------------------------------------
procedure onBreakStart();
begin
   tracker.pause();
end;

// -----------------------------------------------------------------------------
// onBreakEnd()
//
// This gets called when we come back from a break.  Turns the timer back on
// and makes sure the player is logged in.
// -----------------------------------------------------------------------------
procedure onBreakEnd();
begin
   tracker.resume();
   doPlayerLogin();
end;

// -----------------------------------------------------------------------------
// initPlayerForm()
//
// Set up the form
// -----------------------------------------------------------------------------
procedure initPlayerForm();

var
   i: integer;
   n: Tnpc;
   
begin
   with playerForm do
   begin
      name := scriptName + bonsaiFighterVersion;
      scriptHelpThread := 'http://villavu.com/forum/showthread.php?t=106661';
      scriptSettingsPath := scriptPath + scriptName + 'settings.txt';

      editBoxLabels := ['World', 'When to eat (Health %)', 'When To Quit (Health %)', 'Loops Without Finding NPC',
         'Session Length (Minutes)', 'Session Variance (Minutes)', 'Break Length (Minutes)', 'Break Variance (Minutes)']; 
      editBoxDefaults := [ '0', '50', '25', '150', '120', '20', '17', '5'];

      checkBoxLabels := ['Manual Abilites', 'Logout when exiting'];
      checkBoxDefaults := ['False', 'False'];

      comboBoxLabels := ['Mouse Style', 'GraphicsMode', 'NPC']; 
      comboBoxDefaults := ['Left', 'OpenGL', 'autodetect'];

      setLength(comboBoxItems, length(comboBoxLabels));
      comboBoxItems[0] := ['Left', 'Right'];
      comboBoxItems[1] := ['OpenGL', 'DirectX'];
      // comboBoxItems[2] := n.listAllNpcs();
      comboBoxItems[2] := ['i','need','to','write','this'];
   end;
end;

// -----------------------------------------------------------------------------
// getPlayerForm()
//
// Get results from the form
// -----------------------------------------------------------------------------
procedure getPlayerForm();

var
   i: integer;
   mouseStr: string;
   
begin
   players.setup(playerForm.playerNames, playerForm.playerFile);

   if (length(players) < 1) then
   begin
      writeln('*************************************************************************');
      writeln('***** ERROR:  You did not provide a valid playername/nickname/player file');
      writeln('*************************************************************************');
      terminateScript();
   end;

   desiredWorld         := StrToIntDef (playerForm.players[0].settings[0], 0);
   healthPercentToEatAt := StrToIntDef (playerForm.players[0].settings[1], 50);
   healthPercentToQuit  := StrToIntDef (playerForm.players[0].settings[2], 25);
   cantFindNpcLoops     := StrToIntDef (playerForm.players[0].settings[3], 150);
   averageSessionMin    := StrToIntDef (playerForm.players[0].settings[4], 120);
   sessionVarianceMin   := StrToIntDef (playerForm.players[0].settings[5], 20);
   averageBreakMin      := StrToIntDef (playerForm.players[0].settings[6], 17);
   breakVarianceMin     := StrToIntDef (playerForm.players[0].settings[7], 5);
   manualAbilities      := StrToBoolDef(playerForm.players[0].settings[8], false);
   logoutWhenExiting    := StrToBoolDef(playerForm.players[0].settings[9], false);
   mouseStr             := lowercase   (playerForm.players[0].settings[10]);
   graphicsMode         :=              playerForm.players[0].settings[11];
   npcToFight           :=              playerForm.players[0].settings[12];

   case mouseStr of
      'right', 'mouse_right': 
         mouseStyle := MOUSE_RIGHT;
      'left', 'mouse_left':
         mouseStyle := MOUSE_LEFT;
   end;

   currentPlayer := 0;
   players[currentPlayer].world := desiredWorld;
end;

// -----------------------------------------------------------------------------
// MAIN
// -----------------------------------------------------------------------------

const 
   WAIT_FOR_END_OF_FIGHT = true;  
   trackingHeader: TStringArray = [
'   (                              )\ )                )     )           ',
' ( )\                     )  (   (()/(  (   (  (   ( /(  ( /(   (   (   ',
' )((_)  (    (     (   ( /(  )\   /(_)) )\  )\))(  )\()) )\()) ))\  )(  ',
'((_)_   )\   )\ )  )\  )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\ ',
' | _ ) ((_) _(_/( ((_)((_)_  (_) | |_   (_) (()(_)| |(_)| |_ (_))   ((_)',
' | _ \/ _ \| '' \))(_-</ _` | | | | __|  | |/ _` | | '' \ |  _|/ -_) | ''_|',
' |___/\___/|_||_| /__/\__,_| |_| |_|    |_|\__, | |_||_| \__|\___| |_|  ',
'                                           |___/                        '];
// http://patorjk.com/software/taag/#p=display&f=Graffiti&t=Type%20Something%20
                              
var
   timesFailed: integer;  // how many times did we fail to find an npc        
   npc: Tnpc;             // object representing the npc we are fighting  
   pb: TBox;
   
begin
   // initialize and prepare things
   //
   updater.check4update('bonsaiFighter.simba', bonsaiFighterVersion, 
      bonsaiFighterVerUrl, bonsaiFighterCodeUrl, false);
     
   if (updater.wereUpdatesPerformed) then
   begin
      writeln('');
      writeln('////////////////////////////////////////////');
      writeln('////////////////////////////////////////////');
      writeln('/// SCRIPT WAS UPDATED, CLOSE AND REOPEN ///');
      writeln('/// SCRIPT WAS UPDATED, CLOSE AND REOPEN ///');
      writeln('/// SCRIPT WAS UPDATED, CLOSE AND REOPEN ///');
      writeln('/// SCRIPT WAS UPDATED, CLOSE AND REOPEN ///');
      writeln('////////////////////////////////////////////');
      writeln('////////////////////////////////////////////');
      terminateScript();
   end;

   addOnTerminate('scriptShutdown');

   initPlayerForm();
   runPlayerForm();

   if (not playerForm.isScriptReady) then
      terminatescript;
   
   getPlayerForm();   

   smartEnableDrawing := true;
   tracker.init(scriptName, trackingHeader);
   breakTimer.init(averageSessionMin, sessionVarianceMin, 
      averageBreakMin, breakVarianceMin, onBreakStart, onBreakEnd);

   if (graphicsMode = 'DirectX') then
      smartPlugins := ['d3d9.dll'];
   
   SetupSRL();
   disableSRLDebug := true;
  
   // do the work
   //
   healthTimer.start();   
   timesFailed := 0;
   while (true) do
   begin
      breakTimer.check4break();
      doPlayerLogin(); 
      checkHealthAndEat();
   
      if (npc.name() = '') then
            npc.init(npcToFight);

      if (npc.name() = '') then 
      begin
         writeln('****** Could not set up NPC [', npcToFight, '].');
         break;
      end;
    
      if npc.attack(WAIT_FOR_END_OF_FIGHT, checkHealthAndEat, mouseStyle, manualAbilities) then
      begin
         {$IFDEF DEBUG_ON} writeln('***** Killed a ' + npc.name()); {$ENDIF}
         timesFailed := 0;
         antiBan(); 
         tracker.recordKill(npc.name());
         tracker.killHud();
         if ((tracker.numKilled(npc) mod 15) = 0) then
            tracker.progressReport();
            
         case npc.colorCount() of
            01..05: npc.colorize(10000, 5);
            06..09: npc.colorize(2500, 10);
            10..19: 
               begin
                  case random(10) of
                     0..6: npc.colorize(850, 20);
                  end;
               end;
            else
            begin
               case random(10) of
                  0,1: npc.colorize(400, 99999);
               end;
            end;
         end; 
      end
      else
      begin  // npc was not found
         inc(timesFailed);
         {$IFDEF DEBUG_ON} 
            writeln('****** Didnt find a ', npc.name(), ' to fight.  timesFailed = ', timesFailed); 
         {$ENDIF}
         
         if (timesFailed >= cantFindNpcLoops) then 
         begin
            writeln('**** Terminating script due to too many failures to find npc');
            break;
         end;
         
         if ((timesFailed mod 10) = 0) then
         begin
            {$IFDEF DEBUG_ON} 
               writeln('****** Having problems finding NPC, rotating cam.'); 
            {$ENDIF}
            npc.angleTowards();
            // not sure how it happens but I found screenshot with bad angle when
            // it failed.
            mainscreen.setangle(MS_ANGLE_HIGH);            
         end;

         if ((timesFailed mod 23) = 0) then
          begin
            {$IFDEF DEBUG_ON} 
               writeln('****** Having problems finding NPC, sleeping'); 
            {$ENDIF}
            wait(randomRange(3500,4500));            
         end;                   

         if ((timesFailed mod 31) = 0) then
         begin
            {$IFDEF DEBUG_ON} 
               writeln('****** Having problems finding NPC, moving to closest yellow dot'); 
            {$ENDIF}
            npc.moveToClosest();            
         end;         
      end; // npc not found
   end; // while (true)
   
   writeln('***** Loop ended, terminating');
   terminateScript();
end.

SIMBADIR/includes/bonsai/libnpc.simba:

// -----------------------------------------------------------------------------
// --    libnpc.simba
// --    Written by: bonsai
// -----------------------------------------------------------------------------
// {$DEFINE SMART}
{$include_once srl-6/srl.simba}
{$include_once bonsai/libupdater.simba}
{$include_once bonsai/libcolorizer.simba}
{$f-}

const   
   libnpcVersion = '2.0';
   libnpcVerUrl = 'http://pastebin.com/raw.php?i=PmQqYTCq';
   libnpcCodeUrl = 'http://pastebin.com/raw.php?i=UEsQSzsu'; 

type  
   Tnpc = record
      _name             : string;         // runescape name for npc, is used as a key for lookups
      _xp               : extended;       // combat xp received when killed
      _constitutionXp   : extended;       // constitution xp received when killed
      _colorizer        : Tcolorizer;
      _maxFightSeconds  : integer;        // how long is too long to be in a fight?    
   end;

const 
   // _npcInfightDTM = 'mlwAAAHicY2dgYOhkYWDoB+JJSLgPiLuAWIgRgsWBWAGINYBYC4q5BUVwYqBWnJgRD4YCAOi5Bls=';
   _npcInfightDTM = 'mlwAAAHicY2eAAEYgZgViTiTMBpWTgGIxIOaDqgMBbkERnJgLKM+CAzPiwVAAAKx0AgE=';
var 
	_npcDtmId: integer;       
   _npcFightFlag: boolean = false;

// -----------------------------------------------------------------------------
// Tnpc access functions
// 
// Simple functions to give users access to the object data.  Users should
// not be accessing the internal data directly in case we change it.
// -----------------------------------------------------------------------------      
function Tnpc.name(): string;
begin
   result := self._name;   
end;

function Tnpc.xp(): extended;
begin
   result := self._xp;   
end;

function Tnpc.constitutionXp(): extended;
begin
   result := self._constitutionXp;   
end;

function Tnpc.uptext(): String;
begin
   result := self._colorizer.uptext;   
end;

function Tnpc.dist(): integer;
begin
   result := self._colorizer.dist;   
end;

function Tnpc.minPixels(): integer;
begin
   result := self._colorizer.minPixels;   
end;

function Tnpc.maxPixels(): integer;
begin
   result := self._colorizer.maxPixels;   
end;

function Tnpc.maxFightSeconds(): integer;
begin
   result := self._maxFightSeconds;   
end;

function Tnpc.colorCount(): integer;
begin
   result := length(self._colorizer.successful);   
end;

// -----------------------------------------------------------------------------
// init()
//
//    initialize an NPC object.  
// ----------------------------------------------------------------------------- 
procedure Tnpc.init(npcName: string);

var 
   i: integer;
   
begin
   self._colorizer.init(npcName, 'Attack', 150, 5, 10, 1, 2000);
   if (npcName <> '') and (lowercase(npcName) <> 'autodetect') then
   begin
      self._name             := npcName;
      self._xp               := 10;  // need to look these up online
      self._constitutionXp   := 5;
      self._maxFightSeconds  := 60;   
      self._colorizer.load();
   end;
   if (lowercase(npcName) = 'autodetect') then
   begin
      {$IFDEF DEBUG_ON} writeln('****** Tnpc.init: Starting auto detect process'); {$ENDIF}
      self.motionDetect();
      writeln('****** Tnpc.init: Auto detected NPC: ' + self.name());
   end;
end;

// -----------------------------------------------------------------------------
// equals()
//
// Function to compare one NPC object to another.  Perhaps it's not solid
// but only the name field is checked.  var is used even though compareTo
// is not changed.  This is due to wierd lape violation errors when passing
// records around.
// -----------------------------------------------------------------------------
function Tnpc.equals(var compareTo: Tnpc): boolean;
begin
   result := (self._name = compareTo.name());   
end;
  
// -----------------------------------------------------------------------------
// angleTowards()
// 
// Splits the minimap into quadrants and changes our view to the quadrant 
// with the most NPCs in it
// -----------------------------------------------------------------------------
procedure Tnpc.angleTowards() 
 
var
   b: TBox;
   c: TPoint;
   quadrant: array[0..3] of TBox;
   dotCount: TPointArray;
   i, longest, longestQ, angl: integer;
   
begin
   b := minimap.getBounds();
   c := minimap.getCenterPoint();
   // NE, SE, SW, NW
   quadrant[0] := IntToBox(c.x,  b.y1, b.x2, c.y);
   quadrant[1] := IntToBox(c.x,  c.y,  b.x2, b.y2);
   quadrant[2] := IntToBox(b.x1, c.y,  c.x,  b.y2);
   quadrant[3] := IntToBox(b.x1, b.y1, c.x,  c.y);
   longest := -1;
   for i := 0 to 3 do
   begin
      dotCount := minimap.getDots(MM_DOT_NPC, quadrant[i]);
      if (length(dotCount) > longest) then 
      begin
         longestQ := i;
         longest := length(dotCount);
      end;
   end;
   angl := trunc(minimap.getAngleDegrees()) + (45*((longestQ*2)+1));
   if (angl > 360) then 
      angl := angl - 360;
   {$IFDEF DEBUG_ON} writeln('***** Tnpc.angleTowards: Altering angle to ', angl); {$ENDIF}
   minimap.setAngle(trunc(angl)); 
end;

// -----------------------------------------------------------------------------
// moveToClosest()
//
// Clicks on the closest yellow dot on the minimap in an attempt to get
// us back in view of an npc to fight.  It's possible for it to click
// on something unrelated and make things worse :)
// -----------------------------------------------------------------------------
procedure Tnpc.moveToClosest() 
 
var
   yellowDots: TPointArray;   
   
begin
   yellowDots := minimap.getDots(MM_DOT_NPC, minimap.getBounds());
   yellowDots.sortFromPoint(minimap.getBounds().getMiddle());
   mouse(yellowDots[0], MOUSE_LEFT); 
end;

// -----------------------------------------------------------------------------
// isInFight()
//
// Function to determine if the npc is in a fight.
// -----------------------------------------------------------------------------
function Tnpc.isInFight(suppressDebug: boolean = false): boolean;

var
   votes, gold1, red1, box1, box2, green1, green2, dtmfs1, sum: integer;
   tpa: TPointArray;
   search: TBox;
   
begin
   votes := 0;
   
   gold1 := countColorTolerance(2726093, mainscreen.getBounds(), 
      9, colorSetting(2,0.14,2.16));
   
   if (gold1 > 50) then
      inc(votes);
   if (gold1 > 80) then
      inc(votes);
   if (gold1 > 100) then
      inc(votes);
      
   red1 := countColorTolerance(3094484, mainscreen.getBounds(), 
      25, colorSetting(0)); 
   if (red1 > 45) then
      inc(votes);
      
   box1 := countColorTolerance(1380618, mainscreen.getBounds(), 
         0, colorSetting(0));
   if (box1 > 150) then
      votes := votes + 2;
      
   box2 := countColorTolerance(1381133, mainscreen.getBounds(), 
         2, colorSetting(0));         
   if (box2 > 150) then
      votes := votes + 2;
      
   green1 := countColorTolerance(3308832, mainscreen.getBounds(), 
         15, colorSetting(2, 0.27, 1.56)); 
   if (green1 > 125) then
      inc(votes);
      
   search := mainscreen.playerBox;
   search.expand(35);
   green2 := countColorTolerance(45128, search, 9, colorSetting(2, 0.70, 0.00)); 
   if (green2 > 40) then
      inc(votes);
      
//   if (findDTMs(_npcDtmId, tpa, mainscreen.getBounds())) then
//   begin 
//      dtmfs1 := length(tpa);
//   end;         
//   if (dtmfs1 > 1) then          // if we can see more than one dtm, the mouse is
//      smallRandomMouse(100);     // probably on another npc so two popups are open
//
//   sum := gold1 + red1 + box1 + box2 + green2 + green1 + dtmfs1;

   if (votes > 4) then
      result := true
   else
      result := false;
      
   if (not suppressDebug) then
   begin
      {$IFDEF DEBUG_ON} 
         writeln('***** Tnpc.isInFight: result=', result, ' votes=', votes, ' gold1=', gold1, 
            ' red1=', red1, ' box1=', box1, ' box2=', box2, 
            ' green1=', green1, ' green2=', green2); 
      {$ENDIF}
   end;
end;

// -----------------------------------------------------------------------------
// _doAbilities()
//
// Chooses available abilities during s fight
// -----------------------------------------------------------------------------   
procedure Tnpc._doAbilities();

var 
   i, pct: integer;
   keyStr: string;
   
begin
   for i := 9 downto 1 do  // used 9 to match revolution
   begin
      pct := actionBar.getAbilityCooldown(i);
//      {$IFDEF DEBUG_ON} 
//         writeln('***** Tnpc._doAbilities: ability[', i, '] returned cooldown ', pct); 
//      {$ENDIF}
      if (pct = 1) then
      begin
         case i of
            0..9:    keyStr := intToStr(i);
            10:      keyStr := '0';
            11:      keyStr := '-';
            12:      keyStr := '=';
         end;
      
         SendKeys(keyStr[1], 60 + Random(60), 60 + Random(60));

         {$IFDEF DEBUG_ON} 
            writeln('***** Tnpc._doAbilities: activated ability[', i, ']'); 
         {$ENDIF}
         exit;  // only do one ability
      end;
   end;
end;

// -----------------------------------------------------------------------------
// attack()
//
// Finds an NPC, initiates an attack, and (if asked to) waits for the fight
// to complete.  Calls a user specified procedure to check if we need
// food and eat.
// -----------------------------------------------------------------------------   
function Tnpc.attack(waitTilDead: boolean; foodProc: procedure; mouseStyle: integer = MOUSE_RIGHT; 
   manualAbilities: boolean = false): boolean;

var
  t, i, x, y, col: integer;
  b: TBox;
  nname: string;
  found, found2: boolean;
  colList: TIntegerArray;
 
begin  
   with self._colorizer do
   begin
//      b := likelyBox(col);
      b := multiBox(colList);
      if not b.equals(intToBox(-1,-1,-1,-1)) then
      begin
         result := detectObj(x, y, nname, b, mouseStyle);
         for i := 0 to high(colList) do
            updateTrials(colList[i], result);
      end
      else
         result := false;
   end;
   
   if (result and waitTilDead) then
   begin
      {$IFDEF DEBUG_ON} writeln('***** Tnpc.attack: Fight initiated'); {$ENDIF}
      
      found := false;      
      found2 := false;
      
      // give it time to run over and get into the fight 
      // if a smaller value is used it gets more kills/hr but
      // sometimes it does take that long to run around
      
      t := getSystemTime() + randomRange(3200,3900);      
      repeat      
         wait(50);
         found := self.isInFight(true);
      until (found or (getSystemTime() >= t));

      i := 0;
      t := getSystemTime() + (self._maxFightSeconds * 1000);       
      while self.isInFight() do
      begin
         found2 := true;
         wait(randomRange(150,250));
         if (i mod 15) = 0 then  // don't call too frequently
         begin
            if (manualAbilities) then
               self._doAbilities();
            foodProc();
         end;
         if (getSystemTime() >= t) then
         begin
            {$IFDEF DEBUG_ON} writeln('****** Tnpc.attack: Something wrong... in fight too long'); {$ENDIF}
            terminateScript();
         end;   
         inc(i);
      end;
      
      if not (found or found2) then
      begin
         {$IFDEF DEBUG_ON} writeln('****** Tnpc.attack: Probable miss, did not detect start of fight'); {$ENDIF}
         result := false;
      end
      else
      begin
         {$IFDEF DEBUG_ON} writeln('***** Tnpc.attack: End of fight detected'); {$ENDIF}
      end;
   end;
end;

// -----------------------------------------------------------------------------
// colorize()
//
// Tests new and in progress colors to try to find new ones that are successful. 
// -----------------------------------------------------------------------------
function Tnpc.colorize(maxTime: integer = 120000; enough: integer = 5): boolean;
begin
   result := self._colorizer.colorize(maxTime, enough);
end;

// -----------------------------------------------------------------------------
// motionDetect()
//
// Finds NPCs based on screen movement (pixel shift).
//
// Improves color knowledge until we have at least 5 successful colors to use.
// -----------------------------------------------------------------------------
function Tnpc.motionDetect(): string;

var
   s, nname: string;

   function strToNpc(s: string): string;
   var
      sa, sa2: TStringArray;
      i: integer;
   begin
      // Returns the NPC name from strings like
      // "Attack NPC NAME (level XX)"  
      // "Attack *NPC NAME (level XX)" 
      if (pos('Attack', s) <> 1) then exit;

      sa := explode(' ', s);
      if (length(sa) <= 1) then exit;

      if (pos('*', sa[1]) > 0) then
      begin
         sa2 := explode('*', sa[1]);
         sa[1] := sa2[1];
      end
      result := sa[1];

      for i := 2 to high(sa) do
      begin
         if (pos('(', sa[i]) > 0) then break;
         result := result + ' ' + sa[i];
      end;
   end;
   
begin
   {$IFDEF DEBUG_ON} writeln('***** Tnpc.motionDetect: Starting ... '); {$ENDIF}
   
   self.init('');
   s := self._colorizer.motionDetect();
//   nname := strToNpc(s);
nname := s;
   if (s <> '') then
      self.init(nname);
      
   {$IFDEF DEBUG_ON} writeln('***** Tnpc.motionDetect: Detected ', nname, '(', s, ')'); {$ENDIF}
   
   while (self.colorCount() < 5) do
   begin
      {$IFDEF DEBUG_ON} writeln('***** Tnpc.motionDetect: Trying to identify more colors'); {$ENDIF}
      self.colorize(60000, 5);
   end;
end;

// -----------------------------------------------------------------------------
// _npcTerminate
//
// This is hooked into the script termination stream.  It frees up any
// DTMs we loaded.
// -----------------------------------------------------------------------------
procedure _npcTerminate();
   
begin
	freeDTM(_npcDtmId);
end;
 
// -----------------------------------------------------------------------------
// initializer
//
// Ensures we call the function to free DTMS if the script exits.
// Checks for online updates.
// -----------------------------------------------------------------------------
begin
   addOnTerminate('_npcTerminate');
   
//   updater.check4update('libnpc.simba', libnpcVersion, 
//      libnpcVerUrl, libnpcCodeUrl, true);
               
	_npcDtmId := DTMFromString(_npcInfightDTM);
end;

SIMBADIR/includes/bonsai/libcolorizer.simba:

// -----------------------------------------------------------------------------
// --    libcolorizer.simba
// --    Written by: bonsai
// -----------------------------------------------------------------------------
// {$DEFINE SMART}
{$include_once srl-6/srl.simba}
{$include_once bonsai/libupdater.simba}
{$f-}

const   
   libcolorizerVersion = '1.0';
   libcolorizerVerUrl = 'http://pastebin.com/raw.php?i=PmQqYXXX';
   libcolorizerCodeUrl = 'http://pastebin.com/raw.php?i=UEsQXXXX';

   BLACKLIST_THRESHOLD = 500; // msec.  if a findcolor takes longer than this we dont want it
   PIXELSHIFT_WAIT = 300;     // msec
   SUCCESS_THRESHOLD = 0.66;  // what is good enough (percent) to call a color successful
   FAILURE_THRESHOLD = 0.30;  // what is bad enough (percent) to call a failure
   ATTEMPT_THRESHOLD = 30;    // by this many attempts, demand success or blacklist
   GRIDSIZE = 50;             // box size to break up the screen for motion detection
   CLEANUP_LOW_WATER = 40;    // how many colors to keep if we are cleaning up

type  
   TcolRec = record
      color      : integer;
      count      : integer;
      attempts   : integer;
      matches    : integer;
      lastPoints : integer;
      lastObj    : integer;
      maxPoints  : integer;
      maxObj     : integer;
      queryTime  : integer;
   end;
   
   TcolSet = array of TcolRec;
      
   Tcolorizer = record
      name          : string;
      discovered    : TcolSet;
      active        : TcolSet;
      successful    : TcolSet;
      blacklist     : TcolSet;
      runty         : TcolSet;
      uptext        : string;
      uptextTimeout : integer;
      tol           : integer;
      dist          : integer;
      minPixels     : integer;
      maxPixels     : integer;
   end;

// -----------------------------------------------------------------------------
// Some functions that had issues or were missing from SRL
// -----------------------------------------------------------------------------      
function getPixelShiftAverage(b: TBoxArray; waitPerLoop, 
   maxTime: integer): TIntegerArray; override;

var
  len, i, j: integer;
  samples: array of TIntegerArray;
  tmp: TIntegerArray;
  timer: TTimeMarker;
  
begin
   i := 0;
   timer.start();
   while (timer.getTime() < maxTime) do
   begin  
      setLength(samples, i + 1);
      samples[i] := getPixelShift(b, waitPerLoop);
      inc(i);
   end;
   
   setLength(tmp, i); // i got incremented one extra time so is good for length
   len := length(b);
   setLength(result, len);  

   for i := 0 to (len - 1) do
   begin
      for j := 0 to high(samples) do
         tmp[j] := samples[j][i];

      result[i] := tmp.average();
   end;
end;

function getPixelShift(b: TBoxArray; time: integer): TIntegerArray; override;

var
  hi, i: integer;
  before, after: integer;
  
begin
   hi := high(b);
   setLength(result, hi+1);

   before := bitmapFromClient(mainscreen.getBounds());
   sleep(time);
   after  := bitmapFromClient(mainscreen.getBounds());

   for i := 0 to hi do
      result[i] := calculatePixelShift(before, after, b[i]);

   freeBitmap(before);
   freeBitmap(after);
end;

function TIntegerArray.max(): integer;
var
   i, tmpmax: integer;
begin
   tmpmax := -(MAXINT);
   for i := 0 to length(self) do
      if self[i] > tmpmax then tmpmax := self[i];
   exit(tmpmax);
end;
 
function TBoxArray.pixelShift(time: integer = 200): TIntegerArray;
begin
   result := getPixelShift(self, time);
end;
 
function TBoxArray.returnInArray(const b : TBox) : integer;
var
  i: integer;
begin
  for i := 0 to high(self) do
    if (self[i].equals(b)) then exit(i);
  exit(-1);
end;

function TBoxArray.isInArray(const b : TBox) : Boolean;
begin
  if (self.returnInArray(b) <> -1) then 
    result := true
  else
    result := false;
end;

procedure TBoxArray.addIndex(const b : TBox; const index : Integer);
var
  I : Integer;
begin
  if not inRange(index, low(self), length(self)) then
  begin
    WriteLn('ERROR: addIndex: index larger than array length.');
    Exit;
  end;

  setLength(self, length(self)+1);
  for I := high(self)-1 downto index do
    self[I+1] := self[I];
  self[index] := b;
end;

procedure TBoxArray.append(const b : TBox);
begin
  self.addIndex(b, length(self));
end;

procedure TBoxArray.combine(const arr : TBoxArray);
var
  i : integer;
begin
  for i := 0 to high(arr) do
    self.append(arr[i]);
end;

// -----------------------------------------------------------------------------
// successPercent()
//
// Returns the success percentage
// -----------------------------------------------------------------------------
function TcolRec.successPercent(): extended;
begin
   result := (self.matches / self.attempts);
end;
 
// -----------------------------------------------------------------------------
// sortByCount()
//
// sorts the array by count desc
// -----------------------------------------------------------------------------
procedure TcolSet.sortByCount();

var 
   i, j, m: integer;
   tmp: TcolSet;
   
begin
   setLength(tmp, 1);
   for i := 0 to high(self) - 1 do 
   begin    
      m := i;    
      for j := i + 1 to high(self) do 
      begin
         if self[j].count > self[m].count then 
            m := j;   
      end;
      tmp[0]  := self[m];    
      self[m] := self[i];    
      self[i] := tmp[0]; 
   end;
end;

// -----------------------------------------------------------------------------
// sortBySuccess()
//
// sorts the array by success rate desc
// -----------------------------------------------------------------------------
procedure TcolSet.sortBySuccess();

var 
   i, j, m: integer;
   tmp: TcolSet;
   
begin
   setLength(tmp, 1);
   for i := 0 to high(self) - 1 do 
   begin    
      m := i;    
      for j := i + 1 to high(self) do 
      begin
         if ((self[j].attempts = 0) or (self[m].attempts = 0)) then continue;
         if (self[j].successPercent() > self[m].successPercent()) then 
            m := j;   
      end;
      tmp[0]  := self[m];    
      self[m] := self[i];    
      self[i] := tmp[0]; 
   end;
end;

// -----------------------------------------------------------------------------
// returnInArray()
//
// Returns the index of color c in the array (-1 if not found)
// -----------------------------------------------------------------------------
function TcolSet.returnInArray(const c: integer): integer;

var
   i: integer;  

begin
   for i := 0 to high(self) do
      if (self[i].color = c) then exit(i);
   exit(-1);
end;

// -----------------------------------------------------------------------------
// isInArray()
//
// Returns true if color c in the array
// -----------------------------------------------------------------------------
function TcolSet.isInArray(const c: integer): boolean;

var
   i: integer;  

begin
   i := self.returnInArray(c);
   if (i = -1) then
      result := false
   else
      result := true;
end;

// -----------------------------------------------------------------------------
// append()
//
// Adds a color to the array
// -----------------------------------------------------------------------------
procedure TcolSet.append(const t: TcolRec);

var
   i: integer; 
   
begin
   setLength(self, (length(self) + 1));
   self[high(self)] := t;
end;

// -----------------------------------------------------------------------------
// deleteIndex()
//
// Deletes the color at the given index
// -----------------------------------------------------------------------------
procedure TcolSet.deleteIndex(const index: integer);

var
   i : integer;

begin
   if not inRange(index, low(self), high(self)) then
   begin
      writeln('TcolSet.deleteIndex: ERROR - index (', index, ' is out of range');
      exit;
   end;

   for i := index to (high(self) - 1) do
      self[i] := self[i + 1];
   setLength(self, (length(self) - 1));
end;

// -----------------------------------------------------------------------------
// delete()
//
// Deletes the color
// -----------------------------------------------------------------------------
procedure TcolSet.delete(const c: integer);

var
   i : integer;
   
begin
   i := self.returnInArray(c);
   if (i >= 0) then
      self.deleteIndex(i);
end;

// -----------------------------------------------------------------------------
// cleanupColors()
//
// Weeds down the color list
// -----------------------------------------------------------------------------
procedure TcolSet.cleanupColors();

var
   i, t, cnt: integer;
   tmp: TcolSet;
   
begin
   cnt := 1;
   while (cnt < 15) do
   begin
      if (length(self) < CLEANUP_LOW_WATER) then exit;
      
      t := 0;
      setLength(tmp, length(self));
      
      for i := 0 to high(self) do
      begin
         if ((self[i].matches > 0) or (self[i].count > cnt)) then
         begin
            tmp[t] := self[i];
            inc(t);
         end;
      end;
      
      setLength(tmp, t);
      self := tmp;
      inc(cnt);
   end;
end;

// -----------------------------------------------------------------------------
// _fpath()
//
// Make a file path
// -----------------------------------------------------------------------------
function Tcolorizer._fpath(): string;

var
   s: string;
   
begin
   if (self.name = '') then
   begin
      result := '';
      exit;
   end;
   s := lowercase(self.name);
   s := replace(s, ' ', '-', [rfReplaceAll]);
   s := replace(s, '/', '-', [rfReplaceAll]);
   s := replace(s, ':', '-', [rfReplaceAll]);
   
   result := includePath + 'bonsai\colors\';   
   if (not DirectoryExists(result)) then
   begin
      if (CreateDirectory(result)) then
         writeln('***** Tcolorizer._fpath: created include folder ' + result)
      else
         writeln('***** Tcolorizer._fpath: ERROR - Could not create directory ' + result);
   end;

   result := result + s + '.xml';
end;

// -----------------------------------------------------------------------------
// load()
//
// Loads previous work from a file
// -----------------------------------------------------------------------------
function Tcolorizer.load(): boolean;

var
  fileId, i, j, k: integer;
  filePath, fileData: string;
  allData, colArr, colorSets, cRec: TStringArray;
  tmp: TcolRec;
  
begin
   result := false;
   filePath := self._fpath();
	if (not FileExists(filePath)) then
	begin
   	{$IFDEF DEBUG_ON} writeln('***** Tcolorizer.load: Requested file does not exist [', filePath, ']'); {$ENDIF}
		exit;
	end;

	fileId := OpenFile(filePath, false);
	if (fileId = -1) then
   begin
   	{$IFDEF DEBUG_ON} writeln('***** Tcolorizer.load: OpenFile failed [', filePath, ']'); {$ENDIF}
      exit;
   end;
	
	if (not ReadFileString(fileId, fileData, FileSize(fileId))) then	
   begin
   	{$IFDEF DEBUG_ON} writeln('***** Tcolorizer.load: ReadFileString failed [', filePath, ']'); {$ENDIF}
		exit;
	end;  
	CloseFile(fileId);

	// now we have the contents in fileData, parse it
	allData := MultiBetween(fileData, '<colorizer>', '</colorizer>');
	if (length(allData) <> 1) then
	begin
	   writeln('***** Tcolorizer.load: Corrupt file [', filePath, 
	   	'], does not have proper <colorizer></colorizer> tags');
		exit;
	end;
 	
   self.name     :=             between('<name>',          '</name>',          allData[0]);
   self.uptext   :=             between('<uptext>',        '</uptext>',        allData[0]);
   uptextTimeout := StrToIntDef(between('<uptextTimeout>', '</uptextTimeout>', allData[0]), 0);
   tol           := StrToIntDef(between('<tol>',           '</tol>',           allData[0]), 0);
   dist          := StrToIntDef(between('<dist>',          '</dist>',          allData[0]), 0);
   minPixels     := StrToIntDef(between('<minPixels>',     '</minPixels>',     allData[0]), 0);
   maxPixels     := StrToIntDef(between('<maxPixels>',     '</maxPixels>',     allData[0]), 0);

   colorSets := ['discovered', 'active', 'successful', 'blacklist', 'runty'];
   for i := 0 to high(colorSets) do
   begin
      colArr := multiBetween(allData[0], '<' + colorSets[i] + '>', '</' + colorSets[i] + '>');
      for j := 0 to high(colArr) do
      begin
         cRec := multiBetween(colArr[j], '<colorRecord>', '</colorRecord>');
         for k := 0 to high(cRec) do
         begin
            tmp.color      := StrToIntDef(between('<color>',      '</color>',      cRec[k]), 0);
            tmp.count      := StrToIntDef(between('<count>',      '</count>',      cRec[k]), 0);
            tmp.attempts   := StrToIntDef(between('<attempts>',   '</attempts>',   cRec[k]), 0);
            tmp.matches    := StrToIntDef(between('<matches>',    '</matches>',    cRec[k]), 0);
            tmp.lastPoints := StrToIntDef(between('<lastPoints>', '</lastPoints>', cRec[k]), 0);
            tmp.lastObj    := StrToIntDef(between('<lastObj>',    '</lastObj>',    cRec[k]), 0);
            tmp.maxPoints  := StrToIntDef(between('<maxPoints>',  '</maxPoints>',  cRec[k]), 0);
            tmp.maxObj     := StrToIntDef(between('<maxObj>',     '</maxObj>',     cRec[k]), 0);
            tmp.queryTime  := StrToIntDef(between('<queryTime>',  '</queryTime>',  cRec[k]), 0);
            
            case colorSets[i] of
               'discovered' : begin; self.discovered.append(tmp); end;
               'active'     : begin; self.active.append(tmp);     end;
               'successful' : begin; self.successful.append(tmp); end;
               'blacklist'  : begin; self.blacklist.append(tmp);  end;
               'runty'      : begin; self.runty.append(tmp);      end;
            end;
         end;
      end;
   end;
end;

// -----------------------------------------------------------------------------
// save()
//
// Saves the accumulated data
// -----------------------------------------------------------------------------
procedure Tcolorizer.save();

var
   s, filePath: string;
   i, j, fileId: integer;
   colorSets: TstringArray;

   function colRec(r: TcolRec): string;
   begin
      result := result + '    <colorRecord>';
      result := result + '<color>'      + intToStr(r.color)      + '</color>';
      result := result + '<count>'      + intToStr(r.count)      + '</count>';
      result := result + '<attempts>'   + intToStr(r.attempts)   + '</attempts>';
      result := result + '<matches>'    + intToStr(r.matches)    + '</matches>';
      result := result + '<lastPoints>' + intToStr(r.lastPoints) + '</lastPoints>';
      result := result + '<lastObj>'    + intToStr(r.lastObj)    + '</lastObj>';
      result := result + '<maxPoints>'  + intToStr(r.maxPoints)  + '</maxPoints>';
      result := result + '<maxObj>'     + intToStr(r.maxObj)     + '</maxObj>';
      result := result + '<queryTime>'  + intToStr(r.queryTime)  + '</queryTime>';
      result := result + '</colorRecord>' + #13#10;
   end;
   
begin
   s := s + '<colorizer>' + #13#10;
   s := s + '  <name>'          + self.name                    + '</name>' + #13#10;
   s := s + '  <uptext>'        + self.uptext                  + '</uptext>' + #13#10;
   s := s + '  <uptextTimeout>' + intToStr(self.uptextTimeout) + '</uptextTimeout>' + #13#10;
   s := s + '  <tol>'           + intToStr(self.tol)           + '</tol>' + #13#10;
   s := s + '  <dist>'          + intToStr(self.dist)          + '</dist>' + #13#10;
   s := s + '  <minPixels>'     + intToStr(self.minPixels)     + '</minPixels>' + #13#10;
   s := s + '  <maxPixels>'     + intToStr(self.maxPixels)     + '</maxPixels>' + #13#10;

   colorSets := ['discovered', 'active', 'successful', 'blacklist', 'runty'];
   for i := 0 to high(colorSets) do
      case colorSets[i] of
         'discovered':
            begin
               s := s + '  <discovered>' + #13#10;
               for j := 0 to high(self.discovered) do
                  s := s + colRec(self.discovered[j]);
               s := s + '  </discovered>' + #13#10;
            end;
         'active':
            begin
               s := s + '  <active>' + #13#10;
               for j := 0 to high(self.active) do
                  s := s + colRec(self.active[j]);               
               s := s + '  </active>' + #13#10;
            end;
         'successful':
            begin
               s := s + '  <successful>' + #13#10;
               for j := 0 to high(self.successful) do
                  s := s + colRec(self.successful[j]);               
               s := s + '  </successful>' + #13#10;
            end;
         'blacklist':
            begin
               s := s + '  <blacklist>' + #13#10;
               for j := 0 to high(self.blacklist) do
                  s := s + colRec(self.blacklist[j]);               
               s := s + '  </blacklist>' + #13#10;
            end;
         'runty':
            begin
               s := s + '  <runty>' + #13#10;
               for j := 0 to high(self.runty) do
                  s := s + colRec(self.runty[j]);
               s := s + '  </runty>' + #13#10;
            end;
      end;
      
   s := s + '</colorizer>' + #13#10;
      
   filePath := self._fpath();

	fileId := RewriteFile(filePath, false);
	if (fileId = -1) then
   begin
   	{$IFDEF DEBUG_ON} writeln('***** Tcolorizer.save: RewriteFile failed [', filePath, ']'); {$ENDIF}
      exit;
   end;
	
	if (not WriteFileString(fileId, s)) then	
   begin
   	{$IFDEF DEBUG_ON} writeln('***** Tcolorizer.save: WriteFileString failed [', filePath, ']'); {$ENDIF}
		exit;
	end;  
	CloseFile(fileId);
end;

// -----------------------------------------------------------------------------
// init()
//
// Initialize the object
// -----------------------------------------------------------------------------
procedure Tcolorizer.init(nm: string; ut: string; utt: integer; t: integer; 
   d: integer; minp: integer; maxp: integer);

begin
   self.name          := nm;
   self.uptext        := ut;
   self.uptextTimeout := utt;
   self.tol           := t;
   self.dist          := d;
   self.minPixels     := minp;
   self.maxPixels     := maxp;
//   setLength(self.discovered, 0);
//   setLength(self.active,     0);
//   setLength(self.successful, 0);
//   setLength(self.blacklist,  0);
//   setLength(self.runty,      0);
end;

// -----------------------------------------------------------------------------
// setName()
//
// Initialize the object
// -----------------------------------------------------------------------------
procedure Tcolorizer.setName(nm: string);
begin
   self.name := nm;
end;

// -----------------------------------------------------------------------------
// updateCount()
//
// Updates count info for a color.  Adds it if new.
// -----------------------------------------------------------------------------
procedure Tcolorizer.updateCount(col: integer; cnt: integer);

var
   d, a, s, b, r: integer;
   
begin  
   d := self.discovered.returnInArray(col);
   a := self.active.returnInArray(col);
   s := self.successful.returnInArray(col);
   b := self.blacklist.returnInArray(col);
   r := self.runty.returnInArray(col);
   
   if (d+a+s+b+r = -5) then  // this is a new color
   begin
      setLength(self.discovered, length(self.discovered) + 1);
      with self.discovered[high(self.discovered)] do
      begin
         color     := col;
         count     := cnt;
         attempts  := 0;
         matches   := 0;
         lastPoints := 0;
         lastObj    := 0;
         maxPoints := 0;
         maxObj    := 0;
         queryTime := 0;
      end;
   end
   else
   begin
      if (d >= 0) then
         self.discovered[d].count := self.discovered[d].count + cnt;
      if (a >= 0) then
         self.active[a].count := self.active[a].count + cnt;
      if (s >= 0) then
         self.successful[s].count := self.successful[s].count + cnt;
      if (b >= 0) then
         self.blacklist[b].count := self.blacklist[b].count + cnt;
      if (r >= 0) then
         self.runty[r].count := self.runty[r].count + cnt;
   end;   
end;


// -----------------------------------------------------------------------------
// updateTrials()
//
// Records success/failure of an attempt to use a color.  Will move the 
// color from place to place depending on the situation.
// -----------------------------------------------------------------------------
procedure Tcolorizer.updateTrials(col: integer; success: boolean);

var
   d, a, s, b, r: integer;
   percent: extended;
   
begin  
   d := self.discovered.returnInArray(col);
   a := self.active.returnInArray(col);
   s := self.successful.returnInArray(col);
   b := self.blacklist.returnInArray(col);
   r := self.runty.returnInArray(col);
   
   if (d+a+s+b+r = -5) then 
   begin
      writeln('Tcolorizer.updateTrials: ERROR - Asked to update color, ', col, ' - does not exist');
      exit;
   end

   if (d >= 0) then
      with self.discovered[d] do
      begin
         inc(attempts);
         if (success) then inc(matches);
         // move it to active since it is being used.
         {$IFDEF DEBUG_ON} writeln('***** Tcolorizer.updateTrials: moving (', self.discovered[d].color, ') discovered -> active'); {$ENDIF}
         self.active.append(self.discovered[d]);
         self.discovered.deleteIndex(d);
      end;
      
   if (a >= 0) then
      with self.active[a] do
      begin
         inc(attempts);
         if (success) then inc(matches);
         percent := matches / attempts;
        
         // see if this active color has met criteria for blacklist or success
         
         if ((attempts >= ATTEMPT_THRESHOLD) and (percent < SUCCESS_THRESHOLD)) or
            ((attempts >= 5) and (percent < FAILURE_THRESHOLD)) then
         begin
            {$IFDEF DEBUG_ON} 
               writeln('***** Tcolorizer.updateTrials: moving (', self.active[a].color, 
                  ') active -> blacklist');
            {$ENDIF}
            self.blacklist.append(self.active[a]);   // time to give up on this one
            self.active.deleteIndex(a);
         end
         else if ((matches >= 5) and (percent >= SUCCESS_THRESHOLD)) then
         begin
            {$IFDEF DEBUG_ON} 
               writeln('***** Tcolorizer.updateTrials: moving (', self.active[a].color, 
                  ') active -> successful');
            {$ENDIF}
            self.successful.append(self.active[a]);
            self.active.deleteIndex(a);
            self.save();
         end; 
      end;
      
   if (s >= 0) then
      with self.successful[s] do
      begin
         inc(attempts);
         if (success) then inc(matches);

//         if ((matches / attempts) < (SUCCESS_THRESHOLD - 0.1)) then
//         begin
//            {$IFDEF DEBUG_ON} 
//               writeln('***** Tcolorizer.updateTrials: moving (', self.successful[s].color, 
//                  ') successful -> active');
//            {$ENDIF}
//            self.active.append(self.successful[s]);
//            self.successful.deleteIndex(s);
//            self.save();
//         end;
      end;
      
   if (b >= 0) then
      with self.blacklist[b] do
      begin
         inc(attempts);
         if (success) then inc(matches);
      end;
      
   if (r >= 0) then
      with self.runty[r] do
      begin
         inc(attempts);
         if (success) then inc(matches);
      end;
      
//   self.save();
end;

// -----------------------------------------------------------------------------
// updatePointCount()
//
// Updates stats on a color
// -----------------------------------------------------------------------------
procedure Tcolorizer.updatePointCount(col: integer; points: integer; 
   objs: integer; msec: integer);

var
   d, a, s, b, r: integer;
   
begin  
   d := self.discovered.returnInArray(col);
   a := self.active.returnInArray(col);
   s := self.successful.returnInArray(col);
   b := self.blacklist.returnInArray(col);
   r := self.runty.returnInArray(col);
    
   if (d+a+s+b+r = -5) then 
   begin
      writeln('***** Tcolorizer.updatePointCount: ERROR - Asked to update color, ', 
         col, ' - does not exist');
      exit;
   end

   if (d >= 0) then
      with self.discovered[d] do
      begin
         lastPoints := points;
         lastObj := objs;
         if (points > maxPoints) then maxPoints := points; 
         if (objs > maxObj)      then maxObj    := objs;
         if (msec > queryTime)   then queryTime := msec;
         if (msec > BLACKLIST_THRESHOLD) then // move it to the blacklist
         begin
            {$IFDEF DEBUG_ON} 
               writeln('***** Tcolorizer.updatePointCount: moving (', self.discovered[d].color, 
                  ') discovered -> blacklist');
            {$ENDIF}
            self.blacklist.append(self.discovered[d]);
            self.discovered.deleteIndex(d);
         end
         else if ((objs < 1) and (matches = 0)) then // move it to the runty list
         begin
            {$IFDEF DEBUG_ON} 
               writeln('***** Tcolorizer.updatePointCount: moving (', self.discovered[d].color, 
                  ') discovered -> runty.  objs=', objs, ' points=', points);
            {$ENDIF}
            self.runty.append(self.discovered[d]);
            self.discovered.deleteIndex(d);            
         end
         else // since it is being used, move it to active
         begin
            {$IFDEF DEBUG_ON} 
               writeln('***** Tcolorizer.updatePointCount: moving (', self.discovered[d].color, 
                  ') discovered -> active');
            {$ENDIF}
            self.active.append(self.discovered[d]);
            self.discovered.deleteIndex(d);
         end; 
      end;

   if (a >= 0) then
      with self.active[a] do
      begin
         lastPoints := points;
         lastObj := objs;
         if (points > maxPoints) then maxPoints := points; 
         if (objs > maxObj)      then maxObj    := objs;
         if (msec > queryTime)   then queryTime := msec;
         if (msec > BLACKLIST_THRESHOLD) then // move it to the blacklist
         begin
            {$IFDEF DEBUG_ON} 
               writeln('***** Tcolorizer.updatePointCount: moving (', self.active[a].color, 
                  ') active -> blacklist');
            {$ENDIF}
            self.blacklist.append(self.active[a]);
            self.active.deleteIndex(a);
         end 
         else if ((objs < 1) and (matches = 0)) then // move it to the runty list
         begin
            {$IFDEF DEBUG_ON} 
               writeln('***** Tcolorizer.updatePointCount: moving (', self.active[a].color, 
                  ') active -> runty');
            {$ENDIF}
            self.runty.append(self.active[a]);
            self.active.deleteIndex(a);            
         end;
   end;
      
   if (s >= 0) then
      with self.successful[s] do
      begin
         lastPoints := points;
         lastObj := objs;
         if (points > maxPoints) then maxPoints := points; 
         if (objs > maxObj)      then maxObj    := objs;
         if (msec > queryTime)   then queryTime := msec;
         if (msec > BLACKLIST_THRESHOLD) then // move it to the blacklist
         begin
            {$IFDEF DEBUG_ON} 
               writeln('***** Tcolorizer.updatePointCount: moving (', self.successful[s].color, 
                  ') successful -> blacklist');
            {$ENDIF}
            self.blacklist.append(self.successful[s]);
            self.successful.deleteIndex(s);
            self.save();
         end
         else if (objs < 1) then // move it to the runty list
         begin
     //       {$IFDEF DEBUG_ON} 
     //          writeln('***** Tcolorizer.updatePointCount: moving (', self.successful[s].color, 
     //             ') successful -> runty');
     //       {$ENDIF}
     //       self.runty.append(self.successful[s]);
     //       self.successful.deleteIndex(s);            
         end;         
      end;
      
   if (b >= 0) then
      with self.blacklist[b] do
      begin
         writeln('***** Tcolorizer.updatePointCount: Warning - Updating blacklisted color (', col, ')');
         lastPoints := points;
         lastObj := objs;
         if (points > maxPoints) then maxPoints := points; 
         if (objs > maxObj)      then maxObj    := objs;
         if (msec > queryTime)   then queryTime := msec;
      end;
      
   if (r >= 0) then
      with self.runty[r] do
      begin
         writeln('***** Tcolorizer.updatePointCount: Warning - Updating runty color (', col, ')');
         lastPoints := points;
         lastObj := objs;
         if (points > maxPoints) then maxPoints := points; 
         if (objs > maxObj)      then maxObj    := objs;
         if (msec > queryTime)   then queryTime := msec;
         if (msec > BLACKLIST_THRESHOLD) then // move it to the blacklist
         begin
            {$IFDEF DEBUG_ON} 
               writeln('***** Tcolorizer.updatePointCount: moving (', self.runty[r].color, 
                  ') runty -> blacklist');
            {$ENDIF}
            self.blacklist.append(self.runty[r]);
            self.runty.deleteIndex(r);
         end 
         else if (objs > 1) then // it started providing matches, move out of runty
         begin
            {$IFDEF DEBUG_ON} 
               writeln('***** Tcolorizer.updatePointCount: moving (', self.runty[r].color, 
                  ') runty -> active');
            {$ENDIF}
            self.active.append(self.runty[r]);
            self.runty.deleteIndex(r);            
         end;
      end;  
      
   self.save();
end;

// -----------------------------------------------------------------------------
// delete()
//
// Delete info for a color
// -----------------------------------------------------------------------------
procedure Tcolorizer.delete(col: integer);

var
   d, a, s, b, r: integer;
   
begin 
   d := self.discovered.returnInArray(col);
   a := self.active.returnInArray(col);
   s := self.successful.returnInArray(col);
   b := self.blacklist.returnInArray(col);
   r := self.runty.returnInArray(col);

   if (d+a+s+b+r = -5) then 
   begin
      writeln('Tcolorizer.delete: ERROR - Asked to delete color, ', 
         col, ' - does not exist');
      exit;
   end

   {$IFDEF DEBUG_ON} writeln('***** Tcolorizer.delete: deleting (', col, ')'); {$ENDIF}
            
   if (d >= 0) then self.discovered.delete(col);
   if (a >= 0) then self.active.delete(col);
   if (s >= 0) then self.successful.delete(col);
   if (b >= 0) then self.blacklist.delete(col);
   if (r >= 0) then self.runty.delete(col); 
end;

// -----------------------------------------------------------------------------
// cleanupColors()
//
// Weeds down the color list.  Does not clean sucessful, blacklisted,
// or runty lists since these keep us from using bad colors or are the result
// of hard searching.
// -----------------------------------------------------------------------------
procedure Tcolorizer.cleanupColors();

var
   i, t, cnt: integer;
   found: boolean;
   tmp: Tcolorizer;
   
begin
   self.discovered.cleanupColors();
   self.active.cleanupColors();
end;
 
// -----------------------------------------------------------------------------
// gather()
//
// Gathers a color by screen quadrants so we dont get so bogged
// down on background colors that take forever to collect.  Hopefully 
// don't have to break this into eights or make it recursive.
// -----------------------------------------------------------------------------
function Tcolorizer.gather(var tpa: TPointArray; col: integer): boolean;

var
   b: TBox;
   c: TPoint;
   quadrant: array[0..3] of TBox;
   i: integer;
   timer: TTimeMarker;
   qtpa: TPointArray;
   
begin
   b := mainscreen.getBounds();
   c := mainscreen.getCenterPoint();
   // NE, SE, SW, NW
   quadrant[0] := IntToBox(c.x,  b.y1, b.x2, c.y);
   quadrant[1] := IntToBox(c.x,  c.y,  b.x2, b.y2);
   quadrant[2] := IntToBox(b.x1, c.y,  c.x,  b.y2);
   quadrant[3] := IntToBox(b.x1, b.y1, c.x,  c.y);

   setLength(tpa, 0);
   timer.start();
   for i := 0 to 3 do
   begin
      setLength(qtpa, 0);
      if (findColorsTolerance(qtpa, col, quadrant[i], self.tol)) then
      begin
         if (timer.getTime() > (BLACKLIST_THRESHOLD div 4)) then
         begin
            // dump this color for something more productive
            {$IFDEF DEBUG_ON} 
               writeln('***** Tcolorizer.gather: blacklisting (', col, ') for timeout.'); 
            {$ENDIF}
            self.updatePointCount(col, length(qtpa)*4, 0, BLACKLIST_THRESHOLD+1);
            result := false;
            exit;
         end
         else
            tpa.combine(qtpa);
      end;
   end;
   if (length(tpa) > 0) then
      result := true
   else
      result := false;
end;

// -----------------------------------------------------------------------------
// gather()
//
// Gathers a color into an atpa.
// -----------------------------------------------------------------------------
function Tcolorizer.gather(var atpa: T2DPointArray; c: integer): boolean; overload;

var
   tpa: TPointArray;
   timer: TTimeMarker;
   
begin  
   setLength(tpa, 0);
   result := true;
   timer.start();
   if (not self.gather(tpa, c)) then 
   begin
      result := false;
      // no point in updating if it already got blacklisted
      if (not self.blacklist.isInArray(c)) then
      begin
         self.updatePointCount(c, 0, 0, timer.getTime());
      end;
      exit;
   end;

   atpa := tpa.split(self.dist);
   atpa.filterBetween(0, self.minPixels);
   atpa.filterBetween(self.maxPixels, maxint);
   atpa.sortBySize();

   if (length(atpa) = 0) then
      result := false;
      
   self.updatePointCount(c, length(tpa), length(atpa), timer.getTime());
end;
  
// -----------------------------------------------------------------------------
// sample()
//
// Grabs a sampling of colors around the mouse area
// -----------------------------------------------------------------------------
procedure Tcolorizer.sample(n: integer = 3);

var
   i, x, y: integer;
   b: TBox;
   colList: TIntegerArray;
   
begin
   getMousePos(x,y);
   b := [x, y, x, y];
   b.expand(n);
   if (b.x1 < 0) then b.x1 := 0;
   if (b.x2 < 0) then b.x2 := 0;
   if (b.y1 < 0) then b.y1 := 0;
   if (b.y2 < 0) then b.y2 := 0;
   
   colList := getColors(b.createTPA());
   
   for i := 0 to high(colList) do
      self.updateCount(colList[i], 1);
end;
 
// -----------------------------------------------------------------------------
// deepSample()
//
// Jiggles the mouse around a good spot to see if we can collect more colors
// -----------------------------------------------------------------------------
procedure Tcolorizer.deepSample(x: integer; y: integer; n: integer = 3);

var
   p: TPoint;
   i, t: integer;
   matched: boolean;
   s: string;
   
begin
   p.create(x,y);
   i := 5;
   matched := true;
   while (matched) do
   begin
      matched := false;         
      mouse(p.rand(i));
      inc(i);

      t := getSystemTime() + randomRange(uptextTimeout, uptextTimeout+80);
      repeat
         wait(20);
         s := getMouseOverText();
         if (pos(self.uptext, s) > 0) then
         begin
            matched := true;
            self.sample(n);
         end
         else
            if (s <> '') then  // we got an uptext, but it isnt what we want
               break;
      until (matched or (getSystemTime() > t));         
   end;
end;      
      
      
// -----------------------------------------------------------------------------
// untriedColors()
//
// Returns an array of colors we havent tried yet
// -----------------------------------------------------------------------------
function Tcolorizer.untriedColors() : TIntegerArray;

var
   i, j: integer;
   closeToBG, bgList: TIntegerArray;
   
begin
   if (length(self.discovered) > CLEANUP_LOW_WATER) then
      self.cleanupColors(); // might as well try to cut it down

   self.discovered.sortByCount();

   // put colors close to successful ones first in the list
   for i := 0 to high(self.successful) do
      for j := 0 to high(self.discovered) do
      begin
         if SimilarColors(self.successful[i].color, self.discovered[j].color, 10) then
         begin
            result.append(self.discovered[j].color);
            break;
         end;
      end;

   // find background colors (blacklisted with high queryTime).  Put
   // things close to the blacklist at the end.
   setLength(bgList, 0);
   for i := 0 to high(self.blacklist) do
   begin
      if self.blacklist[i].queryTime > BLACKLIST_THRESHOLD then
         bgList.append(self.blacklist[i].color);
   end;
   setLength(closeToBG, 0);
   for i := 0 to high(bgList) do
      for j := 0 to high(self.discovered) do
      begin
         if (not result.isInArray(self.discovered[j].color)) and
            SimilarColors(bgList[i], self.discovered[j].color, 10) then
         begin
            closeToBG.append(self.discovered[j].color);
            break;
         end;
      end;   
   
   for i := 0 to high(self.discovered) do
      if (not result.isInArray(self.discovered[i].color)) and
         (not closeToBG.isInArray(self.discovered[i].color)) then
      begin
         result.append(self.discovered[i].color);
      end;
      
   result.combine(closeToBG);
end;
   
// -----------------------------------------------------------------------------
// activeColors()
//
// Returns an array of colors we need to test more
// -----------------------------------------------------------------------------
function Tcolorizer.activeColors() : TIntegerArray;

var
   i: integer;
   
begin
   if (length(self.active) > CLEANUP_LOW_WATER) then
      self.cleanupColors(); // might as well try to cut it down
      
   setLength(result, 0);
   self.active.sortBySuccess();
   for i := 0 to high(self.active) do
      result.append(self.active[i].color);
end;

// -----------------------------------------------------------------------------
// successfulColors()
//
// Returns an array of colors we have confidence in
// -----------------------------------------------------------------------------
function Tcolorizer.successfulColors() : TIntegerArray;

var
   i: integer;
   
begin
   self.successful.sortBySuccess();
   for i := 0 to high(self.successful) do
      result.append(self.successful[i].color);
end;

// -----------------------------------------------------------------------------
// multiBox()
//
// Uses the five most successful colors to return a box that is likely 
// to have an NPC in it
// -----------------------------------------------------------------------------
function Tcolorizer.multiBox(var clist: TIntegerArray; rand: boolean = true) : Tbox;

var
   s, pointCount, qTimes: TIntegerArray;
   atpa: T2DPointArray;
   allPoints, tpa: TPointArray;
   t: TTimeMarker;
   i: integer;
   
begin
   s := self.successfulColors();
   if (length(s) < 1) then
   begin
      result := [-1,-1,-1,-1];
      exit;
   end;
   
   setLength(clist, 0);
   setLength(pointCount, 0);
   setLength(qTimes, 0);
   for i := 0 to min(5, high(s)) do
   begin
      t.reset();
      t.start();
      if self.gather(tpa, s[i]) then
      begin
         allPoints.combine(tpa);
         clist.append(s[i]);
         pointCount.append(length(tpa));
         qTimes.append(t.getTime());
      end;      
   end;
   
   atpa := allPoints.split(self.dist);
   atpa.filterBetween(0, self.minPixels);
   atpa.filterBetween(self.maxPixels, maxint);

   if (length(atpa) < 1) then
   begin
      result := [-1,-1,-1,-1];
      exit;
   end;

   if rand then
      result := atpa[random(length(atpa))].getBounds()
   else
   begin
      atpa.sortBySize();
      result := atpa[0].getBounds();
   end;

   for i := 0 to min(5, high(s)) do
      self.updatePointCount(clist[i], pointCount[i], length(atpa), qTimes[i]);
      
   {$IFDEF DEBUG_ON} 
      smartImage.drawBox(result, true, clOrange);
      sleep(80);
      smartImage.clearArea(result);
   {$ENDIF}       
end;

// -----------------------------------------------------------------------------
// likelyBox()
//
// Uses the successful list to return a box that is likely to have an NPC in it
// -----------------------------------------------------------------------------
function Tcolorizer.likelyBox(var c: integer; rand: boolean = true) : Tbox;

var
   s: TIntegerArray;
   atpa: T2DPointArray;
   
begin
   s := self.successfulColors();
   if (length(s) < 1) then
   begin
      result := [-1,-1,-1,-1];
      exit;
   end;
   
   if rand then
      c := s[random(length(s))]
   else
      c := s[0];
      
   if self.gather(atpa, c) then
   begin
      if rand then
         result := atpa[random(length(atpa))].getBounds()
      else
         result := atpa[0].getBounds();
   end
   else
   begin
      result := [-1,-1,-1,-1];
      exit;
   end;
   
   {$IFDEF DEBUG_ON} 
      smartImage.drawBox(result, true, clOrange);
      sleep(80);
      smartImage.clearArea(result);
   {$ENDIF} 
end;

// -----------------------------------------------------------------------------
// testCol()
//
// Sees if a color will get us to the desired mousetext
// -----------------------------------------------------------------------------
function Tcolorizer.testCol(c: integer; trials: integer = 1): boolean;

var
   i, t, x, y: integer;
   s: string;
   atpa: T2DPointArray;
   matched: boolean;
   timer: TTimeMarker;
      
begin    
   result := false;
   if (not self.gather(atpa, c)) then
   begin
      self.updateTrials(c, false);
      exit;
   end;
      
   for i := 0 to high(atpa) do
   begin
      if (trials = 0) then
         break
      else
         trials := trials - 1;;
      
      matched := false;
      timer.start();
      t := randomRange(uptextTimeout, uptextTimeout+80);
      atpa[i].getBounds().mouse();
      repeat
         wait(20);
         s := getMouseOverText();
         if (pos(self.uptext, s) > 0) then
            matched := true
         else
            if (s <> '') then  // we got an uptext, but it isnt what we want
               break;
      until (matched or (timer.getTime() > t));
      
      if (matched) then
      begin
         case random(10) of
            0: begin
                  getMousePos(x,y);
                  self.deepSample(x,y);
               end;
         end;
         self.updateTrials(c, true);
         result := true;
      end
      else
         self.updateTrials(c, false);
   end;  
end;

// -----------------------------------------------------------------------------
// colorize()
//
// Tests colors to try to find new ones that are successful. 
// -----------------------------------------------------------------------------
function Tcolorizer.colorize(maxTime: integer = 120000; enough: integer = 5): boolean;

var
   i, timeout: integer;
   tia: TIntegerArray;
   
begin
   if (length(self.successful) >= enough) then 
   begin
      result := true;
      exit;
   end;
   
   result := false;
   timeout := getSystemTime() + maxTime;

   while (getSystemTime() < timeout) do
   begin  
      if ((length(self.active) < 8) and (length(self.discovered) > 0)) then
      begin
         tia := self.untriedColors();
         if (length(tia) < 1) then exit;
         self.testCol(tia[0], 1);
      end
      else
      begin
         tia := self.activeColors();
         if (length(tia) < 1) then exit;
         self.testCol(tia[random(length(tia))], 5);      
      end;

      if (length(self.successful) >= enough) then
      begin
         {$IFDEF DEBUG_ON} 
            writeln('***** Tcolorizer.colorize: Reached our goal of ', enough, ' good colors.'); 
         {$ENDIF}
         result := true;
         exit;
      end;
   end; 
end;

// -----------------------------------------------------------------------------
// detectObj()
//
// Detect an object in a box. 
// -----------------------------------------------------------------------------
function Tcolorizer.detectObj(var x: integer; var y: integer; var menuText: string; 
   b: TBox; mouseButton: integer = MOUSE_MOVE): boolean;

var
   i, j: integer;
   s: string;
   opts: TOptionArray;
   t: integer;
   p: TPoint;
   matched: boolean;
   
begin
   x := 0;
   y := 0;
   menuText := '';
   result := false;
   matched := false;
   
   if (mouseButton = MOUSE_NONE) or (mouseButton = MOUSE_MIDDLE) then exit;
   
   t := getSystemTime() + randomRange(uptextTimeout, uptextTimeout+80);
   
   repeat
      b.mouse();
      wait(20);
      s := getMouseOverText();
      if (pos(self.uptext, s) > 0) then
      begin
         menuText := s;
         matched := true;
         result := true;
      end
      else     
         if (s <> '') then break;    // we got an uptext, but it isnt what we want
         
   until (matched or (getSystemTime() > t));

   if (matched) then
   begin
      self.sample();
      getMousePos(x,y);          // save this for a sec
      case (mouseButton) of
         MOUSE_LEFT:
            begin
               fastClick(MOUSE_LEFT);
               exit;
            end;
         MOUSE_RIGHT, MOUSE_MOVE:
            begin
               fastClick(MOUSE_RIGHT);
               if (mouseButton = MOUSE_RIGHT) then
               begin
                  result := chooseoption.select([self.uptext], 100);
                  exit;
               end              
               opts := chooseOption.getOptions();
               chooseOption.close();
               for j := 0 to high(opts) do
               begin
                  if (pos(self.uptext, opts[j].str) > 0) then
                  begin
                     menuText := opts[j].str; 
                     break;
                  end;
               end;
               mouse(point(x,y), MOUSE_MOVE);
            end;
      end;
   end;
end;

// -----------------------------------------------------------------------------
// examineGrid()
//
// Try to detect an object in one of the boxes in grid. 
// -----------------------------------------------------------------------------
function Tcolorizer.examineGrid(grid: TBoxArray): string;

var
   i, j, x, y, t: integer;
   s: string;
   opts: TOptionArray;
   p: TPoint;
   matched: boolean;
   
begin
   result := '';
   while (length(grid) > 0) do
   begin
      i := randomRange(0, length(grid));     
      if self.detectObj(x, y, s, grid[i]) then
      begin
         result := s;
         break;
      end;
      grid.deleteIndex(i);
   end;
   if (result <> '') then
      self.deepSample(x,y);  
end;

// -----------------------------------------------------------------------------
// motionDetect()
//
// Finds objects based on screen movement (pixel shift). 
// -----------------------------------------------------------------------------
function Tcolorizer.motionDetect(): string;

var
   i, j, t: integer;
   grid, targetGrid, tried: TBoxArray;
   pixels: TIntegerArray;
   max, percent: integer;
 
begin
   result := '';
   setLength(tried, 0);
   grid := mainscreen.getBounds().split(GRIDSIZE, GRIDSIZE);
   
   for t := 15 to 95 with 20 do
   begin
      if (t > 70) then              // we're not doing very good, lets try some 
         setLength(tried, 0);       // of the boxes we tried earlier
         
      pixels := grid.pixelShift(PIXELSHIFT_WAIT);
      max := pixels.max();
      
      setLength(targetGrid, 0);
      for i := 0 to high(grid) do
      begin
         if (tried.isInArray(grid[i])) then     // dont keep moving the mouse to the 
            continue;                           // same place... try new ones
         
         percent := trunc( ((pixels[i]/max) * 100.0 ));
         if ((percent + t) > 100) then
         begin    
            setLength(targetGrid, length(targetGrid)+1);
            targetGrid[high(targetGrid)] := grid[i];
         end; 
      end;
      
      result := self.examineGrid(targetGrid);      
      if ((result = '') or (result = 'Attack')) then
      begin
         {$IFDEF DEBUG_ON} writeln('***** Tcolorizer.motionDetect: FAILED TO IDENTIFY ANYTHING.  tol=', t); {$ENDIF}
      end
      else
      begin
         {$IFDEF DEBUG_ON} writeln('***** Tcolorizer.motionDetect: Identified - ', result); {$ENDIF}
         exit;
      end;
      
      tried.combine(targetGrid);
   end;
end;    

// -----------------------------------------------------------------------------
// _colorizerTerminate
//
// This is hooked into the script termination stream.
// -----------------------------------------------------------------------------
procedure _colorizerTerminate(); 
begin
end;
 
// -----------------------------------------------------------------------------
// initializer
//
// Ensures we call the function to free DTMS if the script exits.
// Checks for online updates.
// -----------------------------------------------------------------------------
begin
   addOnTerminate('_colorizerTerminate');
   
//   updater.check4update('libcolorizer.simba', libcolorizerVersion, 
//      libcolorizerVerUrl, libcolorizerCodeUrl, true);
end;

A couple of other notes….

It's a good idea to check the box for "logout when exiting". That's the source of some instances of dying. I always leave it unchecked because I'm running around or testing different things.

There will never be looting or banking in the generic fighter. It's for XP or knocking out slayer tasks. Anyway, there is no sensible way to implement generic looting and banking for all npcs. Looting, maybe.

I may release specific versions for something (like a charm gatherer or DRS) but this one won't have it.

Hey, you guys that use the SGS…

Do you want it to activate it the same time it would have eaten food (i.e. don't use it until health drops to the % in the form)?

Or would you prefer to be more aggressive (i.e. use it any time it's available)?

use it same time it would have eaten food

SGS user~~

imo i would prefer it to be more aggressive as you may say


i dont know about the others, though

just a quick question, bonsai, do you use OpenGL or DirectX?

From: nutta124
just a quick question, bonsai, do you use OpenGL or DirectX?

If it doesn't say to use DirectX then always use OpenGL because using OpenGL is part of the correct graphics settings by default. Scripts will specify if they want you to use DirectX because it's not part of the default graphic settings for SIMBA.

It doesn't say to use DirectX in the original post, so you need to use OpenGL

autocoloring is a really good idea man !! i am testing it atm and i will give u feedback and proggries if its flawless :)

From: nutta124
just a quick question, bonsai, do you use OpenGL or DirectX?

I use the directx plugin. The machine I mostly use for this suffers from that opengl crash / white screen.

From: sparkyownage
It doesn't say to use DirectX in the original post, so you need to use OpenGL

The form lets you choose either one. I used to use ogl before it got flaky.

I should be testing both before rolling it out though :)

From: pipos1
autocoloring is a really good idea man !! i am testing it atm and i will give u feedback and proggries if its flawless :)

Tyty. I would appreciate that. Please note the bans this week and use a junk account.

I should probably post updated code, I made a few improvements since posting the version above.

From: bonsai
Tyty. I would appreciate that. Please note the bans this week and use a junk account.

I should probably post updated code, I made a few improvements since posting the version above.

the autocoloring is just amaizing it work perfecly only some monster are just too close to background color so it doesnt find it but its normal:p
and here my little proggries i didnt pass the 6hours limit??[ATTACH=CONFIG]23796[/ATTACH]
i used a new acc that why the exp/h is low but i used right-click and the script is pretty flawless

From: pipos1
the autocoloring is just amaizing it work perfecly only some monster are just too close to background color so it doesnt find it but its normal:p
and here my little proggries i didnt pass the 6hours limit??[ATTACH=CONFIG]23796[/ATTACH]
i used a new acc that why the exp/h is low but i used right-click and the script is pretty flawless

Thanks, pipos.

One of the things not done yet is the XP tracking. For now I set it to 10XP per kill and 1ConstitutionXP.

The string I get back from the menu option can be corrupt. It's not getting some of the yellow text and the spaces get dropped sometimes. So it's hard to get an exact real NPC name. Then need to look the name up on runescape wiki or something to get the XP. I know everyone loves their progress reports but I consider it secondary to making the script work.

Which NPC was too close to BG to color? The ony one I had real trouble with so far is the ghost/ankou. Too much white for that one to work.

I tested some in rooms with 2-3 NPC types and it often ends up with mixed colors from all of them. So it kills a mixture of things.

I saw it catching rats so I know it's fast/accurate enough.

i tried again alot of monster with the autocolor and the only monster it didnt work is monk at edgeville in the dungeon

How long should the autocolour take? Tried it with troll chuckers and t didn't work, (stuck on finding colours) though that might have been because they have similar colours to their background

From: Xiiiii
How long should the autocolour take? Tried it with troll chuckers and t didn't work, (stuck on finding colours) though that might have been because they have similar colours to their background

when the debug is spamming: ***** Tnpc.motionDetect: Trying to identify more colors
just stop the script and start it again when the monster is similar to background it can take 2-3 time before you find it
the autocolor take between about 1-3min once it took me like 6min lol

btw troll chucker work i was training there yesterday

No longer getting the
***** Tnpc.motionDetect: Trying to identify more color
line at troll chuckers, seems to be replaced by this:

***** Tcolorizer.updatePointCount: moving (5332091) discovered -> blacklist
***** Tcolorizer.updatePointCount: moving (9213345) discovered -> active
***** Tcolorizer.updateTrials: moving (12379621) active -> blacklist
***** Tcolorizer.updatePointCount: moving (6586272) discovered -> blacklist
***** Tcolorizer.updatePointCount: moving (8751767) discovered -> active
***** Tcolorizer.updateTrials: moving (9213345) active -> successful
***** Tcolorizer.updatePointCount: moving (5398398) discovered -> blacklist
***** Tcolorizer.updatePointCount: moving (6653600) discovered -> active

this is good its finding color it can take 1-3min but i think its at troll chucker it took me 6min lol

srry for double post my computer lagged :/ idk how to delete it

Have been using it on fire giants, has ran perfectly for 10-15 hours before. This evening I checked on it after 3 hours and found it timed out, Somehow it died at fire giants, last health check in the log showed 78%. I guess it went though another portal and kept taking hits. Maybe make it check health anyway every 30 seconds?

From: plasmahand
Have been using it on fire giants, has ran perfectly for 10-15 hours before. This evening I checked on it after 3 hours and found it timed out, Somehow it died at fire giants, last health check in the log showed 78%. I guess it went though another portal and kept taking hits. Maybe make it check health anyway every 30 seconds?

you should bring ring of life :p

having a little issue loading the script and i can't post a screenshot because i just joined the community, so i'll try my utmost best to describe it. when i start the script, it allows me to choose whatever options but when click "run" a new window pops up saying "invalid parameter". i copied some of the code in simba to below, if that helps.

thanks,

——– Using plugins "OpenGL32.dll"
——– FATAL ERROR: Failed to spawn a SMART client
****** bonsaiFighter: Script shutting down

//////////
//////////////////////////////////////// KILLS ////////////////////////////////////////
////////// Warped Cockroach //////////
////////// 1020(Killed) 582(per hour run) 582(per hour active) //////////
////////// 25398(xp) 14485(per hour run) 14485(per hour active) //////////
////////// 8364(const xp) 4770(per hour run) 4770(per hour active) //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////
Seems to be working well, but choosing warped cockroaches causes it to attack corpse spiders. Choosing corpse spiders makes it attack corpse spiders.

Sweet script. Works nice for slayer. Curently at 55 slayer :) Thankyou

From: prostaker
Sweet script. Works nice for slayer. Curently at 55 slayer :) Thankyou

Thanks. Are you using the original from the first post or the new one I posted a little ways up?

Still working on cleaning things up for an update. I was running a long test yesterday but some fool wanted to be my BF after a couple of hours so I bailed before he reported it :duh:

////////////////////////////////////////////////////////////////////////////////////////////////////
//////////       (                              )\ )                )     )               //////////
//////////     ( )\                     )  (   (()/(  (   (  (   ( /(  ( /(   (   (       //////////
//////////     )((_)  (    (     (   ( /(  )\   /(_)) )\  )\))(  )\()) )\()) ))\  )(      //////////
//////////    ((_)_   )\   )\ )  )\  )(_))((_) (_))_|((_)((_))\ ((_)\ (_))/ /((_)(()\     //////////
//////////     | _ ) ((_) _(_/( ((_)((_)_  (_) | |_   (_) (()(_)| |(_)| |_ (_))   ((_)    //////////
//////////     | _ \/ _ \| ' \))(_-</ _` | | | | __|  | |/ _` | | ' \ |  _|/ -_) | '_|    //////////
//////////     |___/\___/|_||_| /__/\__,_| |_| |_|    |_|\__, | |_||_| \__|\___| |_|      //////////
//////////                                               |___/                            //////////
//////////                                                                                //////////
//////////  Script runtime:                                                               //////////
//////////       2 hr 41 min 51 sec(Total) 2 hr 29 min 3 sec(Active) 12 min 48 sec(Break) //////////
//////////                                                                                //////////
////////////////////////////////////////        KILLS       ////////////////////////////////////////
////////// Gelatinous Abomination                                                         //////////
//////////         561(Killed)     208(per hour run)    226(per hour active)              //////////
//////////       22440(xp)        8320(per hour run)   9040(per hour active)              //////////
//////////        7405(const xp)  2746(per hour run)   2983(per hour active)              //////////
//////////                                                                                //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

hi im using your latest scipt (autodetect) . why on me it always say tnpc.motiondetect: trying to identitiy more color for almost 10 minuets? im trying to hunt corpse spider

From: regzastyle
hi im using your latest scipt (autodetect) . why on me it always say tnpc.motiondetect: trying to identitiy more color for almost 10 minuets? im trying to hunt corpse spider

It might take 5 minutes or so to get colors initially.

The success of the autocolor has some luck involved. If the first time it grabs color it gets bad ones, it will take a long time or sometimes not even find anything.

It if doesn't seem to be hitting them while coloring, stop and retry. I would remove the color file if it made one (SIMBADIR\includes\bonsai\colors)

I'm going to release some coloring tools with the fighter. I figured some ways to pre-seed the color file and get much better results. Then you can color separate from fighting or share color files. I don't like all that crazy mouse activity on my better accounts!

I was able to set it up but when im logged in it just keeps moving the mouse around and then ends it after awhile tried it on Warped Cockroaches.. was planning on using it on Cave slimes but have no idea how to. please help me :<

^Fixed i already got it working but was wondering if it can pick up loot/or bank
anyway can you help me set it up with other monsters as i dont understand the post on 1st page. Thank you

^Fixed Got it to do other monsters
Now trying to develop looting for the script. cant determine what procedure to use it always gives error on compiling

From: bonsai
It might take 5 minutes or so to get colors initially.

The success of the autocolor has some luck involved. If the first time it grabs color it gets bad ones, it will take a long time or sometimes not even find anything.

It if doesn't seem to be hitting them while coloring, stop and retry. I would remove the color file if it made one (SIMBADIR\includes\bonsai\colors)

I'm going to release some coloring tools with the fighter. I figured some ways to pre-seed the color file and get much better results. Then you can color separate from fighting or share color files. I don't like all that crazy mouse activity on my better accounts!

hi im just doing this (if doesn't seem to be hitting them while coloring, stop and retry) like your suggest. its working now and its grab color realy fast. but how can i make it looting coin or specifict food ?
Thanks in advance

From: regzastyle
hi im just doing this (if doesn't seem to be hitting them while coloring, stop and retry) like your suggest. its working now and its grab color realy fast. but how can i make it looting coin or specifict food ?
Thanks in advance

For food, it either uses the 'Z' key or the form has a place to enter the keystroke depending on your version. So bind your food to the actionbar and key and it will eat.

The script does not loot or walk to specific places. You want an NPC specific script for that like The Mayors GAO.

The main bonsaiFighter script is pretty simple. A motivated person could customize it for a specific purpose.

ok thanks. im also using The mayor gao script. its worked well. but your script killing really fast. about 470-500 lvl.19 skeleton per hours. with my 38 combat account. there so many thread in this forum. where can i start to make may own scipt ?

From: regzastyle
ok thanks. im also using The mayor gao script. its worked well. but your script killing really fast. about 470-500 lvl.19 skeleton per hours. with my 38 combat account. there so many thread in this forum. where can i start to make may own scipt ?

Deinitely The Mayor's guide.

Your second post is so helpful, I didn't think about that yet.

Works well, I used it on hell hounds for the charms they drop and it worked great, ran it for about 2 hours and babysat while doing some work just incase.

From: Spaceblow
Your second post is so helpful, I didn't think about that yet.

I'm doing it differently in the next version. It does have the full autodetect/color but I'm finding it best to spend a little time up front pre-coloring. Plus you can run color tests on a junky account. The coloring is really mouse crazy. Anyway, here's how I've been doing it now…

BTW, this process works great to get colors for anything, not just NPCs.

1. Grab a bitmap of the mainscreen in the desired spot.
2. Copy it to another file, edit it, and black out the NPCs.
3. Run a script to grab the colors that make up the NPC.
3a. Compare the blacked out places to the original to come up with every color that was blacked out. This is all the colors in the NPC (plus whatever slop you blacked out).
3b. Take that list, query back to the blacked out mask. Since the mask only has background, this tells us if the color bleeds to other objects and should be avoided.
3c. Query good colors against the full picture to see what a real query would get. If it takes too long, too little results it is weeded out.
3c. Output a list of colors from 3a that did not match the background in 3b or perform poorly in 3c.

This weeds out most of the bad colors that cause long hangs if you do it live. It's shocking to see how big these are, 2000+ colors per NPC even with tol 10/20/30

I run another script while logged in. It takes this color list and makes attempts at NPC location. It weeds through the list and comes up with the truly successful colors that can be used.

Here's an example of the first part for skeletons. They're tough due to similar color with the background. It only found ~50 colors worth using and weeded out ~2800 colors that we need to avoid. Coloring live it would waste tons of time on those.

Skeleton pic Mask result http://pastebin.com/raw.php?i=MBWWiSXe

Road tested the new one… 6 hour fix didn't restart smart but it was cranking along. Still a little pokey but at least it's not crapping out.

////////////////////////////////////////////////////////////////////////////////////////////////////
////////////////////////////////////////       Bonsai       ////////////////////////////////////////
////////////////////////////////////////       Fighter      ////////////////////////////////////////
////////////////////////////////////////       _______      ////////////////////////////////////////
//////////                                                                                //////////
//////////  Script runtime:                                                               //////////
//////////       6 hr 54 min 23 sec(Total) 6 hr 3 min 23 sec(Active) 51 min 0 sec(Break)  //////////
//////////                                                                                //////////
////////////////////////////////////////        Kills       ////////////////////////////////////////
//////////                             Total        Per Hour    /Hour Active              //////////
//////////        warped-fly           1,981          286.83          327.08              //////////
//////////                                                                                //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

I've read your reply multiple times but I still can't visualise most of the stuff you said. I'm feeling kind of dumb because I don't really get it… :p

From: bonsai
1. Grab a bitmap of the mainscreen in the desired spot.

A printscreen would be good enough, I understand this.

From: bonsai
2. Copy it to another file, edit it, and black out the NPCs.

Copy the original and edit the copied file in Photoshop to black out the NPC's, yes I also understand this.

From: bonsai
3. Run a script to grab the colors that make up the NPC.

What script are you talking about? I thought the way to get colours was by using ACA?

From: bonsai
3a. Compare the blacked out places to the original to come up with every color that was blacked out. This is all the colors in the NPC (plus whatever slop you blacked out).
3b. Take that list, query back to the blacked out mask. Since the mask only has background, this tells us if the color bleeds to other objects and should be avoided.
3c. Query good colors against the full picture to see what a real query would get. If it takes too long, too little results it is weeded out.
3c. Output a list of colors from 3a that did not match the background in 3b or perform poorly in 3c.

To be honest, I really don't know what you're talking about. I would lie if I would say that I understood everything… :p

You don't need to explain it because I probably won't use it any time soon but it's definitely a very interesting idea you have. If you have some time on your hands, why not make a little tutorial or something so people like me could learn from you. :)

From: Spaceblow
I've read your reply multiple times but I still can't visualise most of the stuff you said. I'm feeling kind of dumb because I don't really get it… :p

A printscreen would be good enough, I understand this.

Copy the original and edit the copied file in Photoshop to black out the NPC's, yes I also understand this.

What script are you talking about? I thought the way to get colours was by using ACA?

To be honest, I really don't know what you're talking about. I would lie if I would say that I understood everything… :p

You don't need to explain it because I probably won't use it any time soon but it's definitely a very interesting idea you have. If you have some time on your hands, why not make a little tutorial or something so people like me could learn from you. :)

+1 "If you have some time on your hands, why not make a little tutorial or something so people like me could learn from you. :)"

////////// //////////
////////// Script runtime: //////////
////////// 2 hr 13 min 47 sec(Total) 2 hr 13 min 47 sec(Active) 0 sec(Break) //////////
////////// //////////
//////////////////////////////////////// KILLS ////////////////////////////////////////
////////// Catablepon //////////
////////// 1021(Killed) 458(per hour run) 458(per hour active) //////////
////////// 134772(xp) 60442(per hour run) 60442(per hour active) //////////
////////// 44414(const xp) 19918(per hour run) 19918(per hour active) //////////
////////// //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

Hey, I keep getting a start up error.
Edit1: This is with the first version, Non (auto-detect)

Exception in Script: Unknown declaration "i" at line 440, column 25 in file "C:\Simba\Includes\bonsai\libobjfind.simba"

but the auto detect is taking forever to start up,will let you know if i can get it running
Edit: ok got it to work for 40 minutes but then this happend

***** Tnpc.attack: End of fight detected
***** Killed a Attack Gelatinous abomination
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 1
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 2
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 3
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 4
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 5
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 6
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 7
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 8
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 9
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 10
****** Having problems finding NPC, rotating cam.
***** Tnpc.angleTowards: Altering angle to 299
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 11
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 12
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 13
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 14
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 15
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 16
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 17
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 18
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 19
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 20
****** Having problems finding NPC, rotating cam.
***** Tnpc.angleTowards: Altering angle to 347
***** Tcolorizer.updatePointCount: ERROR - Asked to update color, 877739572 - does not exist
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 21
***** Health check returning 71 percent
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 22
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 23
****** Having problems finding NPC, sleeping
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 24
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 25
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 26
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 27
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 28
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 29
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 30
****** Having problems finding NPC, rotating cam.
***** Tnpc.angleTowards: Altering angle to 35
***** Tcolorizer.updatePointCount: ERROR - Asked to update color, 925827072 - does not exist
***** Tcolorizer.updatePointCount: ERROR - Asked to update color, 1010251575 - does not exist
***** Tcolorizer.updatePointCount: ERROR - Asked to update color, 926365495 - does not exist
****** Didnt find a Attack Gelatinous abomination to fight. timesFailed = 31
****** Having problems finding NPC, moving to closest yellow dot
Exception in Script: Runtime error: "Access violation" at line 179, column 9 in file "C:\Simba\Includes\bonsai\libnpc.simba"
The following DTMs were not freed: [0]
The following bitmaps were not freed: [Minimap Mask, SMART Debug Image, Gametab Bitmap[0], Gametab Bitmap[1], Gametab Bitmap[2], Gametab Bitmap[3], Gametab Bitmap[4], Gametab Bitmap[5], Gametab Bitmap[6], Gametab Bitmap[7], Gametab Bitmap[8], Gametab Bitmap[9], Gametab Bitmap[10], Gametab Bitmap[11], Gametab Bitmap[12], Gametab Bitmap[13]]
File[C:\Simba\Includes\SRL-6/logs/SRL log (01-09-14 at 12.57.36 PM).txt] has not been freed in the script, freeing it now.
Compiled successfully in 3073 ms.

"Lag post" sorry.

//////////  Script runtime:                                                               //////////
//////////       1 hr 11 sec(Total) 1 hr 11 sec(Active) 0 sec(Break)                      //////////
//////////                                                                                //////////
////////////////////////////////////////        KILLS       ////////////////////////////////////////
////////// Goblin                                                                         //////////
//////////       285(Killed) 284(per hour run) 284(per hour active)                       //////////
//////////       9690(xp) 9660(per hour run) 9660(per hour active)                        //////////
//////////       285(const xp) 284(per hour run) 284(per hour active)                     //////////
//////////                                                                                //////////
////////////////////////////////////////////////////////////////////////////////////////////////////

It ran pretty well, but I noticed a few areas where improvements would help.

It doesn't seem to have a long enough wait before deciding if it's in a fight or not, if a goblin was walking away from me when it clicked, it would end up picking a new one while I was moving and fighting two. The other thing that seemed off was that the mouse has a tendency to wander around when looking for goblins. I haven't looked through the code to see how it does all the searching, but there has to be a more efficient way of going about it. It wanders past multiple targets before it selects one, typically not succeeding at finding the closest one (leading to the first error). Maybe it's just the colours, I'd have to look closer to figure it out.

In the end, it timed out because it couldn't find any goblins. I hadn't been watching at the time, but when I logged in it was still in the right location. The char I was using wasn't very strong so I doubt I actually killed everything in the area (stronghold). I'd have to be watching closer to give a better report on the failure. I assume that the wandering mouse counts as a try each time, and I could see that causing problems.

Thanks for the updates/info. I'm pretty close on a new version so I will be waiting until then to address more tweaks.

I keep getting sidetracked plus it seems like the script is still working ok (albeit with known flaws).

From: 3Garrett3
It doesn't seem to have a long enough wait before deciding if it's in a fight or not, if a goblin was walking away from me when it clicked, it would end up picking a new one while I was moving and fighting two. The other thing that seemed off was that the mouse has a tendency to wander around when looking for goblins. I haven't looked through the code to see how it does all the searching, but there has to be a more efficient way of going about it. It wanders past multiple targets before it selects one, typically not succeeding at finding the closest one (leading to the first error). Maybe it's just the colours, I'd have to look closer to figure it out.

In the end, it timed out because it couldn't find any goblins. I hadn't been watching at the time, but when I logged in it was still in the right location. The char I was using wasn't very strong so I doubt I actually killed everything in the area (stronghold). I'd have to be watching closer to give a better report on the failure. I assume that the wandering mouse counts as a try each time, and I could see that causing problems.

Left clicking is always going to be an issue. NPCs are pretty quick and it's easy to just miss. Right click is controllable because you know if the menu comes up.

The wandering mouse is some old logic because other popups would block things. Or a bad goblic color.

When the script exits it makes a snapshot in SIMBADIR\includes\srl-6\logs so you may be able to see what it looked like when it gave up.

From: acezfate

but the auto detect is taking forever to start up,will let you know if i can get it running
Edit: ok got it to work for 40 minutes but then this happend

It looks like it thinks its fighting, not detecting. I would remove the color xml file and try to redo it.

I made some improvements on that stuff but the autocoloring is always prone to chance.