SRL Archive - Archive

How Long have You Played Runescape?
7 Year(s)


Are you affilated in anyway with Jagex LTD?
No

Were you Referred to SRL?



What is your general programming knowledge?
I know a little Java, not enough to say I really know it.


Are you a member of any other communities?
bots.rs, Rsbuddy


Tell us about yourself…

From: HardRockers
I am a college football player at the SDSMT in Rapid City, SD. In my spare time I play PS3 and Runescape. I am a Mechanical Engineering Major. My favorite things normally include sports.

Please show us one (or multiple) of your scripts.

{/----------------------------------------------------------------------\\
|                                                                        |
|                    ~~ [HardRockin] Iron Miner ~~                       |
|                            ~Version: 0.5~                              |
|                                                                        |
|                       Please Post Progress Reports                     |
|              Because the script is still in Beta please Monitor        |
|                  All Feedback Helps, Good or Bad                       |
|                                                                        |
|                                Features:                               |
|                -Mines iron ore(at any location right now)              |
|                -Good Antiban                                           |
|                -Uses Smart                                             |
|                -Stat tracking, and progress reports.                   |
|                -2 Methods, Regular and M1D1                            |
|                - FASTEST mining exp on a Simba Script.                 |                - Banking
|                -Banking (only at yanille 3 iron ore spot               |
|                                                                        |
|                                Instructions:                           |
|                -Place Character in a place with Iron ore In Sight      |
|                -Fill in account information Under Declare Players      |
|                -Choose A Method Under Const, 1,2 or 3                  |
|                -Press Start                                            |
|                                                                        |
|                                                                        |
|                                                                        |
|                                                                        |
\\----------------------------------------------------------------------//}


program HardRockinYanilleMiner;
{$DEFINE SMART}
{$i SRL\SRL.scar}
{$i sps/sps.simba}
{$i SRL\SRL\Misc\Stats.simba}


Var
  Count, PlusOne: Integer;
  Exp, EPH: Extended;



Const
SRLStats_Username = '';
SRLStats_Password = '';
NumbOfPlayers= 1;
BreakEvery= 120;
BreakFor= 5;
Version= '0.5'; //NO TOUCHY!
Method= 3;//For regular drop use 1, for M1D1 use 2, for Banking use 3



 Procedure DeclarePlayers;
  begin
    HowManyPlayers := 1;
    NumberOfPlayers(HowManyPlayers);
    CurrentPlayer := 0;
    with Players[0] do
    begin
      Players[0].Name := '';
      Players[0].Pass := '';
      Players[0].Nick := '';
      Players[0].Active := True;
      Players[0].Pin := '';
      end;
  end;

 Procedure StartScript;
  Begin
    SetUpSRL;
    MouseSpeed := 15;
    ActivateClient;
    DeclarePlayers;
    If (Not LoggedIn) then
    LoginPlayer;
    SetAngle(True);
    MakeCompass('n');
  End;
procedure AntiBan;
begin
  case random(100) of
    0: RandomRClick;
    1: BoredHuman;
    2: HoverSkill('Mining', False);
    3: ExamineInv;
    4: RandomMovement;
  end;
end;


Function MineOre:Boolean;
Var
  x,y, MineCounter: Integer;
Begin
  If Not(LoggedIn) Then Exit;
  FindNormalRandoms;
  PlusOne:= InvCount +1;
  x:= MSCX;
  y:= MSCY;

  If FindObjCustom(x, y, ['Mine','Rocks','e R'], [2832738, 2502212, 2701150,2371667], 5) Then
    Begin
      WriteLn('There is ore here.');
      GetMousePos(x, y);
      Mouse(x, y, 2, 2, True);
      IncEx(Count, 1);
      stats_IncVariable('Iron Ore (Mined)', 1);
      Flag;
       Case(Method) of
       1: Repeat
          FindNormalRandoms;
          MarkTime(MineCounter);
          wait(100);
          Antiban;
          If InvCount= PlusOne Then
            WriteLn('You got ore');
          Until (InvCount= PlusOne) OR (TimeFromMark(MineCounter) > 3000);
       2:   Repeat
              FindNormalRandoms;
              MarkTime(MineCounter);
              wait(100);
              If InvCount= PlusOne Then
              WriteLn('You got ore');
            Until (InvCount= PlusOne) OR (TimeFromMark(MineCounter) > 3000);
        3:Repeat
            FindNormalRandoms;
            MarkTime(MineCounter);
            wait(100);
            Antiban;
            If InvCount= PlusOne Then
              WriteLn('You got ore');
          Until (InvCount= PlusOne) OR (TimeFromMark(MineCounter) > 3000);
       end;
    end;
end;

//Function Walking
//By Camaro'
//Uses a combination of coordinates and color to walk using the MM.
Function Walking(Color, Tolerance: Integer; SortFrom: tpoint): Boolean;
var
  i, x, y, rx, ry: Integer;
  TPA: TPointArray;
begin
  if not LoggedIn then Exit;
  FindNormalRandoms;
  FindColorsSpiralTolerance(MMCX, MMCY, TPA, Color, MMX1, MMY1, MMX2, MMY2, Tolerance);
  SortTPAFrom(TPA, SortFrom);

  for i := 0 to High(TPA) do
  begin
    x := TPA[i].x;
    y := TPA[i].y;

    rx := RandomRange(-6, 6);
    ry := RandomRange(-6, 6);
    if (not rs_OnMinimap(x + rx, y + ry)) then
      Continue;

    Mouse(x + rx, y + ry, 0, 0, true);
    FFlag(0);
    Wait(200 + Random(500));
    Result := True;
    Break;
  end;
end;

Procedure WalkToBank;

Begin
  if not LoggedIn then Exit;
  FindNormalRandoms;
  ClickNorth(True);
  Walking(2920289, 20, Point(619, 152));
  Flag;
  Walking(2985828, 20, Point(596, 143));
  Flag;
  Walking(7302775, 20, Point(597, 127));
  Flag;
  Walking(14474724, 20, Point(628, 130));
  Openbank('ynb', False,True);
  DepositAll;
  CloseBank;
End;


Procedure WalkToIron;
Begin
  if not LoggedIn then Exit;
  FindNormalRandoms;
  ClickNorth(True);
  Walking(6580843, 10, Point(640, 48));
  Flag;
  Walking(2918254, 10, Point(646, 21));
  Flag;
  Walking(2390608, 10, Point(662, 26));
  Flag;
  Walking(2837593, 10, Point(633, 73));
End;


//Procedure DropOre;
//By: Hero
//From Hero's Ardy M1D1 script, it is very accurate and precise.
procedure DropOre;// simple and accurate first inventory spot drop loop

  begin//Right clicks and drops first inventory slot and adds
    MMouse(580, 226, 2, 2);
      Mouse(580, 226, 1, 1, false);
    Wait(200 + Random(100));
      ChooseOption('Drop');
    Wait(200 + Random(100));
  end;

procedure ProgressReport;

begin
   Exp := 35;
    EPH := Round(((Count * Exp) * 3600.0) / (GetTimeRunning / 1000.0));
    ClearDebug;
    WriteLn('~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~');
    WriteLn('~~~~~~~~~~~~~ HardRockin Iron Miner ~~~~~~~~~~~~~~');
    WriteLn('Time Running: '+ TimeRunning);
    WriteLn('Mining EXP: '+ FloatToStr(Count * Exp) + ' ');
    WriteLn('Iron Ore Mined : ' + ToStr(Count)+ ' ');
    WriteLn('Mining EXP/HR : ' + ToStr(EPH)+ ' ');
    WriteLn('~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~');
    WriteLn('~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~');
  FindNormalRandoms;
end;

Procedure Method1;
Begin
  if not LoggedIn then Exit;
  FindNormalRandoms;
  repeat
    repeat;
      MineOre;
    Until (InvFull);
      DropAll;
      ProgressReport;
      Stats_Commit;
  Until (NoT Loggedin);
End;

Procedure Method2;
Var
  MineCounter: Integer;
Begin
  if not LoggedIn then Exit;
  FindNormalRandoms;
  PlusOne:= InvCount + 1;
    repeat
      repeat
        MineOre;
        Repeat
          FindNormalRandoms;
          MarkTime(MineCounter);
          wait(100);
          If InvCount= PlusOne Then
            WriteLn('You got ore');
        Until (InvCount= PlusOne) OR (TimeFromMark(MineCounter) > 3000);
        DropOre;
        ProgressReport;
        Stats_Commit;
      Until (InvFull);
        if(Invfull) Then
          DropAll;
          AntiBan;
    Until (Not LoggedIn);
End;

Procedure Method3;
Begin
if not LoggedIn then Exit;
  FindNormalRandoms;
  Repeat
    Repeat
      MineOre;
      ProgressReport;
    Until (InvFull);
      WalkToBank;
      WalkToIron;
      Stats_Commit
  Until (Not LoggedIn);
End;




begin
  StartScript;
  SetupSRLStats(425, SRLStats_Username, SRLStats_Password);
  Case(Method) of
    1:Method1;
    2:Method2;
    3:Method3;
  end;
end.

Yes from me.

Script looks a little on the simple side, but I'm glad to see you took the time to write one :)

-Bam Bam

Edit:
In the future you may want to pay more attention / care to making sure your loops don't become potential infinite loops. Some of the repeat..until loops appear to be infinite if you get logged out.
And, you don't seem to have done much with the multiplayer capabilities of SRL which are fairly simple and worth your time to look into.

Ya, it was a request, and I thought it was within my range of difficulty.

The only thing I had a lot of trouble with is maximizing the production of the M1D1 Xp/hr and when I was doing the bank, EVERYTHING is the same color out there, the combination of coordinates and color seems to work well enough.

SPS would not work here, i tried and tried.

I forgot to include Banking is only supported at Yanille near the 3 iron ores, that is easily adjustable, it was just less buggy there than at the 4 ore location just north of there.

From: HardRockers
Ya, it was a request, and I thought it was within my range of difficulty.

The only thing I had a lot of trouble with is maximizing the production of the M1D1 Xp/hr and when I was doing the bank, EVERYTHING is the same color out there, the combination of coordinates and color seems to work well enough.

SPS would not work here, i tried and tried.

I forgot to include Banking is only supported at Yanille near the 3 iron ores, that is easily adjustable, it was just less buggy there than at the 4 ore location just north of there.

Interesting solution to SPS being sucky thanks to Jagex updates. How long did it take you to come up with that?

There was a tutorial on it in the Intermediate section, It was not my original idea I can say sadly. I did not credit him because it was a tutorial, so i figured it was common knowledge but new to me.

I will say I thought of it before i found the tutorial, but was incapable of producing it alone.

case-statement please instead of if method = 1, if method = 2, if method = 3.

Ya, I was trying, but I couldn't find anyone to confirm that I could use a set number in a case statement. I couldn't find where anyone had done it, all I found were Random( ), and obviously that couldn't be random.

Thank you though. Now I know it can be done.

Edit: and it has now been fixed. I won't change it in this application, but I do have it now in the script. Kyle explained it to me, and it really made me feel dumb that I didn't realize it.

From: HardRockers
There was a tutorial on it in the Intermediate section, It was not my original idea I can say sadly. I did not credit him because it was a tutorial, so i figured it was common knowledge but new to me.

I will say I thought of it before i found the tutorial, but was incapable of producing it alone.

Don't worry about that. I think it's safe to say we've ALL used a tutorial to do something here. You're actually using my preferred method of walking here - and there's a tutorial written by bumblebee on how to do it rather than busting out the clipboard ;)

and to elaborate on what Markus said:

 case method of
1: //blah
2: //blah

The other thing is that you don't have any custom object finding - and since it's at the core of just about every script, I usually vote no for this.

But I like your walking (despite the copy+paste), your attitude, and you're "active enough" - which makes it very hard to click no. I think I'm going to hold my vote for now.
But hey, if you were to take your walking function and comment on what's going on as thoroughly as you can to show that you know what's going on, I wouldn't complain ;)


E: Looks like you've already fixed the cases :P

So you want me to Explain to Walking Function? I can probably do that :)

I personally can't vote on this but I want everyone to know that HardRockers seems to have potential and if he talks to the right people he can grow in to a very good scripter. As he developed the script he asked me for some help and I did as much as I could for him. He seems to have the proper attitude and such as well.

I will also agree with him that the SPS in that area is a bit buggy(but is possible). I will also say this before anyone else does because I know they will. Look into your standards. I think there might even be a script that will fix it for you.

Anyways if I could vote I would definitely say yes because some of you guys went out on a limb for me and it is only fair that you treat others the way you want to be treated.

Good Luck!


Edit
*Hint* Update your script as you get feedback. ;)

Thank you Hero. :)

From: HardRockers
There was a tutorial on it in the Intermediate section, It was not my original idea I can say sadly. I did not credit him because it was a tutorial, so i figured it was common knowledge but new to me.

I will say I thought of it before i found the tutorial, but was incapable of producing it alone.

You should always credit when using procedures or functions from a person's tutorials. Even if you just say something like "idea from..". It will help you keep from getting criticized of plagiarizing.

I'm holding my vote for now, still reviewing your script.

Good luck :)

EDIT: can I ask what the point of this is?

Case Random(1) of
        0: Mouse(x, y, 2, 2, True);
      end;

No point now, I changed it, and never got a chance to save it as my computer locked down.

I will change it again, I had a right click option for that case in there to and got rid of it, as I didn't think to many humans right clicked when powermining most of the time

I have voted no. I dont personally like SPS walking alone. (Its a great thing to have, but doesnt show any skill). So I'm going to ignore that, and imagine its not in the script.

So the mining procedure, very simple, as is the dropping. Without being nasty to you, I cant see why people would vote yes to this, its one of the simplest things anyone could do in scripting.

But I do want you to carry on, and to make it more complex. If you do need any help please pm me.

Ok thank you, and I will jakey.

I don't use SPS though? I use a walking function that I got from a tutorial by Camaro.

This:

Function Walking(Color, Tolerance: Integer; SortFrom: tpoint): Boolean;
var
  i, x, y, rx, ry: Integer;
  TPA: TPointArray;
begin
  if not LoggedIn then Exit;
  FindNormalRandoms;
  FindColorsSpiralTolerance(MMCX, MMCY, TPA, Color, MMX1, MMY1, MMX2, MMY2, Tolerance);
  SortTPAFrom(TPA, SortFrom);

  for i := 0 to High(TPA) do
  begin
    x := TPA[i].x;
    y := TPA[i].y;

    rx := RandomRange(-6, 6);
    ry := RandomRange(-6, 6);
    if (not rs_OnMinimap(x + rx, y + ry)) then
      Continue;

    Mouse(x + rx, y + ry, 0, 0, true);
    FFlag(0);
    Wait(200 + Random(500));
    Result := True;
    Break;
  end;
end;                

From: HardRockers
Ok thank you, and I will jakey.

I don't use SPS though? I use a walking function that I got from a tutorial by Camaro.

This:

Function Walking(Color, Tolerance: Integer; SortFrom: tpoint): Boolean;
var
  i, x, y, rx, ry: Integer;
  TPA: TPointArray;
begin
  if not LoggedIn then Exit;
  FindNormalRandoms;
  FindColorsSpiralTolerance(MMCX, MMCY, TPA, Color, MMX1, MMY1, MMX2, MMY2, Tolerance);
  SortTPAFrom(TPA, SortFrom);

  for i := 0 to High(TPA) do
  begin
    x := TPA[i].x;
    y := TPA[i].y;

    rx := RandomRange(-6, 6);
    ry := RandomRange(-6, 6);
    if (not rs_OnMinimap(x + rx, y + ry)) then
      Continue;

    Mouse(x + rx, y + ry, 0, 0, true);
    FFlag(0);
    Wait(200 + Random(500));
    Result := True;
    Break;
  end;
end;                

FML, sorry. whats with?

{$i sps/sps.simba}

you should credit him, I think ive seen the tut. I'm sorry, I should have been more vigilant. But i'd still have voted no


EDIT: have you used SPS and just added the walking proc in there? I cant even see where you've picked a colour for it

No, I was using SPS but it was buggy, just never took that out. I will, I use that walking function, I call it in my WalkToBank and WalkToIron procedures.

Thanks for catching that, too, I will remove it.

Procedure WalkToBank;

Begin
  if not LoggedIn then Exit;
  FindNormalRandoms;
  ClickNorth(True);
  Walking(2920289, 20, Point(619, 152));
  Flag;
  Walking(2985828, 20, Point(596, 143));
  Flag;
  Walking(7302775, 20, Point(597, 127));
  Flag;
  Walking(14474724, 20, Point(628, 130));
  Openbank('ynb', False,True);
  DepositAll;
  CloseBank;
End;              

Your standards need a little work. I would like you to learn TPA's. Everything else is looking good.

I'm voting yes.

Thank you kyle, and I have been looking into TPA's. I just had so many other things that I was trying to perfect, I am still trying to get the M1D1 function perfect, It works, just could be smoother.

I will learn TPA though. I will learn as much as possible. I am not even here to PLAY runescape anymore, I am here to script. I was bored with rs, this has given me something to be excited about and to put my time into.

From: HardRockers
I will learn as much as possible. I am not even here to PLAY runescape anymore, I am here to script. I was bored with rs, this has given me something to be excited about and to put my time into.

Sounds like a lot of other members here. I voted yes based on what others said(about script), what I think of you, and because of what I quoted. It's better be not a lie :p.

I think too many people are allowed in by promising they will learn more about the things you should know before applying to SRL members. Learn it all, make a darn good script and then apply for SRL members. Guaranteed success!

Becuse of the reasons stated by some others, I voted no.
Should you not get in now, learn from our comments and include more advanced functions in your next script. Good luck! :)

From: Emaziz
I think too many people are allowed in by promising they will learn more about the things you should know before applying to SRL members. Learn it all, make a darn good script and then apply for SRL members. Guaranteed success!

Yeah, I think that too as you may have already read in some of my posts(I see no reason why not to learn 'outside' first …) and I usually vote no in cases like this, but somewhy my inner feelings told me to vote yes now …

And I barely vote yes nowadays, I felt like I am too strict.

p.s.: I can only hope it's worthy yes.

You can be strict, if i don't deserve it, I don't deserve it ya know? No hard feelings for no's, being rejected could be beneficial for me. Not saying I want to be rejected, but it could push me more.

From: HardRockers
You can be strict, if i don't deserve it, I don't deserve it ya know? No hard feelings for no's, being rejected could be beneficial for me. Not saying I want to be rejected, but it could push me more.

I really, really like your attitude, having said that the script is just a little to simple in my opinion. Fix a few of your possible infinite loops, and make a bit more advanced procedures, and you'll have a yes from me.

Looking forward to your next app.

This guy totally deserves SRL Member rank. I have no idea why you guys set the bar so hard for people who are clearly working to earn the rank. Basically you should be voting yes if you think this person can be valuable to our community. We need as much talent as we can get if we're gonna find solutions to everything Jagex throws at us!

-Bam Bam

From: Bam Bam
This guy totally deserves SRL Member rank. I have no idea why you guys set the bar so hard for people who are clearly working to earn the rank. Basically you should be voting yes if you think this person can be valuable to our community. We need as much talent as we can get if we're gonna find solutions to everything Jagex throws at us!

-Bam Bam

Bam Bam, I agree with you, and if his script didn't have infinite loops I would have voted yes. If he fixes it, I'll request my vote be changed.

From: Bam Bam
This guy totally deserves SRL Member rank. I have no idea why you guys set the bar so hard for people who are clearly working to earn the rank. Basically you should be voting yes if you think this person can be valuable to our community. We need as much talent as we can get if we're gonna find solutions to everything Jagex throws at us!

-Bam Bam

I agree 100%.

Not going to vote right now but I love the walking procedure you used. ;)

I worked hard to become SRL member, and the reason I worked hard is because I really wanted to become SRL member. Once I became SRL member I stopped focusing on learning new methods and started… slacking.

He knows he's got it, and I'm sure he'd work and learn more than ever if he gets rejected now. His talent won't disappear if he is rejected. If he gives up if he is rejected, perhaps he wouldn't be so valuable after all? The SRL Member rank should mean that you know your ways in and around the SRL library, and you should know it before you become SRL member, not after. I do disagree with you Bam bam :)

Regardless of what happens I hope he will continue to work and learn hard ;)

EDIT: Bam bam: After reading your post on the "Yet another application thread" I thought I should also mention that I agree that activity and attitude also is a major part of the application. However I still keep a high bar for scripts requirements.

From: Emaziz
I worked hard to become SRL member, and the reason I worked hard is because I really wanted to become SRL member. Once I became SRL member I stopped focusing on learning new methods and started… slacking.

He knows he's got it, and I'm sure he'd work and learn more than ever if he gets rejected now. His talent won't disappear if he is rejected. If he gives up if he is rejected, perhaps he wouldn't be so valuable after all? The SRL Member rank should mean that you know your ways in and around the SRL library, and you should know it before you become SRL member, not after. I do disagree with you Bam bam :)

Regardless of what happens I hope he will continue to work and learn hard ;)

EDIT: Bam bam: After reading your post on the "Yet another application thread" I thought I should also mention that I agree that activity and attitude also is a major part of the application. However I still keep a high bar for scripts requirements.

I agree 100%.

From: Bam Bam
This guy totally deserves SRL Member rank. I have no idea why you guys set the bar so hard for people who are clearly working to earn the rank. Basically you should be voting yes if you think this person can be valuable to our community. We need as much talent as we can get if we're gonna find solutions to everything Jagex throws at us!

-Bam Bam

1. That should probably be discussed in a different are not on a persons application?

In my opinion you don't deserve it yet. You don't show knowledge of TPAs of any real object finding.

Sorry.
-Boom

From: Silent SPY
You should always credit when using procedures or functions from a person's tutorials. Even if you just say something like "idea from..". It will help you keep from getting criticized of plagiarizing.

you're using an SRL include, you're "plagerizing" from the community, I don't think you need to credit someone cause you read their tutorial. That's similar to crediting a college because they taught you how to program…

yes, decent script, good attitude to change/learn/adapt

Yes. I can see you improving.

On the edge, but it looks like you're not going to get in this time.
You may try again next week!