SRL Archive - Reflection

Kinda
Awesome
Ridiculously
Amazing
Makes
Jizz
Appear

Fishing Script.

Credits:

• Awkwardsaw - Helped in the brainstorm of names.
• Camaro - Helped me with the development of my ideas for how to do things.
• Tad - Looked over some of the code and told me it didn't suck :)

Description of the script:

This script is kinda awesome, ridiculously amazing, and will make jizz appear in your pants. If not, you're doing it wrong.

I have recently rewritten large portions of this script to increase efficiency as well as reliability. This script is nearly flawless from what I have seen. The only reason it has stopped for me is the reflection randoms crashing the script. I have not seen any other reason that the script has messed up. For that, I deem this script REBORN!!

It will net or bait and sell to the general store. It will harpoon and cage, going to Stiles and noting the fish. It does not drop tuna. It is faster to note it.

Set this biznatch up:

1. Update your srl and reflection, so you wont complain to me
2. Setup the player near the Karamja dock, preferably on the dock.
3. You must have talked to Stiles if you plan on fishing lobster or tuna/swords, otherwise the chat is different and the script wont recognize it.
4. Only have fishing gear and money (noted fish are allowed too) in your inventory.
5. Setup the constants in the script (The ones before declareplayers)
6. Setup the declareplayers in the script
7. DO NOT TOUCH ANYTHING BELOW WHERE IT SAYS DO NOT TOUCH. You run the risk of messing the script up.
8. Press play and hope for the best

If you are having problems with a random not being solved, please don't blame it on me. Instead, give the most detailed report you can think of to either Colour Random Devs or Reflection Random Devs. If you do this, you will be helping the devs fix these randoms much faster, which will lead to a better autoing experience for you

Note: If you don't mind the script cramming your debug box full, please leave debug enabled and report to me where it messed up :)

Features!

1. Multiplayer
• Can rest when only one player is left
• Can sleep - Rests regardless of how many active players
• Will switch players after a given amount of loads per player
2. Fishes in Karamja
• Fishes all possible types of fish
• When using net or bait it will drop the fish.
• Notes harpoon and cage fish at Stiles
3. Very good antirandom system
• You can use colour or reflection antirandoms - it is user defined
• Note: Reflection randoms (IMO) are better at solving randoms, however they have been known to have a few problems with false positives. Colour randoms are less likely to have false positives, but are also a little shakier at the moment.
4. AntiBan (User customizable for how often)
5. Reflection Walking, Object Finding with TPA fish spot and Stiles finding :)
6. Debug is saved to script location for easy recollection.
7. Saves a picture of RS when it fails, which lets me know what is wrong with it. Post this when it fails please :)
8. Fully Commented
• This allows for extremely easy learning by new members
• This is good for other people to see flaws in my logic and help make the script better
9. Path Walking
• Multiple paths allow for more reliable walking
• The script walks only the necessary steps to get to the end of the path
• Very accurate walking with reflection
10. SRL Stats!
• SRL Stats link: stats.villavu.com
• You must register for this to use it, but it lets me track the usage of the script much easier.

Currently known bugs:
-None!

Version Log
Pub - First version of this script. Tested and works very well.
V0.1 - Commented the entire script. Also fixed a few flaws in logic and added constants for a few things to help organization. Fixed a flaw in the reflection fishing spot finding.
V0.2 - Tried tweaking the TPA text finding for menus. Updated the fish finding significantly to attempt to help out with the menu sometimes failing still.
V0.3 - Fixed the menu finding and added a few backups to the process. There shouldn't be any reason (except a rare SRL bug where the mouse is too wild to keep the menu open) for the script to quit here. The walking paths have been redone and should work well (have been tested)
V0.4 - Completely re-written walking system, fresh logic - hopefully right. Tweaked the TPA fish finding. Added a wait time for antiban and reworked some of the logic for it.
V0.41 - Added a couple lines to make the walking not throw errors for powerfishing when netting.
V0.42 - Made it work with the new reflection.
V0.43 - Added random checking when the dock is lost. Just a one line addition, so it's not extremely urgent to update.

Todo List
-Bug fixes if any arise
-Fish picking up and noting
-Adding second exchange option to Stiles as an option in case the player hasn't talked to him yet.
-Random check in GearCheck
-Colour version of gear finding and fish counting (DTMS)
-Another revamp of walking (idea from MSI :redface:)

Disclaimer
I r not responsible for lost accounts due to bans or t3h own by jagex.

Three Best Proggies!

3Garrett3's Fisherer 0.4 Progress Report
*********************************************
Ran for: 15 Hours, 2 Minutes and 26 Seconds
Fished : 2742 Total Fish
Fished : 2742 Lobsters
Antiban used: 2652
TPA Finder worked: 540 Times
Reflection Finder worked: 1 Times
*********************************************

3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 14 Hours, 55 Minutes and 17 Seconds
Fished : 2080 Total Fish
Fished : 2080 Lobsters
*********************************************

3Garrett3's Fisherer 0.4 Progress Report
*********************************************
Ran for: 14 Hours, 42 Minutes and 4 Seconds
Fished : 2816 Total Fish
Fished : 1442 Tuna
Fished : 1374 Swords
Rested: 30 Times
Rested for: 2 Hours, 37 Minutes and 48 Seconds
Antiban used: 1973
TPA Finder worked: 401 Times
Reflection Finder worked: 6 Times
********************************************* 

Hi garrett!!! :)
Very nice script you have here :)
I don't know if my opinion is "respected" round here yet but here is what I have to say :)

Result := R_FindRandoms;
        If Not Result Then Result := FindNormalRandoms;
        R_FindRandoms;

Why not just do:

if not Result := R_FindRandoms then
   FindNormalRandoms;

? :)

Also, could you not loop through your FindSpotTry's?
in a case or something? :)

I don't have time to look through whole script, it's huge.

Looks awesome :D

-Boom

From: Dynamite
Hi garrett!!! :)
Very nice script you have here :)
I don't know if my opinion is "respected" round here yet but here is what I have to say :)

Result := R_FindRandoms;
        If Not Result Then Result := FindNormalRandoms;
        R_FindRandoms;

Why not just do:

if not Result := R_FindRandoms then
   FindNormalRandoms;

? :)

Also, could you not loop through your FindSpotTry's?
in a case or something? :)

I don't have time to look through whole script, it's huge.

Looks awesome :D

-Boom

if not R_FindRandoms then
   FindNormalRandoms;

Without looking at the script though, I would assume he wants the result of a random check though. So he sets it to result.

It's Back! :D

From: HyperSecret

if not R_FindRandoms then
   FindNormalRandoms;

Without looking at the script though, I would assume he wants the result of a random check though. So he sets it to result.

Surely if he want the result then this would be sufficient:

if not Result := R_FindRandoms then
  Result := FindNormalRandoms;

Wouldn't it?
This is only a friendly little "argument", nothing else :)
Script looks great Garrett, this is just me being picky about saving a line :D
Oh and if ^ works, it would be faster :)

-Boom

From: Dynamite
Surely if he want the result then this would be sufficient:

if not Result := R_FindRandoms then
  Result := FindNormalRandoms;

Wouldn't it?
This is only a friendly little "argument", nothing else :)
Script looks great Garrett, this is just me being picky about saving a line :D
Oh and if ^ works, it would be faster :)

-Boom

You get a error in simba for using := in a if like that.

I used it to set the result of the function to the result of finding randoms. Also added the random check after the first two because sometimes a random doesn't solve the end but if you call it again it will. Who knew. ;)

Also, I do loop through the tries. The function below all of the FishSpotTry's loops through in a case. It just looks nicer in a case with only one function, so I separated them into different functions for the sake of neatness.

@ DeSnob - YESSS!!

Thanks to everyone for the feedback, it's always appreciated :)

w0000t so excited. Thank you so much Garrett!

I've updated the first post and added V0.1 to the attachments. The changes are updated in the first post as well. Post some proggies!

From: 3Garrett3

A Karamja Fisher and Noter/Seller by 3Garrett3

Important Note
- Sell fishes for mid-max, even if it takes a while, you need a break from autoing anyway!

Currently, fishes are going for instant-sellout max ( lots of speculation on the return of the Wilderness and PVP, will likely crash soon in a week or so). Thus, you have no excuse to sell for anything but max :P

Anyways, this looks really promising, I'm going to try it out once I get my army to about 45 fishing or so. Thanks!

From: final_result
Currently, fishes are going for instant-sellout max ( lots of speculation on the return of the Wilderness and PVP, will likely crash soon in a week or so). Thus, you have no excuse to sell for anything but max :P

Anyways, this looks really promising, I'm going to try it out once I get my army to about 45 fishing or so. Thanks!

No problem, be sure to report any success, problems, questions, etc whenever you have them!

I'll update the first post since the GE is likely to be relatively useless soon enough.

E:

3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 8 Hours, 27 Minutes and 42 Seconds
Fished : 1372 Total Fish
Fished : 72 Tuna
Fished : 1300 Lobsters
Rested: 2 Times
Rested for: 49 Minutes and 38 Seconds
Antiban used: 2317
TPA Finder worked: 293 Times
Reflection Finder worked: 10 Times
*********************************************

New longest proggy :). Stopped by reflection random crashing the script.

I have a few players that are doing the lobster fishing fine, but I started a new army to get up fishing, but it seems there is a problem finding the shopkeeper. It only tries twice I believe, and even when it right clicked and the option was available, it failed to click it. I'll read through and see if I can find where it messes up, but I'm sure you could do it much easier.

I gave it a quick first spin and it seems great. :)
I'll do a long run tomorrow. Thanks!

[PHP]3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 1 Hours, 26 Minutes and 49 Seconds
Fished : 242 Total Fish
Fished : 140 Tuna
Fished : 102 Swords
Antiban used: 450
TPA Finder worked: 26 Times
Reflection Finder worked: 3 Times
*********************************************
0: moth | True | 242 Fish | 10 Loads | 2 Levels | 21400 Experience|[/PHP]

From: kitchenrange
I have a few players that are doing the lobster fishing fine, but I started a new army to get up fishing, but it seems there is a problem finding the shopkeeper. It only tries twice I believe, and even when it right clicked and the option was available, it failed to click it. I'll read through and see if I can find where it messes up, but I'm sure you could do it much easier.

It's very possible that something is wrong with the shop keeping. I haven't had anyone test it since it first came out. I'll look into it in the morning (4am right now).

PS- What is the option for the shop keeper? It could very well be that the uptext check is different now. That's what it sounds like at least..

From: Furyan
I gave it a quick first spin and it seems great. :)
I'll do a long run tomorrow. Thanks!

[PHP]3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 1 Hours, 26 Minutes and 49 Seconds
Fished : 242 Total Fish
Fished : 140 Tuna
Fished : 102 Swords
Antiban used: 450
TPA Finder worked: 26 Times
Reflection Finder worked: 3 Times
*********************************************
0: moth | True | 242 Fish | 10 Loads | 2 Levels | 21400 Experience|[/PHP]

Thanks! :)

Hey after further testing it seems like the problem only comes when net fishing. It may have been that i was lagging at the time or something. I havent netted since, but the baitfishing went fine with the shopkeeper.

Weird, seemed to work great yesterday, now it's logging me out all the time.

I'm getting this alot:

[21:36:22] FindSpot activating, could not find spot with TPA
[21:36:29] Fish Spot was found, but was not found on MS after attempts to relocate
[21:36:29] Emergency Logout to recalibrate Fishing spot

Sometimes it goes well though, it's pretty random.

That only happens if the fishing spot is randomly completely under the water when it tries to find it both? times. Not sure how many times it looks, but I've seen it happen a few times.

From: kitchenrange
That only happens if the fishing spot is randomly completely under the water when it tries to find it both? times. Not sure how many times it looks, but I've seen it happen a few times.

Hmm. Ok I'm just leaving this here, because it says so:
It's basically the same as above.

[22:18:59] FindSpot activating, could not find spot with TPA
[22:19:01] Fish Spot was found, but was not found on MS after attempts to relocate
[22:19:01] Fishing Spot not found, player should be on dock however, please report this error.
[22:19:01] Script failed at: FishingMain

From: Furyan
Hmm. Ok I'm just leaving this here, because it says so:
It's basically the same as above.

Shit!

Basically, that means that the script found the fishing spots with reflection, but when it walked to the dock, it still couldn't find the spots on the main screen.. So it looks like I should get to work on fixing that up. I've got a pretty sexy idea for the fishing spot TPA finder, I'll post about it if it actually works ;)

I'll try and optimize the option finder for grouped options, I have a hunch that it might be the cause of messing up on the finding.

A short term fix, try setting the SMART_World to a low populated world so that there will be less 'traffic' so to speak around the fishing spots, meaning it will have a way better chance to find it.

It seemed like from what I saw that it was finding the spot solely on color and the only times it missed and logged were when the white specks of the fishing spot were underwater and there was no sign of the spot visually.

I tried to compile and get eror ;/

[Error] C:\Simba\Includes\SRL/SRL/core/globals.scar(401:1): 'BEGIN' expected at line 400
Compiling failed.

the problem is within SRL not the script, wait for the next revision of SRL to come out :) (should be 672)

Many Thanks,
Sgt Soul

I'll test this when I get a couple levels using a spider killer script for rsbot.

Thanks! I was trying to get 99 when all of a sudden your previous script stopped working. It (I believe) was the only karmaja fisher that noted at stiles that was working. So I moved. on.

From: wondersueak
I'll test this when I get a couple levels using a spider killer script for rsbot.

Thanks! I was trying to get 99 when all of a sudden your previous script stopped working. It (I believe) was the only karmaja fisher that noted at stiles that was working. So I moved. on.

It's okay ;) You're welcome to test any time :)

I'm still working out the logistics for the TPA finder upgrade, it takes way to long the way I tried it this time, so I'm going back to the drawing board.

3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 10 Hours, 34 Minutes and 51 Seconds
Fished : 1019 Total Fish
Fished : 1019 Lobsters
Slept: 2 Times
Slept for: 1 Hours, 58 Minutes and 39 Seconds
Antiban used: 3711
TPA Finder worked: 119 Times
Reflection Finder worked: 9 Times
*********************************************
0: | False | 104 Fish | 4 Loads | 1 Levels | 9000 Experience|
1: | False | 157 Fish | 6 Loads | 2 Levels | 14130 Experience|
2: | False | 0 Fish | 0 Loads | 0 Levels | 0 Experience|
3: | False | 131 Fish | 5 Loads | 2 Levels | 11790 Experience|
4: | False | 27 Fish | 1 Loads | 1 Levels | 2430 Experience|
5: | True | 391 Fish | 15 Loads | 4 Levels | 35190 Experience|
6: | False | 209 Fish | 8 Loads | 3 Levels | 18810 Experience|

I didn't really watch it run, but it obviously worked pretty well.
Player 0:

[Reflection] Trying to solve: Beekeeper
[Reflection] Random solving failed for Beekeeper
[00:24:27] Player was logged out, next player

Wasn't in the beekeeper when i logged in. Player was just standing at the dock.
Player 1: Was in the Evil Bob random
Player 2: (See Player 0)… Weird.
Player 3: (See Player 0)
Player 4:

[04:36:46] GearCheck failed, logging out
[04:36:46] Script failed at: GearCheckMain
[04:36:51] Script failed at: FishingMain
[04:40:27] Player was logged out, next player

It took a break right before this, so im guessing something messed up after logging in.
Player 5: It was another gear check failure, but it happened after getting out of the Molly random.
Player 6: (See Player 4) Same thing, after taking a break…

So there has to be something wrong with the beekeeper random, and i guess gear checking after coming back from a random or a break is a little messed up. Over all amazing! Thanks a ton, im running it again!

From: King of the Nites

3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 10 Hours, 34 Minutes and 51 Seconds
Fished : 1019 Total Fish
Fished : 1019 Lobsters
Slept: 2 Times
Slept for: 1 Hours, 58 Minutes and 39 Seconds
Antiban used: 3711
TPA Finder worked: 119 Times
Reflection Finder worked: 9 Times
*********************************************
0: | False | 104 Fish | 4 Loads | 1 Levels | 9000 Experience|
1: | False | 157 Fish | 6 Loads | 2 Levels | 14130 Experience|
2: | False | 0 Fish | 0 Loads | 0 Levels | 0 Experience|
3: | False | 131 Fish | 5 Loads | 2 Levels | 11790 Experience|
4: | False | 27 Fish | 1 Loads | 1 Levels | 2430 Experience|
5: | True | 391 Fish | 15 Loads | 4 Levels | 35190 Experience|
6: | False | 209 Fish | 8 Loads | 3 Levels | 18810 Experience|

I didn't really watch it run, but it obviously worked pretty well.
Player 0: Wasn't in the beekeeper when i logged in. Player was just standing at the dock.
Player 1: Was in the Evil Bob random
Player 2: (See Player 0)… Weird.
Player 3: (See Player 0)
Player 4: It took a break right before this, so im guessing something messed up after logging in.
Player 5: It was another gear check failure, but it happened after getting out of the Molly random.
Player 6: (See Player 4) Same thing, after taking a break…

So there has to be something wrong with the beekeeper random, and i guess gear checking after coming back from a random or a break is a little messed up. Over all amazing! Thanks a ton, im running it again!

I'm guessing the gear check has something to do with lag, I'll have to add a little failsafe in there for it. I have a good todo list now I like it :)

First posting the proggy :)

I guess I should have mentioned that my computer is SLOW. There is a good chance the lag caused the gear check to fail. Do you have any clue why it is finding the beekeeper random?

From: King of the Nites
I guess I should have mentioned that my computer is SLOW. There is a good chance the lag caused the gear check to fail. Do you have any clue why it is finding the beekeeper random?

Something to do with random solving. Are you using ref or col antirandoms? You should report the bug in the respective thread. That's the only reasoning I can figure.

Adding in a second check for the GearCheck is really simple.

Replace SetupPlayer with this:

Procedure SetupPlayer;
Begin
  Wait(2000);
  MarkTime(BRTime); //Sets the time before breaking, used for knowing when to break
  SetAngle(true);
  R_MakeCompass('n');  //Set the initial conditions
  SetRun(True);
  StartLev := R_GetSkillLevel(Skill_Fishing); //Collect data for the player (used to reduce using Player values
  StartEx := R_GetSkillExperience(Skill_Fishing);
  If (StartLev < 1) Then StartLev := GetSkillLevel(Skill_Fishing);
  If (StartEx < 1) Then StartEx := GetXP(Skill_Fishing);
  Debug('StartLev : ' + ToStr(StartLev) + ' StartXP : ' + ToStr(StartEx));
  GameTab(Tab_Inv);
  LoadsDone := 0;
  If Not Decider Then Failure('Decider'); //If no fishOption can be determined then quit
  If Not GearCheck(ToFish) Then
  Begin
    Wait(RandomRange(150,300));
    If not GearCheck(ToFish) Then Failure('GearCheckSetup'); //If no gear then quit
  End;
  DoRandom;
  If Not LoggedIn Then Exit;
  ScriptSettings; //Determine the settings
End;

It's located around line 1420 for me, it will be lower for you because you have more players set up.

Replace the main loop with this:

Begin
  ScriptSetup;
  LoginPlayer;
  Wait(1500);
  Repeat
    SetupPlayer;
    Repeat
      If Not LoggedIn Then Break;
      Repeat
        DoRandom;
        If Not LoggedIn Then Break;
        If Not GearCheck(ToFish) Then
        Begin
          Wait(RandomRange(100,300));
          If Not GearCheck(ToFish) Then Failure('GearCheckMain');
        End;
        If Not Fishing Then Failure('FishingMain');
      Until (InvFull);
      If Not LoggedIn Then Break;
      R_MakeCompass(0);
      If Not Walk(ToStore) Then Failure('WalkToStore');
      If Not LoggedIn Then Break;
      If Not AfterFishes Then Failure('AfterFishing');
      If Not LoggedIn Then Break;
      If Not Walk(ToDock) Then Failure('WalkToDock');
      If Not LoggedIn Then Break;
      DataCollecter;
      Rester;
      Proggy;
    Until (Not LoggedIn);
    Players[CurrentPlayer].Active := False;
    If AllPlayersInactive Then
      TerminateScript;
    Debug('Player was logged out, next player');
    NextPlayer(False);
  Until (AllPlayersInactive)
End.

These fixes will be included in the next release, I am going to release the entire update when it is ready though, so this will function while you wait :)

When I run this script, RS takes considerably more time to load than other scripts, like 10-15 minutes of load time. It also does not go through the lobby, right when it enters the username and password I am completely logged in. Is this supposed to happen?

EDIT: also resets all my graphics settings as well.

From: doublex8
When I run this script, RS takes considerably more time to load than other scripts, like 10-15 minutes of load time. It also does not go through the lobby, right when it enters the username and password I am completely logged in. Is this supposed to happen?

EDIT: also resets all my graphics settings as well.

It's probably because the script uses the unsigned smart client by default, which is slower and more laggy than signed for many people (from what I've managed to read around here).

If you want to change it, change

Smart_Signed := False;

to

Smart_Signed := True;

From: Furyan
It's probably because the script uses the unsigned smart client by default, which is slower and more laggy than signed for many people (from what I've managed to read around here).

If you want to change it, change

to

This^ :)

E: It loads unsigned client because Jagex cannot detect anything that goes on outside of the client. Using signed gives them access to basically whatever they want.

ahh I see. Thank you very much for the info :)

There's a lot of debates about the unsigjnged vs signed, and I'm too drunk to find the info right now, but youy can do a searcgh for the stuff by Moparisthebest (he's so fucking smart) and find out the threard.

3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 6 Hours, 32 Minutes and 4 Seconds
Fished : 936 Total Fish
Fished : 936 Lobsters
*********************************************
0: | False | 78 Fish | 3 Loads | 1 Levels | 7020 Experience|
1: | False | 364 Fish | 14 Loads | 3 Levels | 29790 Experience|
2: | False | 26 Fish | 1 Loads | 0 Levels | 0 Experience|
3: | False | 104 Fish | 4 Loads | 1 Levels | 7020 Experience|
4: | False | 208 Fish | 8 Loads | 1 Levels | 18720 Experience|
5: | False | 26 Fish | 1 Loads | 0 Levels | 2340 Experience|
6: | False | 130 Fish | 5 Loads | 2 Levels | 11160 Experience|

[02:56:48] We were too far from the dock, getting closer
[02:57:05] FindSpot activating, could not find spot with TPA
[02:57:08] Fish Spot was found, but was not found on MS after attempts to relocate
[02:57:08] Fishing Spot not found, player should be on dock however, please report this error.
[02:57:08] Script failed at: FishingMain

This was the only problem that killed all of my players. It happens when it left clicks on a fishing spot and the menu pops up with all the players names and stuff, it will look at the fishing spot option, but it will be a Net option and it wont click it. The menu then stays open and blocks the entire screen so the script cant find any spots.
It was hard to explain, but if you need a screenshot or something just ask.

Edit* Quick solution: Less crowded world. Haha

possible to add only pickup fish and note them?

From: King of the Nites
3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 6 Hours, 32 Minutes and 4 Seconds
Fished : 936 Total Fish
Fished : 936 Lobsters
*********************************************
0: | False | 78 Fish | 3 Loads | 1 Levels | 7020 Experience|
1: | False | 364 Fish | 14 Loads | 3 Levels | 29790 Experience|
2: | False | 26 Fish | 1 Loads | 0 Levels | 0 Experience|
3: | False | 104 Fish | 4 Loads | 1 Levels | 7020 Experience|
4: | False | 208 Fish | 8 Loads | 1 Levels | 18720 Experience|
5: | False | 26 Fish | 1 Loads | 0 Levels | 2340 Experience|
6: | False | 130 Fish | 5 Loads | 2 Levels | 11160 Experience|



This was the only problem that killed all of my players. It happens when it left clicks on a fishing spot and the menu pops up with all the players names and stuff, it will look at the fishing spot option, but it will be a Net option and it wont click it. The menu then stays open and blocks the entire screen so the script cant find any spots.
It was hard to explain, but if you need a screenshot or something just ask.

Edit* Quick solution: Less crowded world. Haha

Yeah the secondary menu thing is hard to make it find. I made it move the mouse away from the menu if it doesn't find the text, but maybe it doesn't move far enough? The easiest solution is like you said, don't use in a crowded world.

From: bolshak25
possible to add only pickup fish and note them?

I can, swords, lobsters and tuna?

3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 14 Hours, 55 Minutes and 17 Seconds
Fished : 2080 Total Fish
Fished : 2080 Lobsters
*********************************************
0: | False | 0 Fish | 0 Loads | 0 Levels | 0 Experience|
1: | False | 26 Fish | 1 Loads | 0 Levels | 1620 Experience|
2: | False | 416 Fish | 16 Loads | 3 Levels | 36180 Experience|
3: | True | 728 Fish | 28 Loads | 4 Levels | 64350 Experience|
4: | False | 234 Fish | 9 Loads | 2 Levels | 20430 Experience|
5: | False | 286 Fish | 11 Loads | 2 Levels | 23760 Experience|
6: | False | 390 Fish | 15 Loads | 3 Levels | 35010 Experience|

Uhhh what can i say? THANK YOU! Im sorry but I cant give any script details, i came back to find Simba was closed, luckily it saves the progress reports. Here is what I see after logging into RS.
0: Just standing on the dock with a half full invy of lobbies.
1: Same as ^
2: Same as ^
3: Leo random failed.
4: Same as 0
5: Mime random failed.
6: Same as 0.

Im guessing it was the same problem as last time for those 5 accounts. But thank you, it works amazing!

From: King of the Nites
Uhhh what can i say? THANK YOU! Im sorry but I cant give any script details, i came back to find Simba was closed, luckily it saves the progress reports. Here is what I see after logging into RS.
0: Just standing on the dock with a half full invy of lobbies.
1: Same as ^
2: Same as ^
3: Leo random failed.
4: Same as 0
5: Mime random failed.
6: Same as 0.

Im guessing it was the same problem as last time for those 5 accounts. But thank you, it works amazing!

Welcome! :)

I'll have to try and get some time to work out the kinks in the text finding.. Everything else seems to be doing well though? :)

Edit:

Made a couple small changes to the script to help fix the text finding thing. Also added the better TPA fish finder, and made it work with the newest Reflection rev.

yes 3garrett3 swords lobs and tuna. just whatever gets dropped. thatll help me make a bit of cash on the side

Umm im trying to make one myself and i had a quick look though to see how you find stiles, cuz i always fail :p
So do you use color(What im trying) or do you use

Function GetNPCsAtX(t: TTile): TNPCArray; //Credit to JP I believe?

If so, could i use it please and give you and JP credit please.

Thanks

From: Troll Man
Umm im trying to make one myself and i had a quick look though to see how you find stiles, cuz i always fail :p
So do you use color(What im trying) or do you use

Function GetNPCsAtX(t: TTile): TNPCArray; //Credit to JP I believe?

If so, could i use it please and give you and JP credit please.

Thanks

I use colour (seach for FindStilesTPA i believe) and it works very well. I also have a reflection finder as back up, but I didn't use tiles. I just searched for his ID. He's stationary so it is really easy to find him.

Good luck!

I must of missed that, also what color because i cant seem to find a working color.

Thanks :)

3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 10 Hours, 34 Minutes and 51 Seconds
Fished : 1019 Total Fish
Fished : 1019 Lobsters
Slept: 2 Times
Slept for: 1 Hours, 58 Minutes and 39 Seconds
Antiban used: 3711
TPA Finder worked: 119 Times
Reflection Finder worked: 9 Times
*********************************************
0: | False | 104 Fish | 4 Loads | 1 Levels | 9000 Experience|
1: | False | 157 Fish | 6 Loads | 2 Levels | 14130 Experience|
2: | False | 0 Fish | 0 Loads | 0 Levels | 0 Experience|
3: | False | 131 Fish | 5 Loads | 2 Levels | 11790 Experience|
4: | False | 27 Fish | 1 Loads | 1 Levels | 2430 Experience|
5: | True | 391 Fish | 15 Loads| 4 Levels | 35190 Experience|
6: | False | 209 Fish | 8 Loads | 3 Levels | 18810 Experience|

Same thing happened as last time, Simba was closed so im not sure about all the details of what happened.

0:Standing at the dock, half full invy
1: ^^
2: ^^
3: ^^
4: Morduat
5: At dock, empty invy
6: Drill demon

I keep a log of the levels of my bots and one thing i noticed was that how much your script says i leveled, didnt match with how much i checked. It almost seemed like a couple players off. ex. i noticed my account #4 leveled 5 levels, but the script only said it leveled 1 time. My accounts #5&6 did not level at all, but the script said otherwise.

Im not sure what to make of this, but thats what i noticed.

EDIT* Also, I had it set to not sleep, but the proggy said it slept. So I'm also a little confused on that.
EDIT2** I restarted it and watched it. It would click on a fishing spot. A huge list of players/fishing spots/fish would pop up, it would move over to the fishing spot option, and even if cage was a choice, it wouldnt click it. it would just keep hovering over different players names.

I keep getting this;

File[C:\Simba\Includes\SRL/logs/SRL log 14-01-11 2.txt] has not been freed in the script, freeing it now.

From: King of the Nites
Same thing happened as last time, Simba was closed so im not sure about all the details of what happened.

0:Standing at the dock, half full invy
1: ^^
2: ^^
3: ^^
4: Morduat
5: At dock, empty invy
6: Drill demon

I keep a log of the levels of my bots and one thing i noticed was that how much your script says i leveled, didnt match with how much i checked. It almost seemed like a couple players off. ex. i noticed my account #4 leveled 5 levels, but the script only said it leveled 1 time. My accounts #5&6 did not level at all, but the script said otherwise.

Im not sure what to make of this, but thats what i noticed.

EDIT* Also, I had it set to not sleep, but the proggy said it slept. So I'm also a little confused on that.
EDIT2** I restarted it and watched it. It would click on a fishing spot. A huge list of players/fishing spots/fish would pop up, it would move over to the fishing spot option, and even if cage was a choice, it wouldnt click it. it would just keep hovering over different players names.

The basic bug is the long list of text. I guess I could commit the mostly finished new version (.2 or .3 I actually don't remember) which has a little failsafe for this. Also, the line of code says "If Sleeping Then" and then starts sleeping. There can't really be a failsafe for this. I don't know what to tell you? It only increases the sleeped variable after it sleeps and only prints it in the proggy if sleeped is >0.

Also, leveling works by getting the player's start level at the beginning of each log in, and checking each load to see if it has gone up, if so, inc by the difference. It should work, but I can take a look :).

From: B o l t o n
I keep getting this;

File[C:\Simba\Includes\SRL/logs/SRL log 14-01-11 2.txt] has not been freed in the script, freeing it now.

I need the lines above this in the script, because that line is not actually a bug.

Edit:

From: Troll Man
I must of missed that, also what color because i cant seem to find a working color.

Thanks :)

Function FindStilesTPA: Boolean;
Var
  TPA: TPointArray;
  TDPA: T2DPointArray;
  I, CTS, H, X, Y, Tries: Integer;
Begin
  If Not LoggedIn Then Exit;

  SetAngle(False); //This makes it a lot easier to find Stiles
  MakeCompass('n');

  cts := GetColorToleranceSpeed;
  ColorToleranceSpeed(2);
  SetColorspeed2Modifiers(0.09, 0.36);

  For Tries := 0 To 2 Do
  Begin

    FindColorsSpiralTolerance(MSCX, MSCY, TPA, 11185079, MSX1, MSY1, MSX2, MSY2, 16); //Looks for his shirt
    If Length(TPA) = 0 Then
      FindColorsSpiralTolerance(MSCX, MSCY, TPA, 11185079, MSX1, MSY1, MSX2, MSY2, 25);
    TDPA := TPAtoATPAEx(TPA, 30, 20);
    If Length(TDPA) = 0 Then Continue;

    SortATPASize(TDPA, True); //Sorts the biggest ATPA first
  //DebugATPABounds(TDPA);
    H := High(TDPA);
    For i := 0 To H Do
    Begin
      Wait(5);
      MiddleTPAEx(TDPA[i], x, y);
      MMouse(x + 5, y, 2, 2); //Mouse over to the middle of each ATPA
      If WaitUpText('tiles', 1000) Then
      Begin
        GetMousePos(x, y);
        Mouse(x, y, 0, 0, False); //If we find the uptext, click the exact mouse position
        If WaitOptionMulti(['Exchange', 'xcha', 'change', 'nge'], 900) Then
        Begin
          Result := True;
          ColorToleranceSpeed(cts);
          Flag;
          Exit;
        End;
      End;
    End;

  End; //End tries loop
  Result := False; //If it doesn't find Stiles it will make it to this point.
  ColorToleranceSpeed(cts);
End;

Function FindStiles: Boolean;
Var
  Stiles: TNPC;
  StilesMS: TPoint;
Begin
  If Not LoggedIn Then Exit;
  Debug('Finding Stiles');
  If Not GetClosestNPC(Stiles, 'Stiles') Then //Gets the closest NPC
    Stiles := GetNPC('Stiles'); //Else gets the only NPC (should do the same thing)
  If Not TileOnMS(Stiles.Tile, 0) Then
    WalkToTile(Stiles.Tile, 1, 0); //Walks to his tile if he's not on the MS
  If TileOnMS(Stiles.Tile, 0) Then
  Begin
    R_Flag;
    Debug('Finding MS coords');
    StilesMS := TileToMS(Stiles.Tile, 0); //Gets the MS coords
    Mouse(StilesMS.x, StilesMS.y, 2, 2, False); //Clicks Stiles
    If Not WaitOption('Exchange', 900) Then //If it doesn't find the option to exchange
    Begin
      If Not GetClosestNPC(Stiles, 'Stiles') Then //Try the entire thing all over again (allows for misclick)
        Stiles := GetNPC('Stiles');
      StilesMS := TileToMS(Stiles.Tile, 0);
      Mouse(StilesMS.x, StilesMS.y, 2, 2, False);
      Result := WaitOption('Exchange', 900);
      R_Flag;
      Exit;
    End Else //if Waitoption works the first time
    Begin
      R_Flag;
      Result := True;
      Exit;
    End;
  End; //If nothing works
  Result := False;
  Debug('Stiles wasn''t found');
End; 

Line 1200 is the Stiles part, so you know.

Ask if you need anything else :)

Hi, I'm getting this problem on the Ver.2:

[Error] (352:28): Invalid number of parameters at line 351
Compiling failed.

which is this function and the line " NPCs := GetNPCs(FishSpot);" that messes it up. I'm not too sure what the problem is however:

Function GetNPCsOnTile(Tile: TPoint): TNPCArray; //Not sure who gets credit for this. Maybe I made it?
Var
  i, h, resCounter: Integer;
  NPCs: TNPCArray;
Begin
  NPCs := GetNPCs(FishSpot);
  SetLength(Result, Length(NPCs));
  h := High(NPCs);
  For i := h Downto 0 Do
  Begin
    If (Not NPCs[i].Tile.X = Tile.X) Or (Not NPCs[i].Tile.Y = Tile.Y) Then
      Continue;
    Result[resCounter] := NPCs[i];
    Inc(resCounter);
  End;

  SetLength(Result, resCounter);
End;         

From: final_result
Hi, I'm getting this problem on the Ver.2:

which is this function and the line " NPCs := GetNPCs(FishSpot);" that messes it up. I'm not too sure what the problem is however:

Function GetNPCsOnTile(Tile: TPoint): TNPCArray; //Not sure who gets credit for this. Maybe I made it?
Var
  i, h, resCounter: Integer;
  NPCs: TNPCArray;
Begin
  NPCs := GetNPCs(FishSpot);
  SetLength(Result, Length(NPCs));
  h := High(NPCs);
  For i := h Downto 0 Do
  Begin
    If (Not NPCs[i].Tile.X = Tile.X) Or (Not NPCs[i].Tile.Y = Tile.Y) Then
      Continue;
    Result[resCounter] := NPCs[i];
    Inc(resCounter);
  End;

  SetLength(Result, resCounter);
End;         

The very newest version is compatble with the new Reflection. You dont seem to have the new version because it works for eveyone else?

E:

I'm drunk but Oi meant the new reflection and my newest script version. Make sure you have both

From: 3Garrett3
The very newest version is compatble with the new Reflection. You dont seem to have the new version because it works for eveyone else?

E:

I'm drunk but Oi meant the new reflection and my newest script version. Make sure you have both

Thanks, I've been lazy updating because I thought I had it automatically update, but I guess not :P. Works for me now, sorry for bothering you.

From: final_result
Thanks, I've been lazy updating because I thought I had it automatically update, but I guess not :P. Works for me now, sorry for bothering you.

No problem, tell me how it goes!

On another note, I am updating a few things, hopefully adding a bunch of big ol failsafes for the text finding, and then I'll make sure the sleeping thing is working, and likely add in picking up fish and noting, depending on if ground items is working, it could be problematic because I'd imagine there is a large line of text when you try to pick stuff up and SRL doesn't exactly like that. Also I'm working on adding stats, so hopefully this will be a large, sexy update! :D

When will the update be coming? Because I cant find a world that is empty enough so that the script doesnt fail because of the huge chooseoption screen.

Its weird because it
1) clicks the fishing spot
2) huge chooseoption screen comes up
3) moves mouse to fishing option
4) second choose option for fishing comes up
5) even if it's the cage option it wont click…

Thanks.

EDIT* Also a way to get rid of choose option screen is to move the mouse very far away from the choose options. Anywhere on the right side near the inventory or minimap.

From: King of the Nites
When will the update be coming? Because I cant find a world that is empty enough so that the script doesnt fail because of the huge chooseoption screen.

Its weird because it
1) clicks the fishing spot
2) huge chooseoption screen comes up
3) moves mouse to fishing option
4) second choose option for fishing comes up
5) even if it's the cage option it wont click…

Thanks.

EDIT* Also a way to get rid of choose option screen is to move the mouse very far away from the choose options. Anywhere on the right side near the inventory or minimap.

I am unable to even manage my script on SRL Stats so it's hard to add that. I can get on the other stuff. I don't see the point of adding fish picking, the choosing option is too hard with the large stacks. SRL has no way of managing this and obviously even a custom function to search for the text wont really work. I'm thinking bitmaps of the text for the fishing options, but it's really unpractical to add it for the other parts. I can change it to move the mouse to anywhere in the inventory or MM area, I had it just move 100 pixels away from the current location as of now, but obviously that isn't working.

In short, look for the update tomorrow. Earlier if you could get me the bitmaps of the text, or screenies, etc

with picking, just have it hover, then left click if it sees the text in top left corner, instead of right clicking. then there isnt the giant list of things to deal with

From: bolshak25
with picking, just have it hover, then left click if it sees the text in top left corner, instead of right clicking. then there isnt the giant list of things to deal with

I've PMed King of the Nites to test the new system, so if he gets back to me with good news then I can put more time into the picking system. My first goal is to make the fishing work, as that is the main part of the script. Picking will have the remainder of the time. There is 3 types of fish to be picked up, I can likely integrate the options into the system easily, it would be a matter of having custom settings for the picking option and making sure it works with the current setup. Shouldn't take more than an hour to get the code in working order, I'd leave the testing up to you.

3Garrett3's Fisherer 0.3 Progress Report
*********************************************
Ran for: 4 Hours, 54 Minutes and 28 Seconds
Fished : 780 Total Fish
Fished : 780 Lobsters
Antiban used: 1113
TPA Finder worked: 180 Times
Reflection Finder worked: 0 Times
*********************************************
0: | False | 52 Fish | 1 Loads | 0 Levels | 2250 Experience|
1: | True | 208 Fish | 8 Loads | 1 Levels | 18540 Experience|
2: | True | 130 Fish | 5 Loads | 1 Levels | 11700 Experience|
3: | True | 78 Fish | 3 Loads | 0 Levels | 7020 Experience|
4: | False | 26 Fish | 1 Loads | 0 Levels | 2340 Experience|
5: | True | 130 Fish | 5 Loads | 1 Levels | 11700 Experience|
6: | True | 156 Fish | 6 Loads | 1 Levels | 12780 Experience|

It only stopped because either my internet crashed or runescape updated.
The new text finding seems to be working amazing!!!!
0:

[21:57:57] Walking To Dock
[21:58:40] Distance to Dock := 29
[21:58:41] Script failed at: WalkToDock
[21:58:47] Player was logged out, next player

EDIT* Pic :)


Uploaded with ImageShack.us
4: Certer failed

Overall works great. I'll rerun it tonight.

Thanks

I don't know why it would fail at walking? Either way I'll add the picking and try and figure out stats and then make a release of V.3

Yea maybe just some lag or something… Let's just say I'm not running on the best of computers haha.

EDIT* I just ran it really quick, it clicked on a fishing spot and then I was watching the debug and it said it found the (reflection) beekeeper random and that it failed and it quickly logged out (Sorry for all the 'ands' haha). I'll post this somewhere in the reflection randoms place.

From: 3Garrett3
I don't know why it would fail at walking? Either way I'll add the picking and try and figure out stats and then make a release of V.3

Failed a few times walking for me… (after noting fish, on the way back to the dock)

between walking fails and 80,000 people in every f2p world messing up ChooseOption I cant get it to run more than 2 - 3 loads…

Aye, walking fails quite often. But I managed to get this today:

3Garrett3's Fisherer 0.2 Progress Report
*********************************************
Ran for: 7 Hours, 45 Minutes and 10 Seconds
Fished : 1094 Total Fish
Fished : 1094 Lobsters
Rested: 6 Times
Rested for: 1 Hours, 31 Seconds
Antiban used: 1813
TPA Finder worked: 250 Times
Reflection Finder worked: 1 Times
*********************************************
0: *** | True | 1094 Fish | 46 Loads | 5 Levels | 98460 Experience|

Great script, thanks Garret :)

From: nose_smasher
Failed a few times walking for me… (after noting fish, on the way back to the dock)

between walking fails and 80,000 people in every f2p world messing up ChooseOption I cant get it to run more than 2 - 3 loads…

If you see the report from King of the Nites, my new ChooseOption system seems to be working very well. :)

From: Emaziz
Aye, walking fails quite often. But I managed to get this today:

3Garrett3's Fisherer 0.2 Progress Report
*********************************************
Ran for: 7 Hours, 45 Minutes and 10 Seconds
Fished : 1094 Total Fish
Fished : 1094 Lobsters
Rested: 6 Times
Rested for: 1 Hours, 31 Seconds
Antiban used: 1813
TPA Finder worked: 250 Times
Reflection Finder worked: 1 Times
*********************************************
0: *** | True | 1094 Fish | 46 Loads | 5 Levels | 98460 Experience|

Great script, thanks Garret :)

Thank you for the proggy! :)

Also @ both of you,

I have a hunch that it might be randoms that are causing the walking to fail. Could you confirm or deny that for me? I would love to see if maybe the path needs some fixing, or if it is something causing the script to continue trying to walk even though there is a random (what I think is happening).

I'm working on the Stats side of this now that I can safely manage my script and add the variables to it, it's only a matter of today most likely.

No it's not random, I've not watched the very moment when the script fails but it stops in between some trees, like King of the Nite's picture shows. :\

Hi there, I figured out how to get it running and it started fishing, once full it logged out and never droped any of the fish, any ideas on how i may fix this?

Down below is my script.

——————————————————————————————————————————————————

Procedure DeclarePlayers;
Begin
HowManyPlayers := 3;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;

With Players[0] Do
Begin
Name := 'lolbottingfisher@email.com';
Pass := 'passwordgoeshere';
Nick := 'lolbottingfisher@email.com';
Active := True;
Integers[0] := 5; // How many loads to do, plus random 3.
Strings[0] := 'Cage'; // Net, Bait, Harpoon, Cage, Highest
End;

With Players[1] Do
Begin
Name := '';
Pass := '';
Nick := '';
Active := True;
Integers[0] := 5; // How many loads to do, plus random 3.
Strings[0] := 'Cage'; // Net, Bait, Harpoon, Cage, Highest
End;

With Players[2] Do
Begin
Name := '';
Pass := '';
Nick := '';
Active := True;
Integers[0] := 5; // How many loads to do, plus random 3.
Strings[0] := 'Harpoon'; // Net, Bait, Harpoon, Cage, Highest
End;
End;


——————————————————————————————————————————————————
I've fixed the fishing part, now i need help with the dropping part!

Thanks,

-Obx

OPPS DOUBLE POST (Delete Please)

So I read the other thread. This doesn't power fish. It walks to the shopkeeper and sells to him. If that isn't working please tell me :D

From: 3Garrett3
So I read the other thread. This doesn't power fish. It walks to the shopkeeper and sells to him. If that isn't working please tell me :D

Yup, that's what's happening. I fished up a full set of shrimps on a new fisher character. Once that happened it just stood there moving mouse trying to fish more but i was full. It didn't try walking away to sell, note or what ever you expected to.

Any help would be awesome.
——————————————————————————————————————————————————
**EDIT** - I'm on right now fishing and i "disabled smart" because it bugged out, then i "re-enabled it", Doing this caused me to type my email in-game, and password; But my email was censored and my password was not allowed to be said out loud which is fine just a little side note .
——————————————————————————————————————————————————

Thanks,
-Obx

From: obx420
Yup, that's what's happening. I fished up a full set of shrimps on a new fisher character. Once that happened it just stood there moving mouse trying to fish more but i was full. It didn't try walking away to sell, note or what ever you expected to.

Any help would be awesome.
——————————————————————————————————————————————————
**EDIT** - I'm on right now fishing and i "disabled smart" because it bugged out, then i "re-enabled it", Doing this caused me to type my email in-game, and password; But my email was censored and my password was not allowed to be said out loud which is fine just a little side note .
——————————————————————————————————————————————————

Thanks,
-Obx

So fishing shrimp doesn't work? Is there anything in the debug window? I hope you move to harpoon soon enough because harpoon and cage are obviously more used, and more testing means it's better. Nobody really uses the netting although when I first released this script it was working. I haven't gotten any reports of it not working since then though. If it isn't working, it should say where it failed, and if you can post that (in the debug box) it would be really helpful for me to figure out what is wrong

From: 3Garrett3
So fishing shrimp doesn't work? Is there anything in the debug window? I hope you move to harpoon soon enough because harpoon and cage are obviously more used, and more testing means it's better. Nobody really uses the netting although when I first released this script it was working. I haven't gotten any reports of it not working since then though. If it isn't working, it should say where it failed, and if you can post that (in the debug box) it would be really helpful for me to figure out what is wrong

I assumed that, I'm sure it works great with harpoon/cage, I'll just get to it. Do you have any suggestion on any other scripts that may assist me on that right now?

Anyways Thanks,

-Obx

Hey I just tried running this script and I keep getting this message on simba
SMART Initialized.
Loaded: Server 152, Members: False, Signed: False, Super Detail: False.
Error: Out Of Range at line 42
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap]
File[C:\Simba\Includes\SRL/logs/SRL log 20-01-11 3.txt] has not been freed in the script, freeing it now.
I don't know what that means but it wont even log me in.I've tried disabling smart and setting everything to low and sound off but nothing.Other scripts work fine for me and log me in.
Please help!

Also everytime I try opening it up again it makes the SMART box have sound and graphics back to normal. WTF!

From: krayzie420
Also everytime I try opening it up again it makes the SMART box have sound and graphics back to normal. WTF!

That's happening to me as well. Every time i start the script i just manually take everything off while online logged one. (By Turning off Smart, Then Re-Enabling once I'm done)

On a side note, It's official for level's 1-40 it's buggy. The script bugs when the inventory is full from fishing (Shrimp,Anchovies) using the (Net). It heads over the to the shop to sell, Targets the vendor 3-4 times and never attempts to click "Trade"; After that's done it just logs out and doesn't attempt to log back in. Instead I have to log on, sell food manually (by turning smart off); Then heading back to docks to log out, then "Stopping" Simba then "Playing" (then enable smart) And it repeats the process, logs in gets full, logs out.

Any help would be great!

Thanks,


-Obx

From: obx420
That's happening to me as well. Every time i start the script i just manually take everything off while online logged one. (By Turning off Smart, Then Re-Enabling once I'm done)

On a side note, It's official for level's 1-40 it's buggy. The script bugs when the inventory is full from fishing (Shrimp,Anchovies) using the (Net). It heads over the to the shop to sell, Targets the vendor 3-4 times and never attempts to click "Trade"; After that's done it just logs out and doesn't attempt to log back in. Instead I have to log on, sell food manually (by turning smart off); Then heading back to docks to log out, then "Stopping" Simba then "Playing" (then enable smart) And it repeats the process, logs in gets full, logs out.

Any help would be great!

Thanks,


-Obx

At the ScriptSetup-procedure, change "Smart_Signed := False" to "Smart_Signed := True", that will make it remember your standard settings and start properly :)

From: obx420
That's happening to me as well. Every time i start the script i just manually take everything off while online logged one. (By Turning off Smart, Then Re-Enabling once I'm done)

On a side note, It's official for level's 1-40 it's buggy. The script bugs when the inventory is full from fishing (Shrimp,Anchovies) using the (Net). It heads over the to the shop to sell, Targets the vendor 3-4 times and never attempts to click "Trade"; After that's done it just logs out and doesn't attempt to log back in. Instead I have to log on, sell food manually (by turning smart off); Then heading back to docks to log out, then "Stopping" Simba then "Playing" (then enable smart) And it repeats the process, logs in gets full, logs out.

Any help would be great!

Thanks,


-Obx

For the resetting the settings, if you read any of the thread it's been mentioned before. Just set SMART_Signed to True. It's a built in feature in SMART, not anything to do with the script ;)

Also the script is buggy to level 35, because nobody has ever tested it other than me about 5 months ago. I can look at it but adding stats and making sure that the walking works is the main goal. These bugs showed up at a bad time because I have a lot of work due tomorrow so I wont likely get them fixed until the weekend.

In the mean time, if you can't wait, MSI has a good array of fishing scripts.

From: 3Garrett3
For the resetting the settings, if you read any of the thread it's been mentioned before. Just set SMART_Signed to True. It's a built in feature in SMART, not anything to do with the script ;)

Also the script is buggy to level 35, because nobody has ever tested it other than me about 5 months ago. I can look at it but adding stats and making sure that the walking works is the main goal. These bugs showed up at a bad time because I have a lot of work due tomorrow so I wont likely get them fixed until the weekend.

In the mean time, if you can't wait, MSI has a good array of fishing scripts.

Hey man it's okay i already assumed that's why it wasn't working, it not being tested. I'll look forward to 40+.

As for sorry, dude no! You're doing us a favor these scripts take a while!

Anyways Thanks,

-Obx

Getting an error on line 63

"Const"

right under

{DON'T TOUCH ANYTHING BELOW THIS!}

I downloaded the older versions to see if maybe there was a typo on that line but it's the same.. I can't compile it etc

not sure what to do, but I'd love to post some proggies

3Garrett3's Fisherer 0.2 Progress Report
*********************************************
Ran for: 4 Hours, 53 Minutes and 45 Seconds
Fished : 858 Total Fish
Fished : 858 Lobsters
Rested: 2 Times
Rested for: 14 Minutes and 3 Seconds
Antiban used: 1200
TPA Finder worked: 172 Times
Reflection Finder worked: 0 Times
*********************************************
0: **** | True | 858 Fish | 33 Loads | 1 Levels | 77220 Experience|

stopped by me

From: gratz
Getting an error on line 63

"Const"

right under

{DON'T TOUCH ANYTHING BELOW THIS!}

I downloaded the older versions to see if maybe there was a typo on that line but it's the same.. I can't compile it etc

not sure what to do, but I'd love to post some proggies

Well the most helpful thing would be posting the entire debug around there, then I can know for sure. But my best guess is that you're not setting up your players correctly. Make sure the number of players is correct.

E: @Xiras, Thanks! :)

Hey 3Garrett3, thought I'd put in my 2 cents…
Here's my BEST progress report that I've got using this script. Ended about a hour ago [my computer lagged].

3Garrett3's Fisherer 0.2 Progress Report
*********************************************
Ran for: 1 Hours, 36 Minutes and 37 Seconds
Fished : 288 Total Fish
Fished : 137 Tuna
Fished : 151 Swords
Antiban used: 195
TPA Finder worked: 45 Times
Reflection Finder worked: 8 Times
*********************************************
0: | True | 288 Fish | 12 Loads | 0 Levels | 25960 Experience|

Next, I'd say the new ChooseOption works a lot better [already established I know]. Generally, the script will fail at walking [to/from Stiles]. That would be the most common error. I've tried watching it when it does, but, to me, it seems to just randomly stop and log out.
Lastly, it'll fail [SOMETIMES] while fishing because the spot is busy, and when it right clicks a HUGE list comes up and it has issues finding the right fishing option [assuming that the fishing option is available].

Overall, I'd say it's an AMAZING script. It has leveled 1 player 20+ levels already and I've fished a total of 4000+ fish with it. Thank you! :D

From: Valithor
Hey 3Garrett3, thought I'd put in my 2 cents…
Here's my BEST progress report that I've got using this script. Ended about a hour ago [my computer lagged].

3Garrett3's Fisherer 0.2 Progress Report
*********************************************
Ran for: 1 Hours, 36 Minutes and 37 Seconds
Fished : 288 Total Fish
Fished : 137 Tuna
Fished : 151 Swords
Antiban used: 195
TPA Finder worked: 45 Times
Reflection Finder worked: 8 Times
*********************************************
0: | True | 288 Fish | 12 Loads | 0 Levels | 25960 Experience|

Next, I'd say the new ChooseOption works a lot better [already established I know]. Generally, the script will fail at walking [to/from Stiles]. That would be the most common error. I've tried watching it when it does, but, to me, it seems to just randomly stop and log out.
Lastly, it'll fail [SOMETIMES] while fishing because the spot is busy, and when it right clicks a HUGE list comes up and it has issues finding the right fishing option [assuming that the fishing option is available].

Overall, I'd say it's an AMAZING script. It has leveled 1 player 20+ levels already and I've fished a total of 4000+ fish with it. Thank you! :D

Yea, I'm almost to Harpoon fishing. I can't wait to use this when i can start noting! Right now I'm manually fishing.

On a side note I want to point out some of the things you said were 100% correct even when i was playing.
——————————————————————————————————————————————————
Bugs-
(1) It get's lost going places sometimes.
(2) It kind of freaks out when a lot of players in a spot, Causing it not to fish and at times even log out because it Didn't find it.
(3) Needs to be fixed for lowbie leveling! (Net+) To actually sell items instead of it freaking out! (It targets the vendor but never 'trades' and sells the items) It just logs out.

Suggestion-
It seems harder to script it to walk and try and sell the items (Net-Pole Fishing) to the shop, Instead why not just make it to where it drops the items up till Harpoon+? (Tuna,Swordfish,Lobster,Shark). This would make scripting easier, and leveling faster I'm assuming.
——————————————————————————————————————————————————

Overall as i said earlier, I can't wait to try it out my self when i start using it fully (Harpoon+); I've heard nothing but good reports about it, So I'll use it then.

——————————————————————————————————————————————————

From: 3Garrett3
For the resetting the settings, if you read any of the thread it's been mentioned before. Just set SMART_Signed to True. It's a built in feature in SMART, not anything to do with the script ;)

Also the script is buggy to level 35, because nobody has ever tested it other than me about 5 months ago. I can look at it but adding stats and making sure that the walking works is the main goal. These bugs showed up at a bad time because I have a lot of work due tomorrow so I wont likely get them fixed until the weekend.

In the mean time, if you can't wait, MSI has a good array of fishing scripts.

Hey man where exactly is the Smart code in the script lol? If you don't mind may you please copy and paste the specific line i should be looking at?

Thanks,

-Obx

From: 3Garrett3
Well the most helpful thing would be posting the entire debug around there, then I can know for sure. But my best guess is that you're not setting up your players correctly. Make sure the number of players is correct.

E: @Xiras, Thanks! :)

Where do I find the whole debug other than just

[Error] (64:1): Identifier expected at line 63
Compiling failed.

Is that setup wrong?

Procedure DeclarePlayers;
Begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  With Players[0] Do
  Begin
    Name := 'account';
    Pass := 'password';
    Nick := 'acc';
    Active := True;
    Integers[0] := 5; // How many loads to do, plus random 3.
    Strings[0] := 'Cage'; // Net, Bait, Harpoon, Cage, Highest
  End;    

Progress Report
*********************************************
Ran for: 7 Hours, 30 Minutes and 37 Seconds
Fished : 1252 Total Fish
Fished : 1252 Lobsters
Rested: 4 Times
Rested for: 20 Minutes and 19 Seconds
Antiban used: 1889
TPA Finder worked: 261 Times
Reflection Finder worked: 0 Times
*********************************************
0: **** | True | 1252 Fish | 50 Loads | 4 Levels | 112500 Experience|

failed walking back to dock

From: Valithor
Hey 3Garrett3, thought I'd put in my 2 cents…
Here's my BEST progress report that I've got using this script. Ended about a hour ago [my computer lagged].

3Garrett3's Fisherer 0.2 Progress Report
*********************************************
Ran for: 1 Hours, 36 Minutes and 37 Seconds
Fished : 288 Total Fish
Fished : 137 Tuna
Fished : 151 Swords
Antiban used: 195
TPA Finder worked: 45 Times
Reflection Finder worked: 8 Times
*********************************************
0: | True | 288 Fish | 12 Loads | 0 Levels | 25960 Experience|

Next, I'd say the new ChooseOption works a lot better [already established I know]. Generally, the script will fail at walking [to/from Stiles]. That would be the most common error. I've tried watching it when it does, but, to me, it seems to just randomly stop and log out.
Lastly, it'll fail [SOMETIMES] while fishing because the spot is busy, and when it right clicks a HUGE list comes up and it has issues finding the right fishing option [assuming that the fishing option is available].

Overall, I'd say it's an AMAZING script. It has leveled 1 player 20+ levels already and I've fished a total of 4000+ fish with it. Thank you! :D

Yeah the walking is kinda laggy because of the path, I guess. I'm going to remake the paths tonight most likely, or tomorrow. School is really busy lately. Thanks for the proggy though! :)

From: obx420
Yea, I'm almost to Harpoon fishing. I can't wait to use this when i can start noting! Right now I'm manually fishing.

On a side note I want to point out some of the things you said were 100% correct even when i was playing.
——————————————————————————————————————————————————
Bugs-
(1) It get's lost going places sometimes.
(2) It kind of freaks out when a lot of players in a spot, Causing it not to fish and at times even log out because it Didn't find it.
(3) Needs to be fixed for lowbie leveling! (Net+) To actually sell items instead of it freaking out! (It targets the vendor but never 'trades' and sells the items) It just logs out.

Suggestion-
It seems harder to script it to walk and try and sell the items (Net-Pole Fishing) to the shop, Instead why not just make it to where it drops the items up till Harpoon+? (Tuna,Swordfish,Lobster,Shark). This would make scripting easier, and leveling faster I'm assuming.
——————————————————————————————————————————————————

Overall as i said earlier, I can't wait to try it out my self when i start using it fully (Harpoon+); I've heard nothing but good reports about it, So I'll use it then.

——————————————————————————————————————————————————



Hey man where exactly is the Smart code in the script lol? If you don't mind may you please copy and paste the specific line i should be looking at?

Thanks,

-Obx

You should look at line 22 (for me at least). The code is:

SmartSigned = True; //Use signed? True is signed, false is unsigned.

True should be the setting you're looking for.

Thanks for the bug reports too. I think that I've fixed the chooseoption part (for the next release) already, and I just mentioned ^^^^^ that I'll be remaking the paths to Stiles tonight probably. And the low level thing should be really easy to fix. You mentioned it doesn't trade. If it right clicks the shopkeeper but just doesn't choose the right option, it's the easiest bug to fix. What I have it set to do is right click the shopkeeper and wait until the option to 'Trade' is there. If the option is different, it will fail. If not, maybe the wait time isn't enough. If the finder isn't really working, then I might have to do a bit more work, but it shouldn't be hard overall.

From: gratz
Where do I find the whole debug other than just

[Error] (64:1): Identifier expected at line 63
Compiling failed.

Is that setup wrong?

Procedure DeclarePlayers;
Begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  With Players[0] Do
  Begin
    Name := 'account';
    Pass := 'password';
    Nick := 'acc';
    Active := True;
    Integers[0] := 5; // How many loads to do, plus random 3.
    Strings[0] := 'Cage'; // Net, Bait, Harpoon, Cage, Highest
  End;    

If that's the exact DeclarePlayers procedure than you're missing an End; at the bottom.

Procedure DeclarePlayers;
Begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  With Players[0] Do
  Begin
    Name := 'account';
    Pass := 'password';
    Nick := 'acc';
    Active := True;
    Integers[0] := 5; // How many loads to do, plus random 3.
    Strings[0] := 'Cage'; // Net, Bait, Harpoon, Cage, Highest
  End;  

End;  

From: xiras
Progress Report
*********************************************
Ran for: 7 Hours, 30 Minutes and 37 Seconds
Fished : 1252 Total Fish
Fished : 1252 Lobsters
Rested: 4 Times
Rested for: 20 Minutes and 19 Seconds
Antiban used: 1889
TPA Finder worked: 261 Times
Reflection Finder worked: 0 Times
*********************************************
0: **** | True | 1252 Fish | 50 Loads | 4 Levels | 112500 Experience|

failed walking back to dock

Working on fixing that bug tonight :) Thanks for the proggy :D

Ah thanks Garrett, I don't know where the end went lol.. I'll check it out in a bit

From: gratz
Ah thanks Garrett, I don't know where the end went lol.. I'll check it out in a bit

No problem, you probably just lost it when you were removing the extra players. Looking forward to a proggie :)

Also!

Huge Update!?!!? :D

Tested to work:
-Walking Paths (Stiles and Shop)
-Fishing of all levels!
-Selling to shop keeper
-Text finding has many backups
-Stats! :D

ToDo for next version
-Revamp of walking. The current system is kinda lame and I'd like to do some creative stuff with at least randomizing which path it uses and making tile walking much more fluid.

Now love love love and sign up for stats, here http://stats.villavu.com/

3Garrett3's Fisherer 0.3 Progress Report
*********************************************
Ran for: 2 Hours, 9 Minutes and 28 Seconds
Fished : 286 Total Fish
Fished : 277 Shrimps
Fished : 9 Anchovies
Rested: 1 Times
Rested for: 33 Minutes and 56 Seconds
Antiban used: 341
TPA Finder worked: 62 Times
Reflection Finder worked: 2 Times
*********************************************
0: xxx | True | 286 Fish | 11 Loads | 15 Levels | 2870 Experience|

Great script. Got caught at InvFull once and kept trying to fish for about 5 minutes before it corrected itself. Loads doesn't seem to work right. I put 5 loads and its on 9 (more than + random 3) and still counting. Will update proggy when it decides to stop. :)

EDIT: It messed up immediately after rest. Not sure what happened, all I know is I checked on it 6 minutes after rest was supposed to be over and it had errored out saying:

[23:01:02] GearCheck failed, logging out
[23:01:02] GearCheck failed, logging out
[23:01:02] Script failed at: GearCheckMain
[23:01:18] Script failed at: FishingMain

Well if you're using one player it just goes forever and rests once it reaches the time you've set. Loads setting only changes how often it will switch players :)

Also, I have no idea why that debug shows. It calls 'LogOut;' right after it says where it failed, but I know it didn't log your player out, it happened to me before too. So SRL wont log out for some reason when it's called.. Also the check may have failed because you weren't properly logged in. Do you have the screenshot that it took of failing? It should have saved it to the same place as your script :)

I was only able to run the old version for about 1-2 loads max with the old fish spot finding, here is what I was able to do with the new update:

3Garrett3's Fisherer 0.3 Progress Report
*********************************************
Ran for: 10 Hours, 15 Minutes and 31 Seconds
Fished : 1900 Total Fish
Fished : 1028 Tuna
Fished : 872 Swords
Antiban used: 3574
TPA Finder worked: 346 Times
Reflection Finder worked: 17 Times
*********************************************
0: xxxx | True | 1900 Fish | 76 Loads | 4 Levels | 169440 Experience|

For some reason the script failed walking back to the dock in the middle of the path.

From: patman16
I was only able to run the old version for about 1-2 loads max with the old fish spot finding, here is what I was able to do with the new update:

3Garrett3's Fisherer 0.3 Progress Report
*********************************************
Ran for: 10 Hours, 15 Minutes and 31 Seconds
Fished : 1900 Total Fish
Fished : 1028 Tuna
Fished : 872 Swords
Antiban used: 3574
TPA Finder worked: 346 Times
Reflection Finder worked: 17 Times
*********************************************
0: xxxx | True | 1900 Fish | 76 Loads | 4 Levels | 169440 Experience|

For some reason the script failed walking back to the dock in the middle of the path.

If you could tell me what the Debug said (it saves them to the same folder as the script) as well as posting the screenshot (it takes one when it fails and saves to the same spot as the script) I would really appreciate it. Thanks much for the proggy though!

Here's the image, I wasn't able to find what the error message said but from what I can remember the debug said "too far away from dock, getting closer", and then failed and stopped the script saying "(fail)WalkToDock" or something to that effect.

Huh, well the paths should be in working order though. It might just be the walking system. Next update will be a major revamp :D.

From: 3Garrett3
No problem, you probably just lost it when you were removing the extra players. Looking forward to a proggie :)

Also!

Huge Update!?!!? :D

Tested to work:
-Walking Paths (Stiles and Shop)
-Fishing of all levels!
-Selling to shop keeper
-Text finding has many backups
-Stats! :D

ToDo for next version
-Revamp of walking. The current system is kinda lame and I'd like to do some creative stuff with at least randomizing which path it uses and making tile walking much more fluid.

Now love love love and sign up for stats, here http://stats.villavu.com/

Now there are two great fishing bots, yours and harry's :P

I do like how it clicks your friends etc, because I do click that often while I play.. the camera movement is kind of a lot I think, i usually have north up and never move it..
Typing this while I fish actually.. I think the camera movement is over done a lot, makes it seem more bot like imo, more random clicks on your stats etc would be better

Ran for: 1 Hours, 3 Minutes and 22 Seconds
Fished : 202 Total Fish
Fished : 121 Tuna
Fished : 81 Swords
Antiban used: 274
TPA Finder worked: 37 Times
Reflection Finder worked: 0 Times

I have to go to class so I manually stopped.







btw I had stats on the whole time, I'm gratz @ there ofc

what the hell happened to the stats site it looks like someones in the middle of editing it? lol

3Garrett3's Fisherer 0.3 Progress Report
*********************************************
Ran for: 4 Hours, 14 Minutes and 31 Seconds
Fished : 655 Total Fish
Fished : 71 Shrimps
Fished : 33 Anchovies
Fished : 551 Lobsters
Antiban used: 1050
TPA Finder worked: 165 Times
Reflection Finder worked: 0 Times
*********************************************
0: xxx | False | 104 Fish | 3 Loads | 2 Levels | 1500 Experience|
1: xxx | True | 551 Fish | 22 Loads | 6 Levels | 49140 Experience|

The script works excellently when noting fish! I haven't watched much but it doesn't seem to make too many mistakes.

Can't wait to see how much the revamping improves it! :D

The script fails when trying to find the shopkeeper to sell fish, in case you didn't already know that. I don't have time to read through this thread because I have to prepare for my Bio Laboratory class.

From: gratz
Now there are two great fishing bots, yours and harry's :P

I do like how it clicks your friends etc, because I do click that often while I play.. the camera movement is kind of a lot I think, i usually have north up and never move it..
Typing this while I fish actually.. I think the camera movement is over done a lot, makes it seem more bot like imo, more random clicks on your stats etc would be better

Ran for: 1 Hours, 3 Minutes and 22 Seconds
Fished : 202 Total Fish
Fished : 121 Tuna
Fished : 81 Swords
Antiban used: 274
TPA Finder worked: 37 Times
Reflection Finder worked: 0 Times

I have to go to class so I manually stopped.







btw I had stats on the whole time, I'm gratz @ there ofc

what the hell happened to the stats site it looks like someones in the middle of editing it? lol

The site has a history of kinda having an error of some sort like that. I think it's when the server goes down for a second?

@ the antiban,

I think it has an equal chance to call the camera and the tabs. If you wish to see it happen less, you can make the AntiBanzor (or whatever I decided to call it) a higher number. I use 85-90 in mine because the antiban is called a lot. I recommend somewhere around 85 or 90 :)

From: doom0791

3Garrett3's Fisherer 0.3 Progress Report
*********************************************
Ran for: 4 Hours, 14 Minutes and 31 Seconds
Fished : 655 Total Fish
Fished : 71 Shrimps
Fished : 33 Anchovies
Fished : 551 Lobsters
Antiban used: 1050
TPA Finder worked: 165 Times
Reflection Finder worked: 0 Times
*********************************************
0: xxx | False | 104 Fish | 3 Loads | 2 Levels | 1500 Experience|
1: xxx | True | 551 Fish | 22 Loads | 6 Levels | 49140 Experience|

The script works excellently when noting fish! I haven't watched much but it doesn't seem to make too many mistakes.

Can't wait to see how much the revamping improves it! :D

The script fails when trying to find the shopkeeper to sell fish, in case you didn't already know that. I don't have time to read through this thread because I have to prepare for my Bio Laboratory class.

Thanks for the proggy :)

I'm simply revamping the walking which still seems to have minor flaws.

Also, I fixed/added/rewrote the shopkeeper finding and ran it for 30 minutes, it never failed for me. Is it the chooseoption or the actual finding? If it's finding then reflection might be messed for it.. I could make a colour finder I guess, TPA finders aren't too hard.

Making the fish notes at Stiles is a lot better than selling at the general store (store gives like 100gp/lob (I think?), when the GE gives a ton more). :)

Also,

You must have talked to Stiles if you plan on fishing lobster or tuna/swords, otherwise the chat is different and the script wont recognize it.

This is only partially true. If you click Exchange once and you are still InvFull, then just click Exchange again and he will fully transfer your fish the second time you click it.

HTH!

Oh it's on an equal chance to do either? It's definitely doing the camera change like 90% of the time for me lol

Every other refresh I do with the stats site it's all glitched out :thumbsdown:

From: Harry
Making the fish notes at Stiles is a lot better than selling at the general store (store gives like 100gp/lob (I think?), when the GE gives a ton more). :)

Also,
This is only partially true. If you click Exchange once and you are still InvFull, then just click Exchange again and he will fully transfer your fish the second time you click it.

HTH!

I have the script sell the fish to the gen store if it's net or bait. I think I'll make it drop though, it's silly to bother with the selling. It notes lobster, tuna and swords :).

So if I just add in text detection for the first trip, and then have it click exchange again it's a fix? Do you happen to have the text? :)

From: gratz
Oh it's on an equal chance to do either? It's definitely doing the camera change like 90% of the time for me lol

Every other refresh I do with the stats site it's all glitched out :thumbsdown:

Actually I lied, it has a 4/10 chance of rotating, a 2/10 chance to click tabs. Maybe I'll make it more even :).

From: 3Garrett3
So if I just add in text detection for the first trip, and then have it click exchange again it's a fix? Do you happen to have the text? :)

I just have it press Exchange on him (right click menu), and wait a few seconds - if InvFull then it will click exchange on him again. You don't even need to touch the ClickToContinue, you just press Exchange in the right-click menu again.

From: Harry
I just have it press Exchange on him (right click menu), and wait a few seconds - if InvFull then it will click exchange on him again. You don't even need to touch the ClickToContinue, you just press Exchange in the right-click menu again.

Jeez that's a jewel. Thanks :D

From: 3Garrett3
Actually I lied, it has a 4/10 chance of rotating, a 2/10 chance to click tabs. Maybe I'll make it more even :).

A 2/10 or 1/10 on rotating and 4/10 on clicking tabs is probably more human like I think.. Although I'm not every human so I don't know how much people rotate their stuff, maybe add an option?

Thanks

From: gratz
A 2/10 or 1/10 on rotating and 4/10 on clicking tabs is probably more human like I think.. Although I'm not every human so I don't know how much people rotate their stuff, maybe add an option?

Thanks

I used to rotate my camera all the time when I played legit. I think tabs all the time would be kinda silly. I made it exactly even, 1/5 for every option (look at AntiBanz if you wanna know all the options ;))

From: 3Garrett3
I used to rotate my camera all the time when I played legit. I think tabs all the time would be kinda silly. I made it exactly even, 1/5 for every option (look at AntiBanz if you wanna know all the options ;))

Ok thanks, we're very opposite, I never change my camera and click my tabs every 2 seconds, the only reason I stop clicking random stuff is to post around here lol


I think I'm talking to someone who is botting right now lol, we're both telling each other to stop talking because we're going to scare the fish away

From: gratz
Ok thanks, we're very opposite, I never change my camera and click my tabs every 2 seconds, the only reason I stop clicking random stuff is to post around here lol


I think I'm talking to someone who is botting right now lol, we're both telling each other to stop talking because we're going to scare the fish away

So we'll meet in the middle and make it even? :)

And I don't understand how that means they're botting :P

From: 3Garrett3
So we'll meet in the middle and make it even? :)

And I don't understand how that means they're botting :P

Yea the middle sounds great!

I forgot to add that they were talking about people who bot right as I walked up lol…

I've tested (20 minutes) the new walking system as well as a couple additions (less antiban, better debugs, etc).

The major addition is that the walking system is now very *smart* and will only walk the tiles which are absolutely required. The paths are randomized now so it will be much more humanlike, and the walking is very human from the 4 loads I watched.

I also fixed a small bug in the TPA fish spot finding.


So, enjoy. I'll leave V0.3 up in case there is a problem with the new version, as I said it was only tested for a second.

From: 3Garrett3
I've tested (20 minutes) the new walking system as well as a couple additions (less antiban, better debugs, etc).

The major addition is that the walking system is now very *smart* and will only walk the tiles which are absolutely required. The paths are randomized now so it will be much more humanlike, and the walking is very human from the 4 loads I watched.

I also fixed a small bug in the TPA fish spot finding.


So, enjoy. I'll leave V0.3 up in case there is a problem with the new version, as I said it was only tested for a second.

Working great so far!

Ran for: 55 Minutes and 33 Seconds
Fished : 157 Total Fish
Fished : 157 Lobsters
Antiban used: 161
TPA Finder worked: 35 Times
Reflection Finder worked: 0 Times

From: 3Garrett3

Thanks for the proggy :)

I'm simply revamping the walking which still seems to have minor flaws.

Also, I fixed/added/rewrote the shopkeeper finding and ran it for 30 minutes, it never failed for me. Is it the chooseoption or the actual finding? If it's finding then reflection might be messed for it.. I could make a colour finder I guess, TPA finders aren't too hard.

I'm not sure what it is that's messing up. I have not had the time to sit down and watch. Soon as I do (probably tomorrow afternoon) I will, though, and I'll let you know!

Rep + for great script, btw.

From: doom0791
I'm not sure what it is that's messing up. I have not had the time to sit down and watch. Soon as I do (probably tomorrow afternoon) I will, though, and I'll let you know!

Rep + for great script, btw.

Nearing 2 hours and nothing wrong, what was happening with yours exactly? Just stopped when walking?

I think he was using the older (V0.3) version where I hadn't fixed the walking. Hopefully after he tries it tomorrow he'll love it :)

From: 3Garrett3
I think he was using the older (V0.3) version where I hadn't fixed the walking. Hopefully after he tries it tomorrow he'll love it :)

Ah I probably didn't run that one long enough to get what he got..


I'll edit this post with my final prog from this run

Ran for: 3 Hours, 12 Minutes and 26 Seconds
Fished : 491 Total Fish
Fished : 491 Lobsters
Rested: 1 Times
Rested for: 26 Minutes and 11 Seconds
Antiban used: 503
TPA Finder worked: 103 Times
Reflection Finder worked: 0 Times

It (only once) as it was running down to stiles (I think that's his name) ran back up one click then started going down again

nothing big, walking was fine it never failed to get there and back

So the walking may need a tweak or two. What caused that to fail? Or did you manually stop it?

From: 3Garrett3
So the walking may need a tweak or two. What caused that to fail? Or did you manually stop it?

Manually stopped, it was running perfectly.. didn't seem like it was going to fail anytime soon :P



garret this is very important I think:

http://villavu.com/forum/showthread.php?t=61065

Your bot, every time it goes to stiles, moves the camera the same place pretty much

try to make it randomized? Sometimes move the camera down, sometimes move the camera sideways and down, sometimes don't move it at all, extremely human

From: gratz
Manually stopped, it was running perfectly.. didn't seem like it was going to fail anytime soon :P



garret this is very important I think:

http://villavu.com/forum/showthread.php?t=61065

Your bot, every time it goes to stiles, moves the camera the same place pretty much

try to make it randomized? Sometimes move the camera down, sometimes move the camera sideways and down, sometimes don't move it at all, extremely human

It just moves the camera to the lowest possible setting (makes it a lot easier to find him). I can remove that, I wont make it random angles though, it would screw with the detection.

From: grats
Nearing 2 hours and nothing wrong, what was happening with yours exactly? Just stopped when walking?

This was in v0.3.
When net-fishing it would walk to the general store and then fail to sell the shrimp every few loads. Again, I haven't had the time to watch it fail, so I'm not sure exactly what happens. Hopefully I'll have the time today. On this proggy it just set the active player to false when that happened:

3Garrett3's Fisherer 0.3 Progress Report
*********************************************
Ran for: 8 Hours, 49 Minutes and 15 Seconds
Fished : 1180 Total Fish
Fished : 71 Shrimps
Fished : 33 Anchovies
Fished : 1076 Lobsters
Rested: 2 Times
Rested for: 1 Hours, 3 Minutes and 51 Seconds
Antiban used: 1937
TPA Finder worked: 295 Times
Reflection Finder worked: 1 Times
*********************************************
0: xxx| False | 104 Fish | 3 Loads | 2 Levels | 1500 Experience|//NET
1: xxx| True | 1076 Fish | 43 Loads | 10 Levels | 96390 Experience|//CAGE

I'll try the new script this afternoon. Thanks!

From: doom0791
This was in v0.3.
When net-fishing it would walk to the general store and then fail to sell the shrimp every few loads. Again, I haven't had the time to watch it fail, so I'm not sure exactly what happens. Hopefully I'll have the time today. On this proggy it just set the active player to false when that happened:

3Garrett3's Fisherer 0.3 Progress Report
*********************************************
Ran for: 8 Hours, 49 Minutes and 15 Seconds
Fished : 1180 Total Fish
Fished : 71 Shrimps
Fished : 33 Anchovies
Fished : 1076 Lobsters
Rested: 2 Times
Rested for: 1 Hours, 3 Minutes and 51 Seconds
Antiban used: 1937
TPA Finder worked: 295 Times
Reflection Finder worked: 1 Times
*********************************************
0: xxx| False | 104 Fish | 3 Loads | 2 Levels | 1500 Experience|//NET
1: xxx| True | 1076 Fish | 43 Loads | 10 Levels | 96390 Experience|//CAGE

I'll try the new script this afternoon. Thanks!

Thanks for the proggy :). I eliminated the selling from now on, it was a waste of experience/hour to bother selling it :p. So now it just powerfishes.

From: 3Garrett3
Thanks for the proggy :). I eliminated the selling from now on, it was a waste of experience/hour to bother selling it :p. So now it just powerfishes.

Sounds great, I was considering asking for an option to disable selling ;)

Thank you! I'll update and run the new version tonight after I'm done working on my miner, and post a proggy with it :)

From: doom0791
Sounds great, I was considering asking for an option to disable selling ;)

Thank you! I'll update and run the new version tonight after I'm done working on my miner, and post a proggy with it :)

Thanks, I hope you enjoy :).

Always feel free to ask for anything, I'll consider any option brought up to me.

3Garrett3's Fisherer 0.4 Progress Report
*********************************************
Ran for: 8 Hours, 17 Minutes and 19 Seconds
Fished : 1300 Total Fish
Fished : 1300 Lobsters
Antiban used: 1320
TPA Finder worked: 303 Times
Reflection Finder worked: 3 Times
*********************************************
0: | False | 260 Fish | 9 Loads | 1 Levels | 20070 Experience|
1: | True | 208 Fish | 8 Loads | 0 Levels | 17010 Experience|
2: | True | 234 Fish | 9 Loads | 1 Levels | 19890 Experience|
3: | True | 156 Fish | 6 Loads | 1 Levels | 14040 Experience|
4: | True | 182 Fish | 7 Loads | 0 Levels | 14670 Experience|
5: | True | 104 Fish | 4 Loads | -2 Levels | -49795 Experience|
6: | True | 156 Fish | 6 Loads | 0 Levels | 14040 Experience|

I'm so mad! It was running so smoothly, but something happened. here's debug:

[Reflection] Trying to solve: Certer
[Certer] Certer is not talking to us, returning result true
[Certer] Warning: We are not talking to a Certer and we can't find them…
[Certer] Error: Had trouble with certer interaction
[Certer] Certer is not talking to us, returning result true
[Certer] Warning: We are not talking to a Certer and we can't find them…
[Certer] Error: Had trouble with certer interaction
[Certer] Certer is not talking to us, returning result true
[Certer] Warning: We are not talking to a Certer and we can't find them…
[Certer] Error: Had trouble with certer interaction
[Reflection] Certer solved
[Reflection] Out of random
No SRL update / Plugins update available!
[Reflection] Trying to solve: Maze
[Maze] Player Pos: (2891, 4555)
[Maze] Loading green path
[Maze] Trying to walk through door[0]
No SRL update / Plugins update available!
Error: Exception: Out of memory at line 447
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap]
File[C:\Program Files\Simba\Includes\SRL/logs/SRL log 25-01-11 0.txt] has not been freed in the script, freeing it now.

(FYI, where it says NO SRL update / Plugins update available, i cut out like 15 of them.)

^^ So yea no clue what happened.
Account 0: Failed walking back to the dock. Guy was next to the two ponds or whatever they are.
Account 5: No clue why XP and levels were negative.

Other than that, the update was amazing!! Great job! Im thinking it could have gone 4x longer or more!!

Thanks,
King of the Nites

Hey Garrett,

No Proggy yet. Sorry.

Though, I wanted to say that the new updates are AMAZING! I've been running v4 all day, and it's awesome! I've experience literally NO problems walking to/from Stiles, and have had one failure with fishing. The one issue I have had is that the script seems to freeze for me when it comes time to change players. It'll go to the log in screen, type in the username/password, and then freeze. I don't know why that'd be.

Any Ideas?

Anyway, I'll run it more tomorrow and hopefully post a proggy then.

Thanks again! :D

From: Valithor
Hey Garrett,

No Proggy yet. Sorry.

Though, I wanted to say that the new updates are AMAZING! I've been running v4 all day, and it's awesome! I've experience literally NO problems walking to/from Stiles, and have had one failure with fishing. The one issue I have had is that the script seems to freeze for me when it comes time to change players. It'll go to the log in screen, type in the username/password, and then freeze. I don't know why that'd be.

Any Ideas?

Anyway, I'll run it more tomorrow and hopefully post a proggy then.

Thanks again! :D

I don't know what to tell you about changing players, it's all done by SRL.

Net fishing still doesn't seem to want to work. It errors out like this every time at first full inventory:

[01:24:12] StartLev : ** StartXP : ******
[Reflection] Randoms var set!
[01:25:53] FindSpot activating, could not find spot with TPA
[01:26:11] Walking to Stiles
Error: Out Of Range at line 976
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap]

Cage fishing works out great though. Will post a proggy when its done :D

Valithor, try updating SRL/Reflection

From: doom0791
Net fishing still doesn't seem to want to work. It errors out like this every time at first full inventory:

[01:24:12] StartLev : ** StartXP : ******
[Reflection] Randoms var set!
[01:25:53] FindSpot activating, could not find spot with TPA
[01:26:11] Walking to Stiles
Error: Out Of Range at line 976
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap]

Cage fishing works out great though. Will post a proggy when its done :D

Valithor, try updating SRL/Reflection

Well that shouldn't happen. I don't know why it says walking to Stiles? :\. I thought I removed that part entirely. I'll look at it..

Also, @Nites,
That seems to be a reflection random error, from what I can tell..

E: Small tweak should fix it, check V.41

Ran for: 4 Hours, 40 Minutes and 41 Seconds
Fished : 599 Total Fish
Fished : 599 Lobsters
Rested: 2 Times
Rested for: 54 Minutes and 36 Seconds
Antiban used: 687
TPA Finder worked: 142 Times
Reflection Finder worked: 0 Times
*********************************************
0: xxx | True | 599 Fish | 23 Loads | 3 Levels | 53910 Experience|

Got caught in a random, though:

[06:13:12] We were too far from the dock, getting closer
[06:13:19] FindSpot activating, could not find spot with TPA
[06:13:20] GetClosestNPC: Couldnt find any NPCs of the given identification
[06:13:20] Did not find fishing spot in 7 tries
[06:13:20] We were too far from the dock, getting closer
[06:13:23] FindSpot activating, could not find spot with TPA
[06:13:24] GetClosestNPC: Couldnt find any NPCs of the given identification
[06:13:24] Did not find fishing spot in 7 tries
[06:13:24] Fish spot could not be found
[06:13:24] Emergency Logout to recalibrate Fishing spot
Welcome to Runescape.
xxxxxxxxxxxx
WriteFileString: Invalid Internal Handle of File: 1
[06:13:44] We were too far from the dock, getting closer
[06:13:54] We were too far from the dock, getting closer
[06:14:03] FindSpot activating, could not find spot with TPA
[06:14:03] GetClosestNPC: Couldnt find any NPCs of the given identification
[06:14:03] Did not find fishing spot in 7 tries
[06:14:03] We were too far from the dock, getting closer
[06:14:07] FindSpot activating, could not find spot with TPA
[06:14:07] GetClosestNPC: Couldnt find any NPCs of the given identification
[06:14:07] Did not find fishing spot in 7 tries
[06:14:07] Fish spot could not be found
[06:14:07] Fishing Spot not found, player should be on dock however, please report this error.
[06:14:07] Script failed at: FishingMain

It was in a random and gave you that? That means that it wasn't detecting the random…

*********************************************
Ran for: 2 Hours, 55 Minutes and 21 Seconds
Fished : 405 Total Fish
Fished : 405 Lobsters
Rested: 1 Times
Rested for: 36 Minutes and 9 Seconds
Antiban used: 416
TPA Finder worked: 85 Times
Reflection Finder worked: 0 Times

on this line:

Integers[0] := 40; // How many loads to do, plus random 3.

Is that the break time too? it seems whatever I put that to the break time goes along with it

Seems to be a great script, except more often than not it doesn't detect a full inventory. Anywhere a few lines of code could be added to for a fix?

From: XRaye
Seems to be a great script, except more often than not it doesn't detect a full inventory. Anywhere a few lines of code could be added to for a fix?

Well it has two checks already. Perhaps you can put If InvFull then Exit; in a lot of stuff if you want to, but unless SRL's InvFull function is broken, my way would work..

From: grats

*********************************************
Ran for: 2 Hours, 55 Minutes and 21 Seconds
Fished : 405 Total Fish
Fished : 405 Lobsters
Rested: 1 Times
Rested for: 36 Minutes and 9 Seconds
Antiban used: 416
TPA Finder worked: 85 Times
Reflection Finder worked: 0 Times

on this line:

Integers[0] := 40; // How many loads to do, plus random 3.

Is that the break time too? it seems whatever I put that to the break time goes along with it

Those are how many loads to do before switching players, if you're running one player, it has nothing to do with it. :)

Error: Out Of Range at line 53
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap]
File[C:\Simba\Includes\SRL/logs/SRL log 30-01-11 2.txt] has not been freed in the script, freeing it now.


Net fishing

From: wand2658
Error: Out Of Range at line 53
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap]
File[C:\Simba\Includes\SRL/logs/SRL log 30-01-11 2.txt] has not been freed in the script, freeing it now.


Net fishing

You've probably set your players up incorrectly. There are a couple tutorials around the boards that you can find to help you make sure you've done it right.

It keeps saying that i don't have the correct fishing gear. I have it set up to "cage" and i have a lobster pot. Any suggestions?


[10:17:39] StartLev : 60 StartXP : -1
[10:17:40] GearCheck failed, logging out
[10:17:40] GearCheck failed, logging out
[10:17:40] Script failed at: GearCheckSetup

From: zeus0134
It keeps saying that i don't have the correct fishing gear. I have it set up to "cage" and i have a lobster pot. Any suggestions?


[10:17:39] StartLev : 60 StartXP : -1
[10:17:40] GearCheck failed, logging out
[10:17:40] GearCheck failed, logging out
[10:17:40] Script failed at: GearCheckSetup

Could you make sure that you have the proper reflection up to date? I see that it isn't getting your XP either so there could be a couple hooks outdated.

Wouldn't log my player in when I started the script, SMART loads and sits there at the login screen. I have SRL and my reflection up to date so is something just broken and I have to wait for an update on that part??

Log doesn't show anything useful..

SRL Compiled in 16 msec
SMART Initialized.
Loaded: Server 152, Members: False, Signed: False, Super Detail: False.

From: whaevr
Wouldn't log my player in when I started the script, SMART loads and sits there at the login screen. I have SRL and my reflection up to date so is something just broken and I have to wait for an update on that part??

Log doesn't show anything useful..

SRL Compiled in 16 msec
SMART Initialized.
Loaded: Server 152, Members: False, Signed: False, Super Detail: False.

Actually, very useful. You're running unsigned RS so you will have to make sure the graphics options are all set. You can do this by stopping the script when it has loaded SMART and then disabling it, making sure you are on lowest settings (although brightness must be maximum) and making sure the window size is at "Fixed". This will solve any problems you may have.

what if i have notes + harpoon in inventory? and then it fails gearcheck, and exits

i set harpoon in the players setup.

From: 3Garrett3
Could you make sure that you have the proper reflection up to date? I see that it isn't getting your XP either so there could be a couple hooks outdated.

I click update and it says that everything is updated. It the bottom it says i have the latest version of reflection.


Scratch that. It just let me update. :) Hopefully it works. :)
Well, it's not working still. It fetched the exp correctly now though.

[04:22:23] StartLev : 60 StartXP : 279950
[04:22:23] GearCheck failed, logging out
[04:22:23] GearCheck failed, logging out
[04:22:23] Script failed at: GearCheckSetup
Successfully executed.

I'm starting to think it's because of the new runescape update. :) I guess i'll just have to wait and keep fingers crossed until all the bugs are ironed out with the new update. I have faith in your script is good because of all the people endorsing it. I would also like to thank you for helping me instead of calling me a noob or something of that sort. I really enjoy the community here. Keep up the great work.

Just out of curiosity, is anyone else having problems running this script or is it me. (That would help to let me know if it has to do with the update or it's a problem on my end. Thanks.)

@3Garrette3
Ahhh alright thanks for that! It logs me in now but I run into the same problem as zeus now..

[08:48:37] GearCheck failed, logging out
[08:48:37] GearCheck failed, logging out
[08:48:37] Script failed at: GearCheckSetup
Successfully executed.

edit:
Using cage btw

The reflection has updated. I don't know if the extension is actually set to update right or not. I don't understand GIT but that's what reflection is using now. You may not have the most up to date reflection. Read [url'http://villavu.com/forum/showthread.php?t=61990'] this link[/url] if you want to understand better than I do.

Please read the entire thread and you may understand. From my understanding the extension should be working soon, but if the IDs are not detected correctly, then your hooks are obviously not working right which means it isn't updating right.

E:

Specifically at Zeus,
It seems to be a problem with the reflection hooks not returning the same id as the script expects. This is either because RS changed the IDs for all fishing objects (very unlikely) or there is a problem with the autoupdating portion of the reflection extension in Simba. This is more likely since I haven't heard anyone confirm that it works yet.

To get around the problem I just took out the gear checking and it worked just fine for me.

From: 3Garrett3


E:

Specifically at Zeus,
It seems to be a problem with the reflection hooks not returning the same id as the script expects. This is either because RS changed the IDs for all fishing objects (very unlikely) or there is a problem with the autoupdating portion of the reflection extension in Simba. This is more likely since I haven't heard anyone confirm that it works yet.

I had this problem with my Iron Miner yesterday. I updated Reflection again today and it works great again :)

E: Before updating today it was returning -1 for all object ID's so I'm assuming it was outdated hooks.

From: patman16
To get around the problem I just took out the gear checking and it worked just fine for me.

Until it comes to counting fish, it will likely return 0 fish caught. If not, the gear part got broken, even though it uses the same system as the fish counting.

From: doom0791
I had this problem with my Iron Miner yesterday. I updated Reflection again today and it works great again :)

E: Before updating today it was returning -1 for all object ID's so I'm assuming it was outdated hooks.

People are saying that they were updating, but maybe it didn't work for some reason.

script looks v.nice, 1500+ lines of code :O
posting proggy soon :)

I keep getting this error

I'm not sure if this is your fault or if this is Simbas fault, just thought I would post it here.
Also I have noticed that it usually walking to stiles that it crashes :)

It is now running :) Does anyone know how i can enable user input. I like to respond to people when i'm botting. I have looked through all the settings and i can't find it. Any suggestions?

It's supposed to be built in to SMART. I've heard that you have to click rapidly a few times on the client and then try typing, and it usually works. There have been a few people saying that it works less on Windows than Linux, so if you're running windows it may take a couple tries.

i try enable smart, left clicking in chat window, clicking out of the window once, then left clicking again and then typing works. (if you typed before it will usually catch up and type everything too)

Ok thanks guyes that worked. :) I just have to keep clicking until it lets me type. It will sometimes stop letting me type in mid sentence. :)

[Reflection] Randoms var set!
[15:39:24] FishCount
[15:39:24] FishCount : Looking for Sardines
[15:39:24] Found : 0
[15:39:24] FishCount : Looking for Herring
[15:39:24] Found : 0
[15:39:24] FishCount : Looking for Tuna
[15:39:24] Found : 0
[15:39:24] FishCount : Looking for Swords
[15:39:24] Found : 0
[15:39:24] FishCount : Looking for Lobster
[15:39:24] Found : 0
[15:39:24] FishCount : Looking for Shrimp
[15:39:24] Found : 15
[15:39:24] FishCount : Looking for Anchovies
[15:39:24] Found : 9
[15:39:44] InvCountBut: 8
[15:39:44] Afterfishes := False
[15:39:44] Script failed at: AfterFishing
Successfully executed.

It also dropped my net, money, and lobster cage. And it failed out before it finished dropping everything (as far as fish)

It wasn't a random thing that happened either this was the first load it tried so I was there to stop it

You dont have updated IDs, I don't know why it even worked through GearCheck. Reflection isnt counting your gear right, so unless you tampered with the script, this wouldn't have happened..

3Garrett3's Fisherer 0.4 Progress Report
*********************************************
Ran for: 15 Hours, 2 Minutes and 26 Seconds
Fished : 2742 Total Fish
Fished : 2742 Lobsters
Antiban used: 2652
TPA Finder worked: 540 Times
Reflection Finder worked: 1 Times
*********************************************
0: l n | True | 1400 Fish | 56 Loads | 1 Levels | 125010 Experience|
1: oul | True | 1342 Fish | 54 Loads | 4 Levels | 120780 Experience|

great script! thanks

From: skilld u
3Garrett3's Fisherer 0.4 Progress Report
*********************************************
Ran for: 15 Hours, 2 Minutes and 26 Seconds
Fished : 2742 Total Fish
Fished : 2742 Lobsters
Antiban used: 2652
TPA Finder worked: 540 Times
Reflection Finder worked: 1 Times
*********************************************
0: l n | True | 1400 Fish | 56 Loads | 1 Levels | 125010 Experience|
1: oul | True | 1342 Fish | 54 Loads | 4 Levels | 120780 Experience|

great script! thanks

Thanks! Any suggestions?

E: I've just been made aware that the Items don't work if you're using the most recent update from Simba's extension. Due to this, the gearcheck will fail at the beginning. If you don't care about having the fish counted, you may use the following code in place of the GearCheck function:

Function GearCheck(Skill: String): Boolean;
Var
  NetI, RodI, BaitI, CageI, HarpoonI: TInvItem;
Begin
  {Case Lowercase(Skill) Of
    'net':
      Result := R_ItemIDExists(NetI, 303); //Checks for the equipment with a simple reflection check
    'bait':
      Result := R_ItemIDExists(RodI, 307) And R_ItemIDExists(BaitI, 313);
    'cage':
      Result := R_ItemIDExists(CageI, 301);
    'harpoon':
      Result := R_ItemIDExists(HarpoonI, 311);
  End;
  If Not Result Then Debug('GearCheck failed, logging out');}
  Result := True;
End;

From: 3Garrett3
Thanks! Any suggestions?

E: I've just been made aware that the Items don't work if you're using the most recent update from Simba's extension. Due to this, the gearcheck will fail at the beginning. If you don't care about having the fish counted, you may use the following code in place of the GearCheck function:

Function GearCheck(Skill: String): Boolean;
Var
  NetI, RodI, BaitI, CageI, HarpoonI: TInvItem;
Begin
  {Case Lowercase(Skill) Of
    'net':
      Result := R_ItemIDExists(NetI, 303); //Checks for the equipment with a simple reflection check
    'bait':
      Result := R_ItemIDExists(RodI, 307) And R_ItemIDExists(BaitI, 313);
    'cage':
      Result := R_ItemIDExists(CageI, 301);
    'harpoon':
      Result := R_ItemIDExists(HarpoonI, 311);
  End;
  If Not Result Then Debug('GearCheck failed, logging out');}
  Result := True;
End;

Thanks that fixed it for me. :)

From: zeus0134
Thanks that fixed it for me. :)

It wont count fish correctly however, until the hooks are fixed. This should not change the performance, simply the progress report. I'm working on a colour fix (something I should have implemented a while ago, I was just too lazy so I used reflection)

From: 3Garrett3
It wont count fish correctly however, until the hooks are fixed. This should not change the performance, simply the progress report. I'm working on a colour fix (something I should have implemented a while ago, I was just too lazy so I used reflection)

As it seems, the last hook update didn't get moved to github. Lets fix that :D

From: pyroryan
As it seems, the last hook update didn't get moved to github. Lets fix that :D

Thank you! :)

:< i like this script but i always run into a random sometime around when it does a gearcheck after a few runs, but then if it runs into a random during that time it just detects off the dock and logs out instead of going into the solver :Z

trying to get a proggy atm.


p.s. sleeping is pure awesome.

From: fyodor
:< i like this script but i always run into a random sometime around when it does a gearcheck after a few runs, but then if it runs into a random during that time it just detects off the dock and logs out instead of going into the solver :Z

trying to get a proggy atm.


p.s. sleeping is pure awesome.

I've never had that happen but I'll remember to put a random check in the GearCheck function. Thanks!

well the random may not have happened directly AT the gearcheck, but i came back and was in a random, and in the debug box the thing i saw was gearcheck so i assumed :<

From: fyodor
well the random may not have happened directly AT the gearcheck, but i came back and was in a random, and in the debug box the thing i saw was gearcheck so i assumed :<

Yeah it's just safer to put it in the gearcheck at the beginning, that way if it fails the random it wont matter if it fails gearCheck ;)

You can replace GearCheck in your version of the script with this:

Function GearCheck(Skill: String): Boolean;
Var
  NetI, RodI, BaitI, CageI, HarpoonI: TInvItem;
Begin
  DoRandom;
  If Not LoggedIn Then Exit;
  Case Lowercase(Skill) Of
    'net':
      Result := R_ItemIDExists(NetI, 303); //Checks for the equipment with a simple reflection check
    'bait':
      Result := R_ItemIDExists(RodI, 307) And R_ItemIDExists(BaitI, 313);
    'cage':
      Result := R_ItemIDExists(CageI, 301);
    'harpoon':
      Result := R_ItemIDExists(HarpoonI, 311);
  End;
  If Not Result Then Debug('GearCheck failed, logging out');
End;

The new version likely wont be out until after this weekend, it's midterm week.

thanks! testing will be done and hopefully a good proggy will arise

3Garrett3's Fisherer 0.4 Progress Report
*********************************************
Ran for: 3 Hours, 10 Minutes and 51 Seconds
Fished : 416 Total Fish
Fished : 416 Lobsters
Rested: 1 Times
Rested for: 32 Minutes and 29 Seconds
Antiban used: 499
TPA Finder worked: 101 Times
Reflection Finder worked: 0 Times
*********************************************
0: ler | True | 416 Fish | 16 Loads | 2 Levels | 37440 Experience|

SRL_Stats: Incorrect user and/or password
[14:12:53] Walking to Stiles
[14:13:14] Index: 3, Tile: (2873, 3148) did not work, correcting
[14:13:31] Distance to Stiles := 2
[14:13:31] FishCount
[14:13:31] FishCount : Looking for Sardines
[14:13:31] Found : 0
[14:13:31] FishCount : Looking for Herring
[14:13:31] Found : 0
[14:13:31] FishCount : Looking for Tuna
[14:13:31] Found : 0
[14:13:31] FishCount : Looking for Swords
[14:13:31] Found : 0
[14:13:31] FishCount : Looking for Lobster
[14:13:31] Found : 26
[14:13:37] Afterfishes := True
[14:13:37] Walking to Dock
[14:13:43] Index: 3, Tile: (2871, 3148) did not work, correcting
[14:13:53] Index: 5, Tile: (2888, 3159) did not work, correcting
[14:14:04] Index: 7, Tile: (2902, 3169) did not work, correcting
[14:14:08] Distance to Dock := 28
[14:14:09] Script failed at: WalkToDock
Successfully executed.


It was stopped south of the bridge between the fishing dock and stiles. Otherwise it ran pretty smooth.

Well for some reason, it just logs off at dock randomly with a full inventory, and stops the script so I am unable to get an extremely long proggy :<

but due to reflection update script is broken, (and my limited coding knowledge cant figure out which thing changes to which from looking at patch notes :<)

From: DEBUG
[Hint] C:\Simba\Includes\reflection\./Core/Objects.simba(85:3): Variable 'LX' never used at line 84
[Hint] C:\Simba\Includes\reflection\./Core/Objects.simba(85:3): Variable 'LY' never used at line 84
[Error] (1047:23): Unknown identifier 'R_CountItemID' at line 1046
Compiling failed.

When to run your fisher like 5 seconds ago, and recieved this in the DEBUG.

This seems like a reflection bug to me, but it occured during your script, so, I thought I'd run it past you.

From: Valithor
When to run your fisher like 5 seconds ago, and recieved this in the DEBUG.

This seems like a reflection bug to me, but it occured during your script, so, I thought I'd run it past you.

Whatt…

Reflection got rid of Item counting? I'll have to look into it..

Consider the script temporarily broked because I never heard about this change..

R_CountItemId -> R_CountItem

and

R_ItemIDExists -> R_ItemExists // note that the parameters are switched

From: masterBB
R_CountItemId -> R_CountItem
and
R_ItemIDExists -> R_ItemExists // note that the parameters are switched

Those changes seem to work [at least the R_CountItem does], but when I change the R_ItemExists it says I'm missing a variable.

Here's my DEBUG:

[Hint] C:\Simba\Includes\reflection\./Core/Text.simba(400:3): Variable 'JAVASTRING' never used at line 399
[Hint] C:\Simba\Includes\reflection\./Core/Objects.simba(85:3): Variable 'LX' never used at line 84
[Hint] C:\Simba\Includes\reflection\./Core/Objects.simba(85:3): Variable 'LY' never used at line 84
[Error] (1352:29): Variable Expected at line 1351
Compiling failed.

You have to switch the parameters, don't have the script on this pc. But it will be like

R_ItemExists('cage', 311); // nr is guessed..

Net := R_ItemExists(NetI, 303); //Check to see which gear exists 

That's an example from his script. Wouldn't "NetI" be the variable? It's listed as it at the beginning of the procedure. Or does it need the 'quotation-things' around it [like in your example]?

Net := R_ItemExists(303, NetI); //Check to see which gear exists
Rod := R_ItemExists(307, RodI);

^ Downloaded the script, this is the correct code. Need to be changed at multiple lines.

Thanks that seemed to do the trick! :D

I forgot to mention that right after my post I updated the script. Everything should work again now.

From: 3Garrett3
I forgot to mention that right after my post I updated the script. Everything should work again now.

haha. That figures! ^_^ I'll download the newest version . Thanks Garrett!
And thanks to masterBB for helping me through!

E: On another note - Have you considered adding 'urn - support'?

From: Valithor
haha. That figures! ^_^ I'll download the newest version . Thanks Garrett!
And thanks to masterBB for helping me through!

E: On another note - Have you considered adding 'urn - support'?

I don't really know what urn support is, you'll have to explain.

From: 3Garrett3
I don't really know what urn support is, you'll have to explain.

Sorrys! I meant maybe include a function for teleporting urns when they are full. If you are still confused by what I'm talking about go here.
I'm not sure about a decent way you could apply this without detracting from overall fishing, though.

Also, you should try to use R_ChooseOptionSpecial. ;)

From: Valithor
Sorrys! I meant maybe include a function for teleporting urns when they are full. If you are still confused by what I'm talking about go here.
I'm not sure about a decent way you could apply this without detracting from overall fishing, though.

Huh, seems interesting. Is it really useful at all or is it just a silly update?

From: Train
Also, you should try to use R_ChooseOptionSpecial. ;)

It doesn't describe what it does though. It attempts to click an option and isn't foolproof? I love you, Timer, but you're gonna have to sell me on using a reflection chooseoption over what I have ;)

Since there is an over population at the fishing docks, when you right click you sometimes get those sub menus.
R_ChooseOptionSpecial clicks the sub-menu's so it doesn't muck up. Unless you already have something like this. ;)
just.. or the other way below.

if (IsMenuTabbed) then
  R_ChooseOptionSpecial()
else
  WhatEverYouDoWithColor();

Example:

  Move the mouse to guessed spot.
  Do your color check.
  Your color check is false.  If true exit.
  if (MenuContains(FishOption)) then
    R_ChooseOptionSpecial(FishOption);

From: Train
Since there is an over population at the fishing docks, when you right click you sometimes get those sub menus.
R_ChooseOptionSpecial clicks the sub-menu's so it doesn't muck up. Unless you already have something like this. ;)
just.. or the other way below.

if (IsMenuTabbed) then
  R_ChooseOptionSpecial()
else
  WhatEverYouDoWithColor();

Example:

  Move the mouse to guessed spot.
  Do your color check.
  Your color check is false.  If true exit.
  if (MenuContains(FishOption)) then
    R_ChooseOptionSpecial(FishOption);

Does it only choose the secondary option? It would be easier to just have it in one function with two options.

I do have a custom function in colour, it uses bitmaps to detect the words and works pretty well. The actual mess up comes from moving the mouse wildly actually, which I don't think your function would help. I'll add it to my personal version and see if I notice a difference though ;)

From: 3Garrett3
Does it only choose the secondary option? It would be easier to just have it in one function with two options.

I do have a custom function in colour, it uses bitmaps to detect the words and works pretty well. The actual mess up comes from moving the mouse wildly actually, which I don't think your function would help. I'll add it to my personal version and see if I notice a difference though ;)

When it mouses over players and has 30+ options, it has submenus, so instead of freaking out, can't find it, it will use the submenus.
EDIT: add my msn
[email]Timer150@Gmail.com[/email]

Well nobody has posted anything here in a while but im still using this script :< cause it lets me keep the rewards I get (fishing mining! ie like 500 coal +100 mith while fishing haha)

I dont really have a proggy but….

salaf has added 33367 minutes to KARAMJA Fisher in 4860 commits .

More specifically, this is how many variables he committed:
Loads Done ( 4207 )
Swordfish Caught ( 43882 )
Total EXP Gained ( 9532020 )
Total Levels Gained ( 40 )
Tuna Caught ( 49149 )


P.S. promises of a proggy soon ensues.

From: fyodor
Well nobody has posted anything here in a while but im still using this script :< cause it lets me keep the rewards I get (fishing mining! ie like 500 coal +100 mith while fishing haha)

I dont really have a proggy but….

salaf has added 33367 minutes to KARAMJA Fisher in 4860 commits .

More specifically, this is how many variables he committed:
Loads Done ( 4207 )
Swordfish Caught ( 43882 )
Total EXP Gained ( 9532020 )
Total Levels Gained ( 40 )
Tuna Caught ( 49149 )


P.S. promises of a proggy soon ensues.

I was wondering if anyone was still using this, glad to see it's still working for you! :)

one thing i noticed is that when it tries to log in and lets say another client is running on that world, it just sticks on the main screen and doesnt try to switch worlds.

Also, when it cant find the dock, it doesnt search for randoms and just logs out so no chance to solve it :<

other than that
3Garrett3's Fisherer 0.4 Progress Report
*********************************************
Ran for: 5 Hours, 58 Minutes and 39 Seconds
Fished : 1087 Total Fish
Fished : 566 Tuna
Fished : 521 Swords
Rested: 11 Times
Rested for: 1 Hours, 26 Minutes and 44 Seconds
*********************************************
0: *** | True | 1087 Fish | 44 Loads | 0 Levels | 97380 Experience|

From: fyodor
one thing i noticed is that when it tries to log in and lets say another client is running on that world, it just sticks on the main screen and doesnt try to switch worlds.

Also, when it cant find the dock, it doesnt search for randoms and just logs out so no chance to solve it :<

other than that
3Garrett3's Fisherer 0.4 Progress Report
*********************************************
Ran for: 5 Hours, 58 Minutes and 39 Seconds
Fished : 1087 Total Fish
Fished : 566 Tuna
Fished : 521 Swords
Rested: 11 Times
Rested for: 1 Hours, 26 Minutes and 44 Seconds
*********************************************
0: *** | True | 1087 Fish | 44 Loads | 0 Levels | 97380 Experience|

The first thing shouldn't be a problem with the script, as logging in is handled by SRL. I've fixed the small problem with not searching for randoms when it can't find the dock. Check .43

kk will check it out and post proggy!

EDIT:

*********************************************
Ran for: 2 Hours, 27 Minutes and 37 Seconds
Fished : 456 Total Fish
Fished : 251 Tuna
Fished : 205 Swords
Rested: 5 Times
Rested for: 29 Minutes and 30 Seconds
Antiban used: 302
TPA Finder worked: 62 Times
Reflection Finder worked: 0 Times
*********************************************
0: *** | True | 456 Fish | 19 Loads | 1 Levels | 39180 Experience|

Successfully executed.

the script just randomly stopped, full inventory at the dock. Then after idle just went to login screen.

i think what happened is it would go "Gearcheck Failed.. logging out" then it would just stop the script, but still be fishing, then after the load is full log out due to idle and thats why it would constantly go to the worldcheck/play screen. There really was no problem though.

[PHP]3Garrett3's Fisherer 0.4 Progress Report
*********************************************
Ran for: 14 Hours, 42 Minutes and 4 Seconds
Fished : 2816 Total Fish
Fished : 1442 Tuna
Fished : 1374 Swords
Rested: 30 Times
Rested for: 2 Hours, 37 Minutes and 48 Seconds
Antiban used: 1973
TPA Finder worked: 401 Times
Reflection Finder worked: 6 Times
*********************************************
0: *** | True | 2816 Fish | 128 Loads | 1 Levels | 251080 Experience|
[/PHP]

other account is still running, will manually stop in a few hours and edit with proggy, i'm going to be taking a 2-3 week break from autoing :< hopefully this script is still bangin when i return!

From: fyodor
[PHP]3Garrett3's Fisherer 0.4 Progress Report
*********************************************
Ran for: 14 Hours, 42 Minutes and 4 Seconds
Fished : 2816 Total Fish
Fished : 1442 Tuna
Fished : 1374 Swords
Rested: 30 Times
Rested for: 2 Hours, 37 Minutes and 48 Seconds
Antiban used: 1973
TPA Finder worked: 401 Times
Reflection Finder worked: 6 Times
*********************************************
0: *** | True | 2816 Fish | 128 Loads | 1 Levels | 251080 Experience|
[/PHP]

:o thanks :D:D

I'm sure it will be around, it will just be up to you to test it out and tell me if it's working, nobody uses it anymore..
other account is still running, will manually stop in a few hours and edit with proggy, i'm going to be taking a 2-3 week break from autoing :< hopefully this script is still bangin when i return!

3Garrett3's Fisherer 0.4 Progress Report
*********************************************
Ran for: 3 Hours, 8 Minutes and 19 Seconds
Fished : 521 Total Fish
Fished : 521 Lobsters
Rested: 1 Times
Rested for: 35 Minutes and 52 Seconds
Antiban used: 407
TPA Finder worked: 94 Times
Reflection Finder worked: 0 Times
*********************************************
0: *** | True | 521 Fish | 20 Loads | 0 Levels | 45450 Experience|

Best fishing script i've ever used, but as of the update today it stopped working. It has trouble going to Stiles and it randomly logs out now while fishing. Thanks for the great work I look forward to the update.

Kinky Ass Raped And Makes Jizz Appear

looks good

[Error] (127:7): Unknown identifier 'theFile' at line 126
Compiling failed.

keep getting this error D: