SRL Archive - OSR Outdated / Broken Scripts

Hello all, this is my first script for old school.:rolleyes:

NOTE: Script uses SMART v8, Simba Rev 992, and the SLR-OSR include. Be sure to have each of these installed and up-to-date.
Search forums for tutorials/guides/etc, if you need help installing or updating these…

0.4
-major update!! intended for use with OSR include:
--Implemented stock checking
-->>stops buying stock after max_Buy has been reached. (see code)
--Implemented random world switching and logging in/out
--Will purchase total_BUY amount of items. (total_Buy = 15000 to buy 15000 items..)
--Should be bug free, but report any errors!!

0.4.5
-- optimized buying routine in port sam for feathers
-- fixed problem with buying too many items at custom shops
-- (note: be sure to fill out custom shop params and to also change shop variable..)

0.5
-- added antirandom support and more antiban
-- because of this it sometimes will bug out if it fails to solve a random
-- failsafes implemented: if it can't find owner, fails to solve random, or otherwise can't buy items will logout and stay logged.
-- cleaned up code and comments


current bugs: None
(Report any that are found...!)

A few things regarding the script:

1) This code searches for the owner and item using color finding methods:
. 1a) this means you may have to use the color select tool to define ownercolor1,..,itemcolor2. (be very picky about the colors of the item you want, if the color is not unique there may . be unwanted results :P)
. 1b) To use the Color Select Tool, refer to the Beginner's guide of the Tutorial forums.
. 2) it will then use a static method once the color has been found to buy items

2) ensure that character is inside of shop
. 1a) Start the script while logged out, and let it do the rest!

3) allows for custom shop creation: see script comments on how to do this
. 3a) custom buying routine/speed (how many to buy/how fast to purchase items)
. 3b) custom items: user-defined item location, within shop/trade window

:spot:



Feel free to report any other errors/bugs/solutions/ideas for expansion.

happy scripting e'rbody! :stirthepot:

MM
:cool:

gonna try it now, will watch it for review..

@edit.. it starts new rs.. but i had rs07 tutorial fixed before? how come it loads rs eoc?

From: geilecharlie
gonna try it now, will watch it for review..

@edit.. it starts new rs.. but i had rs07 tutorial fixed before? how come it loads rs eoc?

you need to edit smartparams as your simba probably updated.

could you please tell me how or what :$ im new to this all but im willing to learn fast and much :D

let it be like that

Filled out info, doesn't even login. Logged in manually, spins camera around.
Filled out colors and shop info correct, does nothing.

does this work? i need too get 100k bronze arrows >.< this would be the best thing in the world :)

From: bodenz
does this work? i need too get 100k bronze arrows >.< this would be the best thing in the world :)

Tried it for bronze arrows, keeps attempting to buy rune arrows :(
Also doesn't notice when the shop is out of stock :/

From: xstrunitx
Tried it for bronze arrows, keeps attempting to buy rune arrows :(
Also doesn't notice when the shop is out of stock :/

I'm slowly working on implementing a stock-checker procedure so the later won't happen.

I was having a similar problem when buying feathers. Occasionally trout would be bought. This was caused because the itemcolor weren't unique. So make sure that the itemcolor1 and itemcolor2 are unique (there can be no other case of the same itemcolor in the shop-menu, or else it may click there..) for the desired item.

Trying to get him to do Bronze Arrows in Lowes store..
He just keeps buying Shortbows?
I've picked my colours so many times, and the nicks set up properly, not sure whats going wrong :\

From: poopa
Trying to get him to do Bronze Arrows in Lowes store..
He just keeps buying Shortbows?
I've picked my colours so many times, and the nicks set up properly, not sure whats going wrong :\

I found the problem that was causing this. I'll upload a fix shortly.

EDIT: Uploaded fix.

Awesome Script i love it!!! just two things i wonder.. If its possible!:

1)How do can we easily obtain Mouse Coordinates inside the smart client window? (I just type something like MouseBox(280, 80, 280,80, mouse_right);, find where that lands me then count the pixels from where the mouse needs to be!).

2)Am horrible at math, how can i edit the value of say: i want to make it right click and buy 5-10 times then hop, not 10-30), what field should i edit?, what line?.

Also is there a way to add something like 'the shop has run out of stock' identifier for hoping? would be really awesome if Simba could do that.

Thanks again for the script man!!!

How do can we easily obtain Mouse Coordinates inside the smart client window? (I just type something like MouseBox(280, 80, 280,80, mouse_right);, find where that lands me then count the pixels from where the mouse needs to be!).

(have updated to the most recent version and loaded Simba and the SMARTv8.0 client)

Along the bottom of the Simba client is an action bar. Somewhere on the bar has the (x,y) position of where the mouse is currently on the screen. But we want to know where mouse is relative to the SMART client. To do this:

Use Simba's "Select a client" tool, found along the top action bar. Select the SMART window as the client (a large red box will highlight the SMART window).

Now refer to the area you found on the Simba window for (x,y).

I'm horrible at math, how can i edit the value of say: i want to make it right click and buy 5-10 times then hop, not 10-30), what field should i edit?, what line?.

To buy 5-10 items, edit line 215 and 216 which looks like:

randAmnt := randomrange(180,300);           //change range to buy more or less 

–change to:

randAmnt := randomrange(50, 100);

Give me like a week to implement the last part… xD

From: meanderingmonk
(have updated to the most recent version and loaded Simba and the SMARTv8.0 client)

Along the bottom of the Simba client is an action bar. Somewhere on the bar has the (x,y) position of where the mouse is currently on the screen. But we want to know where mouse is relative to the SMART client. To do this:

Use Simba's "Select a client" tool, found along the top action bar. Select the SMART window as the client (a large red box will highlight the SMART window).

Now refer to the area you found on the Simba window for (x,y).



To buy 5-10 items, edit line 215 and 216 which looks like:

randAmnt := randomrange(180,300);           //change range to buy more or less 

–change to:

randAmnt := randomrange(50, 100);

Give me like a week to implement the last part… xD

So brilliant i enjoyed reading this post so much, you have no idea how much this helped me (SPECIALLY with the smart mouse position! gosh i wasted so much time trying to get the correct coordinates!!) so lovely sir thank you thank thank you god bless you!

How could you configure it to use coordinates instead of colors? It's trying to buy other things aswell no matter what colors I put because my item is like that.. there is many items same color in the shop

This is working great!

Works amazing, how would I go about it only making it go through like 10 worlds, that I can set? I really need this.

kingo.. how did you set yours up?? i cant even buy my stuff =d

Gratz on release, I would advise static coords and checking if the interface is open and of course off settings clicks

From: mtdewi
How could you configure it to use coordinates instead of colors? It's trying to buy other things aswell no matter what colors I put because my item is like that.. there is many items same color in the shop

I will show you with an example. To fix the mouse to coordinates to position (125, 125):

update the following line of code (line 103) from

MouseBox(xx, yy, xx+6,yy+6, mouse_right); 

to:

MouseBox(125,125,125+6,125+6, mouse_right); 

or for position (350,125):

MouseBox(350,125,350+6,125+6, mouse_right); 

If you want the code to be a little more random, trying changing 350+6 to 350+randomrange(1,7)..

Works amazing, how would I go about it only making it go through like 10 worlds, that I can set? I really need this.

For right now, I haven't implemented a way to selectively choose the worlds to visit. To limit the number of times to cycle through world switching/logging back in/buying items/etc, change GLOBAL_VISITS = 30 to GLOBAL_VISITS=10.

Gratz on release, I would advise static coords and checking if the interface is open and of course off settings clicks

What do you mean by checking if interface is open? Similar to checking if player is LoggedIn? I'll look at the srl library later tonight.
Is there a way to offset clicks if using the mousebox(..) procedure?
I've used mousebox for the majority of clicking and didn't see an offset modifier similar to the one in MMouse(..). How would I add an offset considering this?

Thanks and hope this helps! Enjoy!!

Great script, runs smoothly! I was wondering if you could explain thoroughly each of the world switching constants, just for my understanding. Also, the script occasionally jumps worlds(instead of moving to the next world). Also, after buying from the last world in a column, it does not return to the top world, and just stops working. If you have any advice on how to fix this that would be awesome.

From: dannynandez
Great script, runs smoothly! I was wondering if you could explain thoroughly each of the world switching constants, just for my understanding. Also, the script occasionally jumps worlds(instead of moving to the next world). Also, after buying from the last world in a column, it does not return to the top world, and just stops working. If you have any advice on how to fix this that would be awesome.

nvm i figured it all out. Thank you for writing this!

From: dannynandez
nvm i figured it all out. Thank you for writing this!

Certainly!

Be sure to check out the newest revision. I made use of the WorldSwitching procedures that are apart of the new OSR include. It makes the code much easier to understand!

hey.. how do you buy just bronze arrow?? it keep clicking different arrow because they all look the same?/ is there a coordinate i can enter?

i try the mouse coordinate post you put up there. still doesnt work =(

Edit: i went to different place and it works cause there no arrow but how do you world hop? it doesnt detect that the store has ran out.. how do you change it? thanks

Just made my own script to do this and came on here to find you've also made one! :p I'm surprised you released something like this though: the more people that have it the less effective it becomes! Script looks good though, but a little more complicated than mine.

works great!

great script! really good job you did there!!
maybe some features for in the future or if some scripters know how to add these (as i tried and failed miserably):
- i was wondering if you could make it try 'Owner1' and if it fails to trade with that one, it tries with 'Owner2'.
- Option to make it open the closest door if it fails to get to the trader?
- if it fails to trade the trader for few times, loggs off and try another world.

Edit: Fixed it myself. Thank you!

is there a way it can detect shop is out of stock? or buy like 100 items max in a world? I looked earlier on the thread and can't seem to find the randamt variable in the newest version.

edit: I see v4 suppose to check if item is out of stock. but it stills keeps buying. trying to buy bone bolts.

From: bins69
is there a way it can detect shop is out of stock? or buy like 100 items max in a world? I looked earlier on the thread and can't seem to find the randamt variable in the newest version.

edit: I see v4 suppose to check if item is out of stock. but it stills keeps buying. trying to buy bone bolts.

I've released a hot-fix for this problem, try downloading the newest revision.

[Error] C:\Users\user\Downloads\MM_ItemBuyer_V0.4.5.simba(46:24): 'BEGIN' expected at line 45
Compiling failed.

its highlighting the bool_world line but i didnt do anything to it like it says leave it alone

From: kid cudi
[Error] C:\Users\user\Downloads\MM_ItemBuyer_V0.4.5.simba(46:24): 'BEGIN' expected at line 45
Compiling failed.

its highlighting the bool_world line but i didnt do anything to it like it says leave it alone

Sorry, this was a typo. Add another '/' in front to make it like (or re-download the file):

bool_World = true; //leave alone 

Is there a way to make it buy more than one item without changing the item colors all the time?

From: kMR
Is there a way to make it buy more than one item without changing the item colors all the time?

in procedure buyItems, try using static coords instead of using the passed in x,y variables.

so edit code where it reads something like:

MouseBox(x1,y1,x1+c,y1+c,mouse_right);

to the following:

MouseBox(0,0,100,100,Mouse_Right);

Change (0,0,100,100…) to fit the area where your item is located.
(TIL:Mouse box creates a box from (x1,y1)to (x2,y2)..top left to bottom right)luls

Where is the download for 0.4.5? I only see up to v4 in the list.

Would like to see a check done to see if all items are bought or empty already when attempting to buy, I disslike watching it for 5mins trying to buy something that's empty stock instead of switching worlds, but thank you.

cant get it to buy bronze arrows. it checks the price of them sees they are less than my max buy amount and logs out

Has anyone edited this script for the archer store in Catherby? If so could you please send it? Thanks!

It keeps logging out then back into the same world can someone tell me what im doing wrong please?

how i can buy just like 50-100 feathers and then whop?

Hey man,

I get it to compile and click and world hop alltogether however when i want it to buy bronze bolts, it just scrolls over it… then logs.. I'm not sure why.

Thanks ahead of time!

Anyone know a unique colour code for Bronze Arrows? Whenever I pick one or two colours, the bot buys regular Bows instead. :(

I'm having a similar problem as the above poster. The script does not click on what I am buying and scrolls over it and proceeds to world hop.

Nice script man!, thanks for the command on line 253, helped me with a lot of things.

keep up the good work!

Also thanks for helping me :D

From: freddyadu02
Hey man,

I get it to compile and click and world hop alltogether however when i want it to buy bronze bolts, it just scrolls over it… then logs.. I'm not sure why.

Thanks ahead of time!

This is occurring because of Declare Shop procedure. Refer to lines 121-128.

case itemName of
   'eather' : begin
              itemName_1:=itemName; itemName_2:='eathe r'; itemName_3:='Feather';
              end;
   'rrow' :   begin
              itemName_1 := itemName; itemName_2:='arrow'; itemName_3 :='rro w';
              end;
   end;  

To make it buy bolts, add the following below line 127:

   'olts' :  BEGIN
              itemName_1 := itemName; itemName_2:='olt s'; itemName_3 :='Bolt';
              END;  

This should fix the problem. :staycool:

From: itsblown
cant get it to buy bronze arrows. it checks the price of them sees they are less than my max buy amount and logs out

Have you setup a custom shop? If so, be sure to update the GLOBAL variable Shop accordingly (top of script). If the custom shop is #2 , be sure to make your own buying routine in the BuyItems procedure. (copy/paste from shop #0 or #1 for reference. u := randomrange(x,y) – x,y are the bounds of how many items you wish to purchase. (4,5) for 4-to-5 items..)

is there a way to make it buy 2 items? trying to buy air runes and earth.. at the same time

When trying to buy on 2 accounts, they sometimes try to log in a world that you already are in on another account, this makes the other account get stuck in login screen (just keeps changing worlds but doesnt enter it)

And can you make it not hop to a world you are playing in? By like adding something in the (randomworld) part? :P

I'm trying to buy one item ("Item A") that has the same colors as another item ("Item B") in the same shop. I tried limiting the script to only buy Item A by using the MouseBox function (coordinates surround only Item A; Item B is outside of these coords). However, it is still not working… The script ignores the box outlined by the MouseBox function, and just hovers over Item B then closes the store and world hops. What should I do?

From: meanderingmonk
This is occurring because of Declare Shop procedure. Refer to lines 121-128.

case itemName of
   'eather' : begin
              itemName_1:=itemName; itemName_2:='eathe r'; itemName_3:='Feather';
              end;
   'rrow' :   begin
              itemName_1 := itemName; itemName_2:='arrow'; itemName_3 :='rro w';
              end;
   end;  

To make it buy bolts, add the following below line 127:

   'olts' :  BEGIN
              itemName_1 := itemName; itemName_2:='olt s'; itemName_3 :='Bolt';
              END;  

This should fix the problem. :staycool:

I too have a similar problem when I'm trying to buy body runes from runeshops. It logs into the world, trades the owner, hovers over body rune and right clicks, then clicks x and hops to next world without even reading the price for the runes.


I also want to try to get it to work in tzhaar buying gems from store, but I have a feeling that will be harder.

nice script man, current suggestion is to have it buy more then one item before "closing up shop" thanks

those having troubles with buying arrows and what not, you need to pick a better color! otherwise if you know some coding you can just make a bitmap :)

oh, and do you get randoms when inside any stores or when the store window is open? just curious

From: ibot_dung11
nice script man, current suggestion is to have it buy more then one item before "closing up shop" thanks

those having troubles with buying arrows and what not, you need to pick a better color! otherwise if you know some coding you can just make a bitmap :)

oh, and do you get randoms when inside any stores or when the store window is open? just curious

You get randoms after leaving the store window I assume.

I have died three times in total using this script overnight, lost about 10M but I've made it back with it easily, so I'm happy :) I wonder what managed to kill me all those times since I've been wearing a ring of life too :P Just saying, don't bring all your bank with you when buying!

Great script btw, I have used this for weeks! After the F2P update it's not working properly though, unless you are buying in f2p areas.

From: kMR
You get randoms after leaving the store window I assume.

I have died three times in total using this script overnight, lost about 10M but I've made it back with it easily, so I'm happy :) I wonder what managed to kill me all those times since I've been wearing a ring of life too :P Just saying, don't bring all your bank with you when buying!

Great script btw, I have used this for weeks! After the F2P update it's not working properly though, unless you are buying in f2p areas.

duh heck you buying you can afford to lose 10m :P lol

The script is very good but just few problems, firstly if the shop has lets say 3000 of the items it buys small portions at a time like 210 then logs out and then logs back in to teh same exact world and buys the rest, second problem is it choose non member worlds as well, so it gets stuck…

From: ibot_dung11
nice script man, current suggestion is to have it buy more then one item before "closing up shop" thanks

those having troubles with buying arrows and what not, you need to pick a better color! otherwise if you know some coding you can just make a bitmap :)

oh, and do you get randoms when inside any stores or when the store window is open? just curious

i'm still trying to figure out a method to use DTMs to purchase items and then verify with uptext check. But this will have to wait as RL duties persist. Gah.

From: kMR
You get randoms after leaving the store window I assume.

I have died three times in total using this script overnight, lost about 10M but I've made it back with it easily, so I'm happy :) I wonder what managed to kill me all those times since I've been wearing a ring of life too :P Just saying, don't bring all your bank with you when buying!

Great script btw, I have used this for weeks! After the F2P update it's not working properly though, unless you are buying in f2p areas.

I've fixed most of these problems with the antirandoms that srl has implemented. using a ring of life should get everything fixed even in the case that randoms aren't solved correctly (sometimes forester random makes it click repeatedly trying to find center. this is error in srl code, not mine. sorry :s).

From: ibot_dung11
duh heck you buying you can afford to lose 10m :P lol

feathers sell fairly well ;) and then there's arrows… gems.. silk.. etc.

From: guiltyinstncts
The script is very good but just few problems, firstly if the shop has lets say 3000 of the items it buys small portions at a time like 210 then logs out and then logs back in to teh same exact world and buys the rest, second problem is it choose non member worlds as well, so it gets stuck…

i've updated the buyitem procedure for custom shops to allow for user-defined amount of items to buy per buying routine. see code.


let me know if you're still having any problems still! thanks, MM

From: ToinCoss
I'm trying to buy one item ("Item A") that has the same colors as another item ("Item B") in the same shop. I tried limiting the script to only buy Item A by using the MouseBox function (coordinates surround only Item A; Item B is outside of these coords). However, it is still not working… The script ignores the box outlined by the MouseBox function, and just hovers over Item B then closes the store and world hops. What should I do?

I have a similar problem. I'm trying to buy death runes which have the same colors as other runes in the shop. The difference is that it does not hover over any runes, death, air, whatever, but just keeps moving the mouse around indefinitely. I also limited the box to click within the circle of the death rune, besides that I have not altered the script besides basic params.

I have been trying to get your updated script to work for over 4 hours yesterday and don't know what i'm doing wrong I set it up like I use to in the past. Custom shop to buy bronze arrows but it hovers over the arrows then starts to hop like it randomly jumps the mouse all offer the place but never buys… Could you tell me what im doing wrong?

Would love some support I used your first scrip that you made like 2 months ago and it worked fine for days now I cant get your most recent update to work. Anyone care to help ill pay via paypal.

i also can't get your script to work properly, hovers item i want to buy then bounces all over the buy window occasionally returning then repeats.

editing the script to work with what i want.

i would recomend using relavent variable names that describe what there used for, not 'hello love', if ur going to make a public script

edit: would also recomend putting all the user input at the top and not all over the script, otherwise create a form

Would really like to make this script work with Water vials in ardougne - Isnt there a guide on how to "program / code " this script to do it?
Felt erally advanced and i couldnt understand much

does anyone know how to make it buy runes faster, the mouse moves all over the place and takes like 10 or 15 seconds before it checks price and buys more, im trying to buy nature runes btw

I cant let it bank eh?

I've tried to set this up for a custom shop (to buy some runes) but the instructions in the comments and first post don't really make it too clear. Might even be easier to just copy some of your procedures and make my own script, seeing as it's sometimes easier to start from scratch than it is to edit somebody else work.

Seems that I can't get any working color for body runes, it keeps buying all others except for the body runes..

Hello! I wnat to buy Body Runes with this script in Port Sarim magic shop / Pest Control Island magic shop.

How do I get it worked? I don't seem to understand the script :/

Please help me out! Thanks alot!

custom shop wont work!! :( im trying to get it to buy uncut sapphires using tokkul but it wont even right click the item to buy it, it just moves the mouse all over the place.

I probably could make it bank, so you can buy non-stackable items. But I need help with that since I've got exams too. :")

I've gotten it to bank ardounge vials since its the easiest path in the world to create. but nothing else works since walking is buggy

Works :)

Hope you get bank support soon!

Im really new to this, i was wondering if somebody could make it compatable with nardok, the goblin behind lumbridge that sells bone bolts. That would be awesoommme

[Error] C:\Simba\Scripts\karabmwan buyer.simba(32:13): Syntax error at line 31 the error code.
max_Avg = ; // 3 for 347gp max the code

is a good script but i have a small problem with it add my skype name is:king52588

I can't get it to work with arrows, I think I editted all the things correctly (fixed mouse position) but it just goes on checking colours. Can you help me set it up :\?

looks good

From: meanderingmonk
Help?

Well it logs in, finds the custom shop, then goes over the item I want to buy and doesn't right click it but instead just moves the mouse around the shop. I'm trying to buy cooked bass "Bass"
Here's my code:

1:       //custom
      begin
        ownerName := 'idio';
        itemName := 'ass';
        ownerColor_1 := 5390657;
        itemColor_1 := 1410482;
        ownerColor_2 := 14407387;
        itemColor_2 := 603720;
        max_Buy := max_Avg;
      end;      

  'ass' :
     begin
        itemName_1 := itemName;
        itemName_2 := 'ass';
        itemName_3 := 'Bass';
     end;  

Of course I put in my Declare and filled out Const but I didn't create a DTM for the Bass (I noticed you had one for the Feathers)
Any help please?

[Hint] C:\Users\…\Desktop\MM_Itembuyer_v0.5.simba(345:3): Variable 'PRICE_V' never used at line 344
[Error] C:\Users\…\Desktop\MM_Itembuyer_v0.5.simba(571:3): Unknown identifier 'SMART_FIXSPEED' at line 571
Compiling failed.

what is the problem?