SRL Archive - Test corner

SSInclude [Need constructive AND harsh feedback]

rj

2013-03-21 20:13:15

Ok, so I have decided to upload the Soulsplit include to the members section first for 2 reasons:

1) To get harsh feedback on what needs to be done to make it look better/anything that stands out that just looks horrid
2) To avoid people attempting to use it to bot and spamming the thread with non working functions


This include is 90% modified @DannyRS's P07 include, I have removed about 65% of it because I do not want to just copy and paste his Include and edit it to my own, I would to make my own functions. PLEASE feel free to post harsh feedback AS LONG AS it is constructive

List of things not working:

-Option text
-Find flag
-Auto login
-Make compass(Direction:String)(or degree)
-Find staff


List of things partially/not sure working:

-Radial Walk (need to edit FFlag)
-SPS walking (need to edit FFlag and other stuff)
-Smoking rock random (Inaccurate) @Le Jingle's I have to midify it a little bit, its hard to get the smoke colors
-Uptext
-MMToMS

List of things 100% working:

-Thieving random
-ModExists


List of things to be added:

-SS_ToTab(Tab:Integer)
-SS_DropAll
-SS_ItemExists
-SS_InventoryFull
-SS_PM(Friend,Message:String) // for the lol
-SS_Logout
-SS_CloseBank


Test script:

{$i srl/srl.simba}
{$i SSInclude/SSInclude.simba}
{$i SSInclude/Randoms.simba}
{$i SSInclude/MapWalk.simba}
Begin
  SetupSSInclude;
 // P07_MakeCompass('South');
  WriteLn(SS_GetUpText);
End.

Uptext is hella inaccurate ATM



If you want to actually test it instead of looking through it at nubby errors Then put SSInclude in Simba/Includes and SSUpChars in Simba/Fonts

Justin

2013-03-21 22:51:34

      'North':
        Begin
        CurAngle:=P07_GetCompassAngle;
        If CurAngle > 180 Then
        P07_MakeCompassDegree(355)
        Else
        P07_MakeCompassDegree(5);
      End;
      'East':
      Begin
        P07_MakeCompassDegree(270);
      End;
      'West':
      Begin
        P07_MakeCompassDegree(90);
      End;
      'South':
      Begin    case LowerCase(Direction) of
      'North':
        Begin
        CurAngle:=P07_GetCompassAngle;
        If CurAngle > 180 Then
        P07_MakeCompassDegree(355)
        Else
        P07_MakeCompassDegree(5);
      End;
      'East':
      Begin
        P07_MakeCompassDegree(270);
      End;
      'West':
      Begin
        P07_MakeCompassDegree(90);
      End;
      'South':
      Begin
        P07_MakeCompassDegree(180);
      End;

You use lowercase(direction) but then have your strings starting with a capital?

rj

2013-03-22 05:30:12

From: Justin
      'North':
        Begin
        CurAngle:=P07_GetCompassAngle;
        If CurAngle > 180 Then
        P07_MakeCompassDegree(355)
        Else
        P07_MakeCompassDegree(5);
      End;
      'East':
      Begin
        P07_MakeCompassDegree(270);
      End;
      'West':
      Begin
        P07_MakeCompassDegree(90);
      End;
      'South':
      Begin    case LowerCase(Direction) of
      'North':
        Begin
        CurAngle:=P07_GetCompassAngle;
        If CurAngle > 180 Then
        P07_MakeCompassDegree(355)
        Else
        P07_MakeCompassDegree(5);
      End;
      'East':
      Begin
        P07_MakeCompassDegree(270);
      End;
      'West':
      Begin
        P07_MakeCompassDegree(90);
      End;
      'South':
      Begin
        P07_MakeCompassDegree(180);
      End;

You use lowercase(direction) but then have your strings starting with a capital?


Woops ty

The Killer

2013-03-22 13:14:44

Ok, Some harsh feedback: THIS IS USELESS ;)
Will have a good look later :)

Wetish

2013-03-22 14:38:19

Is soulsplit actually popular?

rj

2013-03-22 15:36:01

From: Wetish
Is soulsplit actually popular?


Yea, they usually have 3000-4000 online at a time… and their own office.. pretty dumb that they have their own office but yea they are popular

Olly

2013-03-22 15:44:00

From: RJJ95
Yea, they usually have 3000-4000 online at a time… and their own office.. pretty dumb that they have their own office but yea they are popular


I have my own office, in my house.

rj

2013-03-22 15:46:15

From: Ollybest
I have my own office, in my house.


They showed a video of it, it's a stand alone building with around 15-20 office working, again it's completely retarded

Olly

2013-03-22 15:47:40

From: RJJ95
They showed a video of it, it's a stand alone building with around 15-20 office working, again it's completely retarded


Yes, i can get a video of an office block.

rj

2013-03-22 15:51:03

From: Ollybest
Yes, i can get a video of an office block.


http://www.youtube.com/watch?v=2UFzeChcBUE

http://www.youtube.com/watch?v=_l7wGQ0_G_c

Olly

2013-03-22 15:56:52

Im sure jagex will swallow on that when they get round to it.

rj

2013-03-22 15:58:30

From: Ollybest
Im sure jagex will swallow on that when they get round to it.


I heard they paid jagex off/giving part of funds to jagex or they are abusing the fact that they live in the Netherlands which do not enforce their copy write laws