SRL Archive - Archive

nikaa - SRL Member Application


nickyvh

2013-03-21 11:54:59

How Long have You Played Runescape?
6 Year(s)


Are you affilated in anyway with Jagex LTD?
no

Were you Referred to SRL?



What is your general programming knowledge?
I know how to script in simba


Are you a member of any other communities?
No


Tell us about yourself…
From: nikaa
I am Nicky van huis
And I love making scripts for something.
I live in the netherlands.



Please show us one (or multiple) of your scripts.
program N_PowerMinerV1_1;
{$DEFINE SMART}
{$i srl/srl.simba}
{$I P07Include.Simba}

Const

Rock = 'copper'; //Which rock ,Copper or Iron



Procedure P07_DeclarePlayer;
begin
P07_PlayerName:='';
P07_PlayerPass:='';
end;


//----------------------------------------------------------------------------//
Procedure AntiBan;
begin;
If (not P07_LoggedIn) then P07_loginplayer;
if P07_LoggedIn then
begin;
case random(300) of
0: P07_HoverSkill('Mining', random(5000));
2: P07_MakeCameraAngleHigh;
3: P07_MakeCompassSouth;
5: P07_MakeCompassWest;
6: P07_DropInventorySlot(14);
7: P07_DropInventorySlot(22);
8: sleepandmovemouse(3000);
end;
end;
end;

Procedure MineCopper;
var
tmpCTS, l, r:Integer;
ObjectTPA:TPointArray;
begin
MouseSpeed:=15;
tmpCTS := GetToleranceSpeed;
SetColorToleranceSpeed(2);
SetToleranceSpeed2Modifiers(0.04, 0.10);
P07_TabInventoryTab(4);
if FindColorsTolerance(ObjectTPA, 4153733, 8, 25, 518, 359, 11) then
begin
SetColorToleranceSpeed(tmpCTS);
SetToleranceSpeed2Modifiers(0.02, 0.02);
L := High(ObjectTPA);
mmouse((ObjectTPA[r].x), (ObjectTPA[r].y), 15, 15);
clickmouse2(mouse_left);
wait(randomrange(10000, 500));
Writeln('Mining Copper');
AntiBan;
wait(randomrange(2000, 2500));
end;

end;

Procedure MineIron;
var
tmpCTS, l, r:Integer;
ObjectTPA:TPointArray;
Begin;
MouseSpeed:=15;
tmpCTS := GetToleranceSpeed;
SetColorToleranceSpeed(2);
SetToleranceSpeed2Modifiers(0.33, 0.85);
P07_TabInventoryTab(4);
if FindColorsTolerance(ObjectTPA, 2898784, 8, 25, 518, 359, 5) then
begin
SetColorToleranceSpeed(tmpCTS);
SetToleranceSpeed2Modifiers(0.02, 0.02);
L := High(ObjectTPA);
mmouse((ObjectTPA[r].x), (ObjectTPA[r].y), 15, 15);
clickmouse2(mouse_left);
wait(randomrange(10000, 500));
Writeln('Mining Iron');
AntiBan;
wait(randomrange(2000, 2500));
end;

end;




procedure Drop;
Begin;
case Lowercase (Rock) of
'copper':
begin
Repeat
MineCopper;
until P07_InvFull
If P07_InvFull then
P07_DropallExcept([1]);
AntiBan
end;
'iron':
begin
Repeat
Mineiron;
until P07_InvFull
If P07_InvFull then
P07_DropallExcept([1]);
AntiBan
end;
end;
end;




begin;
SetupSRL;
SetupP07Include;
P07_LoginPlayer
P07_MakeCameraAnglelow;
repeat
P07_TabInventoryTab(4);
AntiBan;
drop;
until (not P07_LoggedIn);
end.

Ian

2013-03-21 12:00:54

One of the requirements of the application is
A script greater than 300 lines

Yours is 127.

This shows me you have not read http://villavu.com/forum/showthread.php?t=74195

Which you should do before applying.

Please read that and then think about whether you meet the requirements.

These are basic requirements, if you don't meet all of them you get a no:

  • I am nice and helpful around the forums?
  • I have got to know many people from the community?
  • I have been here for a while (greater than one/two months)?
  • I have a script?
  • I am not applying within a month of my last application (if you had one)?


I will show you the list of Definite requirements, I will color the ones you meet green and the ones you don't

Definite:
  • Intrinsic documentation (is your script formatted properly [i.e. standards]? do you use suitable variable/method names?)
  • Use of TPAs (TPointArrays)
  • Custom object finding (that means using NO FindObj* or ACA, make up your own!)
  • Use of auto-colouring (NO ACA generated functions)
  • Walking (try not to use SPS, but instead try TPA walking/use RadialWalk)
  • Appropriate use of variable scope (i.e. local/global variables)
  • Loops (repeat..Until, while..do and for..to..do)
  • Arrays
  • Case statements
  • Randomisation (i.e. use Wait(200 + Random(300)) instead of just Wait(200))
  • Backups/fail safes (in case something goes wrong, do what?)
  • Anti-randoms
  • A script greater than 300 lines

That list should be all green, unless you are more than qualified is other areas such as being an outstandingly active member, and even then it is a possible no.

Also note that even though some things are green, your uses of them are still too simple to be considered worthy.

Also even if you had an outstanding script, I would vote no because you just got here, have ~0 posts, and have not been active or helpful.

nickyvh

2013-03-21 12:24:45

Thanks for the tips !

rj

2013-03-21 12:34:29

I'm not allowed to vote because im a newbie member but I can see a way to shorten your script (I know it has to be 300+ but this also means it can't be repetitive) I suggest instead of making separate procedures for copper and iron you can combine them into one, for example, rockcolor,hue,sat,mod,and tol can all be defined as variables, and I see you already know how to use cases so you can use them to define them like:

case Lowercase (Rock) of
'iron':
Begin
Col := 0;
hue := 0;
sat := 0;
tol := 0;
End;
'copper':
Begin
Col := 0;
hue := 0;
sat := 0;
tol := 0;
End;
End;

And then your mining procedure would look something like

Procedure MineRock;
var
tmpCTS, l, r:Integer;
ObjectTPA:TPointArray;
Begin;
MouseSpeed:=15;
tmpCTS := GetToleranceSpeed;
SetColorToleranceSpeed(2);
SetToleranceSpeed2Modifiers(hue, sat);
P07_TabInventoryTab(4);
if FindColorsTolerance(ObjectTPA, col, 8, 25, 518, 359, tol) then
begin
SetColorToleranceSpeed(tmpCTS);
SetToleranceSpeed2Modifiers(0.02, 0.02);
L := High(ObjectTPA);
mmouse((ObjectTPA[r].x), (ObjectTPA[r].y), 15, 15);
clickmouse2(mouse_left);
wait(randomrange(10000, 500));
Writeln('Mining ' + Rock);
AntiBan;
wait(randomrange(2000, 2500));
end;

end;

Also a decent way to detect if your mining is using pixel shift http://villavu.com/forum/showthread.php?t=74090 instead of guessing when it is done mining the rock

YoHoJo

2013-04-06 13:42:43

Good Luck Next Time