SRL Archive - SRL Old School RuneScape

Someone changed the GetNPCChatName text to use NPCChars07 but we don't have the fonts? Is it safe to assume they meant CharsNPC07?

That was me, let me look over it, sec.
Will edit in response

edit ah right, said NPCChars07 instead of CharsNPC07

thanks once again Justin. :]

From: Le Jingle
That was me, let me look over it, sec.
Will edit in response

edit ah right, said NPCChars07 instead of CharsNPC07

thanks once again Justin. :]

Also compile erros,

[Error] C:\Users\Justin\Documents\GitHub\SRL-007/SRL/core/chat.simba(276:22): Unknown identifier 'SpaceBar' at line 275

Can you please fix the issues and then re-submit the pull request?

E: Also everything that uses "clickContinue" is broken.

I'll resubmit the removal of spacebar changes

however, everything that uses "clickContinue" will need to be changed because as far as I know, you can't use the space bar to progress through chat in oldschool RS

From: Le Jingle
I'll resubmit the removal of spacebar changes

however, everything that uses "clickContinue" will need to be changed because as far as I know, you can't use the space bar to progress through chat in oldschool RS

Alright, let me know when you have done the pull request

From: Justin
Alright, let me know when you have done the pull request

Submitted
https://github.com/SRL/SRL-007/pull/7

From: Le Jingle
Submitted
https://github.com/SRL/SRL-007/pull/7

Please read my comment on the pull.

I think all is ok now, should hpefully cmpile

https://github.com/SRL/SRL-007/pull/8

From: Le Jingle
I think all is ok now, should hpefully cmpile

https://github.com/SRL/SRL-007/pull/8

gametab.simba
[Error] C:\Users\Justin\Documents\GitHub\SRL-007/SRL/core/gametab.simba(1839:38): Invalid number of parameters at line 1838

procedure FixGraphics;

Why don't you compile before submitting pull requests?

From: Justin
gametab.simba
[Error] C:\Users\Justin\Documents\GitHub\SRL-007/SRL/core/gametab.simba(1839:38): Invalid number of parameters at line 1838

procedure FixGraphics;

Why don't you compile before submitting pull requests?

Well, I don't know how to keep updated with the latest git includes, but isn't FixGraphics and gametab.simba a separate issues from chat.simba? if it's the spacebar boolean, it'll have to be fixed in gametab.simba, because there is _no_ spacebar boolean that will allow for the oldschool rs chat to continue through the dialouge. thus I'd rather trail the errors and fix rightlyway instance of having null/confusing code

From: Le Jingle
Well, I don't know how to keep updated with the latest git includes, but isn't FixGraphics and gametab.simba a separate issues from chat.simba? if it's the spacebar boolean, it'll have to be fixed in gametab.simba, because there is _no_ spacebar boolean that will allow for the oldschool rs chat to continue through the dialouge. thus I'd rather trail the errors and fix rightlyway instance of having null/confusing code

FixGraphics uses this 'if (not ClickContinue(True, True)) then'

E: And now we move onto bank.simba -
[Error] C:\Users\Justin\Documents\GitHub\SRL-007/SRL/core/bank.simba(344:30): Invalid number of parameters at line 343
ClickContinue(True, True);

From: Justin
FixGraphics uses this 'if (not ClickContinue(True, True)) then'

I req pull for that file too

I think the best bet for me now is to get some sleep and try to find out how to download a snapshot of the latest version from git, otherwise I'm stuck trailing reports in files outside mine like now :[ Sorry for inconvenience, still need to learn - think Hobbit had some tutorials on git (hopefully for downloading too)

From: Le Jingle
I req pull for that file too

I think the best bet for me now is to get some sleep and try to find out how to download a snapshot of the latest version from git, otherwise I'm stuck trailing reports in files outside mine like now :[ Sorry for inconvenience, still need to learn - think Hobbit had some tutorials on git (hopefully for downloading too)

No worries man, I know it's hard to get use to git, ill take off from where you left and it should be all good by the time you wake up! :)
Justin.

E: https://github.com/SRL/SRL-007/pull/10

Waiting for pull.

Nice problem solving guys :spot:


Just double checking, nobody has worked on inventory.simba yet? If not I will take a crack at it tonight

From: Ashaman88
Nice problem solving guys :spot:


Just double checking, nobody has worked on inventory.simba yet? If not I will take a crack at it tonight

I don't think anyone has worked on it yet, I searched this forum for inventory ,and didn't find anything even slightly related to people looking into it. So you should be good! :]

From: Le Jingle
I don't think anyone has worked on it yet, I searched this forum for inventory ,and didn't find anything even slightly related to people looking into it. So you should be good! :]

Added to my currently doing list :)