SRL Archive - Archive

blockay - SRL Member Application


blockay

2013-02-26 05:05:22

How Long have You Played Runescape?
8 Year(s)


Are you affilated in anyway with Jagex LTD?
no

Were you Referred to SRL?



What is your general programming knowledge?
Java c++, familiarizing with pascal. taking 2-year college class - intro to networking


Are you a member of any other communities?
powerbot since it was rsbot, played around with scripts back then


Tell us about yourself…
From: blockay
I am a 17 year old interested in electronics, i am very enthusiastic about learning more about computers and would like to become a better programmer. I also ride dirtbikes and motorcyles.



Please show us one (or multiple) of your scripts.
This is my first day working on this script, i'll be learning more and adding more to it as i progress! 

program CutterShafter;
{$I SRL/SRL.Simba}
{$I P07Include.Simba}

var
x, AnInteger, math, y, i, z, run, logs, knife, TreeColor: integer;

procedure DTM;
begin
TreeColor := 4162679;
//TreeColors := 3957891;
end;

Procedure P07_DeclarePlayer;
Begin
P07_PlayerName:='';
P07_PlayerPass:='';
end;

Procedure CallThings;
Begin
{Going to Name the Bitmap string " Ring ", and declare the variable under Var}
knife:= BitmapFromString(10, 10, 'meJwztnE1tfMwBpIOnowMDCUlNY' +
'WFVVlZRX39M4FcoDgEAdllZXVA2dy88rS03HnzVkFkgbpMHdwgsvk' +
'FlRkZ+ZMmzQVyFRQMrJy8IWZWVDQAzczOKU1JyV68eD1EFq4RYiZQ' +
'47TpiyBSEFkgm9MqFIhmzlrW2TVl2fJNEFmIYyBScAVYNUIQr0cO3' +
'D1AhFUKUxZZCuxUEAIANwhKdQ==');
logs := BitmapFromString(7, 13, 'meJwL6F8f0L9eNqTcNq3VOqUJggL' +
'AgnBxiBRcBKLGKrEeiGTDq0AooAjCBSIttyizqDKgiEV8jZ5fGhwB' +
'BaW8s6U8MkwjiiDIODQfpBKsXcovH6gegoDKkB0AsQuoDFMQUyUQi' +
'TvHYwoyMjDABYEILgg3FqgSohgA9ylm1w==');
End;

Procedure FreeThings;
Begin
FreeBitMap(logs);
FreeBitMap(knife);
End;

procedure findTree;
Begin
if not (P07_FindObjCustom(x, y, ['ree', 'tre'], [TreeColor], 10)) Then
case RandomRange(1,1000) of
1..250: P07_MakeCompassNorth;
251..500: P07_MakeCompassEast;
501..750: P07_MakeCompassSouth;
751..1000: P07_MakeCompassWest;
end;
End;

Function IsWcing: Boolean;
var
PBox: TBox;
Begin
PBox := IntToBox(240, 158, 285, 198);
Result := (AveragePixelShift(PBox, 250, 350) > 48);
//Writeln(IntToStr(AveragePixelShift(PBox, 500, 650)));
End;

procedure makeShafts;
Begin
If FindBitMapToleranceIn(logs, x, y, MIX1, MIY1, MIX2, MIY2, 50) Then
Mouse(x, y, Random(3), Random(3), true);
P07_ChooseOptionMulti(['use']);
If FindBitMapToleranceIn(knife, x, y, MIX1, MIY1, MIX2, MIY2, 50) Then
Mouse(x, y, Random(3), Random(3), true);
P07_ChooseOptionMulti(['use']);
P07_MouseBox(24, 435, 130, 452, 3);
Wait(RandomRange(300,400));
ClickMouse2(Mouse_Right);
Wait(RandomRange(300,400));
P07_ChooseOptionMulti(['ake 10']);
//Wait(RandomRange(300,400));
//SendKeys('888', 95, 35);
//Wait(RandomRange(300, 400));
//P07_UseKey(13);
Wait(RandomRange(10000, 11500));
Repeat
If not IsWcing then
If FindBitMapToleranceIn(logs, x, y, MIX1, MIY1, MIX2, MIY2, 50) Then
Mouse(x, y, Random(3), Random(3), true);
P07_ChooseOptionMulti(['use']);
If FindBitMapToleranceIn(knife, x, y, MIX1, MIY1, MIX2, MIY2, 50) Then
Mouse(x, y, Random(3), Random(3), true);
P07_ChooseOptionMulti(['use']);
P07_MouseBox(24, 435, 130, 452, 3);
Wait(RandomRange(300,400));
ClickMouse2(Mouse_Right);
Wait(RandomRange(300,400));
P07_ChooseOptionMulti(['ake 10']);
Wait(RandomRange(14000, 15500));
Until not FindBitMapToleranceIn(logs, x, y, MIX1, MIY1, MIX2, MIY2, 50)
End;

Procedure turnRunOn;
begin
end;

procedure ChopTree;
begin
If P07_FindObjCustom(x, y, ['Tree', 'own Tr'], [TreeColor], 5) Then
begin
AnInteger:=P07_InvCount
if Random(28) = 1 then
begin
ClickMouse2(mouse_right);
P07_ChooseOptionMulti(['Chop']);
Repeat Wait(500);
Until (P07_InvCount>AnInteger)
end
else
begin
ClickMouse2(mouse_left);
P07_ChooseOptionMulti(['Chop']);
Repeat Wait(500);
Until (P07_InvCount>AnInteger)
end;
If not (P07_FindObjCustom(x, y, ['ree', 'tre'], [TreeColor], 4)) Then
case random(1000) of
1..250: P07_MakeCompassNorth;
251..500: P07_MakeCompassEast;
501..750: P07_MakeCompassSouth;
751..1000: P07_MakeCompassWest;
end;
end;
end;

begin
run := 0;
DTM;
CallThings;
P07_DeclarePlayer;
SetupP07Include;
ActivateClient;
Addonterminate('FreeThings');
repeat

Wait(1000);
math := (300000 * z);
If (Not P07_LoggedIn) Then
P07_LogInPlayer;
P07_MakeCameraAngleHigh;
if (run = 0) then
begin
MarkTime(i)
turnRunOn;
z := 1;
//z + 1
end;
if(P07_InvFull) then
begin
makeShafts;
end

else

repeat
if (not(P07_InvFull)) then
if Not (IsWcing) then
begin
findTree;
ChopTree;
end;
Until (P07_InvFull);
Until (false)
End.

xtrapsp

2013-02-26 05:21:18

Just a headsup… you have the whole script as a string pretty much…

Press Play

2013-02-26 06:23:40

I voted no because I don't think the script is advanced enough and because you are new and haven't given yourself enough time for some community involvement.

As for your script, I would like to see:
  • Better standards!
  • Custom object finding (eg. use of ATPAs)
  • More failsafes
  • You have a possible infinite loop in there:
  • Until not FindBitMapToleranceIn(logs, x, y, MIX1, MIY1, MIX2, MIY2, 50)
Have a look in the tutorials section and good luck for possible future applications if you don't make it in this time.

Benny

2013-02-26 06:25:18

No sorry. I would like to see greater activity and a more advanced script with anti ban implemented.

Sorry. Good luck.

P1ng

2013-02-26 07:39:11

Unfortunately, also a no from myself.

Greater community involvement
More advanced techniques like:
- Walking
- TPAs
- Case statements

Your standards don't really meet those expected for SRL members, there is a little bit of leeway in this but I still require it to be a bit neater than at present.
Hang around, get to know us, let us get to know you and learn a little more along the way. If you truly are interested in learning about electronics and becoming a better scripter, this is a great place for you.

Ian

2013-02-26 08:47:18

From: xtrapsp
Just a headsup… you have the whole script as a string pretty much…


It's because he has a contraction in the sentence above his script that strings it :p


As others have already mentioned, the script needs improving. I'd also like to add that SRL Members is also a community rank, and we hardly know you yet. Be more active, help out around the community, and work on your script :)

Don't be discouraged, people don't usually get in on their 1st try :)

DannyRS

2013-02-26 08:52:39

Everything mentioned above ;)

You also use, MIX1, MIX2, etc, they are main runescape constant's, even if they work, you should use P07_MIX1, and such, for all of them, untill we have an official Include that will probably be the same names!

Best of luck next time if you don't make it this time!

Hobbit

2013-02-26 10:59:37

Please take the advice given above and check out the tutorial section to learn some more advanced techniques. Also involve yourself in the community and get to know us! That is a big part of being a member at SRL.

Feel free to try again in 4 weeks. :)

Closed