SRL Archive - Help

I am currently making a fishing colony monkfish fisher, but I can't get it to stop finding new fishing spots after it's fishing. I've tried using AveragePixelShift, and it doesn't work. What code should I use for checking if it hasn't gained xp in a certain amount of time to find a new spot?

What about the Total/Fishing XP Counter?

I think that'd be easier than looking in the inventory.. i'll try that.

Would this code work?

Function IsFishing: Boolean;
  var
   Isfishingxp, Startxp, i:Integer;
   begin
    Startxp := (GetXPBar(1)+1);
    wait(randomrange(10000, 20000));
    IsFishingxp := GetXPBar(1);
    if (Isfishingxp > Startxp) then
    result := True;
    if not (Isfishingxp > Startxp) then
    result := False;
  end;

What about following the point/colour where you clicked and when it disappears then the fishing spot isn't there.

-Boom

I put some code onto my first reply.. would that work? idk. I'm not the most expierienced scripter.

From: Dynamite
What about following the point/colour where you clicked and when it disappears then the fishing spot isn't there.

-Boom

Yeah thought bout too, might be an hassle if the camera shifts, could do it in a box?

From: Sawyer
I put some code onto my first reply.. would that work? idk. I'm not the most expierienced scripter.

I'm not that experienced too , but I think it would work though. (assuming you're using a repeat until not Isfishing)

But U can change

 if (Isfishingxp > Startxp) then
    result := True;
    if not (Isfishingxp > Startxp) then
    result := False;

to something shorter

    if (Isfishingxp > Startxp) then
    result := True;
    else
    result := False;

No need to make a new if then statement, when u can use else

From: Sawyer
I think that'd be easier than looking in the inventory.. i'll try that.

Would this code work?

Function IsFishing: Boolean;
  var
   Isfishingxp, Startxp, i:Integer;
   begin
    Startxp := (GetXPBar(1)+1);
    wait(randomrange(10000, 20000));
    IsFishingxp := GetXPBar(1);
    if (Isfishingxp > Startxp) then
    result := True;
    if not (Isfishingxp > Startxp) then
    result := False;
  end;

Using that code, here's how I'd go about this:

Function IsFishing: Boolean;
var
  XPA,T: Integer;
begin
  Result := False;
  if not LoggedIn then
    Exit;

  XPA := GetXPBar(1);
  MarkTime(T);

  Repeat
    if not LoggedIn then
      Exit;
    FindNormalRandoms;

    if (GetXPBar(1) <> XPA) then
      break;
  Until(TimeFromMark(T) > 7000)        //7 seconds without gaining XP

  Result := (GetXPBar(1) <> XPA);
end;

Also, if this function is constantly begin called then you'll want to put more inside of this function's loop, like InvFull checks or anti-bans, ect…

From: Flight
<>

What does <> mean?

From: Sjoekeloe
What does <> mean?

Greater than or less than, basically "if (integerA does not equal integerB) then". In Java I believe it's the same as "!=".

From: Flight
Greater than or less than, basically "if (integerA does not equal integerB) then". In Java I believe it's the same as "!=".

alright useful to know, I read it as 'different'
thanks!

Thanks guys. I'm kinda new to scripting, so I'm learning a lot.

Not a problem at all. Don't be afraid to ask for any help, that's why we're here. :)