SRL Archive - Archive

marc2333 - SRL Member Application


marc2333

2012-12-16 19:24:47

How Long have You Played Runescape?
10 Year(s)


Are you affilated in anyway with Jagex LTD?
No

Were you Referred to SRL?
Can't remember


What is your general programming knowledge?
Learning, i have followed many Java tutorials on youtube (thenewboston and many others). Also learning Pascal right now with Simba.


Are you a member of any other communities?
I got an account at Powerbot, used to be at RsBuddy, i got an account at Robotz in Disguise too.


Tell us about yourself…
From: marc2333
My name is Marc. I am 18 years old. My first language is French and my second is english. I dont study in programming but it is something that really interest me. It was my second choice. I am from Canada. I have been playing Runescape since 2002 (with many quit/comeback). I like playing private servers too, thats where i started scripting.



Please show us one (or multiple) of your scripts.
Made only some for Rsps so far. Will make  some for Rs when i'll feel i have the knowledge to make something great.

This is the most complex i made with banking, failsafe, DTM walking, TPA/ATPA

[code]program OSS_Ess;
{$i srl/srl.simba}

var
x, y, i, t, t2: Integer;
Q: Array [0..15] of Integer;//DTM Declaring procedure.
aFound: Extended;
Aubury,Aubury0,Ess,Ess0,Essence,BlackTPA,BankTPA,BoothTPA:TPointArray;
Aubury2,Ess2,EssenceSplit,Booth2: T2DPointArray;
count,count2,count3:boolean;

procedure SetDTM;//DTM Defining procedure.
begin
Q[0] := DTMFromString('mggAAAHicY2NgYLjHzMBwEogPAvFeIN4JxFuAeANQbiYQzwLi2VA8B4ht3bgZ3r5lQMF//jAx/ALKsWLBjDgwBAAAP74TaQ==');
Q[1] := DTMFromString('mggAAAHicY2NgYJjJzMCwDIjnAfEsIJ4GxJOA+ABQrhaKa5DYf/4wgfHbtwwMX78ygGkQZmXAjhlxYAgAAOL9Eng=');
Q[2] := DTMFromString('mbQAAAHicY2VgYFjDzMCwFYgPQvEFIN4BFN8OxHuBeC0Q7wTiDx8YGDKTDRligoPgmBUojo4ZsWAwAADWCA1Y');
Q[3] := DTMFromString('mggAAAHicY2NgYOBlYmDQB2JzIH7EyMDwnBEi1guky4B4CiOEnQ/ENUD8/z8y/g/FDDgBIw4MAQDLBxNn');
Q[4] := DTMFromString('mbQAAAHicY2VgYFjGzMAwG4j7gLgViBtBbKD4PiDeDsSrgHgREE9ubWPITUlDwawMmIARCwYDAIpKDL0=');
Q[5] := DTMFromString('mggAAAHicY2NgYJjOzMCwAIhXAvEmIF4FxJuBeAVQbgkQLwPipUC8HojXAnF2YhJDsJc/Q25KGgpmZcAOGHFgCAAAD6wO/A==');
Q[6] := DTMFromString('mbQAAAHicY2VgYNjDzMBwDIh3APFcID4HxN1A8S4gXgzFU4A4Py2FITcljQEGgr38GX4BaVY0zIgFgwEAPagLGA==');
Q[7] := DTMFromString('mlwAAAHicY2dgYLjIzMBwCIi3AfFqIF4BxFuA+AYQ5wDlFwDxDCDuAeIWIC4C4glAPGdCH0NuShoYB3v5g2kYSAFiVhyYEQ+GAgB+Cg/P');
Q[8] := DTMFromString('mlwAAAHicY2dgYLjEzMBwF4jPAPE+ID4FxLuBeAcQpwHle4G4B4gnAPFiIN4PxOeB2D2JnyEmOAgrZgXK48KMeDAUAADGCBC7');
Q[9] := DTMFromString('mbQAAAHicY2VgYOhmZmBoB+JmIK4D4slA3AoUbwPidigG8b9+ZWB4+xaC//xhAtOsDJiYEQsGAwDsPw7p');
Q[10] := DTMFromString('mrAAAAHic42BgYLjEzMBwC4jPA/EhID4FxMeBeBcQ7wDiXKCaiUDcD6UXAPFuKL4IxH5J/AwxwUE4MStQDT7MSADDAADw5xNc');
Q[11] := DTMFromString('mggAAAHicY2NgYOhhZmCYCsR9QNwFxG1A3ATE/UC5qUh4ChT/uxvN8OcPE8Pbtwxg/PUrhP7CyMDAyoCJGXFgCAAAEvwTjA==');
Q[12] := DTMFromString('mQwAAAHicY2ZgYJBiYmC4zsjAkA+kMxghOAuI////D8YMIIwEGJEwEAAAnj8KoQ==');
Q[13] := DTMFromString('mggAAAHicY2NgYGhlZmCYBMSdULoJiGuAuBcoNxGIJwHxDCQcExzE8PUrA8OfP0xgNgzjAow4MAQAANhzDq8=');
Q[14] := DTMFromString('mQwAAAHicY2ZgYJjAzMAwHYifAHEXiA/EbUAcFxrC8PUrA4OrqiADMmBEwkAAAD6qByc=');
Q[15] := DTMFromString('mWAAAAHicY2FgYOhhZmCYAMQTgbgFiLuAYk1A3A/EfUAcExzEkGMqwPDnDxMYf2FkYGBlQGBGNAwCAFK5Cxk=');
end;

procedure FrDTM;
begin
FreeDTM(Q[0]);
FreeDTM(Q[1]);
FreeDTM(Q[2]);
FreeDTM(Q[3]);
FreeDTM(Q[4]);
FreeDTM(Q[5]);
FreeDTM(Q[6]);
FreeDTM(Q[7]);
FreeDTM(Q[8]);
FreeDTM(Q[9]);
FreeDTM(Q[10]);
FreeDTM(Q[11]);
FreeDTM(Q[12]);
FreeDTM(Q[13]);
FreeDTM(Q[14]);
FreeDTM(Q[15]);
end;

procedure BankToTele;
begin
SetDTM;
if FindDTMRotated(Q[0], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) then
begin
begin
MoveMouse(x, y);
ClickMouse(x, y, 1)
wait(2000)
repeat
Wait(50 + Random(25));
writeln('a')
until(FindDTMRotated(Q[1], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindDTMRotated(Q[2], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound)) ;
end;
if FindDTMRotated(Q[1], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) then
begin
MoveMouse(x, y);
ClickMouse(x, y, 1)
writeln('1')
repeat
Wait(50 + Random(25));
until(FindColors(Aubury0,1264759,MSX1,MSY1,MSX2,MSY2))
wait(100)
end;
if FindDTMRotated(Q[2], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) then
begin
MoveMouse(x, y+10);
ClickMouse(x, y+10, 1)
writeln('2')
repeat
Wait(50 + Random(25));
until(FindColors(Aubury0,1264759,MSX1,MSY1,MSX2,MSY2))
wait(1000)
end;
MarkTime(t);
repeat
if FindColors(Aubury,1264759,MSX1,MSY1,MSX2,MSY2)then
begin
Aubury2 := SplitTPAEx(Aubury, 10, 10);
SortATPASize(Aubury2, True);
MiddleTPAEx(Aubury2[0], X, Y); //Finds the middle via averaging
begin
movemouse(x, y);
wait(100);
ClickMouse(x, y, 0);
wait(1000);
if FindDTM(Q[3], x, y, MSX1, MSY1, MSX2, MSY2)then
begin
movemouse(x, y);
wait(100);
count:=true;
ClickMouse(x, y, 1);
end;
end;
end;
wait(100);
until(count=true or (TimeFromMark(t) > 10000));
end;
FrDTM
end;

procedure CenterToEss;
begin
wait(7000)
SetDTM;
if FindDTMRotated(Q[4], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindDTMRotated(Q[7], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) then
begin
MoveMouse(x, y);
wait(100)
ClickMouse(x, y, 1)
wait(6000)
repeat
Wait(50 + Random(25));
until FindDTMRotated(Q[5], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindDTMRotated(Q[6], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound);
end;
if FindDTMRotated(Q[5], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindDTMRotated(Q[6], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) then
begin
MoveMouse(x, y);
wait(100)
ClickMouse(x, y, 1)
wait(4000)
repeat
Wait(50 + Random(25));
until(FindColors(Ess0,9013655,MSX1,MSY1,MSX2,MSY2));
end;
repeat
if FindColors(Ess,9013655,MSX1,MSY1,MSX2,MSY2)then
begin
Ess2 := SplitTPAEx(Ess, 5, 5);
SortATPASize(Ess2, True);
MiddleTPAEx(Ess2[0], X, Y); //Finds the middle via averaging
begin
movemouse(x, y);
wait(100);
ClickMouse(x, y, 1);
wait(1000);
writeln('yooooo')
count2:=true;
end;
end;
wait(100);
until(count2=true);
FrDTM;
end;

procedure EssToTele;
begin
repeat
FindColorsTolerance(Essence,8290184,569,211,729,460,70);
EssenceSplit := SplitTPAEx(Essence, 2, 2);
writeln(IntToStr(High(EssenceSplit)+1));
wait(400)
until(High(EssenceSplit)+1=28);
If FindColorTolerance(X, Y, 2782193, MMX1, MMY1, MMX2, MMY2, 5)then
begin
Movemouse(x,y);
wait(200);
Clickmouse(x,y,1);
wait(2000)
repeat
if FindColorTolerance(X,Y,9944001,MSX1,MSY1,MSX2,MSY2,13)then
begin
Movemouse(x,y);
wait(200);
Clickmouse(x,y,1);
wait(5000)
end;
FindColors(BlackTPA,0,MMX1,MMY1,MMX2,MMY2);
writeln(IntToStr(High(BlackTPA)));
until(High(BlackTPA)<1000);
end;
end;

procedure TeleToBank;
begin
setDTM
if FindDTMRotated(Q[8], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindDTMRotated(Q[10], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) then
begin
MoveMouse(x, y);
wait(200)
ClickMouse(x, y, 1)
wait(6000)
repeat
Wait(50 + Random(25));
until FindDTMRotated(Q[8], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindDTMRotated(Q[11], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindDTMRotated(Q[14], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindDTMRotated(Q[15], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindColorTolerance(X,Y,6020606,MMX1,MMY1,MMX2,MMY2,5);
end;
if FindDTMRotated(Q[8], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindDTMRotated(Q[11], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindDTMRotated(Q[14], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindDTMRotated(Q[15], x, y, MMX1, MMY1, MMX2, MMY2, -Pi/4, Pi/4, Pi/60, aFound) or FindColorTolerance(X,Y,6020606,MMX1,MMY1,MMX2,MMY2,5) then
begin
MoveMouse(x, y);
wait(200)
ClickMouse(x, y, 1)
wait(6000)
repeat
Wait(50 + Random(25));
FindColorsTolerance(BankTPA,207935,MSX1,MSY1,MSX2,MSY2,10);
writeln(IntToStr(High(BankTPA)));
until(High(BankTPA)>100);
end;
wait(1500)
MarkTime(t2);
repeat
if FindColors(BoothTPA,209483,MSX1,MSY1,MSX2,MSY2) then
begin
writeln('mofo')
Booth2 := SplitTPAEx(BoothTPA, 15, 10);
SortATPASize(Booth2, True);
MiddleTPAEx(Booth2[0], X, Y);
MoveMouse(x,y);
wait(200);
ClickMouse(x,y,0); //Finds the middle via averaging
wait(200);
if FindDTM(Q[12], x, y, MSX1, MSY1, MSX2, MSY2)then
begin
movemouse(x, y);
wait(100);
count3:=true;
ClickMouse(x, y, 1);
end;
end;
until(count3=true or (TimeFromMark(t2) > 10000));
wait(2000)
if FindColorTolerance(x,y,8421514,570,212,688,280,50)then
begin
MoveMouse(X,Y)
wait(500)
ClickMouse(X,Y,0)
wait(500)
MoveMouse(X,Y+73)
wait(500)
ClickMouse(X,Y+73,1)
end;
FrDTM
end;


begin
repeat
BankToTele;
CenterToEss;
EssToTele;
TeleToBank;
until(false)
end. [/code]

Here is my Hill Giant killer and Bone burier :

[code]program new;
{$i srl/srl.simba}

Var
x,y,n,m,TakeBigBone:integer;
HillTPA,BoneTPA:TPointArray;
Hill2DTPA,Bone2DTPA:T2DPointArray;

Procedure burybone;
begin
if findcolortolerance(x,y,11974335,556,204,739,462,8)then
begin
movemouse(x,y);
wait(250);
clickmouse(x,y,1);
wait(250);
end;
end;


Function fighting: boolean;
begin
if findcolor(X,Y,65280,190,118,381,226)or
findcolor(X,Y,255,190,118,381,226)then
begin
result:=true;
end else
result:=false;
end;

procedure CheckIfInFight;
begin
if findcolor(X,Y,65280,190,118,381,226)or
findcolor(X,Y,255,190,118,381,226)then
repeat
wait(1000);
burybone;
until(fighting=false)
end;

Procedure CheckForBone;
begin
if findcolors(BoneTPA,7039862,MSX1,MSY1,MSX2,MSY2)then
begin
TakeBigBone := DTMFromString('m+AIAAHiczc3BCgFRFMbxM7KysJFSsmJBEaUsLMRCPICtd/IgaMyw8AriAdjZsbKQlXT9cabuKJrlnPp1zv3u6d6SiDwckQ222OOIE8644Iob7kgmPlJII4MscsijgCIqKKOKGupooIkW2uighz6G2PH+AT7zFCvtns5zNdPz2tpzv/rLAkvN7Nyzuv+Hqztm0hVjTMh4NAh571iCzL77lUUV/B23cmImSj0BtyVhHg==');
Bone2DTPA := SplitTPAEx(BoneTPA, 5, 5);
SortATPASize(Bone2DTPA, False);
MiddleTPAEx(Bone2DTPA[0], X, Y); //Finds the middle via averaging
wait(200);
movemouse(x,y);
wait(200);
Clickmouse(x,y,0);
wait(400);
if FindDtm(TakeBigBone,x,y,MSX1,MSY1,MSX2,MSY2)then
begin
movemouse(x,y);
wait(300);
clickmouse(x,y,1);
wait(250);
end;
freedtm(TakeBigBone);
end;
end;

Procedure Fight;
begin
if findcolorstolerance(HillTPA,5141926,4,4,514,340,38) then
begin
Hill2DTPA := SplitTPAEx(HillTPA, 5, 5);
SortATPASize(Hill2DTPA, True);
MiddleTPAEx(Hill2DTPA[0], X, Y); //Finds the middle via averaging
movemouse(x,y);
wait(200);
clickmouse(x,y,1);
wait(4000)
end;
end;

begin
ClearDebug;
repeat
Fight;
wait(50)
Checkifinfight;
Checkforbone;
wait(2000);
until(false)
end. [/code]

Here is my power granite miner with a full invent dropping procedure that i am using in many other power skilling scripts :
[code]program OSS_Granite_Miner;
{$i srl/srl.simba}

var
orecount,pph,count,N,M,X,Y,t,r1,r2,r3,r4:integer;
TPA : tpointarray;


Function fighting: boolean;
begin
if findcolor(X,Y,255,171,115,357,227)then
begin
result:=true;
end else
result:=false;
end;

procedure CheckIfInFight;
begin
if findcolor(X,Y,65280,171,115,357,227)then
begin
writeln('infight');
repeat
wait(1000);
until(fighting=false)
end;
end;

procedure CheckTrade;
begin
if findcolor(X,Y,8388736,21,415,224,433)then
begin
movemouse(X,Y);
wait(200);
clickmouse(X,Y,1);
wait(1000);
if findcolor(X,Y,192,239,258,251,272) then
begin
if findcolor(X,Y,3560818,609,213,644,267)then
movemouse(x,y);
wait(200);
clickmouse(x,y,0);
wait(200);
movemouse(x,y+70);
wait(200);
clickmouse(x,y+70,1);
wait(500);
if findcolor(x,y,49152,242,186,282,197)then
begin
movemouse(x,y);
wait(200);
clickmouse(x,y,1);
wait(2000);
if findcolortolerance(x,y,49152,204,299,250,315,0)then
begin
movemouse(x,y);
wait(200)
clickmouse(x,y,1)
wait(2000)
end;
end;
end;
end;
end;

procedure CheckDrop;
begin
if findcolortolerance(X,Y,1988533,695,408,728,436,5) or
findcolortolerance(X,Y,6184552,695,408,728,436,5) or
findcolortolerance(X,Y,1055024,695,408,728,436,5)or
findcolortolerance(X,Y,3889536,695,408,728,436,5) then
begin
t:=20;
r1:=583;
r2:=627;
r3:=668;
r4:=710;
wait(t);
movemouse(r1,240)
wait(t)
clickmouse(r1,240,0);
wait(t);
movemouse(r1,279);
wait(t);
clickmouse(r1,279,1);
wait(t);
movemouse(r1,272);
wait(t);
clickmouse(r1,272,0);
wait(t);
movemouse(r1,312)
wait(t);
clickmouse(r1,312,1)
wait(t);
movemouse(r1,306);
wait(t);
clickmouse(r1,306,0);
wait(t);
movemouse(r1,346)
wait(t);
clickmouse(r1,343,1)
wait(t);
movemouse(r1,343);
wait(t);
clickmouse(r1,343,0);
wait(t);
movemouse(r1,383)
wait(t);
clickmouse(r1,383,1)
wait(t);
movemouse(r1,377);
wait(t);
clickmouse(r1,377,0);
wait(t);
movemouse(r1,407)
wait(t);
clickmouse(r1,407,1)
wait(t);
movemouse(r1,414);
wait(t);
clickmouse(r1,414,0);
wait(t);
movemouse(r1,406)
wait(t);
clickmouse(r1,406,1)

wait(t)
movemouse(r2,201);
wait(t);
clickmouse(r2,201,0);
wait(t);
movemouse(r2,240);
wait(t);
clickmouse(r2,240,1);
wait(t);
clickmouse(r2,240,0);
wait(t);
movemouse(r2,279);
wait(t);
clickmouse(r2,279,1);
wait(t);
movemouse(r2,272);
wait(t);
clickmouse(r2,272,0);
wait(t);
movemouse(r2,312)
wait(t);
clickmouse(r2,312,1)
wait(t);
movemouse(r2,306);
wait(t);
clickmouse(r2,306,0);
wait(t);
movemouse(r2,346)
wait(t);
clickmouse(r2,343,1)
wait(t);
movemouse(r2,343);
wait(t);
clickmouse(r2,343,0);
wait(t);
movemouse(r2,383)
wait(t);
clickmouse(r2,383,1)
wait(t);
movemouse(r2,377);
wait(t);
clickmouse(r2,377,0);
wait(t);
movemouse(r2,407)
wait(t);
clickmouse(r2,407,1)
wait(t);
movemouse(r2,414);
wait(t);
clickmouse(r2,414,0);
wait(t);
movemouse(r2,406)
wait(t);
clickmouse(r2,406,1)

wait(t)
movemouse(r3,201);
wait(t);
clickmouse(r3,201,0);
wait(t);
movemouse(r3,240);
wait(t);
clickmouse(r3,240,1);
wait(t);
clickmouse(r3,240,0);
wait(t);
movemouse(r3,279);
wait(t);
clickmouse(r3,279,1);
wait(t);
movemouse(r3,272);
wait(t);
clickmouse(r3,272,0);
wait(t);
movemouse(r3,312)
wait(t);
clickmouse(r3,312,1)
wait(t);
movemouse(r3,306);
wait(t);
clickmouse(r3,306,0);
wait(t);
movemouse(r3,346)
wait(t);
clickmouse(r3,343,1)
wait(t);
movemouse(r3,343);
wait(t);
clickmouse(r3,343,0);
wait(t);
movemouse(r3,383)
wait(t);
clickmouse(r3,383,1)
wait(t);
movemouse(r3,377);
wait(t);
clickmouse(r3,377,0);
wait(t);
movemouse(r3,407)
wait(t);
clickmouse(r3,407,1)
wait(t);
movemouse(r3,414);
wait(t);
clickmouse(r3,414,0);
wait(t);
movemouse(r3,406)
wait(t);
clickmouse(r3,406,1)

wait(t)
movemouse(r4,201);
wait(t);
clickmouse(r4,201,0);
wait(t);
movemouse(r4,240);
wait(t);
clickmouse(r4,240,1);
wait(t);
clickmouse(r4,240,0);
wait(t);
movemouse(r4,279);
wait(t);
clickmouse(r4,279,1);
wait(t);
movemouse(r4,272);
wait(t);
clickmouse(r4,272,0);
wait(t);
movemouse(r4,312)
wait(t);
clickmouse(r4,312,1)
wait(t);
movemouse(r4,306);
wait(t);
clickmouse(r4,306,0);
wait(t);
movemouse(r4,346)
wait(t);
clickmouse(r4,343,1)
wait(t);
movemouse(r4,343);
wait(t);
clickmouse(r4,343,0);
wait(t);
movemouse(r4,383)
wait(t);
clickmouse(r4,383,1)
wait(t);
movemouse(r4,377);
wait(t);
clickmouse(r4,377,0);
wait(t);
movemouse(r4,407)
wait(t);
clickmouse(r4,407,1)
wait(t);
movemouse(r4,414);
wait(t);
clickmouse(r4,414,0);
wait(t);
movemouse(r4,406)
wait(t);
clickmouse(r4,406,1)
wait(700)
end;

end;

function CheckIfDoneMining : boolean;
begin
if not findcolor(N,M,4418960,X-15,Y-15,X+15,Y+15)or
(count = 100) then
begin
count:=0;
result:=true;
end else
begin
inc(count)
result:=false;
end;

end;

procedure MineGranite;
begin
if FindColor(X, Y, 4418960, 195, 170, 361, 198) then
begin
movemouse(X,Y);
wait(30);
clickmouse(X,Y,1);
inc(orecount);
wait(2000)
repeat
wait(100);
CheckIfDoneMining;
until(CheckIfDoneMining=true);
end;
end;

procedure Proggy;
begin
ClearDebug
WriteLn('_______________________________ Progress Report ______________________________');
Pph:=Round(375*orecount/(GetTimeRunning/3600000.0));
writeln('Xp made so far: ' + IntToStr(orecount*175/1000)+'k');
writeLN('Xp per hour: ' + IntToStr(pph/1000) + 'k so far');
WriteLn('______________________________________________________________________________');
end;

begin
setupsrl
cleardebug;
repeat
MineGranite;
CheckDrop;
CheckIfInFight
wait(50)
Proggy
until(false)
end. [/code]

riwu

2012-12-16 20:07:37


procedure SetDTM;//DTM Defining procedure.
begin
Q[0] := DTMFromString('mggAAAHicY2NgYLjHzMBwEogPAvFeIN4JxFuAeANQbiYQzwLi2VA8B4ht3bgZ3r5lQMF//jAx/ALKsWLBjDgwBAAAP74TaQ==');
Q[1] := DTMFromString('mggAAAHicY2NgYJjJzMCwDIjnAfEsIJ4GxJOA+ABQrhaKa5DYf/4wgfHbtwwMX78ygGkQZmXAjhlxYAgAAOL9Eng=');
Q[2] := DTMFromString('mbQAAAHicY2VgYFjDzMCwFYgPQvEFIN4BFN8OxHuBeC0Q7wTiDx8YGDKTDRligoPgmBUojo4ZsWAwAADWCA1Y');
Q[3] := DTMFromString('mggAAAHicY2NgYOBlYmDQB2JzIH7EyMDwnBEi1guky4B4CiOEnQ/ENUD8/z8y/g/FDDgBIw4MAQDLBxNn');
Q[4] := DTMFromString('mbQAAAHicY2VgYFjGzMAwG4j7gLgViBtBbKD4PiDeDsSrgHgREE9ubWPITUlDwawMmIARCwYDAIpKDL0=');
Q[5] := DTMFromString('mggAAAHicY2NgYJjOzMCwAIhXAvEmIF4FxJuBeAVQbgkQLwPipUC8HojXAnF2YhJDsJc/Q25KGgpmZcAOGHFgCAAAD6wO/A==');
Q[6] := DTMFromString('mbQAAAHicY2VgYNjDzMBwDIh3APFcID4HxN1A8S4gXgzFU4A4Py2FITcljQEGgr38GX4BaVY0zIgFgwEAPagLGA==');
Q[7] := DTMFromString('mlwAAAHicY2dgYLjIzMBwCIi3AfFqIF4BxFuA+AYQ5wDlFwDxDCDuAeIWIC4C4glAPGdCH0NuShoYB3v5g2kYSAFiVhyYEQ+GAgB+Cg/P');
Q[8] := DTMFromString('mlwAAAHicY2dgYLjEzMBwF4jPAPE+ID4FxLuBeAcQpwHle4G4B4gnAPFiIN4PxOeB2D2JnyEmOAgrZgXK48KMeDAUAADGCBC7');
Q[9] := DTMFromString('mbQAAAHicY2VgYOhmZmBoB+JmIK4D4slA3AoUbwPidigG8b9+ZWB4+xaC//xhAtOsDJiYEQsGAwDsPw7p');
Q[10] := DTMFromString('mrAAAAHic42BgYLjEzMBwC4jPA/EhID4FxMeBeBcQ7wDiXKCaiUDcD6UXAPFuKL4IxH5J/AwxwUE4MStQDT7MSADDAADw5xNc');
Q[11] := DTMFromString('mggAAAHicY2NgYOhhZmCYCsR9QNwFxG1A3ATE/UC5qUh4ChT/uxvN8OcPE8Pbtwxg/PUrhP7CyMDAyoCJGXFgCAAAEvwTjA==');
Q[12] := DTMFromString('mQwAAAHicY2ZgYJBiYmC4zsjAkA+kMxghOAuI////D8YMIIwEGJEwEAAAnj8KoQ==');
Q[13] := DTMFromString('mggAAAHicY2NgYGhlZmCYBMSdULoJiGuAuBcoNxGIJwHxDCQcExzE8PUrA8OfP0xgNgzjAow4MAQAANhzDq8=');
Q[14] := DTMFromString('mQwAAAHicY2ZgYJjAzMAwHYifAHEXiA/EbUAcFxrC8PUrA4OrqiADMmBEwkAAAD6qByc=');
Q[15] := DTMFromString('mWAAAAHicY2FgYOhhZmCYAMQTgbgFiLuAYk1A3A/EfUAcExzEkGMqwPDnDxMYf2FkYGBlQGBGNAwCAFK5Cxk=');
end;
You could directly assign the T2DIntegerArray instead of doing it one by one.


procedure FrDTM;
begin
FreeDTM(Q[0]);
FreeDTM(Q[1]);
FreeDTM(Q[2]);
FreeDTM(Q[3]);
FreeDTM(Q[4]);
FreeDTM(Q[5]);
FreeDTM(Q[6]);
FreeDTM(Q[7]);
FreeDTM(Q[8]);
FreeDTM(Q[9]);
FreeDTM(Q[10]);
FreeDTM(Q[11]);
FreeDTM(Q[12]);
FreeDTM(Q[13]);
FreeDTM(Q[14]);
FreeDTM(Q[15]);
end;
A simple for loop/FreeDTMs would shorten the code to 1/2 lines.

Potential infinite loops at BankToTele, also you are loading all the DTMs but you are only using a few of them in some of the procedures. Might be better to add an extra param to your SetDTM to just load the ones needed (for both efficiency and readability)

You need to improve your standards, EssToTele has no indentation at all.

Severe reliance on DTMs and basic color finding (FindColor/FindColorTolerance). Also you will need to demonstrate your knowledge of the SRL include which makes it hard to judge based on a private server script since you hardly (if at all) use the include.

For your TPA/ATPA usage in Procedure Fight; you should loop through the ATPA instead of just taking the first point (since that may not be what you want).



procedure CheckDrop;
begin
if findcolortolerance(X,Y,1988533,695,408,728,436,5) or
findcolortolerance(X,Y,6184552,695,408,728,436,5) or
findcolortolerance(X,Y,1055024,695,408,728,436,5)or
findcolortolerance(X,Y,3889536,695,408,728,436,5) then
begin
t:=20;
r1:=583;
r2:=627;
r3:=668;
r4:=710;
wait(t);
movemouse(r1,240)
wait(t)
clickmouse(r1,240,0);
wait(t);
movemouse(r1,279);
wait(t);
clickmouse(r1,279,1);
wait(t);
movemouse(r1,272);
wait(t);
clickmouse(r1,272,0);
wait(t);
movemouse(r1,312)
wait(t);
clickmouse(r1,312,1)
wait(t);
movemouse(r1,306);
wait(t);
clickmouse(r1,306,0);
wait(t);
movemouse(r1,346)
wait(t);
clickmouse(r1,343,1)
wait(t);
movemouse(r1,343);
wait(t);
clickmouse(r1,343,0);
wait(t);
movemouse(r1,383)
wait(t);
clickmouse(r1,383,1)
wait(t);
movemouse(r1,377);
wait(t);
clickmouse(r1,377,0);
wait(t);
movemouse(r1,407)
wait(t);
clickmouse(r1,407,1)
wait(t);
movemouse(r1,414);
wait(t);
clickmouse(r1,414,0);
wait(t);
movemouse(r1,406)
wait(t);
clickmouse(r1,406,1)

wait(t)
movemouse(r2,201);
wait(t);
clickmouse(r2,201,0);
wait(t);
movemouse(r2,240);
wait(t);
clickmouse(r2,240,1);
wait(t);
clickmouse(r2,240,0);
wait(t);
movemouse(r2,279);
wait(t);
clickmouse(r2,279,1);
wait(t);
movemouse(r2,272);
wait(t);
clickmouse(r2,272,0);
wait(t);
movemouse(r2,312)
wait(t);
clickmouse(r2,312,1)
wait(t);
movemouse(r2,306);
wait(t);
clickmouse(r2,306,0);
wait(t);
movemouse(r2,346)
wait(t);
clickmouse(r2,343,1)
wait(t);
movemouse(r2,343);
wait(t);
clickmouse(r2,343,0);
wait(t);
movemouse(r2,383)
wait(t);
clickmouse(r2,383,1)
wait(t);
movemouse(r2,377);
wait(t);
clickmouse(r2,377,0);
wait(t);
movemouse(r2,407)
wait(t);
clickmouse(r2,407,1)
wait(t);
movemouse(r2,414);
wait(t);
clickmouse(r2,414,0);
wait(t);
movemouse(r2,406)
wait(t);
clickmouse(r2,406,1)

wait(t)
movemouse(r3,201);
wait(t);
clickmouse(r3,201,0);
wait(t);
movemouse(r3,240);
wait(t);
clickmouse(r3,240,1);
wait(t);
clickmouse(r3,240,0);
wait(t);
movemouse(r3,279);
wait(t);
clickmouse(r3,279,1);
wait(t);
movemouse(r3,272);
wait(t);
clickmouse(r3,272,0);
wait(t);
movemouse(r3,312)
wait(t);
clickmouse(r3,312,1)
wait(t);
movemouse(r3,306);
wait(t);
clickmouse(r3,306,0);
wait(t);
movemouse(r3,346)
wait(t);
clickmouse(r3,343,1)
wait(t);
movemouse(r3,343);
wait(t);
clickmouse(r3,343,0);
wait(t);
movemouse(r3,383)
wait(t);
clickmouse(r3,383,1)
wait(t);
movemouse(r3,377);
wait(t);
clickmouse(r3,377,0);
wait(t);
movemouse(r3,407)
wait(t);
clickmouse(r3,407,1)
wait(t);
movemouse(r3,414);
wait(t);
clickmouse(r3,414,0);
wait(t);
movemouse(r3,406)
wait(t);
clickmouse(r3,406,1)

wait(t)
movemouse(r4,201);
wait(t);
clickmouse(r4,201,0);
wait(t);
movemouse(r4,240);
wait(t);
clickmouse(r4,240,1);
wait(t);
clickmouse(r4,240,0);
wait(t);
movemouse(r4,279);
wait(t);
clickmouse(r4,279,1);
wait(t);
movemouse(r4,272);
wait(t);
clickmouse(r4,272,0);
wait(t);
movemouse(r4,312)
wait(t);
clickmouse(r4,312,1)
wait(t);
movemouse(r4,306);
wait(t);
clickmouse(r4,306,0);
wait(t);
movemouse(r4,346)
wait(t);
clickmouse(r4,343,1)
wait(t);
movemouse(r4,343);
wait(t);
clickmouse(r4,343,0);
wait(t);
movemouse(r4,383)
wait(t);
clickmouse(r4,383,1)
wait(t);
movemouse(r4,377);
wait(t);
clickmouse(r4,377,0);
wait(t);
movemouse(r4,407)
wait(t);
clickmouse(r4,407,1)
wait(t);
movemouse(r4,414);
wait(t);
clickmouse(r4,414,0);
wait(t);
movemouse(r4,406)
wait(t);
clickmouse(r4,406,1)
wait(700)
end;
That's some really intensive blind clicks…..
Blind clicks are extremely discouraged and iirc there's a memb guide thread that blatantly states that their usage may result in instant rejection.


Overall, i can see a lot of efforts being put into the scripts, so keep it up!
However you will need to start scripting for official RS so that you can learn and demonstrate the include knowledge. Also better usage of TPA/ATPA, and moving away from DTM/basic color finding would be beneficial too.
Improve on your community involvement as well, help out others who have scripting troubles.

marc2333

2012-12-16 20:41:54

Thanks for your feedback, I will work on all this and apply again ! You can close my application, I'll be back in few weeks !

[XoL]

2012-12-16 21:22:46

No sorry as stated by riwu, also standards are bad! Please work on it.

I also think you are a little too inactive, srl members is a community rank we do everything for the community and that means you must be active for the community.

Gucci

2012-12-16 22:03:00

I'm going to have to agree with [XoL] and say no, there isn't a good enough use of the include and your standards are terrible, makes the code hard to read. The movemouse/clickmouse functions are things you should stay away from using in scripting for RS as they are extremely bot like.

btw [XoL] can't believe you changed your name haha

Daniel

2012-12-30 21:16:14

Hi marc2333,

It appears you won't be getting in this time. :( You may apply again in one month. :) Please take this time to take in what others have said, to improve yourself and your script, so that you can garner a perfect score the next time you apply! Also, please read the various threads around the SRL Tutorial Island section regarding SRL members and the application process. A neat example is my How to become an SRL Member thread.

Best of luck!