SRL Archive - RS3 Outdated / Broken Scripts

About

Currently very buggy, update coming in the near future
Due to Requests i decided to give this a go

This script is working for me mostly, so if you have problems, turn Debug to true in the settings and post whats going wrong for you and ill try to help fix.

If you spot any bugs please post em and I'll work on a fix ASAP, Thanks, screenshot and or detailed description appreciated

Needs testers to try it :)


Feature's

Anti-Ban

Some Fail Safe's

De Bugging Mode

Credits

Ashaman88 - Read through alot of his work to learn / used some methods

Benland100 - S.M.A.R.T and his mouse script

Flight - Mouse scripting

Please follow setup before starting.


SetUp

Minimize your EoC Action Bar for best results or if having problems

start standing on the exact tile in Pic, have enough coins for a long time

1. Graphic's setup as Simba recommends, RS zoomed out to max

2. Requires using S.M.A.R.T v8.0+ (MAY NOT COMPILE ON 7.2)

3. Fill in the script variables (has some preferences)

4. Start Here !!!!!!!!!!!!!:

Known Bugs

[LIST]
May not see judge till he moves if hes in rare spot
May fail to reset tile position if judge runs away on talk
[/LIST]

Things to Do

More Anti-Ban (can never have enough :))

Bring The Standard of Coding Up

Bank Pin and or Login Support

More Failsafe's and Lag Recovery

Add a Progress Report

Versions

[B]V1.0[/B] - Initial BETA Release
[B]V1.1[/B] - Added a few more filsafes and adjusted some variables may be more unstable than previous version
[B]V2.0[/B] - Major re-write, Added a progress report, best version yet
[B]V2.0a[/B] - Minor loop fix for 2.0
[B]V2.1[/B] - Different Judge Detection, More Optimization, Login Support, [B]If not working well use 2.0a[/B]

If You Do Not Read The SetUp Before Posting a Bug I Will Not Help You!

Proggy's

By: [B][PRO]metheus[/B]
=========RangeGuildTrainer============
=========Version: V2.1===============
Time Running: 6 Hours, 2 Minutes and 52 Seconds
Experience Earned: 126285
Experience/Hour: 20881
================================

By: [B]Deadlast[/B]
=========RangeGuildTrainer==============
=========Version: V2.1================
Time Running: 5 Hours, 53 Minutes and 10 Seconds
Experience Earned: 152002
Experience/Hour: 25823
==================================

This is good man. Keep it up, sorry I can't test it but I might one of these days.

From: Silentcore
This is good man. Keep it up, sorry I can't test it but I might one of these days.

NP silent, as usual, work in progress :) ty for the support

Edit- while now lying in bed having a good think, i can improve some of the logic a bit, i'll take a look tomorrow :D

I have been waiting for one of these scripts. I tried revising a dead one, furthest i got was compiling it and clicking the target; but it then got stuck from a misclick on the tree in the background.

Plan to use this soon!

From: MMOE
I have been waiting for one of these scripts. I tried revising a dead one, furthest i got was compiling it and clicking the target; but it then got stuck from a misclick on the tree in the background.

Plan to use this soon!

Be sure to post any errors or bugs you find, guna be doing more tweaking tomoz but always good to have as much data as possible :)

From: DannyRS
Be sure to post any errors or bugs you find, guna be doing more tweaking tomoz but always good to have as much data as possible :)

I will start it up right now. Seeing as I am at home, will switch it off before bed just in case any errors do happen.

Ok great, im going to try and fall asleep before you post anything otherwise i wont get any sleep tonight :) !

Welcome to RangeGuildTrainer V1.0 by Dannyrs
Starting in 3…
Starting in 2…
Starting in 1…
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge

It paid the judge, now it is standing there right clicking him.
When i self-fixed, the script shoots the targets very slowly. It must close down the score display box before shooting another instead of just spamming the target.

EDIT: Only shoots slowly when right click method is turned off. After the self-fix [Disabling smart, and clicking through the dialog box that says "you pay the judge and receive ten arrows"] The script then runs by itself for a while and then gets stuck again on the "TalkJudge" procedure.

Also, the script does not fully detect when the round is over, midway through a round, it right clicks the judge before the round is complete. The round still finished, but a fix would result in higher xp.

The error is most likely in the block of the script; I see it repeats the procedure of checking if the judge has been paid with all the "end else" and then looping to another check of the judge.

Procedure TalkJudge;
Var
  x,y,attempts: Integer;
  Check: Boolean;

Begin
  Check:=False;

  repeat begin
  if not(FindColorSpiralTolerance(x, y, 10092288, 402, 163, 465, 193, 20))then
    begin
      //Target View Screen
      Wait(563+Random(193));
      if(Debug)then begin Writeln('Talking To Judge'); end;
      DragMouseSpot(193, 191, 221, 253);
      If IsUpTextMultiCustom(['Talk-to','alk-to']) then
      begin
        ClickCurrent(False);
        if (ChooseOptionMulti(['Compete','ompete'])) then begin Check:=True; end
        else begin ShootTarget; Exit; end;
      end else
      begin
        Wait(163+Random(193));
        DragMouseSpot(185, 210, 207, 283);
        If IsUpTextMultiCustom(['Talk-to','alk-to']) then
        begin
          ClickCurrent(False);
          if (ChooseOptionMulti(['Compete','ompete'])) then begin Check:=True; end
          else begin ShootTarget; Exit; end;
        end else
        begin
          Wait(163+Random(193));
          DragMouseSpot(243, 168, 264, 228);
          If IsUpTextMultiCustom(['Talk-to','alk-to']) then
          begin
            ClickCurrent(False);
            if (ChooseOptionMulti(['Compete','ompete'])) then begin Check:=True; end
            else begin ShootTarget; Exit; end;
          end else
        begin
          Wait(163+Random(193));
          DragMouseSpot(256, 218, 277, 277);
          If IsUpTextMultiCustom(['Talk-to','alk-to']) then
          begin
            ClickCurrent(False);
            if (ChooseOptionMulti(['Compete','ompete'])) then begin Check:=True; end
            else begin ShootTarget; Exit; end;
          end;
        end;
        end;
      end;
    end else begin CloseTVUp; end;
    //Wait(563+Random(193));
  end; until (Check) or (FindDTMRotated(ChatDTM, x, y, 170, 380, 308, 480, -Pi/4, Pi/4, Pi/60, aFound))

  Check:=False;
  Wait(1463+Random(193));

  repeat begin
    LeftClickSpot(220, 450, 229, 464);
    Wait(563+Random(193));
    if (FindColorSpiralTolerance(x, y, 938795, 281, 466, 285, 470, 20)) then
    begin
      Check:=True;
    end;
  end; until (FindColorSpiralTolerance(x, y, 938795, 281, 466, 285, 470, 20))
End;              

Yea i recommend using right click method, as timing is much easier to do with that, i'll take a look tomorrow and see whats up, but i was running it fine before i uploaded it :(

Thanks for trying it anyway hopefully i can fix it soon

Edit - that procedure should just be to find the judge with istextup function, shouldent really cause problems or atleast not be the root of the problem, weird, i'll have a good look through it tomorrow though

From: DannyRS
Yea i recommend using right click method, as timing is much easier to do with that, i'll take a look tomorrow and see whats up, but i was running it fine before i uploaded it :(

Thanks for trying it anyway hopefully i can fix it soon

Edit - that procedure should just be to find the judge with istextup function, shouldent really cause problems or atleast not be the root of the problem, weird, i'll have a good look through it tomorrow though

Then again, i did change "Equip arrows before shooting" to false. I'm not sure if that is the source of the problem? I will go back and check if anything changes.

EDIT: Problem fixed, i changed the equip arrows to true. This automatically closes the dialog box and continues the script. Works perfect now; with the exception of not fully knowing when the round is ended. Not a major concern as so far it is running great.
The main problem was most likely just the dialog box? Somehow it affected the script from continuing. If the "equip arrows before shooting" is set to false, maybe a procedure could close the dialog box to continue the script.

From: MMOE
Then again, i did change "Equip arrows before shooting" to false. I'm not sure if that is the source of the problem? I will go back and check if anything changes.

Shouldent be, i added the option to actually use those arrows after lol, are you using the lowest graphics stuff and are you definetly zoomed out to the max, EoC actionbar minimzed etc?

And are you in the exact spot in the picture? The judge normally to the left or above you?

Wow cant believe that causes a problem rofl,

I musta messed up the copy pasting somewhere awfully

great job on finding the cause though, now i can easily fix this :)

And i'll work on perfecting the round detection logic to increase xp/ph :) i started doing it but got too tired (and still cant actually sleep >.< damn my insomnia)

From: DannyRS
Shouldent be, i added the option to actually use those arrows after lol, are you using the lowest graphics stuff and are you definetly zoomed out to the max, EoC actionbar minimzed etc?

And are you in the exact spot in the picture? The judge normally to the left or above you?

Ha unlike most people, i did read the OP. Everything was setup correctly. It runs great now. It was just the dialog box. I'm trying to add a progress report from Ashaman's scripting.
ALL CREDIT TO ASHAMAN! I am just moving some of his script into yours.

Procedure PrintSmart;
Begin
  SMART_ClearCanvas;
  SMART_DrawText(30,252,StatChars, '========DannyRSRangeGuild=========', 65280);
  SMART_DrawText(30,264,StatChars, '==========Version: '+ScriptVersion+'===========', 65280);
  SMART_DrawText(30,275,StatChars, 'Time Running: ' + TimeRunning, 65280);
  SMART_DrawText(30,288,StatChars, 'Experience Earned: ' + ToStr(XP), 65280);
  SMART_DrawText(30,302,StatChars, 'Experience/Hour: ' + ToStr(XPH), 65280);
  SMART_DrawText(30,314,StatChars, '==============================', 65280);
End;

Procedure ProgressReport;
Var
  TTB: Integer;
Begin

  TTB := GetTimeRunning;

  XP := (GetXPBarTotal - StartingExperience);
  XPH := Round(XP * (3600.0 / (GetTimeRunning / 1000.0)));
  MarkTime(Timeout);

  Writeln('========DannyRSRangeGuild=========');
  Writeln('==========Version: '+ScriptVersion+'==========');
  Writeln('Time Running: ' + TimeRunning);
  Writeln('Experience Earned: ' + ToStr(XP));
  Writeln('Experience/Hour: ' + ToStr(XPH));
  Writeln('=================================');

  PrintSmart;
End;                    

I got it to compile with the progress report, i just need to alter a few more things to get it all to tie in. I will finish this later on though i have finals tomorrow and need to start cramming D:

Final thoughts: Works great, proggy would be nice to show off your script, consider adding the six hour fix to avoid shutdown. I didn't see the sixhourfix in the setup procedure.

EDIT: Simple addition for the SixHourFix to get some long ass proggies when I incorporate the progress report system.

Procedure Setup;
var loggedingame: Boolean;
var x,y: Integer;
Begin
  {$IFDEF SIMBAMAJOR980}
    SMART_SERVER := 10;
    SMART_MEMBERS := TRUE;
    SMART_SIGNED := TRUE;
    SMART_SUPERDETAIL := FALSE;
  {$ELSE}
    SRL_SIXHOURFIX := TRUE;     //ADDED HERE
    SMART_FIXSPEED := TRUE;
  {$ENDIF}             

EDIT2:
Got stuck after a possible misclick. Returned to computer and i wasn't at the targets. No problems in the debug, only fix for this would be a failsafe to check position.

I'll have to add login and bank pin support before the 6hour fix, i can add the progress report for you fairly easy, so no worries :), i know how im going to fix that missclick too :)

Ill look at fixing this today

From: DannyRS
I'll have to add login and bank pin support before the 6hour fix, i can add the progress report for you fairly easy, so no worries :), i know how im going to fix that missclick too :)

Ill look at fixing this today

whooh! 99 range here i come :D

working on V2.0 now, majour re-write, think i have it flawless now, just testing before upload :)

Updated, V2.0 - Major re-write, Added a progress report, best version yet,

setup and spot remain the same

Thanks for the script! Does this do both activities?

From: Voyaging
Thanks for the script! Does this do both activities?

only targets atm, whats the other activity?

From: DannyRS
Updated, V2.0 - Major re-write, Added a progress report, best version yet,

setup and spot remain the same

Gonna go fire this back up :D

From: MMOE
Gonna go fire this back up :D

Let me know how it does :)

It shut down two hours in :(
I probably should have turned debug on :P
When i logged in, i was in the correct spot still, everything was okay. I guess to many errors made it fail? Or maybe it couldn't find the judge?

The two other bots there were still running when i logged back on, and normally that place is empty :P I'm assuming they were using your script! So I will give it another go with debug on.

From: MMOE
It shut down two hours in :(
I probably should have turned debug on :P
When i logged in, i was in the correct spot still, everything was okay. I guess to many errors made it fail? Or maybe it couldn't find the judge?

The two other bots there were still running when i logged back on, and normally that place is empty :P I'm assuming they were using your script! So I will give it another go with debug on.

Aww darn, must be a pesky Exit; in a place no longer needed, i shall hunt him down :)

EDIT- couldent see anything, as a temp fix change bottom of script from

begin
  Setup;
  ActivateClient;
  ClearDebug;
  MainLoop;
  LogOutGame;
end.

to

begin
  Setup;
  ActivateClient;
  ClearDebug;
  repeat begin MainLoop; end;
  until keepalive;
  LogOutGame;
end.

and line 8 to

stop, keepalive: Boolean;

running this now. First comments:
1) alot of unused varibles but I think this is just because your in the middle of some updates
2)Possible addition could be an option to not equip the arrows (would save time, would require having 1k or so arrows already equiped
3)Good script, Noticed your releasing a lot of scripts (did ashman give u his script making script? ;)) keep up the good work!

From: The Killer
running this now. First comments:
1) alot of unused varibles but I think this is just because your in the middle of some updates
2)Possible addition could be an option to not equip the arrows (would save time, would require having 1k or so arrows already equiped
3)Good script, Noticed your releasing a lot of scripts (did ashman give u his script making script? ;)) keep up the good work!

There should be a variable at the top for the arrow equpping! :)

I'm really enjoying the script making, so as one reaches completion the next begins!

The variables are because i copy / paste my functions alot and modify them, next release i'll remove them :)

From: DannyRS
There should be a variable at the top for the arrow equpping! :)

I'm really enjoying the script making, so as one reaches completion the next begins!

The variables are because i copy / paste my functions alot and modify them, next release i'll remove them :)

ok :)
and yeah just spotted the const…..
feeling dull now, o well :P

From: The Killer
ok :)
and yeah just spotted the const…..
feeling dull now, o well :P

kinda forgot about this script a bit :)

is it still working ok? i guess somethings going right because the latest version has like 50 views or something and nobody complained

I have had it running for about 20 minutes and its been going well. I will keep an eye on it and let you know how it goes!

nice script btw :D

Update: Every now and then it will get stuck on the target view screen and the debug just says "waiting for arrow to hit". I just manually exited out and it ran well until it happens again. Also, if on a crowded world and the right click brings up a bunch of player names, it sits for a a couple of minutes but sorts itself out. Other than those two things its been running pretty well.

From: garyman
I have had it running for about 20 minutes and its been going well. I will keep an eye on it and let you know how it goes!

nice script btw :D

Update: Every now and then it will get stuck on the target view screen and the debug just says "waiting for arrow to hit". I just manually exited out and it ran well until it happens again. Also, if on a crowded world and the right click brings up a bunch of player names, it sits for a a couple of minutes but sorts itself out. Other than those two things its been running pretty well.

Sounds like a lag / delay issue, and as for the crowded worlds, its causing too much calculation from the ChoseOption include, so i would find an empty world for best xp, maybe i can update the efficiency of the waiting for arrow to hit, so that its faster xp, thanks alot for the feedback and test :),

Glad its actually running ok and the failsafes are working as intended :)

how much exp/hour can i expect to get from this @ 80 range?

Just started the script it loads up to were it inputs the username and just does nothing. Followed your setup guide just is not working for me.

Just started the script it loads up to were it inputs the username and just does nothing. Followed your setup guide just is not working for me.

I had this issue for a bit. I start the script then disable SMART, log in and stop the script. Then i walk around just a little bit, then go back to the start spot, re-enable SMART, and hit the play button and it goes.

That Target arrow screen (for me at least) happens pretty frequently.This will be a great script once that gets handled. you deserve the Promising Newcomer cup for sure! thanks for the great script and glad I could help! :D

Thanks for the response working nicely great script.

Going to go start this and let you know how it goes :D

EDIT: Having issues. I got logged and then the debug says the script is still looking for the judge.

EDIT: Having issues. I got logged and then the debug says the script is still looking for the judge

Did the ashaman proggy show up when you tried to run this?
try what i suggested a few posts up and see if it starts correctly that way.

Danny- If I just let it sit it runs perfect, If i try and watch the client while its running it gets stuck at the Target View Screen. I have no idea why this is.

From: garyman
Did the ashaman proggy show up when you tried to run this?
try what i suggested a few posts up and see if it starts correctly that way.

Danny- If I just let it sit it runs perfect, If i try and watch the client while its running it gets stuck at the Target View Screen. I have no idea why this is.

Ha the ashaman doesn't go away for me until i close the client and open a new one. I was doing agility before i went to range guild. The first time i used the script, using agility prior to, did not affect the script.

I'll take a look at a better way to detect target screen when im home,

As for getting logged, you'll have to add your own log in, i'll add it sometime, but its low prio atm :D

This script is exactly what I have been looking for. Thanks DannyRS. It's working perfectly for me.

From: podmore999
This script is exactly what I have been looking for. Thanks DannyRS. It's working perfectly for me.

glad to hear its what you needed, like everything i do, its going to be improved as i discover better ways to accomplish things :)

Will test it out! Does anyone know the xp rates at 90 range with decent equipment?

From: Rincewind
Will test it out! Does anyone know the xp rates at 90 range with decent equipment?

no idea, it varies greatly due to missing/low score shots

Just tested for 2 hours.. What a brilliant script.

I have gotten 99 range twice with range guild scripts here..
But none of the previous scripts seemed as smooth.

Very nice job man.

I'm trying to make my computer lagg so i can find that bug that makes you walk out of the competition area.

Seems bug free atm though.

From: Peanuts
Just tested for 2 hours.. What a brilliant script.

I have gotten 99 range twice with range guild scripts here..
But none of the previous scripts seemed as smooth.

Very nice job man.

I'm trying to make my computer lagg so i can find that bug that makes you walk out of the competition area.

Seems bug free atm though.

latest version should have fixed that bug :)

From: garyman
. Danny- If I just let it sit it runs perfect, If i try and watch the client while its running it gets stuck at the Target View Screen. I have no idea why this is.

Yeah I am having the same problem. I thought maybe I was just lagging too bad on my laptop so I switched over to my desktop, but the same thing is happening. What a weird bug

From: Ann_arbor
Yeah I am having the same problem. I thought maybe I was just lagging too bad on my laptop so I switched over to my desktop, but the same thing is happening. What a weird bug

Indeed very strange, as two people have this same issue, i'm omw now to see if i can re-create / better optimize the detection :)

From: Ann_arbor
Yeah I am having the same problem. I thought maybe I was just lagging too bad on my laptop so I switched over to my desktop, but the same thing is happening. What a weird bug

From: garyman

Danny- If I just let it sit it runs perfect, If i try and watch the client while its running it gets stuck at the Target View Screen. I have no idea why this is.

Think i Found The Problem, 2.0a Fixed It? and does everything else still work

Looks like this script is receiving high praise, I look forward to trying it out :spot:

[LEFT]Oh, and keep up the good work danny. You're on Fire![/LEFT]

Wow Danny, any issue I had with this the first time through is gone. After trying to recreate the issue with the target view screen, I could get it to stop, but i see you added a failsafe to exit out, which works great!! Excellent script man Keep up the great work!

From: garyman
Wow Danny, any issue I had with this the first time through is gone. After trying to recreate the issue with the target view screen, I could get it to stop, but i see you added a failsafe to exit out, which works great!! Excellent script man Keep up the great work!

yes i found a bad loop, that if you minimized smart or lost cursor would catch you forever,

this is an early script, i'm better at handling this now, hopefully at some point, due to this being such a popular thread of mine, i will get a chance to re-write this and make it much better, but its hopefully decently functional atm :)

From: mr. pali
Looks like this script is receiving high praise, I look forward to trying it out :spot:

[LEFT]Oh, and keep up the good work danny. You're on Fire![/LEFT]

trying my best to give the people what they want :) thanks for the support!

Hey Danny. I was running this last night and for the 10mins I spent watching it, it seemed to run pretty damn good. I couldn't get you a proggy due to my laptop restarting to install new updates overnight.

But all in all it's working like a charm!

Thanks broski!

From: Ann_arbor
Hey Danny. I was running this last night and for the 10mins I spent watching it, it seemed to run pretty damn good. I couldn't get you a proggy due to my laptop restarting to install new updates overnight.

But all in all it's working like a charm!

Thanks broski!

Awesome to know its working for you :)

Two very minor things.

After about an hour, the angle of my screen will move and my screen will face northwest, thus eliminating the view of the targets (I think this may have to do with the script not being able to find the judge)

One other minor problem is that the proggy doesn't work. It shows how long the script has ran, but the exp calculations remain at 0.

These are just minor problems. I dont mind babysitting the script a little, especially since I'm using this for my main. The proggy doesn't really matter either, I can do that manually. Just wanted to point these out for ya.

From: Ann_arbor
Two very minor things.

After about an hour, the angle of my screen will move and my screen will face northwest, thus eliminating the view of the targets (I think this may have to do with the script not being able to find the judge)

One other minor problem is that the proggy doesn't work. It shows how long the script has ran, but the exp calculations remain at 0.

These are just minor problems. I dont mind babysitting the script a little, especially since I'm using this for my main. The proggy doesn't really matter either, I can do that manually. Just wanted to point these out for ya.

i can fix the camera thing at some point maybe,

the proggy is due to you needing to reset your XP counter ingame and set it to range :)

Works great, what's the average xp/h? I'm getting 24k/h

From: Bwpz
Works great, what's the average xp/h? I'm getting 24k/h

Glad its working for you, honestly the XP varies so much on level and gear, i cant give you an average, but its a cheap reliable way to level range up :)

From: DannyRS
Glad its working for you, honestly the XP varies so much on level and gear, i cant give you an average, but its a cheap reliable way to level range up :)

Yeah, definitely better than killing cows xD

The better gear you wear, the more exp? I'll get decked out lmao.

From: Bwpz
Yeah, definitely better than killing cows xD

The better gear you wear, the more exp? I'll get decked out lmao.

Actually no idea in EoC, used to be your chance of hitting the better score on the target was base off your range bonus, but in EoC thats some kind of weakness system?

So i have no idea, but cant hurt to wear the best gear you can / have just incase :)

Have you ever tried to implement the SixHourFix? It would be awesome if you could do that! get some real nice proggies :D

From: garyman
Have you ever tried to implement the SixHourFix? It would be awesome if you could do that! get some real nice proggies :D

Going to add this soon :) if you learn some basic simba scripting you can add it yourself currently, really easy, i just never bothered but i'll get to it :)

Ran it overnight (not sure how long it went for, woke up in the middle of the night and changed scripts). Got me from 40-57 Ranged though.

From: Bwpz
Ran it overnight (not sure how long it went for, woke up in the middle of the night and changed scripts). Got me from 40-57 Ranged though.

Awesome! :)

Glad its going to good use

Hey Danny, thanks for the script.

I've had some good runs I just keep forgetting to copy+paste reports.

Very rarely it seems to miss-click the target and walk to an area around the targets. I'll try to get a screenshot of it.

From: MMOE
Welcome to RangeGuildTrainer V1.0 by Dannyrs
Starting in 3…
Starting in 2…
Starting in 1…
Talking To Judge
Talking To Judge
Talking To Judge
Talking To Judge

Procedure TalkJudge;
Var
  x,y,attempts: Integer;
  Check: Boolean;

Begin
  Check:=False;
...  

From: DannyRS
glad to hear its what you needed, like everything i do, its going to be improved as i discover better ways to accomplish things :)

If you would like a coding suggestion, whenever you see a long line of nested repetitive ifs (or repetition in general), it means its a good area for refactoring. Take your TalkJudge Procedure, it can be changed to this with the exact same effect:

Procedure TalkJudge;
Var
  x,y,attempts: Integer;
  Check: Boolean;
  positions: T2DIntegerArray;
  positionsLength : Integer;
  Index: Integer;

Begin
  Check:=False;

  positionsLength := 10;
  SetLength(positions,positionsLength);
  positions := [
    TIntegerArray([217, 201, 228, 259]),
    TIntegerArray([252, 225, 261, 284]),
    TIntegerArray([233, 175, 237, 228]),
    TIntegerArray([256, 189, 270, 250]),
    TIntegerArray([293, 208, 301, 240]),
    TIntegerArray([340, 228, 344, 291]),
    TIntegerArray([335, 145, 340, 198]),
    TIntegerArray([378, 225, 382, 240]),
    TIntegerArray([278, 175, 282, 214]),
    TIntegerArray([305, 180, 308, 229])
  ];


  repeat begin
  if not(FindColorSpiralTolerance(x, y, 10092288, 402, 163, 465, 193, 20))then
    begin
      //Target View Screen
      Wait(563+Random(193));
      if(Debug)then begin Writeln('Talking To Judge'); end;


      //Reduced ifs to 10 lines
      for Index := 0 to (positionsLength-1) do
        begin
          DragMouseSpot(positions[Index][0], positions[Index][1], positions[Index][2], positions[Index][3]);
          If IsUpTextMultiCustom(['Talk-to','alk-to']) then
            begin
              ClickCurrent(False);
              if (ChooseOptionMulti(['Compete','ompete'])) then begin Check:=True; end
              else begin Exit; Break; end;
            end
        end;
      //end of changes


    end else begin CloseTVUp; end;
    //Wait(563+Random(193));      
...        
 

:D
Hope to see more!

From: tekgen


Very rarely it seems to miss-click the target and walk to an area around the targets. I'll try to get a screenshot of it.

If you would like a coding suggestion, whenever you see a long line of nested repetitive ifs (or repetition in general), it means its a good area for refactoring.

If its miss-clicking targets, your not zoomed out to the max in RS most likely? i cant make it missclick personally

Thanks for the tip, i just slightly modified the judge detection to use TPA's, so there's barely any repetitive If's now anyway :)

UPDATED to 2.1, added TPA for judge detection, Log-in Support, slight optimization tweaks

Can someone test the log-in support for me? if it doesn't work go back to 2.0a till i fix it :)

Log in went very smooth! ill keep it running to make sure six hour fix works. I tried to fix it myself earlier but i had some compiling errors so im glad you got this released :D
Keep up the awesome work!!

From: garyman
Log in went very smooth! ill keep it running to make sure six hour fix works. I tried to fix it myself earlier but i had some compiling errors so im glad you got this released :D
Keep up the awesome work!!

Thanks for the support!

I took the time working on it to mess with a bunch of stuff lol, i tried to improve it, but making that many changes, i could of broke something, so if anyone can find any bugs in long proggies, let me know! :)

And if 2.1 is not working for you, try 2.0a :)

The script misclicked and it logged out and when trying to log back in it clicked on the members tab and started opening internet tabs for that. Idk if this is an issue with the script or if its a client bug? Other than this the scripts still running well.

From: garyman
The script misclicked and it logged out and when trying to log back in it clicked on the members tab and started opening internet tabs for that. Idk if this is an issue with the script or if its a client bug? Other than this the scripts still running well.

Seems to be something weird going on with the way i used the login include,

Where did it missclick? When loggin in or when running shooting the targets?, if it missclicked while playing, where did it click?

Trying this now :)

From: [PRO]metheus
Trying this now :)

Leme know how it goes :)

If 2.1 is broken try previous version

Where did it missclick? When loggin in or when running shooting the targets?, if it missclicked while playing, where did it click?

the script misclicked so I moved out of the target range over by the shed (on the opposite side of the range) which caused me to log out. Then it clicked on the members tab and the issue I explained happened.

Using 2.1, here's an hour proggy:

=========RangeGuildTrainer==============
=========Version: V2.1==================
Time Running: 1 Hours, 59 Seconds
Experience Earned: 21970
Experience/Hour: 21612
========================================

It's still running right now. It works really good! :D

From: [PRO]metheus
Using 2.1, here's an hour proggy:


It's still running right now. It works really good! :D

Awesome, glad 2.1 works good, thanks for sharing your proggy I'll add to OP

=========RangeGuildTrainer==============
=========Version: V2.1==================
Time Running: 6 Hours, 2 Minutes and 52 Seconds
Experience Earned: 126285
Experience/Hour: 20881
========================================

Another proggy. Didn't work after the 6 hour thing, though

From: [PRO]metheus
Another proggy. Didn't work after the 6 hour thing, though

Sweet, aww wonder whats up with the six hour fix, i'll have to try and find it :)

From: garyman
the script misclicked so I moved out of the target range over by the shed (on the opposite side of the range) which caused me to log out. Then it clicked on the members tab and the issue I explained happened.

Yeah this is the same thing that happens for me. I'm all the way zoomed-out. I'm thinking the pointer is just a couple pixels off or something so it walks beyond the targets to the shed. Or after you follow the judge around a bit, it isn't the right position so you walk (have never seen it when it happens so I don't know). This can happen in a few minutes or , last night, after 4 hours.

As for the internet thing, when it goes back to the lobby screen (after inactivity near sheds I guess) , it doesn't detect its not in game and it keeps clicking the jagex url which makes internet tabs popup.

From: tekgen
Yeah this is the same thing that happens for me. I'm all the way zoomed-out. I'm thinking the pointer is just a couple pixels off or something so it walks beyond the targets to the shed. Or after you follow the judge around a bit, it isn't the right position so you walk (have never seen it when it happens so I don't know). This can happen in a few minutes or , last night, after 4 hours.

As for the internet thing, when it goes back to the lobby screen (after inactivity near sheds I guess) , it doesn't detect its not in game and it keeps clicking the jagex url which makes internet tabs popup.

first off, wow joined in 2007 and 7 posts :)

I'm trying to get a better target detection TPA working, in the mean time as a hopefully quick fix (will decrease anti-ban so do at own risk)

Can you try v2.1 and change:

Lines 368 and 369

From:
xpos:=RandomRange(x-4,x+4);
ypos:=RandomRange(y-4,y+4);

To:
xpos:=RandomRange(x-1,x+1);
ypos:=RandomRange(y-1,y+1);

Lines 389 and 390

From:
xpos:=RandomRange(x-4,x+4);
ypos:=RandomRange(y-4,y+4);

To:
xpos:=RandomRange(x-1,x+1);
ypos:=RandomRange(y-1,y+1);

I'm also working on fixing the Log-in thing so it will log you back in :)

Great script
Got to 69 range :P

=========RangeGuildTrainer==============
=========Version: V2.1==================
Time Running: 5 Hours, 53 Minutes and 10 Seconds
Experience Earned: 152002
Experience/Hour: 25823
========================================

From: Deadlast
Great script
Got to 69 range :P

=========RangeGuildTrainer==============
=========Version: V2.1==================
Time Running: 5 Hours, 53 Minutes and 10 Seconds
Experience Earned: 152002
Experience/Hour: 25823
========================================

Sweet proggy, glad it works well for you :)

Just looked at your code, and I have some suggestions.
1. You can use ClickNorth(SRL_ANGLE_HIGH); to reset the map. It will click on the compass, make it to north then move the camera up.
2. Having LeftClickSpot and RightClickSpot functions is not needed. You could use a plus parameter which will determine its type. Also I dont understand why you need those functions. That FastClick() is any better than our common ClickMouse2()?
3. At the LoginHandler part you can just use LoginPlayer when its in lobby, it will click the 'click to play' for you. LoginPlayer is a very smart function, knows everything.
4. The same thing to Logout. It returns true if LoggedIn = false so you could just use it in a repeat loop to make sure it does it job.
5. You should make a procedure something like Debug(Text: String) which will do the Writeln(Text) part for you if debug is on. Very useful.
The script is nearly a week old and you are getting better and better so maybe you already know these, but I thought I would share these with you.
Anyways grats on Members! :)

From: Shatterhand
Just looked at your code, and I have some suggestions.
1. You can use ClickNorth(SRL_ANGLE_HIGH); to reset the map. It will click on the compass, make it to north then move the camera up.
2. Having LeftClickSpot and RightClickSpot functions is not needed. You could use a plus parameter which will determine its type. Also I dont understand why you need those functions. That FastClick() is any better than our common ClickMouse2()?
3. At the LoginHandler part you can just use LoginPlayer when its in lobby, it will click the 'click to play' for you. LoginPlayer is a very smart function, knows everything.
4. The same thing to Logout. It returns true if LoggedIn = false so you could just use it in a repeat loop to make sure it does it job.
5. You should make a procedure something like Debug(Text: String) which will do the Writeln(Text) part for you if debug is on. Very useful.
The script is nearly a week old and you are getting better and better so maybe you already know these, but I thought I would share these with you.
Anyways grats on Members! :)

Thanks for taking a look Shatter!

1. I normaly use the clicknorth thing, but theres a bug in RS that if the target screen is open, and you right click the compass, you cant use the option and it causes the script to get stuck, so i neglected it here :P,
2. My left and right click things are for neatness, i dont understand what you mean with the better way to put that, the fastclick, part of flights custom include stuff for mouse and keyboard if i remember correctly, so there must have been something making it better, not sure,
3. I know the loginplayer thing was overhandled, but it was grabbed from my soulwars script, which needed to 100% select the world picked, going to try the regular way next release,
4. Not sure what you mean, my logout thing or the include?
5. Wow I'm stupid, this is a great tip thanks, will be great not copying the full if statement everytime :) just completely slipped my mind

Thanks so much for the tips and grats, really appreciated ;) <3

Hey Danny I just chose this thread to say congrats on member!! :D keep up the great scripts!!!

From: garyman
Hey Danny I just chose this thread to say congrats on member!! :D keep up the great scripts!!!

Thanks alot gary ;)

Im having a problem, most of the time, not all of the time, it just stops either after checking to see if needing to compete, or right after the arrows are equipped. Do you know the problem?

Gets stuck at "wait arrow loop begin".

From: shadeyyy
Gets stuck at "wait arrow loop begin".

Are your graphics correct?, its working for others

Gets stuck at "wait arrow loop begin".

Just used this today and it worked fine. Make sure brightness is all the way to the right.

From: garyman
Just used this today and it worked fine. Make sure brightness is all the way to the right.

Thanks for the confirm that its on his end not mine :p ;)

Also used this today for an hour or so, working great good job Danny

From: Gucci
Also used this today for an hour or so, working great good job Danny

Good Good, Thanks :p

This is starting to show its age a tad as i have learned so much since then, but sometimes the old ways are the best i suppose ;)

Hey guys what you/we get hour ? and when is the next double xp

From: srhrich
Hey guys what you/we get hour ? and when is the next double xp

No idea when the next double XP is, and I have no idea what XP this gets / Hour

Been a long time since this was made, maybe some things are slightly broken, I have no idea

The script its nice but i only get like 10k per hour wtf its nothing plzz fix the buggs in north and sometimes its attacking

From: srhrich
The script its nice but i only get like 10k per hour wtf its nothing plzz fix the buggs in north and sometimes its attacking

you need to translate a real explanation of whats going on so I can fix it, and make sure you setup your graphics correctly as mine are in the OP

From: DannyRS
you need to translate a real explanation of whats going on so I can fix it, and make sure you setup your graphics correctly as mine are in the OP

I'll test it later and give you feedback

i have made sure the setup is correct but for some reason he shots at the target the competition judge says you cant fire unless you compete but then he fires at the target again?
it will do this a few times then it will pay and then in a few minutes again it will stop and try clicking the target without paying?
if anyone knows or has an idea how to fix this it will be much appreciated.

From: halestorm1234
i have made sure the setup is correct but for some reason he shots at the target the competition judge says you cant fire unless you compete but then he fires at the target again?
it will do this a few times then it will pay and then in a few minutes again it will stop and try clicking the target without paying?
if anyone knows or has an idea how to fix this it will be much appreciated.

Clearly this needs some fixing, I lack time to do it atm tho, I will update when I have the time

You need to fix the best one and the higgest xp and help me with the script the mouse go faster and the xp plzz :D

I will try this out tonight, im using your fletching script at the moment, its very good:)

From: mikeallen
I will try this out tonight, im using your fletching script at the moment, its very good:)

This is apparently really buggy atm, I'll re-write when I have time :(

The fletch script? Did 10k yew shieldbows (u) today, no probs. About to string them all, before choosing lagsafemode I would randomly walk outside CW dosent happen anymore though.

From: mikeallen
The fletch script? Did 10k yew shieldbows (u) today, no probs. About to string them all, before choosing lagsafemode I would randomly walk outside CW dosent happen anymore though.

The RG, not fletcher :)

Ok, wish you luck then, might wait a while :)

is this worth doing to 99? I works like a charm but I only get 26k an hour at 72 range is that normal?

From: tristen8878
is this worth doing to 99? I works like a charm but I only get 26k an hour at 72 range is that normal?

Defo not worth going to 99 :p

Thought this script was bugged and broken, does it seem sluggish and slow to you while running? if it's too bad I'll probably just delete it as I'm too busy atm to re-write it,

I made this one shortly after I learned to script so it's a messy one :p

Very nice script, got me a few levels. Thanks!

From: DannyRS
Defo not worth going to 99 :p

Thought this script was bugged and broken, does it seem sluggish and slow to you while running? if it's too bad I'll probably just delete it as I'm too busy atm to re-write it,

I made this one shortly after I learned to script so it's a messy one :p

Ye the script works no problem been running for 5 hours always clicks the target no problem. Not sloppy at all defo better than most injection scripts.

From: tristen8878
Ye the script works no problem been running for 5 hours always clicks the target no problem. Not sloppy at all defo better than most injection scripts.

Wow, guess all the people that had problems on the page before just didn't set it up correctly lol,

I'd guess the XP in EoC is crap because people probably pull 200k/h with training legit, I don't know what XP/h it can get but I'd say it's more for leveling 50-70 just for the dhide or something so you can move on ;) but it's fairly AFK able so why not :p

ran this last night got me from 72-74 range when I woke up lord behold my toon was logged out at the display page where you hit play it had hit the fourth droparrow down or something like that and was spam clicking the 'here' button highlighted in blue it opens up an internet window directing it to runescape omg there was millions of them opened closed it restarted computer ran slow for a very long time even after running cc cleaner i think your script tried to crash my computer

From: cradlefatal
ran this last night got me from 72-74 range when I woke up lord behold my toon was logged out at the display page where you hit play it had hit the fourth droparrow down or something like that and was spam clicking the 'here' button highlighted in blue it opens up an internet window directing it to runescape omg there was millions of them opened closed it restarted computer ran slow for a very long time even after running cc cleaner i think your script tried to crash my computer

This is a bug with the 6hour restart login with SRL as far as I know, nobody can figure out why it happens, not really much I can do about it :/ you can try channging the login procedure a bit

Entered name/pass as it said to type in and now it doesn't do anything.

From: Kuriamas
Entered name/pass as it said to type in and now it doesn't do anything.

Try starting while logged in?

Ever thought of making one for 07scape? would be a huge hit!

From: TJmidd
Ever thought of making one for 07scape? would be a huge hit!

When I can be bothered to get 50 range so I can get in to script it, I'll lrobably make one ;)

"[Error] Includes\SRL\SRL\misc\SmartParams.Simba(78:8): Unknown identifier 'RSReady' at line 77"

I got this after I changed the {DEFINE SMART} to {DEFINE SMART8}

From: Vamp08
"[Error] Includes\SRL\SRL\misc\SmartParams.Simba(78:8): Unknown identifier 'RSReady' at line 77"

I got this after I changed the {DEFINE SMART} to {DEFINE SMART8}

Hmm, RSReady is in login.simba, reinstall srl / force update maybe?

Hey Danny, the script worked flawlessly for me. I just had to define smart as smart8. Just a tip, you don't need to be 50 to run the script, just get to 34 range and pop a super ranging potion before entering the guild. (40 to enter guild) This is a perfect way to level range from 34 to 60 AFK. Thanks!

From: Preacher
Hey Danny, the script worked flawlessly for me. I just had to define smart as smart8. Just a tip, you don't need to be 50 to run the script, just get to 34 range and pop a super ranging potion before entering the guild. (40 to enter guild) This is a perfect way to level range from 34 to 60 AFK. Thanks!

Ah nice tip, I wish I had 50 range on OSR to release one there

From: TJmidd
Ever thought of making one for 07scape? would be a huge hit!

try mine :) very close to flawless! working on an OSR revamp version

The script work good but i have problem i dont sure what i gonna do but you know its go to memembership and then its only lik "CLICK HERE" and then its lagging my laptop :( TELL ME WHAT I CAN DO :)

It's still working for me. I had like a 14hr proggy to give you this morning but my laptop restarted to install updates :duh:
Anyway, great script. I'll continue to work on getting you a nice proggy. I'm averaging about 27k xp/hr.

Great script, but has anyone done the math on coin per Xp? is it positive or negative?

SmartParams.Simba(282:145): Invalid number of parameters at line 281
Compiling failed.

need for old rs

From: irmao0
need for old rs

There is one for old RS. http://villavu.com/forum/forumdisplay.php?f=537

Thank you for responding so quickly Sir, I appriciate your life very much !!!! I tried this one .. says Wielding arrows and dosent do anything just stays there