SRL Archive - RS3 Outdated / Broken Scripts

Version := 1.0 Beta
Creator := Dudesareus

Info————————————————————-
This is my first fisher, It fishes at Karamja and sell the lobsters at the general shop.

Instructions——————————————————
Start at the fishing dock. Please make sure the money is in your second inventory slot and to pick the road color on Karamja Island. Look below.


Credits———————————————————–
WT-Fakawi for Find Fast Randoms!

Known Bugs/Issues————————————————
Sometimes it takes a while for the randoms. I'm still working on it so don't get mad at me if you die or get teleported.

Have fun and don't get banned!

I tested this one before I release so it DOES work!

/========================\
|  Karamja Lobby Fisher  |
|       And Seller       |
|     By Dudesareus!     |
\========================/
|>Loads Fished : 1
|>Lobs  Fished : 26
|>Time Running : 12 Minutes, and 43 Seconds
Successfully executed

Good try, but this is what you need to work on:

1. Your standards burn my eyes..

2. When you do something like if(FindColor).. you REALLY need to use Tolerance

3. Same for radial walking, use RadialWalkEx or something to radial walk with tolerance. Runescape updates colors while playing all the time to try to stop us. They can't stop us with the almighty tolerance though! :D

4. You REALLY need to add randomness to your waits. you have it waiting exactly 1 second and things like that a LOT. Fix that please or nobody can use this script without getting banned.

5. You have it hover the skill fishing and a random one every time you click the fishing spot.. Don't do that.

6. You should make anti ban with a case statement instead of doing what I said in 5.

7. You only need 1 procedure for loading both DTMs and Bitmaps..

8. Why don't you add multi player? Its not that hard, just check if the loads is how many the user wants to do per player, then have NextPlayer(True) or if you get lost or something goes wrong, NextPlayer(False);

9. You REALLY need more failsafes.. Please add them in your fishing procedure and walking :p

10. You have an infinite loop here, and maybe in some other places I didn't check:

repeat
if (FindColor(x,y,5794434,MSX1,MSY1,MSX2,MSY2)) then
MMouse(x,y,2,2);
until(IsUpText('Talk'));

that repeats looking for the store guy.. But what if your not in the store? Its going to look for that color forever.

11. You don't have it wait after clicking the fishing spot, or while hovering a skill (Which you shouldn't have there anyways like I explained above). Try having it wait, or make a custom procedure/function to wait until your not fishing.





Other then that, the script is perfect! :p Sorry, not trying to be a jerk, just trying to help :p

Thats exactly what I was looking for, thank you, and are my standards really that bad =S I thought they were perfect. Ahhh well, I'm learning failsafes right now, and don't forget, this is only first release of this script. More to come =D

EDIT: I forgot to tell you guys, this is the first time I ever got DTM's and Bitmaps working, and RadialWalk which I've never gotten to work before.

EDIT2: JAD, whats your MSN, I wanted to know if I could message you on MSN if I ever came across a problem. I mean if you don't want to give it to me thats fine too.

Cool, glad to see your coming along nicely. And standards, pretty much all they are is 2 spaces after begins and repeats, and 2 spaces back for ends and untils. Thats about it, there is a little more to it once you get to cases and things like that, but thats all you need to know for right now so people can read your script ;)

Good Luck.. And when you get this script working well, Maybe you could try to get it to bank. :P We need more fishers :)

We'll… Good Luck..

dudeasaurus, its right next to my post count :p the little butterfly thing. Its [email]runescapemacro@hotmail.com[/email] :p

Oh whatta ya know, sorry :p

so.. this gonna be updated soon hopefully?

i hope to :) seems very good

great idea,


keep trying and make the script a good one

it looks alright so far room for inprovement dont worry about what everyone else thinks just keep working on it

haxor

how much do lobbies sell at general store for?

things you could add:

log in and out feature so log out in 30mins and log back into runescape in 1min something like that.

also antiban

a biggy

major bumpage: be sure to update the store symbol if you haven't already!

lobbies sell for 15 each at gen store at the least

Failed when compiling
Line 64: [Error] (14468:5): Unknown identifier 'FindItemColor' in script F:\SCAR 3.06\includes\SRL/SRL/Skill/Fishing.Scar

Whens this getting updated it looks sweet!

thanks hy for your reply much appreciated.

haxor

this is very nice and original. it has inspired me to make one myself. so if anyone can help me it would be much appreciated.

EDIT: looks like i'm gonna need A LOT of help

omg……
I allways get the same error in ALL the fishing scipts: unknown identifier "FindItemColor" in script (fishing.scar)…………..HELP:(
got SRL 3.81 and SCAR 3.06

by me there is a problem :confused:

Failed when compiling
Line 63: [Error] (14516:5): Unknown identifier 'FindItemColor' in script C:\Program Files\SCAR 3.11\includes\SRL/SRL/Skill/Fishing.Scar

??? need help ASAP plz