SRL Archive - RS has been updated.

Trying to tweak a script


Faab68

2012-11-21 06:45:19

Hello guys, I need some help of you.
I'm trying to tweak a script, and have tryed a lot of stuff.
I'm trying to tweak Jeffrey's herblore script. I think the only thing that needs change is the Make all click, which moved to the middle of the screen.
Is that correct? Because nothing else changed (besides the progress bar, which can be solved by making the Wait timer for banking longer, because it will automatically dissapear).

So i think it has something to do with this section of the script (Am i right?)

 
procedure Mix;
var
FailSafe : Integer;
begin
FailSafe := 0;
InvMouse(14, 3);
ClickMouse2(True);
Wait(RandomRange(600, 700));
InvMouse(15, 3);
ClickMouse2(True);
Wait(RandomRange(200, 300));
MMouse((MCX1+MCX2)/2 ,(MCY1+MCY2)/2 , 5, 5);
while not(IsUpText('All')) do
begin
Wait(RandomRange(20, 40));
Inc(FailSafe);
if (FailSafe > 50) then
begin
Writeln('Couldn''t find the make all button!');
FindNormalRandoms;
Inc(SuperFailSafe);
if (SuperFailSafe > 2) then
begin
Writeln('Oh no we come to a failure!');
Logout;
TerminateScript;
end;
Mix;
Exit;
end;
end;
Writeln(inttostr(failsafe));
ClickMouse2(True);
repeat
wait(100);
Inc(x);
until(x > WaitTimer);
AntiBan;
x :=0;
IncEx(MixedPots, 14);
FindNormalRandoms;
SuperFailSafe := 0;
Inc(LoadsCounter);
end;


Could anyone help me with this?
I'm really trying to understand this scripting language but it's pretty hard :P.

Faab :)

riwu

2012-11-21 06:48:46

MMouse((MCX1+MCX2)/2 ,(MCY1+MCY2)/2 , 5, 5);
Change it to where inference appears on mainscreen.

while not(IsUpText('All')) do
Change 'All' if the uptext changed too.

Faab68

2012-11-21 06:56:50

Sir, i am sorry, but i didn't get a word of what u just said.
Could u try to explain it, in noob language?

Ian

2012-11-21 07:05:23

MCX1, MCX2, MCY1, MCY2 are coordinates for the centre of the chatscreen, where the button used to be. You need to change those coordinates to where the button is now.

Faab68

2012-11-21 07:08:31

Thank you very much! For the quick reply's and help.
I'm trying to find the good coordinates atm :). I'll let you guys know when i find it!

Neros

2012-11-21 07:13:54

From: Faab68
Thank you very much! For the quick reply's and help.
I'm trying to find the good coordinates atm :). I'll let you guys know when i find it!


look at another script which uses the same button and take the co-ordinates from there, have a look at shay's maple fletcher or something. because you know what section of code to look for now it should be easy enough to find.

i don't want to tell you them because you'll learn more from figuring it out yourself and it's always usefull to have a read through some scripts ;)

Faab68

2012-11-21 07:40:33

From: Neros
look at another script which uses the same button and take the co-ordinates from there, have a look at shay's maple fletcher or something. because you know what section of code to look for now it should be easy enough to find.

i don't want to tell you them because you'll learn more from figuring it out yourself and it's always usefull to have a read through some scripts ;)



Sir, i've been trying to get the right coordinates for the past half hour now.
The closest to clicking it was with these coordinates:
MMouse((MCX2+MCX2)/3 ,(MCY2+MCY1)/3 , 5, 1);

Still a little above the make all button though.
I searched the forum for ''shay's maple fletcher'' but i did not find it.
I understand if you don't want to give me the answer but can u perhaps explain to me which coordinates i have to change? And which numbers are horizantal and which are vertical?

Ian

2012-11-21 07:43:20

The coordinates with the X in them are horizontal, the coordinates with the Y in them are vertical

Faab68

2012-11-21 07:46:42

From: BMWxi
The coordinates with the X in them are horizontal, the coordinates with the Y in them are vertical


Oh yeah well that's stupid i didn't figure out that myself, lol.
speaks for itself when u think about it.

owell, ty :p

Faab68

2012-11-21 07:52:56

MMouse((MCX2+MCX2)/3 ,(MCY1+MCY1)/2 , 5, 4);

Is what i got now, it's so close to the button!

I did notice that changing the last 2 numbers (5 and 4) doesn't really change anything.
Am I really that stupid for not figuring out the last coordinates?
I'm so close! But really, i still don't have a clue on what i'm doing.


Faab68

2012-11-21 08:21:24

So i found the right coordinates which where:

MMouse((MCX2+MCX2)/3 ,(MCY2+MCY2)/3 , 5, 5);

But now it won't click the button and is saying: Couldn't find make all button.
So then i was thinking, what if i remove that part of the script, where it confirms that it is at the make all button, and change that to just clicking the button.
So i think it is in this section:


begin
Wait(RandomRange(20, 40));
Inc(FailSafe);
if (FailSafe > 50) then
begin
Writeln('Couldn''t find the make all button!');
FindNormalRandoms;
Inc(SuperFailSafe);
if (SuperFailSafe > 2) then
begin
Writeln('Oh no we come to a failure!');
Logout;
TerminateScript;
end;
Mix;
Exit;
end;

I tryed simply removing that part, but then it gave me an error.
anyone got some advice/tips?