SRL Archive - RS3 Outdated / Broken Scripts

Current Status: Working as of 6th Feb 2013

About
Withdraws flax from bank in lumbridge and will spin it, repeat, simple.

i tried some other scripts here and they seemed outdated, so i wrote this over the last day or two

This script is working almost flawlessly for me, so if you have problems, turn Debug to true in the settings and post whats going wrong for you and ill try to help fix.

If you spot any bugs please post em and I'll work on a fix ASAP, Thanks

Feature's

Anti-Ban

Fail Safe's (Should Always Recover From a Miss-Click)

Progress Report

De Bugging Mode

Credits

Ashaman88 - Read through alot of his work to learn

Benland100 - S.M.A.R.T and his mouse scripting

Flight - Mouse scripting

Please follow setup before starting.

SetUp

1. Graphic's setup as Simba recommends, RS zoomed out to max brightness up full

2. Turn EOC Craft UI On

3. Make sure Flax is in the all tab and top right of bank

4. Make sure you start script on top floor on the bank spot, with bank closed

5. Make sure your Run is toggled ON ingame before start

6. I recommend left clicking compass in game before you start

7. Requires using S.M.A.R.T v8.0+ (May Not Compile On 7.2)

Known Bugs

Occasional Miss-Clicks

Things to Do

More Anti-Ban (can never have enough :))

Proggies

[LIST]
My Test Run - 1
****************AutoString****************
*              ~By DannyRS~               
* Strings Made: 952 (1099 P/H)
* XP Earned: 14280 (16487 P/H)
* GP Made: 85680 (98924 P/H)
* Total Time: 51 Minutes and 58 Seconds
******************************************
[/LIST]

[List]
     [MENTION=91080]mikeallen[/MENTION]
***************DannyRS-AutoString**************
*                 Version: V2.0
* Time Running: 7 Hours, 51 Minutes and 47 Seconds
* StringsMade : 7532
* Strings / H : 958
* CraftingXP  : 112980
* Craft  XP/H : 14368
**********************************************
[/List]

Versions

[LIST]
V1.0 - Re Released - my first script ever made no updates planned atm
V2.0 - Re-Written
[/LIST]

Looks nice, Gj on first release! Taking a look now!

Massive script for a first post!

Sorry I can't test, F2P :p

Wow fast reply lol, btw first script, any and all reviews welcome, i confirmed smart 7.2 will not work

I'm fairly new to these forums so its nice to finally meet you and start giving back to the community(been lurking for a while now)

I have tried to keep my script at a high standard, but being my first there was ALOT of reworking and moving stuff around, so sorry if it is hard to read in some spots!

I'm a C# developer so i have programming background, thats why the script is quite large, but my bad habits of hard coding things yet again appear lol, Thanks for taking a look guys!

Looks great!

Congrats on the release!

This is probably more down to personal choice, but I like to group my variables together, just saves several lines IMO.

So instead of:

Var
 Debug: Boolean;
 stop: Boolean;
 quitgame: Boolean;
 takesmallbreaks: Boolean;
 stringstomake: Integer;
 stringsmade: Integer;
 runscomplete: Integer;
 stringprice: Integer;
 flaxprice: Integer;
 failsafes: Integer; 

I'd put:

Var
 Debug, stop, quitgame, takesmallbreaks: Boolean;
 stringstomake, stringsmade, runscomplete, stringprice, flaxprice, failsafes: Integer;

Also, I'd probably change these to constants, as they do not change over the course of the script, also saving you a procedure because the script already knows what value these hold.

Procedure ScriptSetup;
begin
stringstomake:= 5000;    //goal strings to make
  Debug:= False;           //enable if having issues
  takesmallbreaks:= True;  //sometimes take a small break
  stringprice:= 180;       //market stringprice
  flaxprice:= 90;          //market flaxprice
end;

const
  StringsToMake = 5000;
  Debug = False;
  TakeSmallBreaks = True;
  StringPrice = 180;
  FlaxPrice = 90; 

I like to make my declare players like this as well, again down to personal preference but this lends itself toward use with multiplayer

Procedure DeclarePlayers;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;
  Players[0].Name :='';
  Players[0].Pass :='';
  Players[0].Nick :='';
  Players[0].Active:=True;
end;

procedure DeclarePlayers;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  with Players[0] do
  begin
    Name   := '';
    Pass   := '';
    Nick   := '';
    Active := True;
  end;
end;

Great work on adding the human-like mouse movements to your first script, I love seeing new script writers incorporating this kind of stuff :)

You should check out the SRL include, I notice that you have some procedures like CloseBankBooth and LogOutGame etc, which while they make good use of HumanMMouse, it's alot of excess code that could be cut down simply by using the include.

Should check out DTMs for withdrawing items and so forth from the inventory and bank, they are really cool and accurate if made correctly.

This:

        xpos:= RandomRange(246,274);
        ypos := RandomRange(248,274);        ypos := ypos-50;
        HumanMMouse(xpos,ypos,0,0); 

could be shortened to this:

HumanMMouse(RandomRange(246, 274), RandomRange(248, 274), 0, 0);

Check out the constant co-ords in the include like MMx1, MMy1, MSx1, MBx1 and so forth. They are really helpful, and just generally check out all the cool pre-made functions in the different includes. They make life alot easier and save you having to hard-code every action ;)

But all in all, really nice first script, I'd love to give it a proper test for you but I'm a bit short on time at the moment.

Thanks alot for taking a look P1ng,

The main focus of my scripting is the Anti Ban and getting the job done :)

I would normally also group the variables too but someone suggested in a tutorial for a first script not to do so, i think I'll group them all in the next release :)

As for making the input a const, I'll do that in the next release too, was originally like that but i was having trouble getting it to use variables in the const, but that was before alot of the code was done.

No plans at the moment to mess with multiplayer as its fairly low prio, but i'll make the changes you suggest because it makes it look neater and future proofs it :)

HumanMMouse(RandomRange(x1, x2), RandomRange(y1, y2), 0, 0);

This will also definitely be in the next release thanks for the tip, was very much a debugging way i had it setup before, just so i could see every line easily, but before i do that i need someone to test it out, because simba reports the screen position + the top banner for me, so every y position has had to be -50, is this what always happens? because i'll just update the y's and remove all the -50 parts, just wanted to be sure it was not just my client lol

As for the SRL includes, i think at the moment i'd like to remain in control of as much as possible from the main script, dont want to mix and match different mouse script movements, also allowing me complete control over the randomness of the clicks is what im looking for, at some point i'll make them non script specific procedures so i can just copy them for other projects.
the MMx1 etc do look really useful though so i'll check them out

Dont think I'm ready for use of DTM's, they also make alot of work for when there are game updates, maybe at some point, but for now i'd like to stick to a color only method

Thanks alot for the feedback and your changes will really help neaten it up and make it easier to read :)

You use lots of static points in your script.
If you're not moving, it shouldn't affect it too much, but you should really learn to click to colors and things. Static clicking isn't too safe.

From: NKN
You use lots of static points in your script.
If you're not moving, it shouldn't affect it too much, but you should really learn to click to colors and things. Static clicking isn't too safe.

The colour checking is static, the clicking itself should NEVER be static and always random, could you point out somewhere the clicking is static?

do you mean a static point as in the same random box? because im working on making it even more random

i know how to click colors but i wanted to give it a larger random area to click in than i felt i could do with that

some clicks the randomness is very minimal as they needed to be in certain spots, but should be random none the less

From: dannyrs
The colour checking is static, the clicking itself should NEVER be static and always random, could you point out somewhere the clicking is static?

i know how to click colors but i wanted to give it a larger random area to click in than i felt i could do with that

some clicks the randomness is very minimal as they needed to be in certain spots, but should be random none the less

By static he meant blind clicks. Randomized pixel is basic antiban but clicking static coordinates are unreliable.

             xpos:= RandomRange(249,269);
          ypos := RandomRange(183,199);
          ypos := ypos-50;
          HumanMMouse(xpos,ypos,0,0); 

I saw a lot of these throughout the script.
Make use of the coordinates retrieved from color finding functions.

Not too bad for a first script though :)
Also you could simplify those into
MouseBox(249, 183, 269, 199, mouse_Left)

well atm the blind clicking is working almost perfectly, if its clicking in them based on color detection checks, is that not exactly the same thing in this case?

cant see a reason to click the color instead in this case, there are no moving NPC's or such to deal with for this

im currently working on simplifying the mouse lines as i know its a problem :)

You won't be able to open the bank if it's at a different angle/compass and the player must be directly infront of bank in the exact position you coded.
Jagex implement a lot of randomization in various aspects, and you have to add random offset in your mouse clicking, so the walking may not be unreliable. Well..i guess i'll just leave you to find out yourself about the cons of blind clicking when you make more advanced scripts ;)

I can understand for when things move when you are not in control of them, but for this i dont think theres that much need

there's no need here for a random X,Y offset as the actual co-ords are random?

Thanks for the constructive feedback guys :)

I believe what the others were referring to is when you call a function like FindColorTolerance you have to input an x and y variable.

So something like FindColorTolerance(x, y, SRL_VarrockRoadColor, MMx1, MMy1, MMx2, MMy2, 5);

This then returns the x and y values for the point at which this colour was found. So instead of going(where you check for the colour then click a static co-ord):

if FindColorTolerance(x, y, SRL_VarrockRoadColor, MMx1, MMy1, MMx2, MMy2, 5) then
  HumanMMouse(RandomRange(246, 274), RandomRange(248, 274), 0, 0);

you could put:

if FindColorTolerance(x, y, SRL_VarrockRoadColor, MMx1, MMy1, MMx2, MMy2, 5) then
  HumanMMouse(x, y, RandomRange(-4, 4), RandomRange(-4, 4));

In the original example you check for the colour and then click on some static co-ords if that colour is found. In the second (recommended) example you check for the colour and then click in an area around the point where the colour was found. Essentially achieving the same end result assuming things aren't moving around on you, but still a much better practice to get in the habit of doing.

yea i understand now thanks, just a prob if a color is not in the middle of where you want to click though

You should check out TPAs, they make things infinitely possible when finding things with colours. They are a great tool to have, for some people they take a bit of time to wrap your head around, but just keep re-reading the tutorials and practicing over and over again.

Already looking into those thanks p1ng :)

I would like to test the script

Re-Released, my first ever script - feel free to give it a go, if there's interest I'll update it

Might try this out.. Hope it still works

From: stayon
Might try this out.. Hope it still works

First script I ever wrote, should still work but if you were to look at the code itself you would probably cringe, let me know if it doesn't work

Currently tanning some hides but I'll definitely check it out later on :)

From: stayon
Currently tanning some hides but I'll definitely check it out later on :)

Apparently one of the stair colors is outdated, going to check everything in this tomorrow :p

From: DannyRS
Apparently one of the stair colors is outdated, going to check everything in this tomorrow :p

Looking forward to it. I'll make sure to buy some flax to be ready :)

From: stayon
Looking forward to it. I'll make sure to buy some flax to be ready :)

Didnt get a chance today and I've got a monster of a college assignment program to finish, I want to completely re-write this like the rest of my public releases, but with all this crap going on I'll need a few days, sorry, I promise it will be here by the end of this week :)

From: DannyRS
Didnt get a chance today and I've got a monster of a college assignment program to finish, I want to completely re-write this like the rest of my public releases, but with all this crap going on I'll need a few days, sorry, I promise it will be here by the end of this week :)

No rush bro! I'm training my cooking using ash's script and then I'll train some more agi using your wildy script so take your time :)

From: stayon
No rush bro! I'm training my cooking using ash's script and then I'll train some more agi using your wildy script so take your time :)

I need to fix the two 1/1000 stuck spots in that too this week :p

From: DannyRS
I need to fix the two 1/1000 stuck spots in that too this week :p

Looking forward to it. Loved it while I was running it!

From: DannyRS
Apparently one of the stair colors is outdated, going to check everything in this tomorrow :p

roughly line 524.
Replace with

    if(FindColorSpiralTolerance(x, y, 10462631, 263, 210, 270, 214, 20))then 

its a simple color fix


Danny I added login and bank pin support. If you want to include it in the main release just send me a message.

UPDATED V2.0 - Re-Written

Flax now top right of bank

@Justin Can I get the 10min Justin test sometime? :)

Im not sure if I have everything set up correctly but after 2-3 flax being strung into bow strings it clicks by the stairs on the minimap and then runs back and repeats. Fairly botlike I would say. Again it may just be me.

From: haiku
Im not sure if I have everything set up correctly but after 2-3 flax being strung into bow strings it clicks by the stairs on the minimap and then runs back and repeats. Fairly botlike I would say. Again it may just be me.

Read the thread before running, your EoC production interface is disabled, turn it on ;)

***************DannyRS-AutoString*********************
*                 Version: V2.0
* Time Running: 7 Hours, 51 Minutes and 47 Seconds
* StringsMade : 7532
* Strings / H : 958
* CraftingXP  : 112980
* Craft  XP/H : 14368
******************************************************

Here is a proggy :)

From: mikeallen

***************DannyRS-AutoString*********************
*                 Version: V2.0
* Time Running: 7 Hours, 51 Minutes and 47 Seconds
* StringsMade : 7532
* Strings / H : 958
* CraftingXP  : 112980
* Craft  XP/H : 14368
******************************************************

Here is a proggy :)

Awesome, I'll add to OP ;)

is it running ok? any issues anywhere that need addressed?

sometimes it gets stuck at the stairs next to bank having walked up, but it still thinks it is on the lower floor so it keeps looking for the staircase to go up, it is uncommon though.

An issue I was having, It would start spinning and halfway through an inventory it would run to the stairs and run back and spin a few more and continue doing this until the inventory was full…

From: Acidic Void
An issue I was having, It would start spinning and halfway through an inventory it would run to the stairs and run back and spin a few more and continue doing this until the inventory was full…

eoc production ui ON?

Excuse me, this is my first Simba script I've ever tried to run… What is eoc production ui?

From: Acidic Void
Excuse me, this is my first Simba script I've ever tried to run… What is eoc production ui?

try doing this in game,

Ok thanks! It's working now I have 4 accounts currently going. I will post 4 seperate proggies in a few hours :P I've been using powerbot for these accounts until now and the scripts honestly suck over there.. I havent had one last over 6 hours yet.. Thanks a ton for making this!

Little issue, one of my 4 going is stuck trying to go down stairs.. it keeps right clicking and then never pressing climb down.

Edit: now 2 accounts are stuck trying to go down stairs.

From: Acidic Void
Ok thanks! It's working now I have 4 accounts currently going. I will post 4 seperate proggies in a few hours :P I've been using powerbot for these accounts until now and the scripts honestly suck over there.. I havent had one last over 6 hours yet.. Thanks a ton for making this!

Little issue, one of my 4 going is stuck trying to go down stairs.. it keeps right clicking and then never pressing climb down.

Edit: now 2 accounts are stuck trying to go down stairs.

I think it think's it's downstairs already, working on fix

thanks dude! The stupid update stopped all my bots >;(

From: Acidic Void
thanks dude! The stupid update stopped all my bots >;(

Same :( was mid fixing pest control colors too

I was running 6 bots in all.. It's a lot for work starting them all back up :P




Edit: It looks like the bot think it's on the middle level when it's actually on the top and that's why it keeps getting stuck.. do you think debug mode would help this?

It looks like the bot think it's on the middle level when it's actually on the top and that's why it keeps getting stuck.. do you think debug mode would help this?

From: Acidic Void
It looks like the bot think it's on the middle level when it's actually on the top and that's why it keeps getting stuck.. do you think debug mode would help this?

You should edit your comments rather than double posting :)

@Acidic Void, Added a new failsafe, try V2.1, see if it works better or not

I will let you know!


Version: V2.0
* Time Running: 4 Hours, 31 Minutes and 37 Seconds
* StringsMade : 3556
* Strings / H : 785
* CraftingXP : 53340
* Craft XP/H : 11782

* Time Running: 4 Hours, 31 Minutes and 22 Seconds
* StringsMade : 4788
* Strings / H : 1059
* CraftingXP : 71820
* Craft XP/H : 15880

* Time Running: 4 Hours, 31 Minutes and 22 Seconds
* StringsMade : 4788
* Strings / H : 1059
* CraftingXP : 71820
* Craft XP/H : 15880

* Time Running: 4 Hours, 28 Minutes and 53 Seconds
* StringsMade : 2968
* Strings / H : 662
* CraftingXP : 44520
* Craft XP/H : 9934

These are my 4 accounts that have been running, you can see based on the bow strings per hour which 2 get stuck the most :P

Idk why some get stuck and some don't :/ I need to write better logic for the walking I think, will do later when I have the time ;)

Ok, I updated everything and I am now trying it out with all 4 accounts, thanks a bunch!

Edit: It still gets stuck at the same spot where it tries to go up stairs even though it's already on the highest level. And it tends to get stuck on the middle floor next to the stairs like to the right of it.. so it tries to click the spinner and just keeps missing.

From: Acidic Void
Ok, I updated everything and I am now trying it out with all 4 accounts, thanks a bunch!

Edit: It still gets stuck at the same spot where it tries to go up stairs even though it's already on the highest level. And it tends to get stuck on the middle floor next to the stairs like to the right of it.. so it tries to click the spinner and just keeps missing.

Yea I know whats causing it, I will have a look at it soon, see if I can fix all this :p

thanks! So I hit the 6 hour limit and for some reason it didn't reload, so I turned off the bots and when I tried restarting them I got this message:

Exception in Script: Plugin(libsmartremote32) has not been found

I've tried reinstalling simba and updating my extensions and nothing seems to be working.. .:/

From: Acidic Void
thanks! So I hit the 6 hour limit and for some reason it didn't reload, so I turned off the bots and when I tried restarting them I got this message:

Exception in Script: Plugin(libsmartremote32) has not been found

I've tried reinstalling simba and updating my extensions and nothing seems to be working.. .:/

Go update to smart 8.0 I guess ;) or re-unzip the files and put the plugins in again

http://villavu.com/forum/showthread.php?t=87801

I did that and my new issue is:

Exception in Script: Plugin(sps32) has not been found

From: Acidic Void
I did that and my new issue is:

Exception in Script: Plugin(sps32) has not been found

reinstall simba lol

Ok, It's working now! Thanks

Found my guy at the stairs too :(

***************DannyRS-AutoString*********************
*                 Version: V2.0
* Time Running: 7 Hours, 57 Minutes and 29 Seconds
* StringsMade : 1932
* Strings / H : 243
* CraftingXP  : 28980
* Craft  XP/H : 3642
******************************************************
Exception in Script: Failed to create new thread, code:8
The following DTMs were not freed: [0, SRL - Lamp bitmap, 2]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap, SRL - NavBar Bitmap, SRL - Options Bitmap, 9]

From: stayon
Found my guy at the stairs too :(

When I have time, will fix that bug

Can someone take time and make this for oldschool runescape?

From: ranged lm
Can someone take time and make this for oldschool runescape?

I'll make oldschool versions of my scripts when random events are in a decent state

I'm pretty sure this is completely broken now. The most I can get this to do is about 1000 before it just stops working.

***************DannyRS-AutoString*********************
* Version: V2.0
* Time Running: 4 Hours, 2 Seconds
* StringsMade : 3472
* Strings / H : 868
* CraftingXP : 52080
* Craft XP/H : 13018
******************************************************
Exception in Script: Failed to create new thread, code:8
The following DTMs were not freed: [SRL - Lamp bitmap, 1, 2]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap, SRL - NavBar Bitmap, SRL - Options Bitmap]

help please? running simba as admin, win7x64.

From: sd999444

Exception in Script: Failed to create new thread, code:8
help please? running simba as admin, win7x64.

Never seen that error before :/

From: DannyRS
Never seen that error before :/

full reinstall (uninstall, delete reg errors/values, reinstall) fixed it. now it keeps giving the new error message.

Great scrip for a while. Every 5 min or so it will go down the stairs to the right and then when it tries to click on the wheel it is to far to the right instead of ending up in front of the stairs where it is programmed.

***************DannyRS-AutoString*********************
* Version: V2.0
* Time Running: 9 Hours, 5 Minutes and 36 Seconds
* StringsMade : 7056
* Strings / H : 776
* CraftingXP : 105840
* Craft XP/H : 11639
******************************************************

Working decently for me :)

I did notice the strings/hr had dropped a lot and I found that it seems to be getting "stuck" every couple of trips, sometimes every trip, right at the stairs of the spinning wheel. It is hovering just to the right of the spinning wheel and doing so for a while before it finally tries to correct the spot it's standing and then re-click the wheel.



Uploaded with ImageShack.us

Similar problem as previous poster with the difference that it gets stuck on the top (bank) level at the stairs before recovering after some time.
"We Dont Have Flax, Going Bank" written out 7 times in debug log before managing to go to the bank.

It spins about 3 flax then it runs to the stairs stops and runs back and spins 3 more runs to the stairs stops and spins 3 more. Not sure what is going on?

Please fix this, it's definitely broken.
I spin 2-3 flax, run to the bottom of the stairs, spin a few more, repeat. Please fix asap, I have 170k flax to spin.

I hope Danny is working on the "standing next to the stairs bug", but for now i've found a solution.
If you find yourself next to the stairs and the mouse hovering next to the spinning wheel, you should turn the camera a little so that the mouse hovers over the spinning wheel, then it should work just fine

i love your fight cave script, so im pretty stoked to try this sucker out.

From: went2thedrkside
i love your fight cave script, so im pretty stoked to try this sucker out.

well it worked good for a few runs a guess then got stuck at stairs :/ i was really digging this script

***************DannyRS-AutoString*********************
* Version: V2.0
* Time Running: 6 Hours, 30 Minutes and 33 Seconds
* StringsMade : 1596
* Strings / H : 245
* CraftingXP : 23940
* Craft XP/H : 3678
******************************************************