SRL Archive - First Scripts

Hey everyone!

I just read the tutorial section and tried making an easy script to learn a little bit about pascal.

Location: Draynor Fishing Spot
What it does: Simply fishs shrimp and drops them as soon as the inventory is full.

Simple antiban.

I thought i'd share this script with you, although most of you could write this blindfolded :D

Please spend like 5 minutes and give me a small feedback. My next step will probably be banking/walking :)

program new;
{$DEFINE SMART}
{$i srl/srl.simba}
var
 Fish:Integer;
Procedure DeclarePlayers;
begin

HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;

Players[0].Name := '';
Players[0].Pass := '';
Players[0].Nick := '';
Players[0].Active:=True;
end;

procedure AntiBan;
begin
  if(not(LoggedIn))then
  Exit;
   case Random(20) of
   0: PickUpMouse;
   1:
   begin
     MakeCompass('N');
     wait(100+random(1200));
     MakeCompass('S');
     wait(50+random(1200));
     MakeCompass('N');
   end;
   2:
   begin
   SetAngle(SRL_ANGLE_HIGH);
   end;
  end;
end;

procedure Fishnet;
var x, y: integer;

begin
 repeat
 if FindObj(x, y,'et',12236209, 20) then
 begin
    Mouse(x, y, 2, 2, false);
    ChooseOption('et');
    end;
      repeat
    Wait(400+random(250));
    Antiban;
    Wait(900+random(300));
  Until not IsUpText('et') or (InvFull);
  until(InvFull);
 end;

procedure Fishnet2;
var x, y: integer;

begin
 repeat
 if FindObj(x, y,'ish Net',11111037, 20) then
  begin
    Mouse(x, y, 2, 2, false);
    ChooseOption('et');
    end;
      repeat
    Wait(400+random(250));
    Antiban;
    Wait(900+random(300));
  Until not IsUpText('et') or (InvFull);
  until(InvFull);
 end;


 procedure DropFish;
var
  i: Integer;
begin
  if not (LoggedIn) then
    Exit;
  if(InvFull) then
  for i := 1 to 28 do
  begin
    if ExistsItem(i) then
      DropItem(i);
      wait(25+random(5));
      Fish := Fish + 28
  end;
end;

procedure MainLoop;
begin
 repeat
 Fishnet
 Fishnet2
 DropFish
 Until not (LoggedIn);
end;


begin
  SetUpSRL;
  ActivateClient;
  DeclarePlayers;
  LoginPlayer;
  MainLoop();
end.                                       

Congrats on your first script! One thing I've noticed so sar is that it clicks the spot every second or so, even if it is already fishing. Have you considered using Pixelshift to detect when it is fishing?
Here's a tutorial by Flight, he's made some great fishing scripts: http://villavu.com/forum/showthread.php?t=74090

I haven't learned it yet because my scripts are more collecting and mining based, but It's worth a look.

I think the repeatedly fishing thing is because you're using

Until not IsUpText('et')

This only works for one tile areas when you left click, and your script right clicks.