Justin
2012-10-24 07:37:42
Was working fine before the update.
Justin.
2012-10-24 07:37:42
2012-10-24 07:39:57
2012-10-24 07:43:42
From: riwu
Yeah same problem here, i'm now trying to figure out what changed. Tell me if you noticed anything.
EDIT: Seems like LoggedIn is broken too.
if LoggedIn then
writeln('we are logged in');
wait(2000);
2012-10-24 07:45:34
2012-10-24 07:56:34
From: [J]ustin
Weird
if LoggedIn then
writeln('we are logged in');
wait(2000);
Output:
Account was logged in.
IIRC LoggedIn uses the white text on the 'Report' button![]()
2012-10-24 08:07:53
From: riwu
Sorry i manually logged in, start my script and it stops, i assumed it's LoggedIn. Seems like it's some other problem.
Anyway, fixed the lobby tab, Jagex is lame, just a color change to 11582147.
Gametab next.
EDIT: fixed as well. Anything else?
2012-10-24 08:10:06
From: [J]ustin
I started the script while my account was logged in (the if LoggedIn)
That's all that I have noticed that is broken atm.
2012-10-24 08:22:13
From: riwu
Apparently everything to do with tab is broken. I've fixed Lobby, GameTab, Bank tab. What other tabs are there in game?
2012-10-24 08:24:44
2012-10-24 08:28:04
From: Faab68
Hello, i am trying to run a herblore script. when it's trying to use first item on 2nd item, instead of clicking on the 2nd item, it clicks on the inventory tab. Hope this helps
2012-10-24 08:38:40
From: riwu
Probably because InvMouse checks for current tab, and since it is broken it went to click on tab_Inv in attempt to switch to it.
I've sent a pull request, wait for Coh3n to merge then you can update your SRL and it should be fixed.
2012-10-24 08:53:53
2012-10-24 08:59:20
From: Scorched
I tried to use a few scripts, they all seem to have the same issue. The cursor will click inventory and equipment tabs, and just seem to be operating in super slow motion.
Takes 5 minutes to click the bank, 5 minutes to click an item ect.
Just figured I would let everyone know what's going on.
2012-10-24 09:04:56
2012-10-24 09:35:19
From: riwu
Unfortunately not yet, detection is fixed now but the actual tab switching functions involves a composite color of the tab, i'm now fixing them as well.
2012-10-24 10:13:58
2012-10-24 10:20:31
From: Ashaman88
I fixed the gametab thing on justin's other thread, at least it works for me
2012-10-24 10:24:12
2012-10-24 10:26:07
2012-10-24 10:33:34
2012-10-24 10:44:21
2012-10-24 10:48:21
From: riwu
That's changing the algorithm slightly, and introducing tolerance to the function which i'm not sure if it's a good idea. Anyway try my attached file, everything should be fixed now, if it doesn't report it here.
Also make sure you update your SRL to get the bank.simba fix. SRL>Check for updates. (Inb4 SmartParams error)
2012-10-24 10:52:09
From: QQu
It's working, back to normal now. Don't need to change anything. Just make sure you click SRL -> Check for updates within Simba and restart it.
2012-10-24 11:03:19
2012-10-24 11:13:15
2012-10-24 12:22:33
2012-10-24 13:48:23
2012-10-24 13:51:21
From: Master BAW
for some reason it can't see wheter i'm in a gametab or not :(
2012-10-24 15:34:41
2012-10-24 18:25:45
From: riwu
That's changing the algorithm slightly, and introducing tolerance to the function which i'm not sure if it's a good idea. Anyway try my attached file, everything should be fixed now, if it doesn't report it here.
Also make sure you update your SRL to get the bank.simba fix. SRL>Check for updates. (Inb4 SmartParams error)
2012-10-24 20:50:57
2012-10-24 22:12:02
From: ___
trying the update now… but before it just hovered over the invtab.
From: riwu
…
(Inb4 SmartParams error)
2012-10-24 22:15:21
From: [J]ustin
There is a {$DEFINE SMART8} function now, up to the scripters\users to define it if they are going to be using Smart 8 :P
2012-10-24 22:20:45
From: riwu
It may have some compatibility issues with some other components. Right now i realize the ODTM include checks for {$DEFINE SMART} so there will be some conflicts if you define 8 instead.
And even then you have to change every script to {$DEFINE SMART8}, and when smart upgrades (eg. to 9) you have to update your script, and worse, if the user is still using SMART 7 it won't work for them. So basically i think just removing the -1 every SRL update is simpler. Or don't use the autoupdater, get the updates from git directly.
Btw seems like the fix is in the autoupdater now.
2012-10-24 22:24:55
From: [J]ustin
Smart 7 will get over-written by Smart 8. I am sure there will be a function in smart.simba that will be checking for {$DEFINE SMART8} and will just ignore it and load the correct parameters
E: Either way the devs know what they are doing and they will be able to push the updates out in the future without breaking much (as it has been in the past)
{$IFDEF SMART8}
Result := SmartSpawnClient(ReplaceWrap(PluginPath, '\', '/', [rfReplaceAll]), Params[0], ',' + Params[1], 765, 553, 's', '', '');
{$ELSE}
Result := SmartSpawnClient(ReplaceWrap(PluginPath, '\', '/', [rfReplaceAll]), Params[0], ',' + Params[1], 765, 553, 's', '', '', -1);
{$ENDIF} If you define 8, and the user is using 7, they will get a invalid param error instead. (and for the fact that they are still using 7 implies that you can't expect them to fix it themselves and they will come bug you on your thread) Anyway it's personal preference, up to the individual users to decide which way is better.2012-10-24 22:26:16
From: riwu
If you define 8, and the user is using 7, they will get a invalid param error instead. Anyway it's personal preference, up to the individual users to decide which way is better.{$IFDEF SMART8}
Result := SmartSpawnClient(ReplaceWrap(PluginPath, '\', '/', [rfReplaceAll]), Params[0], ',' + Params[1], 765, 553, 's', '', '');
{$ELSE}
Result := SmartSpawnClient(ReplaceWrap(PluginPath, '\', '/', [rfReplaceAll]), Params[0], ',' + Params[1], 765, 553, 's', '', '', -1);
{$ENDIF}
2012-10-25 02:14:29
2012-10-25 02:22:52
From: Solar
I don't think WorldInfo := [96,96]; works now, at least not for Flight's lividfarmer script.
2012-10-25 03:50:25
From: riwu
What is your intention to have 2 same integers in the array? Also it should still work as before, index 0 is simply ignored when you have length higher than 1. I couldn't think of any way in which a script will be broken because of the fix. In fact iirc correctly it was the previous code that will give an error when you have 2 integers, since there will be a type mismatch error for the first index.
Also i've just checked Flight's script, it doesn't even have WorldInfo defined?
2012-10-25 06:56:57
{$DEFINE SMART} // This is how we include SMART
{$DEFINE SMART8} // tell the system that we have smart 8
instead of what I had first:{$DEFINE SMART} // This is how we include SMART
[Error] C:\Simba\Includes\SRL/SRL/misc/paintsmart.simba(42:33): Unknown identifier 'SmartGetDebugDC' at line 41
Compiling failed.
SMART_Canvas.canvas.handle := SmartGetDebugDC;with this:SMART_Canvas.canvas.handle := 0;
2012-10-25 06:59:36
2012-10-25 07:07:09
From: Master BAW
I've a question about this SMART 8 thing. I have SMART 8 installed a month ago, but every time I updated SRL I got a SRL compile error in SmartParams and in paintsmart.
now I started the script with this:instead of what I had first:
{$DEFINE SMART} // This is how we include SMART
{$DEFINE SMART8} // tell the system that we have smart 8{$DEFINE SMART} // This is how we include SMART
but now I still get one compile error:
[Error] C:\Simba\Includes\SRL/SRL/misc/paintsmart.simba(42:33): Unknown identifier 'SmartGetDebugDC' at line 41
Compiling failed.
Is there something I'm missing to get rid of these compile errors after every SRL update?
because Now everytime I have to replace thiswith this:SMART_Canvas.canvas.handle := SmartGetDebugDC;SMART_Canvas.canvas.handle := 0;
2012-10-26 22:01:16
If InvCount=PlusOne Then
WriteLn('Digging...');
Until(InvCount=PlusOne) Or (TimeFromMark(OreCounter) > 4000)2012-10-26 22:17:15
From: BMWxi
Anyone know if InvCount works in browsers? I have a part like this:If InvCount=PlusOne Then
WriteLn('Digging...');
Until(InvCount=PlusOne) Or (TimeFromMark(OreCounter) > 4000)
To check if the rock has been mined but when I was using it in the browser (not SMART), It was always waiting for the marktime fallback even if it mined the ore. I know the code is right because I have not changed anything and it worked earlier, but in a smart window not the browser.
So to recap: Does InvCounting work in browsers since the gametab update?
Also detection for the rocks was much slower than with smart. Any ideas?
2012-10-26 22:18:44
From: riwu
There should be no difference between botting with Smart or with browser.
The code doesn't make sense to me though, can you post the whole routine?
2012-10-26 22:21:00
From: BMWxi
I don't know if I am allowed, it is for the Jr Member copmpetition. Maybe I'll censor out some non relevant code.
Actually could I PM it to you if you're not a judge?
2012-10-26 22:22:17
From: riwu
Oh ok, i'm not a judge but i'm probably not supposed to help too much either. You can pm me and if there's error i'll point it out but i can't give you suggestion/fix.
2012-10-27 10:14:31
2012-10-27 10:27:50