SRL Archive - SRL Bugs

Not detecting Lobby


Justin

2012-10-24 07:37:42

Since RuneScape just updated, Just wanting to know if anyone else is having trouble when SRL log's in an account, it just hangs on the lobby screen.

Was working fine before the update.

Justin.

riwu

2012-10-24 07:39:57

Yeah same problem here, i'm now trying to figure out what changed. Tell me if you noticed anything.

Justin

2012-10-24 07:43:42

From: riwu
Yeah same problem here, i'm now trying to figure out what changed. Tell me if you noticed anything.

EDIT: Seems like LoggedIn is broken too.


Weird


if LoggedIn then
writeln('we are logged in');
wait(2000);

Output:
Account was logged in.

IIRC LoggedIn uses the white text on the 'Report' button


Ashaman88

2012-10-24 07:45:34

everything running super slow for me too. haven't tried the lobby yet. gametab seems to have problems too

riwu

2012-10-24 07:56:34

From: [J]ustin
Weird


if LoggedIn then
writeln('we are logged in');
wait(2000);

Output:
Account was logged in.

IIRC LoggedIn uses the white text on the 'Report' button


Sorry i manually logged in, start my script and it stops, i assumed it's LoggedIn. Seems like it's some other problem.
Anyway, fixed the lobby tab, Jagex is lame, just a color change to 11582147.

Gametab next.

EDIT: fixed as well. Anything else?

Justin

2012-10-24 08:07:53

From: riwu
Sorry i manually logged in, start my script and it stops, i assumed it's LoggedIn. Seems like it's some other problem.
Anyway, fixed the lobby tab, Jagex is lame, just a color change to 11582147.

Gametab next.

EDIT: fixed as well. Anything else?


I started the script while my account was logged in (the if LoggedIn)

That's all that I have noticed that is broken atm.

riwu

2012-10-24 08:10:06

From: [J]ustin
I started the script while my account was logged in (the if LoggedIn)

That's all that I have noticed that is broken atm.

Apparently everything to do with tab is broken. I've fixed Lobby, GameTab, Bank tab. What other tabs are there in game?

Justin

2012-10-24 08:22:13

From: riwu
Apparently everything to do with tab is broken. I've fixed Lobby, GameTab, Bank tab. What other tabs are there in game?


Speaking to Mat on skype, we thing that it's only GameTab and the Bank tab that could be used.

I guess we just wait for posts saying stuff is broken

Faab68

2012-10-24 08:24:44

Hello, i am trying to run a herblore script. when it's trying to use first item on 2nd item, instead of clicking on the 2nd item, it clicks on the inventory tab. Hope this helps

riwu

2012-10-24 08:28:04

From: Faab68
Hello, i am trying to run a herblore script. when it's trying to use first item on 2nd item, instead of clicking on the 2nd item, it clicks on the inventory tab. Hope this helps

Probably because InvMouse checks for current tab, and since it is broken it went to click on tab_Inv in attempt to switch to it.
I've sent a pull request, wait for Coh3n to merge then you can update your SRL and it should be fixed.

Justin

2012-10-24 08:38:40

From: riwu
Probably because InvMouse checks for current tab, and since it is broken it went to click on tab_Inv in attempt to switch to it.
I've sent a pull request, wait for Coh3n to merge then you can update your SRL and it should be fixed.


Make sure 'tab_LogOut' works with your new colours

Scorched

2012-10-24 08:53:53

I tried to use a few scripts, they all seem to have the same issue. The cursor will click inventory and equipment tabs, and just seem to be operating in super slow motion.

Takes 5 minutes to click the bank, 5 minutes to click an item ect.

Just figured I would let everyone know what's going on.

Justin

2012-10-24 08:59:20

From: Scorched
I tried to use a few scripts, they all seem to have the same issue. The cursor will click inventory and equipment tabs, and just seem to be operating in super slow motion.

Takes 5 minutes to click the bank, 5 minutes to click an item ect.

Just figured I would let everyone know what's going on.


Thanks for letting us know.

Riwu has done some work and has fixed the issues.

As you can see by the title, a fix has been released. You will just need to wait for Simba to update your include. (Or you can force-update it)

riwu

2012-10-24 09:04:56

Unfortunately not yet, detection is fixed now but the actual tab switching functions involves a composite color of the tab, i'm now fixing them as well.

l6bustank

2012-10-24 09:35:19

From: riwu
Unfortunately not yet, detection is fixed now but the actual tab switching functions involves a composite color of the tab, i'm now fixing them as well.

Thats good to hear, just ran into this problem.

Ashaman88

2012-10-24 10:13:58

I fixed the gametab thing on justin's other thread, at least it works for me

riwu

2012-10-24 10:20:31

From: Ashaman88
I fixed the gametab thing on justin's other thread, at least it works for me

That's changing the algorithm slightly, and introducing tolerance to the function which i'm not sure if it's a good idea. Anyway try my attached file, everything should be fixed now, if it doesn't report it here.

Also make sure you update your SRL to get the bank.simba fix. SRL>Check for updates. (Inb4 SmartParams error)

Laimonas171

2012-10-24 10:24:12

kinda of topic, main map have been changed a bit, then you are in city varrock or falador it gets red overly, for now only these two are changed.
I guess they change not only randoms being off.

Mr[S]

2012-10-24 10:26:07

New SRL update is working perfectly for me on litoris's Iron Man

Ian

2012-10-24 10:33:34

So should I replace with your file then update? Or not update? Thanks Riwu :)

QQu

2012-10-24 10:44:21

It's working, back to normal now. Don't need to change anything. Just make sure you click SRL -> Check for updates within Simba and restart it.

Ashaman88

2012-10-24 10:48:21

From: riwu
That's changing the algorithm slightly, and introducing tolerance to the function which i'm not sure if it's a good idea. Anyway try my attached file, everything should be fixed now, if it doesn't report it here.

Also make sure you update your SRL to get the bank.simba fix. SRL>Check for updates. (Inb4 SmartParams error)


Yeah the only reason i changed it to that is for future slight changes to the colors can be handled by tolerance, but there are lots of solutions

freezeyp

2012-10-24 10:52:09

From: QQu
It's working, back to normal now. Don't need to change anything. Just make sure you click SRL -> Check for updates within Simba and restart it.

Wow, your guys are awesome. Update the include within a few hours. Thanks

yakkyigooconroy

2012-10-24 11:03:19

Thanks for the timely update

krasniy

2012-10-24 11:13:15

Awesome and with such speed!!!! Thank you Kindly to all of those who collaborated on the update!

Jeroen

2012-10-24 12:22:33

Wow thank you all the coders and scripters. Awesome! :)

Master BAW

2012-10-24 13:48:23

for some reason it can't see wheter i'm in a gametab or not :(

Mr[S]

2012-10-24 13:51:21

From: Master BAW
for some reason it can't see wheter i'm in a gametab or not :(


Update your SRL

Ian

2012-10-24 15:34:41

Do my dtm's need to be updated? It can't find any now.

E: Updated my dtm's but it still won't find them. (they are in the magic tab)

John

2012-10-24 18:25:45

From: riwu
That's changing the algorithm slightly, and introducing tolerance to the function which i'm not sure if it's a good idea. Anyway try my attached file, everything should be fixed now, if it doesn't report it here.

Also make sure you update your SRL to get the bank.simba fix. SRL>Check for updates. (Inb4 SmartParams error)


You should be given some sort of developer/FixIt AI

___

2012-10-24 20:50:57

trying the update now… but before it just hovered over the invtab.

Justin

2012-10-24 22:12:02

From: ___
trying the update now… but before it just hovered over the invtab.


Make sure you close and re-open Simba after the update



From: riwu

…
(Inb4 SmartParams error)


There is a {$DEFINE SMART8} function now, up to the scripters\users to define it if they are going to be using Smart 8 :P

riwu

2012-10-24 22:15:21

From: [J]ustin
There is a {$DEFINE SMART8} function now, up to the scripters\users to define it if they are going to be using Smart 8 :P

It may have some compatibility issues with some other components. Right now i realize the ODTM include checks for {$DEFINE SMART} so there will be some conflicts if you define 8 instead.

And even then you have to change every script to {$DEFINE SMART8}, and when smart upgrades (eg. to 9) you have to update your script, and worse, if the user is still using SMART 7 it won't work for them. So basically i think just removing the -1 every SRL update is simpler. Or don't use the autoupdater, get the updates from git directly.

Btw seems like the fix is in the autoupdater now. Restart all Simba binaries after update.

Justin

2012-10-24 22:20:45

From: riwu
It may have some compatibility issues with some other components. Right now i realize the ODTM include checks for {$DEFINE SMART} so there will be some conflicts if you define 8 instead.

And even then you have to change every script to {$DEFINE SMART8}, and when smart upgrades (eg. to 9) you have to update your script, and worse, if the user is still using SMART 7 it won't work for them. So basically i think just removing the -1 every SRL update is simpler. Or don't use the autoupdater, get the updates from git directly.

Btw seems like the fix is in the autoupdater now.


Smart 7 will get over-written by Smart 8. I am sure there will be a function in smart.simba that will be checking for {$DEFINE SMART8} and will just ignore it and load the correct parameters

E: Either way the devs know what they are doing and they will be able to push the updates out in the future without breaking much (as it has been in the past)

riwu

2012-10-24 22:24:55

From: [J]ustin
Smart 7 will get over-written by Smart 8. I am sure there will be a function in smart.simba that will be checking for {$DEFINE SMART8} and will just ignore it and load the correct parameters

E: Either way the devs know what they are doing and they will be able to push the updates out in the future without breaking much (as it has been in the past)

  {$IFDEF SMART8}
Result := SmartSpawnClient(ReplaceWrap(PluginPath, '\', '/', [rfReplaceAll]), Params[0], ',' + Params[1], 765, 553, 's', '', '');
{$ELSE}
Result := SmartSpawnClient(ReplaceWrap(PluginPath, '\', '/', [rfReplaceAll]), Params[0], ',' + Params[1], 765, 553, 's', '', '', -1);
{$ENDIF}
If you define 8, and the user is using 7, they will get a invalid param error instead. (and for the fact that they are still using 7 implies that you can't expect them to fix it themselves and they will come bug you on your thread) Anyway it's personal preference, up to the individual users to decide which way is better.

EDIT: the code above is in the includes, not plugin. Which is why they get rewritten every time SRL updates.

Justin

2012-10-24 22:26:16

From: riwu
  {$IFDEF SMART8}
Result := SmartSpawnClient(ReplaceWrap(PluginPath, '\', '/', [rfReplaceAll]), Params[0], ',' + Params[1], 765, 553, 's', '', '');
{$ELSE}
Result := SmartSpawnClient(ReplaceWrap(PluginPath, '\', '/', [rfReplaceAll]), Params[0], ',' + Params[1], 765, 553, 's', '', '', -1);
{$ENDIF}
If you define 8, and the user is using 7, they will get a invalid param error instead. Anyway it's personal preference, up to the individual users to decide which way is better.


*facepalm*

I understand what you are on about now :redface:

I was thinking of something else


Plugins weren't updates so why would they start to get invalid param errors now?

Anyway, back on-topic now

Solar

2012-10-25 02:14:29

I don't think WorldInfo := [96,96]; works now, at least not for Flight's lividfarmer script.

riwu

2012-10-25 02:22:52

From: Solar
I don't think WorldInfo := [96,96]; works now, at least not for Flight's lividfarmer script.

What is your intention to have 2 same integers in the array? Also it should still work as before, index 0 is simply ignored when you have length higher than 1. I couldn't think of any way in which a script will be broken because of the fix. In fact iirc correctly it was the previous code that will give an error when you have 2 integers, since there will be a type mismatch error for the first index.

Also i've just checked Flight's script, it doesn't even have WorldInfo defined?

Solar

2012-10-25 03:50:25

From: riwu
What is your intention to have 2 same integers in the array? Also it should still work as before, index 0 is simply ignored when you have length higher than 1. I couldn't think of any way in which a script will be broken because of the fix. In fact iirc correctly it was the previous code that will give an error when you have 2 integers, since there will be a type mismatch error for the first index.

Also i've just checked Flight's script, it doesn't even have WorldInfo defined?


The version I am using is the one that Ashaman altered slightly. When I saw that 96 was in the array twice I did wonder why, but simply ignored it since it seemed to work.
I'll try it again, but when I used it this morning it didn't choose 96.

Edit: Okay, so I just tried it while already logged into the lobby, and it worked. Not sure what happened, although there was an SRL update inbetween when it didn't work and when I just tried it now.

Master BAW

2012-10-25 06:56:57

I've a question about this SMART 8 thing. I have SMART 8 installed a month ago, but every time I updated SRL I got a SRL compile error in SmartParams and in paintsmart.

now I started the script with this:

{$DEFINE SMART} // This is how we include SMART
{$DEFINE SMART8} // tell the system that we have smart 8
instead of what I had first:
{$DEFINE SMART} // This is how we include SMART

but now I still get one compile error:

[Error] C:\Simba\Includes\SRL/SRL/misc/paintsmart.simba(42:33): Unknown identifier 'SmartGetDebugDC' at line 41
Compiling failed.

Is there something I'm missing to get rid of these compile errors after every SRL update?

because Now everytime I have to replace this
SMART_Canvas.canvas.handle := SmartGetDebugDC;
with this:
SMART_Canvas.canvas.handle := 0;

Ashaman88

2012-10-25 06:59:36

I always try to have two world choices but for that one I just left them both 96. And yeah it was just that riwu's fix hadn't hit the servers yet

riwu

2012-10-25 07:07:09

From: Master BAW
I've a question about this SMART 8 thing. I have SMART 8 installed a month ago, but every time I updated SRL I got a SRL compile error in SmartParams and in paintsmart.

now I started the script with this:

{$DEFINE SMART} // This is how we include SMART
{$DEFINE SMART8} // tell the system that we have smart 8
instead of what I had first:
{$DEFINE SMART} // This is how we include SMART

but now I still get one compile error:

[Error] C:\Simba\Includes\SRL/SRL/misc/paintsmart.simba(42:33): Unknown identifier 'SmartGetDebugDC' at line 41
Compiling failed.

Is there something I'm missing to get rid of these compile errors after every SRL update?

because Now everytime I have to replace this
SMART_Canvas.canvas.handle := SmartGetDebugDC;
with this:
SMART_Canvas.canvas.handle := 0;

Change that paintsmart to
{$I SRL/SRL/Misc/SmartGraphics.Simba}
If you have any problem related to SMART either search them and try resolve it or just remove them (it may break the paint but won't break the script)

Ian

2012-10-26 22:01:16

Anyone know if InvCount works in browsers? I have a part like this:
If InvCount=PlusOne Then
WriteLn('Digging...');
Until(InvCount=PlusOne) Or (TimeFromMark(OreCounter) > 4000)

To check if the rock has been mined but when I was using it in the browser (not SMART), It was always waiting for the marktime fallback even if it mined the ore. I know the code is right because I have not changed anything and it worked earlier, but in a smart window not the browser.

So to recap: Does InvCounting work in browsers since the gametab update?
Also detection for the rocks was much slower than with smart. Any ideas?

riwu

2012-10-26 22:17:15

From: BMWxi
Anyone know if InvCount works in browsers? I have a part like this:
If InvCount=PlusOne Then
WriteLn('Digging...');
Until(InvCount=PlusOne) Or (TimeFromMark(OreCounter) > 4000)

To check if the rock has been mined but when I was using it in the browser (not SMART), It was always waiting for the marktime fallback even if it mined the ore. I know the code is right because I have not changed anything and it worked earlier, but in a smart window not the browser.

So to recap: Does InvCounting work in browsers since the gametab update?
Also detection for the rocks was much slower than with smart. Any ideas?



There should be no difference between botting with Smart or with browser.

The code doesn't make sense to me though, on the if check your debug says it's still digging, but on the until check you break the loop. Can you post the whole routine?

Ian

2012-10-26 22:18:44

From: riwu
There should be no difference between botting with Smart or with browser.

The code doesn't make sense to me though, can you post the whole routine?


I don't know if I am allowed, it is for the Jr Member copmpetition. Maybe I'll censor out some non relevant code.

Actually could I PM it to you if you're not a judge?

riwu

2012-10-26 22:21:00

From: BMWxi
I don't know if I am allowed, it is for the Jr Member copmpetition. Maybe I'll censor out some non relevant code.

Actually could I PM it to you if you're not a judge?

Oh ok, i'm not a judge but i'm probably not supposed to help too much either. You can pm me and if there's error i'll point it out but i can't give you suggestion/fix.

Ian

2012-10-26 22:22:17

From: riwu
Oh ok, i'm not a judge but i'm probably not supposed to help too much either. You can pm me and if there's error i'll point it out but i can't give you suggestion/fix.


Ok, don't tell me how to fix it if the problem is on my end, just if it's a problem with using a browser/the gametab update.

E: Riwu couldn't see why it wouldn't work so I'll just try with smart later.

speedster

2012-10-27 10:14:31

Freaked out a little after one week of inactivty to come back and see some functions were not working :) Will be testing this thing out.

Ok updated :

Bug :

"LoadWorldArrays: Could not load world arrays, attempting to rewrite Worlds.INI
NOTE: Attempting to update the Worlds.INI, please allow the script to access this file.
Skipping world "1" because explosion didn't return enough values
Parsed Worlds Page into Worlds.INI. Took 422 ms.
** Warning in FindWorld: World -1 does not exist in worlds.ini **
Failed to find World -1!"

Using : Players[0].WorldInfo := [True, -1, False];


Worlds.ini :

[Worlds]
Count=1
High=0

[World0]
Type=Free
LootShare=False
QuickChat=False
PvP=False


Simba/Srl Doesn't parse the worlds.ini file…

Ian

2012-10-27 10:27:50

I just tested the same thing as my earlier post but with smart this time, not the browser, and everything works. For some reason using the browser made it detect rocks really slowly and not count inventory.