SRL Archive - SRL Bugs

FoundBar/LoggedIn false positive when 'loading'


riwu

2012-10-10 04:42:46


FoundBar checks the existence of bitmap 'H' (shown above) of the 'Home' shown by the nav bar. However, it's common to frequently receive the message 'Loading - please wait.' in RS, which coincidentally covers up the H completely, resulting in FoundBar returning false. As FoundBar is used in SRL_ResetNavBar, which is in turn used in LoggedIn, this results in LoggedIn returning false if the function is called while the 'Loading' is displayed, and y offset will be set to -22 instead of -50, resulting in no chance of the script recovering (even multiplayer will fail since it can't log in).

Fix:
I created a bitmap of the 'S' of the 'Support' instead which is not covered up.
SRL_NAVBAR_BITMAP:= BitmapFromString(8, 13, 'meJzj4pfi4FcS1fFMOnu78sefsF1' +
'nRbXcOPmkOPjkZGwi8198Dd99HkgCpZLP32Xnk2PjU0m/81k+oJJV' +
'3JNLITD5wj31qAp2fmWg4oLXP6x6trJIBrJKBoqaZLAKW7IJaIrpe' +
'mfc+wZE7stPyjhVAaVYxZzZRCzZBXWsWlfEXPkGQe7LToqaZrFKeH' +
'EIarEI26ilzQk5+QmOgBrZBbXFDKOACrgMcgzrN/od/gxEjvPPyPu' +
'Xy4b2AsVZpYKACMh22fYRiCyWv9ea8oJLMYhVwhsipZK7Xqf1uGLZ' +
'YcP5b3RbTwDNAemS8FLJW89lkMsu7qjQ8UJr+hsgUqw4BkTSkXPZR' +
'G24hdXYxZ1EotcodL2SqHvK69jNIaTLJawDAP1wcSY=');
Search area is also changed to 278, 11, 293, 32. Other than that no other changes should be required.

Let me know if i've overlooked anything before i send a pull request.

P1ng

2012-10-10 04:52:52

Looks good to me. Although I've never had an issue with this I'm sure it happens to others. Nice work!

xtrapsp

2012-10-10 08:59:34

Is it not possible to remove the div tag within SMART?

riwu

2012-10-10 09:01:30

From: xtrapsp
Is it not possible to remove the div tag within SMART?

What do you mean? Div tag?

litoris

2012-10-10 09:08:09

Just posting here, I think all check for the login should be small bitmaps rather than GetColor at a certain point. The shop interface stuff are also broken, I got a color count in the scroll bar of shops to check for them in a private script though.

whisper133

2012-10-16 01:05:20

how do i add this, or what do i do with it? sorry im just getting to know this whole scripting thing

riwu

2012-10-16 01:08:10

From: whisper133
how do i add this, or what do i do with it? sorry im just getting to know this whole scripting thing

SRL>Check for Update at the top of Simba.

whisper133

2012-10-16 10:26:43

From: riwu
SRL>Check for Update at the top of Simba.


oh ok i knew that i just thought we ahd to add the code on OP somewhere, thanks :)

xtrapsp

2012-10-16 11:40:58

From: riwu
What do you mean? Div tag?


Web design, Div tags are what website are constructed with.

riwu

2012-10-16 19:52:48

From: xtrapsp
Web design, Div tags are what website are constructed with.

You mean removing the nav bar? The nav bar is now part of the client (you cant target RS w/o including it) so i don't think it's possible. Can possibly 'hide' it by adjusting SMART to have it above the visible range but no point doing so since it still exists there and hence affect coordinates.

Justin

2012-10-17 00:50:23

Looks good to me. Send in a pull request.

Scorched

2012-10-19 12:06:20

I am a bit confused here. I made sure my SRL is up to date within Simba yet I am still getting this error with the LRC Miner script. Possibly this is an issue specific to the script?

How can I change the bitmap within SRL? or is this fix automatically implemented?

Getdropped

2012-10-26 21:34:45

This: http://villavu.com/forum/showthread.php?t=91757 would fix it because you would just search for if logged in ;) and if not found then it checks for the navbar :p

Justin

2012-11-17 05:11:28

From: xtrapsp
Web design, Div tags are what website are constructed with.


Won't work. It's embedded into the client, not the webpage.