SRL Archive - OSR Help

Hey guys,

Been having an issue with logins.

Basically whenever I login the account it says I have 1 week trial left which is all fine… yea thanks for telling me. But It's gotten to the point where Smart bugs out.

LoginPlayerToLob;
        wait(60000+ Random(3000));
        LoginPlayer;

This is the simba for it so far, I've tried making it look for the Bitmaps, MMouse with a Y of -50 etc.

Basically after a set time the popup vanishes but by default Simba starts spam clicking the become a member tab in the lobby. This results in Google Chrome opening ALOT of tabs.

Any suggesitons?

Will need to be coded into login.simba

1580: Actions := ['Less then 1 week of membership left', 2500,  3,    'WeekMember',    ''];

^^ around line 800

         'WeekMember':
         begin
            //Do work here
          Result := True;
         end; 

^^around line 853

Doesn't work :( any other suggestions?

This is because LoginPlayerToLob will loop through a series of response until LobbyScreen is shown, which probably returns false since the pop up blocks the detection. You can either copy paste the function and modify it or just modify from the include. At line 771 of your login include file, add something like:

if FindBitmap/CountColor etc then  //a method to detect the trial window
Break;

If it still spam clicks something, means one of the checks below did it, so either figure out which it is, or just

if FindBitmap/CountColor etc then  //a method to detect the trial window
Break 
else
Continue //restarts the loop, so it wont try to check other stuffs

From: riwu
This is because LoginPlayerToLob will loop through a series of response until LobbyScreen is shown, which probably returns false since the pop up blocks the detection. You can either copy paste the function and modify it or just modify from the include. At line 771 of your login include file, add something like:

if FindBitmap/CountColor etc then  //a method to detect the trial window
Break;

If it still spam clicks something, means one of the checks below did it, so either figure out which it is, or just

if FindBitmap/CountColor etc then  //a method to detect the trial window
Break 
else
Continue //restarts the loop, so it wont try to check other stuffs

Thats a different method to mine but I will give it a go thanks

edit:

It still tries to keep clicking the member section :S

Line 590 of login.simba and further
The mousebox was not 100% correct I believe but you should get the idea. You basicly need to add OneWeekScreen to the check. Login.simba performs multiple checks to see if you have logged it, but can't detect some stuff because the one week screen is in front of other stuff.

(*
OneWeekScreen
~~~~~~~~~~~
By J J

Description:
Closes the one week of trial membership left pop up
*)

function OneWeekScreen: boolean;
var
  Bmp, X, Y, t: Integer;

begin
  Bmp := BitmapFromString(25, 16, 'meJzTiyiyaJ5jU9qu3rxYZvkt2eW3LNffdl9yGA9Sn3lIFqwSiPQnblWrnunUNssiNM512kagXoi40ORjQNMgSJYQAiqGs4EmpJ56DnQMUBAXQtOLR5nL+itA5+FXA/SCdmoNfhuBCOhxPEYBvWkz/YC4giojA4O4vCp+04BGAQMcyOBv3YwmBRQBhoBF82ygOUDEwcYCdBsulWhGYSKg77ym7Jc3NAcaBSQhrsKqEmIU0C6sshAEDMzwqUuBfgQ6D5gGcCkjxiigH52ySrm5uYHKFCbuwmMUMFTxGAVUYLnwFNyDuIzirVgCJIHpE2IUkIuJgEYZti/ScvKWMzQHksCwwqUSYpReRBEeBUCXAF0ORMDUhUsZslG4FMCVwT2CR41N/yqIUTylc1HRHGwic1AZCJXIRlGC4EZB8hflyLN3BQDPxATj');
  MarkTime(t);
  while TimeFromMark(t) < 10000 do
  begin
    Wait(RandomRange(250, 500));
    if FindBitmapToleranceIn(Bmp, X, Y, 0, 0, 750, 530, 20) then
    begin
      Mousebox(309, 365, 458, 380, 1);
      Result := True;
      break;
    end;
  end;
  FreeBitmap(Bmp);
  Wait(RandomRange(1000, 2000));
end;

(*
LoginPLayerToLob
~~~~~~~~~~~~~~~~

.. code-block:: pascal

    function LoginPlayerToLob: Boolean;

Like LoginPlayer but only to the lobbyscreen.

.. note::

    by SRL Dev Team

Example:

.. code-block:: pascal

    LoginPlayerToLob();
    if (not LobbyScreen()) then
      LoginPlayerToLob(); // try again!

*)
function LoginPlayerToLob: Boolean;
var
  Members, RetryLogin: Boolean;
  typtmp, t, w: integer;
  Actions: TVariantArray;
  Attempts: LongInt;
  p: TPoint;
  //ATPA: T2dPointArray;
  TPA: TPointArray;
  Boxes : TIntegerArray;
  //B: TBox;
label
  ProcStart;
begin
  ActivateClient;
  Wait(100);
  TypeByte(vk_Escape);
  Wait(500);

         {Check for lobby screen already open/ already logged in}

  Result := ((LobbyScreen) or (LoggedIn));
  if (Result) then
    Exit;

                       {Check for active player.}

  if (not (Players[CurrentPlayer].Active)) then
  begin
    WriteLn('Player is not Active...');
    if (AllPlayersInActive) then
    begin
      WriteLn('All players not active!');
      Exit;
    end;
    NextPlayer(False);
    Exit;
  end;

               {Wait for the client to finish loading.}

  T := GetSystemTime;
  repeat
    if (RSReady) then
      Break;
    if ((GetSystemTime - T) > 180000) then
    begin
      WriteLn('It has been 3 minutes and Runescape is not yet ready... Terminating.');
      TerminateScript;
    end;
    Wait(RandomRange(1000, 2000));
  until (False);
  WriteLn('Welcome to Runescape.');


                   {New graphics have changed box}
  Case CountColor(LOGIN_TEXTCOLOUR, 198, 192, 567, 259) of
    1079: MouseBox(347, 295, 414, 303, mouse_left);
    1745: MouseBox(347, 305, 414, 312, mouse_left); { "Available graphics options have been changed..." }
    1801: MouseBox(347, 305, 414, 312, mouse_left); { "There was a problem with your current graphics settings..." }
  end;

                   {Click less info if needed.}
  {
  if (not (SimilarColors(GetColor(382, 11), 14285562, 20))) then //Runescae sword green bead
  begin
    MouseBox(212, 479, 550, 495, 1); //Less info button
    Wait(RandomRange(1000, 2000));
  end;
  }
                      {Click Members/free.}

  Members := Players[CurrentPlayer].Member;
  if (Length(Players[CurrentPlayer].WorldInfo) > 0) then
    Members := Players[CurrentPlayer].WorldInfo[0];

  ProcStart:

                       {Type in username and pass}

  if (loggedIn) then
    exit;

  for W:= 0 to 1 do
  begin
    if W = 0 then
      Boxes:= [UBX1, UBY1, UBX2, UBY2]
    else
      Boxes:= [PBX1, PBY1, PBX2, PBY2];

    t := (getSystemTime + (60000 * 2));
    FindColors(TPA, LOGIN_TEXTCOLOUR, Boxes[0], Boxes[1], Boxes[2], Boxes[3]);
    repeat
      if (Length(TPA) > 0) then
      begin
        SortTPAFrom(TPA, Point(Boxes[2], Boxes[1] + (Boxes[3] - Boxes[2]) div 2));
        p := point(TPA[0].X + 20, TPA[0].Y);
        if (not pointInBox(p, intToBox(Boxes[0], Boxes[1], Boxes[2], Boxes[3]))) then
          p := point(UBX2 - (10 + random(10)), p.y);
        Mouse(p.x, p.y, 5, 5, mouse_left);
      end else
        MouseBox(Boxes[0], Boxes[1], Boxes[2], Boxes[3], mouse_left);

      typtmp := 0;
      while (CountColor(LOGIN_TEXTCOLOUR, Boxes[0], Boxes[1], Boxes[2], Boxes[3]) > 0) do
      begin
        Inc(typtmp);
        TypeByte(VK_BACK);
        Wait(50+Random(50));
        if (typtmp >= RandomRange(20, 24)) then
          Break;
      end;
    until(not FindColors(TPA, LOGIN_TEXTCOLOUR, Boxes[0], Boxes[1], Boxes[2], Boxes[3]) or (getSystemTime > t));

    Wait(100 + Random(200));
    if W = 0 then
    begin
      WriteLn(Capitalize(Players[CurrentPlayer].Name));
      TypeSend(Players[CurrentPlayer].Name);
    end else
      TypeSend(Players[CurrentPlayer].Pass);
    Wait(100 + Random(50));
  end;

                        {Check responses}

  T := GetSystemTime;
  repeat
    // so the lobby appears (gets rid of black screen)
    if (countColorTolerance(clBlack, 0, 0, 500, 500, 20) > 245000) then
    begin
      wait(2000 + random(1500));
      mouseBox(0, 0, 750, 490, mouse_Move);
    end;
    SRL_ResetNavBar;
    Result := ((validEmail) or (OneWeekScreen));
    if result then
      break;

    SetLength(Actions, 0);

    if ((GetSystemTime - T) > 60000) then
      Actions :=       ['One minute has passed... Debug: ' + ToStr(CountColor(LOGIN_TEXTCOLOUR, 260, 140, 510, 400)),              0,    5,    'PlayerFalse',   'Login Failed']
    else
    case (CountColor(LOGIN_TEXTCOLOUR, 260, 140, 510, 400)) of //text colour points
                        // WriteLn Error                  Wait for   Retrys     Action      Player[CurrentPlayer].Loc
      763, 2348, 2299:
            Actions := ['Invalid Username / Password',           0,    2,    'PlayerFalse',   'Wrong User/Pass'];
      1088: Actions := ['Your account has been disabled',        0,    0,    'PlayerFalse',   'Acc Disabled'];
       951: Actions := ['Your account is already logged in',  5000,    5,    'PlayerTrue',    'Already logged in'];
      1239: Actions := ['Not a Members Account',                 0,    1,    'PlayerTrue',    ''];
       364: Actions := ['Error Connecting.',                 20000,    9,    'Terminate',     'Error Connecting'];
      1057: Actions := ['Too many incorrect logins.',    5 * 60000,    2,    'PlayerFalse',   'Too many logins'];
       732: Actions := ['Runescape has been updated.',           0,    0,    'RSUpdate',      'RS Updated'];
       591: Actions := ['Client token changed.',                 0,    0,    'RSUpdate',      'Client Token Changed'];
      1606: Actions := ['Game session expired.',                 0,    0,    'RSUpdate',      'Session Expired'];
       777: Actions := ['Login limit exceeded.',             20000,   10,    '',              'Waiting for login.'];
    end;
                             {Respond}

    if (Length(Actions) > 0) then
    begin
      WriteLn(Actions[0]);
      if (Actions[0] <> 'Not a Members Account') then
      begin
        Wait(1000 + Random(500));
        TypeByte(vk_Escape);
      end;
      Wait(Actions[1] + Random(100));
      if (Actions[2] <> 0) then
        if (Attempts < Actions[2]) or (Actions[2] = -1) then
        begin
          if (Actions[0] = 'Not a Members Account') then
          begin
            Players[CurrentPlayer].Member := False;
            if (Length(Players[CurrentPlayer].WorldInfo) > 0) then
              Players[CurrentPlayer].WorldInfo[0] := False;
            MouseBox(267, 321, 496, 350, mouse_left); //Play free game instead button
            Wait(3000 + Random(2000));
            Result := True;
            Exit;
          end;
          RetryLogin := True;
          Wait(2000 + Random(1000));
          Break;
        end;
      if (Actions[4] <> '') then
        Players[CurrentPlayer].Loc := Actions[4];
      case Actions[3] of
        'PlayerFalse': NextPlayer(False);

        'PlayerTrue':
          begin
            LeaveLobby();
            NextPlayer(True);
          end;

        'Terminate': TerminateScript;

        'RSUpdate':
          begin
            if SRL_HasProc(srl_OnRSUpdate) then
            begin
              SRL_Procs[srl_OnRSUpdate]();
              Exit;
            end;
            Writeln('Runescape has been updated! Please restart Simba.');
            TerminateScript;
          end;
      end;
      Exit;
    end;
    Wait(100);
    Result := (LobbyScreen) or (LoggedIn) or (OneWeekScreen);
  until (Result);

  TakeIPScreen();

                     {Back to main screen if needed}

  if (RetryLogin) then
  begin
    RetryLogin := False;
    Inc(Attempts);
    goto ProcStart;
  end;

end;

Near the end is what I added I believe maybe some more stuff

    Result := (LobbyScreen) or (LoggedIn) or (OneWeekScreen);
  until (Result);

Result would never be true without adding the oneweekscreen function :P

EDIT: Correct mousebox: Mousebox(309, 365, 458, 380, 1);
Edited it in the function aswell.

From: J J
Line 590 of login.simba and further
The mousebox was not 100% correct I believe but you should get the idea. You basicly need to add OneWeekScreen to the check. Login.simba performs multiple checks to see if you have logged it, but can't detect some stuff because the one week screen is in front of other stuff.

(*
OneWeekScreen
~~~~~~~~~~~
By J J

Description:
Closes the one week of trial membership left pop up
*)

function OneWeekScreen: boolean;
var
  Bmp, X, Y, t: Integer;

begin
  Bmp := BitmapFromString(25, 16, 'meJzTiyiyaJ5jU9qu3rxYZvkt2eW3LNffdl9yGA9Sn3lIFqwSiPQnblWrnunUNssiNM512kagXoi40ORjQNMgSJYQAiqGs4EmpJ56DnQMUBAXQtOLR5nL+itA5+FXA/SCdmoNfhuBCOhxPEYBvWkz/YC4giojA4O4vCp+04BGAQMcyOBv3YwmBRQBhoBF82ygOUDEwcYCdBsulWhGYSKg77ym7Jc3NAcaBSQhrsKqEmIU0C6sshAEDMzwqUuBfgQ6D5gGcCkjxiigH52ySrm5uYHKFCbuwmMUMFTxGAVUYLnwFNyDuIzirVgCJIHpE2IUkIuJgEYZti/ScvKWMzQHksCwwqUSYpReRBEeBUCXAF0ORMDUhUsZslG4FMCVwT2CR41N/yqIUTylc1HRHGwic1AZCJXIRlGC4EZB8hflyLN3BQDPxATj');
  MarkTime(t);
  while TimeFromMark(t) < 10000 do
  begin
    Wait(RandomRange(250, 500));
    if FindBitmapToleranceIn(Bmp, X, Y, 0, 0, 750, 530, 20) then
    begin
      Mousebox(309, 365, 458, 380, 1);
      Result := True;
      break;
    end;
  end;
  FreeBitmap(Bmp);
  Wait(RandomRange(1000, 2000));
end;

(*
LoginPLayerToLob
~~~~~~~~~~~~~~~~

.. code-block:: pascal

    function LoginPlayerToLob: Boolean;

Like LoginPlayer but only to the lobbyscreen.

.. note::

    by SRL Dev Team

Example:

.. code-block:: pascal

    LoginPlayerToLob();
    if (not LobbyScreen()) then
      LoginPlayerToLob(); // try again!

*)
function LoginPlayerToLob: Boolean;
var
  Members, RetryLogin: Boolean;
  typtmp, t, w: integer;
  Actions: TVariantArray;
  Attempts: LongInt;
  p: TPoint;
  //ATPA: T2dPointArray;
  TPA: TPointArray;
  Boxes : TIntegerArray;
  //B: TBox;
label
  ProcStart;
begin
  ActivateClient;
  Wait(100);
  TypeByte(vk_Escape);
  Wait(500);

         {Check for lobby screen already open/ already logged in}

  Result := ((LobbyScreen) or (LoggedIn));
  if (Result) then
    Exit;

                       {Check for active player.}

  if (not (Players[CurrentPlayer].Active)) then
  begin
    WriteLn('Player is not Active...');
    if (AllPlayersInActive) then
    begin
      WriteLn('All players not active!');
      Exit;
    end;
    NextPlayer(False);
    Exit;
  end;

               {Wait for the client to finish loading.}

  T := GetSystemTime;
  repeat
    if (RSReady) then
      Break;
    if ((GetSystemTime - T) > 180000) then
    begin
      WriteLn('It has been 3 minutes and Runescape is not yet ready... Terminating.');
      TerminateScript;
    end;
    Wait(RandomRange(1000, 2000));
  until (False);
  WriteLn('Welcome to Runescape.');


                   {New graphics have changed box}
  Case CountColor(LOGIN_TEXTCOLOUR, 198, 192, 567, 259) of
    1079: MouseBox(347, 295, 414, 303, mouse_left);
    1745: MouseBox(347, 305, 414, 312, mouse_left); { "Available graphics options have been changed..." }
    1801: MouseBox(347, 305, 414, 312, mouse_left); { "There was a problem with your current graphics settings..." }
  end;

                   {Click less info if needed.}
  {
  if (not (SimilarColors(GetColor(382, 11), 14285562, 20))) then //Runescae sword green bead
  begin
    MouseBox(212, 479, 550, 495, 1); //Less info button
    Wait(RandomRange(1000, 2000));
  end;
  }
                      {Click Members/free.}

  Members := Players[CurrentPlayer].Member;
  if (Length(Players[CurrentPlayer].WorldInfo) > 0) then
    Members := Players[CurrentPlayer].WorldInfo[0];

  ProcStart:

                       {Type in username and pass}

  if (loggedIn) then
    exit;

  for W:= 0 to 1 do
  begin
    if W = 0 then
      Boxes:= [UBX1, UBY1, UBX2, UBY2]
    else
      Boxes:= [PBX1, PBY1, PBX2, PBY2];

    t := (getSystemTime + (60000 * 2));
    FindColors(TPA, LOGIN_TEXTCOLOUR, Boxes[0], Boxes[1], Boxes[2], Boxes[3]);
    repeat
      if (Length(TPA) > 0) then
      begin
        SortTPAFrom(TPA, Point(Boxes[2], Boxes[1] + (Boxes[3] - Boxes[2]) div 2));
        p := point(TPA[0].X + 20, TPA[0].Y);
        if (not pointInBox(p, intToBox(Boxes[0], Boxes[1], Boxes[2], Boxes[3]))) then
          p := point(UBX2 - (10 + random(10)), p.y);
        Mouse(p.x, p.y, 5, 5, mouse_left);
      end else
        MouseBox(Boxes[0], Boxes[1], Boxes[2], Boxes[3], mouse_left);

      typtmp := 0;
      while (CountColor(LOGIN_TEXTCOLOUR, Boxes[0], Boxes[1], Boxes[2], Boxes[3]) > 0) do
      begin
        Inc(typtmp);
        TypeByte(VK_BACK);
        Wait(50+Random(50));
        if (typtmp >= RandomRange(20, 24)) then
          Break;
      end;
    until(not FindColors(TPA, LOGIN_TEXTCOLOUR, Boxes[0], Boxes[1], Boxes[2], Boxes[3]) or (getSystemTime > t));

    Wait(100 + Random(200));
    if W = 0 then
    begin
      WriteLn(Capitalize(Players[CurrentPlayer].Name));
      TypeSend(Players[CurrentPlayer].Name);
    end else
      TypeSend(Players[CurrentPlayer].Pass);
    Wait(100 + Random(50));
  end;

                        {Check responses}

  T := GetSystemTime;
  repeat
    // so the lobby appears (gets rid of black screen)
    if (countColorTolerance(clBlack, 0, 0, 500, 500, 20) > 245000) then
    begin
      wait(2000 + random(1500));
      mouseBox(0, 0, 750, 490, mouse_Move);
    end;
    SRL_ResetNavBar;
    Result := ((validEmail) or (OneWeekScreen));
    if result then
      break;

    SetLength(Actions, 0);

    if ((GetSystemTime - T) > 60000) then
      Actions :=       ['One minute has passed... Debug: ' + ToStr(CountColor(LOGIN_TEXTCOLOUR, 260, 140, 510, 400)),              0,    5,    'PlayerFalse',   'Login Failed']
    else
    case (CountColor(LOGIN_TEXTCOLOUR, 260, 140, 510, 400)) of //text colour points
                        // WriteLn Error                  Wait for   Retrys     Action      Player[CurrentPlayer].Loc
      763, 2348, 2299:
            Actions := ['Invalid Username / Password',           0,    2,    'PlayerFalse',   'Wrong User/Pass'];
      1088: Actions := ['Your account has been disabled',        0,    0,    'PlayerFalse',   'Acc Disabled'];
       951: Actions := ['Your account is already logged in',  5000,    5,    'PlayerTrue',    'Already logged in'];
      1239: Actions := ['Not a Members Account',                 0,    1,    'PlayerTrue',    ''];
       364: Actions := ['Error Connecting.',                 20000,    9,    'Terminate',     'Error Connecting'];
      1057: Actions := ['Too many incorrect logins.',    5 * 60000,    2,    'PlayerFalse',   'Too many logins'];
       732: Actions := ['Runescape has been updated.',           0,    0,    'RSUpdate',      'RS Updated'];
       591: Actions := ['Client token changed.',                 0,    0,    'RSUpdate',      'Client Token Changed'];
      1606: Actions := ['Game session expired.',                 0,    0,    'RSUpdate',      'Session Expired'];
       777: Actions := ['Login limit exceeded.',             20000,   10,    '',              'Waiting for login.'];
    end;
                             {Respond}

    if (Length(Actions) > 0) then
    begin
      WriteLn(Actions[0]);
      if (Actions[0] <> 'Not a Members Account') then
      begin
        Wait(1000 + Random(500));
        TypeByte(vk_Escape);
      end;
      Wait(Actions[1] + Random(100));
      if (Actions[2] <> 0) then
        if (Attempts < Actions[2]) or (Actions[2] = -1) then
        begin
          if (Actions[0] = 'Not a Members Account') then
          begin
            Players[CurrentPlayer].Member := False;
            if (Length(Players[CurrentPlayer].WorldInfo) > 0) then
              Players[CurrentPlayer].WorldInfo[0] := False;
            MouseBox(267, 321, 496, 350, mouse_left); //Play free game instead button
            Wait(3000 + Random(2000));
            Result := True;
            Exit;
          end;
          RetryLogin := True;
          Wait(2000 + Random(1000));
          Break;
        end;
      if (Actions[4] <> '') then
        Players[CurrentPlayer].Loc := Actions[4];
      case Actions[3] of
        'PlayerFalse': NextPlayer(False);

        'PlayerTrue':
          begin
            LeaveLobby();
            NextPlayer(True);
          end;

        'Terminate': TerminateScript;

        'RSUpdate':
          begin
            if SRL_HasProc(srl_OnRSUpdate) then
            begin
              SRL_Procs[srl_OnRSUpdate]();
              Exit;
            end;
            Writeln('Runescape has been updated! Please restart Simba.');
            TerminateScript;
          end;
      end;
      Exit;
    end;
    Wait(100);
    Result := (LobbyScreen) or (LoggedIn) or (OneWeekScreen);
  until (Result);

  TakeIPScreen();

                     {Back to main screen if needed}

  if (RetryLogin) then
  begin
    RetryLogin := False;
    Inc(Attempts);
    goto ProcStart;
  end;

end;

Near the end is what I added I believe maybe some more stuff

    Result := (LobbyScreen) or (LoggedIn) or (OneWeekScreen);
  until (Result);

Result would never be true without adding the oneweekscreen function :P

EDIT: Correct mousebox: Mousebox(309, 365, 458, 380, 1);
Edited it in the function aswell.

exact where do I put these functions and stuff in?

I really need those functions but I don't know where and what I should get in with which order :(