SRL Archive - Outdated / Broken

Well, i havent written a script for the free community in a long, LONG time :p. So i decided to create a smelter. Not really a demonstration of skill, but a stable script to get you through thousands of bars to smelt.

The DesertFlame smelter is designed for Al-Kharid, and makes approx. 350 - 400 bars an hour. It is Divi compatible, and should get you through a night (hopefully!). So here it is, the DesertFlame Smelter!

Please leave comments, bugs, etc. and check with this script at SRL Stats

Enjoy!

Nice looking script, good job. :)

After a quick look-though.

-good use of FindColoredAreaTolerance in furnace finding.

function WeAreInBank : boolean;
var
  angle : extended;
  BankerDTM : integer;
begin
  BankerDTM := DTMFromString('78DA636C626260F06600035608C5F0E70F139' +
       '86604E2FF40C0D8865F0D98EEA68E1A0007930F53');
  result := FindDTMRotated(BankerDTM,x,y,MMX1,MMY1,MMX2,MMY2,-1.0,2.0,0.2,angle);
end;

Aren`t scorpian npc dots also? Does it ever confuse them 2?

  Item.y := 390;
  Case lowercase(Players[CurrentPlayer].Skill) of
  'bronze'   : Item.x := 40;
  'iron'     : Item.x := 140;
  'silver'   : Item.x := 190;
  'steel'    : Item.x := 245;
  'gold'     : Item.x := 290;
  'mithril'  : Item.x := 345;
  'admantite': Item.x := 400;
  'runite'   : Item.x := 450;
  end;
  Mouse(Item.x,Item.y,15,15,false);

Simple, useful, cool.

Thnx, I may use. I want to make at least 2 smithers!

Actually, the banker DTM is of the four yellow dots together, so it shouldn't screw up :)

[ DesertFlame 1.0 Progress Report
|Script has been running for 27 Minutes and 52 Seconds.
|Gained a total of 5 levels!
|Gained a total of 1365 exp!
|The DesertFlame has gotten 210 bars in all.
|The DesertFlame has done 15 loads in all.
|We are averaging 452 bars per hour!
|We are averaging 32 loads per hour!
<~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~>
Name           : xxxxxxxxxxxxx
Number         : 2
Active         : True
Location       : Bank
Smithing Level : 6
Bars Made      : 70
Loads Done     : 5
Worked for     : 0 minutes.
Banked         : 4 times.

Good work! The form is super nice too!!! I gave it a five.

thanks, lefa!

Btw, the form is just SRL's user manager :P

Were there any problems that occured? SUch as stability, banking, or anything like that?

Ok, Very Nice Script, But I did manage to "break" it a few times …

Whenever furnace icon is to the west, it always clicks outside of building to the west, it does manage to find the furnace from there and come back inside, but it looks a little suspicious walking this same route every time…I just logged out and back in a few times, until the Icon was futher to the east, after this, no problems with that ….

It accidently clicked on the " Man" NPC while it was standing by the furnace and started fighting him, Luckily he is low level and my player pummeled him quickly, but I noticed there was no checking for "find Fight" during this ? ……..

One time the Bank Symbol was covered by other players, and as it walked back to the bank, it stopped, then walked to the door way of the Kebab Shop, and started clicking around the screen looking for the Bank, even after the Bank Symbol was clear again, it just stayed here searching…..

I saw some runes on the ground and picked them up, and when it went back to the bank, it did not deposit them into the bank, but kept them in the inventory, thus making it withdraw the incorrect amount of ores to smelt all the bars, then when it started smelting again, it still had 1 ore left in the inventory, and got stuck in the loop, trying to smelt the 1 bar, I had to stop the script….

________ __
\______ \ ____ ______ ____________/ |_
| | \_/ __ \ / ___// __ \_ __ \ __\
| ` \ ___/ \___ \\ ___/| | \/| |
/_______ /\___ >____ >\___ >__| |__|
\/ \/ \/ \/
___________.__
\_ _____/| | _____ _____ ____
| __) | | \__ \ / \_/ __ \
| \ | |__/ __ \| Y Y \ ___/
\___ / |____(____ /__|_| /\___ >
\/ \/ \/ \/
by:
_ _ _ ____ ____ _ _ ___ ____ _ _
| |\ | |___ |__| |\ | | |__/ \_/ 0 0 1
| | \| | | | | \| | | \ |
<~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~>
| DesertFlame 1.0 Progress Report
|Script has been running for 13 Minutes and 45 Seconds.
|Gained a total of 1 levels!
|Gained a total of 819 exp!
|The DesertFlame has gotten 126 bars in all.
|The DesertFlame has done 9 loads in all.
|We are averaging 550 bars per hour!
|We are averaging 39 loads per hour!
<~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~>
Name :***
Number : 0
Active : True
Location : Bank
Smithing Level : 18
Bars Made : 126
Loads Done : 9
Worked for : 0 minutes.
Banked : 6 times.
<~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~>
0 : *** = True. - Lvl: 18. - W: 0 mins. - Bars: 126. - Loads: 9. - Loc: Bank
**********************************************

I noticed it shows how long the Script has been running for..But Not how long it "worked" for…(Same in Lefamaster's Proggy above)

Also, just a suggestion to make any smelting Script more "Human Like" ….I never enter amounts, whenever possible I use the mouse, much faster….IE, "Withdraw 10 Tin, Withdraw 5 Tin….Put 1 back…Withdraw All Copper"..And NEVER close the bank, just click on MM…Same as entering Exact amounts for bars to make…instead, I enter multiple Digits above 11, IE.."22, 33, 44, Etc"…I know this would be extra work to incorporate into a script, But this is how a "human does it" ….

I also noticed, that after entering the amount of Bars to make, the mouse stays in the same spot (Every Time) , While it is true, that after entering the amount, I usely take my hand off the mouse to wait for it to smelt, but it is usaly dragged across the screen at least a little bit…

Please don't think I am tearing apart your script, I do think it is very nice, these are just my observations…. and I do like the use of the Player Manager, AutoColor, Tolerances and responding when a level is gained…Except someone asked me " Why is it funny that you gained a level ? "….

I Hope this was helpful, RAM

Thanks so much Ram Rune! I really appreciate giving me feedback like that, even if its negative. I always enjoy making my scripts as best as possible.

Once i find a better way to walk, i will implement that in.

Ah yes, this happened to me too. Stupid mistake, i forgot to put in an IsUpText check! And just incase, if it finds itself in a fight, it will run to the bank.

Could i have some more info on this? I dont really understand why it happened, because i use the Bankers for getting to the bank.

Fixed by using DepositAll.

Thanks for proggy.

The variable "Worked" for the PlayerArray only starts counting after you have logged in and out at least once during the script.

Alright, lemme "Anti-ban" it up. I never really think about antiban too much, though :P

As far as I understand we should not touch the variable 'worked' as it is used for the SRL-Stats system.

It looks nice, and its easy to read. Standards are inconsistent in a few places but overall not a big deal (SKy's at least when I looked at it had many inconsistencies)

I'll try it and post here.

Edit: it doesn't even compile :S and when I got it to compile I would get a runtime error within like 3 minutes

lol i think the new SRL 3.7 screwed my script up :(
so i hope people will be able to still work it…
im going to start fresh agian, so it will do auto color and all..

Eh probly due to SRL 3.7. This worked wonders with 3.6 :P

EDIT: Updated new version. Compiled for me, so it should compile with you.

Today's proggy:

| DesertFlame 1.0 Progress Report
|Script has been running for 15 Minutes and 28 Seconds.
|Gained a total of 948 exp!
|The DesertFlame has gotten 54 bars in all.
|The DesertFlame has done 6 loads in all.
|We are averaging 209 bars per hour!
|We are averaging 23 loads per hour!
<~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~>
Name : ******
Number : 0
Active : True
Location : Bank
Smithing Level : 39
Bars Made : 54
Loads Done : 6
Worked for : 0 minutes.
Banked : 9 times.

Left it running for 5 hours but it gave a Error Detecting Compass Angle thing :(

weird, the banking and loads dont match up… strange.

hmm i hope that wasnt my script's problem.

Well, im gunna update this in the near future, so no worries!

From: Infintry001
weird, the banking and loads dont match up… strange.

What do you mean?
I changed some things around and everything works great. I fixed the Compass bug by just manually turning the MM to West, removing all MakeCompasses, and that's it :D

It says it did 6 loads, but banked 9 times… I believe they should be the same.

Oh that…well that's not really important lol, as long as the smithing is great no one cares about mismatching numbers :D

Also, a bug report:
Sometimes it misclicks on the Steel bar in the Smelting screen, then runs to bank and acts like nothing happened :(

You mean right after you click the furnace?

Yep

k ill remember that in next version

Update? pl0x?

:D

O right… lemme run my miner through Varrock east and get a few thousand bronze ores :)