SRL Archive - News and General

SRL Login Function


Taylor

2012-08-21 15:53:21

Instead of typing <username>, pressing enter, <password>, and pressing enter again, it should either use the TAB key to switch between the input boxes or send mouseclicks to activate the next box

Reason being is I'm seeing more and more random accounts in random places saying their e-mail address in game

It's obvious when I see them that it's SRL, because if the user pauses smart or something lags at the right moment, SRL will try to log in whilst already logged in

Not sure if this is the right place for suggestions; if it isn't please move it

litoris

2012-08-21 16:52:58

If you do that, you have the chance of saying both your name and password in game, simply by hitting enter.
The main problem is that the scripter puts LoginPlayer alone. They should instead do
if not LoggedIn then
LoginPlayer
Having loginplayer check for being logged in could be a simpler solution.

Taylor

2012-08-21 17:26:22

From: litoris
If you do that, you have the chance of saying both your name and password in game, simply by hitting enter.
The main problem is that the scripter puts LoginPlayer alone. They should instead do
if not LoggedIn then
LoginPlayer
Having loginplayer check for being logged in could be a simpler solution.


If your password is in a string of text you say in RuneScape, it doesn't appear and you're instead faced with this message


The issue isn't that scripters aren't using LoggedIn, the fact of the matter is that if a user stops smart while a script is running, it doesn't matter whether or not LoggedIn was used, the email and password can still be entered into RuneScape

litoris

2012-08-21 17:46:43

From: TaylorV
If your password is in a string of text you say in RuneScape, it doesn't appear and you're instead faced with this message


The issue isn't that scripters aren't using LoggedIn, the fact of the matter is that if a user stops smart while a script is running, it doesn't matter whether or not LoggedIn was used, the email and password can still be entered into RuneScape


You can't expect scripts to work properly if you disable SMART while they are running. Stop the script before disabling SMART. I do that all the time, unless I'm dying or need to pick something up immediately.

Taylor

2012-08-21 18:43:03

That's true, but the issue still stands; replacing enter with tab would fix the issue and prevent personal information being spread around whether by accident or not

riwu

2012-08-22 02:50:10

From: litoris
If you do that, you have the chance of saying both your name and password in game, simply by hitting enter.
The main problem is that the scripter puts LoginPlayer alone. They should instead do
if not LoggedIn then
LoginPlayer
Having loginplayer check for being logged in could be a simpler solution.

The LoginPlayer procedure already checks for LoggedIn before it attempts to log in so that won't make a difference. I think a possible fix would be to check LoggedIn again before enter key is pressed:
TypeSendEX(Players[CurrentPlayer].Name, false);
if not LoggedIn then
TypeByte(VK_ENTER)
else
TypeByte(vk_Escape); //clear the username typed in chatbox

Taylor

2012-08-22 23:48:15

From: riwu
The LoginPlayer procedure already checks for LoggedIn before it attempts to log in so that won't make a difference. I think a possible fix would be to check LoggedIn again before enter key is pressed:
TypeSendEX(Players[CurrentPlayer].Name, false);
if not LoggedIn then
TypeByte(VK_ENTER)
else
TypeByte(vk_Escape); //clear the username typed in chatbox


That's definitely a solution as well. Thank you for contributing