SRL Archive - RS3 Outdated / Broken Scripts

This script is currently in beta testing, I had it completely written and tested but then accidentally wiped my scripts folder so I got to start again from scratch :duh: So anyway, errors, progress reports and debugs are welcome and recommended! I hope you guys enjoy my first released script as an SRL member :)

Wut?! This was the next script I was planning to make after my exam this week! Nice release though :D

Looking forward to some healthy competition if you do end up making yours :)

From: P1ng
Looking forward to some healthy competition if you do end up making yours :)

The smithing section is getting competitive. You're going to make me step it up a notch.

:stirthepot:

I always liked some good competition. Nice release btw. Curious though, what did you use for load tracking? I can't look at the script atm.

What is it you mean by load tracking exactly? It increased the number of bars it makes by the number of primary ore withdrawn every time it completes the smithing in under 30sec. Not ideal, but it has been working well for me thus far.

From: P1ng
What is it you mean by load tracking exactly? It increased the number of bars it makes by the number of primary ore withdrawn every time it completes the smithing in under 30sec. Not ideal, but it has been working well for me thus far.

I mean like, do you do a DTM check to see when you are out of primary ore? Or how do you end your smelting procedure/function?

I believe this is the procedure you are referring to, in which case, yeah I use a general DTM for any ore still in my inventory as a base

procedure WaitTillFinished;
var
  T, x, y: Integer;
begin
  Status('WaitTillFinished');
  MarkTime(T);
  while FindDTM(Ore, x, y, MIx1, MIy1, MIx2, MIy2) do
  begin
    Wait(RandomRange(100,200));
    if ClaimSOF then
    begin
      if PDebug then
        WriteLn('Claimed a spin ticket');
      SmithBars;
      MarkTime(T);
    end;

    PRandoms;
    if not LoggedIn then
    begin
      if PDebug then
        WriteLn('Not logged in @WaitTillFinished');
      QuitScript(False);
    end;

    AntiBan;
    if DestroyRock then
    begin
      if PDebug then
        WriteLn('Successfully destroyed a strange rock');
      SmithBars;
      MarkTime(T);
    end;

    if TimeFromMark(T) > 30000 then
    begin
      if PDebug then
        WriteLn('Waited >30s to smith, walking to bank');
      Exit;;
    end;
  end;
  IncEx(Bars, Bar.FW);
end;

Why do you destroy strange rock??!! D: just have it bank it..

You can always take it out of the script, but I had like 20 in my bank after testing the script so I decided a nice feature would be to destroy them :)

Awesome release P1ng! Narcle better watch his back :garfield:

Gave the script a good hearty test last night while I was asleep after making a couple of slight alterations and it pushed out almost(i ran out of ore..) a 5hr proggy!

Re-uploaded the altered script to the OP now so if anybody wants to download that I'd love some feedback.

- Removed strange rock destruction(mainly to cut down on a little bit of size).
- Fixed an issue with breaking.
- Just neatened a few other bits and pieces up.

Haven't yet tested this with two accounts so if anybody could give that a go it would be greatly appreciated.

Removed the mm dots for ya;)

I still spy a couple of cheeky bots at the yews ;)

Well jagex isn't ganna do anything about them so I figured I'd leave those there haha

Lol does sps actually work good for you? It was shit when I tried using it in edgeville with custom maps etc.

Working perfectly well for me with the custom map in the OP, haven't tested it with nebula's. Also, I have a 'custom' walkpath function in the script.

If you had posted this last week I would have tested it for you. I'm just about to get 99 smithing with RyGuy's (noobking's) edgeville smither.

Feel free to still give it a test anyway, I'd love to know how it goes with rune and addy bars ;)

You do realise you don't actually use spswalkpath_ex right? :P

Fml, I mustn't have changed that in the latest release version. Without any feedback I can't be sure whether or not SPSWalkPath is working properly or if it keeps playing with the run energy.

Only requires a two line change if it does keep doing that, anyway.

From: P1ng
Fml, I mustn't have changed that in the latest release version. Without any feedback I can't be sure whether or not SPSWalkPath is working properly or if it keeps playing with the run energy.

Only requires a two line change if it does keep doing that, anyway.

I've never had a problem with it toggling the run energy or anything.

Is that with this script or just SPS in general?

Needs gold support

Would you just like it to smith gold bars or would you like it to also craft jewellery, I intend on adding support for both, however at present it can only smith the bars.

I dont know why but i run your script and it lasts about 5 mins then logs me out and i get this message:

Current player: *********
NextPlayer(False)
SwitchToPlayer(PlayerNo: 0, Active: False);
Player is not Active…
All players not active!
Successfully executed.

I dont know why it stops, i only have 1 active player and breaks disabled. I was smithing mithril bars if that makes a difference.
Get back to me as soon as you can, got a rather large amount of smithing to do :)

What does the debug say before all the stuff you posted, that just tells me that something went wrong and it logged your player out. Check the debug box in the form and run it again, let me know what it says before that stuff and I should be able to help

From: Nebula
Removed the mm dots for ya;)

How'd you do that :O

|—————————————–|
|——>P1ngs Edgeville AIO Smelter<——|
# Of Steel Bars Smelted: 2394 Per Hour: 589
XP Gained: 42253 Per Hour: 10389
Time runn1ng: 04h 04m 01s
|—————————————–|

|——>P1ngs Edgeville AIO Smelter<——|
# Of Mithril Bars Smelted: 35 Per Hour: 376
XP Gained: 1050 Per Hour: 11272
Time runn1ng: 05m 35s
|—————————————–|
Successful SPS - Walk2Bank
Successful SPS - Walk2Furnace
Furnace UpText was not found @PFurnace
Furnace UpText was not found @PFurnace
Furnace UpText was not found @PFurnace
Didn't find furnace @SmithBars
NextPlayer(False)
SwitchToPlayer(PlayerNo: 0, Active: False);
Player is not Active…
All players not active!
Thank you for using P1ng's ES
Successfully executed.

Does that help?

EDIT:

|——>P1ngs Edgeville AIO Smelter<——|
# Of Mithril Bars Smelted: 110 Per Hour: 367
XP Gained: 3330 Per Hour: 11103
Time runn1ng: 17m 59s
|—————————————–|
Successful SPS - Walk2Bank
Successful SPS - Walk2Furnace
Furnace UpText was not found @PFurnace
Furnace UpText was not found @PFurnace
Furnace UpText was not found @PFurnace
Didn't find furnace @SmithBars
NextPlayer(False)
SwitchToPlayer(PlayerNo: 0, Active: False);
Player is not Active…
All players not active!
Thank you for using P1ng's ES
Successfully executed.

I just started it and it dosent work for me


[Error] C:\Simba\SMARTManager\TmpScripts\2147801.simba(189:35): String error at line 188
[Error] C:\Simba\SMARTManager\TmpScripts\2147801.simba(189:35): Syntax error at line 188
Compiling failed.

@JereHakala - Thank-you very much for the progress report :) Looks like it worked well for you, will be adding that to the OP.

@nabus - Yes that is much more helpful, I will look into solving this problem ASAP. This script is still in the beta stage so feedback is greatly appreciated as I'm sure there will be many changes that need to be made in order to suit everyone :)

@Eustass - I'm not quite sure what is happening there. I would say try to run the script without SMARTManager as it should do just fine running over 6hrs by itself. Assuming you have latest Simba and SMART installed.

Thank-you to everyone for all of the feedback :)

Guess its from SmartManager

running the script without SMARTManager now and its working smoothly

Another update for you on how the scripts going. Got a much nicer proggie before it logged out this time.

|——>P1ngs Edgeville AIO Smelter<——|
# Of Mithril Bars Smelted: 600 Per Hour: 337
XP Gained: 18000 Per Hour: 10122
Time runn1ng: 01h 46m 41s
|—————————————–|
Successful SPS - Walk2Bank
Successful SPS - Walk2Furnace
Found furnace successfully
Found BarDTM @SmithBars
Not logged in @WaitTillFinished
NextPlayer(False)
SwitchToPlayer(PlayerNo: 1, Active: False);
Current player: ***********
Thank you for using P1ng's ES
Successfully executed.

Script works nicely.. Except it makes iron bars instead of steel :p Goes to bank pulls out iron ore and coal then walks to furnace nicely then proceeds to make iron bars with the iron in the inventory… Deeply confused :/

E: Restarted the script and seems to be producing steel bars. Will be watching for a bit.

Hmm, try reducing the tolerance on ~line 312. It should be at 50 now try dropping it a little by little until it detects the steel bar and not the iron and let me know how that goes for you.

No gold bar support?

I did tweak it so that it could do just that though, so I'm not begging to implement it.

|——>P1ngs Edgeville AIO Smelter<——|
# Of Mithril Bars Smelted: 320 Per Hour: 361
XP Gained: 9450 Per Hour: 10674
Time runn1ng: 53m 07s
|—————————————–|
Successful SPS - Walk2Bank
Successful SPS - Walk2Furnace
Found furnace successfully
Found BarDTM @SmithBars
Not logged in @WaitTillFinished
NextPlayer(False)

my best proggie (6th try), usually only lasts 6 min then it kills itself for unknown reason.
I'll keep looking into any patterns that i may find

edit:
# Of Mithril Bars Smelted: 355 Per Hour: 363
XP Gained: 10770 Per Hour: 11023
Time runn1ng: 58m 37s
|—————————————–|
NextPlayer(False)
SwitchToPlayer(PlayerNo: 0, Active: False);
Player is not Active…

Script is still a great script but has consistent problems with selecting iron bar instead of steel. I have changed tolerance anywhere from 30-48 and updated the color of the bar *to the lightest setting* it has about three different colors that change randomly when you start the rs. two of the colors i have are 8092545, 8158338.
A suggestion is to add something where it can start at furnace too.

Glad to know someone is still using this ;) Unfortunately I won't be making any updates to any of my scripts until I have seen how the whole botany bay update plays out. So you guys could be waiting a while until I decide to update them all.

From: P1ng
Glad to know someone is still using this ;) Unfortunately I won't be making any updates to any of my scripts until I have seen how the whole botany bay update plays out. So you guys could be waiting a while until I decide to update them all.

Its been and gone man for now, its done nothing apart from ban advertising bots lol.

Yes, but AFAIK they are still gathering info. Thus, by updating, fixing or improving any of my scripts right now I don't want to hand them all the information that if I held off for a little while I could then use to get around their system once their info. gathering is complete.

Gotcha. Well my own work around fix is to start smart then pick the color of the steel bar in my bank and, put it into the script and restart the script

Gold ores > Gold bars > bracelets would be nice, because it gives less loss at gp. though not so hard to add it, and very useful :)

I wish you had a Smelter @ Al-Kharid.
Cuz, am not a member.

I was trying to run it, it log in, opens the bank, gets the ores/coal, runs to the furnace, clicks the furnace, and then logs me out…

Hey there,

Same problem as Nightmare above, here is what it spits out.

Found furnace successfully
No smelt screen, trying furnace again @SmithBars
Furnace colour was not found @PFurnace
NextPlayer(False)
SwitchToPlayer(PlayerNo: 0, Active: False);
Player is not Active…
All players not active!
Thank you for using P1ng's ES
Successfully executed.

It says no smelt screen when there was one showing

This script is probably out-dated. I haven't changed anything on it post-EoC but I will shortly get back into fixing all of my scripts, just hang tight guys :)

Only Problem will probably be the clicking the new UI smelt all button, should litteraly obly take 30 sec to fix :),

Glad to hear your not abandoning your scripts :)

Moved to outdated.