SRL Archive - RS3 Outdated / Broken Scripts

S1NHumidify [27k+ XP/h | 200K+ GP/h]


Sin

2012-08-10 01:44:01

Thought this was good money when I saw the method but it turns out it isn't.

==========S1NHumidify=============
Time Running: 6 Minutes and 4 Seconds
XP Earned: 2860
XP/h: 28285
Profit: 19448
Profit/H: 192342
===================================

Well, have ALOT of vials in your bank and fill out these Constants:

bSlot = 5; //Which Bankslot has your empty vials?
vialPrice = 3; //Whats the Vial price?
voWPrice = 22; //Whats the Vial of Water Price?
astralPrice = 149; //Whats the Astral rune Price?

Have your spellbook like this:


Astrals in any slot, preferably the first one.
Start it at Soul Wars bank.
You need to have a Steam Staff equipped by the way.

I think that's it?

Vinyl Scratch

2012-08-10 01:56:31

Sin, you left an unused variable, inb4nebula.

Le Jingle

2012-08-10 01:57:47

You can make more gp/hr via humidifying clay

Sin

2012-08-10 02:00:16

From: Le Jingle
You can make more gp/hr via humidifying clay


They don't buy :(

Nebula

2012-08-10 02:12:28

Let me introduce you to

function GetGEPrice(v: variant): Integer;
And
function Withdraw(col, row, Amount: Integer): Boolean;

–
–

function WaitXPIncrease(Time:Integer):Boolean;
var
First,Second,t:Integer;
begin
First := GetXPBarTotal;
MarkTime(T);
repeat
wait(10);
Second := GetXPBarTotal;
if TimeFromMark(t) > Time then
begin
Result := False;
Exit;
end;
until(Second > First);
Result := True;
end;

Can be


function WaitXPIncrease(Time:Integer):Boolean;
var
First,Second,t:Integer;
begin
First := GetXPBarTotal;
MarkTime(T);
While ((TimeFromMark(t) < Time) and (not result)) do
if (GetXPBarTotal >= First) then
result := true
end;



Profit := profit - astralPrice;
Profit := Profit - vialPrice;
Profit := Profit + (voWPrice * 27);

You forgot to multiply the vial price by 27 and this can be condensed.


Profit := (VowPrice * 27) - (VialPrice * 27) -AstralPrice);

  repeat
Bank;
Humidify;
until(AllPlayersInactive);
This will go forever because you don't have proper multiplayer support in your script.




var
Box:TBox;
...

Box := GetTPABounds(TPA);

You never did anything with it…


 if FindColorsTolerance(TPA,10646381,MIX1,MIY1,MIX2,MIY2,38) then
begin
//writeLn(Length(TPA));
if Length(TPA) > 170 then
begin
Box := GetTPABounds(TPA);
if FindColorTolerance(p.x,p.y,10646381,MIX1,MIY1,MIX2,MIY2,38) then
begin
Why call FindColorTolerance twice?

          while InvFull do
wait(50 + random(50));
Infinite loop… not good.
WaitFunc(@InvFull, 10, 5000);


MouseSpeed := 40;

-------

MouseSpeed := 15;

Not very human like to speed up so fast every time you withdraw then slow back down afterwards.


function Humidify:Boolean;
var
TPA:TPointArray;
begin
TypeByte(VK_F4);
if GameTab(tab_Magic) then
begin
Mouse(600,256,5,5,True);
if WaitXPIncrease(2500 + Random(500)) then
begin
Profit := profit - astralPrice;
Profit := Profit - vialPrice;
Profit := Profit + (voWPrice * 27);
Wait(1250 + Random(1000));
Proggy;
end;
end;
end;

A function with no result…



And not a single FindNormalRandoms was called. (yes it as at sw but there are spin tickets, those rocks, and other stuff)

E:
From: Vinyl Scratch
Sin, you left an unused variable, inb4nebula.

Didn't even see this. I was making this post while you said that. Were you referring to the box or is there more?


procedure SetupLogin;
begin
ClearReport;
ClearDebug;

SetupSRL;

ActivateClient;
DeclarePlayers
end;
There isn't a LoginPlayer here or anywhere in this script.


 
Mouse(600,256,5,5,True);

That is how you click the humidify button. Not its blue color, a DTM, or edge color counting. A static click. The thing is like 11x11, use a higher randomness if anything.

Sin

2012-08-10 02:29:39

Now, time to respond to all that urgh.

function GetGEPrice(v: variant): Integer;

Nty.


Simba Code:
function WaitXPIncrease(Time:Integer):Boolean;
var
First,Second,t:Integer;
begin
First := GetXPBarTotal;
MarkTime(T);
repeat
wait(10);
Second := GetXPBarTotal;
if TimeFromMark(t) > Time then
begin
Result := False;
Exit;
end;
until(Second > First);
Result := True;
end;

Can be

Simba Code:
function WaitXPIncrease(Time:Integer):Boolean;
var
First,Second,t:Integer;
begin
First := GetXPBarTotal;
MarkTime(T);
While (TimeFromMark(t) < Time) do
if (GetXPBarTotal >= First) then
result := true
end;


Does it make a goddamn difference?

Simba Code:
repeat
Bank;
Humidify;
until(AllPlayersInactive);
This will go forever because you don't have proper multiplayer support in your script.



Simba Code:
var
Box:TBox;
…

Box := GetTPABounds(TPA);

You never did anything with it…


AllPlayersInactive doesn't need multiplayer to function LOL.

Box: indev, don't concern yourself.

Simba Code:
if FindColorsTolerance(TPA,10646381,MIX1,MIY1,MIX2,MIY2,38) then
begin
//writeLn(Length(TPA));
if Length(TPA) > 170 then
begin
Box := GetTPABounds(TPA);
if FindColorTolerance(p.x,p.y,10646381,MIX1,MIY1,MIX2,MIY2,38) then
begin
Why call FindColorTolerance twice?

L2Seethe's'

Simba Code:
MouseSpeed := 40;

——-

MouseSpeed := 15;

Not very human like to speed up so fast every time you withdraw then slow back down afterwards.

Simulates Mouse keys

Simba Code:
function Humidify:Boolean;
var
TPA:TPointArray;
begin
TypeByte(VK_F4);
if GameTab(tab_Magic) then
begin
Mouse(600,256,5,5,True);
if WaitXPIncrease(2500 + Random(500)) then
begin
Profit := profit - astralPrice;
Profit := Profit - vialPrice;
Profit := Profit + (voWPrice * 27);
Wait(1250 + Random(1000));
Proggy;
end;
end;
end;

A function with no result…

I'll admit that I missed that.

imba Code:
procedure SetupLogin;
begin
ClearReport;
ClearDebug;

SetupSRL;

ActivateClient;
DeclarePlayers
end;
There isn't a LoginPlayer here or anywhere in this script.


LoginPlayer doens't work.


E*
You must have ALOT of time on your hands to criticize everything I do.

shstiger2009

2012-08-10 02:34:39

Nebula, IIRC, GetGEPrice isn't in the include anymore for some reason…correct me if I'm wrong, I know you will. :)

Nebula

2012-08-10 02:38:53

1) why not
2) yes
3) Lol what you're using multiplayer, just not correctly. You don't know you are because you probably just copied it from someone's correct setup. You never call NextPlayer(); so it WILL be an endless loop. You're wrong.
4) Oh, still pre-planning things? Hang on lemme add 50 vars to my script for future use.
5)Didn't see it.
 if FindColorTolerance(p.x,p.y,10646381,MIX1,MIY1,MIX2,MIY2,38) then
begin
HumanMMouse(p.x,p.y,2,2);
ClickMouse2(False);
if WaitOption('All',750) then
while InvFull do
wait(50 + random(50));
end;
It will click the same vial every time. So it should still be changed.

6) not really….

7)k +1 for me

8)LoginPlayer does work.

From: shstiger2009
Nebula, IIRC, GetGEPrice isn't in the include anymore for some reason…correct me if I'm wrong, I know you will. :)

You have to define Online.Simba



From: Shay
You must have ALOT of time on your hands to criticize everything I do.

I didn't criticize your use of ClearDebug; at the beginning of the script.

Sin

2012-08-10 02:39:51

Won't be responding to you anymore.


Vinyl Scratch

2012-08-10 04:17:59

Thata Boy, mate! Anyway, Script looks really good. Going to try it.. when I can humidify.

Rincewind

2012-08-11 18:41:24

I didn't know 200k+ gp per hour was bad profit lol. Looks good anyways, wont be able to use it tho :9

satkan

2012-08-13 17:09:59

Guess I'll have to go and legit Dream mentor :P

Btw, nice script!

+1

Texy

2012-08-13 17:17:09

Eh, right now it's more around 150k gp/hr. A very basic script, but it works well, made a few tweaks myself for antiban and efficiency though.

Edit: Oops, yeah, that was a typo on my part, meant gp/hr. Fixed now.

Le Jingle

2012-08-13 17:52:27

From: Texy
Eh, right now it's more around 150k xp/hr. A very basic script, but it works well, made a few tweaks myself for antiban and efficiency though.


There's no way you will ever reach 150k xp per hour.
Perhaps you meant gp per hour?

There are more items aside from vials to profit on.. (clay > jug > bowl > vial > bucket)

shstiger2009

2012-08-13 19:38:32

From: Le Jingle
There's no way you will ever reach 150k xp per hour.
Perhaps you meant gp per hour?

There are more items aside from vials to profit on.. (clay > jug > bowl > vial > bucket)


I'm sure that is what he meant lol. What are jugs of water for?

Le Jingle

2012-08-13 19:39:11

From: shstiger2009
I'm sure that is what he meant lol. What are jugs of water for?


Grapes + Jug of water's for wine cooking/making

shstiger2009

2012-08-13 19:40:47

From: Le Jingle
Grapes + Jug of water's for wine cooking/making


Ahaaaa. Wouldn't that be ridiculous profit? I bet jugs are hard to buy.

feh55

2012-09-24 08:31:38

After some tweaks and experimenting this script is really effective. Thank you S1N. :-)