SRL Archive - RS3 Outdated / Broken Scripts

Draynor Pottery Crafter


VastlySuperior

2012-08-07 10:48:39

Draynor Pottery Crafter And Clay Miner, With Clay Softner

Current Version: 1.06 Beta Release
Status: Working


Instructions For Use

  1. Set Server To Use
  2. Set Members True Or False
  3. Number Of Players to Use (Currently Only Support Single Player)
  4. Set Which Player Should Start
  5. Set Activity Choice
  6. Set Which Pottery To Be Created
  7. Fill In Player Details
  8. Press The Green Start Button
  9. Download Custom SPS Map. Install Under sps/img/runescape_other Very Important.

Features

  • Numerous Failsafes.
  • Auto Recovery If Lost
  • Antiban
  • Start From Anywhere In The World

To Do List

  1. Options 5 - 6 Must Be Written Yet.
  2. Crafting For Urns Must Still Be Implemented.
  3. Proggy Must Be Expanded and Made Better.
  4. Auto Switch Activity Must Be Written And Implemented.
  5. Walking Must Definitely Be Made Better And Shortened Into One Module That Works From The Activity Choice.
  6. Logic Must Be Improved So That Code Can Be More Compact.
  7. Activity Case Loop Must Be Improved( Break Loop In Better Manner Than The Use Of If Statements.
  8. Implement A Break System.

I Would Like To Get Some Feedback and some Proggies.

The Script is a bit slow for me, I would like to know why and how to improve the speed. My Logic Sucks, so I might have repeated some steps that is not necessary. For some reason while using the custom map with SPS, it clicks quite a lot on the map. I would also like to know why that is? All feedback will be appreciated.

E. Released New Update

Revision History

1) Version 1.00 Beta Released —> 07/08/2012
2) Version 1.01 Minor Update. Forgot Some Code And Corrected Some Coding Mistakes. Added Better DTM Detection —> 08/08/2012
3) Version 1.05 Changed Area Detection With ODTM, Changed Code Flow Created A New Custom Draynor Village Map. Updated Paths Accordingly. Script Should Now Get Less Lost —> 14/08/2012
4) Updated Walking Procedures. —> 21/08/2012




YesMan

2012-08-12 16:27:18

This Script is nicely done, well done VastlySuperior, using it right now :)

Nebula

2012-08-12 16:36:57

Wow good job looks like you put a lot of effort into this!

One thing I noticed is that you tend to use begin and end when it isn't needed sometimes. For example:

While this do
Begin
that;
End;

if this then
begin
that;
end;

Could just be


While this do
that

if this then
that

VastlySuperior

2012-08-14 03:38:06

From: Nebula
Wow good job looks like you put a lot of effort into this!

One thing I noticed is that you tend to use begin and end when it isn't needed sometimes. For example:

While this do
Begin
that;
End;

if this then
begin
that;
end;

Could just be


While this do
that

if this then
that


The reason why I use it like this is because I felt it is better coding practice to do it that way.

There is a problem at the moment with the callproc procedure, when you pass a value with the call it gives an error. I`m working on a solution at the moment to bypass that error. Will update the script once more when I have sorted that problem out, but all the other options who does not use a value that is passed along with the procedure call works correctly. There is still some work to be done with this as it is not a 100% flawless, you still have to babysit this script a lot.

But thanks for the good words.

jefftyler

2012-10-10 03:36:20

Im sorry but i dont know the way to reply a post coz im new. But i noticed sumthin about this script.
I noticed that when my run is toggled before starting the script, it doesn't work. I always end up at d cow place after banking the clay. but when i turn off my run button when my energy is out (while the script is running) , it works perfectly after that.
Apart from that, everything works perfectly.
Thx for this awesome script =D

VastlySuperior

2012-10-12 12:57:32

I recently updated the script but has not as yet uploaded it. I changed the way it mines and also some of the walking which makes it more stable as well as the detection of the pump for the water was redone to make it more accurate.I`m struggling to find the right place to place the 6 hour fix as it still does not pass the six hour mark, not that the script can`t run that long without a problem, it runs quite often to the six hour mark. When I have fixed that issue I will reload the new version.

euphemism

2012-10-12 19:17:05

I do not know if you have fixed this in your update, but a quick look at your walking functions shows that your fail-safes don't actually do anything. If one walking method fails, you exit out of the function and the backups are never called.

JYG

2013-04-10 07:13:20

Don't know if this is outdated or if i am doing something wrong but when i start i only get:

Setup Location For First Time Use

I reckon the script wants to start with a teleport to Draynor but it just opens the skills window and then stops with the red dot over the attack symbol.

Any ideas how to fix this? Don't mind starting at Draynor lodestone, what should i comment out then?

Thanks.