SRL Archive - RS3 Outdated / Broken Scripts

‎(づ｡*◕__◕｡)づ・。*。✧・゜゜・。✧

From: -Benny
Shay your idea about a full working cooking guild script would be nice :)

And so it came to be =P
Currently runs at nearly 260k/h cooking Sharks.


Cook in there, IIRC you need to have done Varrock Diaries 3 for it.
Start the script with your desired cooking material in the first slot of the Bank Tab you open.

============S1NCooker==============
Time Running: 3 Minutes and 52 Seconds
XP Earned: 17010
XP/h: 263948
Items Cooked: 81
==================================

Some of the coders might be asking why it's an ATPA, it's because I had a comp caper in my world which had red dots on it, which screwed it up while finding the range. I fixed it by making it cycle through an ATPA.

Let me know about any problems

Hey, I'm def going to run this script right as we speak! Thanks man!

Any suggestion as to where to place the shark in the invo? How many sharks does it use a hour?

Awesome script - thanks for the release.

Will test it later and post a proggy.

From: Jordan155
Awesome script - thanks for the release.

Will test it later and post a proggy.

Thanks =]

From: Jos3ph
Hey, I'm def going to run this script right as we speak! Thanks man!

Any suggestion as to where to place the shark in the invo? How many sharks does it use a hour?

It makes about 1.2-1.4k/h, and im not too sure about what the "placing the shark" means =S

From: Shay
Thanks =]



It makes about 1.2-1.4k/h, and im not too sure about what the "placing the shark" means =S

Can I place the shark in any invo slot or is there a certain area for the sharks? ;s

Nice script. Did you bother putting in cooking urn support?
Thanks for the public release, I'll post a proggy tomorrow if possible.
By the way, is it supposed to be called "Cooekr.simba"?

Edit:

From: Jos3ph
Can I place the shark in any invo slot or is there a certain area for the sharks? ;s

Just have a full inventory of sharks.

Oh Shay, quoting me at the top of your awesome script has probably made the rest of my week :)

(ps. minor spelling mistake in cooker ;))

From: -Benny
Oh Shay, quoting me at the top of your awesome script has probably made the rest of my week :)

(ps. minor spelling mistake in cooker ;))

Ah just noticed that, was typing too fast haha.

From: Fruit
Nice script. Did you bother putting in cooking urn support?
Thanks for the public release, I'll post a proggy tomorrow if possible.
By the way, is it supposed to be called "Cooekr.simba"?

Edit:
Just have a full inventory of sharks.

Urn support i'll add soon.
Does it provide a decent increase in XP?

From: Jos3ph
Can I place the shark in any invo slot or is there a certain area for the sharks? ;s

Still not that clear, just start with empty inventory and sharks in first BANK Slot.



E*
Idk what happened but the colors changed xP
Download new version 1.1.

I'll run it with 8k shark will give my update with some results. Have been waiting on a script like this; need 100m xp in cooking so thanks bro!

I've just read on zybez that decorated urns can increase the xp per hour for sharks by 50k. I doubt it would be by that much though to be honest.

Damnn, i'll give it a go then!

Error: divide by Zero at line 148
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap, SRL - NavBar Bitmap]

Thats the error I keep getting…I ran it for over a hour and had that error once after I was stuck in a random at the graveyard…

Damn that error keeps coming up eh…
I'll run up a quick fix, give me a bit.

Edited with 1.11

Dude, you gonna support urns? Btw nearly 96 slayer ;)

please, i've been 99 for a week ;)
I'll add urn support as soon as I collect my daily 1k charms :p

Issue with randoms makes me only run the script for 1 hour unless I baby sit. It would be great if I used the script @ SW bank and just burned logs at bank that would make the script a lot more stable since I wont have to worry about randoms & in the long run the XP would be better but not more per hour just better over-all XP since I was logged out for the last 30mins and didnt even know so I lost 30mins worth of XP appose if I was doing it in an area where randoms didnt touch me.


EDIT: I should take that back, script is 100% stable after 1.1 update; I should rephase that; it would make it more XP stable for long term running. Sorry for the mix up!

I would write a post depicting what could be improved but that post would exceed the character limit and I don't want to double post. And It's an all or nothing deal so I will point you in the right direction.

http://villavu.com/forum/showthread.php?t=58935

From: Nebula
I would write a post depicting what could be improved but that post would exceed the character limit and I don't want to double post. And It's an all or nothing deal so I will point you in the right direction.

http://villavu.com/forum/showthread.php?t=58935

Instead of acting all high and mighty, mind saying what the f*ck you're on about?

From: Nebula
I would write a post depicting what could be improved but that post would exceed the character limit and I don't want to double post. And It's an all or nothing deal so I will point you in the right direction.

http://villavu.com/forum/showthread.php?t=58935

How harsh is that and demoralising for Shay is that? Saying he should look at a beginners tutorial.
This community doesn't have space for people like this.
Sin is a great scripter!
This Post is just pathetic and childish.

I had a great post I had been working on for about 25 minutes(it was going to be a very long post), then I accidentally closed the tab. But summed up:

I wasn't trying to be rude to Shay. No matter what anyone says, shay needs to look at the beginner tutorial. This script contains awful standards, flawed logic, and a constant that isn't even used. Just a complete lack of effort. There was so little effort put into this project that he spelled the script name wrong.

@Neblus that Explains a lot more, that just saying go to a beginners Tutorial.

Mat

From: Nebula
I had a great post I had been working on for about 25 minutes(it was going to be a very long post), then I accidentally closed the tab. But summed up:

I wasn't trying to be rude to Shay. No matter what anyone says, shay needs to look at the beginner tutorial. This script contains awful standards, flawed logic, and a constant that isn't even used. Just a complete lack of effort. There was so little effort put into this project that he spelled the script name wrong.

This script contains awful standards,

Oh please, do tell where!

flawed logic

This too!

and a constant that isn't even used.

Do you NEVER add some code in to build upon for later?
It's for an on screen paint that i'm creating at the moment, and rest assured it wont be a picture of some twelve year old fantasizing about women.
Get what i'm saying?

Just a complete lack of effort

I can agree with you here, because OFCOURSE when a script hasn't even been released 12 hours, it has to be ABSOLUTELY PERFECT right?!

There was so little effort put into this project that he spelled the script name wrong.

Im still not too sure if you can read former posts are not.


Still sore about me voting No on your application are we?

I'd count that as rep abuse tbh.

From: Shay
Oh please, do tell where!

Someone please look at this procedure and tell me that this is considered even remotely decent:

begin
SetupLogin;
StartTime:=GetSystemTime;
  if (Players[CurrentPlayer].Integers[1] = 0) then
  begin
    if not IsXPBarOpen then ToggleXPBar(true);
      Players[CurrentPlayer].Integers[0] := GetXPBarTotal;
      Players[CurrentPlayer].Integers[1] := (Players[CurrentPlayer].Integers[1] + 1);
  end;
repeat
  Bank
  Cook;
until(AllPlayersInactive);
end.    

Flawed logic example is shown below. The CTS thing is that I'm talking about.(also another bad standards example):

function OpenCGuildBank:Boolean;
var
  x,y,tmpCTS,i:integer;
  TPA:TPointArray;
  ATPA:T2DPointArray;
begin
tmpCTS := GetColorToleranceSpeed;
SetColorToleranceSpeed(2);
SetColorspeed2Modifiers(0.10,0.99);

  if FindColorsSpiralTolerance(x,y,TPA,4861235,MSX1,MSY1,MSX2,MSY2,5) then
  begin
    ATPA := TPAtoATPA(TPA,5);
    for i := 0 to High(ATPA) do
    begin
      MiddleTPAEx(ATPA[i],x,y);
      MMouse(x,y,2,2);
      if WaitUpTextMulti(['alk','anker','Banker'],750) then
      begin
        ClickMouse2(False);
        ChooseOption('ank B');
        Result := True;
        Break;
      end;
    end;
  end;
SetColorToleranceSpeed(tmpCTS);
SetColorspeed2Modifiers(0.2,0.2);
end;    

And this; all integers start at 0 anyways… and you're just changing the value of t anways 5 seconds later so whats the point of that?

procedure Bank;
var
  t:Integer;
begin
  t := 0;
  if OpenCGuildBank then
  begin
    MarkTime(t);    

"I can agree with you here, because OFCOURSE when a script hasn't even been released 12 hours, it has to be ABSOLUTELY PERFECT right?!"

It does have to be near perfect when you are representing the SRL members. (which I am not doing very well atm). I don't think it looks good when a SRL member produces a few kilobytes of shit.

"Still sore about me voting No on your application are we?"

Yeah a little actually. You really do need to look at the beginner tutorial if you think it's bad to make banking a function.

Wow, rep abuse big whoop. If rep really doesn't count for anything it shouldn't matter +I was high. It's not like I ruined your rep point count with my rep power of 1…

From: Nebula
Are you fucking kidding me? Someone please look at this procedure and tell me that this is considered even remotely decent:

begin
SetupLogin;
StartTime:=GetSystemTime;
  if (Players[CurrentPlayer].Integers[1] = 0) then
  begin
    if not IsXPBarOpen then ToggleXPBar(true);
      Players[CurrentPlayer].Integers[0] := GetXPBarTotal;
      Players[CurrentPlayer].Integers[1] := (Players[CurrentPlayer].Integers[1] + 1);
  end;
repeat
  Bank
  Cook;
until(AllPlayersInactive);
end.    

That is a standard setup procedure, nothing wrong there, you don't have amazing things in your main loop

Flawed logic example is shown below. The CTS thing is that I'm talking about.(also another bad standards example):

function OpenCGuildBank:Boolean;
var
  x,y,tmpCTS,i:integer;
  TPA:TPointArray;
  ATPA:T2DPointArray;
begin
tmpCTS := GetColorToleranceSpeed;
SetColorToleranceSpeed(2);
SetColorspeed2Modifiers(0.10,0.99);

  if FindColorsSpiralTolerance(x,y,TPA,4861235,MSX1,MSY1,MSX2,MSY2,5) then
  begin
    ATPA := TPAtoATPA(TPA,5);
    for i := 0 to High(ATPA) do
    begin
      MiddleTPAEx(ATPA[i],x,y);
      MMouse(x,y,2,2);
      if WaitUpTextMulti(['alk','anker','Banker'],750) then
      begin
        ClickMouse2(False);
        ChooseOption('ank B');
        Result := True;
        Break;
      end;
    end;
  end;
SetColorToleranceSpeed(tmpCTS);
SetColorspeed2Modifiers(0.2,0.2);
end;    

what's wrong with that? The CTS is all done correctly, he saves the current CTS then goes back to it at the end after breaking out of the loop

And this; all integers start at 0 anyways… and you're just changing the value of t anways 5 seconds later so whats the point of that?

Yes by default integers should be 0, but simba isn't perfect and a lot of memory leaks cause variables to have values as soon as they are declared, that is why you often see array lengths set to 0 at the start of functions

procedure Bank;
var
  t:Integer;
begin
  t := 0;
  if OpenCGuildBank then
  begin
    MarkTime(t);    

"I can agree with you here, because OFCOURSE when a script hasn't even been released 12 hours, it has to be ABSOLUTELY PERFECT right?!"
It does have to be near perfect when you are representing the SRL members. (which I am not doing very well atm). I don't think it looks good when a SRL member produces a few kilobytes of shit.

"Still sore about me voting No on your application are we?"

Yeah a little actually. You really do need to look at the beginner tutorial if you think it's bad to make banking a function.

Wow, rep abuse big whoop. If rep really doesn't count for anything it shouldn't matter +I was high. It's not like I ruined your rep point count with my rep power of 1…

I don't know what you are on about here, so I'll leave you be…

Just shut up unless you know what you are talking about…


I haven't been able to run the script as I am not a member atm, but another good release from the looks of the code Shay :)

^ Did all of that just happen? :O

Nice script btw, Shay, great idea to cook in there. Looks like I need to do my Varrock stuff. ;)

calm it guys :)

just don't rage on forums

From: Nebula
Are you fucking kidding me? Someone please look at this procedure and tell me that this is considered even remotely decent:

begin
SetupLogin;
StartTime:=GetSystemTime;
  if (Players[CurrentPlayer].Integers[1] = 0) then
  begin
    if not IsXPBarOpen then ToggleXPBar(true);
      Players[CurrentPlayer].Integers[0] := GetXPBarTotal;
      Players[CurrentPlayer].Integers[1] := (Players[CurrentPlayer].Integers[1] + 1);
  end;
repeat
  Bank
  Cook;
until(AllPlayersInactive);
end.    

Flawed logic example is shown below. The CTS thing is that I'm talking about.(also another bad standards example):

function OpenCGuildBank:Boolean;
var
  x,y,tmpCTS,i:integer;
  TPA:TPointArray;
  ATPA:T2DPointArray;
begin
tmpCTS := GetColorToleranceSpeed;
SetColorToleranceSpeed(2);
SetColorspeed2Modifiers(0.10,0.99);

  if FindColorsSpiralTolerance(x,y,TPA,4861235,MSX1,MSY1,MSX2,MSY2,5) then
  begin
    ATPA := TPAtoATPA(TPA,5);
    for i := 0 to High(ATPA) do
    begin
      MiddleTPAEx(ATPA[i],x,y);
      MMouse(x,y,2,2);
      if WaitUpTextMulti(['alk','anker','Banker'],750) then
      begin
        ClickMouse2(False);
        ChooseOption('ank B');
        Result := True;
        Break;
      end;
    end;
  end;
SetColorToleranceSpeed(tmpCTS);
SetColorspeed2Modifiers(0.2,0.2);
end;    

And this; all integers start at 0 anyways… and you're just changing the value of t anways 5 seconds later so whats the point of that?

procedure Bank;
var
  t:Integer;
begin
  t := 0;
  if OpenCGuildBank then
  begin
    MarkTime(t);    

"I can agree with you here, because OFCOURSE when a script hasn't even been released 12 hours, it has to be ABSOLUTELY PERFECT right?!"

It does have to be near perfect when you are representing the SRL members. (which I am not doing very well atm). I don't think it looks good when a SRL member produces a few kilobytes of shit.

"Still sore about me voting No on your application are we?"

Yeah a little actually. You really do need to look at the beginner tutorial if you think it's bad to make banking a function.

Wow, rep abuse big whoop. If rep really doesn't count for anything it shouldn't matter +I was high. It's not like I ruined your rep point count with my rep power of 1…

1)
That code wasn't written by me, it was written by NexPB and it ended up like that when I copied it (with his permission) from his Artisans Workshop script.


2)
Erm you're twisting up my script? There are NO bad standards in that piece of code.

That's how it looks like when you open it. Explain the CTS thing a bit more clearly, I have no idea what you're talking about.

3)

And this; all integers start at 0 anyways… and you're just changing the value of t anways 5 seconds later so whats the point of that?

They typically do, but i'm calling 't' and then MOVING BACK TO THE BEGINNING OF THE PROCEDURE.

4)

It does have to be near perfect when you are representing the SRL members. (which I am not doing very well atm). I don't think it looks good when a SRL member produces a few kilobytes of shit.

Agreed. Do you remember when whatshisname from RSBots.net released "Auto Dungeoneering Pro"? Was it REMOTELY decent? It was a horrible piece of code when I saw it (H.rs members had all the source codes for all PRO scripts). What you're saying is extremely opinionative, an SRL Member is still a human and doesn't need to be anywhere near perfect. And a few kilobytes of shit? Haha, it's better than having a few kilobytes of a picture in a script which has NO correlation to the point of the script.

Now kindly refrain from posting here as it's just ruining my mood. You don't need to respond to this post, if you want to, take it to a PM.

From: putonajonny
…

I do know what I'm talking about. Let me show you:


First: I wasn't talking about the content of his mainloop, I was talking about the standards.

Second: His CTS never changes throughout his script so there's no point…

third: MarkTime(t); gives t an entire new value, it doesn't matter what its old value is so you can just shut up unless you know what you are talking about.

Shay I'm sure on Line 80 and 81 they need to be tabbed.
like the end;
Mat

I'm just glad someone took the time to write a script, update it & make it public…. I could careless about how it was coded as long as it works.


Have any ideas of building a fire @ sw bank and cooking there?

From: Mat
Shay I'm sure on Line 80 and 81 they need to be tabbed.
like the end;
Mat

Idk mate, that's how I saw it done by the big shots like Kyle/Flight etc.
They made the CTS non tabbed and the main code tabbed.

From: Jos3ph
I'm just glad someone took the time to write a script, update it & make it public…. I could careless about how it was coded as long as it works.


Have any ideas of building a fire @ sw bank and cooking there?

Can't light a fire in Soul Wars :l

From: Shay
Idk mate, that's how I saw it done by the big shots like Kyle/Flight etc.
They made the CTS non tabbed and the main code tabbed.





Can't light a fire in Soul Wars :l

Ah chucks. I get hit with ransoms far to often. :/ just trying to avoid ransoms

My last post in this thread (unless I come to actually use the script in future)

From: Nebula
Second: His CTS never changes throughout his script so there's no point…

Yes, but a whole lot of SRL functions require CTS1, especially random checks, leave it on CTS2 and it will mistake every item under the sun in your invent for a spin ticket or a reward box, and keep trying to open/claim them, then when it can't it will drop them, that's why he does what he did, and what if he wrote a CTS1 colour finding function in the future, would he want to go through the whole script changing the CTS?

third: MarkTime(t); gives t an entire new value, it doesn't matter what its old value is so you can just shut up unless you know what you are talking about.

That's not what I was talking about, I was saying it is good practice to give variables values…

From: Nebula
This is how it should look:

From: Shay
Idk mate, that's how I saw it done by the big shots like Kyle/Flight etc.
They made the CTS non tabbed and the main code tabbed.

…

I deleted that once I saw mats post.

I get this; not a error but surly not something it should do\

Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up

Doesnt bank just tries to cook cooked shark after my first load. Using 1.1 wearing comp cape; all neon green / blue, with fire staff would something be the issue messing it up?


And now I get this error;

Error: divide by Zero at line 148
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap, SRL - NavBar Bitmap]

I'm getting the same thing as your first error.
Shay, did you put in some anti-leech?

Nice release Sin. It's a shame you release a working script to the public and then other SRL members feel like they NEED to correct you.

From: [J]ustin
Nice release Sin. It's a shame you release a working script to the public and then other SRL members feel like they NEED to correct you.

Cant make everyone happy; some feel the need to constantly correct others while I notice Sin has a lot of public scripts and the person who insisted to correct his script doesnt seem to have any public scripts. It is what it is; I'm glad someone took their time to give to the public, perfect or not, its free and a lot better then what I could do so for that I say thank you.

Alright, i'll take a look at it.

E*
Fixed it. 1.12.

Working solid for the last 3hours.

Great! Looking into Urn Support now!

From: Shay
There are NO bad standards in that piece of code.

That's how it looks like when you open it.

Um, that's bad standards, just saying. Nebula had it right with this image:

From: Shay
Idk mate, that's how I saw it done by the big shots like Kyle/Flight etc.
They made the CTS non tabbed and the main code tabbed.

I call BS on that, don't drag me into your little argument. Especially with the claim you're making about me is false. I don't care what the line is, anything after a begin gets indented.

From: [J]ustin
Nice release Sin. It's a shame you release a working script to the public and then other SRL members feel like they NEED to correct you.

I don't agree with the public call out, however, there's more to this story that I can't share with you.

From: Kyle Undefined
Um, that's bad standards, just saying. Nebula had it right with this image:




I call BS on that, don't drag me into your little argument. Especially with the claim you're making about me is false. I don't care what the line is, anything after a begin gets indented.



I don't agree with the public call out, however, there's more to this story that I can't share with you.

Yeah it wasn't you, it was someone else.
I talked with Axel and it was correct.

Any new updates with urn support? Super excitedd!!

============S1NCooker==============
Time Running: 50 Minutes and 33 Seconds
XP Earned: 226500
XP/h: 278634
Items Cooked: 1050
===================================

Urns don't speed it up that much, just working out the kinks in it.

Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up



thats the error I keep getting…

Clicks the second from top row, the last shark it clicks it again and gives me this error. ^

I'll add a few failsafes in, give me a quick bit.

let me know when you added the fail safes and I'll test again

From: Jos3ph
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up



thats the error I keep getting…

Try changing the hue from 0.10 to something higher. That's how I got over that problem.
To find out where the script was getting stuck I just used some WriteLn's.

It shouldn't be 0.10, it should be 0.40 :o
Urn support is working great atm.

When will you post a update to fix the error I am getting?

It's already been posted. :duh:
Change 0.10 to 0.40 in SetColorToleranceSpeedModifier.

Sorry, I went to get a haircut and only JUST got back (was posting from my phone).

From: Shay
Sorry, I went to get a haircut and only JUST got back (was posting from my phone).

Any updates?

Yes, Urn support is still a bit buggy, and i'm trying to get it working 100% of the time since it seems to stop abnormally >.>

From: Shay
Yes, Urn support is still a bit buggy, and i'm trying to get it working 100% of the time since it seems to stop abnormally >.>

I'd suggest grabbing the colors residing between the urn's opening (that signify it's fully) and the urn's main body/the lower half of the urn; that color amount is always the same size (color may vary) when a urn becomes ''filled'' up.

Has there been a stable release of the the basic cooking script yet?

nice script sin will try this out

s1n when will you release a stable release of your script out?

From: Jos3ph
s1n when will you release a stable release of your script out?

Man seriously, it's been said multiple times. You need to change a number in the script and it's stable.

From: Fruit
It's already been posted. :duh:
Change 0.10 to 0.40 in SetColorToleranceSpeedModifier.

Just press CTRL+F and then type SetColorToleranceSpeedModifier and it will bring you there, then change 0.10 to 0.40.

From: 3Garrett3
Man seriously, it's been said multiple times. You need to change a number in the script and it's stable.



Just press CTRL+F and then type SetColorToleranceSpeedModifier and it will bring you there, then change 0.10 to 0.40.

The fact s1n said it shouldnt be 0.10 I just figured someone had something in their script, I never messed with the script nor did I look to see if I should edit it from 0.10 to 0.40 I'll scroll into the script now fix it and post the line for others to scrub right to it to fix if they dont want to do CTRL+F


Line 61, not very far down for those who are interested.

SetColorspeed2Modifiers(0.40,0.99);


It randomly selects my raw shark in the bank, right clicks and goes at random right clicking doesnt leave bank; only cook 2 loads of sharks before it messed up…


I'm done testing the script; it screws up in more then one area, doesnt bank the items properly, doesnt withdraw them properly….

With an attitude like that, why would s1n want to fix a script for you? You haven't given any useful feedback, you double post even though you clearly know how to edit your post, and you complain nonstop and ask the same question over and over even when a solution has been presented.

The script will be fixed when it's fixed. Since other people have reported that it was in working order, I'm starting to wonder if it isn't a problem in your setup, rather than the script.

With an attitude like that, why would s1n want to fix a script for you?

Let me put you in your place for a second, I didn't give a fucking attuide first of all. I've tested the script every time he posted a copy, I've sat and ran through every which way the errors came up and posted them.

I didn't give a attuide when others were saying his scripting was wrong, I sat by and still gave effort to test, so let me tell you something until you test it your self don't bother posting talking about what I am doing, or what I am saying. You dig?

You haven't given any useful feedback

Lets see; on 08-06-2012, 10:37 PM I posted the first error that came up.
Error: divide by Zero at line 148

Then again 08-07-2012, 12:11 PM I posted the second error.

What do I need to give with useful feedback? Do I need to kiss ass as far as feedback or is a simple error report justice enough or is that not good enough for you?

you complain nonstop and ask the same question over and over even when a solution has been presented

I complain? I post the same question over & over? Lets see;

When Change 0.10 to 0.40 in SetColorToleranceSpeedModifier. was mentioned Shay stated it should have been 0.40 so there was no need to change it from 0.10 to 0.40 so I didnt think to even look at it.

Until you reposted it acting like rude asshole it was then when I went to look into the script to change it as it was 0.10 so Shay was in fact incorrect, and I'd have thought Shay could have corrected that in the script but I figured wrong.

Again I don't see where I've complained until I've tested this script since it was posted, first to give feedback and quick with updates when a fix it presented.

I've set the script up properly, I've got no issues running any other script, apparantly there is a banking / withdraw issue.



Do your self a favor, dont post anything back in regards to me; my posts were directed at Shay not you, none of what you've said to me have yet to be useful or helpful you've been nothing but a pain in the ass so just keep it at that and if you wish to take it to another level send me a PM don't waste my time or spamming up some one elses thread.

"Error: divide by Zero at line 148"
Fill in a value for XpItem on line 11.

"I've set the script up properly, "
Clearly you haven't, see above.

"Let me put you in your place for a second, I didn't give a fucking attuide first of all."
He wasn't saying you were giving him a rude attitude, he was saying you were giving him a " Help me plz help help idk whats wrong help" whiney attitude.


Is there a non-rude way to say "You've asked for help literally 10 times [count for yourself], So just wait for a fix [which probably will never come], and shut up?"

I don't advise use of this script due to it being one giant infinite loop, but see above.

From: Nebula
"Error: divide by Zero at line 148"
Fill in a value for XpItem on line 11.

"I've set the script up properly, "
Clearly you haven't, see above.

"Let me put you in your place for a second, I didn't give a fucking attuide first of all."
He wasn't saying you were giving him a rude attitude, he was saying you were giving him a " Help me plz help help idk whats wrong help" whiney attitude.


Is there a non-rude way to say "You've asked for help literally 10 times [count for yourself], So just wait for a fix [which probably will never come], and shut up?"

I don't advise use of this script due to it being one giant infinite loop, but see above.

As I said before, if you have something to say take it to PM. Your previous post wasn't needed, so I just assume you couldn't take the time to read what I posted. LEARN TO READ, don't fill his thread with useless shit; take it to PM or dont say shit at all, you dig?

I am really glad that this script is still active, I like cooking in the cooking guild for some reason. Will be trying this out after I finish my current skill :)

Thanks for the great work

Joseph, I'm not too sure why it's not working for you..
I got a 280k/H proggy with the Clan Avatar boost.

From: Shay
Joseph, I'm not too sure why it's not working for you..
I got a 280k/H proggy with the Clan Avatar boost.

I've been gone for a few days; whats the clan Avatar boost, lol!

Any how how did you like the vacation to Florida?



back on to topic of the script, I've not gotten it to run; I am using 8.0 would this be a issue?

From: Jos3ph
I've been gone for a few days; whats the clan Avatar boost, lol!

Any how how did you like the vacation to Florida?



back on to topic of the script, I've not gotten it to run; I am using 8.0 would this be a issue?

One sec mate, let me get a video up for you.
Urn support is the only thing that's really annoying me, sometimes it works flawlessly, other times it just flops.

OffT, it was great!

From: Shay
One sec mate, let me get a video up for you.
Urn support is the only thing that's really annoying me, sometimes it works flawlessly, other times it just flops.

OffT, it was great!

What part of FL did you go?


Yes a video would be great & Im not in a huge rush over getting urn support.

[YOUTUBE]RKof3m3Pbow[/YOUTUBE]
Still processing iirc.

Will take a look at it shortly. Thanks for taking the time to post a video +rep

Well i'll upload my dev version.

<Removed In-appropriate content ~BraK>

Is there anyway to have it not click the same exact spot everytime it chooses the "cook shark" option without having to change a lot of code? Also, do you think it would make more sense to have it attempt some kind of anti ban while the food is cooking or is it better as it is now just having the mouse sit idle like a constantly afk player?

just trying to help you out..

function IsEvenNumber(x:Integer):Boolean;
var
  n:Extended;
begin
  repeat
    n := (x / 2);
    writeLn((n));
  until(n = 1) or (n = 0.5);
  writeLn((n));
  if (n = 1) then
    Result := True else Result := False;
end;

This would never work since the loop uses x which never changes so unless x is 2, this will continue on and on and on and on and on forever and ever and ever and on and on and forever.

A better method would be this:

{Full credit to Nebula for this, my original method was completely flawed}
function IsEvenNumber(x:Integer):Boolean;
var
  n:Extended;
begin
  n := x;
  while n > 1.0 do
    n := n / 2;
  result := n = 1;
end;    

procedure rToW;
begin
  MouseItem(1,1);
  Wait(50 + Random(750));
  if FindBlackChatMessage('full') then
  begin
    wUrn := False;
    Exit;
  end else
    wUrn := True;
end;   

Tbh what I am posting below seriously upsets me I'm not trying to shit talk you I'm just saying that you should know better than this.

procedure rToW;
begin
  MouseItem(1,1);
  Wait(50 + Random(750));
  if FindBlackChatMessage('full') then
  begin
    wUrn := False;
    Exit;
  end else
    wUrn := True;
end;   

Could be this..

procedure rToW;
begin
  MouseItem(1,1);
  Wait(50 + Random(750));
  result := not FindBlackChatMessage('full');
end;         

From: Shay

//Its going to stay like this Nebula, deal with it. 

Lol- These actually made me laugh

function IsEvenNumber(x:Integer):Boolean;
var
  n:Extended;
begin
  repeat
    n := (x / 2);
    writeLn((n));
  until(n = 1) or (n = 0.5);
  writeLn((n));
  if (n = 1) then
    Result := True else Result := False;
end;

I was messing around with that, it didn't work so yeah.

procedure rToW;
begin
  MouseItem(1,1);
  Wait(50 + Random(750));
  result := not FindBlackChatMessage('full');
end;

Erm, there's a few things wrong, it's a procedure so Result wouldn't work, and I need to set a global var to true :l

I meant wUrn not result. so this:

procedure rToW;
begin
  MouseItem(1,1);
  Wait(50 + Random(750));
  wUrn := not FindBlackChatMessage('full');
end;

Gah well, that'll work too xD

Changed a line,

procedure ChooseInterfaceOption;
begin
  if ChatInterfaceUp then
    Mouse(230 + Random(55),400+Random(60),3,3,True);
end;

and borrowed some anti-ban from another script. With Urns turned off it seems to work ok, SRL is seriously failing at doing any randoms though but that isn't too much of a problem.

Don't think I will be using the script enough to try and mess with the urns working properly, I will look at it while I babysit the script maybe

I like the concept of the script but I'm having an issue. I can get the script to open up the bank but

if BankScreen then
break;
never goes true so I can't get past this. I've tried both versions of the script and gets stuck at the same location. any advice?

Thanks

Oooh I'm looking forward to this little gem. I haven't used Simba since the slayer update fucked it up, so it might take a little bit to get it running. But 90-99 cooking shall be nice with this ^.^, thanks.

the script works wonderful most times but sometimes it just stops randomly after the inventory finishes

Unfortunately i do not know how to script but just an idea to fix the urns scripting, make it so you never click deposit inventory, and there fore make it always right click sharks and deposit all sharks, still keep the first step of left clicking the first inventory space before banking but script the WithdrawUrn procedure to false if InvCount > 1.

though you will be missing out on the bonus 20% xp on 17 sharks because it takes 37 sharks to fill 1 and two inventory is 54, this is just a simple and basic idea to improve the xp/hr rate of this script. Im sure my idea will help you think of a better way to incorporate flawless urning into the script but however this is a public script and i greatly appreciate the work and effort you have put into it.

i hope you understand what i mean

new idea, if you have two decorated cooking urns in ur inventory and make the script click the first and second slot of ur inv before banking and withdraw urns only when ur invcount < 2, though this seems more bot like since you are clicking both urns without human detection of which urn was recently withdrawn, it will still be a 20% more efficient way of cooking anything!

Of course, anyone that is still burning sharks would be fucked if deposit all wasn't used. It would end up with a full invent of burnt sharks eventually. Of course there could be a catch for that aswell but whatever

Some how it made 4-5 trips then failed a right click and was just randomly clicking the shark to bank…

Cool script, will use soon.

@the above

function IsEven(N: Integer): Boolean;
begin
  Result := ((N mod 2) = 0);
end; 

From: scipio
Cool script, will use soon.

@the above

function IsEven(N: Integer): Boolean;
begin
  Result := ((N mod 2) = 0);
end; 

Is that what I need to change the script to?

From: scipio
Cool script, will use soon.

@the above

function IsEven(N: Integer): Boolean;
begin
  Result := ((N mod 2) = 0);
end; 

I too noticed the strange complex original function for finding out whether a number was even but I didn't change it since it wasn't used in the script anymore

@below, changing that shouldn't make any difference to your problem

Can anyone tell me how I could fix my issue I have nearly 20k sharks I need to cook.

For most of my cooking I used Enslaved's Cooking Guilder bot. For me it worked much better.

From: Solar
For most of my cooking I used Enslaved's Cooking Guilder bot. For me it worked much better.

And this is on my thread why……..?


Not too sure why it's happening, it's working perfectly for me :x

From: Shay
And this is on my thread why……..?


Not too sure why it's happening, it's working perfectly for me :x

I was just telling Jos3ph that there is an alternative. Sorry.

From: Shay
And this is on my thread why……..?


Not too sure why it's happening, it's working perfectly for me :x

I will test again but I'll teamview with you if it happens again

============S1NCooker==============
Time Running: 3 Hours, 6 Minutes and 23 Seconds
XP Earned: 703080
XP/h: -157742
Items Cooked: 3348
===================================
great script man i will try for 6 hours
next up i will try rocktail if the are supported?
sorry for sounding like a leacher i am trying to learn scripting

They're supported ^.^

From: Shay
They're supported ^.^

rocktails don't work for me they take them out select them and it cant find the cook option.

Moved to Outdated

Gave it a run and it still works.