SRL Archive - RS3 Outdated / Broken Scripts

P1ng's AIO Potion Maker


P1ng

2012-06-27 23:18:38

P1ng's All-In-One Potion Maker
- Uses herb with vial of water or secondary ingredient with unfinished potion.
- Quick and efficient.

Setup:
Have herb/secondary ingredient in the first bank slot.
Have vial of water/unfinished potion in the second bank slot.
Fill out player information in DeclarePlayers.
Press run.

Features:
- Debug progress report (Strange rocks will make you skip an inventory).
- Option to have on-screen progress report as well.
- Fully randomized withdrawal and mixing procedures.
- Will terminate on not enough of either ingredient.
- Quick potion making.
- Can work in multiple locations.
- Finds and handles randoms.
- Antiban.
- Breaking.
- Failsafes.
- Supports any combination of ingredients.
- Fast herblore XP.


To Be Added:
- None at present.

Known Bugs:
- Strange rocks screw up progress report.

Progress Reports:
|------>P1ngs AIO Potions<------|
# Of Pots Made: 98
XP Gained: 10418
Est XP Per Hr: 163848
Time running: 03m 48s
|---------------------------------|


EDIT: Uploaded new script with compatibility for Simba 990. Download the bottom link of v2 for the latest version

Dannyownz

2012-06-28 04:21:03

Good release. Will test out now.


After making 196 pots, this is what I got

|——>P1ngs AIO Potions<——|
# Of Pots Made: 196
XP Gained: 0
Est XP Per Hr: 0
Time running: 06m 30s
|———————————|

The XP is messed up, but it is a pretty solid script. I will be using this in the furture

P1ng

2012-06-28 04:51:49

Were you making unfinishe pots? You dont gain xp for making unfs, only cleaning herbs and making the finished product

Dannyownz

2012-06-28 04:57:05

oh, that could be why. I bot cleaning herbs so i can make money. :) Ill finish some right now.


>>Edit<<
|——>P1ngs AIO Potions<——|
# Of Pots Made: 182
XP Gained: 24250
Est XP Per Hr: 155989
Time running: 09m 19s
|———————————|

Thanks for the script because i got 60 herb and a 1900 total level milestone :)

zunkill

2012-07-01 10:56:39

using this script for 80 herblore.
didnt know you dont get exp for adding herbs to water but oh well still a task for me to do :P using your script that is XD

gunna make my potion after it finishs =]
did you know theres an option to turn strange rocks off at the museum? :)

P1ng

2012-07-03 10:38:42

Cool man, best of luck with heading for 80 herblore! Don't forget to post any nice proggies you get here so I can add a decent one to the OP ;)

P1ng

2012-07-17 19:47:14

New QuickFix version available for download.
Only works at Soul Wars bank chest.
Very quick job at fixing this script just to get it back up and running, if you encounter any errors please post them here, but likely they will be fixed with the Simba/SRL quickfix guide below -

Simba/SRL QuickFix guide:
http://villavu.com/forum/showpost.php?p=1070475&postcount=866

This version of the script will not be added to the OP ever as the script will be made compatible with all banking locations once the official fix for Simba/SRL is released.

QuickFix Script: REMOVED

rewopelet

2012-07-18 14:58:17

banking not working at sw
it click on you not the chest

P1ng

2012-07-18 21:52:24

Banking edited slightly and same with some co-ordinates.
If you have used the quickfix in my sig this should work for you.

QuickFix Script: REMOVED

forslyen

2012-07-18 23:38:45

For me it will withdraw 14 and 14 and keep attempting to combine them but not actually do so. Eventually it will deposit the ingredients and withdraw more.

P1ng

2012-07-19 00:10:56

So what's actually happening? Where is it clicking instead of the potion box? Does it just keep using the two ingredients together and not even attempt to click the potion box?

1. Are you using SMART?
2. Did you do the QuickFix in my sig?

More details please.

hackingislol133

2012-07-19 00:17:57

After a batch of unfs are finished, it takes 5-7 seconds to respond and deposit again.

When entering bank screen, after depositing will sometimes crash.

P1ng

2012-07-19 00:23:11

I know about the long time to respond when banking. That can be removed quite easily if you have no pin to enter.
In regards to the crash after depositing, that can be easily fixed also but it requires removing the scripts ability to check that there are a sufficient amount of items to withdraw.

hackingislol133

2012-07-19 15:44:10

Removing the bank check method would also double as a way to mix more than 1 different herb at once.

P1ng

2012-07-19 20:32:38

True, but then if you run out of all herbs and vials of water no human would then start trying to mix something like coal and rune hatchets. That will look very bot-like unless you set TOTALPOTS to a number equal or slightly lower to how many ingredients you have.

Never the less, if you want to implement the 'no check'ing withdrawal procedure to go around the item glitch here is what you need to put in place of the existing WithdFI and WithdSI -

QuickFix Codes: REMOVED

710johnw

2012-07-26 15:20:39

well it doesnt click the make x. it withdraws herbs and vials then clicks them together over and over

skillzmatic

2012-08-02 17:10:16

|———————————|
|——>P1ngs AIO Potions<——|
# Of Pots Made: 2044
XP Gained: 332150
Est XP Per Hr: 247025
Time running: 01h 20m 40s


Making range pots. Thanks alot for the script!

johnarnts

2012-08-02 21:32:25

Script does struggles to find bank and sometimes does not click make x. :( Also invy wait time is a little long, how would I change?

P1ng

2012-08-03 00:40:02

Have you downloaded the most recent one which is in the OP as of yesterday?

johnarnts

2012-08-03 10:25:45

From: P1ng
Have you downloaded the most recent one which is in the OP as of yesterday?


Yes I was using the newest version :/

P1ng

2012-08-03 21:40:43

What does it do when you say it 'struggles to click make X' ?

Instead of clicking it, what does it do?

johnarnts

2012-08-04 00:29:50

It just sits there doesn't click and rebanks

P1ng

2012-08-04 03:39:25

Does it move the mouse to the make all thing or just doesn't move at all?

Wardancer

2012-08-05 15:49:11

I'm having the same issue with banking. On one world, the mouse went straight to a guy wearing a purple cape (but completely ignored the closer bankers). On another, it just went somewhere randomly on the screen and stayed there.

EDIT: Just to explain what caused it. I got a brain freeze and didn't select the correct bank. Make sure you selected the correct one and it should work.

EDIT2: No, it wasn't a brain freeze after all. It has to do with the fix to open the bank faster without the few seconds of delay. Now that I used it, it only hovers over different bankers without clicking on them.

P1ng

2012-08-05 22:13:35

Are you certain you have updated to the latest version I released on 02 August?
Which bank are you using it at?

Wardancer

2012-08-07 13:04:08

I downloaded the script the same day I posted, so yes it has to be the new version. Also, it was working fine before editing the code to make the banking faster. All I had was the little issue of the time wasted after mixing before banking. I notice that you edited your posts to remove the "fix" to the banking delay so I can't check to see if that was posted before or after the new version of simba. That might be the issue here (that I pasted a part of script meant for an older version of simba).

P1ng

2012-08-07 20:21:15

Updated to work with SMART 7.2/8.0 and Simba 991
For this update download P1ngAPM v2 from the OP of this thread. Should fix any issues you have and is currently running just fine for me.

Destined2bGreat

2012-08-10 19:01:43

Just bought 60-99 herblore and I was hoping to be using this. I have the scroll of cleansing, so some herbs are saved. It thinks that the potions are still mixing because of this.

Datchikk

2012-08-10 19:08:15

May I ask can this do extreme ranges

P1ng

2012-08-11 01:10:18

This just does normal potion mixing. First ingredient with vial of water. or unfinished potion with secondary ingredient.

US Marine

2012-09-13 09:30:33

Should be 99 smithing by the end of tomorrow, bought 96-99 herblore. Going to see how this lovely script fairs me. :)

E:



Thanks for the 99!

Easy script to work, and did extremes extremely well!!!! Thanks!!

whisper133

2012-09-30 14:01:42

is there a way that i can add Super antiFire potions since it doesn't start with "use" and it says "drink" instead

Kevork

2012-10-13 21:27:39

Im having some trouble. its not logging me in at all, and if i log myself in and hit play it announces my stuff in pub chat. what am i doing wrong?

shaezy

2012-10-28 03:54:34

I was using this script a couple of days ago and it was working good.

I tried it again today and it loads the login screen but does not log me in. the cursor stays in the top left screen and does not move.

i updated simba and everything else and still no change.

i then tried logging in myself and then starting the script but the cursor still stays in the left of the screen.

there is not much happening in the commands, the last thing it says is 'loading smart: http://world2.runescape.com/f2337'

Ashaman88

2012-10-28 07:55:53

Are you sure you're on fixed mode, max brightness and whatnot? And put your login details in the script?

P1ng

2012-10-28 08:21:58

I'm not aware of any issues that should be cropping up with my scripts, but I believe I have stated previously that I am awaiting the final turn out of this new botwatch that Jagex has recently rolled out before updating any of my scripts. I don't believe that this script should be outdated, but it is certainly possible. You will simply have to wait until I believe it is time to release a new version unless you have the ability to fix your errors on your own.

shaezy

2012-10-28 12:55:59

From: Ashaman88
Are you sure you're on fixed mode, max brightness and whatnot? And put your login details in the script?

yeah i have all the correct settings, everything is the same as it was when it was working.

the only difference i can think of is that its the double exp weekend.. but that wouldn't affect it would it?

imthecactus

2012-11-01 00:45:45

Nice script.


Although, how would I go about changing the time it takes before it banks the potions?

procedure PUse;
var
Counter: Integer;
begin
Status('PUse');
if not LoggedIn then
NextPlayer(False);
if FindNormalRandoms or FindNonInventoryRandoms then
Exit;
if WaitFunc(@InvFull,RandomRange(10,50),RandomRange(2000,2750)) then
begin
repeat
InvMouse(1+Random(13),mouse_Left);
Wait(RandomRange(200,400));
Invmouse(15+Random(13),mouse_Left);
Inc(Counter);
[B] if WaitFunc(@HerbMenu,50 + Random(25),2000 + Random(750)) then
Break;
until(Counter > 3);[/B]
end else
begin
WriteLn('Not a full inventory @PUse');
TerminateScript;
end;

The bolded section is what Id assume it to be. I haven't really gotten time to watch all of the tutorial videos.

Sincerely,
Noob.

Swifte

2012-11-05 22:10:41

I think it should be somewhere below your username + password set up. Like… Really close below.

euphemism

2012-12-07 22:26:43

Moved to outdated.