SRL Archive - RS3 Outdated / Broken Scripts

Description
This script fly-fishes at the Lumbridge fishing spots. It uses the unlimited teleports supplied by the dungeoneering ring and the lumbridge home teleport to bank and return to the river.

How to Use
1) Fill out the setup.

const
  UserPin   = ''; // Leave blank if not using a pin
  TimeToRun = 360; // Minutes to run the script for (0 to run until stopped)
  UseRest   = True; // Rest when low energy

procedure DeclarePlayers;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  with Players[0] do
  begin
    Name       := ''; // Player username
    Pass       := ''; // Player password
    BoxRewards := ['XP', 'ostume', 'mote', 'oins', 'une', 'ssence'];
    LampSkill  := Skill_FISHING;
    Active     := True;
  end;
end;

2) Place your character anywhere.
3) Equip:
–> Ring of kinship
4) Have feathers in the first slot of your inventory, with the rest empty.
5) Sort your spellbook by level and have all spells on.
6) Hit run!

Requirements
1) 20 Fishing

Additional Info
-> The script will only run for 1 load if the TimeToRun const is set to an unreasonable amount (9999+). Be sure to set it to 360, 720, etc.

Top Reports
-> Runaway!

 Runaways                                 v0.15!
<=------------ Lumbridge Fly-Fisher -----------=>
|  Running for: 6 Hours, 26 Seconds
|  Caught: 1414 trout
|          933 salmon
|  Banked: 88 loads
|  Fishing XP gained: 136010 XP
<=---------------------------------------------=> 

-> curiousgeorge322!

 Runaways                                  v0.1!
<=------------ Lumbridge Fly-Fisher -----------=>
|  Running for: 3 Hours, 23 Minutes and 8 Seconds
|  Caught: 618 trout
|          443 salmon
|  Banked: 39 loads
|  Fishing XP gained: 61910 XP
<=---------------------------------------------=> 

-> Runaway!

 Runaways                                 v0.15!
<=------------ Lumbridge Fly-Fisher -----------=>
|  Running for: 3 Hours, 4 Minutes and 1 Seconds
|  Caught: 735 trout
|          467 salmon
|  Banked: 44 loads
|  Fishing XP gained: 69440 XP
<=---------------------------------------------=>

 Runaways                                 v0.15!
<=------------ Lumbridge Fly-Fisher -----------=>
|  Running for: 2 Hours, 43 Minutes and 14 Seconds
|  Caught: 686 trout
|          437 salmon
|  Banked: 42 loads
|  Fishing XP gained: 64890 XP
<=---------------------------------------------=>

 Runaways                                  v0.2!
<=------------ Lumbridge Fly-Fisher -----------=>
|  Running for: 2 Hours, 13 Minutes and 27 Seconds
|  Caught: 525 trout
|          396 salmon
|  Banked: 35 loads
|  Fishing XP gained: 53970 XP
<=---------------------------------------------=> 

Current Bugs
-> If the daemonheim teleport places the player too close to the steps it will screw up when walking to the bank. The script will fix itself after 15 seconds though. (happens ~1 in every 50 or so teleports)
-> May not recognize the NPC dot color which will throw off walking.
-> Can accidentally click on the wrong side of the river when walking to the fishing spots.

Bug Fixes
-> If you come across this error message:

ERROR: NPC color not found! See thread for fix.

You've come to the right place. First, navigate to the DeclareColors procedure, which is inside the script setup area:

 
procedure DeclareColors;
begin
  // Only update if NPCs cannot be located \\
  NPC := [2162687, 1900543, 1783370, 1702399, 1701113, 1505535, 1437694, 1374705, 1372665, 1244415, 1179647, 1179644, 1043199, 981753, 916991, 786430, 783103, 777964, 773595, 720883, 718847, 717815, 717567, 654579, 653311, 651775, 648667, 645348, 640979, 589823, 589311, 588280, 587000, 584957, 584171, 583916, 579817, 579802, 578776, 575448, 574407, 522732, 458751, 450798, 393210, 391151, 327667, 326911, 326385, 325112, 323558, 322788, 319972, 318418, 317648, 315603, 314049, 313279, 257009, 255470, 196604, 127367, 65522, 65233, 63478, 61670, 61439, 61150, 60651, 59355, 56781, 55511, 55014, 53474, 51142, 50645, 49105, 47302];  

The NPC array is the one you want to add a new color to. To do this, go back to your browser, click on the color picker tool in Simba, and select the yellow color of the NPC dot with it. The color you chose will show up in Simba's debug like this:

Picked colour: 225126 at (1216, 209)

Take the color and add it into the NPC array as the first color:

  NPC := [225126, 2162687, 1900543, 1783370, 1702399, 1701113, 1505535, 1437694, 1374705, 1372665, 1244415, 1179647, 1179644, 1043199, 981753, 916991, 786430, 783103, 777964, 773595, 720883, 718847, 717815, 717567, 654579, 653311, 651775, 648667, 645348, 640979, 589823, 589311, 588280, 587000, 584957, 584171, 583916, 579817, 579802, 578776, 575448, 574407, 522732, 458751, 450798, 393210, 391151, 327667, 326911, 326385, 325112, 323558, 322788, 319972, 318418, 317648, 315603, 314049, 313279, 257009, 255470, 196604, 127367, 65522, 65233, 63478, 61670, 61439, 61150, 60651, 59355, 56781, 55511, 55014, 53474, 51142, 50645, 49105, 47302]; 

Now you should be able to run the script with no issues! Be sure to post the color you've found on this thread so that it can be added to the official version of the script!

Future Updates
(Please make suggestions!)
-> Speed up recognition processes

Update Log

[B]v 0.2[/B]
- Massive NPC color revamp
- More river walking failsafes
- Revamped walking function
[B]v 0.15[/B]
- Fixed the river walking problems
- Sped up a few functions
- More failsafes added
[B]v 0.1[/B]
- Initial release

Looks good, :) prob will be using, been meaning to get my new mains fishing up, how do banking times compare with edgeville? You could add:

until((TimeToRun <> 0) and (TimeFromMark(t) > TimeToRun * 60 * 1000));

so that players can set TimeToRun to 0 to make it not stop (sorry I'm on my phone so I can't see the line number)

From: putonajonny
Looks good, :) prob will be using, been meaning to get my new mains fishing up, how do banking times compare with edgeville? You could add:

until((TimeToRun <> 0) and (TimeFromMark(t) > TimeToRun * 60 * 1000));

so that players can set TimeToRun to 0 to make it not stop (sorry I'm on my phone so I can't see the line number)

Gosh, why didn't I think of that! Thanks, I'll add it into the next update.

As for the banking times: I don't know anything about Edgeville as I haven't fished there in years, but this goes from a full inventory to fishing again in ~80 seconds.

Already got a 6hr report! If I can get any suggestions on what to improve that would be great :)

 Runaways                                 v0.15!
<=------------ Lumbridge Fly-Fisher -----------=>
|  Running for: 6 Hours, 26 Seconds
|  Caught: 1414 trout
|          933 salmon
|  Banked: 88 loads
|  Fishing XP gained: 136010 XP
<=---------------------------------------------=>

EDIT: For anyone wondering, v0.15 has not yet been released. I am testing a few different things with it until I've found the best configuration.

Will be trying this out, your scrips are insane.

From: Theron
Will be trying this out, your scrips are insane.

Thanks :p Let me know how it goes!

Great script, but mine keeps getting stuck randomly on the correct side of the river, but south of the fishing spots, right next to the goblin house right across the bridge.

This is fine because it just means I need to watch it and fix it, and it isn't THAT often it gets stuck.

I love your scripts man! This one has a little trouble walking to the fishing spot though. It consistently gets stuck by the goblin building directly across the river. It also has a little trouble banking–It finds the banker and hovers over him without banking every once in a while. Regardless, it generally figures itself out after a few extra home teleports/demonheim teleports.

With some babysitting help (not nearly as fast as some of your proggies):

Runaways v0.1!
<=———— Lumbridge Fly-Fisher ———–=>
| Running for: 3 Hours, 23 Minutes and 8 Seconds
| Caught: 618 trout
| 443 salmon
| Banked: 39 loads
| Fishing XP gained: 61910 XP
<=———————————————=>


Thanks!

From: Esparno
Great script, but mine keeps getting stuck randomly on the correct side of the river, but south of the fishing spots, right next to the goblin house right across the bridge.

This is fine because it just means I need to watch it and fix it, and it isn't THAT often it gets stuck.

From: curiousgeorge322
I love your scripts man! This one has a little trouble walking to the fishing spot though. It consistently gets stuck by the goblin building directly across the river. It also has a little trouble banking–It finds the banker and hovers over him without banking every once in a while. Regardless, it generally figures itself out after a few extra home teleports/demonheim teleports.

With some babysitting help (not nearly as fast as some of your proggies):

Runaways v0.1!
<=———— Lumbridge Fly-Fisher ———–=>
| Running for: 3 Hours, 23 Minutes and 8 Seconds
| Caught: 618 trout
| 443 salmon
| Banked: 39 loads
| Fishing XP gained: 61910 XP
<=———————————————=>


Thanks!

Ahh I guess I will release v0.15 a little early, I have fixed it in that version. I was using FFlag(2); in v0.1 to handle the walking wait time, but since the flag is out of the screen for a bit when walking to the first point towards the river, it can break it occasionally.

E: And my proggies are most likely faster because I constantly tweak it while it's running :p

v0.15 released and up for download!

Thanks for the early release, heres a proggy

<=———— Lumbridge Fly-Fisher ———–=>
| Running for: 1 Hours, 37 Minutes and 7 Seconds
| Caught: 400 trout
| 247 salmon
| Banked: 24 loads
| Fishing XP gained: 37290 XP
<=———————————————=>

One random that was completed (abyss so it was fast)

EDIT: aww I just noticed I almost have 1337 as my time. :(

So I'm still getting stuck, this time a little more north than before, but still close to the goblin house right across the bridge. It's happening less, but still happening.

From: Esparno
So I'm still getting stuck, this time a little more north than before, but still close to the goblin house right across the bridge. It's happening less, but still happening.

Could you take a screenshot of the spot you get stuck at? I am having no issues with walking. Maybe you could try setting the SMART slider higher as well. I always set mine here:

I'll take a screenshot of the next time it gets stuck. I changed the smart slider to where yours is. What does changing the smart slider do? (If you can't tell I'm a novice at using Simba)

EDIT: I looked it up, it increases the frame-rate, cool. Good to know.

From: Esparno
I'll take a screenshot of the next time it gets stuck. I changed the smart slider to where yours is. What does changing the smart slider do? (If you can't tell I'm a novice at using Simba)

EDIT: I looked it up, it increases the frame-rate, cool. Good to know.

Yeah. It uses more CPU, but if you've got enough to give it will only make your botting experience better ;)

v0.2 has been released! Check out the "Update Log" on the first post to see what has been changed!

All river-walking issues should be fixed now :)

Sometimes when i turn on again there will still be fish in the inventory.. It will go fish, catch two of them then log out. Debug: Error: Cannot fing fish in inventory!

I'll run this today for 2-3 hours. I'll tell you if anything goes wrong.
Edit: Ran for about 1.5 hours, it screwed up walking about 5 times on the way to the fishing spot, I had to fix manually. You should check for the fishing spot sign before attempting to find the fishing spot, it could fix itself very fast that way.

From: Becks
Sometimes when i turn on again there will still be fish in the inventory.. It will go fish, catch two of them then log out. Debug: Error: Cannot fing fish in inventory!

Hmmph these color issues are popping up in most of my scripts and it's getting rather frustrating :(

From: litoris
I'll run this today for 2-3 hours. I'll tell you if anything goes wrong.
Edit: Ran for about 1.5 hours, it screwed up walking about 5 times on the way to the fishing spot, I had to fix manually. You should check for the fishing spot sign before attempting to find the fishing spot, it could fix itself very fast that way.

Which spot does it get stuck on? The colors I use for the last fishing spot walk (2 of 2) are actually the fishing spot colors :p I grabbed the land color, the fishing icon background and the fishing icon blue color. It should also be checking for the fish symbol in RiverAdjust (which is called on the aforementioned walk point), but maybe I did something wrong 0.0

From: Runaway
Hmmph these color issues are popping up in most of my scripts and it's getting rather frustrating :(



Which spot does it get stuck on? The colors I use for the last fishing spot walk (2 of 2) are actually the fishing spot colors :p I grabbed the land color, the fishing icon background and the fishing icon blue color. It should also be checking for the fish symbol in RiverAdjust (which is called on the aforementioned walk point), but maybe I did something wrong 0.0

It walked into the lumby castle when it got stuck 3 times, don't remember the others. The problem was that it kep searching for the fishing spots without realizing that it wasn't near them.

From: litoris
It walked into the lumby castle when it got stuck 3 times, don't remember the others. The problem was that it kep searching for the fishing spots without realizing that it wasn't near them.

What the… I'll add a whole bunch of walking failsafes then, I guess :redface:

PS: Love your new signature <3