From: Kyle Undefined
It's not about just reviewing it and merging it, it's about the impact it will have once it's merged ;)
Yes removing the Smart_Server and stuff will impact many scripts and cause noobs to post all over the place asking how to fix it but leaving it there is useless.. Leaving support for the versions lower than 7.1 is much harder to maintain.
It's only 4 lines to remove but I see where you're coming from then again:
Saving Parameters then loading them from a file, keeping track of a timer for the 6hr limit in which a parameter may or may not expire, keeping track of a current parameter so that smart does not close when play is pressed again, etc..
Whereas the new version just passes it directly, once, and that's it. I honestly don't mind leaving the old way in there. Mormanman doesn't want it and I'm pretty certain Ben would prefer just calling get params and passing it instead of keeping track but I don't mind.
Either way if I leave the old one in there, something has to give.
It'd be {$DEFINE SMART} for LibSmart32 vs. {$DEFINE SMARTREMOTE} for LibSmartRemote32 whereas it can be removed and just be {$DEFINE SMART} for the latest.
Anyway if no one wants smart_server and stuff removed then I still have a backup of the previous push so I can just replace it if needed. Don't have to write anything new.