SRL Archive - SRL Bugs

Bankers


'Toxin

2012-05-29 12:16:43

All bankers are now broken and will need to be fixed within SRL. This is due to today's update (5/29/2012).

Kyle Undefined

2012-05-29 12:19:26

What about chests? I'll look into this later.

'Toxin

2012-05-29 12:24:16

I believe chests are fine, just NPC's were changed.

Kyle Undefined

2012-05-29 12:40:47

OpenBank, and all the other OpenBanks still work perfectly. I believe I've gotten the best color for the banker NPC.

Change lines 1719 - 1720 with this:

SetColorSpeed2Modifiers(0.10, 1.48);
FindColorsTolerance(Colors, 4674189, NPCBox.X1, NPCBox.Y1, NPCBox.X2, NPCBox.Y2, 21);

I did multiple client reloads to grab all the colors and it's found the NPC every time. Let me know if there are any false positives. If there's none, I'll push this through.

I have also attached the ACA file I have, it's using the pink shirt.

litoris

2012-05-29 14:42:51

They will change back to the original in 2 weeks or so I think.

Kyle Undefined

2012-05-29 14:56:44

Hmm ok, is it for a special event?

jackhill6

2012-05-29 14:59:54

yeah, chests are fine.

Hadley

2012-05-29 15:09:25

From: Kyle Undefined
Hmm ok, is it for a special event?


it's just for the diamond jubilee event jagex released.

Kyle Undefined

2012-05-29 15:12:18

Ahh ok, well pushing a fix now and then reverting after it's over will be the best option.

Benny

2012-05-29 15:14:33

Good work guys thanks for being so prompt!

Faab68

2012-05-29 15:27:48

I have to say, i'm kind of new to this community, i don't reply much, but i read alot.
This community is always so fast with fixes, it's unbelievable. Thank you guys!!
Thanks kyle for the quick fix.

'Toxin

2012-05-29 15:36:31

From: Kyle Undefined
OpenBank, and all the other OpenBanks still work perfectly. I believe I've gotten the best color for the banker NPC.

Change lines 1719 - 1720 with this:

SetColorSpeed2Modifiers(0.10, 1.48);
FindColorsTolerance(Colors, 4674189, NPCBox.X1, NPCBox.Y1, NPCBox.X2, NPCBox.Y2, 21);

I did multiple client reloads to grab all the colors and it's found the NPC every time. Let me know if there are any false positives. If there's none, I'll push this through.

I have also attached the ACA file I have, it's using the pink shirt.


Yup, it works… Issue resolved.

Kyle Undefined

2012-05-29 15:39:57

Ok, I'll do a hotfix for this. I'll leave the original values in the code, and just add these to it. Should update in an hour at the most.

Hadley

2012-05-29 15:50:52

works great Kyle, thanks a bunch. :D

somethingcool

2012-05-29 16:25:55

ok so im kinda new here iv just started using aks smelter in edge and cant get it to find bank any help please?

Hadley

2012-05-29 16:36:03

From: ethenhenderson
ok so im kinda new here iv just started using aks smelter in edge and cant get it to find bank any help please?


in the core folder under srl (C:\Simba\Includes\SRL\srl\core) edit the bank script by replacing line 1719/1720 with what kyle gave us. It should find the banker then.

somethingcool

2012-05-29 16:52:21

sweet thank you very much i wasnt sure were to insert the new line now i know and real quick what should i do when it changes back ?

iamafish33

2012-05-29 22:15:51

hey guys I have a question. Im using Leetz super heater and before the SRL update the script couldnt find the banker at the GE. I asked on the script thread and I was directed here to figure out how to fix it. Well I followed the directions to fix it but I saw that it had already been updated with temporary colors (right? Im new so I am just going off of what I read on line 1722-1724) so I left it alone assuming it had been updated. The only problem is that the super heater script still cant find the banker. Am I doing something wrong or is there something I can do to fix this?

Hadley

2012-05-30 03:56:17

From: iamafish33
hey guys I have a question. Im using Leetz super heater and before the SRL update the script couldnt find the banker at the GE. I asked on the script thread and I was directed here to figure out how to fix it. Well I followed the directions to fix it but I saw that it had already been updated with temporary colors (right? Im new so I am just going off of what I read on line 1722-1724) so I left it alone assuming it had been updated. The only problem is that the super heater script still cant find the banker. Am I doing something wrong or is there something I can do to fix this?


It's line 1719 and 1720 that need to be changed. Read post #16.

Kyle Undefined

2012-05-30 09:56:18

SRL should update with the correct banker colors, all you have to do is update your SRL.

'Toxin

2012-05-30 11:18:09

Kyle, colors are off. They seem to work for a few runs sort of speak, however after that they may have change, or the tol is off.

Robinhotje

2012-05-30 11:48:18

I updated SRL but it still doesn't work. I'm trying to bank in Edgeville..

Kyle Undefined

2012-05-30 11:48:58

Ok, use the ACA file to add the colors of the pink shirt to the list. I did 6 complete client refreshes to get the colors, you may need to do it a few more times.

Robinhotje

2012-05-30 12:09:36

From: Kyle Undefined
Ok, use the ACA file to add the colors of the pink shirt to the list. I did 6 complete client refreshes to get the colors, you may need to do it a few more times.


I downloaded your ACA file from the post above, but where do I have to put it?

Robinhotje

2012-06-03 08:46:13

Bump

P1ng

2012-06-03 10:33:26

From: Kyle Undefined

Change lines 1719 - 1720 with this:

SetColorSpeed2Modifiers(0.10, 1.48);
FindColorsTolerance(Colors, 4674189, NPCBox.X1, NPCBox.Y1, NPCBox.X2, NPCBox.Y2, 21);

I did multiple client reloads to grab all the colors and it's found the NPC every time. Let me know if there are any false positives. If there's none, I'll push this through.

I have also attached the ACA file I have, it's using the pink shirt.


You don't need to copy the ACA file, just replace lines 1719 - 1720 with the code he posted and it will work. If that doesn't work (like it hasn't for some people) then try grabbing the colours yourself with ACA.

Kyle Undefined

2012-06-04 09:25:12

From: Robinhotje
I downloaded your ACA file from the post above, but where do I have to put it?


The ACA file is only for the ACA program, you load it so you can see the colors I've chosen, then you can add colors to it.

Abu

2012-06-04 09:41:35

From: Robinhotje
I downloaded your ACA file from the post above, but where do I have to put it?


In your script…

Then just call the function in your mainloop or wherever you plan to open the bank.

Robinhotje

2012-06-05 15:20:36

Hmm.. I don't get it to work :(

Jakkle

2012-06-06 09:05:41

Not sure if anyone is still having a problem but these are my banker records I'm using in my script.

Color := 5139932;
Hue := 0.08;
Sat := 2.18;
Tol := 13;

Hasn't failed me yet. Hope that help anyone who decides to use it.