SRL Archive - Archive

Ilya - SRL Member Application


Ilya

2012-05-22 03:10:11

How Long have You Played Runescape?
6 Year(s)


Are you affilated in anyway with Jagex LTD?
No

Were you Referred to SRL?



What is your general programming knowledge?
None except for what I learned on here.


Are you a member of any other communities?
Yes, Sythe


Tell us about yourself…
From: Ilya
See previous Application.
Not much has changed.



Please show us one (or multiple) of your scripts.
program WizardKiller;
{$i srl/srl/misc/smart.simba}
{$i srl/srl.simba}
{$i SRL/SRL/skill/fighting.simba}

Var
x, y :Integer;
c, T, i : Integer;
foodnumber: integer;

//By Ilya\\
//Start with food in first bank slot\\
//Loots Water Talismans and Fire Talismans\\
//Has a procedure for runes, but its slow\\
//Must have unlocked Varrock and Edgeville Lodestones\\






procedure DeclarePlayers;
begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;
Players[0].Name := '';
Players[0].Pass := '';
Players[0].Nick := '';
Players[0].Active := True;
Players[0].BoxRewards := ['ostume'];
end;

procedure ToEdge;
var
X, Y: integer;

begin;
if GetCurrentTab = (tab_Magic) then
begin
WriteLn('Current tab is the magic tab, correct!')
end else
begin
FTab(tab_Magic);
WriteLn('Changed tab to the magic tab')
end;
MouseBox(562, 217, 585, 240, 1); //HOME TELEPORT
Wait(1000 + Random(500));
MouseBox(272, 136, 311, 175, 1); //EDGEVILLE LODESTONE
Wait(18500 + Random(500));
begin
WriteLn('Got To Edgeville')
end;
end;

procedure ToVarrock;
var
X, Y: integer;

begin;
if GetCurrentTab = (tab_Magic) then
begin
WriteLn('Current tab is the magic tab, correct!')
end else
begin
FTab(tab_Magic);
WriteLn('Changed tab to the magic tab')
end;
MouseBox(562, 217, 585, 240, 1); //HOME TELEPORT
Wait(1000 + Random(500));
MouseBox(337, 169, 354, 182, 1); //Varrock LODESTONE
Wait(18500 + Random(500));
begin
WriteLn('Got To Varrock')
end;
end;


procedure ToBank;
begin
MouseBox(686, 91, 699, 107, 1); //edge step 1
Wait(8000 + Random(500));
MouseBox(677, 105, 692, 121, 1); //edge step 2
Wait(8000 + Random(500));
end;

procedure ToWiz;
begin
MouseBox(674, 97, 688, 124, 1);
Wait(8000 + Random(500));
begin
WriteLn('Got To Wizards')
end;
end;

procedure EndBank;
begin
MouseBox(587, 27, 676, 133, 1);
Wait(808 + Random(127));
begin
WriteLn('Banked!')
end;
end;


procedure AntiRandom;
begin
FindNormalRandoms;
LampSkill := 'attack';
LevelUp;
Writeln('Checking for randoms');
end;

procedure Hungry;
var
c, T, i, x, y: Integer;


begin
if (HPPercent < RandomRange(50, 70)) and LoggedIn then
begin
if not InvEmpty then
for c := 0 to 2 do
for i := 1 to 28 do
if ExistsItem(i) then
begin
MMouseItem(i);
GetMousePos(x, y);
if WaitUptext('Eat', 100) then
begin
Mouse(x, y, 0, 0, false);
if WaitOption('Eat', 100) then
begin
Writeln('Eating.')
t := GetSystemTime;
while ExistsItem(i) and ((GetSystemTime - t) < 2000) do
wait(20);
end;
Exit;
end;
end;
end;
end;

function FindWizard(): Boolean;
begin
if(StrInArr('Dark wizard', ChatBoxTextArray(clMessage)))
then
Wait(RandomRange(1200, 1700));
FindObjCustom(x, y, ['Dark', 'wizard'], [1712417, 7312038, 2305581], 3);
Mouse(x, y, 1, 1, false );
ChooseOption('Attack');
end;


Function RuneFinder(Colors: TIntegerArray; TheUpText: TStringArray; midx, midy: integer): Boolean;
Var
T,i,X,Y: Integer;
TPA: TPointArray;
ATPA: Array of TPointArray;
Begin
MarkTime(T);
Repeat
SetArrayLength(ATPA, Length(Colors));
for i := 0 to High(Colors) do
FindColorsSpiralTolerance(midx, midy, ATPA[i], Colors[i], MSX1, MSY1, MSX2, MSY2, 3);
TPA := MergeATPA(ATPA);
ATPA := TPAtoATPAEx(TPA, 10, 10);
SortATPAFrom(ATPA, Point(MSCX, MSCY));
if (Length(ATPA) = 0) then
Exit;

MiddleTPAEx(ATPA[0], x, y);

if (TimeFromMark(T) > 5000) then
Exit;

MMouse(x, y, 10, 10);
Wait(randomrange(10,15));
If(IsUpTextMultiCustom(TheUpText)) then
begin
ClickMouse2(False);
WaitOption('une', 50);
if DidRedClick then
begin
Result := True;
Break;
end;
end;
Until(Result)
end;



function Loot(): Boolean;
begin

FindObjCustom(x, y, ['ake water', 'ake Fire', 'alisman'], [11486773, 7548451, 8684938, 11555637, 3620789], 3);
Mouse(x, y, 5, 5, false);
ChooseOption('talisman');
Wait(RandomRange(1277, 2121));
end;

function FindBanker(): Boolean;
begin
if(StrInArr('Bank', ChatBoxTextArray(clMessage)))
then
Wait(RandomRange(200, 700));
FindObjCustom(x, y, ['Banker'], [3152673], 3);
Mouse(x, y, 5, 5, false);
ChooseOption('Bank Banker');
end;

Function GetFood : boolean;
begin
Withdraw(0, 0, 20);
wait(777 + Random(77));
end;


Procedure Banking;
begin
wait(7000);
ToBank;
wait(27000);
ToEdge;
ToBank;
Repeat FindBanker;
wait(700 + Random(33));
until BankScreen;
wait(2000 + Random(47));
If Bankscreen Then DepositAll;
Wait(1000);
GetFood;
wait(735);
EndBank;
Wait(300 + Random(33));
ToVarrock;
ToWiz;
end;



begin
Smart_Server := 5;
Smart_Members := True;
Smart_Signed := True;
Smart_SuperDetail := False;

ClearDebug;
SetupSRL;
DeclarePlayers;
LoginPlayer;
SetAngle(SRL_ANGLE_HIGH);
repeat
repeat
FindWizard;
Wait(7000 + Random(753));
until InFight;
FindNormalRandoms;
Hungry;
Loot;
if HPPercent < 45 then Banking;
until(AllPlayersInactive);
end.

Justin

2012-05-22 03:14:31

Sorry, its a no from me.

  • Standards are off
  • You use a lot of "boolean" functions yet never return true or false.
  • Blind clicking. No fail safes
  • EG:

    MouseBox(562, 217, 585, 240, 1); //HOME TELEPORT
    Wait(1000 + Random(500));
    MouseBox(337, 169, 354, 182, 1); //Varrock LODESTONE
    Wait(18500 + Random(500));

They are just some of the reasons why I am voting no at this stage.

Best of luck in the future!

P.S: Took me a few applications to get SRL Member so don't think that you will never get it!

Ilya

2012-05-22 03:20:32

From: [J]ustin
Sorry, its a no from me.

  • Standards are off
  • You use a lot of "boolean" functions yet never return true or false.
  • Blind clicking. No fail safes
  • EG:

    MouseBox(562, 217, 585, 240, 1); //HOME TELEPORT
    Wait(1000 + Random(500));
    MouseBox(337, 169, 354, 182, 1); //Varrock LODESTONE
    Wait(18500 + Random(500));

They are just some of the reasons why I am voting no at this stage.

Best of luck in the future!

P.S: Took me a few applications to get SRL Member so don't think that you will never get it!



Thanks;)
I was just happy to make a script that can bank and run to the 6 hour limit most of the time =)

'Toxin

2012-05-31 08:33:29

Script doesn't look too bad at a first glance, but as Justin said, you're going to need to work on failsafes heavily, seeing as the script depends on the home teleport, yet you're never able to tell if it actually teleported successfully. These are a few small things, that, and your activity around here should be raised up a little bit.

Good luck, unfortunately it is a no from me as well.

John

2012-06-02 08:07:51

It's a no from me, Reading through I realised that you don't use DTM's in any part of the script, They are quick to learn and can be very efficient and helpful if used properly.
Another thing maybe if you added SPS walking as a backup?
Good Luck with your App.

Sin

2012-06-02 09:07:45

From: John
It's a no from me, Reading through I realised that you don't use DTM's in any part of the script, They are quick to learn and can be very efficient and helpful if used properly.
Another thing maybe if you added SPS walking as a backup?
Good Luck with your App.


Hey, you're new here, so try and refrain from voting for a week alright?

[XoL]

2012-06-02 10:21:40

Hey! I saw your post with that script earlier, I use this method (My own script) to make money for my account as well!

Some things I noticed that could possibly improve anti-ban and stability of script.
Try to use the built in Lodestone functions (Very simple to implement and very efficient, this way you don't rely on Mouse Box)

Try DTMs for items it is generally faster FindobjCustom.
I would really implement fail-safes for your walking, I see it can "randomly" get off track just by judging the code so you could set perimeters or a another walking system completely such as SPS (Pretty simple to get going, lots of tutorials check links below)

No from me. Sorry. BUT I think one day you will make a fine member, so once you have made these correction + what other's have said above please re-apply.. I will be looking towards it!

Try to follow this guide to become a SRL member:
http://villavu.com/forum/showthread.php?t=74195

For learning purposes I recommend starting with YoHoJo's video tutorials, informative and they will teach you what you need to know to create a basic/decent script.
http://villavu.com/forum/showthread.php?t=69179

For more advanced scripting I would suggest reading these guides:
http://villavu.com/forum/forumdisplay.php?f=96

Also one thing I really think is important is being community focused, you have 63 posts! Posting actively not only shows you genuinely care for the community it also helps your chances of getting accepted.

These guides can help you with that:
http://villavu.com/forum/showthread.php?t=72050
http://villavu.com/forum/showthread.php?t=66084

Anyway, sorry for the roughness. Good luck.

E: I saw this thread and thought of you :)
http://villavu.com/forum/showthread.php?t=76643

Nava2

2012-06-02 12:20:34

Normally, I would let this close itself, but unfortunately, it will already be a no.

Best of luck in the future,but you will not be accepted this time.