SRL Archive - SRL Bugs

Not sure what causes it specifically but I know others have complained about it and others keep saying it has been fixed.

Somehow you get logged out to the lobby and it spam clicks the online recovery link.

However, I'm always up to date on SRL and have it happen about every other day. After >100 firefox tabs, my laptop crashes.

Putting in a formal thread to discuss.

This has also happened to me twice. Both times I saw it happening soon enough to avoid a computer crash because of too many tabs :P I'm pretty sure it has something to do with breaks.

When did this start happening?

I recall this happening to me 2-3 weeks ago, hundreds of firefox tabs… not fun

Has happened to me, about 2-3times so far.
Sadly I cannot say how it has done that, because it has happened when I wasnt babysitting, which I usually am.

same for me :S its cus the smartclient somehow goes to lobby and the bot runs, and then it opens 100's of tabs and make ur comp crash :S happend to me many times, and then the bot runs, and i am at the lobby , where i can change worlds and friends etc… :S hope this bug can be fixed, pretty annoying opening my laptop and all i see is my net browser with unlimited tabs :S and i cant do a shit!

The script was poorly coded.
It should stop once its not LoggedIn.

Can anyone post the log file that SRL logs in \Includes\SRL\Logs ?
Would help solve the bug

this is very weird, it has happened to me a few times after 6hs the smart manager wouldn't restart and it would take me to recoveries page and log me in their, then it would fool around on the rspage.

Pffft obvious fix is uninstall firefox and getting chrome :)

From: Blakebn2011
Pffft obvious fix is uninstall firefox and getting chrome :)

Then they would have chrome tabs.

From: Shay
The script was poorly coded.
It should stop once its not LoggedIn.

That might be the case if we were all using your scripts.

But let's be serious, I think the problem is in the login procedure.

From: smurg
That might be the case if we were all using your scripts.

But let's be serious, I think the problem is in the login procedure.

Quote of the day:
Never argue with an idiot, they'll drag you down to their level and beat you with experience.

From: Shay
Funny, all my scripts use until not LoggedIn, unlike your 40M Pest Controller :spot:

Not sure if serious, but I employ Login checks in every function/procedure that performs actions and have a login in the MainLoop (I think you should stop speaking). And funny that you disabled rep because you were going into the red.

From: smurg
That might be the case if we were all using your scripts.

But let's be serious, I think the problem is in the login procedure.

Don't think so, I haven't had this problem.. :S

From: [J]ustin
Don't think so, I haven't had this problem.. :S

I haven't experienced it either…hmm

From: ashaman88
I haven't experienced it either…hmm

Could be user-error then

Never happened to me but I think the login procedure could be improved though. For example making sure it knows what it's doing. It's pretty annoying when it starts typing your username and password in the main chat.

There is also a bug with clearing the letters. It doesn't work if your username starts with 'i' or 'I' or 'l' or all of them, not sure.

From: weequ
Never happened to me but I think the login procedure could be improved though. For example making sure it knows what it's doing. It's pretty annoying when it starts typing your username and password in the main chat.

There is also a bug with clearing the letters. It doesn't work if your username starts with 'i' or 'I' or 'l' or all of them, not sure.

Also, if it types it in incorrectly, it will backspace the whole name but leave the first letter many times.

So frustrating to see it re-type my login in wrong.

From: smurg
Also, if it types it in incorrectly, it will backspace the whole name but leave the first letter many times.

So frustrating to see it re-type my login in wrong.

Yh I think that could be fixed by simply increasing the size of the CountColor box. (Move X1 few pixels left)

From: smurg
Also, if it types it in incorrectly, it will backspace the whole name but leave the first letter many times.

So frustrating to see it re-type my login in wrong.

Have you tried to fix this yourself and sending in a pull request?

From: smurg
Not sure if serious, but I employ Login checks in every function/procedure that performs actions and have a login in the MainLoop (I think you should stop speaking). And funny that you disabled rep because you were going into the red.

Bro I script sh*t so focused I break concentration camps.

From: Shay
The script was poorly coded.
It should stop once its not LoggedIn.

False. Yes it should, but it doesn't sometimes. I can confirm :)


~Home

I saw this happen a few months ago, and iirc, Coh3n put a fix in. It hasn't happened since.

From: Kyle Undefined
I saw this happen a few months ago, and iirc, Coh3n put a fix in. It hasn't happened since.

Was the issue inside the login procedure? What function was doing the clicking on the link?

Because as seen in the thread, people have still been having issues with it.

I believe so, but it only happened once for me. It hasn't happened to me, personally, since Coh3n pushed the fix.

From: smurg

Because as seen in the thread, people have still been having issues with it.

No one > Registered User though, and I can't even begin to say how many "MSI Bugs" actually don't exist. Simple registered users not knowing what they're doing and blaming someone else's code.

I'm not saying that's what you're doing, but I do remember this bug before Coh3n fixed it and it occurred quite often (couple times a week for most). However, I haven't heard of it since, nor have I had any problems, and I just tested the Login procedure quite extensively when adding support for the unregistered email screen the other day.

this happens every 5-6 hours for me

Happened again.

Welcome to Runescape.

Than spam click recoveries.

I can't reproduce this, at all. Could you add some WriteLn's to the Login method and post what it's doing?

I experienced this multiple times but I realized I just poorely scripted my script :p missed a few checks.

Well it happens in the loggedin function for me. I'll try to debug it.

I find it usually happens on a disconnect.

This issue is still yet to happen to me

I am working on fixing this, or at least finding the cause. I'll report back in a few….

Edit1: Ok, the line that opens up the recovery question tab in the lobby is in the function loginplayertolobby

edit2: Has to do with this piece of code:

  if (not pointInBox(p, intToBox(Boxes[0], Boxes[1], Boxes[2], Boxes[3]))) then
    p := point(UBX2 - (10 + random(10)), p.y);
  Mouse(p.x, p.y, 5, 5, mouse_left);
end else
  MouseBox(Boxes[0], Boxes[1], Boxes[2], Boxes[3], mouse_left);

Edit3: On my test character, if I open up the email tab (yes I am registered to an email) it spams click to recovery. And the call to click is done by the first Mouse procedure in the snipplet of code above.

Edit4: What I've noticed is that I get the one minute has passed message, then if my email tab is open, the script decides to spam click.

My guess is that it thinks I'm logged out and decides to type in the username again or erase the username again…

Edit5: Yup, it reports that I am not loggedin (loggedin = false) and lobbyscreen reports false

I'm done my psychoanalysis for the day. I'll leave you behavior-moders to works backwords and do your thing.

And my graphics settigns are correct.

Edit6: Turns out im not done. I just want to report that getlobbytab reports -1……

Edit: noone interested?

Edit: I can recreate

Thread should be reviewed once again with the information Yago has posted.

Double post I know but I have some more information on this.

While running one of my scripts, it tried to log in my character, Somewhere in login.simba or whatever (where it switches to the 'World' tab) failed. It was on the Main screen and was giving me a false-positive over this

777: Actions := ['Login limit exceeded.',             20000,   10,    '',              'Waiting for login.'];

^^ found in login.simba
I think the detection method might need a revamp.

From: [J]ustin
Double post I know but I have some more information on this.

While running one of my scripts, it tried to log in my character, Somewhere in login.simba or whatever (where it switches to the 'World' tab) failed. It was on the Main screen and was giving me a false-positive over this

777: Actions := ['Login limit exceeded.',             20000,   10,    '',              'Waiting for login.'];

^^ found in login.simba
I think the detection method might need a revamp.

You are on about logging in a second player in right ? And the second script will try and log in the second char to the same world as the first char in the first script ? I have had no problems with this. If I try and do that it goes back to world select and selects a new world and logs in. I've not had it fail on me yet but I have only done that like 3 or 4 times in the past few months.

From: Jakkle
You are on about logging in a second player in right ? And the second script will try and log in the second char to the same world as the first char in the first script ? I have had no problems with this. If I try and do that it goes back to world select and selects a new world and logs in. I've not had it fail on me yet but I have only done that like 3 or 4 times in the past few months.

Yeah, logging into the same world, I think I figured it out, I have changed a wait value from 100 + random(50) to 800 + random(50) (the wait after you hit 'enter' on the password box) for it to start counting colours for the login error(s). I will give it more testing today and if that is a fix, I sill submit a pull request.

I've had it happen several times, and every single time I was babysitting. It would open up the lobby, and try to select a world, but the world select tab would not open, then it would click where the worlds should be and that is a link to set recoveries.

Funny thing is, as soon as I disable smart, it would jump straight to the select worlds tab. I think it maybe a smart 7.2 error.

From: Ivo09
I've had it happen several times, and every single time I was babysitting. It would open up the lobby, and try to select a world, but the world select tab would not open, then it would click where the worlds should be and that is a link to set recoveries.

Funny thing is, as soon as I disable smart, it would jump straight to the select worlds tab. I think it maybe a smart 7.2 error.

When you disable SMART, it replicates an alt+tab to regain focus to the rsclient. That is why it switches to the world tab

Edit: https://github.com/SRL/SRL-5/pull/83/files