SRL Archive - Archive

After further consideration, I am still going to withdraw my application (mod can close this). I know that a bunch of registered users here idolize all of the SRL members and I want to show them you can learn to script and still have just as good scripts without becoming a SRL member. I DO NOT want to deter anyone from becoming a SRL Member but I do want them to see it is not the end all, be all. I still think what I have posted below should be considered. Thanks again to everyone who voted and took the time to comment (Also, I could be way off base with how SRL members are viewed. Maybe they are not idolized and I have just formed a faulty perception in my head. If that is the case then I am quite sorry).

I am obviously not a SRL member, but has it been considered that it should be highly encouraged that if you vote no, then you should try and at least post a sentence as to why? I think it would be really beneficial for whomever is applying. Even if it is something like "I voted no because lack of activity" or "I voted no because you need to learn other walking methods". I think it would really help the applicant to know what he/she needs to work on and give them a goal to pursue. Just a thought!

Took my advice and applied I see ;). Also pretty good work with standards it's nice and readable, I like your attitude, activity is lacking but your script is good. Yes from me

From: Gucci
Took my advice and applied I see ;). Also pretty good work with standards it's nice and readable, I like your attitude, activity is lacking but your script is good. Yes from me

Thanks for the comments. I have been working on getting my activity up over the past few weeks!

Edit - People are just knocking down the door to vote it appears!

For me, longevity and activity is fine.

I'm a bit confused as to why you've done this:

Procedure CheckFight;
Begin
  If InFight Then
  Begin
    Writeln('Checking for fight....');
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow Else Writeln('No fight detected. Back to fishing!');
  End;
End;

Could you not have done a repeat..until loop? Something like:

Procedure CheckFight;
var
  Checked: Integer;  // make a variable called checked
Begin
  If InFight Then
  begin
    Writeln('Checking for fight....');
     repeat
      Inc(Checked); // increases 'checked' by 1
      if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
      begin
        RunAwayNow;
        Break; // stops it from repeating the check again
      end;
      Wait(250);
    until (Checked = 7); //checks upto 7 times
  End;
End; 

You have used DTM's correctly, that's a plus. Also, you have walking which is good. However, try using backup walking methods such as RadialWalk in case your walking method fails.

I see you've used TPA's, but only via ACA with the exception of one function. You need to work on creating more of your own TPA functions to show you really understand how to use advanced functions.


So your community work is fine and your scripting is of good level - but just not good enough for me.

Holding my vote for now.

From: abu_jwka
For me, longevity and activity is fine.

I'm a bit confused as to why you've done this:

Procedure CheckFight;
Begin
  If InFight Then
  Begin
    Writeln('Checking for fight....');
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow;
    Wait(250);
    if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
    RunAwayNow Else Writeln('No fight detected. Back to fishing!');
  End;
End;

Could you not have done a repeat..until loop? Something like:

Procedure CheckFight;
var
  Checked: Integer;  // make a variable called checked
Begin
  If InFight Then
  begin
    Writeln('Checking for fight....');
     repeat
      Inc(Checked); // increases 'checked' by 1
      if(FindDTM(FShield, x, y, MSX1, MSY1, MSX2, MSY2) Or FindDTM(FDamage, x, y, MSX1, MSY1, MSX2, MSY2)) Then
      begin
        RunAwayNow;
        Break; // stops it from repeating the check again
      end;
      Wait(250);
    until (Checked = 7); //checks upto 7 times
  End;
End; 

You have used DTM's correctly, that's a plus. Also, you have walking which is good. However, try using backup walking methods such as RadialWalk in case your walking method fails.

I see you've used TPA's, but only via ACA with the exception of one function. You need to work on creating more of your own TPA functions to show you really understand how to use advanced functions.

Thanks for the input. That was actually the very first script I wrote and I was learning the whole way. I put some more scripts in the original post so you, and others, can see that I have fine tuned some of the things you listed and I put in my original script.

Edit that post and put those scripts into your app, then I'll go over them :)

What tutorials have you looked at? It seems like you do the same thing as Sin. You pass X, Y variables through the function and never use them (it looks like you mean to make them an output, but you miss the 'var').

Then you use a clickmouse2 anyways and avoid the X, Y (FindPulley).

Also, standards are a bit off and weird spacing scheme. Other than that, seems like there's a few issues with the flow of the script (you call ToFishing inside your bank procedure?), but looks alright.

From: smurg
What tutorials have you looked at? It seems like you do the same thing as Sin. You pass X, Y variables through the function and never use them (it looks like you mean to make them an output, but you miss the 'var').

Then you use a clickmouse2 anyways and avoid the X, Y (FindPulley).

Also, standards are a bit off and weird spacing scheme. Other than that, seems like there's a few issues with the flow of the script (you call ToFishing inside your bank procedure?), but looks alright.

I see what you mean about the x, y in the FindPulley procedure. Not really sure where I picked that up but I seem to do it a lot. I'm not sure that I am concerned with the "flow" so to speak. I call ToFishing there so if there are no fish to bank then it immediately goes back to the fishing spots. I can see how that could be "bad flow" but it works in the most rapid manner and allows me to maximize the fish per hour in the 6 hours the script runs.

Thanks for the comments!

From: abu_jwka
Edit that post and put those scripts into your app, then I'll go over them :)

I added 3 more of my scripts to the original post. If you need to see more I still got 5 or so more to post!

I am obviously not a SRL member, but has it been considered that it should be highly encouraged that if you vote no, then you should try and at least post a sentence as to why? I think it would be really beneficial for whomever is applying. Even if it is something like "I voted no because lack of activity" or "I voted no because you need to learn other walking methods". I think it would really help the applicant to know what he/she needs to work on, and give them a goal to pursue, rather than just demotivating him/her and lose out on a potential involved community member. Just a thought!

I would kindly ask that you keep your application up for the duration of the process. You will find that things can look grim to begin with, and swing in your favor at the end…

Why'd you take it off :(

From: EtherFreak
I would kindly ask that you keep your application up for the duration of the process. You will find that things can look grim to begin with, and swing in your favor at the end…

I'll look into re-upping it when I get off.

From: Shay
Why'd you take it off :(

Frustration online, real life, and just about everywhere else today haha.

Come on man re-up it your app only has a total of 7 votes so there's a lot of people who could vote still. Might end up turning in your favour

From: Gucci
Come on man re-up it your app only has a total of 7 votes so there's a lot of people who could vote still. Might end up turning in your favour

I think you got this in before I was finished editing my original post. Read it real quick, and I think it will clear things up. It has more to do with what I stated in there than the fact the votes are not in my favor at this time.

From: alevere4
I think you got this in before I was finished editing my original post. Read it real quick, and I think it will clear things up. It has more to do with what I stated in there than the fact the votes are not in my favor at this time.

Ah I just did, still you might as well see if you make members as I feel you'd would be a great addition

I voted no because your scripts were too simplistic IMO.

From: cause
I voted no because your scripts were too simplistic IMO.

Appreciate you taking the time to let me know!

Had voted yes b/c lrc can suck to script for and you have been way more involved in the community as of late.

From: ashaman88
Had voted yes b/c lrc can suck to script for and you have been way more involved in the community as of late.

Thanks. Had been working on that.

From: alevere4
After further consideration, I am still going to withdraw my application (mod can close this).

From: alevere4
I still think what I have posted below should be considered.

You contradict yourself a lot.. Holding my vote for now (I guess?). :confused:

voted no because there is no script in your application.
voted no because your general attitude in this thread isn't very good.

From: footballjds
voted no because there is no script in your application.
voted no because your general attitude in this thread isn't very good.

I think he is withdrawing and so no vote needed ;)

From: tehq
You contradict yourself a lot.. Holding my vote for now (I guess?). :confused:

What I meant to be considered was this:

I am obviously not a SRL member, but has it been considered that it should be highly encouraged that if you vote no, then you should try and at least post a sentence as to why? I think it would be really beneficial for whomever is applying. Even if it is something like "I voted no because lack of activity" or "I voted no because you need to learn other walking methods". I think it would really help the applicant to know what he/she needs to work on and give them a goal to pursue. Just a thought!

I believe you misunderstood.

From: footballjds
voted no because there is no script in your application.
voted no because your general attitude in this thread isn't very good.

I honestly think I have been very mature and I have made sure to say everything in the best manner that I could. If you have interpreted that as a bad attitude then I am sorry.

From: [S]paz
I think he is withdrawing and so no vote needed ;)

Exactly. A mod is welcome to close this.

From: alevere4
What I meant to be considered was this:

I am obviously not a SRL member, but has it been considered that it should be highly encouraged that if you vote no, then you should try and at least post a sentence as to why? I think it would be really beneficial for whomever is applying. Even if it is something like "I voted no because lack of activity" or "I voted no because you need to learn other walking methods". I think it would really help the applicant to know what he/she needs to work on and give them a goal to pursue. Just a thought!

I believe you misunderstood.



I honestly think I have been very mature and I have made sure to say everything in the best manner that I could. If you have interpreted that as a bad attitude then I am sorry.



Exactly. A mod is welcome to close this.

That sucks. Life's been keeping you busy?

I was about to vote yes, saw you removed your app, voted no.

I understand your reasons, but you should've thought of these things before applying. Also, the fact that the app was not going in your favour was clearly a factor as to why you made this decision.

You cannot say you would've to closed the app if you had 12 - 0 votes in your favour now would you?

Think before applying.



Good luck making scripts to prove that point of yours :)

From: abu_jwka
I was about to vote yes, saw you removed your app, voted no.

I understand your reasons, but you should've thought of these things before applying. Also, the fact that the app was not going in your favour was clearly a factor as to why you made this decision.

You cannot say you would've to closed the app if you had 12 - 0 votes in your favour now would you?

Think before applying.



Good luck making scripts to prove that point of yours :)

I didn't say that it going against me didn't factor in cause it did make me think about whether I really wanted to be a member. But at the same time, why didn't I withdraw my app last time when it was 6 to 1 or 11 to 2. That shows the voting is clearly not my main motivator. I withdrew this app at 3-2. I would hardly say members was a for sure no.

But anyways, I appreciate the luck ;)

Closing due to withdrawal.