SRL Archive - SRL Suggestions

Release Includes that Compile


smurg

2012-05-19 21:09:47

One of the newer SRL updates included certer.simba and it didn't compile.

Had a few people complain to me about my script not working for them.

Sin

2012-05-19 21:26:35

Mistakes happen, pardon the devs for overlooking one small detail, because of course, they're getting paid for this and have no life outside of SRL

Narcle

2012-05-19 21:30:22

Thanks Sin.

It happens and lesson learned for the Dev that did it :p.

NCDS

2012-05-19 22:06:33

Note to self and everyone else; don't merge pull requests via gitHub.

Note to smurg; You could have easily 'fixed' it and sent a pull request, rather than complain about it ~10 hours after it was fixed(was an extra semicolon on a request from a member..). That is the point of SRL being hosted on gitHub, after all.

Kyle Undefined

2012-05-19 22:26:33

I remember when I broke MSI awhile back D:

It happens, it was fixed, it's all good :)

smurg

2012-05-20 03:55:23

I'm not trying to dog on anyone, I just think there should be some procedural steps taken before releases. Testing in some way, compiling the code, etc.

Going to ignore the obvious flamebait by Sin.

Justin

2012-05-20 05:53:53

From: smurg
I'm not trying to dog on anyone, I just think there should be some procedural steps taken before releases. Testing in some way, compiling the code, etc.

Going to ignore the obvious flamebait by Sin.


Like almost everyone in this thread has said, mistakes happen, some things are overlooked. SRL was down for like what.. 6 hours? and even then it was a simple fix as most people have already pointed out.

Home

2012-05-20 06:12:53

From: [J]ustin
Like almost everyone in this thread has said, mistakes happen, some things are overlooked. SRL was down for like what.. 6 hours? and even then it was a simple fix as most people have already pointed out.


As for my self. I fixed it in 10 Secs, and pushed updated certer.simba to customers :) But I can understand Smurg side too. But we are all humans (Or are you Kyle ;)) :)

~Home

NCDS

2012-05-20 08:11:14

From: smurg
I'm not trying to dog on anyone, I just think there should be some procedural steps taken before releases. Testing in some way, compiling the code, etc.

Going to ignore the obvious flamebait by Sin.


There are steps taken. I always compile and test my code before committing. I was told the code in question (all 5? lines) had been tested prior to the pull request being sent. However, this was clearly not the case.

Justin

2012-05-20 08:16:13

From: NCDS
There are steps taken. I always compile and test my code before committing. I was told the code in question (all 5? lines) had been tested prior to the pull request being sent. However, this was clearly not the case.


I must of hit Ctrl-Z by accident instead of Ctrl-S just as I sent the request in. Not everyone is perfect. After all, we are only human.