HardRawks
2012-05-18 23:06:59
I had a problem with the MSI Container Filler, in particular the Jug Filler. It would not be able to find Jugs.
So I changed the script to give the DTM coordinates of the jug of water, figuring the images were the same except the water color in the jug. So i tested it and it would find the jug and the jug of water as the same item. then Tootoot222 on the IRC helped and said the Jug was 1 pixel "taller" than Jug of Water. so I found DTMs of both the Jug and Jug of water, found the new colors, and I'm posting the code changes below and a progress report.
anyways, the cat's on the roof, so here's where it stands, The reason the progress report gave to why it failed was wrong ( I had items left), and I think it failed because of something to do with finding the options, or finding the uptext in the bank screen after right clicking. Consider the bugfix a gift from me, and it definitely needs testing. Maybe other items recently need similar DTM changes? This skewing of the sprites to be 1 pixel taller/shorter is annoying. :fiery:
So I changed the script to give the DTM coordinates of the jug of water, figuring the images were the same except the water color in the jug. So i tested it and it would find the jug and the jug of water as the same item. then Tootoot222 on the IRC helped and said the Jug was 1 pixel "taller" than Jug of Water. so I found DTMs of both the Jug and Jug of water, found the new colors, and I'm posting the code changes below and a progress report.
anyways, the cat's on the roof, so here's where it stands, The reason the progress report gave to why it failed was wrong ( I had items left), and I think it failed because of something to do with finding the options, or finding the uptext in the bank screen after right clicking. Consider the bugfix a gift from me, and it definitely needs testing. Maybe other items recently need similar DTM changes? This skewing of the sprites to be 1 pixel taller/shorter is annoying. :fiery:
//<-- line 323
JUG_WATER:
Result := [
Point(19, 11),
Point(24, 16),
Point(29, 16),
Point(12, 31),
Point(5, 25)
];
JUG_EMPTY:
Result := [
Point(20, 13),
Point(25, 18),
Point(30, 18),
Point(14, 33),
Point(6, 27)
];
//<-- line 504
JUG_WATER : Result := 12479594;
|====================================|
| ~ SRL ~ |
| Randoms Report |
|────────────────────────────────────|
| |
| |
|────────────────────────────────────|
|====================================|
{----------------------------------------------------------------}
{ MSI Phoenix Short Report }
{----------------------------------------------------------------}
{ Time Running: 27 Minutes and 30 Seconds }
{----------------------------------------------------------------}
{ }
{ Totals: }
{ - Players: 1 }
{ - Player Time: 20m 34s }
{ - Loads: 14 }
{ - Containers Filled: 383 }
{ }
{----------------------------------------------------------------}
{----------------------------------------------------------------}
{----------------------------------------------------------------}
{ MSI Phoenix Player Report }
{----------------------------------------------------------------}
{ Time Running: 27 Minutes and 30 Seconds }
{----------------------------------------------------------------}
{ }
{ Player 0: }
{ Location: Varrock East Bank }
{ Time: 20m 34s }
{ Active: False }
{ Reason: Ran out of supplies }
{ }
{ Script: Varrock East Container Filler }
{ Time: 20m 34s }
{ Loads: 14 }
{ Item: Jug of water }
{ Amount: 383 }
{ }
{----------------------------------------------------------------}
{----------------------------------------------------------------}
[0:27:37]: [ ] ------ All players inactive
[0:27:37]: Thank-you for using MSI Phoenix scripts!
[0:27:37]: Successfully executed.