SRL Archive - Development

There is a very weird issue with DTM validation in Simba 0.99, so I finally decided to investigate. I found the issue lied within uncompress() in the DTM function, which seemed to be a FPC function. So why does it fail on one Simba commit but not on the other?

I decided to use git-bisect:

merlijn@merlijn-desktop ~/Programs/simba $ git bisect start
merlijn@merlijn-desktop ~/Programs/simba $ git bisect good simba-0.98.4
merlijn@merlijn-desktop ~/Programs/simba $ git bisect bad simba-0.99-rc1
Bisecting: a merge base must be tested
merlijn@merlijn-desktop ~/Programs/simba $ git bisect bad
Bisecting: a merge base must be tested
[d6797da850b831f0ce4ca444f4e2dcbfe919c2cb] Some documentation changes.
merlijn@merlijn-desktop ~/Programs/simba $ git bisect good
Bisecting: 78 revisions left to test after this (roughly 6 steps)
[e3c75eb4849ebc7483553fb9f2026f2ba15f38e2] New 'y' Upchar by TRiLeZ.
merlijn@merlijn-desktop ~/Programs/simba $ git bisect bad
Bisecting: 38 revisions left to test after this (roughly 5 steps)
[addc7abc995c5e4adba762d7c653a7c1a903cb3e] Simba: Use XDG_* for DocPath.
merlijn@merlijn-desktop ~/Programs/simba $ git bisect good
Bisecting: 19 revisions left to test after this (roughly 4 steps)
[379fdb79fa785f756e47a187ea960b62a50a1224] Fix FindDeformedBitmapToleranceIn.
merlijn@merlijn-desktop ~/Programs/simba $ git bisect bad
Bisecting: 9 revisions left to test after this (roughly 3 steps)
[70be99316c16309e22c86a0405604d4e7a5ca21f] Bump installer version to 0.99.
merlijn@merlijn-desktop ~/Programs/simba $ git bisect bad
Bisecting: 3 revisions left to test after this (roughly 2 steps)
[58eadd650a96f1978dc86be64820034840686d5b] Merge pull request #59 from Dgby714/crypto
merlijn@merlijn-desktop ~/Programs/simba $ git bisect bad
Bisecting: 2 revisions left to test after this (roughly 1 step)
[bfd5593448e3e2c139a4e2aba580fe4b932ad9ee] Merge pull request #58 from Dgby714/crypto
merlijn@merlijn-desktop ~/Programs/simba $ git bisect good
Bisecting: 1 revision left to test after this (roughly 1 step)
[cfe7451ec1648436bcc59b5e783cd38adb10a239] Merge pull request #57 from Dgby714/Settings
merlijn@merlijn-desktop ~/Programs/simba $ git bisect good
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[13ae596527465488171af00fe78bc75c6034459e] Simba: Removed dcpbase64 from a file that didn't need it.
merlijn@merlijn-desktop ~/Programs/simba $ git bisect reset
M	Units/lape
Previous HEAD position was 13ae596... Simba: Removed dcpbase64 from a file that didn't need it.
HEAD is now at f70787d... Add Path setting.

Voila. The commit that introduced the bug: https://github.com/MerlijnWajer/Simba/commit/13ae596527465488171af00fe78bc75c6034459e

To be honest, I am still quite puzzled as to WHY this introduces a bug. But I think I'm on the right track now. Hooray for git.

Ah, one step closer to solving this bug! Good work :).

Got it… https://github.com/MerlijnWajer/Simba/commit/a2a923727820d96251337438e0343847936dcc74

I'll wait for the autobuild to do its work, but it's working for me now.

Feel free to test: http://nala.villavu.com/downloads/master/a2a923727820d96251337438e0343847936dcc74/

( No Linux build because Nielsie has to push a lape patch ;) )