SRL Archive - Help

I have only one script out public so far. The lunar planker in my sig.

It has a ton of features, listed on the thread, and walking if it isn't where it should be. Walking is'nt working fully right now, so it only walks if you are near where it should be.

I've been a member for a few months now, and have 2 scripts partially completed:

My ess miner and air orb runner

I cant release the runner till I'm member or it will be farmed though.

I understand TPAs, ATPAs, Walking with SPS,ObjectDTM, and radial walk, and I've been scripting for years now.

So, the question is, would you vote for me?

I would like to know if I'm even near SRL Members standards. I've read the Threads on what it takes to become a member.

I'd learn to walk with ddtm too, they love it.

Aint too hard to learn too.. It's almost like DTM, well in fact it is but there's small difference.

Read about them for a good 20 min, try them and in less than an hour you can say you know how to use DDTM walking - tee hee.

Activity and willingness is what i usually vote for.
Maybe use the orb runner along with the planker to apply with, then only srl members+ can see it. Although, these days it doesnt mean it wont get abused

I was thinking that, but It isn't finished. Walking is half done.


And DDTM is a good idea =D

What threw me off was this:

From: m34tcode
and I've been scripting for years now.

Join Date: 12-18-2011.

Elaborate please.

Im also g0tp0t

I started in 6th grade, and that got me into programming

I moved from srl, and did more programming than anything else

and came back.

Decided a new name was appropriate lol

So Iv been using scar/simba for almost 7 years

I would vote yes if you would change a few things in your script that show you understand standards and basic script logic, a few things being:

Do not use global variables as much as possible. You should really only use them for progress reports. For anything else you should just use local variables.

Constants should be fully capitalized. IE: DEBUG or STATS_USER.

You, honestly, shouldn't use a procedure to declare all of your DTMs. It looks ugly and it is inefficient in my eyes. Why do that when you can just call the DTMs each function when you use local variables instead? It also makes freeing easier and cleaner when viewed.

This isn't required but it's good to get in to the habit of it: Instead of using ChooseOption or IsUpText, etc., Use 'WaitOption' or 'WaitUpText'. This will allow for lag tolerance in your scripts. It will wait until the option or uptext actually appears before it 'Time outs' and results in false. If it finds the option or uptext, it will choose the option or just result true depending on which you are using.


You use static wait times in places. One of them being:

while not (BankScreen or PinScreen) and (TimeFromMark(postBankClick) < 5000) do

Why? This should be a random range: RandomRange(5000, 6000). This will be safer and it's good to get in to the habit of it.


You shouldn't reuse variables for more than one thing. If you use one variable to count time at one spot, you should use another for another spot. It will make it easier to manage and it looks cleaner.

You should also not have a set boolean for entering the bank pin of the player. What happens when it finds a mod, logs out and then logs back in? From what I understand, your script will pin not enter the pin again if the pin has already been entered before. Or did I simply misunderstand that?

while not (GetCurrentTab = tab_Magic) and (TimeFromMark(T) < 7000) do
  begin
    wait(150+random(150));
  end;

Why do you have this like when your previous ones that did the same thing almost with just different if's were proper? You shouldn't have a begin .. end if it just does one thing.



I think you have a great chance of being accepted though if you'd fix the things I mentioned. Others may have different options though, of course.


Good luck!

From: m34tcode
Im also g0tp0t

I started in 6th grade, and that got me into programming

I moved from srl, and did more programming than anything else

and came back.

Decided a new name was appropriate lol

So Iv been using scar/simba for almost 7 years

Ah! knew you had a good explanation :), you have a good attitude around here, apply Mate… Worse that could happen is that you have to wait a month to reapply, although if you do know whatever you have stated than go for it and please apply.

Good Luck!
-Cheers

I always add a begin..end first, then remove if unnecessary.

I try keeping in that habit so my levels of code always remain clear.

As for DTMs being local, I do area, but since iv seen many other people declare them in a specific procedure, I figured I'd have a better chance here.

And thank you for your analyses(not sure of the word there)

That was wicked in depth =]

From: RISK
You use static wait times in places. One of them being:

while not (BankScreen or PinScreen) and (TimeFromMark(postBankClick) < 5000) do

Why? This should be a random range: RandomRange(5000, 6000). This will be safer and it's good to get in to the habit of it.

I do not agree with this one… In this case it isn't needed imo. The wait(100+random(50)) should add the randomness. I suggest using wait(100+random(200)) though.