SRL Archive - Archive

How Long have You Played Runescape?
10 Year(s)


Are you affilated in anyway with Jagex LTD?
No

Were you Referred to SRL?



What is your general programming knowledge?
I have alot of experience with java c++ and have made several rsps's (runescape private servers) and intend on learning how simba works and how to write complicated scripts


Are you a member of any other communities?
Runelocus, moparscape, rune-server


Tell us about yourself…

From: fatmess
I am 18 years old, i have been learning all the basic java skills since the age of 12, i live in the united kingdom and have a passion for botting,creating servers and also learning new things, i have played runescape since 2005 and not stopped playing since, i know how alot of bots work (epicbot,rsbot) and have benefited from it alot (pking green dragon bots) (killing chin hunting bots)

Please show us one (or multiple) of your scripts.

This is my first script i have worked on so far, but i have picked up the coding aspect of script making fairly quickly (going to start on walking and gui's next)

[url]http://villavu.com/forum/showthread.php?p=971061#post971061[/url]

Before I continue, it's probably a good idea to paste your entire script so we can read it through the code snippet there.

First I'm going to go on some things I notice before I even look at the script.

Community Activity

You have 7 posts, and you've been here a month. Show some care for the site if you want to be a member. It's a bigger deal now that our community is growing (and we have more members+ scripts), so activity is important. We have to know that you aren't going to just leech.

Script

Things I'm seeing:

Standards

For the most part, standards look pretty good, but there are some odd parts:

procedure ChopIvy;
var x, y: integer;
begin
    if FindObj(x, y, 'hop', 1785912, 35) then //incorrect. this should be 2 spaces in front of begin.
  Mouse(x, y, 0, 0, false); //first off, there should be a begin before this. second, this should be four spaces ahead
  ChooseOption('hop'); //two more spaces ahead
  repeat //same as above
  FindNormalRandoms //two spaces above the repeat
    Wait(30000+random(250)); //two spaces above the repeat
  Until not IsUpText('ew') or (InvFull); //same as repeat
end;  

I'll go ahead and show you how to fix it.

procedure ChopIvy;
var x, y: integer;
begin
  if FindObj(x, y, 'hop', 1785912, 35) then
  begin
    Mouse(x, y, 0, 0, false); 
    ChooseOption('hop'); 
    repeat 
      FindNormalRandoms 
      Wait(30000+random(250)); 
    Until not IsUpText('ew') or (InvFull); 
  end; 
end; 

So… just watch out for standards. Look through some other scripts and this will come naturally.

Antiban

You have it, which is awesome. Everything looks good on this front. I really like the methods you use, and Antiban shouldn't be ignored. Also, you handle randoms at almost every point in the script, which is good.

Finding Methods

Here's where I'm worried. FindObj is just… not very good. It frantically moves around the screen with your mouse pointer rolling over anything with a tol 35 around 1785912. That's not good.

There's tutorials around on how to use advanced TPA functions so you can make your finding more accurate. Look around the tutorial section.

SMART Incorporation

Yeah, you should probably incorporate SMART. Everyone uses it. There's tutorials, just check around.

Script Continuance

Or lack thereof… All it does is chop one inventory of Ivy. You should show that you can create a script that walks and banks or drops the Ivy.

Also under this:

repeat
  FindNormalRandoms
    Wait(30000+random(250));
  Until not IsUpText('ew') or (InvFull); 

Notice the last line. This will stop when it chops down one tree. This is not a continuous script at all.

Also, add SOME sort of walking so we know you know what you're doing.


DTM/Bitmap

You need some DTM/Bitmaps to demonstrate your knowledge of their use. Try getting a DTM of the Ivy logs so you can count them in your inventory.

Areas to Improve

Ultimately:

• Add DTM/Bitmaps.
• Add Walking
• Fix Standards
• Improve Finding Methods
• Continue the Script. Make it drop the ivy so the script can continue past one inventory…
• Add Multiplayer
• Add SMART
• Be more active

If you do all these things, you will undoubtedly get a yes vote from me next time. But for now, my vote is a no. Sorry, and good luck.

Hey, I'm sorry but it looks like you aren't getting in this time. I'm going to close this so you can reapply in 2 weeks. Good luck!