Looks good, but you might want to add some regularity to your scripts. Some times you have things like
if FindNPCChatText('kebab', nothing)then
And some times you have it like this;
if FindNPCChatText('please', nothing) then
So you might want to add a space to the first example.
Also for this part
if FindColorTolerance(X, Y,14340569,MSX1, MSY1, MSX2, MSY2, 2)then
–>
if FindColorTolerance(X, Y, 14340569, MSX1, MSY1, MSX2, MSY2, 2) then
It's always good to start off with getting all the standards 100% right :) Atleast, that's what I did and it's easy to find specific parts in my scripts now :P
Overall it looks pretty good!
Oh yeah, you might want to look into using Cases. It's something that I enjoy doing to add randomness.
An example from one of my scripts. This withdraw the required items on a couple different ways to add extra randomness and to look more like a human that switches things up sometimes!
case random(36) of
0..9: begin;
Withdraw(2, 0, 5);
Withdraw(2, 0, 9);
Withdraw(3, 0, 5);
Withdraw(3, 0, 9);
end;
10..19: begin;
Withdraw(2, 0, 9);
Withdraw(2, 0, 5);
Withdraw(3, 0, 9);
Withdraw(3, 0, 5);
end;
20..23: begin;
Withdraw(3, 0, 5);
Withdraw(3, 0, 9);
Withdraw(2, 0, 5);
Withdraw(2, 0, 9);
end;
24..27: begin;
Withdraw(3, 0, 9);
Withdraw(3, 0, 5);
Withdraw(2, 0, 9);
Withdraw(2, 0, 5);
end;
28..29: begin;
Withdraw(2, 0, 9);
Withdraw(2, 0, 5);
Withdraw(3, 0, 5);
Withdraw(3, 0, 9);
end;
30..31: begin;
Withdraw(3, 0, 9);
Withdraw(3, 0, 5);
Withdraw(2, 0, 5);
Withdraw(2, 0, 9);
end;
32: begin;
Withdraw(3, 0, 9);
Withdraw(2, 0, 5);
Withdraw(3, 0, 5);
Withdraw(2, 0, 9);
end;
33: begin;
Withdraw(3, 0, 5);
Withdraw(2, 0, 9);
Withdraw(3, 0, 9);
Withdraw(2, 0, 5);
end;
34: begin;
Withdraw(3, 0, 5);
Withdraw(2, 0, 9);
Withdraw(3, 0, 5);
Withdraw(2, 0, 5);
end;
35: begin;
Withdraw(3, 0, 9);
Withdraw(2, 0, 9);
Withdraw(3, 0, 5);
Withdraw(2, 0, 5);
end;
36: begin;
Withdraw(3, 0, 5);
Withdraw(2, 0, 5);
Withdraw(3, 0, 9);
Withdraw(2, 0, 9);
end;
end;
I'm currently trying to figure out how to shorten this code and how to let Simba calculate all the possibilities. I can probably achieve that by using multiple arrays or something, but that's another story.
Good luck!
