SRL Archive - RS3 Outdated / Broken Scripts

Thank you very much for this. It's a quite boring task.

I have one question, you put 210xp in your script, is there any staff that gives that much xp or was it just a random number ? :-)

I'm making 137,5xp with airs, 27k of them banked. Once i'm 99 cons I'll let your script rip.

I just googgled a value for airs, remember the coordinate for the make button might need to be edited

Hi Gucci,

For me it doesn't work, I've changed the coords at line 95 - removed the compiling error.

Script opens bank, takes out the orb & battlestaffs. Once it has done that it must somehow right click in the chat cos the add friend interface comes up. You see the red mouse dot hovering over the make battlestaff button but instead of clicking it, it opens the bank again to take out stuff, gets stuck in that loop.

Hope you understand what I'm seeing.

Is your coord –> Mouse(xcoord, ycoor, 0, 0, True);? And I'll make a DTM for it today expect an update soon

Mouse(253, 427, 0, 0, True);

This is my line 95, I didn't change the 1, 1 to 0, 0 at first but it makes no difference. In the mean time I'll try it on another computer. For some reasons sometimes a script works ons laptop and not on pc or visa versa.

btw, the compiling error was my own fault, i put 137.5 xp , 137xp solved the problem hehe

Yeah no decimals allowed and I'll do the update when I get home from work

Looking forward to the update :) Thanks for your quick answers.

lol you released it after, nice

Alright updated give it a shot now :D

I'm sorry to disappoint you but it has the same problem as your previous version. It withdraws 14 orbs & 14 battlestaffs, uses the orb on the staff, the make battlestaffs option pops up in the chat, mouse hovers over it but it won't click on the button. After that it instantly opens the bank again and repeats process.

Sorry for the bad news again :s

From: dangerousgoods
I'm sorry to disappoint you but it has the same problem as your previous version. It withdraws 14 orbs & 14 battlestaffs, uses the orb on the staff, the make battlestaffs option pops up in the chat, mouse hovers over it but it won't click on the button. After that it instantly opens the bank again and repeats process.

Sorry for the bad news again :s

What tha….. try replacing Mouse(x, y, 0, 0 True) under the if FindDTM(Make……) then
With ClickMouse2(True);

I hope you like a challenge…

Replaced line 106 with : Clickmouse2(True);

Same problem as before, if you can't duplicate the error on your side i'm more than willing to show you through a teamviewer session.

From: dangerousgoods
I hope you like a challenge…

Replaced line 106 with : Clickmouse2(True);

Same problem as before, if you can't duplicate the error on your side i'm more than willing to show you through a teamviewer session.

:duh::duh: The problem was wait times so I have fixed it the making but I'm not sure about the banking cause I've ran out of money testing this thing :( New version. If there are problems I won't be able to fix for a while as I need to continue work on MSI

Gucci,

First problem is solved, I have no idea but I had to up your waiting times to more as double in the script :

MouseSpeed := 40;
InvMouse(14, mouse_left);
Wait(100);
InvMouse(15, mouse_left);
Wait(800 + Random(20));
Mouse(253, 427, 0, 0, True);
Wait(15500 + Random(20));

I had to put the last wait way up to 15500 or it would just start to bank after making a few staffs. One issue i'm still struggling with is you Depost part of the script.

Script does not bank the staffs made, after the 'make cycle' it withdraws 14 new items without doing a deposit. I'm learning from this so it's all in a good cause :D

I hope I can figure this out, any hint is welcome hehe.

Good luck with your msi work also !

Good news,

I got your script to work, I've put and extra line in your GetGoods procedure. Somehow the scripts nevers gets to your DepositGoods procedure.

WriteLn('Bank is Open');
DepositAll;
Withdraw(0, 0, 14);
Withdraw(1, 0, 14);
Wait(300);
CloseBank;
WriteLn('Got Goods');

As you see I've just put a depositall in front of your withdraw lines as a failsafe to make sure the invent is empty. And now it's running like a baws. Thanks for the script, thanks for directing me to all the solutions needed.

I hope you see what my problems were, maybe you learned something as well :D

Not really I was gonna add that as a faulsafe in case everything wasn't deposited. Just don't have time, not bad for being whipped up in 5 mins

Not bad at all, and as you can see I'm a satisfied script user. I hope I didn't give an other impression :)

+rep for you and thanks again.

From: dangerousgoods
Not bad at all, and as you can see I'm a satisfied script user. I hope I didn't give an other impression :)

+rep for you and thanks again.

Thanks for the rep and no, not a different impression :)

this works perfectly

all i had to do was:
1. change exp value at the top
2. add a new line after line 107 (new empty line 108)
3. and then enter " ClickMouse2(True); " on this line

Click middle of friend chat and does nothing. >.<

there are only 2 words to discribe this script……. AWSOME! AND FLAWLESS!! did 24k air battlestaffs without error, got me from lvl 96-99 in less then 24hrs! THANK-YOU SO MUCH!

From: pulse0
there are only 2 words to discribe this script……. AWSOME! AND FLAWLESS!! did 24k air battlestaffs without error, got me from lvl 96-99 in less then 24hrs! THANK-YOU SO MUCH!

Glad you like it :D

+rep and please next time you are on pm me with a rs account or how ever i can get ahold of you to donate 10M rsgp .

i just added the line ClickMouse2(True); under the Mouse(257, 428, 0, 0, True); and it seems to be working perfectly now was having some problems with it making the staffs lookin good though! thanks for the script! and other who tipped on helping

I modified a bit of the script and now it works very well. I changed it so it didn't close the bank after it deposits the battlestaff and I added the ClickMouse2(True);
Here it is if anyone wants it and doesn't want to make changes to the original, start it with an empty inv and bank screen open.

program GuccisBattlestaffMaker;
{$DEFINE SMART}
{$i srl/srl/misc/smart.simba}
{$loadlib sps}
{$i srl/srl.simba}
{$i sps/sps.simba}

const
 SRLStats_User = ''; // Your SRL Stats Username
 SRLStats_Password = ''; // Your SRL Stats Password
 MEMBERS = True;
 NumbOfPlayers = 1;
 StartPlayer = 0;
 CraftingEXP = 135; // Edit this for exp gained per staff made.

 var
  StaffsMade, CraftEXP, Make, x, y: integer;

 procedure DeclarePlayers;
  var i:integer;
begin
  NumberOfPlayers(NumbOfPlayers);
  CurrentPlayer := StartPlayer
  for i := 0 to NumbOfPlayers-1 do
  Players[i].BoxRewards := ['XP'];

  With Players[0] do
    begin
      Name := ''; //Username.
      Pass := ''; //Password.
      Pin := ''; // Bank Pin.
      Active := True;
    end;

end;

procedure GetGoods;
begin
  SetAngle(SRL_ANGLE_HIGH);
  Wait(200 + Random(100));

  if (BankScreen) or (PinScreen) then

  begin
    if (PinScreen) then
      repeat
        InPin(Players[0].Pin);
      until (BankScreen);

    if (BankScreen) then
      begin
        WriteLn('Bank is Open');
        DepositAll;
        Withdraw(0, 0, 14);
        Withdraw(1, 0, 14);
        Wait(300);
        CloseBank;
        WriteLn('Got Goods');
      end;
    end;
end;

procedure DepositGoods;
begin
  if (InvCount = 14) then
  begin
   OpenBankChest(SRL_BANK_SW);

  if (BankScreen) or (PinScreen) then

  begin
    if (PinScreen) then
      repeat
        InPin(Players[0].Pin);
      until (BankScreen);

    if (BankScreen) then
      begin
        WriteLn('Bank is Open');
        DepositAll;
        Wait(300);
        WriteLn('Deposited Staffs');
      end;
    end;
end;
end;

procedure DTMS;
begin
  Make :=  DTMFromString('mLgAAAHicY2JgYJBnYmDQBmIjIFYC4uJgAYYFC5YzwAAjFDMwAABU/wNo');
end;

procedure FrDTM;
begin
  FreeDTM(Make);
end;

procedure MakeStaffs;
begin
 MouseSpeed := 40;
 InvMouse(14, mouse_left);
 Wait(100);
 InvMouse(15, mouse_left);
 Wait(500 + Random(20));
 Mouse(257, 428, 0, 0, True);
 ClickMouse2(True);
 Wait(18000 + Random(20));
end;

procedure StaffMade;
begin
  if BankScreen then
  IncEx(StaffsMade, 14);
end;

procedure Report;

begin

  if (BankScreen) then
begin
   CraftEXP:= (StaffsMade*CraftingExp);

  Writeln('############ Guccis Staff Maker ##########');
  Writeln('|= Player : ' + Players[CurrentPlayer].Name);
  Writeln('|= Time Running : ' + TimeRunning);
  Writeln('|= Crafting EXP gained : ' + IntToStr(CraftEXP));
  Writeln('##########################################');
end;
end;

Begin
  Smart_Signed := TRUE;
  Smart_Members := MEMBERS;
  Smart_SuperDetail := FALSE;
  Smart_Server := 30;
  ActivateClient;
  SetupSRL;
  DTMS;
  DeclarePlayers;
  if not (LoggedIn) then
  LoginPlayer;
  Wait(4000+random(400));
  SetAngle(SRL_ANGLE_HIGH);
   Repeat
    GetGoods;
    MakeStaffs;
    if (InvCount = 14) then
    DepositGoods;
    Report;
   Until(False)
    FrDTM;
End.

From: ZenoKurosagi
I modified a bit of the script and now it works very well. I changed it so it didn't close the bank after it deposits the battlestaff and I added the ClickMouse2(True);
Here it is if anyone wants it and doesn't want to make changes to the original, start it with an empty inv and bank screen open.

program GuccisBattlestaffMaker;
{$DEFINE SMART}
{$i srl/srl/misc/smart.simba}
{$loadlib sps}
{$i srl/srl.simba}
{$i sps/sps.simba}

const
 SRLStats_User = ''; // Your SRL Stats Username
 SRLStats_Password = ''; // Your SRL Stats Password
 MEMBERS = True;
 NumbOfPlayers = 1;
 StartPlayer = 0;
 CraftingEXP = 135; // Edit this for exp gained per staff made.

 var
  StaffsMade, CraftEXP, Make, x, y: integer;

 procedure DeclarePlayers;
  var i:integer;
begin
  NumberOfPlayers(NumbOfPlayers);
  CurrentPlayer := StartPlayer
  for i := 0 to NumbOfPlayers-1 do
  Players[i].BoxRewards := ['XP'];

  With Players[0] do
    begin
      Name := ''; //Username.
      Pass := ''; //Password.
      Pin := ''; // Bank Pin.
      Active := True;
    end;

end;

procedure GetGoods;
begin
  SetAngle(SRL_ANGLE_HIGH);
  Wait(200 + Random(100));

  if (BankScreen) or (PinScreen) then

  begin
    if (PinScreen) then
      repeat
        InPin(Players[0].Pin);
      until (BankScreen);

    if (BankScreen) then
      begin
        WriteLn('Bank is Open');
        DepositAll;
        Withdraw(0, 0, 14);
        Withdraw(1, 0, 14);
        Wait(300);
        CloseBank;
        WriteLn('Got Goods');
      end;
    end;
end;

procedure DepositGoods;
begin
  if (InvCount = 14) then
  begin
   OpenBankChest(SRL_BANK_SW);

  if (BankScreen) or (PinScreen) then

  begin
    if (PinScreen) then
      repeat
        InPin(Players[0].Pin);
      until (BankScreen);

    if (BankScreen) then
      begin
        WriteLn('Bank is Open');
        DepositAll;
        Wait(300);
        WriteLn('Deposited Staffs');
      end;
    end;
end;
end;

procedure DTMS;
begin
  Make :=  DTMFromString('mLgAAAHicY2JgYJBnYmDQBmIjIFYC4uJgAYYFC5YzwAAjFDMwAABU/wNo');
end;

procedure FrDTM;
begin
  FreeDTM(Make);
end;

procedure MakeStaffs;
begin
 MouseSpeed := 40;
 InvMouse(14, mouse_left);
 Wait(100);
 InvMouse(15, mouse_left);
 Wait(500 + Random(20));
 Mouse(257, 428, 0, 0, True);
 ClickMouse2(True);
 Wait(18000 + Random(20));
end;

procedure StaffMade;
begin
  if BankScreen then
  IncEx(StaffsMade, 14);
end;

procedure Report;

begin

  if (BankScreen) then
begin
   CraftEXP:= (StaffsMade*CraftingExp);

  Writeln('############ Guccis Staff Maker ##########');
  Writeln('|= Player : ' + Players[CurrentPlayer].Name);
  Writeln('|= Time Running : ' + TimeRunning);
  Writeln('|= Crafting EXP gained : ' + IntToStr(CraftEXP));
  Writeln('##########################################');
end;
end;

Begin
  Smart_Signed := TRUE;
  Smart_Members := MEMBERS;
  Smart_SuperDetail := FALSE;
  Smart_Server := 30;
  ActivateClient;
  SetupSRL;
  DTMS;
  DeclarePlayers;
  if not (LoggedIn) then
  LoginPlayer;
  Wait(4000+random(400));
  SetAngle(SRL_ANGLE_HIGH);
   Repeat
    GetGoods;
    MakeStaffs;
    if (InvCount = 14) then
    DepositGoods;
    Report;
   Until(False)
    FrDTM;
End.

works now after this^, thanks

I had an issue with the wait timers, so that it wouldn't begin combining the staffs properly and would have to go through the MakeStaffs procedure twice before the staffs were created. Doubling the wait time before clicking the "Combine" button to 1000 solved the problem on all worlds, while 800 didn't prove long enough.

Combining that with Zeno's updated code solved all problems, so hopefully this saves a few people the trial-and-error tinkering.

General commentary: this script is really useful to a newbie like myself in learning how a script functions. It's so stripped down and basic that I haven't had any problems figuring out what each function does, nor does it have tightly linked dependancies to unravel. While it might lack failsafes and the like, there are some advantages to the extreme simplicity.

From: Nasus
I had an issue with the wait timers, so that it wouldn't begin combining the staffs properly and would have to go through the MakeStaffs procedure twice before the staffs were created. Doubling the wait time before clicking the "Combine" button to 1000 solved the problem on all worlds, while 800 didn't prove long enough.

Combining that with Zeno's updated code solved all problems, so hopefully this saves a few people the trial-and-error tinkering.

General commentary: this script is really useful to a newbie like myself in learning how a script functions. It's so stripped down and basic that I haven't had any problems figuring out what each function does, nor does it have tightly linked dependancies to unravel. While it might lack failsafes and the like, there are some advantages to the extreme simplicity.

Yeah it's was just something I quickly whipped up I don't ever use it so I don't really check out bugs, but it's great people learn from it ;)

Hey Gucci, I was using your script and it works flawlessly, b staffs take to long to buy so I have resorted to making Green d' bods, I cannot get a script to work for it, would be alright If i edit your script to make green d bods?

From: rbd banned
Hey Gucci, I was using your script and it works flawlessly, b staffs take to long to buy so I have resorted to making Green d' bods, I cannot get a script to work for it, would be alright If i edit your script to make green d bods?

Yeah for sure just don't release to public

I've been using the version that Zeno posted, and it has been working very well.

The script gets stuck when it needs to click the make all battlestaffs tab.
Solution: change the prodedure in the script for my version, way more stable.

procedure MakeStaffs;
begin
MouseSpeed := 20;
InvMouse(14, mouse_left);
Wait(150);
InvMouse(15, mouse_left);
Wait(1500 + Random(100));
Mouse(257, 428, 0, 0, True);
ClickMouse2(True);
Wait(17000 + Random(20));
end;

Making staves all day long :D

From: neo arrow pk
The script gets stuck when it needs to click the make all battlestaffs tab.
Solution: change the prodedure in the script for my version, way more stable.

procedure MakeStaffs;
begin
MouseSpeed := 20;
InvMouse(14, mouse_left);
Wait(150);
InvMouse(15, mouse_left);
Wait(1500 + Random(100));
Mouse(257, 428, 0, 0, True);
ClickMouse2(True);
Wait(17000 + Random(20));
end;

Making staves all day long :D

I was having a similar issue, thanks for posting that!

From: Gucci
Bugs:
- Not clicking the make button in the chatbox ( You need do put in your own coords for that at line 95)

Coordinates are fine.
Seems like most people have highlighted the issue and addressed it.
The wait timer for the crafting menu is not long enough. Easily fixed, script runs fine now.

Also, I'm not sure why it closes the bank after depositing the staves, personally I just commented that part out. :/

        WriteLn('Bank is Open');
        DepositAll;
        Wait(300);
        //CloseBank;
        //WriteLn('Deposited Staffs');

Crude script but get's the job done - thanks. :)

From: honeyhoney
Coordinates are fine.
Seems like most people have highlighted the issue and addressed it.
The wait timer for the crafting menu is not long enough. Easily fixed, script runs fine now.

Also, I'm not sure why it closes the bank after depositing the staves, personally I just commented that part out. :/

        WriteLn('Bank is Open');
        DepositAll;
        Wait(300);
        //CloseBank;
        //WriteLn('Deposited Staffs');

Crude script but get's the job done - thanks. :)

Haha yeah I never need to use it so that affects how much I update it, but tonight I'll update

I take it that this doesn't work anymore?

From: Uzu
I take it that this doesn't work anymore?

You are correct ;) didn't think anybody would use this anymore

I wanted to use it yesterday since staves are still a viable training method :P

From: Uzu
I wanted to use it yesterday since staves are still a viable training method :P

Alright I'll take a look at fixing this tomm

im still learning how to script. im trying to fix your script since rs does not use the MAKE X option anymore.

From: dzpliu
im still learning how to script. im trying to fix your script since rs does not use the MAKE X option anymore.

Make sure you get his permission if you intend of releasing it to the public to use his code.

and so i fixed the script by adding things from SIN's and Ashman88's scripts but im not sure if im allowed to post or not. will ask owner for permission first.

Thank you, I just started fiddling with this and loving it already. Appreciate it :-)

From: googlebear
Thank you, I just started fiddling with this and loving it already. Appreciate it :-)

Nice you see, lol I forgot this existed

############ Guccis Staff Maker ##########
|= Time Running : 1 Hours, 4 Minutes and 56 Seconds
*/////////We have gained: 227452 xp / Thats 210171 xp per hour
*/////////We have crafted 2274 Staff / Thats 2101 Staff Per Hour
##########################################
thanks for script.