SRL Archive - First Scripts

This is my first script I have decided to release. Got help from my brother with this script. I hope it is an okay start.

program CageFishing;
{$DEFINE SMART}
{$i srl/srl.simba}
const
{==========Smart Setup==========}
World = 0;  // Input the runescape world number right here for it to select. You may leave it as 0 if you would like it to select a random world.
MEMBERS = False;  // Select False if you are not a member. Select True if you are a member.
SIGNED = True;  // Select True if you are using single account. Select False if not. Do know that this is a single account script.
{===============================}
procedure DeclarePlayers;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  Players[0].Name := ''; //Your Runescape username goes right here.
  Players[0].Pass := ''; //Your Runescape password goes right here.
  Players[0].Active := True; //Set to True if you want to use this player. Set to False to disable this player.
  Players[0].Pin := ''; //Put your Bank PIN here. Leave blank if you don't have a Bank PIN.
end;
procedure AntiBan;
begin
     if(not(LoggedIn))then
  Exit;
  FindNormalRandoms;
  case Random(8) of
   0:
   begin
     HoverSkill('Fishing', false);
     wait(1500+Random(750));
   end;
   end;
   end;
procedure MakeNorth;
begin
MakeCompass('n');
Antiban;
end;
procedure FishSpot;
var x, y: integer;
begin
FindNormalRandoms;
SetAngle(SRL_ANGLE_HIGH);
if FindObj(x, y, 'age', 11447206, 10) then
Mouse(x, y, 0, 0, true);
ChooseOption('ishingspot');
repeat
wait(3000+random(250));
Until not IsUpText('ishingspot') or (InvFull);
end;
procedure Drop;
var i: integer;
begin
  for i:= 0 to 2 do
  begin
    DropPattern(Random(2) + 1);
    if InvCount = 0 then
      break;
  end;
end;
begin
  Smart_Server := WORLD;
  Smart_Members := MEMBERS;
  Smart_Signed := SIGNED;
  Smart_SuperDetail := False;
  SetupSRL;

  DeclarePlayers;
  LoginPlayer;

  repeat
  AntiBan;
  FishSpot;
  Drop;
  until AllPlayersInactive;
end.

Feedback would be nice.

Still have more to learn. I taught you enough you would need to know.

not too bad for ur first script. :) only "bugs" (or issues that i noticed off the bat) were these:

procedure FishSpot;
var x, y: integer;
begin
  FindNormalRandoms;
  SetAngle(SRL_ANGLE_HIGH);
  if FindObj(x, y, 'age', 11447206, 10) then
    Mouse(x, y, 0, 0, true);
  ChooseOption('ishingspot');       // no need, since u r left clicking, u will never need this.
  repeat
    wait(3000+random(250));
  Until not IsUpText('ishingspot') or (InvFull);     // potential infinate loop
end;    

From: x[Warrior]x3500
not too bad for ur first script. :) only "bugs" (or issues that i noticed off the bat) were these:

procedure FishSpot;
var x, y: integer;
begin
  FindNormalRandoms;
  SetAngle(SRL_ANGLE_HIGH);
  if FindObj(x, y, 'age', 11447206, 10) then
    Mouse(x, y, 0, 0, true);
  ChooseOption('ishingspot');       // no need, since u r left clicking, u will never need this.
  repeat
    wait(3000+random(250));
  Until not IsUpText('ishingspot') or (InvFull);     // potential infinate loop
end;    

Thanks for the feedback.

oh! how could i have forgotten that! omg i just saw the code that i posted and realised there was a MAJOR issue with that function.

NEVER EVER EVER EVER use a script that doesnt have randomness to it.
never do this:

  Mouse(x, y, 0, 0, true);

(unless u have something like this)

mmouse(x, y, 4, 4);
getmousepos(x,y);
// insert uptext detection here, or something
mouse(x, y, 0, 0, false); 

From: x[Warrior]x3500
oh! how could i have forgotten that! omg i just saw the code that i posted and realised there was a MAJOR issue with that function.

NEVER EVER EVER EVER use a script that doesnt have randomness to it.
never do this:

  Mouse(x, y, 0, 0, true);

(unless u have something like this)

mmouse(x, y, 4, 4);
getmousepos(x,y);
// insert uptext detection here, or something
mouse(x, y, 0, 0, false); 

Ah……Okay. Thanks for pointing that out. =)

Nice script, worked nicely for half hour - until I manually stopped it. If you really want to train scripting, you should look at your antiban - it's really basic. Back in SCAR days, I had my own func, in my own .simba file just cause I was so proud of it :) Something like - case of 100 and 8 options like hoverskill, semi-afk, camera rotation or smth like that would be much greater, for there is no variation. Also you seem to have a bad habit of not making spare lines beetwen functions/procedures, it makes script harder to read. Also your script seems to never use MakeNorth procedure, so why have it there to compile ? You can always save that 0,0000000001 s :) Other than that, nice script, keep up the good work and good luck :)

From: Endzior
Nice script, worked nicely for half hour - until I manually stopped it. If you really want to train scripting, you should look at your antiban - it's really basic. Back in SCAR days, I had my own func, in my own .simba file just cause I was so proud of it :) Something like - case of 100 and 8 options like hoverskill, semi-afk, camera rotation or smth like that would be much greater, for there is no variation. Also you seem to have a bad habit of not making spare lines beetwen functions/procedures, it makes script harder to read. Also your script seems to never use MakeNorth procedure, so why have it there to compile ? You can always save that 0,0000000001 s :) Other than that, nice script, keep up the good work and good luck :)

Back in SCAR days, I had my own func, in my own .simba file.
Back in SCAR days, I had my own .simba file.
SCAR days….simba file.

..wait..wut?

:P

Aha, JigSawJr teaching youngsters.

-Insiders, Phyaskou get's it.-

From: nkn
Aha, JigSawJr teaching youngsters.

-Insiders, Phyaskou get's it.-

I get it :stirthepot:

program CageFishing;
{$DEFINE SMART}
{$i srl/srl.simba}
const
{==========Smart Setup==========}
World = 0;  // Input the runescape world number right here for it to select. You may leave it as 0 if you would like it to select a random world.
MEMBERS = False;  // Select False if you are not a member. Select True if you are a member.
SIGNED = True;  // Select True if you are using single account. Select False if not. Do know that this is a single account script.
{===============================}
procedure DeclarePlayers;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  Players[0].Name := '';
  Players[0].Pass := '';
  Players[0].Active := True;
  Players[0].Pin := '';
end;

procedure AntiBan;
begin
  if(not(LoggedIn))then
    Exit;                 //Notice how this is set out
  FindNormalRandoms;     //You need to look into this more
  case Random(8) of
    0 : begin             //Notice how I set this out
          HoverSkill('Fishing', false);
          wait(1500+Random(750));
        end;
  end;
end;

procedure MakeNorth;
begin
  MakeCompass('n');        //Notice that these are indented
  Antiban;
end;

procedure FishSpot;
var x, y: integer;
begin
  FindNormalRandoms;
  SetAngle(SRL_ANGLE_HIGH);
  if FindObj(x, y, 'age', 11447206, 10) then
    Mouse(x, y, 0, 0, true);
  ChooseOption('ishingspot');   //this line isn't needed
  repeat
    wait(3000+random(250));
  Until not IsUpText('ishingspot') or (InvFull);   //what about if the user goes in a random event now? or stops fishing but the uptext stays
end;
procedure Drop;
var
  i: integer;
begin
  if(not InvFull)then
    exit;              //If the inventory isn't full then we don't want to drop
  for i:= 0 to 2 do
  begin
    DropPattern(Random(2) + 1);
    if InvCount = 0 then
      break;
  end;
end;
begin
  Smart_Server := WORLD;
  Smart_Members := MEMBERS;
  Smart_Signed := SIGNED;
  Smart_SuperDetail := False;
  SetupSRL;

  DeclarePlayers;
  LoginPlayer;

  repeat
    AntiBan;        //tab these lines in a space
    FishSpot;
    Drop;
  until AllPlayersInactive;
end.

I'm gonna learn along with him.. if that's ok <3

procedure DeclarePlayers;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  Players[0].Name := ''; //Your Runescape username goes right here.
  Players[0].Pass := ''; //Your Runescape password goes right here.
  Players[0].Active := True; //Set to True if you want to use this player. Set to False to disable this player.
  Players[0].Pin := ''; //Put your Bank PIN here. Leave blank if you don't have a Bank PIN.
end;
procedure AntiBan;
begin
     if(not(LoggedIn))then
  Exit;
  FindNormalRandoms;
  case Random(8) of
   0:
   begin
     HoverSkill('Fishing', false);
     wait(1500+Random(750));
   end;
   end;
   end;
procedure MakeNorth;
begin
MakeCompass('n');
Antiban;
end;
procedure FishSpot;
var x, y: integer;
begin
FindNormalRandoms;
SetAngle(SRL_ANGLE_HIGH);
if FindObj(x, y, 'age', 11447206, 10) then
Mouse(x, y, 0, 0, true);
ChooseOption('ishingspot');
repeat
wait(3000+random(250));
Until not IsUpText('ishingspot') or (InvFull);
end;
procedure Drop;
var i: integer;
begin
  for i:= 0 to 2 do
  begin
    DropPattern(Random(2) + 1);
    if InvCount = 0 then
      break;
  end;
end;
begin
  Smart_Server := WORLD;
  Smart_Members := MEMBERS;
  Smart_Signed := SIGNED;
  Smart_SuperDetail := False;
  SetupSRL;

  DeclarePlayers;
  LoginPlayer;

  repeat
  AntiBan;
  FishSpot;
  Drop;
  until AllPlayersInactive;  [COLOR="Blue"]//does this need to be defined somewhere else in the script?[/COLOR]
end.