SRL Archive - Archive

Ilya - SRL Member Application


Ilya

2012-02-16 16:01:27

How Long have You Played Runescape?
6 Year(s)


Are you affilated in anyway with Jagex LTD?
Absolutely Not

Were you Referred to SRL?
Found Out on Sythe.


What is your general programming knowledge?
Zero, but attempting to learn Pascal.


Are you a member of any other communities?
Sythe and RiD


Tell us about yourself…
From: Ilya
Hello Simbaers.
I go by Ilya. I am in my senior year of college. My interests include videogames, partying, skiing, politics, college football, and maybe coding in the near future.
I've been playing RS entirely too long, but I can't seem to kick the habbit. I swear it's worse than cigarettes.



Please show us one (or multiple) of your scripts.
A Druid killing/looting script I attempted.

program Druids;
//by Ilya\\
{$DEFINE SMART}
{$i SRL/srl.simba}
{$i SRL/SRL/skill/fighting.simba}


var
DruidColours, LootColours: TIntegerArray;
x, y, xx, yy , reportcount,
KillCount, LootCount, LevelPopUp, NoThanks : Integer;
frmDesign: TForm;
StartReady: Boolean;
PlayerList: TListBox;
npcname,Username,Password,AttackingOption: String;
Edits: Array [0..9] of TEdit;
foodnumber: integer;
Drops: Array of String;
HerbColours: TIntegerArray;


const
Tolerance = 3;
LootHerbs = true;




procedure DeclarePlayers;
begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;
with Players[0] do
begin
Name := 'chief ilya'; //Character Name
Pass := '460159865'; //Character Pass
Pin := ''; //Pin for bank
Active := true;
end;
end;

procedure CheckRandoms;
begin
if (FindBitMap(LevelPopUp, x, y)) then
begin
FindBitMap(NoThanks, xx, yy)
Mouse(xx, yy, 3, 3, true);
end;
FindNormalRandoms;
end;

procedure Attack;

var
Xi, Yi, X1, Y1, X2, Y2: Integer;
begin
if InFight then
begin
repeat
FindNormalRandoms;
until (not (OthersInFight) or (not LoggedIn) or (not InFight))
end;
x := Random(8) case x of 4:
end;
if FindObjEx(Xi, Yi, ['ttack', 'ranarr', 'kwuarm', 'irit', 'dwarf', 'avantoe', 'cadantine'], DruidColours, Tolerance, 50, 1, 5, 689, 390) then
begin
if not (IsFightAt(Xi, Yi) and not InFight) then
begin
GetMousePos(Xi, Yi);
Mouse(Xi, Yi, 5, 5, false);
if WaitOptionMulti(['ttack Chaos', 'attack druid', 'haos druid', 'haos', 'ranarr', 'kwuarm', 'irit', 'dwarf', 'avantoe', 'cadantine'], 200)then
WaitOptionMulti(['ttack Chaos', 'attack druid', 'haos druid', 'haos', 'ranarr', 'kwuarm', 'irit', 'dwarf', 'avantoe', 'cadantine'], 200);
end;
while IsMoving do
begin
Wait(350);
end;

end
else
begin
repeat
FindNormalRandoms;
until (not InFight) or (not OthersInFight) or (not LoggedIn)
end;
end;




procedure CheckLoot;

var
Xi, Yi, X1, Y1, X2, Y2: Integer;
begin

if LootHerbs then
begin
if InFight then
begin
repeat
FindNormalRandoms;
until (not (OthersInFight) or (not LoggedIn) or (not InFight))
end;
if FindObjEx(Xi, Yi, ['take', 'grimy', 'ake', 'ranarr', 'kwuarm', 'irit', 'dwarf', 'avantoe', 'cadantine'], LootColours, Tolerance, 50, 1, 5, 689, 390) then
begin
if not InFight then
begin
GetMousePos(Xi, Yi);
Mouse(Xi, Yi, 5, 5, false);
if WaitOptionMulti(['take', 'grimy', 'ake', 'ranarr', 'kwuarm', 'irit', 'dwarf', 'avantoe', 'cadantine'], 200) then
WaitOptionMulti(['take', 'grimy', 'ake', 'ranarr', 'kwuarm', 'irit', 'dwarf', 'avantoe', 'cadantine'], 200);
Wait(RandomRange(1000, 1500));
end;
while IsMoving do
begin
Wait(250);
end;
end
else
begin
wait(300)
end;
end;
end;
procedure Hungry;
var
c, T, i, x, y: Integer;


begin
if (HPPercent < RandomRange(45, 65)) and LoggedIn then
begin
if not InvEmpty then
for c := 0 to 2 do
for i := 1 to 28 do
if ExistsItem(i) then
begin
MMouseItem(i);
GetMousePos(x, y);
if WaitUptext('Eat', 400) then
begin
Mouse(x, y, 0, 0, false);
if WaitOption('Eat', 400) then
begin
t := GetSystemTime;
while ExistsItem(i) and ((GetSystemTime - t) < 2000) do
wait(20);
end;
Exit;
end;
end;
end;
end;


begin
Cleardebug;
ClearReport;
Smart_Server := 97;
Smart_Members := true;
Smart_Signed := true;
Smart_SuperDetail := false;
DruidColours := [8228496, 3297136, 2506837, 12500935];
LootColours := [2256450, 2388541, 1923356, 5069084, 5200669, 1009756, 1076320, 2256457, 2189895];
SetupSRL;
DeclarePlayers;
LoginPlayer;
Writeln('Welcome to DruidRaper!');
Wait(600);
SetAngle(SRL_ANGLE_HIGH);


repeat
Hungry;
CheckLoot;
Attack;
CheckLoot;
CheckRandoms;
until (false)
end.

PatDuffy

2012-02-16 16:03:48

find obj…no TPA…

it's a no from me, I'm sure someone will give you a more detailed answer

Sin

2012-02-16 16:04:08

FindObjEx


Noty.

Kave

2012-02-16 16:08:30

You left your password in your application pming you new one.

Kyle Undefined

2012-02-16 16:17:19

Sorry, it's too simple for me. Also, you left your creds in the script, but luckily no Member here will wipe it :)

Try to avoid using so many Global variables, they can hog up memory and can really slow down a script if used incorrectly. Looks like you're pulling Form variables in, even though you don't have a form. frmDesign, PlayerList, Edits are only for forms and aren't needed.

Your CheckRandoms procedure won't even work, you're searching for bitmaps that aren't even defined in your script. Also, the x/y and xx/yy variables should be defined in your procedure itself and not global.

Your Attack procedure is completely broken, you have a random case statement that isn't even being used so why have it? You declare X1/2 Y1/2 variables and don't use those either. I don't understand what your uptext is suppose to mean, since it's an attack procedure and not a loot procedure. Are you trying to attack and loot in one piece of code?

Your CheckLoot procedure basically isn't needed since you're basically doing the same thing in the Attack one.

Your Hungry procedure will eat everything in the inventory, even if you don't need to.

Oh, and also, you joined last month. You're too green and need to make yourself known more first.

Ilya

2012-02-16 16:49:21

Thanks for everything guys.
I recon i'll hang out for awhile.

[XoL]

2012-02-16 17:43:29

No from me.

Try to follow this guide to become a SRL member:
http://villavu.com/forum/showthread.php?t=74195

For learning purposes I recommend starting with YoHoJo's video tutorials, informative and they will teach you what you need to know to create a basic/decent script.
http://villavu.com/forum/showthread.php?t=69179

For more advanced scripting I would suggest reading these guides:
http://villavu.com/forum/forumdisplay.php?f=96

Also one thing I really think is important is being community focused, you have 22 posts and have been here since Jan! Posting actively not only shows you genuinely care for the community it also helps your chances of getting accepted.

These guides can help you with that:
http://villavu.com/forum/showthread.php?t=72050
http://villavu.com/forum/showthread.php?t=66084

Anyway, sorry for the roughness. Good luck.

Camaro'

2012-02-25 21:47:27

From: Sin
Noty.


If that is the only reason you voted no, then you should really reconsider how you vote. This script as other members have pointed out is not members worthy, but quoting a function that is built into SRL and voting no with no further reasoning doesn't seem to fair to me. It seems like you just saw that function and voted no right away because of it.

P1nky

2012-02-25 21:50:57

No, Try using more complex functions, add TPAS/DDTMS/RRW/DTMS/BMP.

Good Luck Mate

Justin

2012-02-26 05:50:10

Its a no for me. Looks exactly like my EdgeManKiller and you just edited the NPC names, colors and renamed procedure.

EdgeManKiller script: http://villavu.com/forum/showthread.php?t=69748

masterBB

2012-02-26 06:29:45

It's a good copy, but I see too many similarities.

Harry

2012-02-26 07:06:25

53d81
< procedure Attack;
54a83
> procedure Attack;
64c93
< x := Random(8) case x of 4:
—
> x := Random(8) case x of 4: WalkToMen; //Failsafe if we get lured
66c95
< if FindObjEx(Xi, Yi, ['ttack', 'ranarr', 'kwuarm', 'irit', 'dwarf', 'avantoe', 'cadantine'], DruidColours, Tolerance, 50, 1, 5, 689, 390) then
—
> if FindObjEx(Xi, Yi, ['ttack'], ManColours, Tolerance, 50, 1, 5, 689, 390) then
72,73c101
< if WaitOptionMulti(['ttack Chaos', 'attack druid', 'haos druid', 'haos', 'ranarr', 'kwuarm', 'irit', 'dwarf', 'avantoe', 'cadantine'], 200)then
< WaitOptionMulti(['ttack Chaos', 'attack druid', 'haos druid', 'haos', 'ranarr', 'kwuarm', 'irit', 'dwarf', 'avantoe', 'cadantine'], 200);
—
> WaitOptionMulti(['ttack M', 'attack Man'], 200);
77c105
< Wait(350);
—
> Wait(250);
79d106

> procedure CheckLoot;
97d117
<
106c126
< if FindObjEx(Xi, Yi, ['take', 'grimy', 'ake', 'ranarr', 'kwuarm', 'irit', 'dwarf', 'avantoe', 'cadantine'], LootColours, Tolerance, 50, 1, 5, 689, 390) then
—
> if FindObjEx(Xi, Yi, ['ake'], HerbColours, Tolerance, 50, 1, 5, 689, 390) then
112,114c132,133
< if WaitOptionMulti(['take', 'grimy', 'ake', 'ranarr', 'kwuarm', 'irit', 'dwarf', 'avantoe', 'cadantine'], 200) then
< WaitOptionMulti(['take', 'grimy', 'ake', 'ranarr', 'kwuarm', 'irit', 'dwarf', 'avantoe', 'cadantine'], 200);
< Wait(RandomRange(1000, 1500));
—
> WaitOptionMulti(['Take Grimy', 'ake Grimy'], 200);
> Wait(RandomRange(1000, 1800));
123c142
< wait(300)
—
> wait(800)

Just 2 nice little snips from the differences in the script ;)

I'm not really sure if I'd call it complete plagiarism. There is a LOT of stuff borrowed. It looks like you took the man killer, butchered some stuff off it, renamed, changed colors. Please explain why there's no credits and such.

No from me.

Bam Bam

2012-02-27 01:11:05

Sorry, no from me on the basis that the script is a bit too simple to be considered for SRL Membership. Also, what Harry says earns you a no vote.

Hobbit

2012-03-02 01:27:15

The poll has closed and you didn't quite make it this time. Please take the suggestions made in this thread and improve on the script and reapply in 4 weeks time :)

Cheers
Hobbit