SRL Archive - Archive

laakerules - SRL Member Application


laakerules

2012-02-05 18:41:05

How Long have You Played Runescape?
9 Year(s)


Are you affilated in anyway with Jagex LTD?
No

Were you Referred to SRL?
Noone


What is your general programming knowledge?
C#, JavaScript, Java, And simba. With a little in a few more.


Are you a member of any other communities?
Nope


Tell us about yourself…
From: laakerules
I am a man with ADD and Disgraqphia, i let my energy and boredness flow into coding!

This is my 3rd time applying, 1st time i got 7 no's and 4 yesses in a week. Second time same script more advanced though i got 2 yesses and 12 no's in 1 day!

So i decided to make a new and improved script. Ghouling Ghouler, in the fighting section.



Please show us one (or multiple) of your scripts.
Changed rouges den to this one since this is amazing xp shows multiple uses of my skills and also this one is flawless ran it several times with all 6 hours + gone thruogh! :)
program CraftingGuild;

{$DEFINE SMART}
{$i SRL/srl.simba}
{$i sps/sps.simba}



Var
Urns,XPU,XPF,XPT,XPH:Integer;

procedure DeclarePlayers;
Begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;

With Players[0] Do
Begin
Name := ''; //Player username.
Pass := ''; //Player password.
Nick := ''; //Player nickname - 3-4 letters of Player username.
Active := True;
End;

End;

Procedure XPcalcT;
Begin
XPT := (URNS*81);
End;

Procedure XPhour;
Begin
XPcalcT;
XPH := Round((XPT * 3600) / (GetTimeRunning / 1000));
End;

procedure SetupChar;

begin

SetupSRL();
SetAngle(0);
ClickNorth(0);
end;
Procedure Proggy;

begin
XPHour;
XPcalcT;
ClearDebug;
Writeln('*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*');
Writeln('* \*|_/\Crafting Guilder/\_|*/ *');
Writeln('*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*');
Writeln('You have Finished ' + IntToStr(Urns) + 'Urns');
Writeln('And have Gained ' + IntToStr(XPT) + 'EXP');
Writeln('And have Gained ' + IntToStr(XPH) + 'XP/H');
Writeln(' Ran for ' + TimeRunning + 'Time');
Writeln('*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*');
end;

procedure Startup;
begin
Smart_Server := 69;
Smart_Members:= true;
Smart_Signed := true;
SetupSRL;
DeclarePlayers;
LogInPlayer;
MouseSpeed := 500;
wait(100+random(100));
end;
function Walking(Color, Tolerance: Integer; SortFrom: tpoint): Boolean;
var
i, x, y, rx, ry: Integer;
TPA: TPointArray;
begin
if not LoggedIn then Exit;
FindNormalRandoms;
FindColorsSpiralTolerance(MMCX, MMCY, TPA, Color, MMX1, MMY1, MMX2, MMY2, Tolerance);
SortTPAFrom(TPA, SortFrom);

for i := 0 to High(TPA) do
begin
x := TPA[i].x;
y := TPA[i].y;

rx := RandomRange(-1, 1);
ry := RandomRange(-1, 1);
if (not rs_OnMinimap(x + rx, y + ry)) then
Continue;

Mouse(x + rx, y + ry, 0, 0, true);
FFlag(0);
Wait(200 + Random(500));
Result := True;
Break;
end;
end;

Function FindObjOnScreen(Color,Tolerance:Integer;MC2:Variant): Boolean;
var
X,Y:Integer;
CTS,I,T: Integer;
TPA: TPointArray;
begin
repeat
Result := False;
CTS := GetColorToleranceSpeed;

ColorToleranceSpeed(2);

SetColorSpeed2Modifiers(0.50,1.00);

FindColorsSpiralTolerance(MSCX, MSCY, TPA,(Color), MSX1, MSY1, MSX2, MSY2, Tolerance);
ColorToleranceSpeed(CTS);

if (Length(TPA) < 1) then
Exit;

MMouse(TPA[0].X, TPA[0].Y, 5, 5);
begin
GetMousePos(X, Y);
ClickMouse2(MC2);
Result := True;
Exit;
end;
Until(Result)
end;
procedure ToWater;
Var
myPath:TPointArray;
begin
SPS_Setup(RUNESCAPE_SURFACE,['8_8']);//SPS Areas
myPath := [Point(3590, 3522), Point(3579, 3533), Point(3572, 3540)];
SPS_WalkPath(myPath);
SetAngle(0);
Repeat
Wait(50);
until (not IsMoving);
end;

procedure ToSpinner;
Var
myPath:TPointArray;
begin
SPS_Setup(RUNESCAPE_SURFACE,['8_8']);//SPS Areas
myPath := [Point(3573, 3538), Point(3575, 3528), Point(3578, 3517), Point(3578, 3504)];
SPS_WalkPath(myPath);
Repeat
Wait(50);
until (not IsMoving);
end;

procedure ToFire;
Var
myPath:TPointArray;
begin
SPS_Setup(RUNESCAPE_SURFACE,['8_8']);//SPS Areas
myPath := [Point(3581, 3504), Point(3570, 3513), Point(3553, 3498)];
SPS_WalkPath(myPath);
Repeat
Wait(50);
until (not IsMoving);
end;

procedure ToRocks;
Var
myPath:TPointArray;
begin
SPS_Setup(RUNESCAPE_SURFACE,['8_8']);//SPS Areas
myPath := [Point(3554, 3501), Point(3564, 3509), Point(3573, 3517), Point(3590, 3522)];
SPS_WalkPath(myPath);
Repeat
Wait(50);
until (not IsMoving);
end;

Procedure MakeSoft;
Var
X,Y:Integer;
Begin
InvMouse(1, 1);
Wait(250 + Random(25));
FindObjOnScreen(16625804,5,True);
Wait(2000 + Random(25));
MMouse(250, 425, 10, 10);
ClickMouse2(True);
End;

Procedure MakeUrns;
Begin
FindObjOnScreen(9671578,2,True);
Wait(1000 + Random(25));
MMouse(200, 430, 0, 0);
ClickMouse2(True);
Wait(1000 + Random(25));
MMouse(300, 425, 0, 0);
ClickMouse2(True);
Wait(1000 + Random(25));
MMouse(465, 420, 0, 0);
ClickMouse2(True);
End;

Procedure MakeUrnsF;
Begin
InvMouse(1, 1);
Wait(1000 + Random(25));
FindObjOnScreen(4673664,1,True);
Wait(2000 + Random(25));
MMouse(250, 430, 0, 0);
ClickMouse2(True);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
End;
Procedure DoCrafting;
Begin
ToWater;
MakeSoft;
Wait(38000);
ToSpinner;
MakeUrns;
Proggy;
Wait(20000);
ToFire;
MakeUrnsF;
Proggy;
Wait(60000);
DropAll;
ToRocks;
Proggy;
Wait(1000);
end;

Procedure MineClay;
Var
X,Y:Integer;
Begin
If InvFull Then Exit;
repeat
FindObjOnScreen(9295101,10,True);
If InvFull Then Exit;
Wait(2000);
FindObjOnScreen(9295101,10,True);
If InvFull Then Exit;
Wait(2000);
Until InvFull Exit;

End;

begin
Startup;
SetupChar;
Repeat
MineClay;
DoCrafting;
Until Not(LoggedIn);
end.

program Ghouler;
{$DEFINE SMART}
{$i SRL/srl.simba}
{$i SRL/SRL/skill/fighting.simba}
{$i sps/sps.simba}
{$i SRL/SRL/misc/paintsmart.simba}


///////////////////////////////////
//start setup
///////////////////////////////////

const

SWorld = 35;
var
foodnumber,T,Exp,Charms,XPH,BMP,Kills,MSpeed,RandAmount:Integer;
Drops: Array of String;


procedure DeclarePlayers;
Begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;

With Players[0] Do
Begin
Name := ''; //Player username.
Pass := ''; //Player password.
Nick := ''; //Player nickname - 3-4 letters of Player username.
Active := True;
End;

End;

///////////////////////////////////
///////////////////////////////////
///// end setup /////
///////////////////////////////////
///////////////////////////////////




procedure SetupChar;

begin

SetupSRL();
SetAngle(0);
ClickNorth(0);
end;

Procedure ToBank;
Var
myPath: TPointArray;
begin
SPS_Setup(RUNESCAPE_SURFACE, ['13_6','14_6']);
myPath := [Point(5502, 2599), Point(5513, 2597), Point(5523, 2593), Point(5532, 2592), Point(5542, 2591), Point(5550, 2593), Point(5558, 2597), Point(5567, 2600), Point(5576, 2605), Point(5586, 2612), Point(5594, 2622), Point(5603, 2632), Point(5610, 2642), Point(5617, 2652), Point(5626, 2659), Point(5634, 2671), Point(5641, 2684), Point(5647, 2695), Point(5656, 2698), Point(5666, 2700), Point(5672, 2705), Point(5679, 2714), Point(5684, 2730), Point(5695, 2740), Point(5711, 2740), Point(5726, 2740), Point(5739, 2735), Point(5751, 2732), Point(5762, 2730), Point(5772, 2725), Point(5783, 2722), Point(5797, 2717), Point(5811, 2714), Point(5824, 2714), Point(5835, 2713), Point(5846, 2715), Point(5860, 2722), Point(5874, 2727)];
SPS_WalkPath(myPath);
end;

Procedure ToGhouls;
Var
myPath: TPointArray;
begin
SPS_Setup(RUNESCAPE_SURFACE,['14_6','13_6']);
myPath := [Point(5878, 2728), Point(5870, 2728), Point(5857, 2722), Point(5849, 2720), Point(5840, 2719), Point(5827, 2717), Point(5813, 2716), Point(5798, 2716), Point(5784, 2722), Point(5773, 2732), Point(5757, 2739), Point(5741, 2742), Point(5727, 2745), Point(5712, 2743), Point(5699, 2737), Point(5685, 2728), Point(5678, 2712), Point(5666, 2700), Point(5653, 2689), Point(5642, 2679), Point(5633, 2672), Point(5628, 2666), Point(5618, 2656), Point(5612, 2645), Point(5607, 2631), Point(5595, 2619), Point(5582, 2610), Point(5571, 2604), Point(5559, 2596), Point(5548, 2596), Point(5536, 2597), Point(5524, 2599), Point(5512, 2599)];
SPS_WalkPath(myPath);
end;

procedure MSI_RandomFKey;
var
i, randInt, randKey, currTab: Integer;
keys: array[0..4] of Word;
begin
currTab := GetCurrentTab();

keys[0] := VK_F1;
keys[1] := VK_F2;
keys[2] := VK_F3;
keys[3] := VK_F4;
keys[4] := VK_F5;

randInt := Random(6);

case randInt of
0..4:
begin
KeyDown(keys[randInt]);
wait(35+random(85));
KeyUp(keys[randInt]);
end;

else
for i := 1 to 3 do
begin
randKey := Random(5);
KeyDown(keys[randKey]);
wait(35+random(85));
KeyUp(keys[randKey]);
end;
end;
wait(75+random(100));
GameTab(currTab);
end;
Function Eat(What: String): Boolean;
var
I: Integer;
begin
Result := False;
If Not LoggedIn then Exit;
if (foodnumber=1) then Exit;
if (HPPercent < 70) then
If InvEmpty then Logout
else
for i := 1 to 28 do
begin
InvMouse(I, 3);
if IsUpText(What) then
begin
ClickMouse2(True);
Wait(RandomRange(350, 525));
Result := True;
Exit;
end else
end;
end;
Procedure Proggy;

begin
ClearDebug;
Writeln('********************************************');
Writeln('* |*/\GhoulerV4/\*| *');
Writeln('********************************************');
Writeln('*You have killed ' + IntToStr(Kills) + 'Ghouls');
Writeln('*And have Gained ' + IntToStr(Exp) + 'EXP');
Writeln('*And have Picked up ' + IntToStr(Charms) + 'Charms');
Writeln('* Ran for ' + TimeRunning + '');
Writeln('********************************************');
end;

procedure GAntiBan;
begin
writeln('Choosing random antiban');
case random(11) of
0 : begin
writeln('Prayer tab selected');
GameTab(27);
Wait(randomrange(400,800));
end;
1 : begin
writeln('Random movement selected');
RandomMovement;
end;
2 : begin
writeln('Random Fkey selected');
MSI_RandomFKey;
end;
3 : begin
writeln('Random click selected');
RandomRClick;
end;
4 : begin
writeln('Random Angle selected');
end;
5 : begin
writeln('Hover skill strength');
HoverSkill(skill_strength,false);
end;
6 : begin
writeln('Hover Skill (HP) selected');
HoverSkill(skill_hitpoints,false);
Wait(randomrange(300,600));
end;
7 : begin
writeln('Game Tab stats selected');
GameTab(23);
end;
8 : begin
writeln('Pickup Mouse selected');
PickUpMouse;
end;
9 : begin
writeln('Random wait selected');
Wait(randomrange(1000,2000));
end;
10 : begin
writeln('Hover Skill attack selected');
HoverSkill('attack',false);
end;
end;
Wait(randomrange(500,1000));
end;

Procedure LoadBMP;
begin

{Took out the BMP cause its massive for you guys to view the script through so there is a pic of it beneath this code. If you want to see how the script runs you can download it through my Sig}

end;
procedure LoadVars;
begin
Drops:=['old charm','ffigy']

end;

Procedure XPcalc;
Begin
Exp := (Kills*266);
End;

Procedure XPhour;
Begin
XPcalc;
XPH := Round((Exp * 3600) / (GetTimeRunning / 1000));
End;

Procedure DoThePainting;
begin
XPhour;
LoadBMP;
SMART_DrawBitmap(False, BMP, Point(0, 337));
SMART_DrawText(130, 395, UpCharsEx, '' +IntToStr(Kills)+ '', clRed);
SMART_DrawText(130, 420, UpCharsEx, '' +IntToStr(Exp)+ '', clRed);
SMART_DrawText(130, 445, UpCharsEx, ''+IntToStr(XPH)+'', clRed);
SMART_DrawText(325, 395, UpCharsEx,''+TimeRunning+' ', clRed);
SMART_DrawText(440, 420, UpCharsEx, ''+IntToStr(Charms)+'', clRed);
FreeBitmap(BMP);
end;

function CharmColor: Integer;
var
arP: TPointArray;
arC: TIntegerArray;
tmpCTS, i, arL: Integer;
begin
tmpCTS := GetColorToleranceSpeed;
ColorToleranceSpeed(2);
SetColorSpeed2Modifiers(1.14, 1.47);

if not (FindColorsTolerance(arP, 6397359, MSX1, MSY1, MSX2, MSY2, 2)) then
begin
Writeln('Failed to find the color, no result.');
Exit;
end;

arC := GetColors(arP);
ClearSameIntegers(arC);
arL := High(arC);

for i := 0 to arL do
begin
Result := arC[i];
Writeln('AutoColor = ' + IntToStr(arC[i]));
Break;
end;

ColorToleranceSpeed(tmpCTS);
SetColorSpeed2Modifiers(0.2, 0.2);

if (i = arL + 1) then
Writeln('AutoColor failed in finding the color.');
end;
Function FindCharms(Var X,Y: Integer): Boolean;
var
CTS: Integer;
TPA: TPointArray;
begin
Result := False;
CTS := GetColorToleranceSpeed;

ColorToleranceSpeed(2);

SetColorSpeed2Modifiers(0.38, 0.55);

FindColorsSpiralTolerance(MSCX, MSCY, TPA, (CharmColor), MSX1, MSY1, MSX2, MSY2, 7);
ColorToleranceSpeed(CTS);

if (Length(TPA) < 1) then
Exit;

MMouse(TPA[0].X, TPA[0].Y, 5, 5);

if WaitUpText('Take', 400) then
begin
GetMousePos(X, Y);
ClickMouse2(False);
ChooseOptionMulti(Drops);
Result := True;
Inc(Charms);
Exit;
end;

end;

//Euphamism thanks, through YoHo
procedure SMART_DrawBitmapWithTextMulti(Clear: Boolean; Bitmap: Integer; BmpPlacement: TPoint; TP: TStringArray; Shadow: Boolean; TxtPlacement: TPoint; Font: string; Colour: TColor);
var
I, B, H, Pic, TPH, Numb: Integer;
Offset: TPoint;
TTP: TPointArray;
Canvas: TCanvas;
begin

if (not SMART_DebugSetup) then
SMART_SetupDebug();


TPH := High(TP);

Offset := IntToPoint(TxtPlacement.x - BmpPlacement.x, TxtPlacement.y - BmpPlacement.y);

Pic := CopyBitmap(Bitmap);

for I := 0 to TPH do
begin

TTP := LoadTextTPA(TP[i], SmallChars, H);

for B := 0 to High(TTP) do
begin

Numb := ((I + 1) * 13);

if Shadow then
try

FastSetPixel(Pic, TTP[b].x + 1 + Offset.x , TTP[b].y + Numb + 1 + Offset.y,131072);
except
end;

try

FastSetPixel(Pic, TTP[b].x + Offset.x, TTP[b].y + Numb + Offset.y, Colour);
except
end;
end;
end;

Canvas := TCANVAS.Create;
Canvas.Handle := SmartGetDebugDC;
DrawBitmap(Pic, Canvas, BmpPlacement.x, BmpPlacement.y);
FreeBitmap(Pic);
end;

Function PickupCharms:Boolean;
Var
X, Y: Integer;
begin
FindNormalRandoms;
If FindCharms(X,Y) Then
Begin
writeln('You have found the some Charms!');
While IsMoving do
Wait(50);
FindNormalRandoms;
Wait(RandomRange(300,400));
End;
end;

//credits to Flight
Function FindGhoul(Var X,Y: Integer): Boolean;
var
CTS,I,T: Integer;
TPA: TPointArray;
begin
repeat
Result := False;
CTS := GetColorToleranceSpeed;

ColorToleranceSpeed(2);

SetColorSpeed2Modifiers(0.20, 1.60);

FindColorsSpiralTolerance(MSCX, MSCY, TPA,(11652298), MSX1, MSY1, MSX2, MSY2, 8);
ColorToleranceSpeed(CTS);

if (Length(TPA) < 1) then
Exit;

MMouse(TPA[0].X, TPA[0].Y, 5, 5);

if WaitUpText('ck Gho', 50) then
begin
GetMousePos(X, Y);
ClickMouse2(True);
Result := True;
If DidRedClick then
MarkTime(T);
Repeat
wait(2 + Random(10));
Until Infight or (TimeFromMark(T) > 5000) ;
Begin
Inc(Kills);
End;
repeat
DoThePainting;
until Not(InFight)or (not OthersInFight) or (not LoggedIn);
Exit;
end;
Until(Result)
end;

procedure GetOutF;
begin
case random(2) of
0 : begin
KeyDown(VK_Tab);
wait(35+random(100));

wait(35+random(100));
KeyUp(VK_Tab);
wait(25+random(70));

wait(35+random(100));
end;
1 : begin
ExamineInv;
end;
end;
end;

procedure GMoveMouse;
begin
case random(4) of
0 : begin
mMouse(5,25,10,20);
end;
1 : begin
mMouse(250,150,40,40);
end;
2 : begin
mMouse(505,350,50,50);
end;
3 : begin
mMouse(30,315,20,40);
end;
end;
end;

Procedure RAntiBan;
begin
Wait(randomrange(200,400));
case random(RandAmount) of
0 : begin
writeln('Random Wait AntiBan');
Wait(randomrange(1100,2500));
end;
1 : begin
GAntiBan;
end;
2 : begin
writeln('pickup mouse / GMoveMouse');
PickUpMouse;
Wait(randomrange(25,100));
GMoveMouse;
Wait(randomrange(250,300));
end;
3 : begin
writeln('Double GMoveMouse');
GMoveMouse;
Wait(randomrange(45,100));
GMoveMouse;
end;
end;
end;
//Laakes

procedure KillGhouls;
var
sX,sY,X,Y: Integer;
label
fighting;
begin
If FindGhoul(X,Y) Then
writeln('You are ghouling this ghoul');
fighting:
While IsMoving do
MarkTime(T);
wait(1);
FindNormalRandoms;
if FindBlackChatMessage('omeone else is fighting') then
begin
writeln('Someone else may be doing the same as you!');
case random(4) of
0 : begin
sX := MSX1;
sY := MSY1;
end;
1 : begin
sX := MSX1;
sY := MSY2;
end;
2 : begin
sX := MSX2;
sY := MSY1;
end;
3 : begin
sX := MSX2;
sY := MSY2;
end;
end;
If FindGhoul(X,Y) Then
GetOutF;
goto fighting;
end else
begin
if InFight then
begin
repeat
DoThePainting;
FindNormalRandoms;
Eat('Eat');
RAntiBan;
until (not InFight) or (not OthersInFight) or (not LoggedIn)
end;
wait(randomrange(200,300));
end;
end;
procedure Startup;
begin
Smart_Server := SWorld;
Smart_Members:= true;
Smart_Signed := true;
Smart_SuperDetail := false;
SetupSRL;
RandAmount := 30;
MSpeed := 200;
DeclarePlayers;
LogInPlayer;
MouseSpeed := MSpeed;
wait(100+random(100));
end;

begin
Startup;
SetupChar;
LoadBMP;
LoadVars;
repeat
ToGhouls;
repeat
DoThePainting;
KillGhouls;
begin
PickupCharms;
end;
until (hppercent<50);
ToBank;
Proggy;
OpenBankNPC;
if BankScreen then
begin
DoThePainting;
DepositAll;
wait(50 + Random(250));
DoThePainting;
Withdraw(0, 0, 28);
wait(50 + Random(250));
DoThePainting;
Deposit(1,1,false);
wait(50 + Random(250));
DoThePainting;
CloseBank;
end;
FindNormalRandoms;
until not LoggedIn
writeln('stopping script');
Proggy;
TerminateScript;
end.


Here is a pic of the GUI in game as requested a newer one just taken of my acc running on it as i got home 2 hours ago after a 5 day trip and just edited and reuploaded my script so its running now! :)

Sin

2012-02-05 18:43:14

It hasn't been a month :l

laakerules

2012-02-05 18:47:17

Its a month? :O i was told a week before.

Where i was told try again in a week

Sorry if its a month wait. You can delete if it is, my bad.

Sin

2012-02-05 18:49:24

Your last one was on the 29th :s
http://villavu.com/forum/showthread.php?t=73181

laakerules

2012-02-05 18:50:45

Look at edit of post ^^^^ sorry if its a month.

[XoL]

2012-02-05 18:51:43

Can you take another picture? I mean that one really doesn't prove much :P, besides your disable button works well.

Sin

2012-02-05 18:51:57

That's alright, it's still a yes from me :P

laakerules

2012-02-05 18:58:48

Okay Sweet, and R4ndom i just uploaded a new pic of it that i just took!:)

Edit: Okay i see i already have 3 no's, if your going to say no please post why your saying no so i can improve!

Sin

2012-02-05 20:17:41

I forgot to vote Yes >.>

[XoL]

2012-02-05 20:20:48

Well your attitude seems like it improved dramatically from the last time :) I will remain silent from here on, I just wish you waited a little longer before applying again (Even though someone said it was okay).

laakerules

2012-02-05 20:51:41

Okay thanks random, only reason i was sour last time is i saw someone with only a m1d1 get member then i improved my script sooooo much and i got more no's and less yesses in less time from my earlier version.

DemiseScythe

2012-02-05 21:02:26

You seem mature and that is a nice script, lots of good techniques applied correctly, I see a lot of failsafes and that is a nice Paint, you got my yes =)

EDIT:

Combat is difficult to script, I am proud you choosed combat instead of some bs Runecrafter or some collecting script. Regardless of the outcome, I am proud of you. There just some people who vote no for voting no instead of actually looking at what is being posted. I know you posted before it was time but at least you posted a revised/upgraded script. Other people who apply within limit, apply with unworthy material. Your stuff is good, I am impressed at the charm looting.

EDIT: EDIT:

To those voting no, at least have a good reason for voting no, just dont vote no for the sake of it.

R0b0t1

2012-02-05 21:16:17

HEY, YOU. YEAH. I KINDA LIKE YOU. I FIGURE I'LL ACTUALLY VOTE YES ON THIS ONE.

ALSO, YOU HAD 404 POSTS WHEN I SAW THIS THREAD. I THOUGHT THAT WAS FUNNY. a

DemiseScythe

2012-02-05 21:18:04

More than me and 1 less month than I have been here. Haven't seen spammy posts from him so that proves he is actively involved in the community.

laakerules

2012-02-05 21:23:01

Thanks for the input good or bad guys. :)

Scaper

2012-02-05 21:27:49

Yes as always from me :)

Sin

2012-02-05 21:31:14

From: DemiseScythe
You seem mature and that is a nice script, lots of good techniques applied correctly, I see a lot of failsafes and that is a nice Paint, you got my yes =)

EDIT:

Combat is difficult to script, I am proud you choosed combat instead of some bs Runecrafter or some collecting script. Regardless of the outcome, I am proud of you. There just some people who vote no for voting no instead of actually looking at what is being posted. I know you posted before it was time but at least you posted a revised/upgraded script. Other people who apply within limit, apply with unworthy material. Your stuff is good, I am impressed at the charm looting.

EDIT: EDIT:

To those voting no, at least have a good reason for voting no, just dont vote no for the sake of it.

Glad we can agree on something :p

Kyle Undefined

2012-02-05 23:47:32

Voting no, not because of the scripts, but because your "oh poor me" act you pulled on your last app.

laakerules

2012-02-05 23:52:28

Okay thanks for that input Kyle, that will help me out in the future! :)

For all the other people voting no, can you please post a reason Like Kyle Did, that would be much appreciated since i like to improve myself, and if theres a no without a reason i feel like you just hate me! :) so please help me out and tell me what im doing wrong.

Mat

2012-02-06 12:39:23

Yes.

laakerules

2012-02-06 12:45:45

Thanks mat! I appreciate commenting after you vote! :)

PatDuffy

2012-02-06 21:01:27

I am inclined to vote yes because you finally show the knowledge of scripting I look for and because I feel you want to become a Member for the right reasons…..but because of this:

From: Kyle Undefined
Voting no, not because of the scripts, but because your "oh poor me" act you pulled on your last app.


I am not going to vote on this application. I feel I cannot make a confident choice whether to vote Yes or No.

You are going in the right direction, but it is too soon after that incident to forget about it. It might have been a genuine mistake in the heat of the moment, but it showed a slight immaturity that you still must prove was untrue to your nature. I know you are the type of person that will take this experience and grow from it, I have seen it from your activity of recent.

I knew when you acted out after your last app that you would be back, and I am glad I was correct. I know in the future, you will become a member, but your time has not yet come. I hope in the coming month wait before your next application we will see more positive things from you, you are showing a knack for fighting scripts that I like :)

laakerules

2012-02-06 21:06:18

From: PatDuffy
I am inclined to vote yes because you finally show the knowledge of scripting I look for and because I feel you want to become a Member for the right reasons…..but because of this:



I am not going to vote on this application. I feel I cannot make a confident choice whether to vote Yes or No.

You are going in the right direction, but it is too soon after that incident to forget about it. It might have been a genuine mistake in the heat of the moment, but it showed a slight immaturity that you still must prove was untrue to your nature. I know you are the type of person that will take this experience and grow from it, I have seen it from your activity of recent.

I knew when you acted out after your last app that you would be back, and I am glad I was correct. I know in the future, you will become a member, but your time has not yet come. I hope in the coming month wait before your next application we will see more positive things from you, you are showing a knack for fighting scripts that I like :)


Thanks, this is the feedback i like to see. And thanks for not voting rather than voting no. Also, im working on skill scripts atm! :) so well see how those turnout, and im doing alot of java coding while working on this! :)

Griff

2012-02-06 21:10:32

Well, in the week that has passed between this and your last app, you seem to be a whole different person. The script is good, attitude improved, I'm going to vote yes.

laakerules

2012-02-06 22:03:16

From: Griff
Well, in the week that has passed between this and your last app, you seem to be a whole different person. The script is good, attitude improved, I'm going to vote yes.


Thanks Griff, i am currently working on a RougesDen Script that opens and cracks the safe for Small money Gems and XP! :)

So far its cracking safes and eating once below certain HP, also working on creating a walking type while down there. Kinda crappy walking but it sets clicknorth(0); and then from safes moves mouse to a new pos and clicks! :P then finds banker Then moves mouse to certain pos and clicks there! :P

Sin

2012-02-06 22:04:37

Caman guys let him in!
He's beating it!

laakerules

2012-02-08 11:35:45

Thank you all for your input, I will work harder for my next app as I don't think I will make it this time! :) and thanks for votig and comments! :)

Edit: whoops sorry for double post guys I'm on my iPhone and didn't know I already ha posted! :/

DemiseScythe

2012-02-08 11:41:05

Your application is close to 50:50

That means an Admin will decide if you make it into members or not, you just need to wait for a while until the poll closes and the admin makes his decision, for now keep working on your scripts and don't worry about it.

laakerules

2012-02-08 11:42:57

Admins make the decision? :0

I thought it was all based on votes. Is there a way I can delete the stupid double post error I made? :duh:

Edit:nvm I found out where it is.

-laakes iPhone

DemiseScythe

2012-02-08 12:04:52

They only do it if the amount of Yes and No votes are close to eachother, otherwise it is based on the majority of votes

laakerules

2012-02-12 00:48:42

Put up my CraftingGuild script since that one is flawless and gets good xp with multiple showing of different skills including the new function that i created! :)

KingKong

2012-02-12 18:03:55

No. You call SPS_Setup every single time you walk somewhere. Not enough advanced stuff like ATPA's(your TPA methods aren't that good), and you don't have any failsafes.

laakerules

2012-02-12 18:20:03

From: KingKong
No. You call SPS_Setup every single time you walk somewhere. Not enough advanced stuff like ATPA's(your TPA methods aren't that good), and you don't have any failsafes.


Thanks for responding and giving me a headsup on what to do for next app. But i did sense a little bit of sour attitude of you thinking your the best! :)

Anyways thanks, and i will be releasing my Blood Pact Quester for COLOR In a lil, you may want to check it out since you did a reflection version! :)

masterBB

2012-02-12 19:09:41

Okay, here is my critics on the entire first script, don't take it too hard. :

You wrote:
Procedure XPcalcT;
Begin
XPT := (URNS*81);
End;

Unclear procedure name. And could be better be a function. For example:
function GetUrnsXP:integer;
begin
result := URNS * 81;
end;

You wrote:
Procedure XPhour;
Begin
XPcalcT;
XPH := Round((XPT * 3600) / (GetTimeRunning / 1000));
End;

Same story as with the previous procedure. I also think they could be merged. But this could be (with 2 functions):
function GetXpHour: Integer;
begin
result := Round((GetUrnsXP * 3600) / (GetTimeRunning / 1000));
end;

You wrote:
procedure SetupChar;
begin
SetupSRL();
SetAngle(0);
ClickNorth(0);
end;

Now this isn't bad. There is nothing wrong with this procedure. But it would be cool if you added some failsafes in it, like CheckPickaxe or something. It isn't required but it is an easy place to score a point.

You wrote:
procedure Proggy;
begin
XPHour;
XPcalcT;
ClearDebug;
Writeln('*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*');
Writeln('* \*|_/\Crafting Guilder/\_|*/ *');
Writeln('*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*');
Writeln('You have Finished ' + IntToStr(Urns) + 'Urns');
Writeln('And have Gained ' + IntToStr(XPT) + 'EXP');
Writeln('And have Gained ' + IntToStr(XPH) + 'XP/H');
Writeln(' Ran for ' + TimeRunning + 'Time');
Writeln('*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*');
end;

There is of course not much to say about the progress report procedure. But this is how it would look if you added those first two functions:

procedure Proggy;
begin
ClearDebug;
Writeln('*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*');
Writeln('* \*|_/\Crafting Guilder/\_|*/ *');
Writeln('*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*');
Writeln('You have Finished ' + IntToStr(Urns) + 'Urns');
Writeln('And have Gained ' + IntToStr(GetUrnsXP) + 'EXP');
Writeln('And have Gained ' + IntToStr(GetXpHour) + 'XP/H');
Writeln(' Ran for ' + TimeRunning + 'Time');
Writeln('*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*');
end;

You wrote:
procedure Startup;
begin
Smart_Server := 69;
Smart_Members:= true;
Smart_Signed := true;
SetupSRL;
DeclarePlayers;
LogInPlayer;
MouseSpeed := 500;
wait(100+random(100));
end;

There is nothing wrong with this procedure except for its placement. Why is it so high? I believe it's only called once so could be placed in the bottom begin…end., but a procedure is cool too.

You wrote:
function Walking(Color, Tolerance: Integer; SortFrom: tpoint): Boolean;
var
i, x, y, rx, ry: Integer;
TPA: TPointArray;
begin
if not LoggedIn then Exit;
FindNormalRandoms;
FindColorsSpiralTolerance(MMCX, MMCY, TPA, Color, MMX1, MMY1, MMX2, MMY2, Tolerance);
SortTPAFrom(TPA, SortFrom);

for i := 0 to High(TPA) do
begin
x := TPA[i].x;
y := TPA[i].y;

rx := RandomRange(-1, 1);
ry := RandomRange(-1, 1);
if (not rs_OnMinimap(x + rx, y + ry)) then
Continue;

Mouse(x + rx, y + ry, 0, 0, true);
FFlag(0);
Wait(200 + Random(500));
Result := True;
Break;
end;
end;

I really neat looking function. It actually works really nice and the flow is understandable. I believe there is only one thing that could be optimized but I'm not sure if it's the same, getting rid of the SortTPAFrom:
FindColorsSpiralTolerance(SortFrom.x, SortFrom.y, TPA, Color, MMX1, MMY1, MMX2, MMY2, Tolerance);

You wrote:
Function FindObjOnScreen(Color,Tolerance:Integer;MC2:Variant): Boolean;
var
X,Y:Integer;
CTS,I,T: Integer;
TPA: TPointArray;
begin
repeat
Result := False;
CTS := GetColorToleranceSpeed;

ColorToleranceSpeed(2);

SetColorSpeed2Modifiers(0.50,1.00);

FindColorsSpiralTolerance(MSCX, MSCY, TPA,(Color), MSX1, MSY1, MSX2, MSY2, Tolerance);
ColorToleranceSpeed(CTS);

if (Length(TPA) < 1) then
Exit;

MMouse(TPA[0].X, TPA[0].Y, 5, 5);
begin
GetMousePos(X, Y);
ClickMouse2(MC2);
Result := True;
Exit;
end;
Until(Result)
end;

Standards, this is almost unreadable. A difference of day and night with the previous function. A begin and end; with no reason. And unless the length of TPA is less then 1, this function will return true….

You wrote:
 procedure ToWater;
Var
myPath:TPointArray;
begin
SPS_Setup(RUNESCAPE_SURFACE,['8_8']);//SPS Areas
myPath := [Point(3590, 3522), Point(3579, 3533), Point(3572, 3540)];
SPS_WalkPath(myPath);
SetAngle(0);
Repeat
Wait(50);
until (not IsMoving);
end;

Global path array would be so nice, but that's just for the extra point. I don't understand what the setAngle has to do with this procedure. Also there is an infinity loop…:
function ToWater:Boolean;
var
myPath:TPointArray;
i:Integer;
begin
SPS_Setup(RUNESCAPE_SURFACE,['8_8']);//SPS Areas
myPath := [Point(3590, 3522), Point(3579, 3533), Point(3572, 3540)];
result := SPS_WalkPath(myPath);
if(result) then
repeat
inc(i);
Wait(50);
until (not IsMoving or i > 100);
end;

You wrote:
procedure ToSpinner;
procedure ToFire;
procedure ToRocks;

Should all be one function, you repeat the same code three times in a row.

You wrote:
Procedure MakeSoft;
Var
X,Y:Integer;
Begin
InvMouse(1, 1);
Wait(250 + Random(25));
FindObjOnScreen(16625804,5,True);
Wait(2000 + Random(25));
MMouse(250, 425, 10, 10);
ClickMouse2(True);
End;

This should be a function, how else would you know if it succeeded?

You wrote:
Procedure MakeUrns;

Idem dito.

You wrote:
Procedure MakeUrnsF;
Begin
InvMouse(1, 1);
Wait(1000 + Random(25));
FindObjOnScreen(4673664,1,True);
Wait(2000 + Random(25));
MMouse(250, 430, 0, 0);
ClickMouse2(True);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
Inc(Urns);
End;

No function, no failsafes and no clear function name. This isn't a great procedure. And btw:
IncEx(Urns,16);
or
Urns := Urns + 16;

You wrote
Procedure DoCrafting;
Begin
ToWater;
MakeSoft;
Wait(38000);
ToSpinner;
MakeUrns;
Proggy;
Wait(20000);
ToFire;
MakeUrnsF;
Proggy;
Wait(60000);
DropAll;
ToRocks;
Proggy;
Wait(1000);
end;

If you made them all functions this could look so much cooler :(. But if ToSpinner fails it will just continue… And waits are static…

You wrote:
Procedure MineClay;
Var
X,Y:Integer;
Begin
If InvFull Then Exit;
repeat
FindObjOnScreen(9295101,10,True);
If InvFull Then Exit;
Wait(2000);
FindObjOnScreen(9295101,10,True);
If InvFull Then Exit;
Wait(2000);
Until InvFull Exit;
End;

No function, bad standards and no fail safes.

laakerules

2012-02-12 19:19:58

Thanks man, now this is what i need! :) and for the findobjonscreen! :P that was my beta one that i started with and have imporved much on it! :) as in my tut! :P

KingKong

2012-02-12 23:19:26

From: laakerules
Thanks for responding and giving me a headsup on what to do for next app. But i did sense a little bit of sour attitude of you thinking your the best! :)

Anyways thanks, and i will be releasing my Blood Pact Quester for COLOR In a lil, you may want to check it out since you did a reflection version! :)


Nope, no attitude on my part. I only told you what was wrong with your app. :sasmokin:

laakerules

2012-02-12 23:47:42

From: KingKong
Nope, no attitude on my part. I only told you what was wrong with your app. :sasmokin:



Ahh kay, :duh: hopefully if u don't get some miracle this time on my third app I will improve! :)

Markus

2012-02-23 12:47:16

It's more like 40/60 now, unfortunately closed. Try again in a week or so.

Hobbit

2012-02-23 12:49:25

Close but not quite close enough!

Please apply again in 2 weeks :)