From: Kyle Undefined
Voted no because you re-wrote a lot of the SRL include. Being an SRL Member shows you have knowledge of the include. I like your script, and I like your personality, but it just doesn't meet Member quality (IMO). Sorry.
I didn't realize how important it was to show my understanding and knowledge of SRL. I guess I should have, applying for A "SRL" membership and all. I already explained why I didn't use alot of SRL functions and used my own. But, I do understand what your saying tho. If I fail this round, which by the looks of it I will, I will submit a better SRL script next time. I do have a better understanding of SRL then you guy believe. I just like the idea of using my own stuff. One reason is, if an rs updates occurs and it breaks something. Users of my script don't have to wait for SRL to be fixed. I can go into it and fix it my self. I can do this with srl too, I know, but for the newbs that don't know much about scripting might have a hard time doing that. So by my reasoning, I figured my way was better for the users. Also I have a simplistic way of doing things and I believed it would be a good way for new scripters to learn from my script. But I do understand that submitting a script, lacking in SRL, to become a member of SRL was a bad idea.
From: superuser
Voted no because I don't find your code that well written. Small things like I'm very old-school programmer, so for instance I really don't like when you define functions in this way:
procedure This_Is_My_Function;
It should be
procedure ThisIsMyFunction();
The code itself is not readable. Very messy. Bad indenting. Bad naming convention. To me all that shows you have no general basic understanding over programming, hence no.
Sorry for being harsh.
Not being harsh at all. I asked for it. ;) I have an explanation tho for the Open_bank naming. When writing a script I sometimes come across a global variable or Name that is already being used by srl. For example. When I made a procedure to open the sw bank. I wanted to call it "OpenBank". I suppose I could have chosen OpenB, or OpenChest, or any other variation. I know that SRL already has a function named OpenBank, but sometime I run across one that I don't know about. So to save me time on have to go back and change dup identifiers, I use the "_" to add some uniqueness to it. This way there is no chance of dup identifiers. Maybe this is bad practice but you are the first in years of scripting to say so.
and about this part:
The code itself is not readable. Very messy. Bad indenting. Bad naming convention. To me all that shows you have no general basic understanding over programming, hence no.
I will admit this script needs alot of cleaning up. I'm only now just getting done with it. There are if statements where there should be case statements. There is whole functions that could be removed with changes to another, etc. This is stuff I all plain on doing in the near future. I basically threw this together as quick as I could. And test what works and what didn't, adding stuff , taking away, adding more, etc. Things got put in there that wasn't suppose to be or misplace, cause I was tired and it was 3 in the morning. Just stuff like that. I still can't figure out why my bmps are stacking. It uses the same variables to store bmps all through out the script. Depending on whats being made there should be at most 5 open bmps. So to sum it up I am aware this is far from a completed script. I just work alot and use all my free time to work on this script.
The indenting? What are you talking about I am using the Official Standard, I thought.
http://villavu.com/forum/showthread.php?t=3293&highlight=officialI am completely self taught, so please give me a little of a break. I am kinda of a loner and the rw friends I do got, have no interest in programming let alone computers. I didn't go to no school. Hell I didn't even graduate, I got my GED.
I only applied for a few reasons. One, I thought I might in someway get to help more and learn new things. Two, I'd like access to the black market because I figured that would be that safest place to buy rs gold. And three I plan on being here awhile(active), so I wanted to set up a avatar. I don't NEED SRL membership. I see it as SRL needs me. I script on my own just fine. I don't need to be a leacher. So what I'm saying is, there is no hard feelings and if I don't make it today there is always tomorrow.