SRL Archive - RS3 Outdated / Broken Scripts

How to fix banking error! (Deposit money pouch)


lostprophetsown

2012-01-04 12:58:53

Hey guys, this is just a simple tutorial to help people who are struggling to auto due to the recent update which has placed the deposit money pouch button in place of the deposit all button.

EDIT: I've uploaded the updated bank.scar file to replace the original one with. Feel free to check through the code, as there isn't anything malicious about it :)

To fix this, follow this guide I have quickly created:





The code you will need to replace the depositAll feature with is this:

function DepositAll: Boolean;
var
T, X, Y: Integer;
BScreen, DScreen: Boolean;
begin
Result := false;
BScreen := BankScreen;
if (not(BScreen)) then
DScreen := DepositScreen;
if (BScreen) or (DScreen) then
if (InvCount > 0) or (FindColor(X, Y, srl_outline_black, 98, 68, 436, 257) and (DSCreen)) then
begin
Mouse(360 - 50 * Integer(DScreen), 305 - 30 * Integer(DScreen), 15, 10, True);
Wait(200 + Random(300));
T := GetSystemTime;
while (InvCount > 0) or (FindColor(X, Y, srl_outline_black, 98, 68, 436, 257) and (DSCreen)) and (GetSystemTime - T < 2000) do
Wait(100);
Result := (InvEmpty) or (not(FindColor(X, Y, srl_outline_black, 98, 68, 436, 257)) and (DScreen));
end else begin
srl_Warn('DepositAll', 'No items to deposit ', warn_AllVersions);
result := true;
end;
end;


EDIT: Some people are struggling with following the tutorial so I've uploaded the updated bank.scar file. Can someone scan through it to confirm it's fine? Thank you.

I hope I helped, thanks again :)

YoHoJo

2012-01-04 13:00:02

=D Nice quick fix to stop all the noobs from asking.
SRL should be updated with a fix soon too! Thanks for the help.
Lol glad to see a new guy like you actually HELPING!

lostprophetsown

2012-01-04 13:02:46

Yeah, I'm expecting scripts to be filled with spam, and it's rather annoying they can't search as I came across this fix almost instantly.
And I can't really take much credit, I only spent 10 minutes making the tutorial, it was actually Kyle that had the fix:

http://villavu.com/forum/showthread.php?t=71061

Kyle Undefined

2012-01-04 13:04:36

Very nice! :D This will help a lot!

TkrZ

2012-01-04 13:24:12

Damn, was hoping I could learn simba a little better by bringing it upon myself to fix it, but I found this tutorial and couldn't help myself, anyways, thanks for the fix! :D

Also, yet another amazing reason to use Simba! If this was RSBot or anything of such, you would have to wait for days for an update! :D

Jamestt

2012-01-04 14:00:42

Hmm, good work and thank you. Been saying if the money pouch was there, hehe. Thanks and Good job at learning Pascal :)

lostprophetsown

2012-01-04 14:02:40

From: Kyle Undefined
Very nice! :D This will help a lot!


No, thank you, as you were the one with the fix :)

Glad it's helping people though :P

lostprophetsown

2012-01-04 14:07:16

From: IRobot335
Damn, was hoping I could learn simba a little better by bringing it upon myself to fix it, but I found this tutorial and couldn't help myself, anyways, thanks for the fix! :D

Also, yet another amazing reason to use Simba! If this was RSBot or anything of such, you would have to wait for days for an update! :D


Always much more convenient to take the easier alternative :P
And yeah, plus you'd be getting 'trolled' by everyone, because they're all pro scripters and know everything, so you don't deserve to be helped.
There's honestly a far better community here, I'm glad it's not too overfilled with people either.

chelmid

2012-01-04 14:33:54

I didn't get it to work.

lostprophetsown

2012-01-04 14:42:26

From: chelmid
I didn't get it to work.


I've uploaded the updated bank document if you need it :)
Just download and save over the old file.

begginer

2012-01-04 14:56:53

This should be kind of announcement. Then no-one will have to post threads or ask about banking

Shuttleu

2012-01-04 14:58:21

srl 5 has already been updated with my fix

if you use srl 5 then just re download it and you will be fine

~shut

lostprophetsown

2012-01-04 15:14:00

From: Shuttleu
srl 5 has already been updated with my fix

if you use srl 5 then just re download it and you will be fine

~shut


Ahh right, cheers for the heads up :)

Giant Panda

2012-01-05 06:01:43

Thank you very much :)

Hello World..

2012-01-07 07:04:06

Great, very..

Kresh

2012-01-07 07:10:17

doesent do anything, this is included in the last srl5 update so its not needed anymore,
its up to the script creators to update to SRL5 now, as if its not updated, they will get an error saying Exception in Script: Unable to find file 'SRL/SRL.scar' used from ''

Gark

2012-01-08 05:46:16

Not working to me