SRL Archive - RS3 Outdated / Broken Scripts

AutoCooker


Jason2gs

2007-03-15 19:05:24

First off, what the heck is "AutoColor"? Does that mean you don't have to type in your own colors? I got that, then :p

I assume Alpha means the first of it's series… Beta means it's not been tested before… So what's "Release"? Doesn't matter…

Anyways, I made this at the request of Dunceiam. I havn't tested it yet, due to the fact that I have no food. :p But I'm sure it works like it should ;)

New version out. Just ironed out some bugs. Still has a lot of work.

It's the first time I've ever used an item counter, so that's kinda neat. It's also the first time I've made a color finder turn the camera after trying to find the color a few times in a script [that's good enough for release].

Post any bugs you find!!!

I can't stress this enough.

I release script. You test script. You post bugs. I make next script better.

Sound good? K :p

Anyways. Start off here:



(That's Edgeville Bank BTW)

And put yo' food in the first bank space. K? Cool.

Dunceiam

2007-03-15 19:14:43

Alright, thanks again Jason2gs…:D

Right now my bro's on the computer, so I'll test it out when he's off…

Thanks!
-Dunceiam

Bobarkinator

2007-03-15 19:28:11

Did you specifically not use MakeCompass('') here?
  begin
KeyDown(37);
Wait(1000 + Random(500));
KeyUp(37);
end;

procedure TheWalkTo;
begin
MakeCompass('N');
if(FindSymbol(x, y, 'Cook'))then
begin
Mouse(x, y, 2, 2, True);
FindTalk;
Wait(5000 + Random(5000));
FindTalk;
end;
end;
You could change to
procedure TheWalkTo;
begin
MakeCompass('N');
if(FindSymbol(x, y, 'Cook'))then
begin
Mouse(x, y, 2, 2, True);
While (FlagPresent) do
FindTalk;
end;
end;
Just some suggestions. You don't have to use them

Ejjman

2007-03-15 19:51:09

Lets see here.

1: TheOpenBank;
- The color may be accurate, but it may not. Try using deformed bitmaps of some sort.
- If this script gets the variable Tries up to 5, it would hold down the key 37 for 1 second, then key up. But, it is still set as 5, so, it will do it again…and again…and again…over and over. Try adding a time limit, or add Tries := 0 in that begin end; loop in there.
- Possibly, for IsUpText, try IsUpTextMulti, which I prefer, because it can sometimes find it better IMO.

2: TheBank;
- To me, this is a pointless procedure. Why not increase the run speed, and add this in your other proc(s) to make this an easier to read script? All the stuff packed perfectly into one or two procs is very awesome.

3: TheWalkTo;
- As I look at this, it screams failsafes. Sometimes the symbol isn't exactly on the places, such as the bank symbol slightly outside the bank. Might wanna make a failsafe for this, as I'm trying to figure out one.

4: TheDoor1;
- Read my feedback on TheOpenBank; procedure.

5: TheCook;
- Maybe try making a better little procedure, possibly.
- The case random of 6 '111' '222' '333' '444' '555' '666', try adding something like TypeSend(IntToStr(28+random(400)); if you really wanna get techical. But still, most people just type the number they have, I know I type 29 every time.
- repeat wait(2000) until items = 0. Thats like holding a card in your hand and saying wait until it floats. It will never. << I might be wrong on this I'm a little off. Or wait, do this. until (CountItemColorTol(Color, 5) <= 0); understand?

6: TheDoor2;
- Read my feedback on TheDoor1; procedure.

7: TheWalkBack;
- Unless you really ahve solid coordinates, the map changes a bunch, and along with symbols and blah blah. This probably wont work unless you've got something really good.

[BANANA]
Skipped loop, don't wanna look, your antirandoms I guess look fine, and TheLoadsPerPlayer; I don't see anything that I can think of though I'm kinda not thinking right now.[/BANANA]





I really hope you take my stuff into consideration, and just know, your the only person I've ever done this for. Feel good, probably cuz I'm watching Cinderella 3 possibly. Anyway, have fun!

-Ejjman1

Jason2gs

2007-03-15 19:51:25

For the first code you posted, yes. I ment to leave MakeCompass out. I wanted it to turn the camera slightly to find the color if it (if it didn't find it the first time).

For the last code/suggestion. I'll probably use that :)

I've never used While…Do before.

@ Ejj

Thanks for your feedback, mate :)

I put everything into different procedures like that because I find it easier to script if I set up everything like this ahead of time:


procedure proc1;
begin
end;

procedure proc2;
begin
end;

procedure proc3;
begin
end;

Etc…

I didn't realize that about the Tries being 5 after you move on. I'll have to fix that.

As for TheWalkTo;, I know lol. I didn't set the procedure up very well, it still needs some [a lot] of work. I'll fix it later on.

As for TheCook;, I didn't think of making 28 + Random(xxx), that's a really good idea. I just remember from when I used to cook a lot, typing in like 123 or 444 or somethin' ;)

TheLoadsPerPlayer. I was quite fond of the way I sent that up :p I'm not very good with forms yet, so I thought of ReadLn as a shortcut of sorts :p

I do feel all special for this :p Thank you :)

Ejjman

2007-03-15 20:13:15

@Jason2gs with the LoadsPerPlayer thing, I didnt find out with ReadLn was till like, a week ago. I never used it lol, but it does help rather than consts in a way. :)

Dunceiam

2007-03-15 20:17:38

Alright, just tried it out…

Line 219: [Error] (17880:31): Type mismatch in script C:\Program Files\SCAR 2.03\Scripts\Auto-Cooker.scar

Line 219 is…if(LoadsDone >= LoadsPerPlayer)then

Any ideas?
-Dunceiam

Jason2gs

2007-03-15 20:44:46

Type mismatch…


if(LoadsDone >= StrToInt(LoadsPerPlayer))then

That works. ;)

Edit: But with this many errors (just read up), I don't suggest using this script without supervising it.

the scar noob

2007-03-16 07:21:24

uhm peopl ei've got a suestion, uhm the typesend from SRL doesn't types numberes for me, is this normal? Do you guys have got this to??

Jason2gs

2007-03-16 12:33:46

123456789


program New;
{.include SRL/SRL.Scar}
begin
Wait(5000);
TypeSend('123456789');
end.

Works for me, mate ;)

JAD

2007-03-16 17:24:51


if(LoadsDone >= StrToInt(LoadsPerPlayer))then
should be/could be

if(LoadsDone > StrToInt(LoadsPerPlayer))then
I saw somebody had an error with that, and I think my way without the = sign is the proper way :) I'm not sure though. good work though, keep it up.

TheGodfather

2007-03-16 19:27:06

Great looking script, planning to test sometime.

Jason2gs

2007-03-16 22:56:27

From: JAD

if(LoadsDone >= StrToInt(LoadsPerPlayer))then
should be/could be

if(LoadsDone > StrToInt(LoadsPerPlayer))then
I saw somebody had an error with that, and I think my way without the = sign is the proper way :) I'm not sure though. good work though, keep it up.


Mine will check to see if LoadsDone is equal to or higher than LoadPerPlayer.

Yours will just check and see if it's higher. ;)

JAD

2007-03-17 01:30:12

Oh, :p my bad, thanks for making me feel like such an idiot too :p

Dunceiam

2007-03-17 22:29:25

Alright, tried it again. This time, it logs in, opens bank, removes 28 shrimp. And then it stops with the bankpage still open. Even if you assist it and close the bank page, still doesn't do anything. But from the 10 seconds of work it did, it looks pretty good :p

-Dunceiam

Wuffel

2007-03-18 09:14:19

From: Dunceiam
Alright, tried it again. This time, it logs in, opens bank, removes 28 shrimp. And then it stops with the bankpage still open. Even if you assist it and close the bank page, still doesn't do anything. But from the 10 seconds of work it did, it looks pretty good :p

-Dunceiam


^^_ Same and in the diolog box it says Random found :P:f:

Jason2gs

2007-03-18 19:39:40

Ah dangit :(

I'll have to get some food later and test it out.

Edit: Just replaced the old version with the new version. I just ironed out some bugs, but it should be better.

BTW:

The reason it didn't close the bank last time, was because I forgot to add "CloseBank" lol

rocky 123

2007-03-23 22:12:08

Hey, it seems pretty good, but theres one thing

Every time i get to the stove, the mouse hovers over the fish, but does not click on it, and then hovers over the stove, as if clicking, but dosnt have a fish selected to use on it

I tried it quite a few times

baracoudaking

2007-04-01 12:23:24

yes me to same as rocky

gsquare567

2007-04-11 20:37:42

change line 105 to
MouseItem(1,true);

see, if u know to program then using scripts is so much easier!
great script bro. now try fitting in some error handling if u can.

Shockwave

2007-05-07 13:34:01

looks great ill test l8er ty

yoctown

2007-05-08 18:24:25

goes to cook and same problem and what do u mean change line 105 line 105 has nothing on it and if i put what u told me to put there it wont even run also i looked through the script and i cant figure the problem out.. my guess is it moves over x,y but doesnt click cuase because even if he did mix up click true and false it would right click it so i guess u gotta add a click somehow i dunno about this new scar before i woulda just added a clickmouse somewhere but its probably a new command now im gonna go look it up see if i can figure out how to fix this one

haz3

2007-05-13 23:12:41

^ ok leecher, ctrl + f and ctrl + v what the guy said(the line of code) and then it will find it for you and change it.

3Garrett3

2007-05-14 18:49:10

haz3, dont get all angry, just because he doesnt read, just tell him to look, or tell him what line its on, but not. AHH!! LEECHER! DIE! THEN CTR F !! AHHH CTR V! THEN DIE AGAIN!.. try to be nice every once in a while :p

haz3

2007-05-14 19:18:55

sorry it was late……..

3Garrett3

2007-05-14 19:59:41

its ok, just try not to rip his head off next time, ok?

haz3

2007-05-15 07:59:44

^ I did no such thing, I just told you it was late..

jabe

2007-05-16 12:54:15

Ah.. i have small problem with this script.. when this take 28 fishs in bank.. and click minimap.. he didnt start cook nothing.. and this go outside a house..:duh: and this error coming Line 174: [Hint] (192:43): Variable 'NEWLINE' never used in script C:\Program Files\SCAR 2.03\includes\srl\srl\core\Globals.scar

skibby

2007-05-26 22:57:04

Really nice script man

coe12

2007-05-29 10:02:44

DONT EVEN COOK IT IT GOES TO COKK BUT DONT CLICK THE LOBBY:| BIT STUPID ops soz about caps

StreetNaruto

2007-08-04 02:42:25

getting some errors but ill check and just see if its me when i get the chance:D

omegaangelz

2007-11-03 15:18:51

Leechers, stop yelling/saying the script it stupid. It looks great man tested it out and it worked fine for me. Just dont tell the leechers how to fix the problems and they will go away.

Czepa

2007-11-04 06:50:33

From: omegaangelz
Leechers, stop yelling/saying the script it stupid. It looks great man tested it out and it worked fine for me. Just dont tell the leechers how to fix the problems and they will go away.

dont gravedig.. does it actually work?

fooddude12

2007-12-22 02:14:31

Edgeville bank doesn't look like that picture you posted anymore.