SRL Archive - First Scripts

iCleaner [Herblore] [Grimy herb cleaner]


iCURiP

2011-12-28 21:27:42

Hey, this is my first script, feel free to give me your opinions or if you do script your self please review how I'm doing so far xD.

No need to input what herb you want to clean, just select your banking settings and it will do the herb in the slot you choose, just make sure that other herbs are not visible, otherwise it will not detect being out of herbs and stop.

Has a basic anti-ban and also 15 different cleaning paths, i will add more when i get time, and cleans roughly 3800 herbs per hour :)

Instructions inside script.

Enjoy! :spot:

—

Got me 50 - 70 herblore to far :), going to do a complete re-write of this script soon.


~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 12:02:17
Herbs cleaned: 45808
Loads cleaned: 1636
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

RISK

2011-12-28 21:32:16

This procedure is blank, why?
Procedure setDTM;
begin




end;

You don't need this if you are using SMART. :)
ActivateClient;  

You shouldn't use global variables. You should use local variables as much as you can.
var
HERB, X, Y, BankTabOfHerb, BankSlotX, BankSlotY, ISlot, HERBS_CLEANED:Integer;
DTMString:String;
UseAntiban:Boolean;
Pattern, Clock:TIntegerArray;

You need to work on your standards.

Other than that, this is a great first script. :) I'm very excited to see what you create in the future and what you make of this script!

iCURiP

2011-12-28 21:36:04

From: RISK
This procedure is blank, why?
Procedure setDTM;
begin




end;

You don't need this if you are using SMART. :)
ActivateClient;  

You shouldn't use global variables. You should use local variables as much as you can.
var
HERB, X, Y, BankTabOfHerb, BankSlotX, BankSlotY, ISlot, HERBS_CLEANED:Integer;
DTMString:String;
UseAntiban:Boolean;
Pattern, Clock:TIntegerArray;

You need to work on your standards.

Other than that, this is a great first script. :) I'm very excited to see what you create in the future and what you make of this script!


Oh yeah, i forgot to delete that method, i was going to try making a GUI and that was going to be the method to set the DTM, didn't make it in the end or need it in and forgot to remove it.

Thanks for pointing those things out too. helps me learn.

Also could you explain to me what the benefits are of using local variables :)?

TsterT

2011-12-29 07:43:58

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 1:7:26
Herbs cleaned: 4988
Loads cleaned: 178
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Nice job man. Worked flawlessly. Although, once it's done, it will start withdrawing whatever was in the set bank slot. Just a suggestion, but adding in a check for the uptext wouldn't hurt.

iCURiP

2011-12-29 08:42:17

From: TsterT
~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 1:7:26
Herbs cleaned: 4988
Loads cleaned: 178
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Nice job man. Worked flawlessly. Although, once it's done, it will start withdrawing whatever was in the set bank slot. Just a suggestion, but adding in a check for the uptext wouldn't hurt.


Thanks for the feedback :D

That usually happens when another herb is visible in bank, will sort this out soon :)

Gushers

2011-12-29 09:43:21

Looks like a very nice script, do you make any cash off it? Or do you lose some?

iCURiP

2011-12-29 10:07:08

From: Gushers
Looks like a very nice script, do you make any cash off it? Or do you lose some?


http://runescape.wikia.com/wiki/Calculator:Herblore/Herbs
Check profits/losses here :), although i suggest trialling them before you do them, buy, clean, sell, grand exchange fluctuates a lot.

LemonHaze

2011-12-29 16:22:20

does this script support soul wars bank?
Gratz on first script btw :p

walsh145

2011-12-29 17:19:34

lovely script mate its clean 20k cads for me today

iCURiP

2011-12-29 17:36:01

From: lordvolt
does this script support soul wars bank?
Gratz on first script btw :p


Only supports NPC banks at the moment, will add an option soon, im working on a safe cracker at the moment though :)

iCURiP

2011-12-29 17:37:18

From: walsh145
lovely script mate its clean 20k cads for me today


Nice one, proggie would have been sexy xD

walsh145

2011-12-29 17:48:03

stopped the script so no proggy just making them into unfin cad pots gonna takes ages lol then do another 20k after sold pots

iCURiP

2011-12-29 18:32:44

From: walsh145
stopped the script so no proggy just making them into unfin cad pots gonna takes ages lol then do another 20k after sold pots


Nice, that must be some nice profits rite there, I might make an option to make unfinished potions after cleaning all of the herbs. I also want to make a GUI.

karter50

2011-12-29 23:51:03

Gonna load out 400k - 500k herbs of some sort now, I'll post what happens in a few days.

If all goes well, I'll retest with a million. See how it turns out. Endurance testing is the best :)

Oh, forgot to mention, I'm spreading the herbs over 5 member accounts, standing in 5 different worlds from 5 different computers, 5 different banks and 5 different herb types, just incase they try to ban them :D

Bank Pin could be added too:

Players[0].Pin :='';//Bank pin

Underneath the active player.

TrLoLoLoL

2011-12-30 00:53:51

going to try out this script, would i get banned useing it ?

karter50

2011-12-30 01:04:18

Has a basic anti-ban


:duh:

imaloser

2011-12-30 01:10:02

Good stuff man, I'm tryna hoan on m pascal language as we speak lol.

(:

iCURiP

2011-12-30 01:12:25

Good luck karter :D, post a couple proggies.

–

fagex, it has an anti-ban, but its not all down to the anti-ban, its how you use it, your more likely to get banned if you get reported multiple times, that's like 80% of jagex's banning system :P, so i suggest its a fairly populated place (So theres less change of people talking to you out of a larger amount of people) or a quickchat world.

karter50

2011-12-30 01:28:46

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 0:57:48
Herbs cleaned: 4284
Loads cleaned: 153
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Around 4350 Herbs an hour man, good so far. I started this bot first, the other 4 took a while because of my incompetence to store my account details so I'll post them when I wake up.

Looks good though, they're avantoe's I'm cleaning. Thats a profit of:

4350 / hour = 565K / HOUR!!!!

Seriously, bot nuke on reflection and injection was amazing for things like herbs. 130 profit per avantoe, I'm level 65 herb on my secondary account now.

I don't merchant, cannot wait until other prices deflate too!

LemonHaze

2011-12-30 04:31:06

From: iCURiP
Only supports NPC banks at the moment, will add an option soon, im working on a safe cracker at the moment though :)


k, would be very nice to see sw :p.

iCURiP

2011-12-30 10:46:48

From: lordvolt
k, would be very nice to see sw :p.


Got chest banking done, although iv already updated the script to SRL-5 so it will be released when that is released.
Also now has a paint.

Grihmm

2011-12-30 12:50:29

I was reading through your code, and I realized something: I was reading through your code! This is the first script I looked through and understood without having to analyze everything 10 times! I am stoked.

Btw, I am using this script as we speak. 67-70 herblore through cleaning grimy cadantines. I will post a proggy for you, as well as any bugs I see.

sahibjs

2011-12-30 12:56:02

works great!

thanks (:

Time running: 0:39:1
Herbs cleaned: 2729
Loads cleaned: 97

karter50

2011-12-30 12:59:08

You planning adding unfinished potions? I've modified mine to do them but it isn't anti-ban (just goes 1 and 15, 2 and 16, 3 and 17, etc)

oh, and here's a 12 hour update

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 12:02:17
Herbs cleaned: 45808
Loads cleaned: 1636
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Profit of 5,955,040 or about 6 million gp.

Thanks bro.

Grihmm

2011-12-30 13:12:32

Found a bug: occasionally, the camera rotates as an antiban and the cursor cannot find the banker again, resulting in random antibans and cursor movements all over.

Edit: I am running this at the G E. So the roof of the little exchange area is blocking the banker. I am not sure if this would affect actual banks.

karter50

2011-12-30 13:25:17

From: Grihmm
Found a bug: occasionally, the camera rotates as an antiban and the cursor cannot find the banker again, resulting in random antibans and cursor movements all over.

Edit: I am running this at the G E. So the roof of the little exchange area is blocking the banker. I am not sure if this would affect actual banks.


If this is a problem then remove line 75, saying this:

3: RandomMovement;

This will stop the arrow keys so the camera won't move. The other four anti-ban features should take care of it.

Oh and you should run it at something like Tree Gnome Village. It's far away from any activity, and I'd run it on a quick-chat world too. Less risk of any reports from anyone :)

iCURiP

2011-12-30 13:40:42

From: karter50
If this is a problem then remove line 75, saying this:

3: RandomMovement;

This will stop the arrow keys so the camera won't move. The other four anti-ban features should take care of it.

Oh and you should run it at something like Tree Gnome Village. It's far away from any activity, and I'd run it on a quick-chat world too. Less risk of any reports from anyone :)


Exactly what i was going to say lol.

Also explain what you modified again i didn't really understand.

Grihmm

2011-12-30 13:49:28

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 1:8:16
Herbs cleaned: 2876
Loads cleaned: 102
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
It has been 3 minutes and Runescape is not yet ready… Terminating.
Make sure your settings are set to fixed screen
Successfully executed.
The following DTMs were not freed: [2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131,

I was at G E and it self-terminated. I believe because of the camera angle changing.

iCURiP

2011-12-30 13:52:48

People having issues at GE just run a little south to varrock west :p

sahibjs

2011-12-30 14:05:39

From: iCURiP
People having issues at GE just run a little south to varrock west :p


i can confirm that varrok west works great!

Grihmm

2011-12-30 14:15:27

I am using it now. Btw, the Gnome Stronghold bank didn't work for me. Then again, gnome bankers are different than human ones.

imaloser

2011-12-30 16:13:31

Good script.

Average ~4200 herbs cleaned

I added MouseKeys to the cleaning procedure and well report back how many an hour it can do.

iCURiP

2011-12-30 17:57:56

From: imaloser
Good script.

Average ~4200 herbs cleaned

I added MouseKeys to the cleaning procedure and well report back how many an hour it can do.


sure that's safe lol, of course mouse keys are legit but surely its a bit risky?

HT BaaFly

2011-12-30 18:03:35

nice script man

try using things like:
Procedure BankDoesNotContainHerb;
var
i: integer;
begin
For i := 0 to 4 do
if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
begin
writeln('OUT OF HERBS, LOGGING OUT!');
CloseBank;
Logout;
TerminateScript;
end else
break;
end;

instead of:
Procedure BankDoesNotContainHerb;
begin
if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
writeln('OUT OF HERBS, LOGGING OUT!');
CloseBank;
Logout;
TerminateScript;

end;

orr something like that u know
avoid typing the same line multiple times

karter50

2011-12-30 18:42:34

From: iCURiP
Exactly what i was going to say lol.

Also explain what you modified again i didn't really understand.


I added two things:

1) A bank pin option.

2) Ability to make unfinished potions out of the cleaned herbs in the bank (but yeah it's your script with some stuff changed)

NOTE: TARROMINS ARE NOW THE BEST HERB TO DO FOR PROFIT, SIMPLY BECAUSE AVANTOES ARE SO HARD TO BUY!

imaloser

2011-12-31 00:47:58

From: iCURiP
sure that's safe lol, of course mouse keys are legit but surely its a bit risky?


~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 1:30:46
Herbs cleaned: 12546
Loads cleaned: 231
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


iCURiP

2011-12-31 00:52:13

From: imaloser
~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 1:30:46
Herbs cleaned: 12546
Loads cleaned: 231
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~



Nice :P, I know its legit but mouse keys are tricky to 100% simulate, if you get it off a bit then your screwed :/

karter50

2011-12-31 08:39:49

From: Grihmm
I am using it now. Btw, the Gnome Stronghold bank didn't work for me. Then again, gnome bankers are different than human ones.


Gnome Bankers don't work, sorry about that :3 Although if they did it's the best place to do it.

LemonHaze

2011-12-31 17:15:17

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 1:21:23
Herbs cleaned: 5778
Loads cleaned: 206
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

:)

karter50

2012-01-01 08:04:24

Finished the 500k and made 66m, thanks :D

Closer to my 100b target nao :D

iCURiP

2012-01-01 10:03:50

From: karter50
Finished the 500k and made 66m, thanks :D

Closer to my 100b target nao :D


Shizzle my nizzle, that's sexy

laakerules

2012-01-01 21:14:09

Nice Script, Gonna try it out on toadflax after i get 99 Def with my Script! :P

iCURiP

2012-01-02 00:21:23

From: laakerules
Nice Script, Gonna try it out on toadflax after i get 99 Def with my Script! :P


Sweet good luck, I actually just finished work on my own semi-combat script :P, pest control, although I'm saving it till SPS 2.0, otherwise the camera has to be north all the time, which would be a possible way of detecting pest control bots, it also has options to defend void or kill portals and quick prayers etc.

The Ghola

2012-01-02 09:00:36

can u confirm if this has Mousekeys yet?

MJF94

2012-01-02 11:09:07

No mouse keys, and doesn't work 100%

iCURiP

2012-01-02 11:54:16

From: MJF94
No mouse keys, and doesn't work 100%


Care to tell me how, otherwise i cant' make it better can i :p?

Also ghola, I'm doing a re-write of this script soon and it will have a lot more options probably including mouse-keys

Interested

2012-01-02 13:08:08

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 1:28:38
Herbs cleaned: 5868
Loads cleaned: 209
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
OUT OF HERBS, LOGGING OUT!

Worked flawlessly, apart from one occasion where it started clicking a different bank booth. Thanks :)

iCURiP

2012-01-02 13:54:48

From: Interested
~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 1:28:38
Herbs cleaned: 5868
Loads cleaned: 209
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
OUT OF HERBS, LOGGING OUT!

Worked flawlessly, apart from one occasion where it started clicking a different bank booth. Thanks :)


Well, it uses SRL, maybe in SRL-5 this might be fixed but i don't see it as much of a issue myself :)

Interested

2012-01-02 18:21:09

It only did it once as far as I'm aware, it didn't keep choosing different ones, just thought i would let you know :)

celljrftw

2012-01-02 22:13:03

Cleaned 40k herbs for me at about 3.7k/hr. Sorry for no proggies :s.

iCURiP

2012-01-03 00:09:49

From: celljrftw
Cleaned 40k herbs for me at about 3.7k/hr. Sorry for no proggies :s.


Nice one :D

prostaker

2012-01-03 04:10:44

I rarely take time to post anything, but i could not leave this one un-posted: I LOVE THIS SCRIPT. It reminds me of the good ol´ Reflection-script times. Thank you very much for making this. Gr8 script.

MaxPower

2012-01-03 04:12:02

Very nice script! One suggestion I have is to create 3 or so "Speed Levels" (one would be the current speed, one approximately 2x faster, one mousekey speed (if you decide to do that), etc).

I used to use very fast reflection bots to clean herbs and never got banned or rolled back, so I'm not very worried about Jagex catching me. Thus I tried to speed up the script by reducing some of the wait times and was able to get something like 5k herbs an hour.

I would speed it up even more, but I think the MouseItem function you use to click is inherently slow by itself, and I can't seem to find where that function is. Can anyone point it out to me so I can try to speed up the script some more? I'll be happy to post my final code after I'm satisfied with the speed!

Also, I can't seem to find a function that waits for non-integer amounts of time. Anyone know if this is possible? If not, I'll do some research on Google :P.

PS: for anyone that's interested in displaying your xp/hour, use something like

HERB_EXP := (experience for cleaning one herb here);
CleanedPerHour := Round((HERBS_CLEANED * 3600) / (GetTimeRunning / 1000));
writeln('XP Per Hour: ' + ToStr(HERB_EXP * CleanedPerHour));

Skywalk

2012-01-03 05:01:18

i get this message:

Exception in Script: Unable to find file 'SRL/SRL.scar' used from ''
doesn't exist

celljrftw

2012-01-03 15:41:46

Exception in Script: Plugin(irokiplugin32) has not been found
Exception in Script: Plugin(irokiplugin32) has not been found
Exception in Script: Plugin(irokiplugin32) has not been found
Exception in Script: Plugin(irokiplugin32) has not been found
Exception in Script: Plugin(irokiplugin32) has not been found
Exception in Script: Plugin(irokiplugin32) has not been found
Exception in Script: Plugin(irokiplugin32) has not been found
Exception in Script: Plugin(irokiplugin32) has not been found

iCURiP

2012-01-03 17:12:46

You two, are you both updated? :)

iCURiP

2012-01-03 17:15:45

From: prostaker
I rarely take time to post anything, but i could not leave this one un-posted: I LOVE THIS SCRIPT. It reminds me of the good ol´ Reflection-script times. Thank you very much for making this. Gr8 script.


Well then, I'm sure you will LOVE my next two releases…

Here is some hints…
Script one… Four portals…
Script two… two avatars?…

I WONDERRRR WHAT THEY AREEE :O?

You can probably guess what they are and might be thinking, no, making a herb cleaner doesn't mean you can suddenly do that… but i would like to think i have picked things up fairly quickly, I know a few other languages and its just a matter of learning the API

Already finished script one, about 30% done on second.

celljrftw

2012-01-03 23:15:03

I'm excited, your herb cleaner is great. Should be moved to "herblore" scripts as the other 2 don't work.

chelmid

2012-01-04 08:36:32

This is awesome! I got herblore lvl 17->61 in two days!

iCURiP

2012-01-04 09:38:10

From: chelmid
This is awesome! I got herblore lvl 17->61 in two days!


Sweet :D

chelmid

2012-01-04 11:01:11

Doesn't work because of the newest rs update.it can't bank.

celljrftw

2012-01-04 11:11:02

~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 6:1:7
Herbs cleaned: 25839
Loads cleaned: 922
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

iCURiP

2012-01-04 11:31:08

From: chelmid
Doesn't work because of the newest rs update.it can't bank.


It won't open the bank or it won't do things like withdrawing and depositing?

Its probably down to SRL, most of the banking methods are SRL, just wait for it to update.

lostprophetsown

2012-01-04 13:00:24

To bank follow my tutorial:

http://villavu.com/forum/showthread.php?p=881761#post881761

LemonHaze

2012-01-05 07:12:33

Do you have plans to add sw bank?

iCURiP

2012-01-05 08:34:14

From: lordvolt
Do you have plans to add sw bank?


Already done it, but im waiting till SRL 5 takes over

LemonHaze

2012-01-05 10:25:05

From: iCURiP
Already done it, but im waiting till SRL 5 takes over


k, nice :D

chelmid

2012-01-06 05:12:00

Is iCleaner updated to SRL5?

chelmid

2012-01-06 08:46:23

It doesn't work.still pressing deposit money pouch.

Kresh

2012-01-08 07:59:00

whilst trying to run this i got multiple problems, two of which i fixed, but the problems just kept coming, so i recorded it to show you exactly what they are..

http://www.youtube.com/watch?v=QmxOuDIV6_8

Grihmm

2012-01-08 22:06:14

You might want to update this to SRL5.

o0stacey0o

2012-01-09 08:02:07

this dont work for me,

it goes to bank withdraws the right herb, then cleans it and then opens bank up again and then just freezes there it dont actualy withdraw a new inventory :(


just seen it clicks the deposit cash from pouch instead of deposting my inventory :(

Mash

2012-01-09 15:05:03

From: o0stacey0o
this dont work for me,

it goes to bank withdraws the right herb, then cleans it and then opens bank up again and then just freezes there it dont actualy withdraw a new inventory :(


just seen it clicks the deposit cash from pouch instead of deposting my inventory :(


hey bro i know how u feel, none of the herblore scripts on here work. so i decided to make my own.

il be done very soon

Grihmm

2012-01-10 02:33:50

It clicks the Deposit Coins button instead of the Deposit Inventory button because it hasn't been updated to SRL5.

Mr. Freeweed

2012-01-10 14:55:40

Here is a quick fix for everyone till owner gets back. Nothing added. I just fixed for srl5 update to check it out. Nice little first script here. :sasmokin:

to the writer I like your "Pattern" mouse item.

I recommend writing your own bank finding algo. The srl ones are to general. Goodluck!

progress report
~~~~~~~~~iCleaner~~~~~~~~~~~~~~
Time running: 5:1:19
Herbs cleaned: 19878
Loads cleaned: 709
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
OUT OF HERBS, LOGGING OUT!

Program iCleaner;

//MAKE SURE NO OTHER HERBS ARE VISIBLE IN YOUR BANK OTHER THAN THE ONE YOU ARE USING, OTHERWISE IT WILL NOT STOP WHEN OUT OF HERBS
//(You can have them in your bank, just not visible)
//
// NOTE: SOME HERBS HAVE NOT BEEN TESTED
// IF THEY DON'T WORK TELL ME,
// ALTHOUGH THEY SHOUlD BE FINE :).
//
// INSTRUCTIONS
//
// ► FILL IN THE OPTIONS, HERE IS AN EXPLANATION OF BANK SETTINGS: http://i1139.photobucket.com/albums/n560/iCURiP/exmple.png
// ► START AT ANY SRL SUPPORTED NPC BANK
// ► MAKE SURE THE ONLY HERBS VISIBLE ARE THE ONES YOU WANT TO USE.
// ► THERE IS NO NEED TO INPUT WHAT HERB YOU WANT, AS IT JUST GETS THE ONE IN THE SLOT YOU CHOOSE IN BANK SETTINGS
//
// TIPS
//
// ► TO FIND PROFITABLE HERBS I SUGGEST GOING HERE > http://runescape.wikia.com/wiki/Calculator:Herblore/Herbs
// ► TO BE SURE YOUR HERB IS PROFITABLE BUY, CLEAN AND SELL ONE OF THE HERB, SOMETIMES IT MAY SAY ITS PROFITABLE BUT PRICES FLUCTUATE A LOT
// ► SOMETIMES IT MAY BE WORTH A COUPLE LESS GP PROFIT IN ORDER TO GET MORE EXP TO SAVE MONEY RATHER THAN GETTING HERBLORE NORMALLY



var
HERB, X, Y, BankTabOfHerb, BankSlotX, BankSlotY, ISlot, HERBS_CLEANED:Integer;
DTMString:String;
UseAntiban:Boolean;
Pattern, Clock:TIntegerArray;

{$define SMART} //Comment this if you are not using SMART
{$i SRL/SRL.simba}

Procedure DeclarePlayers;
begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;




//----------------OPTIONS START HERE-----------------|
Players[0].Name :='';//Username //|
Players[0].Pass :='';//Password //|
Players[0].Nick :='Mr ';//3-4 letters of name //|
Players[0].Active:= True; //|
// |
//Go to instructions for example of bank settings. |
//Preset is the main tab, first slot. |
//-----------------BANK_SETTINGS---------------------|
BankTabOfHerb := 1; //|
BankSlotX := 0; //|
BankSlotY := 0; //|
//-----------------OTHER_SETTINGS--------------------|
UseAntiban := True; //Use Antiban? True/False |
//---------------------------------------------------|
//OPTIONS END HERE////////////////////////////////////////////////////////////////

DTMString := 'mrAAAAHic42BgYLAGYicgdgZiRyC2AWIzINYHYlsgzgXiJCBOh7ILgbgYiAug4s5mskCSCSdmZcAPGAlgGAAAAu0F8g==';//Change this if the DTM is broken.
Smart_Server := 86;
Smart_Members := True;
Smart_Signed := True;
Smart_SuperDetail := False;
SetupSRL;
end;

Procedure Antiban;
begin
if UseAntiban then
case random(40) of
0: RandomRClick;
1: PickUpMouse;
2: RandomRClick;
3: RandomMovement;
4: ExamineInv;
end;
end;


Procedure PROGRESS_REPORT;
begin

writeln('~~~~~~~~~iCleaner~~~~~~~~~~~~~~');
Clock := [0,0,0];
ConvertTime(GetTimeRunning,Clock[0],Clock[1],Clock[2]);
Writeln(' Time running: ' +tostr(Clock[0])+':'+tostr(Clock[1])+':'+tostr(Clock[2]));
writeln('Herbs cleaned: ' + IntToStr(HERBS_CLEANED));
writeln('Loads cleaned: ' + IntToStr(HERBS_CLEANED/28));
writeln('~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~');

end;


Procedure BankDoesNotContainHerb;
begin
if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
if NOT FindDTM(HERB,X, Y, MSX1, MSY1, MSX2, MSY2) then
writeln('OUT OF HERBS, LOGGING OUT!');
CloseBank;
Logout;
TerminateScript;

end;
Procedure FAILSAFE;
begin
if Not LoggedIn then
begin
LogInPlayer;
ClickNorth(SRL_ANGLE_HIGH); //Or SRL_ANGLE_LOW or SRL_ANGLE_NONE
SetAngle(SRL_ANGLE_HIGH); //Or SRL_ANGLE_LOW
end;
FindNormalRandoms;
LevelUp;
end;

Procedure Clean;
var SlotBox:TBox;
begin
Case Random(16) Of
0:Pattern := [1, 5, 9, 13, 17, 21, 25, 2, 6, 10, 14, 18, 22, 26, 3, 7, 11, 15, 19, 23, 27, 4, 8, 12, 16, 20, 24, 28];
1:Pattern := [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28];
2:Pattern := [1, 5, 2, 9, 6, 3, 13, 10, 7, 4, 17, 14, 11, 8, 21, 18, 15, 12, 25, 22, 19, 16, 26, 23, 20, 27, 24, 28];
3:Pattern := [1, 2, 5, 6, 9, 10, 13, 14, 17, 18, 21, 22, 25, 26, 3, 4, 7, 8, 11, 12, 15, 16, 19, 20, 23, 24, 27, 28];
4:Pattern := [1, 2, 3, 4, 8, 7, 6, 5, 9, 10, 11, 12, 16, 15, 14, 13, 17, 18, 19, 20, 24, 23, 22, 21, 25, 26, 27, 28];
5:Pattern := [1, 2, 3, 4, 8, 12, 16, 20, 24, 28, 27, 26, 25, 21, 17, 13, 9, 5, 6, 7, 11, 15, 19 ,23 ,22 ,18 ,14 ,10];
6:Pattern := [1, 5, 9, 13, 17, 21, 25, 26, 22, 18, 14, 10, 6, 2, 3, 7, 11, 15, 19, 23, 27, 28, 24, 20, 16, 12, 8, 4];
7:Pattern := [1, 5, 9, 13, 17, 21, 25, 26, 27, 28, 24, 20, 16, 12, 8, 4, 3, 2, 6, 10, 14, 18, 22, 23, 19, 15, 11, 7];
8:Pattern := [2, 1, 5, 6, 10, 9, 13, 14, 18, 17, 21, 22, 26, 25, 4, 3, 7, 8, 12, 11, 15, 16, 20, 19, 23, 24, 28, 27];
9:Pattern := [28, 24, 20, 16, 12, 8, 4, 3, 7, 11, 15, 19, 23, 27, 26, 22, 18, 14, 10, 6, 2, 1, 5, 9, 13, 17, 21, 25];
10:Pattern := [28, 27, 26, 25, 21, 22, 23, 24, 20, 19, 18, 17, 13, 14, 15, 16, 12, 11, 10, 9, 5, 6, 7, 8, 4, 3, 2, 1];
11:Pattern := [25, 26, 27, 28, 24, 23, 22, 21, 17, 18, 19, 20, 16, 15, 14, 13, 9, 10, 11, 12, 8, 7, 6, 5, 1, 2, 3, 4];
12:Pattern := [4, 3, 7, 8, 12, 11, 15, 16, 20, 19, 23, 24, 28, 27, 26, 25, 21, 22, 18, 17, 13, 14, 10, 9, 5, 6, 2, 1];
13:Pattern := [25, 21, 17, 13, 9, 5, 1, 2, 6, 10, 14, 18, 22, 26, 27, 23, 19, 15, 11, 7, 3, 4, 8 ,12 ,16 ,20 ,24 ,28];
14:Pattern := [4, 8, 12, 16, 20, 24, 28, 27, 23, 19, 15, 11, 7, 3, 2, 6, 10, 14, 18, 22, 26, 25, 21, 17, 13, 9, 5, 1];
15:Pattern := [4, 8, 12, 16, 20, 24, 28, 27, 26, 25, 21, 17, 13, 9, 5, 1, 2, 3, 7, 11, 15, 19, 23, 22, 18, 14, 10, 6];
end;



for ISlot := 0 To 27 Do
begin
HERB := DTMFromString(DTMString);
SlotBox := InvBox(Pattern[ISlot]);
if FindDTM(HERB, X, Y, SlotBox.X1, SlotBox.Y1, SlotBox.X2, SlotBox.Y2) then
begin
MouseItem(Pattern[ISlot], 1);
wait(5 + Random(50));
HERBS_CLEANED := HERBS_CLEANED + 1;
if ISlot = 27 then
begin
wait(500 + Random(1000));
end;
end;
FreeDTM(HERB);
end;
end;

begin
DeclarePlayers;

Repeat
Antiban;
FAILSAFE;
HERB := DTMFromString(DTMString);

if FindDTM(HERB, X, Y, MIX1, MIY1, MIX2, MIY2) then

begin
FreeDTM(HERB);
Clean;
end;
HERB := DTMFromString(DTMString);

if Not FindDTM(HERB, X, Y, MIX1, MIY1, MIX2, MIY2) then
begin
if Not BankScreen then

begin
OpenBankNPC;
wait(150 + Random(500));
Antiban;
wait(150 + Random(500));
end;

if BankScreen then

begin
BankTab(BankTabOfHerb);
wait(50 + Random(100));
Antiban;
wait(50 + Random(100));
DepositAll;
wait(50 + Random(250));
Antiban;
wait(50 + Random(250));
if Not FindDTM(HERB, X, Y, MSX1, MSY1, MSX2, MSY2) then
BankDoesNotContainHerb;
Withdraw(BankSlotX, BankSlotY, 28);
wait(100 + Random(500));
CloseBank;
wait(50 + Random(250));
Antiban;
wait(50 + Random(250));
end;

end;
Antiban;
wait(50 + Random(100));
FreeDTM(HERB);
PROGRESS_REPORT;
Until(False);
end.

Yobesti

2012-01-12 03:03:10

thx freeweed, that worked for me :)

script seems good, it just cleans kinda slow.

And every load it examines the first herb -> if this is antiban, i don't think it's neccesary doing it every load ?

+ in bank it clicks withdraw 'x', followed by typing '28' for like 1 out of 2 loads. Does it really need to do this so many times ? Just at start is enough no ?

iCURiP

2012-01-12 05:17:05

From: Yobesti
thx freeweed, that worked for me :)

script seems good, it just cleans kinda slow.

And every load it examines the first herb -> if this is antiban, i don't think it's neccesary doing it every load ?

+ in bank it clicks withdraw 'x', followed by typing '28' for like 1 out of 2 loads. Does it really need to do this so many times ? Just at start is enough no ?


If you don't want it to examine the herbs just remove it from the antiban, the withdraw x thing is SRL.

–

Also sorry everyone, my pest control and soul wars scripts are not going to be released very soon, since im working on a java based bot.

Yobesti

2012-01-12 07:20:15

From: iCURiP
If you don't want it to examine the herbs just remove it from the antiban, the withdraw x thing is SRL.


Ok thanks !

PS; What about making it clean faster ? What value should i change ?
is it this one ?
             MouseItem(Pattern[ISlot], 1);
wait(5 + Random(50)); <<===

Grtz
Yobesti

iCURiP

2012-01-12 07:50:20

From: Yobesti
Ok thanks !

PS; What about making it clean faster ? What value should i change ?
is it this one ?
             MouseItem(Pattern[ISlot], 1);
wait(5 + Random(50)); <<===

Grtz
Yobesti



You can't really make it faster, that 50 wait is pretty much 1/20 of a second at max, most of the time its even smaller than that, which is needed to make all of your clicks not at the same intervals, the main reason it is slowish is because its a color bot and it has to search the screen which takes a couple of seconds.

laakerules

2012-01-12 10:42:07

Has anyone added soul wars bank?

Mr. Freeweed

2012-01-12 14:17:15

From: iCURiP
If you don't want it to examine the herbs just remove it from the antiban, the withdraw x thing is SRL.

–

Also sorry everyone, my pest control and soul wars scripts are not going to be released very soon, since im working on a java based bot.


To become a better scripter I suggest going through the srl functions/procedures and editing/make your own designed just for this script. #1 srl is just a bunch of very general code made for a broad use. If you make your own 99% of the time youll have a better and I guarantee a faster script. I threw in some of my own premade stuff like a banking procedure and moved the herb closer to the inventory in bank, and so on ext…. I'd show you but since this is a first script you might as well work on it yourself, if you plan to move on to better ;)

Most normal players wont keep entering manually 28. you can have it check the menu text to see what value its already at.

An alternative would be just have it do withdraw on occasion or 50/50 between withral 28 and all. What ever floats your boat.

iCURiP

2012-01-12 15:16:54

From: Mr. Freeweed
To become a better scripter I suggest going through the srl functions/procedures and editing/make your own designed just for this script. #1 srl is just a bunch of very general code made for a broad use. If you make your own 99% of the time youll have a better and I guarantee a faster script. I threw in some of my own premade stuff like a banking procedure and moved the herb closer to the inventory in bank, and so on ext…. I'd show you but since this is a first script you might as well work on it yourself, if you plan to move on to better ;)

Most normal players wont keep entering manually 28. you can have it check the menu text to see what value its already at.

An alternative would be just have it do withdraw on occasion or 50/50 between withral 28 and all. What ever floats your boat.


This was my first simba script but i have improved a lot since this, and i now have working pest control + soul wars scripts, although i have temporarily taken a break from pascal as Java is my preferred language, I'm working on a java based bot client at the moment.

iPestControl: http://www.youtube.com/watch?v=96gWn_CVa8A
iSoulwars: http://www.youtube.com/watch?v=eag3r6y-FIQ

chelmid

2012-01-22 13:42:28

Are u ggoing to release iSoulwars or iPestControl to public?

Sin

2012-01-22 14:01:41

From: imaloser
Good stuff man, I'm tryna hoan on m pascal language as we speak lol.

(:

English first lol.

iCURiP

2012-01-26 10:47:20

From: S1N
English first lol.


I like this post tbh :D

– On a side note –
After taking a break from simba, I'm slowly getting back into it again, currently just making a falconry bot, then i may start work on my soul wars script again depending on how i feel.

tisin

2012-02-08 21:29:31

I got error

"Exception in Script: Unable to find file 'SRL/SRL.scar' used from ''