SRL Archive - Archive

~Justin - SRL Member Application


Justin

2011-12-23 23:38:45

UPDATED: RADIAL+SPS FAILSAFE WALKING - SNAPE GRASS

How Long have You Played Runescape?
5 Year(s)


Are you affilated in anyway with Jagex LTD?
No

Were you Referred to SRL?



What is your general programming knowledge?
Java, HTML, php, VB and some basic ones


Are you a member of any other communities?
Yes,
RSBuddy, PowerBot, RSBots.NET


Tell us about yourself…
From: ~Justin

I'm 19, Have been working with computers since I was young (around 9-10). I live in Australia, Finished my VCE Schooling and I am currently a ICT Admin at a Highschool. I enjoy my job and in my spare time I tend to code and modify scripts to make then work better for my liking and enjoy playing/botting on RuneScape.



Please show us one (or multiple) of your scripts.

Snape Grass collector

program SnapeGrass;
{$i srl/srl/misc/smart.scar}
{$i srl/srl.scar}
{$i sps/sps.simba}
{$i SRL/SRL/Misc/stats.simba}

var
Snape, SnapePrice, RandomChange, loads: Integer;
Jarvald, SnapeGrass: TIntegerArray;
HouseToBoat, GoIntoBank, SnapeGrassLocation, SafePlace: TPointArray;

procedure DeclarePlayers;
begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;
Players[0].Name := '';
Players[0].Pass := '';
Players[0].Active := true;
Players[0].Pin := '';
end;

procedure SetupLogin;
begin
ClearDebug;
Smart_Server := 97;
Smart_Members := true;
Smart_Signed := true;
Smart_SuperDetail := false;
SetupSRL;
DeclarePlayers;
LoginPlayer;
end;

procedure SetupSps;
begin
SPS_Setup(RUNESCAPE_SURFACE, ['6_5', '5_5', '5_4', '5_3', '4_3', '4_4', '10_6']);
SPS_Continue := false;
end;

procedure Antiban; //idea taken from Coh3n's tutorial.
begin
if not (LoggedIn) then
Exit;
begin
case Random(250) of // Random(250) generates a random integer from 0 to 250
10: RandomRClick;
30: PickUpMouse;
50: RandomMovement;
70: BoredHuman;
89: ExamineInv;
end;
end;
end;

procedure DoRest;
begin
if not (LoggedIn) then
Exit;
begin
SetRest;
while not RunEnergy(95) do
begin
Antiban;
Wait(Random(1000));
end;
end;
end;

procedure TeleToBankAndWalk;
begin
if not (LoggedIn) then
Exit;
if not FindNormalRandoms then
begin
if not RunEnergy(25) then
DoRest;
MakeCompass('n');
Writeln('Teleporting to bank...');
while (srl_InFight) do
begin
Wait(RandomRange(1500, 1800));
Writeln('Waiting to be out of combat...');
end;
Wait(Random(1000));
GameTab(Tab_Magic);
MMouse(574, 232, 8, 7);
if WaitUptext('Cast', 400) then
ClickMouse2(true);
begin
MMouse(574, 232, 10, 3);
end;
GoIntoBank := [Point(4211, 2670)];
if SPS_WalkPath(GoIntoBank) then
Writeln('At the Bank..');
end;
end;

procedure Banking;
var
p, t: Integer;
begin
if not (LoggedIn) then
Exit;
while (IsMoving) do
begin
Wait(RandomRange(900, 1200));
end;
t := 0; //Tries starts at zero
repeat
Inc(t);
Wait(RandomRange(700, 1000));
OpenBankNPC;
until BankScreen or PinScreen or (t = 5);
if PinScreen then
begin
p := 0;
repeat
InPin(Players[0].Pin);
Inc(p)
until BankScreen or (p > 0) or not (LoggedIn);
end;
if BankScreen then
begin
Writeln('Opened the bank...');
DepositAll;
Withdraw(0, 0, 1);
Wait(RandomRange(500, 1200));
CloseBank;
end;
if (t = 5) then
begin
Writeln('Couldn''t find bank in time... Terminating...');
TerminateScript;
end;
Inc(loads);
end;

procedure TeleportToHouse;
begin
InvMouse(1, 1);
wait(RandomRange(2400, 4800));
end;

procedure WalkToBoat_SPS;
begin
if not (LoggedIn) then
Exit;
if not FindNormalRandoms then
begin
if not RunEnergy(25) then
DoRest;
MakeCompass('n');
Writeln('Walking to boat via SPS');
Wait(Random(1000));
begin
case Random(5) of // Randomize walking path
0..1:
HouseToBoat := [Point(2517, 2097), Point(2499, 2075), Point(2481, 2054),
Point(2446, 2051), Point(2413, 2054), Point(2371, 2048),
Point(2360, 2021), Point(2344, 2008), Point(2327, 1982),
Point(2316, 1949), Point(2313, 1922), Point(2317, 1910)];
2:
HouseToBoat := [Point(2511, 2093), Point(2481, 2056), Point(2464, 2053),
Point(2438, 2051), Point(2430, 2037), Point(2392, 2017),
Point(2361, 2014), Point(2341, 1997), Point(2338, 1972),
Point(2315, 1937), Point(2321, 1911)];
3:
HouseToBoat := [Point(2513, 2087), Point(2489, 2057), Point(2441, 2048),
Point(2409, 2053), Point(2374, 2051), Point(2347, 2043),
Point(2319, 2027), Point(2293, 2013), Point(2290, 1959),
Point(2316, 1925), Point(2318, 1905)];
4:
HouseToBoat := [Point(2505, 2080), Point(2485, 2057), Point(2443, 2047),
Point(2406, 2048), Point(2368, 2044), Point(2329, 2036),
Point(2328, 2010), Point(2334, 1991), Point(2339, 1969),
Point(2351, 1932), Point(2327, 1923), Point(2321, 1913)];
5:
HouseToBoat := [Point(2508, 2081), Point(2460, 2051), Point(2425, 2049),
Point(2370, 2046), Point(2322, 2028), Point(2331, 1984),
Point(2306, 1948), Point(2322, 1919), Point(2317, 1909)];
end;
end;
if SPS_WalkPath(HouseToBoat) then
begin
Writeln('Walked to the boat via SPS');
Wait(RandomRange(1200, 1500));
end else
begin
Writeln('Failed to walk to the boat via Radial and SPS... Terminating script!');
TerminateScript;
end;
end;
end;

procedure WalkToBoat_Radial;
begin
if not (LoggedIn) then
Exit;
if not FindNormalRandoms then
begin
if not RunEnergy(25) then
DoRest;
MakeCompass('n');
Writeln('Walking to boat via Radial');
Wait(Random(1000));
begin
RadialWalkTolerance(6451052, 318, 345, 72, -1, 0,25);
Wait(RandomRange(800, 1200));
RadialWalkTolerance(6451052, 322, 338, 72, -1, 0,25);
Wait(RandomRange(800, 1200));
RadialWalkTolerance(6451052, 315, 333, 72, -1, 0,25);
Wait(RandomRange(800, 1200));
RadialWalkTolerance(6451052, 282, 303, 72, -1, 0,25);
Wait(RandomRange(800, 1200));
RadialWalkTolerance(1795803, 273, 294, 70, -1, 0,15);
Wait(RandomRange(800, 1200));
writeln('Walked to the boat via Radial... If not will SPS failsafe!');
end;
end;
end;

procedure WalkToGoodSnapeGrass;
begin
begin
case Random(5) of // Randomize walking path
0..1: SnapeGrassLocation := [Point(2013, 1581), Point(1971, 1570),
Point(1936, 1570), Point(1898, 1573), Point(1863, 1586), Point(1851, 1605)];
2: SnapeGrassLocation := [Point(2010, 1601), Point(1988, 1587),
Point(1977, 1580), Point(1955, 1572), Point(1920, 1595),
Point(1893, 1605), Point(1857, 1615)];
3: SnapeGrassLocation := [Point(2004, 1597), Point(1979, 1576),
Point(1957, 1572), Point(1922, 1570), Point(1896, 1572),
Point(1875, 1572), Point(1857, 1593), Point(1849, 1610)];
4: SnapeGrassLocation := [Point(2025, 1606), Point(1996, 1583),
Point(1966, 1568), Point(1938, 1566), Point(1897, 1572),
Point(1870, 1580), Point(1847, 1618)];
5: SnapeGrassLocation := [Point(2021, 1601), Point(1962, 1575),
Point(1932, 1583), Point(1913, 1596), Point(1851, 1619)];
end;
end;
if not SPS_WalkPath(SnapeGrassLocation) then
begin
Writeln('We are unable to walk to Snape Grass Location.. Going to bank!');
TeleToBankAndWalk;
Banking;
end;
end;

procedure Travel;
var
Tries, x, y: Integer;
begin
Writeln('We are trying to find Jarvald...');
Tries := 0;
repeat
Inc(Tries);
Writeln('Trying to find Jarvarl...');
MakeCompass('n');
Wait(RandomRange(700, 1000));
if FindObjCustom(x, y, ['alk-to Jarvald'], Jarvald, 3) then
begin
Writeln('Found Jarvald!');
Mouse(x, y, 3, 3, false);
Writeln('Selecting Travel option...');
WaitOptionMulti(['ravel-Water', 'ravel-W'], 1000);
Writeln('Waiting...');
Wait(RandomRange(2000, 6000));
end;
until ((Tries = 3) or (IsChatBoxTextBetween('eaving Rellekka', clBlack, 8, 8)));
begin
if (Tries = 3) then //Failed!
begin
Writeln('We failed to Travel! Trying to walk via SPS');
WalkToBoat_SPS;
Travel;
end;
end;
end;

procedure CollectSnapeGrass;
var
RandomNorthCount, fs, x, y: Integer;
begin
case Random(1) of
0: MakeCompass('e');
1: MakeCompass('w');
end;
case RandomRange(15, 19) of
15..19: MouseSpeed := RandomRange(15, 19);
end;
RandomNorthCount := RandomRange(17, 27);
fs := 0;
if (InvCount <= 28) then
begin
repeat
while (IsMoving) do
begin
Wait(RandomRange(200, 250));
end;
if (FindObjCustom(x, y, ['ake', 'ttack'], SnapeGrass, 25)) then
begin
Mouse(x, y, 4, 4, false);
WaitOptionMulti(['ake Snape', 'Take Snape', 'seaweed'], 50);
//Ensure that we don't click 'Walk' - Add a Seaweed check (had a player try to break my bot)
AntiBan;
Wait(RandomRange(100, 180));
end;
Inc(fs);
if (fs = 70) then
begin
Writeln('Been doing nothing for too long... changing worlds and going to bank to starting again');
ChangeWorld(RandomWorld(true, false));
Wait(RandomRange(3400, 9800));
TeleToBankAndWalk;
Wait(RandomRange(400, 1200));
Banking;
TeleportToHouse;
Wait(RandomRange(700, 1800));
WalkToBoat_Radial;
Wait(RandomRange(270, 2200));
Travel;
Exit;
end;
if (InvCount = RandomNorthCount) then
begin
MakeCompass('n');
end;
until InvFull;
end;
if (InvFull) then
begin
SafePlace := [Point(1902, 1605)];
if not (SPS_WalkPath(SafePlace)) then
begin
Writeln('Something went wrong when walking to the safe spot... Will try to teleport at current location');
end;
Exit;
end;
end;

function GetPrice(ObjID: Integer): Integer; //Credits to putonajonny
var
Str, str2, str3, str4: string;
startat, endat, com, k, b, m: Integer;
begin
Str := GetPage('http://services.runescape.com/m=itemdb_rs/g=runescape/viewitem.ws?obj=' +
IntToStr(ObjID));
startat := Pos('<th scope="row">Current guide price:</th>', Str);
if (startat > 0) then
begin
endat := Pos('<th scope="row">Today', Str);
str2 := Copy(Str, (startat + 46), endat - startat - 63);
k := Pos('k', str2);
com := Pos(',', str2);
b := Pos('b', str2);
m := Pos('m', str2);
str4 := str2;
if (k > 0) then
begin
str3 := Copy(Str2, 1, k - 1);
str4 := IntToStr(StrToInt(Copy(Str3, 1, Length(Str3) - 2) + Copy(Str3,
Length(Str3), 1)) * 100);
end;
if (b > 0) then
begin
str3 := Copy(Str2, 1, b - 1);
str4 := IntToStr(StrToInt(Copy(Str3, 1, Length(Str3) - 2) + Copy(Str3,
Length(Str3), 1)) * 100000000);
end;
if (m > 0) then
begin
str3 := Copy(Str2, 1, m - 1);
str4 := IntToStr(StrToInt(Copy(Str3, 1, Length(Str3) - 2) + Copy(Str3,
Length(Str3), 1)) * 100000);
end;
if (com > 0) then
begin
str4 := Copy(Str2, 1, com - 1) + Copy(Str2, com + 1, Length(str2) - com);
end;
Result := StrToInt(str4);
end
else
begin
Result := 0;
end;
end;


procedure Progress;
begin
Snape := Snape + InvCount;
Writeln('|===============|');
Writeln('| Snape Grass |');
Writeln('| ' + IntToStr(Snape) + ' | $' + IntToStr(Snape * SnapePrice) +
' |');
Writeln('| Time running: ' + TimeRunning + ' |');
Writeln('|===============|');
Writeln('');
end;

begin
SetupLogin;
SetupSps;
Jarvald := [3026992, 2436400, 3884876, 3757671];
SnapeGrass := [6067245, 5272868, 6195498, 5075235];
SnapePrice := GetPrice(231);
TeleToBankAndWalk;
Banking;
TeleportToHouse;
RandomChange := RandomRange(30, 80);
repeat
if (loads = 85) then //Just incase we mess up and go past out limit.
begin
loads := 0;
end;
{WalkToBoat_SPS;}
WalkToBoat_Radial;
Wait(RandomRange(100, 800));
Travel;
WalkToGoodSnapeGrass;
Wait(RandomRange(300, 1200));
CollectSnapeGrass;
TeleToBankAndWalk;
Progress;
Wait(RandomRange(640, 940));
Banking;
TeleportToHouse;
Wait(RandomRange(705, 1200));
if (RandomChange = loads) then
begin
ChangeWorld(RandomWorld(true, false));
RandomChange := RandomRange(8, 18);
loads := 0;
end;
until (false)
end.

Varrock Teletab maker

program VarrockTabMaker;
{$i srl/srl/misc/smart.scar}
{$i srl/srl.scar}
{$i sps/sps.simba}
{$i SRL/SRL/Misc/stats.simba}

var
VarrockTabBig, TabsMade, TabPrice, CashMonies: Integer;
GoIntoBank: TPointArray;
const
SRLStats_Username = ''; // Your SRL Stats Username
SRLStats_Password = ''; // Your SRL Stats Password

procedure DeclarePlayers;
begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;
Players[0].Name := '';
Players[0].Pass := '';
Players[0].Active := true;
Players[0].Pin := '';
end;

procedure SetupLogin;
begin
ClearDebug;
Smart_Server := 49;
Smart_Members := true;
Smart_Signed := true;
Smart_SuperDetail := false;
SetupSRL;
DeclarePlayers;
LoginPlayer;
end;


procedure SetupSps;
begin
SetupSRLStats(406, SRLStats_Username, SRLStats_Password);
SPS_Setup(RUNESCAPE_SURFACE, ['10_6']);
SPS_Continue := false;
end;

procedure Antiban; //idea taken from Coh3n's tutorial.
begin
if not (LoggedIn) then
Exit;
begin
case Random(250) of // Random(250) generates a random integer from 0 to 250
10: RandomRClick;
30: PickUpMouse;
50: RandomMovement;
70: BoredHuman;
89: ExamineInv;
end;
end;
end;

procedure TeleportToEdgevilleBank;
begin
if not (LoggedIn) then
Exit;
if not FindNormalRandoms then
begin
MakeCompass('n');
Writeln('Teleporting to bank...');
Wait(Random(1000));
GameTab(Tab_Magic);
MMouse(574, 232, 5, 5);
if WaitUptext('Cast', 400) then
ClickMouse2(true);
Wait(RandomRange(5000,8000));
GoIntoBank := [Point(4211, 2670)];
if SPS_WalkPath(GoIntoBank) then
Writeln('At the Bank..');
end;
end;

procedure DoBanking;
var
p, t: Integer;
begin
if not (LoggedIn) then
Exit;
while (IsMoving) do
begin
Wait(RandomRange(900, 1200));
end;
t := 0;
repeat
Inc(t);
Wait(RandomRange(700, 1000));
OpenBankNPC;
until BankScreen or PinScreen or (t = 5);
if PinScreen then
begin
p := 0;
repeat
InPin(Players[0].Pin);
Inc(p)
until BankScreen or (p > 0) or not (LoggedIn);
end;
if BankScreen then
begin
Writeln('Opened the bank...');
DepositAll;
Withdraw(0, 0, 1);
Wait(RandomRange(500, 1200));
CloseBank;
end;
if (t = 5) then
begin
Writeln('Couldn''t find bank in time... Terminating...');
TerminateScript;
end;
end;

procedure TeleportToHouse;
begin
Writeln('Breaking House teleport tab...');
if (ExistsItem(28)) then
begin
InvMouse(28, 1);
wait(RandomRange(6000, 7500));
end
else
TerminateScript;
end;


procedure WalkToLecturn;
begin
if not (LoggedIn) then
Exit;
if not FindNormalRandoms then
begin
MakeCompass('n');
Writeln('Walking to Lecturn...');
Mouse(627, 123, 10, 15, true);
Wait(RandomRange(2000, 4000));
while (IsMoving) do
begin
Wait(1000);
end;
end;
end;

procedure MainLoop;
var
x, y, xx, yy, FailSafe: Integer;
begin
while (InvCount > 5) do
begin
if (FindObjCustom(x, y, ['tudy Lec', 'tudy L'], [9212563, 4217971], 5)) then
begin
MMouse(x, y, 5, 5);
if (WaitUpText('Study', 500)) then
begin
ClickMouse2(true);
end;
end;
while not (FindBitmapToleranceIn(VarrockTabBig, xx, yy, 0, 0, 514, 332, 20)) do
begin
if (FailSafe = 500) then
begin
MainLoop;
end;
wait(50);
Inc(FailSafe);
end;
if (FindBitmapToleranceIn(VarrockTabBig, xx, yy, 0, 0, 514, 332, 20)) then
begin
MMouse(xx, yy, 10, 10);
FailSafe := 0;
if (WaitUpText('ake Varrock', 500)) then
begin
ClickMouse2(true);
IncEx(TabsMade, 1);
FindNormalRandoms;
while (FindBitmapToleranceIn(VarrockTabBig, xx, yy, 0, 0, 514, 332, 20)) do
begin
FindNormalRandoms;
wait(200);
end;
end;
end;
end;
CashMonies := (24 * TabPrice)stats_IncVariable('Varrock Tablets (Made)', 24);
stats_IncVariable('Magic EXP (Gained)', 840);
Stats_Commit;
TeleportToEdgevilleBank;
DoBanking;
TeleportToHouse;
WalkToLecturn;
GameTab(25);
MainLoop;
Exit;
end;

function GetPrice(ObjID: Integer): Integer; //Credits to putonajonny
var
Str, str2, str3, str4: string;
startat, endat, com, k, b, m: Integer;
begin
Str := GetPage('http://services.runescape.com/m=itemdb_rs/g=runescape/viewitem.ws?obj=' +
IntToStr(ObjID))startat := Pos('<th scope="row">Current guide price:</th>',
Str)if (startat > 0) then begin endat :=
Pos('<th scope="row">Today', Str) str2 :=
Copy(Str, (startat + 46), endat - startat - 63);
k := Pos('k', str2) com := Pos(',', str2) b :=
Pos('b', str2) m := Pos('m', str2) str4 := str2 if (k > 0) then
begin str3 := Copy(Str2, 1, k - 1) str4 :=
IntToStr(StrToInt(Copy(Str3, 1, Length(Str3) - 2) + Copy(Str3, Length(Str3), 1))
* 100)
end;
if (b > 0) then
begin
str3 := Copy(Str2, 1, b - 1) str4 :=
IntToStr(StrToInt(Copy(Str3, 1, Length(Str3) - 2) + Copy(Str3, Length(Str3), 1))
* 100000000)
end;
if (m > 0) then
begin
str3 := Copy(Str2, 1, m - 1) str4 :=
IntToStr(StrToInt(Copy(Str3, 1, Length(Str3) - 2) + Copy(Str3, Length(Str3), 1))
* 100000)
end;
if (com > 0) then
begin
str4 := Copy(Str2, 1, com - 1) + Copy(Str2, com + 1, Length(str2) - com)
end;
Result := StrToInt(str4)
end
else
begin
Result := -1
end;
end;





begin
SetupLogin;
SetupSps;
VarrockTabBig := BitmapFromString(52, 53,
'meJzN2VtKQzEQBuDF+OKeSiml1E' +
'tbe/FeRNyfKxH3IBgcCONkMvlnEqqQB/HkJJ//JKc2Z7Xerda7zea' +
'w3d7xtt8/5HZ7+8Tb/f0xt4fHl7LRJeqcB6Fh00SprX4mvbq+oXZx' +
'uU5tubxeLC7n8+VstphO55PJbPXbxklCxUlC9XV+xlspzMhSmJElT' +
'4XhQQlVTShi5EIeo+DR1QyLBdUUqoXO6ycLBY/belRPz6/UkBjLpV' +
'iz5YLGypdVvOFCQqo8EZqrfKrKKySkyitDG6LChYTMPGHLu4Bgxmh' +
'eFSJMTY0u23hoAVW4Zw6QeKKsIjTVFksDv0uUlXhky7ughMVUgRGI' +
'J8pqFBQnNfuANh5dsuGhdRZO7WzvCCS0ng1r31uLjtvKXeAtkEuoX' +
'irLqha0NmxApQ7VXHVkw0PrhBmj1aI7WWiIjXhem5jl8+M9tSam7N' +
'Z8CPDoYqEhNrUPMpfLBs4L9sGj4zZ8pdG8Nq9pa+6IQGhIdPZVMLp' +
'mt/9mQ54bdlmbFUd4sdBsALJTTmMrGeDTr8n7Kxuem+sBYjN6QuPz' +
'1mw90Y0Krf9TfqBNhJaeIUhPPDoXzPhcKG390Y0KLdsGRoc/cu3QV' +
'NuQyvaHRv9hjrIRr3OlpZ/56Y19I/8lwgvY1NAQW8mLCY0R1F1A5w' +
'+uvysgtO+thQbaDJ4tRO6qhUbfF8Dl6hIGupXH6batFouBdGVr29L' +
'30+PxrTl1oGquGwXMZfMuLe8iVAuq2sKL327GmLUj/WRTeQOFNqn2' +
'UmmzORi2fiGoKl/J0RkX2WxeYB3iqiE2UBhW8YLSCxqvrVlokCRUt' +
's3LA3cfqBKvBeksmttivFLoIqmvzsn2Dc/IBoY=');
TabPrice := GetPrice(8007);
DoBanking;
TeleportToHouse;
WalkToLecturn;
GameTab(25);
MainLoop;
end.

Edgeville Man Killer
//EDGEVILLE MAN KILLER - MADE BY ~JUSTIN
program EdgeManKiller;
{.include SRL/SRL/Misc/Smart.scar}
{.include SRL/SRL.scar}
{.include SRL/SRL/Skill/Fighting.scar}
{$i sps/sps.simba}
{$DEFINE UseLaptopMouse}
var
ManColours : TIntegerArray;
x,y,StartAttack, StartStrength, StartDefence, StartHitpoints, CurrentAttack, CurrentStrength, CurrentDefence, CurrentHitpoints, LevelPopUp, NoThanks, xx,yy : integer;
WalkBank,WalkMen: TPointArray;
const
Tolerance = 2; //Make higher if it wont attack;
Version = '0.501'; //Please don't change.
procedure DeclarePlayers;
begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;
With Players[0] do
begin
Name := ''; //Character Name
Pass := ''; //Character Pass
Pin := ''; //Pin for bank
Active := True;

end;

end;

function GetCustomXP(skill: variant): integer;
var
b: TBox;
p: TPoint;
tpa: TPointArray;
begin
result := -1;
if (not gameTab(TAB_STATS)) then
exit;
p := skillToCoords(skill);
if (p.x < 1) then
exit;
mmouse(p.x, p.y + 5, 12, 4);
Wait(150);
if (WaitFindColors(tpa, 921102, MIX1, MIY1, MIX2, MIY2, 0, 3000)) then
begin
b := getTPABounds(tpa);
Result := strToIntDef(getNumbers(getTextAt(b.x1 + 15, b.y1 + 15, 0, 1, 4, 4305653, 0, 75, smallChars)), -1);
end;
end;


function WalkToBank: Boolean;
begin
WalkBank := [Point(4224, 2633),Point(4208, 2649),Point(4210, 2667)]
If(SPS_WalkPath(WalkBank)) then
end;

function WalkToMen: Boolean;
begin
WalkMen := [Point(4208, 2649),Point(4232, 2608)]
If(SPS_WalkPath(WalkMen)) then
end;



procedure CheckRandoms;
begin
if (FindBitMap(LevelPopUp,x,y)) then
begin
FreeBitmap(LevelPopUp);
FindBitMap(NoThanks,xx,yy)
MMouse(xx,yy,3,3);
ClickMouse2(true);
FreeBitmap(NoThanks);
end;
FindNormalRandoms;
if not(LoggedIn) then
begin
WriteLn('I think we failed a random - I will just Check');
LoginPlayer;
FindNormalRandoms;
if not(LoggedIn) then
begin
WriteLn('Client has Logged Out So Probably Failed a Random - Terminating Script');
TerminateScript;
end ;
end;
end;


procedure Attack;
var Xi, Yi:integer;
begin
if InFight then
begin
repeat
FindNormalRandoms;
until (not (OthersInFight) or (not LoggedIn) or (not InFight))
end;
x := Random(8)
case x of
4: WalkToMen; //Failsafe if we get lured
end;
if FindObjCustom(Xi, Yi, ['ttack'], ManColours, Tolerance) then
begin
if not (IsFightAt(Xi, Yi) and not InFight) then
begin
GetMousePos(Xi, Yi);
Mouse(Xi, Yi, RandomRange(-3,5), RandomRange(-3,5), false);
WaitOptionMulti(['ttack M', 'attack Man'], 200);
wait(RandomRange(800,1200))
end;
while IsMoving do
begin
Wait(250);
end;
end;
SetAngle(True);
end;


procedure AntiBan;
begin
x := Random(500)
case x of
0: HoverSkill('Attack', False);
1: HoverSkill('Strength', False);
2: HoverSkill('Defence', False);
3: HoverSkill('hitpoints', False);
12..15: PickUpMouse;
16..25: RandomMovement;
26..27: RandomRClick;
28..32: BoredHuman;
33: ExamineInv;
34: RandomAngle(True);
end;
end;
function DoBanking: Boolean;
var
FailSafe: Integer;
begin
if not (LoggedIn) then
Exit;
while (IsMoving) do
begin
Wait(RandomRange(900, 1200));
end;
FailSafe := 0;
repeat
Inc(FailSafe);
MakeCompass('n');
Wait(RandomRange(400, 1200));
OpenBankNPC;
until BankScreen or PinScreen or (FailSafe = 7);
if PinScreen then
begin
repeat
InPin(Players[0].Pin);
until BankScreen or not (LoggedIn);
end;
if BankScreen then
begin
Withdraw(0,0,RandomRange(17,28));
CloseBank;
WalkToMen;
end;
if (FailSafe = 7) then
begin
Writeln('We failed to find the bank 7 times. Terminating script.');
TerminateScript;
end;
end;

procedure Report;
begin
CurrentAttack := GetCustomXP(0);
CurrentStrength := GetCustomXP(2);
CurrentDefence := GetCustomXP(1)
CurrentHitpoints := GetCustomXP(3);
Writeln('||=====');
Writeln('||===== Attack EXP Gained : ' + IntToStr(CurrentAttack - StartAttack));
Writeln('||===== Strength EXP Gained : ' + IntToStr(CurrentStrength - StartStrength));
Writeln('||===== Defence EXP Gained : ' + IntToStr(CurrentDefence - StartDefence));
Writeln('||===== Hitpoints EXP Gained : ' + IntToStr(CurrentHitpoints - StartHitpoints));
Writeln('||=====');
exit;
end;


procedure HpCheck; //Credits to Narcle
var
c, T, i, x, y:Integer;
begin
if (HPPercent < RandomRange(45,65)) and LoggedIn then
begin
if not InvEmpty then
for c := 0 to 2 do
for i := 1 to 28 do
if ExistsItem(i) then
begin
MMouseItem(i);
GetMousePos(x, y);
if WaitUptext('Eat', 400) then
begin
Mouse(x,y,0,0,false);
if WaitOption('Eat', 400) then
begin
t := GetSystemTime;
while ExistsItem(i) and ((GetSystemTime-t) < 2000) do
wait(20);
end;
Exit;
end;
end;
if InvEmpty then
begin
WalkToBank;
If IsMoving then
repeat
Wait(500);
until not (IsMoving);
Report;
DoBanking;
WalkToMen;
Exit;
end;
end;
end;

procedure VersionCheck();
var
oVersion : string;
begin
oVersion := GetPage('http://web.aanet.com.au/SRLJustin/EdgevilleManKiller/edgeman_version.txt');
if(oVersion <> Version)then
begin
WriteLn('The version you''re using is outdated!');
WriteLn('Downloading new version...');
if(WriteFileString(RewriteFile(ScriptPath + 'EdgeManKiller ~Justin.simba', True), GetPage('http://web.aanet.com.au/SRLJustin/EdgevilleManKiller/edgeman_script.txt')))then
WriteLn('Successfully downloaded the script! Please close the script and re-open to see the changes, thank you!');
TerminateScript;
end
else
WriteLn('You have the current version, good to go!');
end;

begin
Cleardebug;
Writeln('Please wait while I check your script version...');
VersionCheck();
ManColours := [991283 ,2367519 ,4344898 ,4824485 ,3033449 ,3100779 ,1977654];
Smart_Server := 97;
Smart_Members := False;
Smart_Signed := False;
Smart_SuperDetail := False;
SetupSRL;
DeclarePlayers;
LoginPlayer;
SPS_Areas := ['10_6'];
SPS_Setup(RUNESCAPE_SURFACE, SPS_Areas);
Writeln('Welcome to ~Justin''s Edgeville Man Killer! Verson: '+ Version);
Wait(800);
Writeln('Grabbing starting EXP...');
MouseSpeed := RandomRange(17,22);
StartAttack := GetCustomXP(0); //atk
StartStrength := GetCustomXP(2); //str
StartDefence := GetCustomXP(1) //def
StartHitpoints := GetCustomXP(3); //hp
Writeln('Grabbed and saved starting EXP!');
WalkToMen;
LevelPopUp := BitmapFromString(22, 42, 'meJytlVFIU2EUx0lpU+emu3fmYE' +
'7nNpzioIjZMiaYOlOn2Z2WuhRdZelSclpiI600ycKKsgyiguohCnz' +
'0ITJ86alegwp6Dnrtrbf+957xeXfvnQsM/hzOPff8f/d83+79Vmh1' +
'Fu5Mh1pPHGzuQqzvONkgDAS7o4gVtfUd/TFUqF7TKNSF+pAjQuhBn' +
'p3HZetN2XojGSEUISTwIg6MXUYz3SLX6ss14lPUmUugPN52Kj4Xm7' +
'mBCAsiJETHu4cnkfSNXoJQhxYfPkcbEsSzUj8joB916iTLkchZFAf' +
'jsxCKPSPTAEIspzZ4CaImvPr088G7Lwo93viqFjrtDo29xS1drr9N' +
'eBLqWkWEmjtWSYdDy0w5ehc6QdDv8SiEJ5a5b1W1bkKVLRuUqC9Nj' +
'jg6S8tduWV+uUxOP+pc8QX0FHnvVfjvFFcs8JVLyBG9gbsl3pvIcV' +
'dvEohgqGpj4ryiUDcXxdDDVy2Nza2//fCt2LOAHPaP3381HX8GlEg' +
'whohg3N/P+yJyTdx/w0szwMW752duvweE7J1DLzj3PCOgEwSFnQj5' +
'ljh6LBIBuray+eP3H9jFSxQlQo6xhQiW2iGFGIHsHt8inv7o9WdMY' +
'nVfwQyca15N4AMxpsHZlXxLjAhkb488LbQnphbWGYQI6BRXIfOSjo' +
'7OGrgz6IFrZHqN7JxjjiB4PQrsCYkQRKeaUNKQQtAUEXSGpiShfir' +
'dDNtLTrAFJ8lLCepZu6v1prDOEIT0xnYS8hxjs1RsgnZllW6tgiAY' +
'RkpQ/0d1phLMdRMEsZe7MssBOWGHmJHNQPNQwoQdhmyBqLUmbPI05' +
'tv3FVid3acnILVdU1uEA72M0H9+BtK2tyVEZZqBCBpPlNulxBmKE4' +
'QIBe46IvSeuwgp+1NV3p5Qz8B7tAhqoxQhNkCGGXZAoDa5l10m89R' +
'VcL4eEAy2araT8sfJpUnAOWDeG2aEnuEpiNpcQsIVvq6AYH75Eugk' +
'kRNoBhhFCSJEY5LUARQE2ockQQWRv1H05aoJ9FaTPbkQQcNOhORh6' +
'ItoEhQbqP4i2AzahDSTKwhsBvwlqX9NjYWzz1w6OdMR2Bul/hIZRG' +
'FXrGLrrU5/LMh/BSLIZ6B90DbSoRGIbU84Fh2HMtoZId0+aNhV/2L' +
'/i6BeRfzqMvQX5OsJfg==');

NoThanks := BitmapFromString(75, 14, 'meJztks1qAkEQhN8hBy9CEJSAIu' +
'IhSH4ugiB4UBD0oMccPOUNfDUfJve8REYGyqJ6undXEBECH8t0b1V' +
'Nz+5svo+bW/Kx2t83Z7E/MCknIR3RxLA+rU8/v00TiplX58y2XyDn' +
'5CjuoKxE9E3tNWMb8bncAT4gd7gEbJQECLi0rmIfRu7bMeIQ5m2+B' +
'sjJT+5gDXLT2lnAgeIqpnn6q0dK9CdTIAfkjv0X0BQT2M5Gdtk0T2' +
'8Xshd2jAkC7WzxAWuW3kG8eby3wem6o3cAC69lC6v0EuJSble8C/9' +
'Zu13xFXjuvwIE8lq2tkovISi9C1+pt5tKgsyTaL+MAWRcxiOxnRPy' +
'q2JgnQMGehHE85zpDcFFRiU6cqkgE4qfxebHV1T01sj3Np6n1RkwS' +
'SYld/iLidFz2cBiWqVejPXneWr3/nlo/gDohg86');
repeat
Attack;
AntiBan;
HpCheck;
CheckRandoms;
until(false)
end.

mika

2011-12-23 23:51:43

very nice you're up to a good start and you know how to use SPS but im gonna have say no bc the script is unfinished.

Justin

2011-12-23 23:53:33

From: mika
very nice you're up to a good start and you know how to use SPS but im gonna have say no bc the script is unfinished.


What script is unfinished?
They are all functional and working fine. I am running the Snape Grass and Edgeville Man Killer right now…

Daniel

2011-12-24 00:59:17

Your other application hasn't closed yet? Nor do you wait the specified time before applying again (a month, in some special cases two weeks minimum, you are [thus far] day after day).

Also, break up your scripts in separate [simba] tags.

Hobbit

2011-12-24 01:27:40

I'll let it slide because its Christmas, but please, for the love of God, stop making applications :p Wait till the current one is finished. Please do not even think about applying again until this thread closes on Jan 6. And after that you will have to wait 2 weeks to a month to reapply if you get denied. This is the last application I will let slide.

Silent

2011-12-24 02:56:23

Auto no for not waiting for your other app to close. Should have just changed the script in that one and told us. We would have looked over your changes, and possibly changed our votes, but you have to play by the rules.

Good luck in a few weeks.

Daniel

2011-12-24 03:55:23

The reason I had not voted as of yet, is because these scripts show much greater intelligence than his other two previous applications.

Now that Hobbit (part 1: An Unexpected Journey) has commented on this, I am going to have to say no.

  • You constantly use ClickMouse2() throughout your script directly after using MMouse, why? Just use the procedure, Mouse (that moves the mouse and clicks afterwards).
  • GoToBank; Banking; TeleportToHome; WalkToBoat; Travel; What? That's a bit sudden isn't it to be doing those things? You don't wait (or sleep) before doing any of those? Do you, as a human, do things that fast without having to stop and think?
  • Throughout your scripts, I see very little waits (or sleeps), or when I do they will be static (i.e. waiting for exactly X milliseconds, no randomness to them). Example (at the very end):

  • procedure TeleportToHome;
    begin
    writeln('We are going to teleport to home');
    while (srl_InFight) do
    begin
    Wait(RandomRange(1500, 1800));
    writeln('Waiting to be out of combat...');
    end;

    InvMouse(1, 1);
    wait(4000);
    end;
  • Have you even compiled your scripts to see if they are working? These tell me you haven't:

  • function WalkToBank: Boolean;
    begin
    WalkBank := [Point(4224, 2633),Point(4208, 2649),Point(4210, 2667)]
    If(SPS_WalkPath(WalkBank)) then
    end;

    function WalkToMen: Boolean;
    begin
    WalkMen := [Point(4208, 2649),Point(4232, 2608)]
    If(SPS_WalkPath(WalkMen)) then
    end;
    If, then, what? You'll get an error… Even:

    end else
    begin
    Result := -1
    end
    end;
    Will cause an error when clicking Run (/play), you have no semi-colon appending the second-to-last end?
  • procedure CheckRandoms; begin if (FindBitMap(LevelPopUp,x,y)) then begin FreeBitmap(LevelPopUp); What? Why free it? Where else do you load it again? You'll get an error when calling this function a second time.
  • function DoBanking: Boolean;
  • var FailSafe: Integer; begin if not (LoggedIn) then Exit; while (IsMoving) do begin Wait(RandomRange(900, 1200)); end; FailSafe := 0; repeat Inc(FailSafe); MakeCompass('n'); Wait(RandomRange(400, 1200)); OpenBankNPC; until BankScreen or PinScreen or (FailSafe = 7); if PinScreen then begin repeat InPin(Players[0].Pin); until BankScreen or not (LoggedIn); end; if BankScreen then begin Withdraw(0,0,RandomRange(17,28)); CloseBank; WalkToMen; end; if (FailSafe = 7) then begin Writeln('We failed to find the bank 7 times. Terminating script.'); TerminateScript; end; end; Why make it a function? You don't return anything. Also, what if it finds the pin or bank screen on your final try and your Failsafe variable is equal to 7? It will terminate the script regardless.
  • Some people will comment on this, but it isn't really a bother to me since I could read and comprehend your script just fine, but your standards are iffy (NOTE: NOT a major voting point for me, however for some, it is).
  • Shouldn't you switch this around?



  • procedure CheckRandoms;
    begin
    if (FindBitMap(LevelPopUp,x,y)) then
    begin
    FreeBitmap(LevelPopUp);
    FindBitMap(NoThanks,xx,yy)
    MMouse(xx,yy,3,3);
    ClickMouse2(true);
    FreeBitmap(NoThanks);
    end;
    FindNormalRandoms;
    if not(LoggedIn) then
    begin
    WriteLn('I think we failed a random - I will just Check');
    LoginPlayer;
    FindNormalRandoms;
    if not(LoggedIn) then
    begin
    WriteLn('Client has Logged Out So Probably Failed a Random - Terminating Script');
    TerminateScript;
    end ;
    end;
    end;
    As in, put the if..not LoggedIn then first? It would make more sense.
  • I see SPS walking, but no fail safes. In fact, very little fail safes for anything.
  • You use bitmaps. Do they always get found? Try using FindBitmapToleranceIn instead, or better yet, use DTMs or DDTMs (the latter is looked highly upon).
  • You implement version checking, which is nice. However, please avoid from using your own server to host the script (security precautions) and always allow the user to choose whether to update or not. :) Instead, just link to the thread which you posted your script at SRL. :)

Sorry, but it's going to be a no. I am sorry if this is not what you wanted to hear/read, but your script shows little complexity that which a SRL member would know how to use/implement.

Seasons greetings, Merry Christmas and we will see you apply again after the New Year :) (<- yes, you can only apply again after the new year, no sooner).

Justin

2011-12-24 04:09:59

From: Daniel
The reason I had not voted as of yet, is because these scripts show much greater intelligence than his other two previous applications.

Now that Hobbit (part 1: An Unexpected Journey) has commented on this, I am going to have to say no.

  • You constantly use ClickMouse2() throughout your script directly after using MMouse, why? Just use the procedure, Mouse (that moves the mouse and clicks afterwards).
  • GoToBank; Banking; TeleportToHome; WalkToBoat; Travel; What? That's a bit sudden isn't it to be doing those things? You don't wait (or sleep) before doing any of those? Do you, as a human, do things that fast without having to stop and think?
  • Throughout your scripts, I see very little waits (or sleeps), or when I do they will be static (i.e. waiting for exactly X milliseconds, no randomness to them). Example (at the very end):

  • procedure TeleportToHome;
    begin
    writeln('We are going to teleport to home');
    while (srl_InFight) do
    begin
    Wait(RandomRange(1500, 1800));
    writeln('Waiting to be out of combat...');
    end;

    InvMouse(1, 1);
    wait(4000);
    end;
  • Have you even compiled your scripts to see if they are working? These tell me you haven't:

  • function WalkToBank: Boolean;
    begin
    WalkBank := [Point(4224, 2633),Point(4208, 2649),Point(4210, 2667)]
    If(SPS_WalkPath(WalkBank)) then
    end;

    function WalkToMen: Boolean;
    begin
    WalkMen := [Point(4208, 2649),Point(4232, 2608)]
    If(SPS_WalkPath(WalkMen)) then
    end;
    If, then, what? You'll get an error… Even:

    end else
    begin
    Result := -1
    end
    end;
    Will cause an error when clicking Run (/play), you have no semi-colon appending the second-to-last end?
  • procedure CheckRandoms; begin if (FindBitMap(LevelPopUp,x,y)) then begin FreeBitmap(LevelPopUp); What? Why free it? Where else do you load it again? You'll get an error when calling this function a second time.
  • function DoBanking: Boolean;
  • var FailSafe: Integer; begin if not (LoggedIn) then Exit; while (IsMoving) do begin Wait(RandomRange(900, 1200)); end; FailSafe := 0; repeat Inc(FailSafe); MakeCompass('n'); Wait(RandomRange(400, 1200)); OpenBankNPC; until BankScreen or PinScreen or (FailSafe = 7); if PinScreen then begin repeat InPin(Players[0].Pin); until BankScreen or not (LoggedIn); end; if BankScreen then begin Withdraw(0,0,RandomRange(17,28)); CloseBank; WalkToMen; end; if (FailSafe = 7) then begin Writeln('We failed to find the bank 7 times. Terminating script.'); TerminateScript; end; end; Why make it a function? You don't return anything. Also, what if it finds the pin or bank screen on your final try and your Failsafe variable is equal to 7? It will terminate the script regardless.
  • Some people will comment on this, but it isn't really a bother to me since I could read and comprehend your script just fine, but your standards are iffy (NOTE: NOT a major voting point for me, however for some, it is).
  • Shouldn't you switch this around?



  • procedure CheckRandoms;
    begin
    if (FindBitMap(LevelPopUp,x,y)) then
    begin
    FreeBitmap(LevelPopUp);
    FindBitMap(NoThanks,xx,yy)
    MMouse(xx,yy,3,3);
    ClickMouse2(true);
    FreeBitmap(NoThanks);
    end;
    FindNormalRandoms;
    if not(LoggedIn) then
    begin
    WriteLn('I think we failed a random - I will just Check');
    LoginPlayer;
    FindNormalRandoms;
    if not(LoggedIn) then
    begin
    WriteLn('Client has Logged Out So Probably Failed a Random - Terminating Script');
    TerminateScript;
    end ;
    end;
    end;
    As in, put the if..not LoggedIn then first? It would make more sense.
  • I see SPS walking, but no fail safes. In fact, very little fail safes for anything.
  • You use bitmaps. Do they always get found? Try using FindBitmapToleranceIn instead, or better yet, use DTMs or DDTMs (the latter is looked highly upon).
  • You implement version checking, which is nice. However, please avoid from using your own server to host the script (security precautions) and always allow the user to choose whether to update or not. :) Instead, just link to the thread which you posted your script at SRL. :)

Sorry, but it's going to be a no. I am sorry if this is not what you wanted to hear/read, but your script shows little complexity that which a SRL member would know how to use/implement.

Seasons greetings, Merry Christmas and we will see you apply again after the New Year :) (<- yes, you can only apply again after the new year, no sooner).


Thank-you for a very detailed response Daniel.

I am going to learn from what you have said and improve my scripts even more.

Have a good Christmas.

Daniel

2011-12-24 04:13:01

From: ~Justin
Thank-you for a very detailed response Daniel.

I am going to learn from what you have said and improve my scripts even more.

Have a good Christmas.


Also, wait for other members comments and responses to see if they can pick up on anything I haven't :)

EDIT: 3 hours and 45 more minutes for you and I until it is Christmas :p

mika

2011-12-24 11:59:27

From: ~Justin
What script is unfinished?
They are all functional and working fine. I am running the Snape Grass and Edgeville Man Killer right now…


Srry i voted yeasterday and there was only the snape grass script.

Kyle Undefined

2011-12-24 12:57:48

Isn't this your third application? Jesus! However, since I'm out of town and drinking a nice liquor, I won't hold it against you. Holding my vote for now.

cycrosism

2011-12-26 02:47:35

Nope, you have been a member for almost 4 years and you have just under 70 posts. Not active enough.

Justin

2011-12-26 03:40:34

From: cycrosism
Nope, you have been a member for almost 4 years and you have just under 70 posts. Not active enough.


So we are going off post counts now?

cycrosism

2011-12-26 04:33:14

From: ~Justin
So we are going off post counts now?


The script is NOT the only thing that matters in becoming an SRL member. There are other factors such as activity and attitude.

Justin

2011-12-26 04:43:07

From: cycrosism
The script is NOT the only thing that matters in becoming an SRL member. There are other factors such as activity and attitude.


But it seems you voted no because of my post count.

Daniel

2011-12-26 04:46:35

From: cycrosism
Not active enough.

He's active now. Look at his activity bar. Nearly half way.

cycrosism

2011-12-26 05:17:53

From: Daniel
He's active now. Look at his activity bar. Nearly half way.


In 4 years he has only got 70 posts. That is not very active at all.

Gu3st...

2011-12-26 05:57:35

From: cycrosism
In 4 years he has only got 70 posts. That is not very active at all.
So because he created the account at some point in time, then left and now rejoined is bad? If the account was created now in december, would you feel the same way?

Justin

2011-12-26 06:01:23

Thanks Daniel and Zyt3x for your support in the whole 'activity' issue.

cycrosism

2011-12-26 06:46:10

From: Zyt3x
So because he created the account at some point in time, then left and now rejoined is bad? If the account was created now in december, would you feel the same way?


It seems to me that he created the account a while ago to leach the scripts and now because of the bot nuke update since no other bots work he has decided to come here.

If he created the account in December I would still feel the same way. He should be an active member in the community and not try to rush into everything.

Daniel

2011-12-26 06:54:48

From: cycrosism
It seems to me that he created the account a while ago to leach the scripts and now because of the bot nuke update since no other bots work he has decided to come here.

If he created the account in December I would still feel the same way. He should be an active member in the community and not try to rush into everything.

But now because of that 'nuke', he knows how to create Simba scripts, has contributed those scripts for communal use, has helped a few and has contributed to community discussions. How is this not being "an active member in the community"?

Sabzi

2011-12-26 06:55:00

I don't either see why the hurry of becoming member.
And I also like to know better who is member which is for me not really possible with such a low post count.
Like they are not my friends(other members) but I know a lot of them, how they feel, how they write, what they are capable of(at least their online personality) and that from hundreds of posts.
But I would have voted no just for the script too. Way not advanced enough.

@Daniel: If he wants to contribute/be active he can just be so the rank he is. No need to rush members. I see where cycrosism coming from, it seems like he(applicant) only wants better scripts. I don't say he is, but maybe.

Justin

2011-12-26 07:01:51

From: cycrosism
It seems to me that he created the account a while ago to leach the scripts and now because of the bot nuke update since no other bots work he has decided to come here.

If he created the account in December I would still feel the same way. He should be an active member in the community and not try to rush into everything.


Funny that… you are jumping to conclusions there mate…

When I made this account I was exploring bots… Colour bots just didn't cut it for me, moved onto more advanced bots, quit botting/runescape for around 1 - 1 and a half years, returned to botting around 6 months ago. Reflections died. Reverted back to Simba/SRL to learn how to make scripts so I am able to help keep botting 'alive'

Gu3st...

2011-12-26 07:24:10

You clearly have the attitude and maturity of an srl member, and an app with 3 scripts in it shows that you put a great deal of time and work into this.

I vote yes.

Dervish

2011-12-26 07:49:04

From: cycrosism
Nope, you have been a member for almost 4 years and you have just under 70 posts. Not active enough.


Really ..?

Post count post count… Who gives a damn about the post count ?

If one had 9561 posts but a bad script, would you let him in ?

My guess is no, as I believe you are a clever boy.

cycrosism

2011-12-26 08:07:03

From: Dervish
Really ..?

Post count post count… Who gives a damn about the post count ?


A lot of people care about the post count

From: Dervish
If one had 9561 posts but a bad script, would you let him in ?


I do not base my vote completely off user activity, so no.

Sure, it counts as a minor factor, and if the user activity is somewhat good at the least, very well, I will continue on and look at the application, point out what can be improved and/or changed on the script and also state why.

I vote yes or no based on three things. Activity, script and attitude.

From: Dervish
My guess is no, as I believe you are a clever boy.


You guessed right

Kyle Undefined

2011-12-26 10:15:58

Well he has the attitude, his scripts are solid, and his activity is increasing. So where is your problem?

Yes.

hamster31

2011-12-26 14:13:40

Dude, Im sorry but Post Count should not be used as a good measure for the persons knowledge…its the type of posts…Seriously..

YES FROM ME!…

You have an excellent attitude…and u deserve this

Griff

2011-12-26 14:55:53

Because of things said already, I am voting yes. Only thing for me is that your standards are a bit off in some places, but that's no reason for a no :)

Putnam

2011-12-26 16:24:44

Voting yes. Good attitude, accepting of criticism, and willingness to script. :)

Justin

2011-12-27 05:30:44

Please review my application.
Reason: Added varrock teletab maker

WT-Fakawi

2011-12-27 05:35:13

Original, persistent… creative. Yes.

Justin

2011-12-27 05:38:54

From: WT-Fakawi
Original, persistent… creative. Yes.


Thank you, means a lot to me for the SRL Leader to vote.

P1nky

2011-12-27 05:45:34

I am Sorry, but No from me.

Too simple in my opinion for a SRL Member rank, although seems like your going to the right direction.

-Your failsafes are just too simple.
-Simple mouse movement

-I rather see a 1 whole script than little snippets of a script, you can do so much with one little script, add more functions/procedures/features/failsafes.
what I see right now is basically like in Novels we have summaries, well this is exactly a Summary of those scripts.


Sorry mate.

Kasi

2011-12-27 05:50:18

yes, keep scripting =]

Justin

2011-12-27 06:18:30

Thanks for the vote.

Update: Added SRL Stats to Varrock Tab Maker

PatDuffy

2011-12-27 23:41:24

Decided to vote NO for reasons stated in Daniel's post on the first page, because you applied several times without waiting for your previous app to close(I see this as a tendency to not follow instructions), and because I can.

I actually didn't even realize I hadn't reviewed this App yet. Also, please do not take this as I hate you for releasing a rival Tele-Tabber, I'm indifferent about that.

You need to show a little variety in your practices, and come up with some unique functions using TPA's or DTM's as you have not used any of those.

Your effort to fix problems we point out has not gone unnoticed, however. That is a good quality I like to see in a potential member, I would just like to see a little bit more detailed script.

Justin

2011-12-27 23:48:10

From: PatDuffy
Decided to vote NO for reasons stated in Daniel's post on the first page, because you applied several times without waiting for your previous app to close(I see this as a tendency to not follow instructions), and because I can.

I actually didn't even realize I hadn't reviewed this App yet. Also, please do not take this as I hate you for releasing a rival Tele-Tabber, I'm indifferent about that.

You need to show a little variety in your practices, and come up with some unique functions using TPA's or DTM's as you have not used any of those.

Your effort to fix problems we point out has not gone unnoticed, however. That is a good quality I like to see in a potential member, I would just like to see a little bit more detailed script.


Just to correct you on one thing, I didn't release my Tab maker nor do I plan to.

I am currently making a Green Dragon Killer that will include DTM's and TPA's.

I hope once this script is made you will reconsider your vote.

Thanks.

PatDuffy

2011-12-27 23:52:38

Ooooo my bad with even mentioning that :p

I saw Tab-Maker and assumed it was the one that someone released, must have been someone else.

Also, if you do not complete that script by the time your application closes, DO NOT create another Application within 30 days, as stated several times.

Flight

2011-12-27 23:57:20

The scripts look nice if you ask me, but I'd like to see you active around the forums. We're good people, my friend, you should get to know us. ;) Just have some patience on gaining Membership, it's not like SRL is gonna close down this month. :S There's no rush to get a rank on a forum, if you really want to be a part of this then something as simple as a rank should not be holding you back; I know it never held me back. ;)

Justin

2011-12-28 07:26:36

Woah. Was going good with the votes then BAM…

BraK

2011-12-28 07:34:37

The quote below is a good enough reason to vote no. My question then becomes not why he has so many no's but why so many Yes's. Are you all clicking yes just to spite cycrocism. If so then you good sir need to rethink your priorities in life. Your ability to deal with others opinions has much needed work. He has applied 3 times in 3 days…. That's an application a day for 3 days in a row. And the first 2 weren't even closed before creating a new one. There is a 2 week at the very least needed wait time between Applications. We see enough spam around the rest of the Forums…

See his previous Applications.

http://villavu.com/forum/showthread.php?t=69717

http://villavu.com/forum/showthread.php?t=69755


From: Daniel
The reason I had not voted as of yet, is because these scripts show much greater intelligence than his other two previous applications.

Now that Hobbit (part 1: An Unexpected Journey) has commented on this, I am going to have to say no.

  • You constantly use ClickMouse2() throughout your script directly after using MMouse, why? Just use the procedure, Mouse (that moves the mouse and clicks afterwards).
  • GoToBank; Banking; TeleportToHome; WalkToBoat; Travel; What? That's a bit sudden isn't it to be doing those things? You don't wait (or sleep) before doing any of those? Do you, as a human, do things that fast without having to stop and think?
  • Throughout your scripts, I see very little waits (or sleeps), or when I do they will be static (i.e. waiting for exactly X milliseconds, no randomness to them). Example (at the very end):

  • procedure TeleportToHome;
    begin
    writeln('We are going to teleport to home');
    while (srl_InFight) do
    begin
    Wait(RandomRange(1500, 1800));
    writeln('Waiting to be out of combat...');
    end;

    InvMouse(1, 1);
    wait(4000);
    end;
  • Have you even compiled your scripts to see if they are working? These tell me you haven't:

  • function WalkToBank: Boolean;
    begin
    WalkBank := [Point(4224, 2633),Point(4208, 2649),Point(4210, 2667)]
    If(SPS_WalkPath(WalkBank)) then
    end;

    function WalkToMen: Boolean;
    begin
    WalkMen := [Point(4208, 2649),Point(4232, 2608)]
    If(SPS_WalkPath(WalkMen)) then
    end;
    If, then, what? You'll get an error… Even:

    end else
    begin
    Result := -1
    end
    end;
    Will cause an error when clicking Run (/play), you have no semi-colon appending the second-to-last end?
  • procedure CheckRandoms; begin if (FindBitMap(LevelPopUp,x,y)) then begin FreeBitmap(LevelPopUp); What? Why free it? Where else do you load it again? You'll get an error when calling this function a second time.
  • function DoBanking: Boolean;
  • var FailSafe: Integer; begin if not (LoggedIn) then Exit; while (IsMoving) do begin Wait(RandomRange(900, 1200)); end; FailSafe := 0; repeat Inc(FailSafe); MakeCompass('n'); Wait(RandomRange(400, 1200)); OpenBankNPC; until BankScreen or PinScreen or (FailSafe = 7); if PinScreen then begin repeat InPin(Players[0].Pin); until BankScreen or not (LoggedIn); end; if BankScreen then begin Withdraw(0,0,RandomRange(17,28)); CloseBank; WalkToMen; end; if (FailSafe = 7) then begin Writeln('We failed to find the bank 7 times. Terminating script.'); TerminateScript; end; end; Why make it a function? You don't return anything. Also, what if it finds the pin or bank screen on your final try and your Failsafe variable is equal to 7? It will terminate the script regardless.
  • Some people will comment on this, but it isn't really a bother to me since I could read and comprehend your script just fine, but your standards are iffy (NOTE: NOT a major voting point for me, however for some, it is).
  • Shouldn't you switch this around?



  • procedure CheckRandoms;
    begin
    if (FindBitMap(LevelPopUp,x,y)) then
    begin
    FreeBitmap(LevelPopUp);
    FindBitMap(NoThanks,xx,yy)
    MMouse(xx,yy,3,3);
    ClickMouse2(true);
    FreeBitmap(NoThanks);
    end;
    FindNormalRandoms;
    if not(LoggedIn) then
    begin
    WriteLn('I think we failed a random - I will just Check');
    LoginPlayer;
    FindNormalRandoms;
    if not(LoggedIn) then
    begin
    WriteLn('Client has Logged Out So Probably Failed a Random - Terminating Script');
    TerminateScript;
    end ;
    end;
    end;
    As in, put the if..not LoggedIn then first? It would make more sense.
  • I see SPS walking, but no fail safes. In fact, very little fail safes for anything.
  • You use bitmaps. Do they always get found? Try using FindBitmapToleranceIn instead, or better yet, use DTMs or DDTMs (the latter is looked highly upon).
  • You implement version checking, which is nice. However, please avoid from using your own server to host the script (security precautions) and always allow the user to choose whether to update or not. :) Instead, just link to the thread which you posted your script at SRL. :)

Sorry, but it's going to be a no. I am sorry if this is not what you wanted to hear/read, but your script shows little complexity that which a SRL member would know how to use/implement.

Seasons greetings, Merry Christmas and we will see you apply again after the New Year :) (<- yes, you can only apply again after the new year, no sooner).


@Justin Please post a whole script in future Application not just pieces. Also Your members application should be your very best don't just apply with any old script you should put your pride in your script. I voted No due to not following the Membership Application Instructions.

E: Rep++ Daniel and Cycrocism

putonajonny

2011-12-28 08:41:14


*FindNormalRandoms;
* if not(LoggedIn) then
* *begin
* * WriteLn('I think we failed a random - I will just Check');
* * LoginPlayer;
* * FindNormalRandoms;
* * if not(LoggedIn) then
* * * begin
* * * * WriteLn('Client has Logged Out So Probably Failed a Random - Terminating Script');
* * * * TerminateScript;
* * * end ;
* * end;
*end;
This part of your check randoms procedure looks very familiar.. I'm not going to vote though because I'm very new into members

E: not sure why the starts came up, I'm posting this from my phone

Justin

2011-12-29 06:09:14

Made some more changes to the application.
Can you all please re-view.

The problems that Daniel made a post on have been fixed. (http://villavu.com/forum/showpost.php?p=870825&postcount=7)

Thanks

Edit: Added Radial Walking to the Snape Grass script with a SPS failsafe, if Radial and SPS fails script will terminate

Hero

2011-12-30 01:04:05

I am going to go out on the limb and vote yes. He has messaged me about further developing his skills and what he needs to learn to script better. I think if a few people that truly understand SRL gave him the help when he asks then he could be a valuable asset to himself and the community. I also suggest you look into less cases. Learn to use ATPAs and TPAs, and hey it wouldn't hurt if you made an include specifically to run your script ;)

Markus

2012-01-01 07:29:22

Seems you're not getting in now..
Closed, you may apply again in 4 weeks.