SRL Archive - MSI Bugs

When using falador vial filler it cant find the pump, just runs a little north of bank and cant find it. Keeps attempting to find falador water pump but cant find it :s tried running it two different times and also heard someone else was having same problem

I'll check this out an edit with what I find…

Probably just have to update the object record.

Yeah. I created it a while ago and it wasn't perfect so Ill see if I can change a few things.

Edit: Bump edit w/e…

This is rather difficult/hard with SPS not being able to put you next to the pump therefore getting you to find other similar objects and yeah …

To MSI Developers:

—-My proposition to fix this problem is to:

• Change Accuracy to a New System. This change will probably be only a few lines of code.
• Instead of accuracy there will be MaxAccuracy and MinAccuracy (You can change the names of the variables).
• So, currently you need a minimum of Accuracy amount of colors.
• With the new system you'd need a minimum of of minaccuracy and and cannot exceed a maximum of maxaccuracy…
• This would solve all issues where there is an excess of colors and all colors are similar (such as the Falador Pump).

From: Yago
Yeah. I created it a while ago and it wasn't perfect so Ill see if I can change a few things.

Edit: Bump edit w/e…

This is rather difficult/hard with SPS not being able to put you next to the pump therefore getting you to find other similar objects and yeah …

To MSI Developers:

—-My proposition to fix this problem is to:

• Change Accuracy to a New System. This change will probably be only a few lines of code.
• Instead of accuracy there will be MaxAccuracy and MinAccuracy (You can change the names of the variables).
• So, currently you need a minimum of Accuracy amount of colors.
• With the new system you'd need a minimum of of minaccuracy and and cannot exceed a maximum of maxaccuracy…
• This would solve all issues where there is an excess of colors and all colors are similar (such as the Falador Pump).

I believe this was brought up long ago actually, not sure if it was public or private conversation though. Regardless, I'm certainly not against it. Perhaps I'll have a look at the best way to add that.

I agree, Yago. Since it won't be needed for all objects we can just do

if (maxAccuracy > 0) then
begin
  if (not inRange(length(TPA), minAccuracy, maxAccuracy)) then
    continue;
end else
  if (length(TPA) < minAccuracy) then
    continue;

That would have to go in MSI_FindObjectsTPA I believe.

It would definitely solve a lot of problems.

Also, like coh3n said we could make it optional so if max value is set to zero then use the old system unless you guys don't mind editing all TMSobjects. If anything, i'd probably help with changing up the object files.

From: Yago
It would definitely solve a lot of problems.

Also, like coh3n said we could make it optional so if max value is set to zero then use the old system unless you guys don't mind editing all TMSobjects. If anything, i'd probably help with changing up the object files.

We could change them all, but the majority of them don't need changing as they work just fine as they are. There may be others that this could be applied to, though.

I feel that even with a different accuracy system, finding this pump will still be a pain and not accurate. The colors in the surrounding area are just too close together. The pump has no unique color to lock onto, I've gone through pixel by pixel and can't get a color that is only on the pump.

From: Camo Developer
I feel that even with a different accuracy system, finding this pump will still be a pain and not accurate. The colors in the surrounding area are just too close together. The pump has no unique color to lock onto, I've gone through pixel by pixel and can't get a color that is only on the pump.

Just use a simple DTM, 2 points, one is on the pump and one is on the path underneath it. Make sure the distance between the points is small. Then get a TPA of all instances of the DTM and wa-la it works.

From: legoace
Just use a simple DTM, 2 points, one is on the pump and one is on the path underneath it. Make sure the distance between the points is small. Then get a TPA of all instances of the DTM and wa-la it works.

Have you ever used a DTM for object finding on the main screen? I don't think it's that simple. VE and EV are just as close to the fountain and well, I'd rather see the location removed then do a lot of work for something that doesn't really need to be done. But, it's not my decision to make. :)

From: Camo Developer
I feel that even with a different accuracy system, finding this pump will still be a pain and not accurate. The colors in the surrounding area are just too close together. The pump has no unique color to lock onto, I've gone through pixel by pixel and can't get a color that is only on the pump.

But are all the colors grouped similarly? Ex. are there 120 blue pixels on the fountain, plus 120 blue pixels in 3 other places on the MS? I have no doubt that it can easily be found, it just wouldn't fit with MSI's current object finding.

I'll have to come back to this thread in a bit.

There is no fountain, the pump is almost the exact color of the road.

From: Coh3n
Have you ever used a DTM for object finding on the main screen? I don't think it's that simple. VE and EV are just as close to the fountain and well, I'd rather see the location removed then do a lot of work for something that doesn't really need to be done. But, it's not my decision to make. :)

I have my own vial filler that is optimized for speed that is using this method, and is working. I only wrote it because MSI's was broken.

From: Camo Developer
I feel that even with a different accuracy system, finding this pump will still be a pain and not accurate. The colors in the surrounding area are just too close together. The pump has no unique color to lock onto, I've gone through pixel by pixel and can't get a color that is only on the pump.

I've counted to differences between after a few edits to the colors between the pump and other similar objects… The accuracy is off by around 100pixels. Max accuracy and min accuracy would eliminate this problem.

Are we going to move forward with taking out this as a vial filler location? Or take Yago's idea and implement it?

I was wondering if anyone has had a look at this recently, it doesnt sem to quite be working yet

If you would of read the posts, you would of realized that we are talking about removing the Falador pump out all together.

We will be adding a maxAccuracy attribute as that will be useful in numerous other situations as well.

I'll come back to this after work today.

From: Kyle Undefined
If you would of read the posts, you would of realized that we are talking about removing the Falador pump out all together.

I did read all of the posts, but their were suggestions that would eliminate the need to remove it, and I was wondering if anyone had still been considering those.

I'd remove it, but maxAccuracy will probably help. ;)