SRL Archive - MSI Bugs

If you're not positioned at the bank, and you have no pickaxe in your inventory, it will not attempt to walk to the bank and grab one; instead it just logs out.

[0:00:26]: World selected.
[0:00:31]: [ ] —— Players Found: 0
[0:00:32]: [ ] —— Scanning for randoms…
[0:00:33]: [ ] —- MSI_SetPlayerLoc
[0:00:33]: [ ] —— MSI_AtLocation
[0:00:34]: [ ] ———- MSI_GetMyPos(): (4750, 4070)
[0:00:34]: [ ] ——– Checking sub-location: Al Kharid Bank
[0:00:34]: [ ] ——– Player not at Al Kharid Bank
[0:00:34]: [ ] —— MSI_AtLocation: False
[0:00:34]: [ ] —— MSI_AtLocation
[0:00:34]: [ ] ———- MSI_GetMyPos(): (4750, 4070)
[0:00:34]: [ ] ——– Checking sub-location: Lumbridge Swamp East Mine
[0:00:34]: [ ] ——– Player is at Lumbridge Swamp East Mine
[0:00:34]: [ ] —— MSI_AtLocation: True
[0:00:34]: [ ] —— Player's location: Lumbridge Swamp East Mine
[0:00:34]: [ ] —- MSI_SetPlayerLoc: True
[0:00:34]: [ ] —- MSI_SetSkillLevels
[0:00:34]: [ ] —— [HOOKED] CharacterStats_FunctionCall: CharacterStats
[0:00:34]: [ ] ———- Bobzilla_GetData: Getting skill levels
[0:00:35]: [ ] ———- Player Found in XML, Updating
[0:00:35]: [ ] —— [HOOKED] CharacterStats_FunctionCall: CharacterStats: 1
[0:00:35]: [ ] —— Mining Level: 36
[0:00:35]: [ ] —- MSI_SetSkillLevels: Finished
[0:00:35]: [ ] —- MSI_SetupWC/Mining
[0:00:35]: [ ] —— Best tool for Mining is Adamant pickaxe
[0:00:36]: [ ] —— MSI_FindTool
[0:00:36]: [ ] ——– Searching Equipment tab
[0:00:36]: [ ] ——– Failed to find DTM of Adamant pickaxe
[0:00:36]: [ ] —— MSI_FindTool: False
[0:00:36]: [ ] —— MSI_FindTool
[0:00:36]: [ ] ——– Searching Equipment tab
[0:00:36]: [ ] ——– Failed to find DTM of Mithril pickaxe
[0:00:36]: [ ] —— MSI_FindTool: False
[0:00:36]: [ ] —— MSI_FindTool
[0:00:36]: [ ] ——– Searching Equipment tab
[0:00:36]: [ ] ——– Failed to find DTM of Steel pickaxe
[0:00:36]: [ ] —— MSI_FindTool: False
[0:00:36]: [ ] —— MSI_FindTool
[0:00:36]: [ ] ——– Searching Equipment tab
[0:00:36]: [ ] ——– Failed to find DTM of Iron pickaxe
[0:00:36]: [ ] —— MSI_FindTool: False
[0:00:36]: [ ] —— MSI_FindTool
[0:00:36]: [ ] ——– Searching Equipment tab
[0:00:36]: [ ] ——– Failed to find DTM of Bronze pickaxe
[0:00:36]: [ ] —— MSI_FindTool: False
[0:00:36]: [ ] —— Best tool for Mining is Adamant pickaxe
[0:00:38]: [ ] —— MSI_FindTool
[0:00:38]: [ ] ——– Searching Inventory tab
[0:00:38]: [ ] ——– Failed to find DTM of Adamant pickaxe
[0:00:38]: [ ] —— MSI_FindTool: False
[0:00:38]: [ ] —— MSI_FindTool
[0:00:38]: [ ] ——– Searching Inventory tab
[0:00:38]: [ ] ——– Failed to find DTM of Mithril pickaxe
[0:00:38]: [ ] —— MSI_FindTool: False
[0:00:38]: [ ] —— MSI_FindTool
[0:00:38]: [ ] ——– Searching Inventory tab
[0:00:38]: [ ] ——– Failed to find DTM of Steel pickaxe
[0:00:38]: [ ] —— MSI_FindTool: False
[0:00:38]: [ ] —— MSI_FindTool
[0:00:38]: [ ] ——– Searching Inventory tab
[0:00:38]: [ ] ——– Failed to find DTM of Iron pickaxe
[0:00:38]: [ ] —— MSI_FindTool: False
[0:00:38]: [ ] —— MSI_FindTool
[0:00:38]: [ ] ——– Searching Inventory tab
[0:00:38]: [ ] ——– Failed to find DTM of Bronze pickaxe
[0:00:38]: [ ] —— MSI_FindTool: False
[0:00:38]: [ ] —- MSI_SetupWC/Mining: False
[0:00:38]: [ ] – MSI_SetupPlayer: False

Looks like the DTMs need to be recreated.

From: Camo Developer
Looks like the DTMs need to be recreated.

No?
He sad he's standing at mine with no pickaxe, and wants script to figure that out (which it did) and then go to the bank and get one (instead if logging out).

Roit?

Ahh, I'm still half asleep I guess.

Just a quick fix, tested with Lumbridge swamp miner.

Change this (lines 82-83 at Woodcutting.simba)

        if (MSI_Locations[MSI_Players[CurrentPlayer].Location].AtBank) then // If player is at a bank 
  Result := MSI_WithdrawBestTool();

To:

        if (not (MSI_Locations[MSI_Players[CurrentPlayer].Location].AtBank)) then // If player is not at a bank
  if MSI_WalkPath(MSI_Scripts[MSI_Players[CurrentPlayer].Scripts[CurrentScript].Name].PathInfo, false) then
    Result := MSI_WithdrawBestTool()
else
  Result := MSI_WithdrawBestTool();  

Also, if Im not mistaken, the DTM detection is done with DDTMs. Honestly we should check for shape once, and only if the shape exists then check for the correct colours, that would be a lot more efficient than checking both spots for all DTMS.

And nice fix.

-RM

There's been a pull request opened for this, so it will be resolved as soon as it's merged.

E: Resolved in the next version.