SRL Archive - SRL Bugs

I'm pretty much done with the actual text getting, at least with shadows - but that required an enormous effort to create shadows of the fonts. (I did it for most, but next time I'll make sure I do it automatically with a self-written program.

Anyway.

• FindText no longer works and neither will FindTextTPA. Therefore I'm using Simba's awesome GetTextATPA.
• Characters now have (or had, I don't recall) shadow.
• Font is still SmallChars.
• Background may be transparent. (Confirm?) Confirmed.
• Characters have some random spacing. (Confirm?)

Now, Java is really giving me a bad time, so I'd appreciate some (32 bit) screenshots of various choose option menus. To (specifically) get: The colours used for text, (gray, brown, etc) and test my shadow functions if required. Colours are required to make a non shadow version.

Here's what I made in 30 mins:

program new;

var
   bmp, bmp2: integer;
   w, h: integer;
   cts: integer;
   i: integer;

   s: String;

   P: TPointArray;
   ATPA: Array of TPointArray;
   ATPATemp: Array of TPointArray;

begin

  LoadFont('SmallCharsNS', True);
  LoadFont('SmallCharsNS', False); // we don't really need this.

  bmp := LoadBitmap('chooseopt.bmp');
  SetTargetBitmap(bmp);
  GetClientDimensions(w, h);
  Writeln('Size: ' + inttostr(w) + ', ' + inttostr(h));

  cts := GetToleranceSpeed;
  SetColorToleranceSpeed(1);
  FindColorsTolerance(P, 591618, 0, 0, w-1, h-1, 5); // Find shadows
  // Replace this with multiple FindColorsTolerance + CombineTPA for non-shadow OCR.
  SetColorToleranceSpeed(cts);

  ATPA := SplitTPAEx(P, 15, 2); // Split per line.
  SortATPAFromFirstPoint(ATPA, Point(0,0)); // Sort, SplitTPAEx messes stuff up

  bmp2 := CopyBitmap(bmp);

  writeln(length(atpa));
  DrawATPABitmap(bmp2, ATPA);


  DisplayDebugImgWindow(w, h);
  DrawBitmapDebugImg(bmp2);
  DisplayDebugImgWindow(w, h);

  SaveBitmap(bmp2, 'test.bmp');
  for i := 0 to high(ATPA) do
  begin
    P := ATPA[i];
    ATPATemp := SplitTPAEx(P, 2, 10); // Split one into characters
    SortTPAFrom(P, Point(0, 0)); // Sort SplitTPA messes stuff up
    SortATPAFromFirstPoint(ATPATemp, P[0]); // More Sort

    DrawATPABitmap(bmp2, ATPATemp);

    s := GetTextATPA(ATPATemp, 5, 'SmallCharsNS_s'); // Replace this with 'SmallChars' for non shadow OCR
    writeln(s);
    setlength(atpatemp,0);
    setlength(p,0);
  end;

  SaveBitmap(bmp2, 'test_split.bmp');

  SetDesktopAsClient;
  FreeBitmap(bmp);
end.

You need SmallCharsNS in your Fonts: http://wizzup.org/SmallCharsNS.zip (I just added shadows, in the future the shadows will not be required in the bitmaps themselves. (BTW don't use this SmallCharsNS font in combination with BitmapFromText, it will fail)

So, what do we need to finish this?

Basically:

• Retrieve the ChooseOption area
• Call the above code on it and make it return a string array + position of characters.
• Call pos() on the string array, return the position of the first hit.

That's it. The above code can be adjusted to include all the colours and now compare to the SmallChars_NS_s but to SmallChars (no _s), you'll have to FindColorsTolerance() each colour, and combine it into one TPA. Then just call all the same splitstuff etc on it. (IOW Replace the one FindColorsTolerance with several FindColorsTolerance combined with CombineTPA)

I'd be grateful if someone else could work on this (as well), I'm done for today. I don't know SRL by heart at the moment and I need to focus my time on something else ATM.

Obviously, all the SaveBitmap/LoadBitmap/Draw(A)TPABitmap/DisplayDebugImg etc should be removed in the actual inclusion.

E: Added some comments to the code.

Looking good Wizzup? Thanks so much for the time you're putting into this… I wish I could be of more help, however, I'm looking at your shadow detection, are you sure that looking around the width/height -1 will do the trick? That MAY need some tinkering, I believe.

….Just my two cents.

Background is definitely transparent.

From: XxX Toxin XxX
Looking good Wizzup? Thanks so much for the time you're putting into this… I wish I could be of more help, however, I'm looking at your shadow detection, are you sure that looking around the width/height -1 will do the trick? That MAY need some tinkering, I believe.

….Just my two cents.

Yeah, the 0, 0, w -1, h - 1 is where the chooseoption SHOULD BE. I just had a cropped bitmap to work with. Obviously that will have to be changed. I'm putting it out here in the hope someone else will pick this up and finish it. I think I did the hard part - pretty much any SRL Developer (or scripter probably) can finish this now. I would have made the colours (not shadow) part too, but I didn't have enough screenshots and java keeps messing with me.

From: kingarabian
Background is definitely transparent.

How transparent? Would colours ``shine through'' enough to bother the OCR? In that case we'd need a more advanced filter, like the one I use for uptext. (but shadows should still work)

From: Wizzup?
Yeah, the 0, 0, w -1, h - 1 is where the chooseoption SHOULD BE. I just had a cropped bitmap to work with. Obviously that will have to be changed. I'm putting it out here in the hope someone else will pick this up and finish it. I think I did the hard part - pretty much any SRL Developer (or scripter probably) can finish this now. I would have made the colours (not shadow) part too, but I didn't have enough screenshots and java keeps messing with me.



How transparent? Would colours ``shine through'' enough to bother the OCR? In that case we'd need a more advanced filter, like the one I use for uptext. (but shadows should still work)

Not too transparent… You have to get close up to the screen and squint.

I think I have came across a weird obscurity…. Check this out guys, I am either going crazy or… I don't know.

So I'm currently working on a Falador West Miner for mining Iron Ores, and I am looking at the ChooseOption menu. Sometimes there is a different overlay on the opacity of the background. Sometimes when I right-click overtop of a rock, there will be very little overlay of the rock through the menu, however sometimes, when the rock is right-clicked, there is zero overlay of the rocks behind the menu.

Here's a few sample images :

I don't believe that it is transparent enough to shine through.

There is some transparency, but I think it changes…
Here are all the images:

http://alt-f4.co.cc/srl/ (my personal site, the files were too big to attach.

From: XxX Toxin XxX
I think I have came across a weird obscurity…. Check this out guys, I am either going crazy or… I don't know.

So I'm currently working on a Falador West Miner for mining Iron Ores, and I am looking at the ChooseOption menu. Sometimes there is a different overlay on the opacity of the background. Sometimes when I right-click overtop of a rock, there will be very little overlay of the rock through the menu, however sometimes, when the rock is right-clicked, there is zero overlay of the rocks behind the menu.

Here's a few sample images :

Yeah same here. It's random. I was going crazy around the G.E right clicking everything. Some NPC's can be seen well (but not too well), while some other NPC's were not shown at all.

From: kingarabian
Yeah same here. It's random. I was going crazy around the G.E right clicking everything. Some NPC's can be seen well (but not too well), while some other NPC's were not shown at all.

Same thing goes with different ores/rocks. I am seeing a pattern with respect to opacity of the overlay'ed menu. The same rock will only overlay two different ways it appears to me and my imperfect human eyes. It will either have a very vivid opacity, something close to 90(maybe even more), or it will not be visible behind the menu AT all.

Thanks for the quick updates Wizzup! Always quick even in the scar days

Thanks for the pictures. They actually helped :)

I have a ChooseOption working but it seems too dodgy then what we want. Will hopefully have it ready tonight.

Guys, watch the option text. The font is constantly moving around, like minimap colors. That's enough to confirm the constant spacing changes.

Here's new ChooseOption, replace both files (removed) as it has to load shadows on SRL call. If you have Bank problems use Bank.scar attached. (adds additional option to click)

Noted code changes:

in Text.scar

Type
  TOptions = Record
    Str: string;
    Bounds: TBox;
  end;   

Function GetChooseOptions(TextType: string): Array of TOptions;
var
   B: TBox;
   TPA, TPA1, TPA2: TPointArray;
   aTPA, tempatpa: T2DPointArray;
   I, L: Integer;
   Colors: TIntegerArray;
begin
  GetClientDimensions(B.X2, B.Y2);
  B.X1 := 0;
  B.Y1 := 0;
  Dec(B.X2);
  Dec(B.Y2);
  FindColorsTolerance(TPA1, 4343893, B.X1, B.Y1, B.X2, B.Y2, 0);
  FindColorsTolerance(TPA2, 3950929, B.X1, B.Y1, B.X2, B.Y2, 0);
  TPA := CombineTPA(TPA1, TPA2);
  If Length(TPA) < 10 Then
    Exit;
  B.X2 := 0;
  B.Y2 := 0;
  aTPA := SplitTPAEx(TPA, 20, 20);
  SortATPASize(aTPA, True);
  B := GetTPABounds(aTPA[0]);

  Colors := [460034];
  SetLength(aTPA, Length(Colors));
  for i := 0 to High(Colors) do
    FindColorsTolerance(aTPA[i], Colors[i], B.X1, B.Y1, B.X2, B.Y2, 5);//yes shadows owns, only 1 color

  TPA := MergeATPA(aTPA);
  aTPA := SplitTPAEx(TPA, 15, 2);
  L := High(aTPA);
  SortATPAFromFirstPoint(ATPA, Point(B.X1, B.y1));

  SetArrayLength(Result, Length(ATPA));
  for i := 0 to high(ATPA) do
  begin
    TPA := ATPA[i];
    tempatpa := SplitTPAEx(TPA, 2, 10); // Split one into characters
    SortTPAFrom(TPA, Point(0, 0)); // Sort SplitTPA messes stuff up
    SortATPAFromFirstPoint(tempatpa, TPA[0]); // More Sort
    Result[i].Str := GetTextATPA(tempatpa, 5, 'SmallCharsNS_s'); // Replace this with 'SmallChars' for non shadow OCR
    Result[i].Bounds := GetTPABounds(ATPA[i]);
    writeln(Result[i].Str);
    setlength(tempatpa,0);
    setlength(TPA,0);
  end;

end;


{*******************************************************************************
function ChooseOptionMultiEx(Texts: TStringArray; TextType: String; Action: fnct_ActionOptions): Boolean;
By: Wizzup?, Nava2, and N1ke!
Description: Finds Popup menu, then clicks on it.
             Will look for the first string first and so on.
             It will search for the Text Type you input valid arguments are
             'action', 'player': The white text
             'npc': The yellow text
             'object': The cyan text
             'all': Searches for all colors of text.
             Will default to 'all'.
*******************************************************************************}
function ChooseOptionMultiEx(Texts: TStringArray; TextType: String; Action: fnct_ActionOptions): Boolean;
var
   B: TBox;
   I, H, ii, L: Integer;
   Options: array of TOptions;
begin
  Result := False;
  Options := GetChooseOptions(TextType);
  H := High(Options);
  L := High(Texts);
  for I := 0 To H do
  begin
    for ii := 0 to L do
      If Pos(Texts[ii], Options[I].Str) > 0 Then
      begin
        Result := True;
        B := Options[I].Bounds;
        case Action of
          ClickLeft: MouseBoxEx(B.x1 + 5, B.Y1, B.x2 - 5, B.Y1 + 5,5, 1);
          Move:      MouseBoxEx(B.x1 + 5, B.Y1, B.x2 - 5, B.Y1 + 5,5, 3);
          Nothing:   begin end;
          else
            srl_warn('ChooseOptionMultiEx', 'ClickRight not a valid click for RS menus!', warn_AllVersions);
        end;
        Exit;
      end;
  end;
  if Action <> Nothing then
  begin
    MMouse(B.X1 - 50, B.Y1 - 50, 40, B.Y2 - B.Y1);
    Wait(200 + Random(100));
  end;

  if (not result) then
    ChooseOptionMultiEx(['Cancel', 'ancel', 'ncel'], 'All', clickLeft);
end;                             

And make sure this is called in SRL.scar

  LoadFont('SmallCharsNS', true);  

Working great and tested thoroughly-ish?
Commit!?
Thanks Narcle for the work!

From: YoHoJo
Working great and tested thoroughly-ish?
Commit!?
Thanks Narcle for the work!

Its not perfect yet. Still shadows missing according to Wizzup. So its just for testing, I'm botting tho lol.

Edit:
Wizzup doesn't have time, so going to commit it

Hmm..Was going over transparency this morning….Where's Menu debugger I wrote… >.>

Commited to svn.

Make sure your fonts get updated.

Let's find out how stable this first quickfix works. :)

Aww yeah!
At least it's a fix even if a quick one, I'm sure people will continue on working to make it more stable.
Will test and post here!

From: Wizzup?
Let's find out how stable this first quickfix works. :)

Badly, I did it. duuuh

Wait, so how can I use your fix Narcle? Your attachments weren't working and then they disappeared when I reloaded the page.

From: legoace
Wait, so how can I use your fix Narcle? Your attachments weren't working and then they disappeared when I reloaded the page.

Narcle said

Commited to svn.

Meaning you can now that them through SRL update.

My fonts updated on Simba, I think just that will do it.
But anyways, you should still (In Simba) update your extensions/SRL and it should work now.

From: YoHoJo
you should still (In Simba) update your extensions/SRL and it should work now.

That's what I thought and did, but SRL banking is still broken (will not choose the option to open the bank). I double-checked by forcing my SRL to update.

From: legoace
That's what I thought and did, but SRL banking is still broken (will not choose the option to open the bank). I double-checked by forcing my SRL to update.

I can confirm this as well :unsure:

Yeah, VE banking remains broken for me as well.

From: Silent SPY
I can confirm this as well :unsure:

This :norris:

SmallChars works - partially. SmallCharsNS doesnt.

From: kingarabian
SmallChars works - partially. SmallCharsNS doesnt.

After the latest SRL update, I get this:

Error: Exception: LoadFont: Directory C:\Simba\Fonts\SmallCharsNS does not exists. at line 188

Line 188:

 LoadFont('SmallCharsNS', true); 

First make sure the font version you get is 10
Second update SRL it should be version 838

Unless Wizzup messed up on fonts update it should work. I'm using it as I type.

Edit:
This was a quick fix. I tested and tried to tweak but its not as accurate as before. Wizzup assumes the shadows for fonts still need to be updated. It currently only uses shadows to get the text next step will be trying to get the letters.

Edit2:
Check your fonts folder, make sure SmallCharsNS is there if not download from first page and try it.

Edit3:
Yes I confirmed he has it extract the Fonts folder into the Fonts folder instead of replacing it. So do the above step you'll have to manually move the folder.

I did what narcle said and it's working now. I had to update srl again tho after i added the new font folder.

From: Narcle
First make sure the font version you get is 10
Second update SRL it should be version 838

Unless Wizzup messed up on fonts update it should work. I'm using it as I type.

Edit:
This was a quick fix. I tested and tried to tweak but its not as accurate as before. Wizzup assumes the shadows for fonts still need to be updated. It currently only uses shadows to get the text next step will be trying to get the letters.

Edit2:
Check your fonts folder, make sure SmallCharsNS is there if not download from first page and try it.

Edit3:
Yes I confirmed he has it extract the Fonts folder into the Fonts folder instead of replacing it. So do the above step you'll have to manually move the folder.

Well after doing some extensive research for 5 minutes, I have come to the conclusion that the Chars are really changing. Sometimes SmallChars works, sometimes SmallCharsNS_s works, and sometimes SmallCharsNS works. So my script would be running perfectly until the fonts change. I guess have it detect all 3 Fonts and see which one is true before acting accordingly?

See, sometimes the inventory ChooseOption works, but the ChooseOption in the bank screen doesn't. And vice versa. Also, sometimes ChooseOptions on NPC's works and sometimes it doesn't.

I deleted my settings.xml to force everything to update. Still no chars, so followed instructions to manually download font. VE banking still fails to open bank.

Edit: Just read the post above. Oh what fun! Minor setback.

From: ozam
I did what narcle said and it's working now. I had to update srl again tho after i added the new font folder.

Confirmed here too. Working now, thanks Narcle and Wizzup?

Thanks narcle that worked for me too


but yea the fonts must be changing, isn't working to select bank

Working here too, updated everything, got compiling error because I didn't DL the fonts in first page, got those, all is well!

If this is already committed I'll be happy to test it.

From: grats
Thanks narcle that worked for me too


but yea the fonts must be changing, isn't working to select bank

^ This, it worked once for me at veb, but failed at clt bank….

EDIT: Flight, it's there, but it added a sub-font directory. Take the folders from Fonts->Fonts and move them to just Fonts. (hope that made sense)

al kharid here

it fails because backgrounds are basically dynamic now? I'd assume that is why

do we use openGL and grab all the letters only with fully transparent backgrounds so all it searches for are the letters? or.. ?

"The automatically split characters are too wide. Try decreasing minspacing"

I keep getting this error when script is trying to access bank, or drop items etc.

Forced all my updates etc. :/

**Edit: replaced fonts main folder with the sub folder as suggested above, all is well now it seems. Thank you**

Why's there a Fonts/Fonts directory? Why not just extract SmallCharsNS like the rest?

[Error] C:\Users\wyn10\Desktop\Simba\Includes\SRL/SRL/core/gametab.scar(976:70): Unknown identifier 'UpCharsEx' at line 975


hmmm..Redid Fonts/Includes from scratch.

From: wyn10
[Error] C:\Users\wyn10\Desktop\Simba\Includes\SRL/SRL/core/gametab.scar(976:70): Unknown identifier 'UpCharsEx' at line 975


hmmm..Redid Fonts/Includes from scratch.

I'm pretty sure that this is not a good solution to this, but it does get things working (definately if they don't use UpCharsEx). I just made a second copy of the UpChars font folder and renamed it to UpCharsEx to make things compile. Now, admittedly, this is probably the wrong font for UpCharsEx, but it does at least get some things working for the time being.

Running 4 Lumby swamp miners, they right click banker and sometimes right click rock, all are working A-Ok for multiple hours each.

Strange. I was trying to run MSI's guild miner earlier and it was having problems with ChooseOption. Is there something that one must actively do to force Simba to update it's fonts other than check for updates and restart it?

Extensions>Update (If you don't see this do View> Extensions Menu)
SRL>Update

And then just download the font in the first page and put it in the proper folder, that's about it, I'm all good here.

Seems to be working fairly well on my end too.

I was looking at the actual behavior of the mouse durring the failed ChooseOption from MSI and it looks as if ChooseOption is detecting the UpText as an option, and attempting to click it, but it goes away before it can click it, so it fails. This would make sense if the UpText font and the option fonts were the same. Anyways, I hope that helps somebody debug this.

From: Coh3n
Why's there a Fonts/Fonts directory? Why not just extract SmallCharsNS like the rest?

I made a mistake, new fonts (only changed structure) uploaded now.

Kingarabian: SmallCharsNS_s is the shadow part of SmallCharsNS. (I just called it new shadow or something, it's a temporary font for sure) What you're experiencing is probably the function not being able to grap all the shadow colours, I guess. So that may need to be tweaked. And we could use a Filter + normal colour OCR to see what one works better, but it'd have to export Simba's uptext filter to the script for that. May do that in Simba 980.

Been chopping Yews for the last two hours using the new Font. Works Perfect. ChooseOption('Chop down Yew') and ChooseOption('Deposit')

From: WT-Fakawi
Been chopping Yews for the last two hours using the new Font. Works Perfect. ChooseOption('Chop down Yew') and ChooseOption('Deposit')

I think the problem is more with interfaces…

yea anything with a bright background shines through and it can't find the text.. that's what I notice

Hey, first time I've used simba in like quite a few weeks guys and I've just updated everything through the updaters in MSI, SRL, SPS and extensions. I now get this error every time I try to start MSI


I've posted here because its to do with the text.

From: Jakkle
Hey, first time I've used simba in like quite a few weeks guys and I've just updated everything through the updaters in MSI, SRL, SPS and extensions. I now get this error every time I try to start MSI


I've posted here because its to do with the text.

Update your fonts?

Q: How DO you MANUALLY (as in force Simba to) update fonts?

From: kingarabian
Update your fonts?

When I started simba it came up with updating fonts, as I was updating everything else, it was fine before that.

Yeah. Any choose option that overlaps an interface for me, 2/3 times fails.

So I had it do something like this, out of 3 possible fonts, find and use the matching one. BUT ITS SLOW AS FUCK.

From: WT-Fakawi
Been chopping Yews for the last two hours using the new Font. Works Perfect. ChooseOption('Chop down Yew') and ChooseOption('Deposit')

Bank Banker wasn't working for me.

From: wyn10
Bank Banker wasn't working for me.

Get some pictures? I had it working for me but there might be changes.

From: YoHoJo
Q: How DO you MANUALLY (as in force Simba to) update fonts?

Edit the settings.xml and change the font <Version> to 0, or so. (yeah, perhaps this should be in the SRL Extension)

It's having some problems with ChooseOption, I believe….

Trying to use bank booth, and failing to click the correct one, if any, for that matter. Anyway, here's a quick screenie of the ChooseOption menu. Anyone else having any similar issues?

From: Narcle
Get some pictures? I had it working for me but there might be changes.

al kharid banking still doesn't work for me.. others were having problems last night

but I posted a screenshot on the other page, msi checks through every banker and then fails to bank

From: XxX Toxin XxX
It's having some problems with ChooseOption, I believe….

Trying to use bank booth, and failing to click the correct one, if any, for that matter. Anyway, here's a quick screenie of the ChooseOption menu. Anyone else having any similar issues?

Yes. half the banks work, half don't

I was thinking it depends on how much gets through the transparency (brighter floor)

Simba ocr uptext filter on chooseopt, quickly adjusted: (you can see how it actually removes the entire background which it also matches as shadow - I hardly changed the colour filter, it should probably be adjusted for chooseoption)


E:

Which is weird because AK banking is working for me =/

If you want to test something edit this line in GetChooseOptions function in Text.scar.

Line 603| Colors := [460034];

Change the color to 460291

This is just to test, we have a _much_ better way in development.
Edit: Wizzup beat me to it. That's what i was talking about.

http://villavu.com/forum/showthread.php?t=68435

good example of what happens to MSI at al kharid bank.. see it can't find the 'ooth'

For Falador West Bank, using "" ChooseOption('Use-'); "" seems to be working perfectly for me now.

From: Wizzup?
Edit the settings.xml and change the font <Version> to 0, or so. (yeah, perhaps this should be in the SRL Extension)

I was having the issue of Simba not automatically updating Fonts, so I tried that suggestion. It did work, well as in it re-updated fonts to version 11(is this the current one?). I am still having errors dealing with not having the correct fonts for some reason I cannot find.

I re-updated everything(literally) including the fonts again, and still cannot get them to update. I am missing a folder UpCharsEx for some reason, and is there any place to find this individually to place in my fonts folder?

From: PatDuffy
I was having the issue of Simba not automatically updating Fonts, so I tried that suggestion. It did work, well as in it re-updated fonts to version 11(is this the current one?). I am still having errors dealing with not having the correct fonts for some reason I cannot find.

I re-updated everything(literally) including the fonts again, and still cannot get them to update. I am missing a folder UpCharsEx for some reason, and is there any place to find this individually to place in my fonts folder?

http://simba.villavu.com/bin/Fonts for a .tar.bz2 of the latest fonts. Can you be more specific as to it not properly installing the fonts? Perhaps you need to run Simba as administrator.

From: Wizzup?
http://simba.villavu.com/bin/Fonts for a .tar.bz2 of the latest fonts. Can you be more specific as to it not properly installing the fonts? Perhaps you need to run Simba as administrator.

Well apparently it was installing the newer fonts correctly, but a function in gametab is trying to use UpCharsEx which doesn't exist.

Warning: In file C:\Simba\Includes\SRL/SRL/core/text.scar: at row: 579, col: 7, pos 22598: ChooseOption is NOT accelerated
[Error] C:\Simba\Includes\SRL/SRL/core/gametab.scar(976:70): Unknown identifier 'UpCharsEx' at line 975
Compiling failed.

I'm probably missing something that's really obvious here, but I've been searching for fixes before I actually asked. There are several functions that give me this error, as I've tried to comment out the trouble function. I honestly might have messed something up on my end, as I've been tinkering with things trying to fix it.

From: Narcle
Get some pictures? I had it working for me but there might be changes.

http://villavu.com/forum/showpost.php?p=852166&postcount=8