SRL Archive - RS3 Outdated / Broken Scripts

Description:
Pond-Fisher, the script to aid lower level'd fishers & chefs. This script will swiftly train your Fishing level, with the option to cook all the fish you catch as well. Train your Fishing/Cooking/Woodcutting/and Firemaking levels with ease!

Features:

• Powerfishes or Fish 'n cook crayfish at the Lumbridge pond (near the west chicken pen)
• 100% color
• Fast and accurate object/item/location finding
• Solid break system (By Echo_)
• World switching option (Switch worlds after every break)
• SRL Stats
• Failsafes to ensure endurance

How to use:

• Start near the Lumbridge pond (west of the chicken pen)
• For powerfishing already have a crayfish cage in your first inventory slot
• For fish 'n cook have a [crayfish cage, hatchet, tinderbox] in your first 3 inventory slots

Updates:

V1.1:

• MakeFire patched up
• Lessened anti-bans
• Drops improved
• Cooking button detection improved
• More precise spot-switching

V1.2:

• Levelup detection while making fires
• Added a slight delay from walking > finding trees
• Slot-dropping modifications
• Generously adjusted failsafe times for chopping trees and making fires
• In case of a failed chopped tree or lit fire, stages will be set appropriately to continue the script

V1.3:

• All items switched to DTMs
• Item-counting is now correct
• Slight change to cooking
• Dropping has been sped up and uses a much more human approach to mouse speeds

V1.4:

• All object-finding redone
• Tools-to-toolbelt added

[End Note]:

As all of my previous scripts were hybrids (Color & Reflection), this would be my first official color script. Alot of people might not find this very useful, but I'm happy to have completed this with such wonderful end results. The purpose of this small project was to familiarize myself more with the SRL include, and I'm sure glad I did! It's amazing what it truly has to offer. I hope more people can learn from this script and begin making their own. Anyways, I hope you enjoy the script, post progress reports if you like!

Please post errors should you come across them.

~Flight

Congratulations on your first color script! :smile: I will check it out in a bit for you, if you would like.

I seemed to have run into a bug of "ItemActivated" not always being accurate. If the script gets stuck for you at the part of making a fire, replace this line:

if (HasLogs(X2,Y2) and ItemActivated(SlotA)) then

with this:

if HasLogs(X2,Y2) then

I'm testing the changes now to make sure that patches things up. Should it not I'll continue experimenting and I'll post any updates/findings.

Edit:
That seemed to have done the trick. I'll do a couple more tweaks to the dropping and put out V1.1.

=-=-=-=-=-= Pond-Fisher 1.0 by Flight =-=-=-=-=-=
Time Running: 1 Hours, 55 Minutes and 56 Seconds
Method: Fish 'n cook
Crayfish caught: 768
Crayfish cooked 660
Breaks: 0
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

^Stopped to test the 1.1 updates.

Does it have to be crayfish? does this work with lobster etc (Sorry, I have no idea what is in that pond)

From: R4nd0m
Does it have to be crayfish? does this work with lobster etc (Sorry, I have no idea what is in that pond)

It's just the pond behind lumby castle, only crayfish.

From: R4nd0m
Does it have to be crayfish? does this work with lobster etc (Sorry, I have no idea what is in that pond)

At the Lumbridge pond only Crayfish are available to fish. I'll be working on more fishing scripts soon, I imagine.

Great Job on releasing this pond-fisher, a color script! Really Well done! Hope to see more,soon! :D

E: oh yeah! The first ever color script, from the top to the bottom! :) Double gratz! :b

Congrats on the 100% color release. I've been waiting to see one from you for a bit. I'm sure you'll find color has it's perks like Reflection. Rep+

Thank you very much, everyone. :) I was very pleased with the results, enough to spark ideas for other scripts.

Version 1.2 released.

Also, thank you onilika for testing this with me. I believe 1.2 has the fix to the problems you previously had. Not only have I fixed the problem you were finding, but any possible way that could have triggered it before has been patched. I've also confirmed this to be absolutely stable on an account with level 1 Fishing/Cooking/Woodcutting/Firemaking.

Awesome script! Looks really nice, will try this soon!

But shouldn't:

FindBitmapsSpiralTolerance(Fish2, MMCX, MMCY, TPA, MIx1, MIy1, MIx2, MIy2, 5);

be

FindBitmapsSpiralTolerance(Fish2, MICX, MICY, TPA, MIx1, MIy1, MIx2, MIy2, 5);

Changed the center coords.

Was having some technical problems, but I think was due to be playing minecraft at same time. I will post a better proggie next time :)

=-=-=-=-=-= Pond-Fisher 1.2 by Flight =-=-=-=-=-=
Time Running: 1 Hours, 2 Minutes and 18 Seconds
Method: Fish 'n cook
Crayfish caught: 254
Crayfish cooked 180
Breaks: 0
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

E: quick note. Click on ' All ' or 'Game', at the chat, so that the script works perfectly :)

Gratz on your first color script! I have been using your scripts a lot and its great that you have adjusted to all color! Also, I love these multipurpose scripts! Keep up the great work! (Maybe I will test but my laptop is prone to overheating :()

From: masterBB
Awesome script! Looks really nice, will try this soon!

But shouldn't:

FindBitmapsSpiralTolerance(Fish2, MMCX, MMCY, TPA, MIx1, MIy1, MIx2, MIy2, 5);

be

FindBitmapsSpiralTolerance(Fish2, MICX, MICY, TPA, MIx1, MIy1, MIx2, MIy2, 5);

Changed the center coords.

Right you are. That's what I get for easily copying and pasting MM symbol finding… :duh:

Thanks for the feedback, everyone! Today I'll be working on a Lumbridge Fly-fisher (Powerfish / Fish 'n cook) that should prove to be the fastest Fishing xp in F2P. If someone would like to make a walking procedure for getting from the Barbarian village to Edgeville bank I'll happily make a Barbarian fisher/banker!

Looks cool! :)

Could try SPS for walking. I plan on making an updater for it in the near future so it won't be a hassle getting users to download (I hope).

Looks great Flight! Glad to see you're still going at it without reflection. :)

Works good. It messed up when making a fire (it chopped a tree, then lit the fire, but I guess it couldn't find the fire, so it made 2 more fires, then finally found it). After it cooked my inv, I got a quiz while dropping, and then:
Error: Out Of Range at line 637
line being TP := Point(TPA[0].X, TPA[0].Y);

Also I'd suggest chopping down a tree after cooking, and keeping the log in your inv; so it won't have to drop a raw thing every time you go to cook.

It also didn't seem to handle you can't light a fire here, and always has difficulty finding the burning fire. I've lit like 6 fires now and he hasn't found any of them :p

It finally found the fire I was standing ontop of after many tries or logs being burned. http://i.imgur.com/bNKxd.png

It also starts to drop my inv before the last crayfish is cooked, leaving it raw.

Other than that, it seems to work good :D

=-=-=-=-=-= Pond-Fisher 1.2 by Flight =-=-=-=-=-=
Time Running: 1 Hours, 5 Minutes and 48 Seconds
Method: Fish 'n cook
Crayfish caught: 361
Crayfish cooked 213
Breaks: 0
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Looks like a nice script!

From: Harry
Works good. It messed up when making a fire (it chopped a tree, then lit the fire, but I guess it couldn't find the fire, so it made 2 more fires, then finally found it). After it cooked my inv, I got a quiz while dropping, and then:
Error: Out Of Range at line 637
line being TP := Point(TPA[0].X, TPA[0].Y);

Also I'd suggest chopping down a tree after cooking, and keeping the log in your inv; so it won't have to drop a raw thing every time you go to cook.

It also didn't seem to handle you can't light a fire here, and always has difficulty finding the burning fire. I've lit like 6 fires now and he hasn't found any of them :p

It finally found the fire I was standing ontop of after many tries or logs being burned. http://i.imgur.com/bNKxd.png

It also starts to drop my inv before the last crayfish is cooked, leaving it raw.

Other than that, it seems to work good :D

=-=-=-=-=-= Pond-Fisher 1.2 by Flight =-=-=-=-=-=
Time Running: 1 Hours, 5 Minutes and 48 Seconds
Method: Fish 'n cook
Crayfish caught: 361
Crayfish cooked 213
Breaks: 0
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Thank you for the feedback Harry!

I assume the reason for not wanting to cook the fish is it can't find the raw fish rather than the fire itself. I had the problem in Fly-Fisher and I, instead, switched to DTMs and increased their tolerance dramatically. I'll do the same here.

Also the the dropping, yes I remember that problem as well. The spiralbitmaps function seemed to give an inaccurate TPA count twords the item. Again, the DTMs replacement should solve this as well. There will be an update hopefully sometime today, so hang in there!

Congrats on your 1st full color script Flight!

Like harry said sometimes it cut down few trees and try/start to do fire many times before cooking.

Sometimes it also go to next fishing spot without reason doing few round trip.

For me the Power mode ( without cooking ) doesn't work at all. When inventory is full, it go in endless loop doing nothing exept increasing the number of caught in the log.

Exept that flawless for 2h :

=-=-=-=-=-= Pond-Fisher 1.3 by Flight =-=-=-=-=-=
Time Running: 1 Hours, 53 Minutes and 11 Seconds
Method: Fish 'n cook
Crayfish caught: 425
Crayfish cooked 284
Breaks: 0
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Thank a lot for your share I have learn a lot studying your script :)

Powerfish mode, okay I'll look into that today. The fire issue may be due to 15 second limit before exiting the "make-fire" procedure. I could extend this some. Also, make sure your messages is set to "All" so when you get the message "The logs catch and begin to burn" (or whatever) the script will recognize that an initiate the cooking procedure. This is essential.

idk why but i always get


[Error] (651:13): Duplicate identifier 'FISH' at line 650
Compiling failed.

From: beleeive
idk why but i always get


[Error] (651:13): Duplicate identifier 'FISH' at line 650
Compiling failed.

I had this problem today aswell, It was a easy fix just change the word Fish to Fishing, Then it will say it again 2 more times and change all three to Fishing instead of Fish.

Edit:
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
=-=-=-=-=-= Pond-Fisher 1.3 by Flight =-=-=-=-=-=
Time Running: 4 Hours, 25 Minutes and 9 Seconds
Method: Fish 'n cook
Crayfish caught: 1539
Crayfish cooked 1188
Breaks: 0
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Not a bad script, Ran for that long before it got stuck in mime.
I also noticed a few other problems such as not cooking and just sitting there if it can not see the fire, So you might want to make it change camera direction if it can not see fire.

Yes it looks like I'll have to change those words up. I imagine because "Fish" is already defined somewhere within MSI you'll get those errors. I don't because I don't use MSI.

[Error] (660:13): Duplicate identifier 'FISH' at line 659
Compiling failed.
[Error] (660:13): Duplicate identifier 'FISH' at line 659
Compiling failed.
[Error] (660:13): Duplicate identifier 'FISH' at line 659
Compiling failed.this is wut it says when i click run?? (help)

Updated to version 1.4.

can you fish only with this ?

Fish a full inventory and either drop it all or have it chop a tree, make a fire, and cook the fish.

what is average xp fishin n droping ?

I've updated this for SRL 5 tinkering around and using the search function but the script doesn't work right. It fishes fine but then tries to find a tree to cut and kinda wanders around. My tinkering ability ends here.

Update: Uhg having a hard time with this. Guess I picked the wrong script to learn how to do this. I can't keep it from looping around in a circle after the inventory is full. It won't go to the cut down tree part.

Needs to be updated. Not working.

From: Kanyin
I've updated this for SRL 5 tinkering around and using the search function but the script doesn't work right. It fishes fine but then tries to find a tree to cut and kinda wanders around. My tinkering ability ends here.

Update: Uhg having a hard time with this. Guess I picked the wrong script to learn how to do this. I can't keep it from looping around in a circle after the inventory is full. It won't go to the cut down tree part.

Ok I think I can tinker around with it today.

From: Themanhunt1
Needs to be updated. Not working.

Please be specific.

Seriously, specify? You just run it and it doesn't work. I think it's because it has not been updated to SRL5 yet.

From: Themanhunt1
Seriously, specify? You just run it and it doesn't work. I think it's because it has not been updated to SRL5 yet.

So then you're getting compile/run errors? You see, if you would have simply told me that I would have known what the problem is. I'm not a mind reader…

Right, so you now know what's wrong so…help?

I get this:

Exception in Script: Unable to find file 'srl/srl.scar' used from ''

I replace all .scar with .simba and it gives:

Exception in Script: Unable to find file 'SRL/SRL/Misc/stats.simba' used from ''

So can't run it.

From: Themanhunt1
Right, so you now know what's wrong so…help?

I get this:

Exception in Script: Unable to find file 'srl/srl.scar' used from ''

I replace all .scar with .simba and it gives:

Exception in Script: Unable to find file 'SRL/SRL/Misc/stats.simba' used from ''

So can't run it.

= Not updated to SRL 5 please be specific and not a douchebag..

~Home

It compiles fine but when I run it, it gets an error on this line.

TP := Point(TPA[0].X, TPA[0].Y);  

The the CheckDist procedure

The debugbox says…

Compiled successfully in 375 ms.
SRL Compiled in 0 msec
SMART Initialized.
Loaded: Server 86, Members: True, Signed: True, Super Detail: False.
=-=-=-=-=-= Pond-Fisher 1.4 by Flight =-=-=-=-=-=
Time Running: 5 Seconds
Method: Powerfishing
Crayfish caught: 0
Breaks: 0
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Error: Out Of Range at line 735
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap]

Other than that the script looks really nice. Great job.

From: Home
= Not updated to SRL 5 please be specific and not a douchebag..

~Home

But all you do to check for this bug is…open in Simba…run….there's your bug. I would have though that this would be the first thing to do?

[Error] (37:32): Type mismatch at line 36
Compiling failed.

line 36 is as follows :

LampSkill:= 'Fishing';

anyone know what i need to do?

From: itzzikonik
line 36 is as follows :

anyone know what i need to do?

This script is overall broken as fuck and a bitch to debug (hardly any output or comments etc.). There are a few things you can do to make the powerfishing side of it work but it still won't move your char when fishing spots change locations.

If you want it to cook then theres a whole nother level of fubar going on.


Change LampSkill:= 'Fishing'; to LampSkill:= SKILL_FISHING;


Every occurrence of

MouseItem(*, true);
MouseItem(*, false);

replace with

MouseItem(*, MOUSE_LEFT);
MouseItem(*, MOUSE_RIGHT);


Every occurence of

SetAngle(true);

replace with

SetAngle(SRL_ANGLE_HIGH);


Insert the following

if(Length(TPA) = 0)then
Exit;

after

TPA := FindSpotsSpirl;

at the start of these procedures

Procedure NextSpot;

Procedure CheckDist;


Change the tolerance in

Function FindSpotsSpirl: TPointArray;

from 5 to like 10 or 12.


Replace

MouseBox(TB.X1, TB.Y1, TB.X2, TB.Y2, 2);

with

MouseBox(TB.X1, TB.Y1, TB.X2, TB.Y2, MOUSE_RIGHT);

in

Procedure FastDropSlot(Slot: Integer);